ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

getCommonEdge as default way of filleting (#6043)

Browse Source 
* Common edge faces into artifact graph

* clean up

* kingdom of tags

* add tests

* hook up tags with edge treatments

* update unit tests

* update e2e

* clean up

* more fix up after main merge

* fmt

* revolve fix

* fix new circular dependency

* fix revolve

* remove numbers from circ deps, makes diffs bad

* sim test updates

* try and get tests working

* update

* Fix tsc error

---------

Co-authored-by: max-mrgrsk <156543465+max-mrgrsk@users.noreply.github.com>
Co-authored-by: max <margorskyi@gmail.com>
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
This commit is contained in:
Kurt Hutten
2025-04-26 14:00:28 +10:00
committed by GitHub
parent 50f8131d83
commit 8de648f0db
224 changed files with 157661 additions and 42680 deletions
Download Patch File Download Diff File Expand all files Collapse all files

140
rust/kcl-lib/tests/sketch_on_face/artifact_graph_flowchart.snap.md
View File

@ -8,13 +8,13 @@ flowchart LR
6["Segment<br>[184, 192, 0]"]
7[Solid2d]
end
subgraph path23 [Path]
23["Path<br>[270, 295, 0]"]
24["Segment<br>[301, 320, 0]"]
25["Segment<br>[326, 345, 0]"]
26["Segment<br>[351, 371, 0]"]
27["Segment<br>[377, 385, 0]"]
28[Solid2d]
subgraph path18 [Path]
18["Path<br>[270, 295, 0]"]
19["Segment<br>[301, 320, 0]"]
20["Segment<br>[326, 345, 0]"]
21["Segment<br>[351, 371, 0]"]
22["Segment<br>[377, 385, 0]"]
23[Solid2d]
end
1["Plane<br>[10, 27, 0]"]
8["Sweep Extrusion<br>[198, 217, 0]"]
@ -25,29 +25,19 @@ flowchart LR
13["Cap Start"]
14["Cap End"]
15["SweepEdge Opposite"]
16["SweepEdge Adjacent"]
16["SweepEdge Opposite"]
17["SweepEdge Opposite"]
18["SweepEdge Adjacent"]
19["SweepEdge Opposite"]
20["SweepEdge Adjacent"]
21["SweepEdge Opposite"]
22["SweepEdge Adjacent"]
29["Sweep Extrusion<br>[391, 410, 0]"]
30[Wall]
31[Wall]
32[Wall]
33[Wall]
34["Cap Start"]
35["Cap End"]
36["SweepEdge Opposite"]
37["SweepEdge Adjacent"]
38["SweepEdge Opposite"]
39["SweepEdge Adjacent"]
40["SweepEdge Opposite"]
41["SweepEdge Adjacent"]
42["SweepEdge Opposite"]
43["SweepEdge Adjacent"]
44["StartSketchOnFace<br>[229, 264, 0]"]
24["Sweep Extrusion<br>[391, 410, 0]"]
25[Wall]
26[Wall]
27[Wall]
28[Wall]
29["Cap Start"]
30["Cap End"]
31["SweepEdge Opposite"]
32["SweepEdge Opposite"]
33["SweepEdge Opposite"]
34["StartSketchOnFace<br>[229, 264, 0]"]
1 --- 2
2 --- 3
2 --- 4
@ -56,17 +46,16 @@ flowchart LR
2 ---- 8
2 --- 7
3 --- 12
3 --- 21
3 --- 22
3 --- 17
3 x--> 13
4 --- 11
4 --- 19
4 --- 20
4 --- 16
4 x--> 13
5 --- 10
5 --- 17
5 --- 18
5 --- 15
5 x--> 13
6 --- 9
6 --- 15
6 --- 16
6 x--> 13
8 --- 9
8 --- 10
8 --- 11
@ -76,43 +65,44 @@ flowchart LR
8 --- 15
8 --- 16
8 --- 17
8 --- 18
8 --- 19
8 --- 20
8 --- 21
8 --- 22
12 --- 23
23 --- 24
23 --- 25
23 --- 26
23 --- 27
23 ---- 29
23 --- 28
12 --- 18
15 <--x 10
15 <--x 14
16 <--x 11
16 <--x 14
17 <--x 12
17 <--x 14
18 --- 19
18 --- 20
18 --- 21
18 --- 22
18 ---- 24
18 --- 23
19 --- 28
19 --- 33
19 x--> 29
20 --- 27
20 --- 32
20 x--> 29
21 --- 26
21 --- 31
21 x--> 29
22 --- 25
22 x--> 29
24 --- 25
24 --- 26
24 --- 27
24 --- 28
24 --- 29
24 --- 30
24 --- 31
24 --- 32
24 --- 33
24 --- 42
24 --- 43
25 --- 32
25 --- 40
25 --- 41
26 --- 31
26 --- 38
26 --- 39
27 --- 30
27 --- 36
27 --- 37
29 --- 30
29 --- 31
29 --- 32
29 --- 33
29 --- 34
29 --- 35
29 --- 36
29 --- 37
29 --- 38
29 --- 39
29 --- 40
29 --- 41
29 --- 42
29 --- 43
12 <--x 44
31 <--x 26
31 <--x 30
32 <--x 27
32 <--x 30
33 <--x 28
33 <--x 30
12 <--x 34
```