ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

new sweep default (#6965)

Browse Source 
snaps

Signed-off-by: Jess Frazelle <github@jessfraz.com>
This commit is contained in:
Jess Frazelle
2025-05-15 04:50:55 -07:00
committed by GitHub
parent 4fe880a970
commit 94f194a984
13 changed files with 31 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/kcl-std/functions/std-clone.md
View File

File diff suppressed because one or more lines are too long

6
docs/kcl-std/functions/std-helix.md
View File

File diff suppressed because one or more lines are too long

4
docs/kcl-std/std.json
View File

@ -251786,7 +251786,7 @@
}
},
"required": false,
"description": "What is the sweep relative to? Can be either 'sketchPlane' or 'trajectoryCurve'. Defaults to sketchPlane.",
"description": "What is the sweep relative to? Can be either 'sketchPlane' or 'trajectoryCurve'. Defaults to trajectoryCurve.",
"labelRequired": true
},
{
@ -256720,7 +256720,7 @@
false
],
[
"// Create a spring by sweeping around a helix path.\n\n// Create a helix around the Z axis.\nhelixPath = helix(\n angleStart = 0,\n ccw = true,\n revolutions = 4,\n length = 10,\n radius = 5,\n axis = Z,\n)\n\n// Create a spring by sweeping around the helix path.\nspringSketch = startSketchOn(YZ)\n |> circle(center = [0, 0], radius = 1)\n |> sweep(path = helixPath)",
"// Create a spring by sweeping around a helix path.\n\n// Create a helix around the Z axis.\nhelixPath = helix(\n angleStart = 0,\n ccw = true,\n revolutions = 4,\n length = 10,\n radius = 5,\n axis = Z,\n)\n\n// Create a spring by sweeping around the helix path.\nspringSketch = startSketchOn(YZ)\n |> circle(center = [0, 0], radius = 1)\n |> sweep(path = helixPath, relativeTo = \"sketchPlane\")",
false
],
[

4
docs/kcl-std/sweep.md
View File

File diff suppressed because one or more lines are too long

7
rust/kcl-lib/src/std/sweep.rs
View File

@ -112,7 +112,7 @@ pub async fn sweep(exec_state: &mut ExecState, args: Args) -> Result<KclValue, K
/// // Create a spring by sweeping around the helix path.
/// springSketch = startSketchOn(YZ)
/// |> circle( center = [0, 0], radius = 1)
/// |> sweep(path = helixPath)
/// |> sweep(path = helixPath, relativeTo = "sketchPlane")
/// ```
///
/// ```no_run
@ -167,7 +167,7 @@ pub async fn sweep(exec_state: &mut ExecState, args: Args) -> Result<KclValue, K
path = { docs = "The path to sweep the sketch along" },
sectional = { docs = "If true, the sweep will be broken up into sub-sweeps (extrusions, revolves, sweeps) based on the trajectory path components." },
tolerance = { docs = "Tolerance for this operation" },
relative_to = { docs = "What is the sweep relative to? Can be either 'sketchPlane' or 'trajectoryCurve'. Defaults to sketchPlane."},
relative_to = { docs = "What is the sweep relative to? Can be either 'sketchPlane' or 'trajectoryCurve'. Defaults to trajectoryCurve."},
tag_start = { docs = "A named tag for the face at the start of the sweep, i.e. the original sketch" },
tag_end = { docs = "A named tag for the face at the end of the sweep" },
},
@ -191,14 +191,13 @@ async fn inner_sweep(
};
let relative_to = match relative_to.as_deref() {
Some("sketchPlane") => RelativeTo::SketchPlane,
Some("trajectoryCurve") => RelativeTo::TrajectoryCurve,
Some("trajectoryCurve") | None => RelativeTo::TrajectoryCurve,
Some(_) => {
return Err(KclError::Syntax(crate::errors::KclErrorDetails {
source_ranges: vec![args.source_range],
message: "If you provide relativeTo, it must either be 'sketchPlane' or 'trajectoryCurve'".to_owned(),
}))
}
None => RelativeTo::default(),
};
let mut solids = Vec::new();

8
rust/kcl-lib/std/prelude.kcl
View File

@ -83,7 +83,7 @@ export END = 'end'
/// // Create a spring by sweeping around the helix path.
/// springSketch = startSketchOn(YZ)
/// |> circle( center = [0, 0], radius = 0.5)
/// |> sweep(path = helixPath)
/// |> sweep(path = helixPath, relativeTo = "sketchPlane")
/// ```
///
/// ```
@ -104,7 +104,7 @@ export END = 'end'
/// // Create a spring by sweeping around the helix path.
/// springSketch = startSketchOn(XY)
/// |> circle( center = [0, 0], radius = 0.5 )
/// |> sweep(path = helixPath)
/// |> sweep(path = helixPath, relativeTo = "sketchPlane")
/// ```
///
/// ```
@ -124,7 +124,7 @@ export END = 'end'
/// // Create a spring by sweeping around the helix path.
/// springSketch = startSketchOn(XY)
/// |> circle( center = [0, 0], radius = 1 )
/// |> sweep(path = helixPath)
/// |> sweep(path = helixPath, relativeTo = "sketchPlane")
/// ```
///
/// ```
@ -413,7 +413,7 @@ export fn offsetPlane(
/// // Create a spring by sweeping around the helix path.
/// sweepedSpring = clone(springSketch)
/// |> translate(x=100)
/// |> sweep(path = helixPath)
/// |> sweep(path = helixPath, relativeTo = "sketchPlane")
/// ```
///
/// ```kcl

4
rust/kcl-lib/tests/kcl_samples/bench/artifact_commands.snap
View File

@ -5122,7 +5122,7 @@ description: Artifact commands bench.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -5134,7 +5134,7 @@ description: Artifact commands bench.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
}
]

2
rust/kcl-lib/tests/kcl_samples/cold-plate/artifact_commands.snap
View File

@ -906,7 +906,7 @@ description: Artifact commands cold-plate.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{

12
rust/kcl-lib/tests/kcl_samples/cpu-cooler/artifact_commands.snap
View File

@ -5576,7 +5576,7 @@ description: Artifact commands cpu-cooler.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -6111,7 +6111,7 @@ description: Artifact commands cpu-cooler.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -9469,7 +9469,7 @@ description: Artifact commands cpu-cooler.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -9601,7 +9601,7 @@ description: Artifact commands cpu-cooler.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -10120,7 +10120,7 @@ description: Artifact commands cpu-cooler.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -10252,7 +10252,7 @@ description: Artifact commands cpu-cooler.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{

8
rust/kcl-lib/tests/kcl_samples/exhaust-manifold/artifact_commands.snap
View File

@ -1598,7 +1598,7 @@ description: Artifact commands exhaust-manifold.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -1610,7 +1610,7 @@ description: Artifact commands exhaust-manifold.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -1622,7 +1622,7 @@ description: Artifact commands exhaust-manifold.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{
@ -1634,7 +1634,7 @@ description: Artifact commands exhaust-manifold.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{

2
rust/kcl-lib/tests/kcl_samples/utility-sink/artifact_commands.snap
View File

@ -4491,7 +4491,7 @@ description: Artifact commands utility-sink.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{

2
rust/kcl-lib/tests/subtract_regression03/artifact_commands.snap
View File

@ -418,7 +418,7 @@ description: Artifact commands subtract_regression03.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{

2
rust/kcl-lib/tests/subtract_regression05/artifact_commands.snap
View File

@ -395,7 +395,7 @@ description: Artifact commands subtract_regression05.kcl
"trajectory": "[uuid]",
"sectional": false,
"tolerance": 0.0000001,
"relative_to": "sketch_plane"
"relative_to": "trajectory_curve"
}
},
{