ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feature tree loading indicator is too big and requires scroll to see (#6508)

Browse Source 
Fixes #6477
This commit is contained in:
Pierre Jacquier
2025-04-25 15:58:33 -04:00
committed by GitHub
parent a1f31f4348
commit 9547e95e9d
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Auth.tsx
View File

@ -7,7 +7,7 @@ export const Auth = ({ children }: React.PropsWithChildren) => {
const isLoggingIn = authState.matches('checkIfLoggedIn') const isLoggingIn = authState.matches('checkIfLoggedIn')
return isLoggingIn ? ( return isLoggingIn ? (
<Loading> <Loading className="h-screen">
<span data-testid="initial-load">Loading Design Studio...</span> <span data-testid="initial-load">Loading Design Studio...</span>
</Loading> </Loading>
) : ( ) : (

2
src/components/EngineStream.tsx
View File

@ -418,7 +418,7 @@ export const EngineStream = (props: {
{![EngineStreamState.Playing, EngineStreamState.Paused].some( {![EngineStreamState.Playing, EngineStreamState.Paused].some(
(s) => s === engineStreamState.value (s) => s === engineStreamState.value
) && ( ) && (
<Loading dataTestId="loading-engine" className="fixed inset-0"> <Loading dataTestId="loading-engine" className="fixed inset-0 h-screen">
Connecting to engine Connecting to engine
</Loading> </Loading>
)} )}

2
src/components/Loading.tsx
View File

@ -111,7 +111,7 @@ const Loading = ({ children, className, dataTestId }: LoadingProps) => {
return ( return (
<div <div
className={`body-bg flex flex-col items-center justify-center h-screen ${colorClass} ${className}`} className={`body-bg flex flex-col items-center justify-center ${colorClass} ${className}`}
data-testid={dataTestId ? dataTestId : 'loading'} data-testid={dataTestId ? dataTestId : 'loading'}
> >
{isUnrecoverableError ? ( {isUnrecoverableError ? (

2
src/routes/Home.tsx
View File

@ -321,7 +321,7 @@ const Home = () => {
className="flex-1 overflow-y-auto pr-2 pb-24" className="flex-1 overflow-y-auto pr-2 pb-24"
> >
{state?.matches(SystemIOMachineStates.readingFolders) ? ( {state?.matches(SystemIOMachineStates.readingFolders) ? (
<Loading>Loading your Projects...</Loading> <Loading className="h-screen">Loading your Projects...</Loading>
) : ( ) : (
<> <>
{searchResults.length > 0 ? ( {searchResults.length > 0 ? (