ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KCL: Rephrase confusing error msg (#6436)

Browse Source 
Before:

  × undefined value: memory item key `foo` is not defined

Now:

  × undefined value: `foo` is not defined
This commit is contained in:
Adam Chalmers
2025-04-22 15:24:53 -05:00
committed by GitHub
parent 29d6b22d63
commit 9730e3f5b3
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
e2e/playwright/sketch-tests.spec.ts
View File

@ -3295,7 +3295,7 @@ profile003 = startProfileAt([-201.08, 254.17], sketch002)
) )
await editor.expectState({ await editor.expectState({
activeLines: [], activeLines: [],
diagnostics: ['memoryitemkey`badBadBadFn`isnotdefined'], diagnostics: ['`badBadBadFn`isnotdefined'],
highlightedCode: '', highlightedCode: '',
}) })
await expect( await expect(

4
rust/kcl-lib/src/execution/memory.rs
View File

@ -365,7 +365,7 @@ impl ProgramMemory {
} }
Err(KclError::UndefinedValue(KclErrorDetails { Err(KclError::UndefinedValue(KclErrorDetails {
message: format!("memory item key `{}` is not defined", var), message: format!("`{}` is not defined", var),
source_ranges: vec![source_range], source_ranges: vec![source_range],
})) }))
} }
@ -486,7 +486,7 @@ impl ProgramMemory {
} }
Err(KclError::UndefinedValue(KclErrorDetails { Err(KclError::UndefinedValue(KclErrorDetails {
message: format!("memory item key `{}` is not defined", var), message: format!("`{}` is not defined", var),
source_ranges: vec![], source_ranges: vec![],
})) }))
} }

4
rust/kcl-lib/src/execution/mod.rs
View File

@ -1585,7 +1585,7 @@ const answer = returnX()"#;
assert_eq!( assert_eq!(
err, err,
KclError::UndefinedValue(KclErrorDetails { KclError::UndefinedValue(KclErrorDetails {
message: "memory item key `x` is not defined".to_owned(), message: "`x` is not defined".to_owned(),
source_ranges: vec![ source_ranges: vec![
SourceRange::new(64, 65, ModuleId::default()), SourceRange::new(64, 65, ModuleId::default()),
SourceRange::new(97, 106, ModuleId::default()) SourceRange::new(97, 106, ModuleId::default())
@ -1669,7 +1669,7 @@ let shape = layer() |> patternTransform(instances = 10, transform = transform)
assert_eq!( assert_eq!(
err, err,
KclError::UndefinedValue(KclErrorDetails { KclError::UndefinedValue(KclErrorDetails {
message: "memory item key `x` is not defined".to_owned(), message: "`x` is not defined".to_owned(),
source_ranges: vec![SourceRange::new(80, 81, ModuleId::default())], source_ranges: vec![SourceRange::new(80, 81, ModuleId::default())],
}), }),
); );

2
rust/kcl-lib/tests/cube_with_error/execution_error.snap
View File

@ -4,7 +4,7 @@ description: Error from executing cube_with_error.kcl
--- ---
KCL UndefinedValue error KCL UndefinedValue error
× undefined value: memory item key `foo` is not defined × undefined value: `foo` is not defined
╭─[23:1] ╭─[23:1]
22 │ // Error, after creating meaningful output. 22 │ // Error, after creating meaningful output.
23 │ foo 23 │ foo

2
src/lang/executor.test.ts
View File

@ -462,7 +462,7 @@ const theExtrude = startSketchOn(XY)
await expect(exe(code)).rejects.toEqual( await expect(exe(code)).rejects.toEqual(
new KCLError( new KCLError(
'undefined_value', 'undefined_value',
'memory item key `myVarZ` is not defined', '`myVarZ` is not defined',
topLevelRange(129, 135), topLevelRange(129, 135),
[], [],
[], [],