Signed-off-by: Jess Frazelle <github@jessfraz.com>
This commit is contained in:
Jess Frazelle
2025-04-07 14:07:57 -07:00
parent f68892ec0b
commit 97e19a7064
4 changed files with 6632 additions and 5695 deletions

View File

@ -120,7 +120,6 @@ impl ExecutorContext {
.exec_block(program, exec_state, crate::execution::BodyType::Root) .exec_block(program, exec_state, crate::execution::BodyType::Root)
.await; .await;
let new_units = exec_state.length_unit();
let env_ref = if preserve_mem { let env_ref = if preserve_mem {
exec_state.mut_stack().pop_and_preserve_env() exec_state.mut_stack().pop_and_preserve_env()
} else { } else {

View File

@ -162,11 +162,11 @@ pub(crate) async fn do_post_extrude<'a>(
) -> Result<Solid, KclError> { ) -> Result<Solid, KclError> {
// Bring the object to the front of the scene. // Bring the object to the front of the scene.
// See: https://github.com/KittyCAD/modeling-app/issues/806 // See: https://github.com/KittyCAD/modeling-app/issues/806
/*args.batch_modeling_cmd( args.batch_modeling_cmd(
exec_state.next_uuid(), exec_state.next_uuid(),
ModelingCmd::from(mcmd::ObjectBringToFront { object_id: sketch.id }), ModelingCmd::from(mcmd::ObjectBringToFront { object_id: sketch.id }),
) )
.await?;*/ .await?;
let any_edge_id = if let Some(edge_id) = sketch.mirror { let any_edge_id = if let Some(edge_id) = sketch.mirror {
edge_id edge_id
@ -208,8 +208,6 @@ pub(crate) async fn do_post_extrude<'a>(
vec![] vec![]
}; };
println!("face_infos: {:?}", face_infos);
// Face filtering attempt in order to resolve https://github.com/KittyCAD/modeling-app/issues/5328 // Face filtering attempt in order to resolve https://github.com/KittyCAD/modeling-app/issues/5328
// In case of a sectional sweep, empirically it looks that the first n faces that are yielded from the sweep // In case of a sectional sweep, empirically it looks that the first n faces that are yielded from the sweep
// are the ones that work with GetOppositeEdge and GetNextAdjacentEdge, aka the n sides in the sweep. // are the ones that work with GetOppositeEdge and GetNextAdjacentEdge, aka the n sides in the sweep.