[Fix] Created the safest navigate/load/open/please sir i want some more for a .kcl
file (#6867)
* fix: clear scene and bust cache if rust panics * Update onboarding following @jgomez720 * chore: hopefully made a safe navigate to kcl file to call executeAST without a race condition * chore: hopefully made a safe navigate to kcl file to call executeAST without a race condition * fix: clean up * fix: FUCK * fix: FUCK 2.0 * fix: oh boi * fix: oh boi * fix: idk man * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix: take main on this, do not need a single line from my testing code * fix: more PR cleanup from all of the testing code * fix: trying to clean up more, ope this has a lot of other code * fix: PR clean up * fix: trying to get a clean branch, I had multiple other branches in here ope * fix: more cleanup * fix: another one * fix: fixed the comment to be accurate * fix: removed confusing comment --------- Signed-off-by: Jess Frazelle <github@jessfraz.com> Co-authored-by: Frank Noirot <frankjohnson1993@gmail.com> Co-authored-by: Jess Frazelle <github@jessfraz.com>
This commit is contained in:
@ -261,7 +261,14 @@ export const EngineStream = (props: {
|
||||
)
|
||||
.catch(trap)
|
||||
}
|
||||
}, [file?.path])
|
||||
/**
|
||||
* Watch file not file?.path. Watching the object allows us to send the same file.path back to back
|
||||
* and still trigger the executeCode() function. JS should not be doing a cache check on the file path
|
||||
* we should be putting the cache check in Rust.
|
||||
* e.g. We can call `navigate(/file/<>)` or `navigate(/file/<>/settings)` as much as we want and it will
|
||||
* trigger this workflow.
|
||||
*/
|
||||
}, [file])
|
||||
|
||||
const IDLE_TIME_MS = Number(streamIdleMode)
|
||||
|
||||
|
Reference in New Issue
Block a user