ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make the timeout for a WebRTC/WebSocket connection pair configurable (#310)

Browse Source 
Signed-off-by: Paul Tagliamonte <paul@kittycad.io>
This commit is contained in:
Paul Tagliamonte
2023-08-23 16:49:04 -04:00
committed by GitHub
parent c25dd1800c
commit 9dd708db5d
4 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.env.development
View File

@ -1,3 +1,4 @@
VITE_KC_API_WS_MODELING_URL=wss://api.dev.kittycad.io/ws/modeling/commands VITE_KC_API_WS_MODELING_URL=wss://api.dev.kittycad.io/ws/modeling/commands
VITE_KC_API_BASE_URL=https://api.dev.kittycad.io VITE_KC_API_BASE_URL=https://api.dev.kittycad.io
VITE_KC_SITE_BASE_URL=https://dev.kittycad.io VITE_KC_SITE_BASE_URL=https://dev.kittycad.io
VITE_KC_CONNECTION_TIMEOUT_MS=5000

3
.env.production
View File

@ -1,3 +1,4 @@
VITE_KC_API_WS_MODELING_URL=wss://api.kittycad.io/ws/modeling/commands VITE_KC_API_WS_MODELING_URL=wss://api.kittycad.io/ws/modeling/commands
VITE_KC_API_BASE_URL=https://api.kittycad.io VITE_KC_API_BASE_URL=https://api.kittycad.io
VITE_KC_SITE_BASE_URL=https://kittycad.io VITE_KC_SITE_BASE_URL=https://kittycad.io
VITE_KC_CONNECTION_TIMEOUT_MS=15000

2
src/env.ts
View File

@ -8,4 +8,6 @@ export const VITE_KC_API_WS_MODELING_URL = import.meta.env
.VITE_KC_API_WS_MODELING_URL .VITE_KC_API_WS_MODELING_URL
export const VITE_KC_API_BASE_URL = import.meta.env.VITE_KC_API_BASE_URL export const VITE_KC_API_BASE_URL = import.meta.env.VITE_KC_API_BASE_URL
export const VITE_KC_SITE_BASE_URL = import.meta.env.VITE_KC_SITE_BASE_URL export const VITE_KC_SITE_BASE_URL = import.meta.env.VITE_KC_SITE_BASE_URL
export const VITE_KC_CONNECTION_TIMEOUT_MS = import.meta.env
.VITE_KC_CONNECTION_TIMEOUT_MS
export const TEST = import.meta.env.TEST export const TEST = import.meta.env.TEST

7
src/lang/std/engineConnection.ts
View File

@ -1,6 +1,9 @@
import { SourceRange } from '../executor' import { SourceRange } from '../executor'
import { Selections } from '../../useStore' import { Selections } from '../../useStore'
import { VITE_KC_API_WS_MODELING_URL } from '../../env' import {
VITE_KC_API_WS_MODELING_URL,
VITE_KC_CONNECTION_TIMEOUT_MS,
} from '../../env'
import { Models } from '@kittycad/lib' import { Models } from '@kittycad/lib'
import { exportSave } from '../../lib/exportSave' import { exportSave } from '../../lib/exportSave'
import { v4 as uuidv4 } from 'uuid' import { v4 as uuidv4 } from 'uuid'
@ -243,7 +246,7 @@ export class EngineConnection extends EventTarget {
// TODO(paultag): This ought to be both controllable, as well as something // TODO(paultag): This ought to be both controllable, as well as something
// like exponential backoff to have some grace on the backend, as well as // like exponential backoff to have some grace on the backend, as well as
// fix responsiveness for clients that had a weird network hiccup. // fix responsiveness for clients that had a weird network hiccup.
const connectionTimeoutMs = 3000 const connectionTimeoutMs = VITE_KC_CONNECTION_TIMEOUT_MS
setTimeout(() => { setTimeout(() => {
if (this.isReady()) { if (this.isReady()) {