Make z-index relation between sketch scene items explicit and colocated (#5435)

* Set up start of semantic z-index layers in tailwind.config.js

* Use first two active semantic z-index layers to fix just this issue
This commit is contained in:
Frank Noirot
2025-02-20 13:53:35 -05:00
committed by GitHub
parent 5232e1d40a
commit 9f5003cafc
3 changed files with 17 additions and 4 deletions

View File

@ -179,10 +179,7 @@ const Overlays = () => {
// Set a large zIndex, the overlay for hover dropdown menu on line segments needs to render // Set a large zIndex, the overlay for hover dropdown menu on line segments needs to render
// over the length labels on the line segments // over the length labels on the line segments
return ( return (
<div <div className="absolute inset-0 pointer-events-none z-sketchOverlayDropdown">
className="absolute inset-0 pointer-events-none"
style={{ zIndex: '99999999' }}
>
{Object.entries(context.segmentOverlays) {Object.entries(context.segmentOverlays)
.flatMap((a) => .flatMap((a) =>
a[1].map((b) => ({ pathToNodeString: a[0], overlay: b })) a[1].map((b) => ({ pathToNodeString: a[0], overlay: b }))

View File

@ -291,6 +291,7 @@ export class SceneInfra {
this.labelRenderer.domElement.style.position = 'absolute' this.labelRenderer.domElement.style.position = 'absolute'
this.labelRenderer.domElement.style.top = '0px' this.labelRenderer.domElement.style.top = '0px'
this.labelRenderer.domElement.style.pointerEvents = 'none' this.labelRenderer.domElement.style.pointerEvents = 'none'
this.labelRenderer.domElement.className = 'z-sketchSegmentIndicators'
window.addEventListener('resize', this.onWindowResize) window.addEventListener('resize', this.onWindowResize)
this.camControls = new CameraControls( this.camControls = new CameraControls(

View File

@ -43,6 +43,21 @@ module.exports = {
'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue',
sans-serif`, sans-serif`,
}, },
/**
* We want the z-index of major UI areas
* to be consolidated in this one spot,
* so we can make sure they coordinate.
*/
zIndex: {
// TODO change use of `z-<number>` to use these instead
// underlay: '-1',
// tooltip: '1',
// commandBar: '2',
// modal: '3',
sketchSegmentIndicators: '5',
sketchOverlayDropdown: '6',
// top: '99',
},
}, },
}, },
darkMode: 'class', darkMode: 'class',