ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: stabilizing named views e2e tests (#6246)

Browse Source 
* fix: moving toast application state:

* fix: forgot the await on the expect calls, ts didn't yell at me?

* fix: cleaning up the camera move e2e code

* fix: lint,tsc,fmt

* Unblock on macOS for now

---------

Co-authored-by: Frank Noirot <frank@zoo.dev>
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
This commit is contained in:
Kevin Nadro
2025-04-11 09:32:44 -05:00
committed by GitHub
parent 7d3294ff78
commit a07dbc3aac
6 changed files with 71 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/lib/commandBarConfigs/namedViewsConfig.ts
View File

@ -160,10 +160,11 @@ export function createNamedViewsCommand() {
data: {
level: 'project',
value: requestedNamedViews,
toastCallback: () => {
toast.success(`Named view ${requestedView.name} created.`)
},
},
})
toast.success(`Named view ${requestedView.name} created.`)
}
}
}
@ -210,9 +211,11 @@ export function createNamedViewsCommand() {
data: {
level: 'project',
value: rest,
toastCallback: () => {
toast.success(`Named view ${viewToDelete.name} removed.`)
},
},
})
toast.success(`Named view ${viewToDelete.name} removed.`)
} else {
toast.error(`Unable to delete, could not find the named view`)
}
@ -307,6 +310,8 @@ export function createNamedViewsCommand() {
type: 'default_camera_get_settings',
},
})
// We do not have the promise of the engine command for ensuring the camera projection has been completed.
toast.success(`Named view ${name} loaded.`)
} else {
toast.error(`Unable to load named view, could not find named view`)