From a4783d49512682d1174e2e7bf6d6a525df7b0815 Mon Sep 17 00:00:00 2001 From: Pierre Jacquier Date: Mon, 28 Oct 2024 09:41:32 -0400 Subject: [PATCH] Separate debug/release electron-builder to help mac job (#4313) --- .github/workflows/build-test-publish-apps.yml | 42 +++++++++++++------ release-notes.md | 0 2 files changed, 30 insertions(+), 12 deletions(-) create mode 100644 release-notes.md diff --git a/.github/workflows/build-test-publish-apps.yml b/.github/workflows/build-test-publish-apps.yml index c8f8a673c..8506f8327 100644 --- a/.github/workflows/build-test-publish-apps.yml +++ b/.github/workflows/build-test-publish-apps.yml @@ -109,17 +109,8 @@ jobs: platform: linux runs-on: ${{ matrix.os }} env: - APPLE_ID: ${{ secrets.APPLE_ID }} - APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }} - APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_PASSWORD }} - APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }} - CSC_LINK: ${{ secrets.APPLE_CERTIFICATE }} - CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} - CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }} - CSC_FOR_PULL_REQUEST: true VERSION: ${{ github.event_name == 'schedule' && needs.prepare-files.outputs.version || format('v{0}', needs.prepare-files.outputs.version) }} VERSION_NO_V: ${{ needs.prepare-files.outputs.version }} - WINDOWS_CERTIFICATE_THUMBPRINT: F4C9A52FF7BC26EE5E054946F6B11DEEA94C748D steps: - uses: actions/checkout@v4 @@ -181,8 +172,25 @@ jobs: smksp_cert_sync.exe shell: cmd - - name: Build the app - run: yarn electron-builder --config ${{ env.BUILD_RELEASE && '--publish always' || '' }} + - name: Build the app (debug) + if: ${{ env.BUILD_RELEASE == 'false' }} + # electron-builder doesn't have a concept of release vs debug, + # this is just not doing any codesign or release yml generation + run: yarn electron-builder --config + + - name: Build the app (release) + if: ${{ env.BUILD_RELEASE == 'true' }} + env: + APPLE_ID: ${{ secrets.APPLE_ID }} + APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }} + APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_PASSWORD }} + APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }} + CSC_LINK: ${{ secrets.APPLE_CERTIFICATE }} + CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} + CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }} + CSC_FOR_PULL_REQUEST: true + WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }} + run: yarn electron-builder --config --publish always - name: List artifacts in out/ run: ls -R out @@ -226,7 +234,17 @@ jobs: - name: Build the app (updater-test) if: ${{ env.CUT_RELEASE_PR == 'true' }} - run: yarn electron-builder --config ${{ env.BUILD_RELEASE && '--publish always' || '' }} + env: + APPLE_ID: ${{ secrets.APPLE_ID }} + APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }} + APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_PASSWORD }} + APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }} + CSC_LINK: ${{ secrets.APPLE_CERTIFICATE }} + CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} + CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }} + CSC_FOR_PULL_REQUEST: true + WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }} + run: yarn electron-builder --config --publish always - uses: actions/upload-artifact@v3 if: ${{ env.CUT_RELEASE_PR == 'true' }} diff --git a/release-notes.md b/release-notes.md new file mode 100644 index 000000000..e69de29bb