ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

replace tanArc(to) with tanArcToRelative (#3729)

Browse Source 
* replace tanArc(to) with tanArcToRelative

Closes #3319

* Handle invalid tanArcs
This commit is contained in:
Adam Chalmers
2024-08-30 13:44:20 -05:00
committed by GitHub
parent 403e074249
commit a4cf68c661
11 changed files with 7688 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/wasm-lib/tests/executor/main.rs
View File

@ -186,7 +186,7 @@ async fn kcl_test_negative_args() {
async fn kcl_test_basic_tangential_arc_with_point() {
let code = r#"const boxSketch = startSketchAt([0, 0])
|> line([0, 10], %)
|> tangentialArc([-5, 5], %)
|> tangentialArcToRelative([-5, 5], %)
|> line([5, -15], %)
|> extrude(10, %)
"#;
@ -715,7 +715,7 @@ async fn kcl_test_error_sketch_on_arc_face() {
let code = r#"fn cube = (pos, scale) => {
const sg = startSketchOn('XY')
|> startProfileAt(pos, %)
|> tangentialArc([0, scale], %, $here)
|> tangentialArcToRelative([0, scale], %, $here)
|> line([scale, 0], %)
|> line([0, -scale], %)
@ -739,7 +739,7 @@ const part002 = startSketchOn(part001, part001.sketchGroup.tags.here)
assert!(result.is_err());
assert_eq!(
result.err().unwrap().to_string(),
r#"type: KclErrorDetails { source_ranges: [SourceRange([280, 333])], message: "Tag `here` is a non-planar surface" }"#
r#"semantic: KclErrorDetails { source_ranges: [SourceRange([94, 139]), SourceRange([222, 238])], message: "could not sketch tangential arc, because its center would be infinitely far away in the X direction" }"#
);
}