fix member expression in object expression (#1992)

* fix member expression in object expression

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* new renders

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* empty trigger

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* empty

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

---------

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

src/wasm-lib/kcl/src/ast/types.rs

@@ -1861,18 +1861,13 @@ impl ObjectExpression {
                 Value::ObjectExpression(object_expression) => object_expression.execute(memory, pipe_info, ctx).await?,
                 Value::ArrayExpression(array_expression) => array_expression.execute(memory, pipe_info, ctx).await?,
                 Value::PipeExpression(pipe_expression) => pipe_expression.get_result(memory, pipe_info, ctx).await?,
+                Value::MemberExpression(member_expression) => member_expression.get_result(memory)?,
                 Value::PipeSubstitution(pipe_substitution) => {
                     return Err(KclError::Semantic(KclErrorDetails {
                         message: format!("PipeSubstitution not implemented here: {:?}", pipe_substitution),
                         source_ranges: vec![pipe_substitution.into()],
                     }));
                 }
-                Value::MemberExpression(member_expression) => {
-                    return Err(KclError::Semantic(KclErrorDetails {
-                        message: format!("MemberExpression not implemented here: {:?}", member_expression),
-                        source_ranges: vec![member_expression.into()],
-                    }));
-                }
                 Value::FunctionExpression(function_expression) => {
                     return Err(KclError::Semantic(KclErrorDetails {
                         message: format!("FunctionExpression not implemented here: {:?}", function_expression),

src/wasm-lib/tests/executor/main.rs

@@ -1929,3 +1929,35 @@ const plumbus0 = make_circle(p, 'a', [0, 0], 1.5)
         .unwrap();
     twenty_twenty::assert_image("tests/executor/outputs/plumbus_fillets.png", &result, 1.0);
 }
+
+#[tokio::test(flavor = "multi_thread")]
+async fn serial_test_member_expression_in_params() {
+    let code = r#"fn capScrew = (originStart, length, dia, capDia, capHeadLength) => {
+  const screwHead = startSketchOn({
+       plane: {
+         origin: {
+          x: originStart[0],
+          y: originStart[1],
+          z: originStart[2],
+         },
+         x_axis: { x: 0, y: 0, z: -1 },
+         y_axis: { x: 1, y: 0, z: 0 },
+         z_axis: { x: 0, y: 1, z: 0 }
+      }
+  })
+    |> circle([0, 0], capDia / 2, %)
+    |> extrude(capHeadLength, %)
+  const screw = startSketchOn(screwHead, "start")
+    |> circle([0, 0], dia / 2, %)
+    |> extrude(length, %)
+  return screw
+}
+
+capScrew([0, 0.5, 0], 50, 37.5, 50, 25)
+"#;
+
+    let result = execute_and_snapshot(code, kittycad::types::UnitLength::Mm)
+        .await
+        .unwrap();
+    twenty_twenty::assert_image("tests/executor/outputs/member_expression_in_params.png", &result, 1.0);
+}