KCL: Convert x/y lines to use keyword arguments (#5615)
Previously, `xLine`, `xLineTo`, `yLine` and `yLineTo` used positional arguments. Now: - `xLineTo` and `yLineTo` have been removed - `xLine` and `yLine` both use keyword arguments: - `length`, optional (i.e. a relative distance along the X or Y axis) - `endAbsolute` optional (i.e. an absolute point along the X or Y axis) - `tag` optional - Exactly one of `length` or `endAbsolute` must be given. Not both, not neither. For example: ``` // Old way |> xLine(6.04, %) |> yLineTo(20, %, $base) // New way |> xLine(length = 6.04) |> yLine(endAbsolute = 20, tag = $base) ``` This also improves some of the general-purpose keyword arguments code in modeling app's TS codebase.
This commit is contained in:
Adam Chalmers
GitHub
@ -2,97 +2,97 @@
|
||||
flowchart LR
|
||||
subgraph path2 [Path]
|
||||
2["Path<br>[284, 322, 0]"]
|
||||
3["Segment<br>[328, 355, 0]"]
|
||||
4["Segment<br>[361, 418, 0]"]
|
||||
5["Segment<br>[424, 442, 0]"]
|
||||
6["Segment<br>[448, 472, 0]"]
|
||||
7["Segment<br>[478, 504, 0]"]
|
||||
8["Segment<br>[510, 602, 0]"]
|
||||
9["Segment<br>[608, 632, 0]"]
|
||||
10["Segment<br>[638, 696, 0]"]
|
||||
11["Segment<br>[702, 720, 0]"]
|
||||
12["Segment<br>[726, 739, 0]"]
|
||||
13["Segment<br>[745, 771, 0]"]
|
||||
14["Segment<br>[777, 823, 0]"]
|
||||
15["Segment<br>[829, 836, 0]"]
|
||||
3["Segment<br>[328, 361, 0]"]
|
||||
4["Segment<br>[367, 424, 0]"]
|
||||
5["Segment<br>[430, 457, 0]"]
|
||||
6["Segment<br>[463, 493, 0]"]
|
||||
7["Segment<br>[499, 534, 0]"]
|
||||
8["Segment<br>[540, 632, 0]"]
|
||||
9["Segment<br>[638, 668, 0]"]
|
||||
10["Segment<br>[674, 732, 0]"]
|
||||
11["Segment<br>[738, 765, 0]"]
|
||||
12["Segment<br>[771, 793, 0]"]
|
||||
13["Segment<br>[799, 834, 0]"]
|
||||
14["Segment<br>[840, 886, 0]"]
|
||||
15["Segment<br>[892, 899, 0]"]
|
||||
16[Solid2d]
|
||||
end
|
||||
subgraph path60 [Path]
|
||||
60["Path<br>[1022, 1060, 0]"]
|
||||
61["Segment<br>[1066, 1093, 0]"]
|
||||
62["Segment<br>[1099, 1156, 0]"]
|
||||
63["Segment<br>[1162, 1180, 0]"]
|
||||
64["Segment<br>[1186, 1210, 0]"]
|
||||
65["Segment<br>[1216, 1242, 0]"]
|
||||
66["Segment<br>[1248, 1340, 0]"]
|
||||
67["Segment<br>[1346, 1370, 0]"]
|
||||
68["Segment<br>[1376, 1434, 0]"]
|
||||
69["Segment<br>[1440, 1458, 0]"]
|
||||
70["Segment<br>[1464, 1477, 0]"]
|
||||
71["Segment<br>[1483, 1509, 0]"]
|
||||
72["Segment<br>[1515, 1561, 0]"]
|
||||
73["Segment<br>[1567, 1574, 0]"]
|
||||
60["Path<br>[1085, 1123, 0]"]
|
||||
61["Segment<br>[1129, 1162, 0]"]
|
||||
62["Segment<br>[1168, 1225, 0]"]
|
||||
63["Segment<br>[1231, 1258, 0]"]
|
||||
64["Segment<br>[1264, 1294, 0]"]
|
||||
65["Segment<br>[1300, 1335, 0]"]
|
||||
66["Segment<br>[1341, 1433, 0]"]
|
||||
67["Segment<br>[1439, 1469, 0]"]
|
||||
68["Segment<br>[1475, 1533, 0]"]
|
||||
69["Segment<br>[1539, 1566, 0]"]
|
||||
70["Segment<br>[1572, 1594, 0]"]
|
||||
71["Segment<br>[1600, 1635, 0]"]
|
||||
72["Segment<br>[1641, 1687, 0]"]
|
||||
73["Segment<br>[1693, 1700, 0]"]
|
||||
74[Solid2d]
|
||||
end
|
||||
subgraph path118 [Path]
|
||||
118["Path<br>[1906, 1931, 0]"]
|
||||
119["Segment<br>[1937, 1987, 0]"]
|
||||
120["Segment<br>[1993, 2033, 0]"]
|
||||
121["Segment<br>[2039, 2046, 0]"]
|
||||
118["Path<br>[2032, 2057, 0]"]
|
||||
119["Segment<br>[2063, 2113, 0]"]
|
||||
120["Segment<br>[2119, 2159, 0]"]
|
||||
121["Segment<br>[2165, 2172, 0]"]
|
||||
122[Solid2d]
|
||||
end
|
||||
subgraph path135 [Path]
|
||||
135["Path<br>[2134, 2159, 0]"]
|
||||
136["Segment<br>[2165, 2183, 0]"]
|
||||
137["Segment<br>[2189, 2214, 0]"]
|
||||
138["Segment<br>[2220, 2246, 0]"]
|
||||
139["Segment<br>[2252, 2352, 0]"]
|
||||
140["Segment<br>[2358, 2381, 0]"]
|
||||
141["Segment<br>[2387, 2440, 0]"]
|
||||
142["Segment<br>[2446, 2464, 0]"]
|
||||
143["Segment<br>[2470, 2493, 0]"]
|
||||
144["Segment<br>[2499, 2623, 0]"]
|
||||
145["Segment<br>[2629, 2674, 0]"]
|
||||
146["Segment<br>[2680, 2693, 0]"]
|
||||
147["Segment<br>[2699, 2718, 0]"]
|
||||
135["Path<br>[2260, 2285, 0]"]
|
||||
136["Segment<br>[2291, 2318, 0]"]
|
||||
137["Segment<br>[2324, 2358, 0]"]
|
||||
138["Segment<br>[2364, 2399, 0]"]
|
||||
139["Segment<br>[2405, 2505, 0]"]
|
||||
140["Segment<br>[2511, 2540, 0]"]
|
||||
141["Segment<br>[2546, 2599, 0]"]
|
||||
142["Segment<br>[2605, 2632, 0]"]
|
||||
143["Segment<br>[2638, 2667, 0]"]
|
||||
144["Segment<br>[2673, 2797, 0]"]
|
||||
145["Segment<br>[2803, 2848, 0]"]
|
||||
146["Segment<br>[2854, 2876, 0]"]
|
||||
147["Segment<br>[2882, 2901, 0]"]
|
||||
148[Solid2d]
|
||||
end
|
||||
subgraph path189 [Path]
|
||||
189["Path<br>[3046, 3071, 0]"]
|
||||
190["Segment<br>[3077, 3095, 0]"]
|
||||
191["Segment<br>[3101, 3123, 0]"]
|
||||
192["Segment<br>[3129, 3253, 0]"]
|
||||
193["Segment<br>[3259, 3304, 0]"]
|
||||
194["Segment<br>[3310, 3331, 0]"]
|
||||
195["Segment<br>[3337, 3344, 0]"]
|
||||
189["Path<br>[3229, 3254, 0]"]
|
||||
190["Segment<br>[3260, 3287, 0]"]
|
||||
191["Segment<br>[3293, 3324, 0]"]
|
||||
192["Segment<br>[3330, 3454, 0]"]
|
||||
193["Segment<br>[3460, 3505, 0]"]
|
||||
194["Segment<br>[3511, 3547, 0]"]
|
||||
195["Segment<br>[3553, 3560, 0]"]
|
||||
196[Solid2d]
|
||||
end
|
||||
subgraph path218 [Path]
|
||||
218["Path<br>[3432, 3482, 0]"]
|
||||
219["Segment<br>[3488, 3511, 0]"]
|
||||
220["Segment<br>[3517, 3538, 0]"]
|
||||
221["Segment<br>[3544, 3557, 0]"]
|
||||
222["Segment<br>[3563, 3570, 0]"]
|
||||
218["Path<br>[3648, 3698, 0]"]
|
||||
219["Segment<br>[3704, 3736, 0]"]
|
||||
220["Segment<br>[3742, 3769, 0]"]
|
||||
221["Segment<br>[3775, 3797, 0]"]
|
||||
222["Segment<br>[3803, 3810, 0]"]
|
||||
223[Solid2d]
|
||||
end
|
||||
subgraph path239 [Path]
|
||||
239["Path<br>[3658, 3683, 0]"]
|
||||
240["Segment<br>[3689, 3714, 0]"]
|
||||
241["Segment<br>[3720, 3738, 0]"]
|
||||
242["Segment<br>[3744, 3757, 0]"]
|
||||
243["Segment<br>[3763, 3770, 0]"]
|
||||
239["Path<br>[3898, 3923, 0]"]
|
||||
240["Segment<br>[3929, 3963, 0]"]
|
||||
241["Segment<br>[3969, 3996, 0]"]
|
||||
242["Segment<br>[4002, 4024, 0]"]
|
||||
243["Segment<br>[4030, 4037, 0]"]
|
||||
244[Solid2d]
|
||||
end
|
||||
subgraph path261 [Path]
|
||||
261["Path<br>[4130, 4179, 0]"]
|
||||
262["Segment<br>[4185, 4208, 0]"]
|
||||
263["Segment<br>[4214, 4256, 0]"]
|
||||
264["Segment<br>[4262, 4287, 0]"]
|
||||
265["Segment<br>[4293, 4300, 0]"]
|
||||
261["Path<br>[4397, 4446, 0]"]
|
||||
262["Segment<br>[4452, 4484, 0]"]
|
||||
263["Segment<br>[4490, 4538, 0]"]
|
||||
264["Segment<br>[4544, 4578, 0]"]
|
||||
265["Segment<br>[4584, 4591, 0]"]
|
||||
266[Solid2d]
|
||||
end
|
||||
1["Plane<br>[258, 278, 0]"]
|
||||
17["Sweep Revolve<br>[847, 982, 0]"]
|
||||
17["Sweep Revolve<br>[910, 1045, 0]"]
|
||||
18[Wall]
|
||||
19[Wall]
|
||||
20[Wall]
|
||||
@ -134,8 +134,8 @@ flowchart LR
|
||||
56["SweepEdge Adjacent"]
|
||||
57["SweepEdge Opposite"]
|
||||
58["SweepEdge Adjacent"]
|
||||
59["Plane<br>[996, 1016, 0]"]
|
||||
75["Sweep Extrusion<br>[1580, 1617, 0]"]
|
||||
59["Plane<br>[1059, 1079, 0]"]
|
||||
75["Sweep Extrusion<br>[1706, 1743, 0]"]
|
||||
76[Wall]
|
||||
77[Wall]
|
||||
78[Wall]
|
||||
@ -177,8 +177,8 @@ flowchart LR
|
||||
114["SweepEdge Adjacent"]
|
||||
115["SweepEdge Opposite"]
|
||||
116["SweepEdge Adjacent"]
|
||||
117["Plane<br>[1874, 1900, 0]"]
|
||||
123["Sweep Extrusion<br>[2052, 2083, 0]"]
|
||||
117["Plane<br>[2000, 2026, 0]"]
|
||||
123["Sweep Extrusion<br>[2178, 2209, 0]"]
|
||||
124[Wall]
|
||||
125[Wall]
|
||||
126[Wall]
|
||||
@ -190,7 +190,7 @@ flowchart LR
|
||||
132["SweepEdge Adjacent"]
|
||||
133["SweepEdge Opposite"]
|
||||
134["SweepEdge Adjacent"]
|
||||
149["Sweep Extrusion<br>[2724, 2755, 0]"]
|
||||
149["Sweep Extrusion<br>[2907, 2938, 0]"]
|
||||
150[Wall]
|
||||
151[Wall]
|
||||
152[Wall]
|
||||
@ -229,8 +229,8 @@ flowchart LR
|
||||
185["SweepEdge Adjacent"]
|
||||
186["SweepEdge Opposite"]
|
||||
187["SweepEdge Adjacent"]
|
||||
188["Plane<br>[3013, 3040, 0]"]
|
||||
197["Sweep Extrusion<br>[3350, 3381, 0]"]
|
||||
188["Plane<br>[3196, 3223, 0]"]
|
||||
197["Sweep Extrusion<br>[3566, 3597, 0]"]
|
||||
198[Wall]
|
||||
199[Wall]
|
||||
200[Wall]
|
||||
@ -251,7 +251,7 @@ flowchart LR
|
||||
215["SweepEdge Adjacent"]
|
||||
216["SweepEdge Opposite"]
|
||||
217["SweepEdge Adjacent"]
|
||||
224["Sweep Extrusion<br>[3576, 3607, 0]"]
|
||||
224["Sweep Extrusion<br>[3816, 3847, 0]"]
|
||||
225[Wall]
|
||||
226[Wall]
|
||||
227[Wall]
|
||||
@ -266,7 +266,7 @@ flowchart LR
|
||||
236["SweepEdge Adjacent"]
|
||||
237["SweepEdge Opposite"]
|
||||
238["SweepEdge Adjacent"]
|
||||
245["Sweep Extrusion<br>[3776, 3826, 0]"]
|
||||
245["Sweep Extrusion<br>[4043, 4093, 0]"]
|
||||
246[Wall]
|
||||
247[Wall]
|
||||
248[Wall]
|
||||
@ -281,8 +281,8 @@ flowchart LR
|
||||
257["SweepEdge Adjacent"]
|
||||
258["SweepEdge Opposite"]
|
||||
259["SweepEdge Adjacent"]
|
||||
260["Plane<br>[4097, 4124, 0]"]
|
||||
267["Sweep Extrusion<br>[4306, 4338, 0]"]
|
||||
260["Plane<br>[4364, 4391, 0]"]
|
||||
267["Sweep Extrusion<br>[4597, 4629, 0]"]
|
||||
268[Wall]
|
||||
269[Wall]
|
||||
270[Wall]
|
||||
@ -297,9 +297,9 @@ flowchart LR
|
||||
279["SweepEdge Adjacent"]
|
||||
280["SweepEdge Opposite"]
|
||||
281["SweepEdge Adjacent"]
|
||||
282["StartSketchOnFace<br>[2097, 2128, 0]"]
|
||||
283["StartSketchOnFace<br>[3395, 3426, 0]"]
|
||||
284["StartSketchOnFace<br>[3621, 3652, 0]"]
|
||||
282["StartSketchOnFace<br>[2223, 2254, 0]"]
|
||||
283["StartSketchOnFace<br>[3611, 3642, 0]"]
|
||||
284["StartSketchOnFace<br>[3861, 3892, 0]"]
|
||||
1 --- 2
|
||||
2 --- 3
|
||||
2 --- 4
|
||||
|
||||
Reference in New Issue
Block a user