KCL: Convert x/y lines to use keyword arguments (#5615)

Previously, `xLine`, `xLineTo`, `yLine` and `yLineTo` used positional arguments. Now:

- `xLineTo` and `yLineTo` have been removed
- `xLine` and `yLine` both use keyword arguments:
  - `length`, optional (i.e. a relative distance along the X or Y axis)
  - `endAbsolute` optional (i.e. an absolute point along the X or Y axis)
  - `tag` optional
- Exactly one of `length` or `endAbsolute` must be given. Not both, not neither.

For example:

```
// Old way
|> xLine(6.04, %)
|> yLineTo(20, %, $base)

// New way
|> xLine(length = 6.04)
|> yLine(endAbsolute = 20, tag = $base)
```

This also improves some of the general-purpose keyword arguments code in modeling app's TS codebase.
This commit is contained in:
Adam Chalmers
2025-03-07 22:07:16 -06:00
committed by GitHub
parent bc3a0e3896
commit aea82e004a
289 changed files with 65906 additions and 67955 deletions

View File

@ -2,58 +2,58 @@
flowchart LR
subgraph path2 [Path]
2["Path<br>[462, 508, 0]"]
3["Segment<br>[514, 555, 0]"]
4["Segment<br>[561, 663, 0]"]
5["Segment<br>[669, 707, 0]"]
6["Segment<br>[713, 748, 0]"]
7["Segment<br>[754, 834, 0]"]
8["Segment<br>[840, 896, 0]"]
9["Segment<br>[902, 941, 0]"]
10["Segment<br>[947, 985, 0]"]
11["Segment<br>[991, 1045, 0]"]
12["Segment<br>[1051, 1075, 0]"]
13["Segment<br>[1081, 1105, 0]"]
14["Segment<br>[1111, 1135, 0]"]
15["Segment<br>[1141, 1165, 0]"]
16["Segment<br>[1171, 1195, 0]"]
17["Segment<br>[1201, 1224, 0]"]
18["Segment<br>[1230, 1254, 0]"]
19["Segment<br>[1260, 1283, 0]"]
20["Segment<br>[1289, 1312, 0]"]
21["Segment<br>[1318, 1414, 0]"]
22["Segment<br>[1420, 1476, 0]"]
23["Segment<br>[1482, 1489, 0]"]
3["Segment<br>[514, 567, 0]"]
4["Segment<br>[573, 675, 0]"]
5["Segment<br>[681, 734, 0]"]
6["Segment<br>[740, 787, 0]"]
7["Segment<br>[793, 888, 0]"]
8["Segment<br>[894, 965, 0]"]
9["Segment<br>[971, 1022, 0]"]
10["Segment<br>[1028, 1081, 0]"]
11["Segment<br>[1087, 1156, 0]"]
12["Segment<br>[1162, 1201, 0]"]
13["Segment<br>[1207, 1237, 0]"]
14["Segment<br>[1243, 1273, 0]"]
15["Segment<br>[1279, 1309, 0]"]
16["Segment<br>[1315, 1345, 0]"]
17["Segment<br>[1351, 1380, 0]"]
18["Segment<br>[1386, 1416, 0]"]
19["Segment<br>[1422, 1451, 0]"]
20["Segment<br>[1457, 1486, 0]"]
21["Segment<br>[1492, 1588, 0]"]
22["Segment<br>[1594, 1650, 0]"]
23["Segment<br>[1656, 1663, 0]"]
24[Solid2d]
end
subgraph path85 [Path]
85["Path<br>[1587, 1631, 0]"]
86["Segment<br>[1637, 1699, 0]"]
87["Segment<br>[1705, 1818, 0]"]
88["Segment<br>[1824, 1944, 0]"]
89["Segment<br>[1950, 2006, 0]"]
90["Segment<br>[2012, 2019, 0]"]
85["Path<br>[1761, 1805, 0]"]
86["Segment<br>[1811, 1873, 0]"]
87["Segment<br>[1879, 1992, 0]"]
88["Segment<br>[1998, 2118, 0]"]
89["Segment<br>[2124, 2180, 0]"]
90["Segment<br>[2186, 2193, 0]"]
91[Solid2d]
end
subgraph path107 [Path]
107["Path<br>[2118, 2163, 0]"]
108["Segment<br>[2169, 2229, 0]"]
109["Segment<br>[2235, 2348, 0]"]
110["Segment<br>[2354, 2474, 0]"]
111["Segment<br>[2480, 2536, 0]"]
112["Segment<br>[2542, 2549, 0]"]
107["Path<br>[2292, 2337, 0]"]
108["Segment<br>[2343, 2403, 0]"]
109["Segment<br>[2409, 2522, 0]"]
110["Segment<br>[2528, 2648, 0]"]
111["Segment<br>[2654, 2710, 0]"]
112["Segment<br>[2716, 2723, 0]"]
113[Solid2d]
end
subgraph path129 [Path]
129["Path<br>[2647, 2692, 0]"]
130["Segment<br>[2698, 2765, 0]"]
131["Segment<br>[2771, 2884, 0]"]
132["Segment<br>[2890, 3010, 0]"]
133["Segment<br>[3016, 3072, 0]"]
134["Segment<br>[3078, 3085, 0]"]
129["Path<br>[2821, 2866, 0]"]
130["Segment<br>[2872, 2939, 0]"]
131["Segment<br>[2945, 3058, 0]"]
132["Segment<br>[3064, 3184, 0]"]
133["Segment<br>[3190, 3246, 0]"]
134["Segment<br>[3252, 3259, 0]"]
135[Solid2d]
end
1["Plane<br>[437, 456, 0]"]
25["Sweep Extrusion<br>[1503, 1533, 0]"]
25["Sweep Extrusion<br>[1677, 1707, 0]"]
26[Wall]
27[Wall]
28[Wall]
@ -113,7 +113,7 @@ flowchart LR
82["SweepEdge Adjacent"]
83["SweepEdge Opposite"]
84["SweepEdge Adjacent"]
92["Sweep Extrusion<br>[2033, 2064, 0]"]
92["Sweep Extrusion<br>[2207, 2238, 0]"]
93[Wall]
94[Wall]
95[Wall]
@ -128,7 +128,7 @@ flowchart LR
104["SweepEdge Adjacent"]
105["SweepEdge Opposite"]
106["SweepEdge Adjacent"]
114["Sweep Extrusion<br>[2564, 2595, 0]"]
114["Sweep Extrusion<br>[2738, 2769, 0]"]
115[Wall]
116[Wall]
117[Wall]
@ -143,7 +143,7 @@ flowchart LR
126["SweepEdge Adjacent"]
127["SweepEdge Opposite"]
128["SweepEdge Adjacent"]
136["Sweep Extrusion<br>[3099, 3129, 0]"]
136["Sweep Extrusion<br>[3273, 3303, 0]"]
137[Wall]
138[Wall]
139[Wall]
@ -158,9 +158,9 @@ flowchart LR
148["SweepEdge Adjacent"]
149["SweepEdge Opposite"]
150["SweepEdge Adjacent"]
151["StartSketchOnFace<br>[1547, 1581, 0]"]
152["StartSketchOnFace<br>[2078, 2112, 0]"]
153["StartSketchOnFace<br>[2609, 2641, 0]"]
151["StartSketchOnFace<br>[1721, 1755, 0]"]
152["StartSketchOnFace<br>[2252, 2286, 0]"]
153["StartSketchOnFace<br>[2783, 2815, 0]"]
1 --- 2
2 --- 3
2 --- 4