KCL: Convert x/y lines to use keyword arguments (#5615)

Previously, `xLine`, `xLineTo`, `yLine` and `yLineTo` used positional arguments. Now:

- `xLineTo` and `yLineTo` have been removed
- `xLine` and `yLine` both use keyword arguments:
  - `length`, optional (i.e. a relative distance along the X or Y axis)
  - `endAbsolute` optional (i.e. an absolute point along the X or Y axis)
  - `tag` optional
- Exactly one of `length` or `endAbsolute` must be given. Not both, not neither.

For example:

```
// Old way
|> xLine(6.04, %)
|> yLineTo(20, %, $base)

// New way
|> xLine(length = 6.04)
|> yLine(endAbsolute = 20, tag = $base)
```

This also improves some of the general-purpose keyword arguments code in modeling app's TS codebase.
This commit is contained in:
Adam Chalmers
2025-03-07 22:07:16 -06:00
committed by GitHub
parent bc3a0e3896
commit aea82e004a
289 changed files with 65906 additions and 67955 deletions

View File

@ -1,5 +1,5 @@
---
source: kcl/src/simulation_tests.rs
source: kcl-lib/src/simulation_tests.rs
description: Operations executed ssi_pattern.kcl
---
[
@ -43,16 +43,16 @@ description: Operations executed ssi_pattern.kcl
}
},
"sourceRange": [
315,
317,
327,
329,
0
]
}
},
"name": "extrude",
"sourceRange": [
287,
318,
299,
330,
0
],
"type": "StdLibCall",
@ -64,8 +64,8 @@ description: Operations executed ssi_pattern.kcl
}
},
"sourceRange": [
295,
304,
307,
316,
0
]
}
@ -80,8 +80,8 @@ description: Operations executed ssi_pattern.kcl
}
},
"sourceRange": [
346,
356,
358,
368,
0
]
},
@ -92,16 +92,16 @@ description: Operations executed ssi_pattern.kcl
"artifact_id": "[uuid]"
},
"sourceRange": [
358,
363,
370,
375,
0
]
}
},
"name": "startSketchOn",
"sourceRange": [
332,
364,
344,
376,
0
],
"type": "StdLibCall",
@ -124,16 +124,16 @@ description: Operations executed ssi_pattern.kcl
}
},
"sourceRange": [
621,
624,
633,
636,
0
]
}
},
"name": "extrude",
"sourceRange": [
604,
625,
616,
637,
0
],
"type": "StdLibCall",