KCL: Convert x/y lines to use keyword arguments (#5615)
Previously, `xLine`, `xLineTo`, `yLine` and `yLineTo` used positional arguments. Now: - `xLineTo` and `yLineTo` have been removed - `xLine` and `yLine` both use keyword arguments: - `length`, optional (i.e. a relative distance along the X or Y axis) - `endAbsolute` optional (i.e. an absolute point along the X or Y axis) - `tag` optional - Exactly one of `length` or `endAbsolute` must be given. Not both, not neither. For example: ``` // Old way |> xLine(6.04, %) |> yLineTo(20, %, $base) // New way |> xLine(length = 6.04) |> yLine(endAbsolute = 20, tag = $base) ``` This also improves some of the general-purpose keyword arguments code in modeling app's TS codebase.
This commit is contained in:
@ -6,9 +6,9 @@ const box_height = 50
|
||||
|
||||
const box_sketch = startSketchOn('XY')
|
||||
|> startProfileAt([0, 0], %)
|
||||
|> xLine(box_width, %, $line1)
|
||||
|> yLine(box_depth, %, $line2)
|
||||
|> xLineTo(profileStartX(%), %, $line3)
|
||||
|> xLine(length = box_width, tag = $line1)
|
||||
|> yLine(length = box_depth, tag = $line2)
|
||||
|> xLine(endAbsolute = profileStartX(%), tag = $line3)
|
||||
|> close(%, $line4)
|
||||
|
||||
const box3D = extrude(box_sketch, length = box_height)
|
Reference in New Issue
Block a user