From af7d0e6b6656729e3fb85f247010391a6533a44e Mon Sep 17 00:00:00 2001 From: Kevin Nadro Date: Thu, 6 Feb 2025 08:43:57 -0600 Subject: [PATCH] fix: added wait for execution done --- e2e/playwright/fixtures/sceneFixture.ts | 24 ------------------------ e2e/playwright/point-click.spec.ts | 3 +-- 2 files changed, 1 insertion(+), 26 deletions(-) diff --git a/e2e/playwright/fixtures/sceneFixture.ts b/e2e/playwright/fixtures/sceneFixture.ts index 9b4f6aee5..aa53aba43 100644 --- a/e2e/playwright/fixtures/sceneFixture.ts +++ b/e2e/playwright/fixtures/sceneFixture.ts @@ -239,30 +239,6 @@ export class SceneFixture { await expect(buttonToTest).toBeVisible() await buttonToTest.click() } - - drawCanvas = async () => { - await this.page.evaluate(() => { - var canvas = document.querySelector('[data-engine="three.js r172"]') - // insert at global document level and pointer events through it... - // make overlay - var parentElement = canvas?.parentElement - var overlayCanvas = canvas?.cloneNode() - this.overlay = overlayCanvas - if (overlayCanvas) { - overlayCanvas.style.top = '0px' - overlayCanvas.style.position = 'absolute' - overlayCanvas.style.pointerEvents = 'none' - overlayCanvas.style.zIndex = '99999999' - document.body.prepend(overlayCanvas) - let ctx = overlayCanvas.getContext('2d') - ctx.lineWidth = 3 - ctx.strokeStyle = '#FF0000' - ctx.beginPath() - ctx.arc(500, 250, 10, 0, 2 * Math.PI, false) - ctx.stroke() - } - }) - } } export async function expectPixelColor( diff --git a/e2e/playwright/point-click.spec.ts b/e2e/playwright/point-click.spec.ts index 57ffacaad..91916883d 100644 --- a/e2e/playwright/point-click.spec.ts +++ b/e2e/playwright/point-click.spec.ts @@ -140,8 +140,6 @@ test.describe('verify sketch on chamfer works', () => { await scene.moveCameraTo(cameraPos, cameraTarget) - await scene.drawCanvas() - await new Promise(() => {}) await test.step('check chamfer selection changes cursor positon', async () => { await expect(async () => { // sometimes initial click doesn't register @@ -206,6 +204,7 @@ test.describe('verify sketch on chamfer works', () => { }, file) await page.setBodyDimensions({ width: 1000, height: 500 }) await homePage.goToModelingScene() + await scene.waitForExecutionDone() const sketchOnAChamfer = _sketchOnAChamfer(page, editor, toolbar, scene)