ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix whole module import deletion in feature tree (#6456)

Browse Source 
* Fix whole module import deletion in feature tree
Fixes #6447

* Delete both

* Fix tests

* Lint

* Clean up for review

* Update src/lang/modifyAst.ts

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* Add extra error case

* Update e2e/playwright/point-click-assemblies.spec.ts

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

---------

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This commit is contained in:
Pierre Jacquier
2025-04-25 10:45:51 -04:00
committed by GitHub
parent 0ef1483e11
commit c501d3bfbf
2 changed files with 102 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
e2e/playwright/point-click-assemblies.spec.ts
View File

@ -358,6 +358,24 @@ test.describe('Point-and-click assemblies tests', () => {
await scene.expectPixelColor(bgColor, midPoint, tolerance)
await scene.expectPixelColor(partColor, moreToTheRightPoint, tolerance)
})
await test.step('Delete the part using the feature tree', async () => {
await toolbar.openPane('feature-tree')
const op = await toolbar.getFeatureTreeOperation('bracket', 0)
await op.click({ button: 'right' })
await page.getByTestId('context-menu-delete').click()
await scene.settled(cmdBar)
await toolbar.closePane('feature-tree')
// Expect empty editor and scene
await toolbar.openPane('code')
await editor.expectEditor.not.toContain('import')
await editor.expectEditor.not.toContain('bracket')
await editor.expectEditor.not.toContain('|> translate')
await editor.expectEditor.not.toContain('|> rotate')
await toolbar.closePane('code')
await scene.expectPixelColorNotToBe(partColor, midPoint, tolerance)
})
}
)
@ -471,6 +489,46 @@ test.describe('Point-and-click assemblies tests', () => {
await toolbar.closePane('code')
await scene.expectPixelColor(partColor, partPoint, tolerance)
})
await test.step('Delete first part using the feature tree', async () => {
await toolbar.openPane('feature-tree')
const op = await toolbar.getFeatureTreeOperation('cube', 0)
await op.click({ button: 'right' })
await page.getByTestId('context-menu-delete').click()
await scene.settled(cmdBar)
await toolbar.closePane('feature-tree')
// Expect only the import statement to be there
await toolbar.openPane('code')
await editor.expectEditor.not.toContain(`import "cube.step" as cube`)
await toolbar.closePane('code')
await editor.expectEditor.toContain(
`
import "${complexPlmFileName}" as cubeSw
cubeSw
`,
{ shouldNormalise: true }
)
await toolbar.closePane('code')
})
await test.step('Delete second part using the feature tree', async () => {
await toolbar.openPane('feature-tree')
const op = await toolbar.getFeatureTreeOperation('cubeSw', 0)
await op.click({ button: 'right' })
await page.getByTestId('context-menu-delete').click()
await scene.settled(cmdBar)
await toolbar.closePane('feature-tree')
// Expect empty editor and scene
await toolbar.openPane('code')
await editor.expectEditor.not.toContain(
`import "${complexPlmFileName}" as cubeSw`
)
await editor.expectEditor.not.toContain('cubeSw')
await toolbar.closePane('code')
await scene.expectPixelColorNotToBe(partColor, midPoint, tolerance)
})
}
)