Add export to cmd bar (#1593)
* Add new exportFile icon * Isolate exportFromEngine command * Naive initial export command * Update types to accept functions for arg defaultValue, required, and options * Make existing helper functions and configs work with new types * Make UI components work with new types support resolving function values and conditional logic * Add full export command to command bar * Replace ExportButton with thin wrapper on cmd bar command * fmt * Fix stale tests and bugs found by good tests * fmt * Update src/components/CommandBar/CommandArgOptionInput.tsx * Update snapshot tests and onboarding wording * Move the panel open click into doExport * Don't need to input storage step in export tests anymore * Remove console logs, fmt, select options if we need to * Increase test timeout --------- Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>
This commit is contained in:
@ -1,7 +1,13 @@
|
||||
import { Models } from '@kittycad/lib'
|
||||
import { CommandSetConfig, KclCommandValue } from 'lib/commandTypes'
|
||||
import { Selections } from 'lib/selections'
|
||||
import { modelingMachine } from 'machines/modelingMachine'
|
||||
|
||||
type OutputFormat = Models['OutputFormat_type']
|
||||
type OutputTypeKey = OutputFormat['type']
|
||||
type ExtractStorageTypes<T> = T extends { storage: infer U } ? U : never
|
||||
type StorageUnion = ExtractStorageTypes<OutputFormat>
|
||||
|
||||
export const EXTRUSION_RESULTS = [
|
||||
'new',
|
||||
'add',
|
||||
@ -11,6 +17,10 @@ export const EXTRUSION_RESULTS = [
|
||||
|
||||
export type ModelingCommandSchema = {
|
||||
'Enter sketch': {}
|
||||
Export: {
|
||||
type: OutputTypeKey
|
||||
storage?: StorageUnion
|
||||
}
|
||||
Extrude: {
|
||||
selection: Selections // & { type: 'face' } would be cool to lock that down
|
||||
// result: (typeof EXTRUSION_RESULTS)[number]
|
||||
@ -26,6 +36,80 @@ export const modelingMachineConfig: CommandSetConfig<
|
||||
description: 'Enter sketch mode.',
|
||||
icon: 'sketch',
|
||||
},
|
||||
Export: {
|
||||
description: 'Export the current model.',
|
||||
icon: 'exportFile',
|
||||
needsReview: true,
|
||||
args: {
|
||||
type: {
|
||||
inputType: 'options',
|
||||
defaultValue: 'gltf',
|
||||
required: true,
|
||||
options: [
|
||||
{ name: 'gLTF', isCurrent: true, value: 'gltf' },
|
||||
{ name: 'OBJ', isCurrent: false, value: 'obj' },
|
||||
{ name: 'STL', isCurrent: false, value: 'stl' },
|
||||
{ name: 'STEP', isCurrent: false, value: 'step' },
|
||||
{ name: 'PLY', isCurrent: false, value: 'ply' },
|
||||
],
|
||||
},
|
||||
storage: {
|
||||
inputType: 'options',
|
||||
defaultValue: (c) => {
|
||||
switch (c.argumentsToSubmit.type) {
|
||||
case 'gltf':
|
||||
return 'embedded'
|
||||
case 'stl':
|
||||
return 'ascii'
|
||||
case 'ply':
|
||||
return 'ascii'
|
||||
default:
|
||||
return undefined
|
||||
}
|
||||
},
|
||||
skip: true,
|
||||
required: (commandContext) =>
|
||||
['gltf', 'stl', 'ply'].includes(
|
||||
commandContext.argumentsToSubmit.type as string
|
||||
),
|
||||
options: (commandContext) => {
|
||||
const type = commandContext.argumentsToSubmit.type as
|
||||
| OutputTypeKey
|
||||
| undefined
|
||||
|
||||
switch (type) {
|
||||
case 'gltf':
|
||||
return [
|
||||
{ name: 'embedded', isCurrent: true, value: 'embedded' },
|
||||
{ name: 'binary', isCurrent: false, value: 'binary' },
|
||||
{ name: 'standard', isCurrent: false, value: 'standard' },
|
||||
]
|
||||
case 'stl':
|
||||
return [
|
||||
{ name: 'binary', isCurrent: false, value: 'binary' },
|
||||
{ name: 'ascii', isCurrent: true, value: 'ascii' },
|
||||
]
|
||||
case 'ply':
|
||||
return [
|
||||
{ name: 'ascii', isCurrent: true, value: 'ascii' },
|
||||
{
|
||||
name: 'binary_big_endian',
|
||||
isCurrent: false,
|
||||
value: 'binary_big_endian',
|
||||
},
|
||||
{
|
||||
name: 'binary_little_endian',
|
||||
isCurrent: false,
|
||||
value: 'binary_little_endian',
|
||||
},
|
||||
]
|
||||
default:
|
||||
return []
|
||||
}
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
Extrude: {
|
||||
description: 'Pull a sketch into 3D along its normal or perpendicular.',
|
||||
icon: 'extrude',
|
||||
|
Reference in New Issue
Block a user