From c8cee6a0dcaedf24e3cd851b487c4a68ff57dafd Mon Sep 17 00:00:00 2001 From: Jace Browning Date: Sat, 12 Apr 2025 14:17:13 -0400 Subject: [PATCH] Fix examples of how to run e2e tests with options (#6303) --- Makefile | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 509c5a97b..44917e567 100644 --- a/Makefile +++ b/Makefile @@ -24,11 +24,6 @@ install: node_modules/.package-lock.json $(CARGO) $(WASM_PACK) ## Install depend node_modules/.package-lock.json: package.json package-lock.json npm install -ifdef POWERSHELL - @ type nul > $@ -else - @ touch $@ -endif $(CARGO): ifdef WINDOWS @@ -129,17 +124,17 @@ test-e2e: test-e2e-$(TARGET) test-e2e-web: install build-web ## Run the web e2e tests @ curl -fs localhost:3000 >/dev/null || ( echo "Error: localhost:3000 not available, 'make run-web' first" && exit 1 ) ifdef E2E_GREP - npm run chrome:test --headed --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES) + npm run chrome:test -- --headed --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES) else - npm run chrome:test --headed --workers='100%' + npm run chrome:test -- --headed --workers='100%' endif .PHONY: test-e2e-desktop test-e2e-desktop: install build-desktop ## Run the desktop e2e tests ifdef E2E_GREP - npm run test:playwright:electron --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES) + npm run test:playwright:electron -- --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES) else - npm run test:playwright:electron --workers='100%' + npm run test:playwright:electron -- --workers='100%' endif ###############################################################################