ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optionally chain error_code

Browse Source 
Something in the Chamfer E2E tests is complaining about an uncaught
error with `error_code` trying to be referenced on something that is
`undefined`. That means that an API request is coming back as not
successful but does not have an actual error in the body of the
response.
This commit is contained in:
Frank Noirot
2025-05-20 19:21:53 -04:00
parent 0753987b5a
commit cac7aa2bee
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/lang/std/engineConnection.ts
View File

@ -998,7 +998,7 @@ class EngineConnection extends EventTarget {
if (!message.success) { if (!message.success) {
const errorsString = message?.errors const errorsString = message?.errors
?.map((error) => { ?.map((error) => {
return ` - ${error.error_code}: ${error.message}` return ` - ${error?.error_code || 'Unknown error'}: ${error?.message || 'Unknown message'}`
}) })
.join('\n') .join('\n')
if (message.request_id) { if (message.request_id) {
@ -1016,7 +1016,7 @@ class EngineConnection extends EventTarget {
} }
const firstError = message?.errors[0] const firstError = message?.errors[0]
if (firstError.error_code === 'auth_token_invalid') { if (firstError?.error_code === 'auth_token_invalid') {
this.state = { this.state = {
type: EngineConnectionStateType.Disconnecting, type: EngineConnectionStateType.Disconnecting,
value: { value: {
@ -1030,7 +1030,7 @@ class EngineConnection extends EventTarget {
this.disconnectAll() this.disconnectAll()
} }
if (firstError.error_code === 'internal_api') { if (firstError?.error_code === 'internal_api') {
this.state = { this.state = {
type: EngineConnectionStateType.Disconnecting, type: EngineConnectionStateType.Disconnecting,
value: { value: {