ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix sketchOnFace point&click for booleans (#6713)

Browse Source 
* fix bool sketchOnFace

* fix chamfer test

* add test

* Kurt composite attempt (#6722)

* composite attempt

* Add forward edge to CSG artifacts in artifact graph

* Fix comment

* Move the doc comments above the attributes

* Fix to update the correct field of Path

* Update output

---------

Co-authored-by: Jonathan Tran <jonnytran@gmail.com>

* use rust defined composite solid edges instead

* Update src/hooks/useEngineConnectionSubscriptions.ts

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* Revert PNG screenshots

* Fix TS formatting

---------

Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This commit is contained in:
Kurt Hutten
2025-05-07 08:25:12 +10:00
committed by GitHub
parent 996517f5c4
commit d187a29e55
17 changed files with 256 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/machines/modelingMachine.ts
View File

@ -305,7 +305,7 @@ export type ModelingMachineEvent =
}
| { type: 'Sketch On Face' }
| {
type: 'Select default plane'
type: 'Select sketch plane'
data: DefaultPlane | ExtrudeFacePlane | OffsetPlane
}
| {
@ -4255,7 +4255,7 @@ export const modelingMachine = setup({
exit: ['hide default planes', 'set selection filter to defaults'],
on: {
'Select default plane': {
'Select sketch plane': {
target: 'animating to plane',
actions: ['reset sketch metadata'],
},
@ -4268,7 +4268,7 @@ export const modelingMachine = setup({
id: 'animate-to-face',
input: ({ event }) => {
if (event.type !== 'Select default plane') return undefined
if (event.type !== 'Select sketch plane') return undefined
return event.data
},