ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix dumb ass logic bug with edge cuts, actually extends edge cuts array versus overwriting it lolz (#3928)

Browse Source 
* dumb ass logic bug with edge cuts

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* change order

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)

* Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)"

This reverts commit 1ad9eb315e.

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)

* Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)"

This reverts commit 4004c9c1db.

* A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)

* Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)"

This reverts commit 57d0d05d06.

---------

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Jess Frazelle
2024-09-19 14:50:36 -07:00
committed by GitHub
parent d8236dd8da
commit d1f9a02ffa
7 changed files with 103 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/wasm-lib/kcl/src/std/chamfer.rs
View File

@ -128,7 +128,6 @@ async fn inner_chamfer(
}
let mut extrude_group = extrude_group.clone();
let mut edge_cuts = Vec::new();
for edge_tag in data.tags {
let edge_id = match edge_tag {
EdgeReference::Uuid(uuid) => uuid,
@ -152,7 +151,7 @@ async fn inner_chamfer(
)
.await?;
edge_cuts.push(EdgeCut::Chamfer {
extrude_group.edge_cuts.push(EdgeCut::Chamfer {
id,
edge_id,
length: data.length,
@ -171,7 +170,5 @@ async fn inner_chamfer(
}
}
extrude_group.edge_cuts = edge_cuts;
Ok(extrude_group)
}