ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KCL: Angled line should use keyword args (#5803)

Browse Source 
We continue migrating KCL stdlib functions to use keyword arguments. Next up is the `angledLine` family of functions (except `angledLineThatIntersects, which will be a quick follow-up).

Before vs. after:

`angledLine({angle = 90, length = 3}, %, $edge)`
  => `angledLine(angle = 90, length = 3, tag = $edge)`

`angledLineOfXLength({angle = 90, length = 3}, %, $edge)`
  => `angledLine(angle = 90, lengthX = 3, tag = $edge)`

`angledLineOfYLength({angle = 90, length = 3}, %, $edge)`
  => `angledLine(angle = 90, lengthY = 3, tag = $edge)`

`angledLineToX({angle = 90, length = 3}, %, $edge)`
  => `angledLine(angle = 90, endAbsoluteX = 3, tag = $edge)`

`angledLineToY({angle = 90, length = 3}, %, $edge)`
  => `angledLine(angle = 90, endAbsoluteY = 3, tag = $edge)`
This commit is contained in:
Adam Chalmers
2025-04-09 14:55:15 -05:00
committed by GitHub
parent b03ca30379
commit d275995dfe
288 changed files with 36142 additions and 40081 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
rust/kcl-lib/tests/kcl_samples/bench/artifact_graph_flowchart.snap.md
View File

@ -191,45 +191,45 @@ flowchart LR
end
subgraph path618 [Path]
618["Path<br>[2632, 2661, 5]"]
619["Segment<br>[2669, 2692, 5]"]
620["Segment<br>[2700, 2725, 5]"]
621["Segment<br>[2733, 2757, 5]"]
622["Segment<br>[2765, 2789, 5]"]
623["Segment<br>[2797, 2819, 5]"]
624["Segment<br>[2827, 2862, 5]"]
625["Segment<br>[2870, 2877, 5]"]
619["Segment<br>[2669, 2704, 5]"]
620["Segment<br>[2712, 2737, 5]"]
621["Segment<br>[2745, 2781, 5]"]
622["Segment<br>[2789, 2813, 5]"]
623["Segment<br>[2821, 2855, 5]"]
624["Segment<br>[2863, 2898, 5]"]
625["Segment<br>[2906, 2913, 5]"]
626[Solid2d]
end
subgraph path650 [Path]
650["Path<br>[3152, 3179, 5]"]
651["Segment<br>[3187, 3206, 5]"]
652["Segment<br>[3214, 3304, 5]"]
650["Path<br>[3188, 3215, 5]"]
651["Segment<br>[3223, 3242, 5]"]
652["Segment<br>[3250, 3340, 5]"]
end
subgraph path654 [Path]
654["Path<br>[3404, 3437, 5]"]
655["Segment<br>[3445, 3464, 5]"]
656["Segment<br>[3472, 3494, 5]"]
657["Segment<br>[3502, 3525, 5]"]
658["Segment<br>[3533, 3553, 5]"]
659["Segment<br>[3561, 3585, 5]"]
660["Segment<br>[3593, 3616, 5]"]
661["Segment<br>[3624, 3631, 5]"]
654["Path<br>[3440, 3473, 5]"]
655["Segment<br>[3481, 3500, 5]"]
656["Segment<br>[3508, 3530, 5]"]
657["Segment<br>[3538, 3561, 5]"]
658["Segment<br>[3569, 3589, 5]"]
659["Segment<br>[3597, 3621, 5]"]
660["Segment<br>[3629, 3652, 5]"]
661["Segment<br>[3660, 3667, 5]"]
662[Solid2d]
end
subgraph path688 [Path]
688["Path<br>[3152, 3179, 5]"]
689["Segment<br>[3187, 3206, 5]"]
690["Segment<br>[3214, 3304, 5]"]
688["Path<br>[3188, 3215, 5]"]
689["Segment<br>[3223, 3242, 5]"]
690["Segment<br>[3250, 3340, 5]"]
end
subgraph path692 [Path]
692["Path<br>[3404, 3437, 5]"]
693["Segment<br>[3445, 3464, 5]"]
694["Segment<br>[3472, 3494, 5]"]
695["Segment<br>[3502, 3525, 5]"]
696["Segment<br>[3533, 3553, 5]"]
697["Segment<br>[3561, 3585, 5]"]
698["Segment<br>[3593, 3616, 5]"]
699["Segment<br>[3624, 3631, 5]"]
692["Path<br>[3440, 3473, 5]"]
693["Segment<br>[3481, 3500, 5]"]
694["Segment<br>[3508, 3530, 5]"]
695["Segment<br>[3538, 3561, 5]"]
696["Segment<br>[3569, 3589, 5]"]
697["Segment<br>[3597, 3621, 5]"]
698["Segment<br>[3629, 3652, 5]"]
699["Segment<br>[3660, 3667, 5]"]
700[Solid2d]
end
1["Plane<br>[333, 353, 5]"]
@ -682,7 +682,7 @@ flowchart LR
615["Sweep Extrusion<br>[2523, 2547, 5]"]
616["Sweep Extrusion<br>[2523, 2547, 5]"]
617["Plane<br>[1205, 1272, 0]"]
627["Sweep Extrusion<br>[3047, 3071, 5]"]
627["Sweep Extrusion<br>[3083, 3107, 5]"]
628[Wall]
629[Wall]
630[Wall]
@ -703,10 +703,10 @@ flowchart LR
645["SweepEdge Adjacent"]
646["SweepEdge Opposite"]
647["SweepEdge Adjacent"]
648["Sweep Extrusion<br>[3047, 3071, 5]"]
649["Plane<br>[3712, 3747, 5]"]
653["Plane<br>[3778, 3807, 5]"]
663["Sweep Sweep<br>[3819, 3846, 5]"]
648["Sweep Extrusion<br>[3083, 3107, 5]"]
649["Plane<br>[3748, 3783, 5]"]
653["Plane<br>[3814, 3843, 5]"]
663["Sweep Sweep<br>[3855, 3882, 5]"]
664[Wall]
665[Wall]
666[Wall]
@ -730,9 +730,9 @@ flowchart LR
684["SweepEdge Adjacent"]
685["SweepEdge Opposite"]
686["SweepEdge Adjacent"]
687["Plane<br>[3712, 3747, 5]"]
691["Plane<br>[3778, 3807, 5]"]
701["Sweep Sweep<br>[3819, 3846, 5]"]
687["Plane<br>[3748, 3783, 5]"]
691["Plane<br>[3814, 3843, 5]"]
701["Sweep Sweep<br>[3855, 3882, 5]"]
702[Wall]
703[Wall]
704[Wall]
@ -764,10 +764,10 @@ flowchart LR
730["StartSketchOnPlane<br>[1657, 1677, 5]"]
731["StartSketchOnPlane<br>[2095, 2115, 5]"]
732["StartSketchOnPlane<br>[2604, 2624, 5]"]
733["StartSketchOnPlane<br>[3124, 3144, 5]"]
734["StartSketchOnPlane<br>[3376, 3396, 5]"]
735["StartSketchOnPlane<br>[3124, 3144, 5]"]
736["StartSketchOnPlane<br>[3376, 3396, 5]"]
733["StartSketchOnPlane<br>[3160, 3180, 5]"]
734["StartSketchOnPlane<br>[3412, 3432, 5]"]
735["StartSketchOnPlane<br>[3160, 3180, 5]"]
736["StartSketchOnPlane<br>[3412, 3432, 5]"]
1 --- 2
2 --- 3
2 --- 4

30
rust/kcl-lib/tests/kcl_samples/bench/ops.snap
View File

@ -1060,8 +1060,8 @@ description: Operations executed bench.kcl
"type": "FunctionCall",
"name": "backSlats",
"functionSourceRange": [
2993,
3084,
3029,
3120,
5
],
"unlabeledArg": null,
@ -1076,7 +1076,7 @@ description: Operations executed bench.kcl
"name": "backSlatsSketch",
"functionSourceRange": [
2580,
2972,
3008,
5
],
"unlabeledArg": null,
@ -1154,8 +1154,8 @@ description: Operations executed bench.kcl
"type": "FunctionCall",
"name": "armRest",
"functionSourceRange": [
3671,
3859,
3707,
3895,
5
],
"unlabeledArg": null,
@ -1194,8 +1194,8 @@ description: Operations executed bench.kcl
"type": "FunctionCall",
"name": "armRestPath",
"functionSourceRange": [
3100,
3325,
3136,
3361,
5
],
"unlabeledArg": null,
@ -1257,8 +1257,8 @@ description: Operations executed bench.kcl
"type": "FunctionCall",
"name": "armRestProfile",
"functionSourceRange": [
3344,
3652,
3380,
3688,
5
],
"unlabeledArg": null,
@ -1318,8 +1318,8 @@ description: Operations executed bench.kcl
"type": "FunctionCall",
"name": "armRest",
"functionSourceRange": [
3671,
3859,
3707,
3895,
5
],
"unlabeledArg": null,
@ -1358,8 +1358,8 @@ description: Operations executed bench.kcl
"type": "FunctionCall",
"name": "armRestPath",
"functionSourceRange": [
3100,
3325,
3136,
3361,
5
],
"unlabeledArg": null,
@ -1421,8 +1421,8 @@ description: Operations executed bench.kcl
"type": "FunctionCall",
"name": "armRestProfile",
"functionSourceRange": [
3344,
3652,
3380,
3688,
5
],
"unlabeledArg": null,