ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix unit test, use kebab-case for url query param

Browse Source
This commit is contained in:
Frank Noirot
2025-01-13 10:42:08 -05:00
parent b30a37a0b3
commit df01c233e4
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/playwright/command-bar-tests.spec.ts
View File

@ -354,7 +354,7 @@ test.describe('Command bar tests', () => {
homePage, homePage,
}) => { }) => {
await test.step(`Prepare and navigate to home page with query params`, async () => { await test.step(`Prepare and navigate to home page with query params`, async () => {
const targetURL = `?create-file&name=test&units=mm&code=ZXh0cnVzaW9uRGlzdGFuY2UgPSAxMg%3D%3D&askToOpenInDesktop` const targetURL = `?create-file&name=test&units=mm&code=ZXh0cnVzaW9uRGlzdGFuY2UgPSAxMg%3D%3D&ask-open-desktop`
await homePage.expectState({ await homePage.expectState({
projectCards: [], projectCards: [],
sortBy: 'last-modified-desc', sortBy: 'last-modified-desc',
@ -413,7 +413,7 @@ test.describe('Command bar tests', () => {
]) ])
}) })
await test.step(`Prepare and navigate to home page with query params`, async () => { await test.step(`Prepare and navigate to home page with query params`, async () => {
const targetURL = `?create-file&name=test&units=mm&code=ZXh0cnVzaW9uRGlzdGFuY2UgPSAxMg%3D%3D&askToOpenInDesktop` const targetURL = `?create-file&name=test&units=mm&code=ZXh0cnVzaW9uRGlzdGFuY2UgPSAxMg%3D%3D&ask-open-desktop`
await homePage.expectState({ await homePage.expectState({
projectCards: [ projectCards: [
{ {

2
src/components/OpenInDesktopAppHandler.test.tsx
View File

@ -39,7 +39,7 @@ describe('OpenInDesktopAppHandler tests', () => {
test(`renders the modal if the query param is present`, () => { test(`renders the modal if the query param is present`, () => {
render( render(
<BrowserRouter> <BrowserRouter>
<TestWrap location="/?askToOpenInDesktop"> <TestWrap location="/?ask-open-desktop">
<p>Dummy app contents</p> <p>Dummy app contents</p>
</TestWrap> </TestWrap>
</BrowserRouter> </BrowserRouter>

2
src/lib/constants.ts
View File

@ -150,4 +150,4 @@ export const ZOO_STUDIO_PROTOCOL = 'zoo-studio:'
* A query parameter that triggers a modal * A query parameter that triggers a modal
* to "open in desktop app" when present in the URL * to "open in desktop app" when present in the URL
*/ */
export const ASK_TO_OPEN_QUERY_PARAM = 'askToOpenInDesktop' export const ASK_TO_OPEN_QUERY_PARAM = 'ask-open-desktop'

2
src/lib/links.test.ts
View File

@ -8,7 +8,7 @@ describe(`link creation tests`, () => {
// Converted with external online tools // Converted with external online tools
const expectedEncodedCode = `ZXh0cnVzaW9uRGlzdGFuY2UgPSAxMg%3D%3D` const expectedEncodedCode = `ZXh0cnVzaW9uRGlzdGFuY2UgPSAxMg%3D%3D`
const expectedLink = `http://localhost:3000/?create-file=&name=test&units=mm&code=${expectedEncodedCode}&askToOpenInDesktop` const expectedLink = `http://localhost:3000/?create-file=true&name=test&units=mm&code=${expectedEncodedCode}&ask-open-desktop=true`
const result = createCreateFileUrl({ code, name, units }) const result = createCreateFileUrl({ code, name, units })
expect(result.toString()).toBe(expectedLink) expect(result.toString()).toBe(expectedLink)

4
src/lib/links.ts
View File

@ -23,11 +23,11 @@ export function createCreateFileUrl({ code, name, units }: FileLinkParams) {
// Use the dev server if we are in development mode // Use the dev server if we are in development mode
let origin = DEV ? 'http://localhost:3000' : PROD_APP_URL let origin = DEV ? 'http://localhost:3000' : PROD_APP_URL
const searchParams = new URLSearchParams({ const searchParams = new URLSearchParams({
[CREATE_FILE_URL_PARAM]: '', [CREATE_FILE_URL_PARAM]: String(true),
name, name,
units, units,
code: stringToBase64(code), code: stringToBase64(code),
[ASK_TO_OPEN_QUERY_PARAM]: '', [ASK_TO_OPEN_QUERY_PARAM]: String(true),
}) })
const createFileUrl = new URL(`?${searchParams.toString()}`, origin) const createFileUrl = new URL(`?${searchParams.toString()}`, origin)