ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Swap "must" for "should" in identifier casing lint (#7604)

Browse Source 
Draft: Swap "must" for "should" in identifier casing lint
This commit is contained in:
Pierre Jacquier
2025-06-25 12:48:02 -04:00
committed by GitHub
parent 0a1f35b89a
commit e1ab6bbc48
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
e2e/playwright/editor-tests.spec.ts
View File

@ -288,7 +288,7 @@ a1 = startSketchOn(offsetPlane(XY, offset = 10))
// error text on hover // error text on hover
await page.hover('.cm-lint-marker-info') await page.hover('.cm-lint-marker-info')
await expect( await expect(
page.getByText('Identifiers must be lowerCamelCase').first() page.getByText('Identifiers should be lowerCamelCase').first()
).toBeVisible() ).toBeVisible()
await page.locator('#code-pane button:first-child').click() await page.locator('#code-pane button:first-child').click()
@ -314,7 +314,7 @@ sketch_001 = startSketchOn(XY)
// error text on hover // error text on hover
await page.hover('.cm-lint-marker-info') await page.hover('.cm-lint-marker-info')
await expect( await expect(
page.getByText('Identifiers must be lowerCamelCase').first() page.getByText('Identifiers should be lowerCamelCase').first()
).toBeVisible() ).toBeVisible()
}) })
@ -511,7 +511,7 @@ sketch_001 = startSketchOn(XY)
// error text on hover // error text on hover
await page.hover('.cm-lint-marker-info') await page.hover('.cm-lint-marker-info')
await expect( await expect(
page.getByText('Identifiers must be lowerCamelCase').first() page.getByText('Identifiers should be lowerCamelCase').first()
).toBeVisible() ).toBeVisible()
// focus the editor // focus the editor
@ -539,7 +539,7 @@ sketch_001 = startSketchOn(XY)
// error text on hover // error text on hover
await page.hover('.cm-lint-marker-info') await page.hover('.cm-lint-marker-info')
await expect( await expect(
page.getByText('Identifiers must be lowerCamelCase').first() page.getByText('Identifiers should be lowerCamelCase').first()
).toBeVisible() ).toBeVisible()
}) })
@ -681,7 +681,7 @@ a1 = startSketchOn(offsetPlane(XY, offset = 10))
// error text on hover // error text on hover
await page.hover('.cm-lint-marker-info') await page.hover('.cm-lint-marker-info')
await expect( await expect(
page.getByText('Identifiers must be lowerCamelCase').first() page.getByText('Identifiers should be lowerCamelCase').first()
).toBeVisible() ).toBeVisible()
// select the line that's causing the error and delete it // select the line that's causing the error and delete it

4
rust/kcl-lib/src/lint/checks/camel_case.rs
View File

@ -11,10 +11,10 @@ use crate::{
def_finding!( def_finding!(
Z0001, Z0001,
"Identifiers must be lowerCamelCase", "Identifiers should be lowerCamelCase",
"\ "\
By convention, variable names are lowerCamelCase, not snake_case, kebab-case, By convention, variable names are lowerCamelCase, not snake_case, kebab-case,
nor CammelCase. 🐪 nor upper CamelCase (aka PascalCase). 🐪
For instance, a good identifier for the variable representing 'box height' For instance, a good identifier for the variable representing 'box height'
would be 'boxHeight', not 'BOX_HEIGHT', 'box_height' nor 'BoxHeight'. For would be 'boxHeight', not 'BOX_HEIGHT', 'box_height' nor 'BoxHeight'. For

2
rust/kcl-lib/src/lsp/tests.rs
View File

@ -2359,7 +2359,7 @@ async fn test_kcl_lsp_diagnostic_has_lints() {
assert_eq!(diagnostics.full_document_diagnostic_report.items.len(), 1); assert_eq!(diagnostics.full_document_diagnostic_report.items.len(), 1);
assert_eq!( assert_eq!(
diagnostics.full_document_diagnostic_report.items[0].message, diagnostics.full_document_diagnostic_report.items[0].message,
"Identifiers must be lowerCamelCase" "Identifiers should be lowerCamelCase"
); );
} else { } else {
panic!("Expected full diagnostics"); panic!("Expected full diagnostics");