ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revolve adjacency info (#7008)

Browse Source 
* check edge colinear

* cleanup

* revert cargo.toml

* revert cargo.toml properly

* undo yarn.lock

* clippy

* add new sim test

* move tolerance2

* typo

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* fmt

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* update snap

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* push real snap

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* update tests

Signed-off-by: Jess Frazelle <github@jessfraz.com>

---------

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com>
Co-authored-by: Jess Frazelle <github@jessfraz.com>
This commit is contained in:
Ben Crabbe
2025-05-16 23:02:30 +01:00
committed by GitHub
parent d35531758d
commit e7d2289a14
18 changed files with 1103 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
rust/kcl-lib/src/std/extrude.rs
View File

@ -220,6 +220,7 @@ async fn inner_extrude(
},
exec_state,
&args,
None,
)
.await?,
);
@ -234,6 +235,7 @@ pub(crate) struct NamedCapTags<'a> {
pub end: Option<&'a TagNode>,
}
#[allow(clippy::too_many_arguments)]
pub(crate) async fn do_post_extrude<'a>(
sketch: &Sketch,
#[cfg(feature = "artifact-graph")] solid_id: ArtifactId,
@ -242,6 +244,7 @@ pub(crate) async fn do_post_extrude<'a>(
named_cap_tags: &'a NamedCapTags<'a>,
exec_state: &mut ExecState,
args: &Args,
edge_id: Option<Uuid>,
) -> Result<Solid, KclError> {
// Bring the object to the front of the scene.
// See: https://github.com/KittyCAD/modeling-app/issues/806
@ -251,7 +254,9 @@ pub(crate) async fn do_post_extrude<'a>(
)
.await?;
let any_edge_id = if let Some(edge_id) = sketch.mirror {
let any_edge_id = if let Some(id) = edge_id {
id
} else if let Some(edge_id) = sketch.mirror {
edge_id
} else {
// The "get extrusion face info" API call requires *any* edge on the sketch being extruded.