The app names don't look native on Windows and macOS (#373)

* The app names don't look native on Windows and macOS
Fixes #372

* Typo

* Change default too

* Update json gen

* Reorg, fix upload glob

* Clean up
This commit is contained in:
Pierre Jacquier
2023-09-05 17:56:25 -04:00
committed by GitHub
parent 22c4406105
commit e992a96d3b
4 changed files with 20 additions and 8 deletions

View File

@ -124,8 +124,6 @@ jobs:
publish-apps-release:
runs-on: ubuntu-20.04
if: github.event_name == 'release'
permissions:
contents: write
needs: [build-test-web, build-apps]
env:
VERSION_NO_V: ${{ needs.build-test-web.outputs.version }}
@ -144,11 +142,11 @@ jobs:
jq --null-input \
--arg version "v${VERSION_NO_V}" \
--arg darwin_sig "$DARWIN_SIG" \
--arg darwin_url "$RELEASE_DIR/macos/kittycad-modeling-app.app.tar.gz" \
--arg darwin_url "$RELEASE_DIR/macos/KittyCAD%20Modeling.app.tar.gz" \
--arg linux_sig "$LINUX_SIG" \
--arg linux_url "$RELEASE_DIR/appimage/kittycad-modeling-app_${VERSION_NO_V}_amd64.AppImage.tar.gz" \
--arg linux_url "$RELEASE_DIR/appimage/kittycad-modeling_${VERSION_NO_V}_amd64.AppImage.tar.gz" \
--arg windows_sig "$WINDOWS_SIG" \
--arg windows_url "$RELEASE_DIR/nsis/kittycad-modeling-app_${VERSION_NO_V}_x64-setup.nsis.zip" \
--arg windows_url "$RELEASE_DIR/nsis/KittyCAD%20Modeling_${VERSION_NO_V}_x64-setup.nsis.zip" \
'{
"version": $version,
"platforms": {
@ -182,7 +180,7 @@ jobs:
uses: google-github-actions/upload-cloud-storage@v1.0.3
with:
path: artifact
glob: '*/kittycad-modeling-app*'
glob: '*/*'
parent: false
destination: dl.kittycad.io/releases/modeling-app/v${{ env.VERSION_NO_V }}
@ -195,4 +193,4 @@ jobs:
- name: Upload release files to Github
uses: softprops/action-gh-release@v1
with:
files: artifact/*/kittycad-modeling-app*
files: artifact/*/*