ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bump modeling cmds (#6746)

Browse Source 
* fixes

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* bump modeling-cmds

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

---------

Signed-off-by: Jess Frazelle <github@jessfraz.com>
This commit is contained in:
Jess Frazelle
2025-05-07 14:10:18 -07:00
committed by GitHub
parent 2fee3a424c
commit e9f6ebb6d1
66 changed files with 1333 additions and 394 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
rust/kcl-lib/src/std/chamfer.rs
View File

@ -58,7 +58,10 @@ async fn inner_chamfer(
args.batch_end_cmd(
id,
ModelingCmd::from(mcmd::Solid3dFilletEdge {
edge_id,
edge_id: None,
edge_ids: vec![edge_id],
extra_face_ids: vec![],
strategy: Default::default(),
object_id: solid.id,
radius: LengthUnit(length.to_mm()),
tolerance: LengthUnit(DEFAULT_TOLERANCE), // We can let the user set this in the future.

5
rust/kcl-lib/src/std/fillet.rs
View File

@ -89,7 +89,10 @@ async fn inner_fillet(
args.batch_end_cmd(
id,
ModelingCmd::from(mcmd::Solid3dFilletEdge {
edge_id,
edge_id: None,
edge_ids: vec![edge_id],
extra_face_ids: vec![],
strategy: Default::default(),
object_id: solid.id,
radius: LengthUnit(radius.to_mm()),
tolerance: LengthUnit(tolerance.as_ref().map(|t| t.to_mm()).unwrap_or(DEFAULT_TOLERANCE)),

12
rust/kcl-lib/src/std/patterns.rs
View File

@ -387,7 +387,11 @@ async fn send_pattern_transform<T: GeometryTrait>(
modeling_response: OkModelingCmdResponse::EntityLinearPatternTransform(pattern_info),
} = &resp
{
&pattern_info.entity_ids
if !pattern_info.entity_ids.is_empty() {
&pattern_info.entity_ids
} else {
&pattern_info.entity_face_edge_ids.iter().map(|x| x.object_id).collect()
}
} else if args.ctx.no_engine_commands().await {
mock_ids.reserve(extra_instances);
for _ in 0..extra_instances {
@ -1295,7 +1299,11 @@ async fn pattern_circular(
modeling_response: OkModelingCmdResponse::EntityCircularPattern(pattern_info),
} = &resp
{
&pattern_info.entity_ids
if !pattern_info.entity_ids.is_empty() {
&pattern_info.entity_ids.clone()
} else {
&pattern_info.entity_face_edge_ids.iter().map(|e| e.object_id).collect()
}
} else if args.ctx.no_engine_commands().await {
mock_ids.reserve(num_repetitions as usize);
for _ in 0..num_repetitions {