Make Modify with Text-to-CAD selection arg optional by honoring skip: false on non-required args (#6992)
				
					
				
			* Make "skip = false" non-required args appear in header * Make non-required, unskippable selection args work * Make prompt-to-edit's selection arg optional but non-skippable * Update src/components/CommandBar/CommandBarSelectionInput.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Fix dumb logic bug Thanks for user testing @Irev-dev * Update mixed input to show selection Feel free to revert @Irev-Dev if this is the wrong move, but I found it odd that this component doesn't show the current selection in the text like the other selection input does, so I copied that over. * Merge branch 'main' into franknoirot/adhoc/optional-selection-args * Merge branch 'main' into franknoirot/adhoc/optional-selection-args * Merge remote-tracking branch 'origin' into franknoirot/adhoc/optional-selection-args * fix tests * change copy again * Update src/components/CommandBar/CommandBarSelectionMixedInput.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This commit is contained in:
		@ -99,6 +99,8 @@ test.describe('edit with AI example snapshots', () => {
 | 
			
		||||
      await test.step('fire off edit prompt', async () => {
 | 
			
		||||
        await cmdBar.captureTextToCadRequestSnapshot(test.info())
 | 
			
		||||
        await cmdBar.openCmdBar('promptToEdit')
 | 
			
		||||
        await page.waitForTimeout(100)
 | 
			
		||||
        await cmdBar.progressCmdBar()
 | 
			
		||||
        // being specific about the color with a hex means asserting pixel color is more stable
 | 
			
		||||
        await page
 | 
			
		||||
          .getByTestId('cmd-bar-arg-value')
 | 
			
		||||
 | 
			
		||||
		Reference in New Issue
	
	Block a user