ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug: Fillet Button - selecting edge without tag caused an Error rev2 (#3690)

Browse Source 
* typos

* typos2

* trigger ci
This commit is contained in:
max
2024-08-28 01:53:33 +02:00
committed by GitHub
parent 1d19fc6b7e
commit ed339a6b9a
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/lang/modifyAst/addFillet.ts
View File

@ -469,6 +469,9 @@ export const hasValidFilletSelection = ({
if (segmentNode.node.type === 'CallExpression') { if (segmentNode.node.type === 'CallExpression') {
const segmentName = segmentNode.node.callee.name const segmentName = segmentNode.node.callee.name
if (segmentName in sketchLineHelperMap) { if (segmentName in sketchLineHelperMap) {
// Add check whether the tag exists at all:
if (!(segmentNode.node.arguments.length === 3)) return true
// If the tag exists, check if it is already filleted
const edges = isTagUsedInFillet({ const edges = isTagUsedInFillet({
ast, ast,
callExp: segmentNode.node, callExp: segmentNode.node,