ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix gltf snapshots (#1224)

Browse Source 
* fix gltf snapshots

* delete old assets
This commit is contained in:
Kurt Hutten
2023-12-18 14:22:15 +11:00
committed by GitHub
parent 10b6c1cfbc
commit eea55ff2b1
6 changed files with 17 additions and 2987 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.gitignore vendored
View File

@ -42,6 +42,8 @@ e2e/playwright/export-snapshots/*.ply
e2e/playwright/export-snapshots/*.obj e2e/playwright/export-snapshots/*.obj
e2e/playwright/export-snapshots/*.step e2e/playwright/export-snapshots/*.step
e2e/playwright/export-snapshots/*.stl e2e/playwright/export-snapshots/*.stl
e2e/playwright/export-snapshots/*binary.gltf
e2e/playwright/export-snapshots/*embedded.gltf
/test-results/ /test-results/

BIN
e2e/playwright/export-snapshots/gltf-binary.gltf
View File

Binary file not shown.

BIN
e2e/playwright/export-snapshots/gltf-binary.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 72 KiB

2976
e2e/playwright/export-snapshots/gltf-embedded.gltf
View File

File diff suppressed because one or more lines are too long

BIN
e2e/playwright/export-snapshots/gltf-embedded.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 72 KiB

10
e2e/playwright/snapshot-tests.spec.ts
View File

@ -337,18 +337,22 @@ const part001 = startSketchOn('-XZ')
units: 'in', units: 'in',
}) })
) )
exportLocations.push(
// TODO: gltfs don't seem to work with snap shots. push onto exportLocations once it's figured out
await doExport({ await doExport({
type: 'gltf', type: 'gltf',
storage: 'embedded', storage: 'embedded',
presentation: 'pretty', presentation: 'pretty',
}) })
)
exportLocations.push(
await doExport({ await doExport({
type: 'gltf', type: 'gltf',
storage: 'binary', storage: 'binary',
presentation: 'pretty', presentation: 'pretty',
}) })
)
// TODO: gltfs don't seem to work with snap shots. push onto exportLocations once it's figured out
await doExport({ await doExport({
type: 'gltf', type: 'gltf',
storage: 'standard', storage: 'standard',
@ -361,7 +365,7 @@ const part001 = startSketchOn('-XZ')
// snapshot exports, good compromise to capture that exports are healthy without getting bogged down in "did the formatting change" changes // snapshot exports, good compromise to capture that exports are healthy without getting bogged down in "did the formatting change" changes
// context: https://github.com/KittyCAD/modeling-app/issues/1222 // context: https://github.com/KittyCAD/modeling-app/issues/1222
for (const { modelPath, imagePath, outputType } of exportLocations) { for (const { modelPath, imagePath, outputType } of exportLocations) {
const cliCommand = `export KITTYCAD_TOKEN=${secrets.snapshottoken} && cat ${modelPath} | kittycad file snapshot --output-format=png --src-format=${outputType} - ${imagePath}` const cliCommand = `export KITTYCAD_TOKEN=${secrets.snapshottoken} && kittycad file snapshot --output-format=png --src-format=${outputType} ${modelPath} ${imagePath}`
const child = spawn(cliCommand, { shell: true }) const child = spawn(cliCommand, { shell: true })
await new Promise((resolve, reject) => { await new Promise((resolve, reject) => {
child.on('error', (code: any, msg: any) => { child.on('error', (code: any, msg: any) => {