Stop throwing in frontend code (#2654)

Return error instead of throw

e2e/playwright/test-utils.ts

@@ -114,19 +114,45 @@ export const wiggleMove = async (
   dist: number,
   ang: number,
   amplitude: number,
-  freq: number
+  freq: number,
+  locator?: string
 ) => {
   const tau = Math.PI * 2
   const deg = tau / 360
   const step = dist / steps
   for (let i = 0, j = 0; i < dist; i += step, j += 1) {
+    if (locator) {
+      const isElVis = await page.locator(locator).isVisible()
+      if (isElVis) return
+    }
     const [x1, y1] = [0, Math.sin((tau / steps) * j * freq) * amplitude]
     const [x2, y2] = [
       Math.cos(-ang * deg) * i - Math.sin(-ang * deg) * y1,
       Math.sin(-ang * deg) * i + Math.cos(-ang * deg) * y1,
     ]
     const [xr, yr] = [x2, y2]
-    await page.mouse.move(x + xr, y + yr, { steps: 2 })
+    await page.mouse.move(x + xr, y + yr, { steps: 5 })
+  }
+}
+
+export const circleMove = async (
+  page: any,
+  x: number,
+  y: number,
+  steps: number,
+  diameter: number,
+  locator?: string
+) => {
+  const tau = Math.PI * 2
+  const step = tau / steps
+  for (let i = 0; i < tau; i += step) {
+    if (locator) {
+      const isElVis = await page.locator(locator).isVisible()
+      if (isElVis) return
+    }
+    const [x1, y1] = [Math.cos(i) * diameter, Math.sin(i) * diameter]
+    const [xr, yr] = [x1, y1]
+    await page.mouse.move(x + xr, y + yr, { steps: 5 })
   }
 }
 
@@ -151,11 +177,11 @@ export const getMovementUtils = (opts: any) => {
 
   // Make it easier to click around from center ("click [from] zero zero")
   const click00 = (x: number, y: number) =>
-    opts.page.mouse.click(opts.center.x + x, opts.center.y + y)
+    opts.page.mouse.click(opts.center.x + x, opts.center.y + y, { delay: 100 })
 
   // Relative clicker, must keep state
   let last = { x: 0, y: 0 }
-  const click00r = (x?: number, y?: number) => {
+  const click00r = async (x?: number, y?: number) => {
     // reset relative coordinates when anything is undefined
     if (x === undefined || y === undefined) {
       last.x = 0
@@ -163,12 +189,19 @@ export const getMovementUtils = (opts: any) => {
       return
     }
 
-    const ret = click00(last.x + x, last.y + y)
+    await circleMove(
+      opts.page,
+      opts.center.x + last.x + x,
+      opts.center.y + last.y + y,
+      10,
+      10
+    )
+    await click00(last.x + x, last.y + y)
     last.x += x
     last.y += y
 
     // Returns the new absolute coordinate if you need it.
-    return ret.then(() => [last.x, last.y])
+    return [last.x, last.y]
   }
 
   return { toSU, click00r }