Stop throwing in frontend code (#2654)

Return error instead of throw

src/clientSideScene/ClientSideSceneComp.tsx

@@ -44,6 +44,7 @@ import {
   removeSingleConstraintInfo,
 } from 'lang/modifyAst'
 import { ActionButton } from 'components/ActionButton'
+import { err, trap } from 'lib/trap'
 
 function useShouldHideScene(): { hideClient: boolean; hideServer: boolean } {
   const [isCamMoving, setIsCamMoving] = useState(false)
@@ -184,11 +185,14 @@ const Overlay = ({
   let xAlignment = overlay.angle < 0 ? '0%' : '-100%'
   let yAlignment = overlay.angle < -90 || overlay.angle >= 90 ? '0%' : '-100%'
 
-  const callExpression = getNodeFromPath<CallExpression>(
+  const _node1 = getNodeFromPath<CallExpression>(
     kclManager.ast,
     overlay.pathToNode,
     'CallExpression'
-  ).node
+  )
+  if (err(_node1)) return
+  const callExpression = _node1.node
+
   const constraints = getConstraintInfo(
     callExpression,
     codeManager.code,
@@ -219,6 +223,7 @@ const Overlay = ({
         data-testid="segment-overlay"
         data-path-to-node={pathToNodeString}
         data-overlay-index={overlayIndex}
+        data-overlay-visible={shouldShow}
         data-overlay-angle={overlay.angle}
         className="pointer-events-auto absolute w-0 h-0"
         style={{
@@ -227,6 +232,7 @@ const Overlay = ({
       ></div>
       {shouldShow && (
         <div
+          data-overlay-toolbar-index={overlayIndex}
           className={`px-0 pointer-events-auto absolute flex gap-1`}
           style={{
             transform: `translate3d(calc(${
@@ -352,7 +358,7 @@ export async function deleteSegment({
   pathToNode: PathToNode
   sketchDetails: SketchDetails | null
 }) {
-  let modifiedAst: Program = kclManager.ast
+  let modifiedAst: Program | Error = kclManager.ast
   const dependentRanges = findUsesOfTagInPipe(modifiedAst, pathToNode)
 
   const shouldContinueSegDelete = dependentRanges.length
@@ -363,6 +369,7 @@ export async function deleteSegment({
     : true
 
   if (!shouldContinueSegDelete) return
+
   modifiedAst = deleteSegmentFromPipeExpression(
     dependentRanges,
     modifiedAst,
@@ -370,9 +377,12 @@ export async function deleteSegment({
     codeManager.code,
     pathToNode
   )
+  if (err(modifiedAst)) return Promise.reject(modifiedAst)
 
   const newCode = recast(modifiedAst)
   modifiedAst = parse(newCode)
+  if (err(modifiedAst)) return Promise.reject(modifiedAst)
+
   const testExecute = await executeAst({
     ast: modifiedAst,
     useFakeExecutor: true,
@@ -384,13 +394,15 @@ export async function deleteSegment({
   }
 
   if (!sketchDetails) return
-  sceneEntitiesManager.updateAstAndRejigSketch(
-    sketchDetails.sketchPathToNode,
+  await sceneEntitiesManager.updateAstAndRejigSketch(
+    pathToNode,
     modifiedAst,
     sketchDetails.zAxis,
     sketchDetails.yAxis,
     sketchDetails.origin
   )
+
+  // Now 'Set sketchDetails' is called with the modified pathToNode
 }
 
 const SegmentMenu = ({
@@ -535,10 +547,13 @@ const ConstraintSymbol = ({
   const implicitDesc =
     varNameMap[_type as LineInputsType]?.implicitConstraintDesc
 
-  const node = useMemo(
-    () => getNodeFromPath<Value>(kclManager.ast, pathToNode).node,
+  const _node = useMemo(
+    () => getNodeFromPath<Value>(kclManager.ast, pathToNode),
     [kclManager.ast, pathToNode]
   )
+  if (err(_node)) return
+  const node = _node.node
+
   const range: SourceRange = node ? [node.start, node.end] : [0, 0]
 
   if (_type === 'intersectionTag') return null
@@ -576,12 +591,17 @@ const ConstraintSymbol = ({
             })
           } else if (isConstrained) {
             try {
-              const shallowPath = getNodeFromPath<CallExpression>(
-                parse(recast(kclManager.ast)),
+              const parsed = parse(recast(kclManager.ast))
+              if (trap(parsed)) return Promise.reject(parsed)
+              const _node1 = getNodeFromPath<CallExpression>(
+                parsed,
                 pathToNode,
                 'CallExpression',
                 true
-              ).shallowPath
+              )
+              if (trap(_node1)) return Promise.reject(_node1)
+              const shallowPath = _node1.shallowPath
+
               const input = makeRemoveSingleConstraintInput(
                 argPosition,
                 shallowPath