Stop throwing in frontend code (#2654)

Return error instead of throw

src/components/Toolbar/Intersect.tsx

@@ -11,11 +11,13 @@ import {
   transformSecondarySketchLinesTagFirst,
   getTransformInfos,
   PathToNodeMap,
+  TransformInfo,
 } from '../../lang/std/sketchcombos'
 import { GetInfoModal, createInfoModal } from '../SetHorVertDistanceModal'
 import { createVariableDeclaration } from '../../lang/modifyAst'
 import { removeDoubleNegatives } from '../AvailableVarsHelpers'
 import { kclManager } from 'lib/singletons'
+import { err } from 'lib/trap'
 
 const getModalInfo = createInfoModal(GetInfoModal)
 
@@ -23,7 +25,13 @@ export function intersectInfo({
   selectionRanges,
 }: {
   selectionRanges: Selections
-}) {
+}):
+  | {
+      transforms: TransformInfo[]
+      enabled: boolean
+      forcedSelectionRanges: Selections
+    }
+  | Error {
   if (selectionRanges.codeBasedSelections.length < 2) {
     return {
       enabled: false,
@@ -40,6 +48,8 @@ export function intersectInfo({
       selectionRanges.codeBasedSelections[0],
       selectionRanges.codeBasedSelections[1]
     )
+  if (err(previousSegment)) return previousSegment
+
   const shouldUsePreviousSegment =
     selectionRanges.codeBasedSelections?.[1]?.type !== 'line-end' &&
     previousSegment &&
@@ -61,17 +71,28 @@ export function intersectInfo({
   const paths = _forcedSelectionRanges.codeBasedSelections.map(({ range }) =>
     getNodePathFromSourceRange(kclManager.ast, range)
   )
-  const nodes = paths.map(
-    (pathToNode) => getNodeFromPath<Value>(kclManager.ast, pathToNode).node
-  )
-  const varDecs = paths.map(
-    (pathToNode) =>
-      getNodeFromPath<VariableDeclarator>(
-        kclManager.ast,
-        pathToNode,
-        'VariableDeclarator'
-      )?.node
-  )
+  const _nodes = paths.map((pathToNode) => {
+    const tmp = getNodeFromPath<Value>(kclManager.ast, pathToNode)
+    if (err(tmp)) return tmp
+    return tmp.node
+  })
+  const _err1 = _nodes.find(err)
+  if (err(_err1)) return _err1
+  const nodes = _nodes as Value[]
+
+  const _varDecs = paths.map((pathToNode) => {
+    const tmp = getNodeFromPath<VariableDeclarator>(
+      kclManager.ast,
+      pathToNode,
+      'VariableDeclarator'
+    )
+    if (err(tmp)) return tmp
+    return tmp.node
+  })
+  const _err2 = _varDecs.find(err)
+  if (err(_err2)) return _err2
+  const varDecs = _varDecs as VariableDeclarator[]
+
   const primaryLine = varDecs[0]
   const secondaryVarDecs = varDecs.slice(1)
   const isOthersLinkedToPrimary = secondaryVarDecs.every((secondary) =>
@@ -117,16 +138,22 @@ export async function applyConstraintIntersect({
   modifiedAst: Program
   pathToNodeMap: PathToNodeMap
 }> {
-  const { transforms, forcedSelectionRanges } = intersectInfo({
+  const info = intersectInfo({
     selectionRanges,
   })
+  if (err(info)) return Promise.reject(info)
+  const { transforms, forcedSelectionRanges } = info
+
+  const transform1 = transformSecondarySketchLinesTagFirst({
+    ast: JSON.parse(JSON.stringify(kclManager.ast)),
+    selectionRanges: forcedSelectionRanges,
+    transformInfos: transforms,
+    programMemory: kclManager.programMemory,
+  })
+  if (err(transform1)) return Promise.reject(transform1)
   const { modifiedAst, tagInfo, valueUsedInTransform, pathToNodeMap } =
-    transformSecondarySketchLinesTagFirst({
-      ast: JSON.parse(JSON.stringify(kclManager.ast)),
-      selectionRanges: forcedSelectionRanges,
-      transformInfos: transforms,
-      programMemory: kclManager.programMemory,
-    })
+    transform1
+
   const {
     segName,
     value,
@@ -156,15 +183,18 @@ export async function applyConstraintIntersect({
     sign,
     variableName
   )
+  const transform2 = transformSecondarySketchLinesTagFirst({
+    ast: kclManager.ast,
+    selectionRanges: forcedSelectionRanges,
+    transformInfos: transforms,
+    programMemory: kclManager.programMemory,
+    forceSegName: segName,
+    forceValueUsedInTransform: finalValue,
+  })
+  if (err(transform2)) return Promise.reject(transform2)
   const { modifiedAst: _modifiedAst, pathToNodeMap: _pathToNodeMap } =
-    transformSecondarySketchLinesTagFirst({
-      ast: kclManager.ast,
-      selectionRanges: forcedSelectionRanges,
-      transformInfos: transforms,
-      programMemory: kclManager.programMemory,
-      forceSegName: segName,
-      forceValueUsedInTransform: finalValue,
-    })
+    transform2
+
   if (variableName) {
     const newBody = [..._modifiedAst.body]
     newBody.splice(