Stop throwing in frontend code (#2654)

Return error instead of throw
This commit is contained in:
49fl
2024-06-24 11:45:40 -04:00
committed by GitHub
parent f7196e7eb0
commit f4877cb160
67 changed files with 5127 additions and 4523 deletions

View File

@ -6,6 +6,7 @@ import {
import { Models } from '@kittycad/lib'
import { v4 as uuidv4 } from 'uuid'
import { DefaultPlanes } from 'wasm-lib/kcl/bindings/DefaultPlanes'
import { err } from 'lib/trap'
type WebSocketResponse = Models['WebSocketResponse_type']
@ -56,13 +57,13 @@ class MockEngineCommandManager {
commandStr: string
): Promise<any> {
if (id === undefined) {
throw new Error('id is undefined')
return Promise.reject(new Error('id is undefined'))
}
if (rangeStr === undefined) {
throw new Error('rangeStr is undefined')
return Promise.reject(new Error('rangeStr is undefined'))
}
if (commandStr === undefined) {
throw new Error('commandStr is undefined')
return Promise.reject(new Error('commandStr is undefined'))
}
const command: EngineCommand = JSON.parse(commandStr)
const range: SourceRange = JSON.parse(rangeStr)
@ -73,9 +74,12 @@ class MockEngineCommandManager {
}
export async function enginelessExecutor(
ast: Program,
pm: ProgramMemory = { root: {}, return: null }
ast: Program | Error,
pm: ProgramMemory | Error = { root: {}, return: null }
): Promise<ProgramMemory> {
if (err(ast)) return Promise.reject(ast)
if (err(pm)) return Promise.reject(pm)
const mockEngineCommandManager = new MockEngineCommandManager({
setIsStreamReady: () => {},
setMediaStream: () => {},