d35531758d
fix read_to_string to give error ( #7022 )
...
updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-16 16:56:19 -04:00
729e0a7949
add a subtract regression test ( #7018 )
...
* add a subtraact regression test
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* also rename some github actions job so we can require them;
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* artifacts
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-16 20:06:56 +00:00
620b7401aa
Update Rust tests to use internal KCL samples on CI ( #7014 )
...
* Update Rust tests to use internal KCL samples on CI
* Regenerate manifest with internal KCL samples
* try again
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* remove the needs
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* features
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* features
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* secret
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
Co-authored-by: Jess Frazelle <github@jessfraz.com >
2025-05-16 19:38:55 +00:00
48a4fd8373
Organization and Pro tier link sharing features exposure ( #6986 )
...
* Improve url sharing for orgs and pros
* Remove sharing via menu item
* fmt
* Not sure what's different but it is
* fmt & lint
* whoops
* Update snapshots
* Typos from codespell
* Fix alignment
* Update snapshots
* Prune
---------
Co-authored-by: Pierre Jacquier <pierrejacquier39@gmail.com >
Co-authored-by: Pierre Jacquier <pierre@zoo.dev >
2025-05-16 09:51:08 +00:00
f59b806a88
Fix to display warnings when there's a fatal error ( #6995 )
...
* Fix to display warnings when there's a fatal error
* Fix JSON test
2025-05-16 03:22:21 +00:00
23a0085c78
Change runtime assert to runtime error and debug assert ( #6987 )
2025-05-15 22:55:16 -04:00
a280a8c3f0
Nickmccleery/i have no idea what im doing ( #6967 )
...
* Yeet in alt param structure.
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
Co-authored-by: Jess Frazelle <github@jessfraz.com >
2025-05-16 02:16:32 +00:00
11620dfa6b
Fix to display errors at the call site ( #6991 )
2025-05-15 22:11:37 -04:00
f6e26e0bab
test: Add face_code_ref to the mermaid output ( #6985 )
...
* Add face_code_ref to the mermaid output
* Update output
2025-05-15 20:14:31 -04:00
74939e5cd6
Fix execution caching to cache artifact graph NodePath ( #6978 )
...
* Fix to add NodePaths to SketchOnFace and SketchOnPlane artifacts
* Fix to only compute the new part of the artifact graph
* Change to early-return sooner when in mock mode
* Add another test
* Fix to propagate NodePath for sketch on face
* Update output
2025-05-15 19:18:03 -04:00
9906c9947a
Do not coerce unknown numbers and preserve known units if present ( #6961 )
...
Signed-off-by: Nick Cameron <nrc@ncameron.org >
2025-05-16 10:58:21 +12:00
2516df3a39
fix my insta test fubar ( #6981 )
...
* fix my insta test fubar
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* more python tests
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* more python tests
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-15 13:37:12 -07:00
e489222b6a
expose mock executing to python library; ( #6980 )
...
* expose mock executing to python library;
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* bump
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* Update rust/kcl-python-bindings/src/lib.rs
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
2025-05-15 12:35:29 -07:00
d93a57d7bf
more lsp tests / pass python a bool on parse ( #6975 )
...
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* parse returns bool for python
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-15 11:04:53 -07:00
d34aea345b
#6548 Fix autocomplete for offsetPlane ( #6940 )
...
* handle Plane in get_autocomplete_snippet to fix missing default plane value for offsetPlane
* adds test for offsetPlane default plane value
* cleanup test
* use XY instead of XZ for default plane
* add rust test for offsetplane autocomplete
* remove playwright test for offestPlane, as it has rust test now and there are autocomplete tests already
2025-05-15 19:53:35 +02:00
b898c27e74
Add KCL constants for sweep relativeTo strings ( #6974 )
...
* Add KCL constants for sweep relativeTo strings
Before:
```
sweep(pill, path = sweepPath, relativeTo = "trajectoryCurve")
```
After:
```
sweep(pill, path = sweepPath, relativeTo = sweep::TRAJECTORY)
```
* Update docs
2025-05-15 10:13:04 -07:00
92fc294eae
Update mesh clone test ( #6597 )
2025-05-15 16:46:37 +00:00
d3a4fd8b55
Raw dog parse for python bindings ( #6970 )
...
* raw dog parse python
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* add tests
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-15 15:39:28 +00:00
94f194a984
new sweep default ( #6965 )
...
snaps
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-15 11:50:55 +00:00
4fe880a970
Revert "fixes"
...
This reverts commit 8f5fbfc273
2025-05-15 04:28:20 -07:00
8f5fbfc273
fixes
...
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-15 04:27:59 -07:00
d74fdd9369
Color picker goober works w single quotes ( #6957 )
...
* lsp stuffs
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-15 12:37:14 +10:00
334145f0be
fix sketch on face of union ( #6949 )
...
* fix sketch on face of union
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* rotate the model
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-14 23:25:12 +00:00
c24073b6ae
Sensible parser error when using keyword as arg label ( #6948 )
...
Closes <https://github.com/KittyCAD/modeling-app/issues/6924 >
2025-05-14 22:29:31 +00:00
078b7f3bf7
fix errors from the wasm side ( #6939 )
...
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* playwright tests
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* fix tests
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* change order of operations
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* lint
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* fixups
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* Revert "fixups"
This reverts commit c54fd71074github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-14 13:20:46 -07:00
ce566fb6e5
Accept idents as KW args ( #6644 )
...
Support kw arg/local variable shorthand
Signed-off-by: Nick Cameron <nrc@ncameron.org >
2025-05-15 07:42:48 +12:00
5c2dfb8e40
Support new sweep flag ( #6932 )
...
Closes https://github.com/KittyCAD/engine/issues/3115
2025-05-14 13:54:10 -05:00
696222a070
Change KCL error messages to display principal type of values ( #6906 )
2025-05-14 10:04:51 -04:00
1e487ef3bd
Include NodePath in artifact graph mermaid charts as comments ( #6884 )
...
* Display NodePath in artifact graph mermaid charts
* Update output
* Change node path display to be only comments
* Update output
* Update output after rebase
2025-05-14 05:31:58 +00:00
980e3c4bc2
remove my sins ( #6919 )
...
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-14 04:28:55 +00:00
78b6854c6b
bump modeling-cmds, nuke slow world ( #6753 )
...
* bump modeling-cmds, nuke slow world
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* more stuffs
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* i mechanical engineered today
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* reverse uno your revolves
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* retry logic
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* fixes
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-14 04:07:24 +00:00
068b9129cf
add a sleep for local engine disconnect/reconnect ( #6918 )
...
updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-13 16:12:37 -07:00
05fba3c50c
more stable shards ( #6916 )
...
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-13 15:27:18 -07:00
7944a4ce41
New single-file samples for the website ( #6670 )
...
* New single-file samples for the website
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* Delete public/kcl-samples/piston directory
* More
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* move another test
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com >
Co-authored-by: Jess Frazelle <github@jessfraz.com >
2025-05-13 15:05:57 -07:00
4640f1a3ad
Teaching t2c how to counterbore, countersink, and counterdrill ( #6833 )
...
* Teaching t2c how to counterbore, countersink, and counterdrill
* Delete public/kcl-samples/parametric-bearing-pillow-block directory
* Update mounting-wire.kcl
* new artifiacts
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* Update kcl-samples simulation test output
* Update kcl-samples simulation test output
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com >
Co-authored-by: Jess Frazelle <github@jessfraz.com >
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-05-13 14:11:50 -07:00
cd79059d97
Subtract tests ( #6913 )
...
* add subtract test and cleanup some other tests
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* fmt
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-13 14:06:10 -07:00
2d95e19048
Gears DLC (free) ( #6835 )
...
* Gears DLC (free)
Using the involuteCircular fn to create a variety of cylindrical gearsets
* Delete public/kcl-samples/gear directory
* Update main.kcl
fixing gear meshing
* new samples
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* add link
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com >
Co-authored-by: Jess Frazelle <github@jessfraz.com >
2025-05-13 14:03:52 -07:00
d047587bc1
Avoid using full revolve for now ( #6912 )
...
Avoid using revolve for now
When we moved to concurrent execution of KCL modules, we begun to see an
error we never fully understood, and because it was pretty hard to
trigger, we wound up never being able to fix it. Today we were able to
track it down to the `revolve` call here.
Specifically, the problem is triggered when we're doing a "Full Revolve"
(e.g., `angle = 359.999999` passes, but *not* `angle = 360` or the
default, as it is in `main`), and concurrently executing modules will
see something weird happen with `getNextAdjacentEdge`.
From all the smoke I believe this happens only when we are doing a *full
revolve*, *AND* we're executing other modules which are calling
`getNextAdjacentEdge`.
When the `revolve` is present, we can lose the race in *either*
`talk-button.kcl` OR `case.kcl`.
If I move back to single-threaded execution OR I add imports to sequence
things carefully, I can get the tests to pass. If the revolve is an
`extrude` or not a full revolve, it works fine.
My best guess is that it seems like the world got flipped upside down or
something, such that "next edge" has a different orentation for two
calls. My even further guess is that inside `revolve` we mutate
something connection-global such that it alters the intepretation of
calls made during the revolve implementation's "critical section".
2025-05-13 20:20:48 +00:00
128e1093fb
Update snaps ( #6911 )
...
* update pattern entity ids since that pr merged
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* artifacts
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-13 19:27:34 +00:00
be14022f97
Update samples PNG export ( #6908 )
2025-05-13 18:03:27 +00:00
33e83747f3
Split up example tests into smaller batches and provide info on which example is failing ( #6896 )
...
* Give example info for failing std example tests
Signed-off-by: Nick Cameron <nrc@ncameron.org >
* Shard example tests into 10
Signed-off-by: Nick Cameron <nrc@ncameron.org >
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org >
2025-05-13 10:50:54 -07:00
01c7b69f50
Function types ( #6891 )
...
* Change Fn to fn for function types
Signed-off-by: Nick Cameron <nrc@ncameron.org >
* Support args and return types in function types
Signed-off-by: Nick Cameron <nrc@ncameron.org >
* Use fancy function types in the docs
Signed-off-by: Nick Cameron <nrc@ncameron.org >
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org >
2025-05-13 14:59:23 +12:00
e297f8286f
KCL: Fix incorrect error messages ( #6883 )
...
**Problem:**
KCL's xLine and yLine functions were telling users to supply either "end" or "endAbsolute" arguments. But "end" is not a valid argument for xLine/yLine, it's actually "length" instead.
**Cause:**
xLine/yLine were using a helper function designed for `line` KCL stdlib functions, which do use `end`.
**Solution**
Add a new param to the helper function, indicating what the label should be for relative lines. "end" for `line` calls, `length` for x/yline
2025-05-13 00:26:43 +00:00
95a02cbcd7
Check all nested KCL samples ( #6880 )
2025-05-12 18:43:51 -04:00
a049768f1c
Move some more functions to be declared in KCL ( #6856 )
...
* Move the leg functions to KCL
Signed-off-by: Nick Cameron <nrc@ncameron.org >
* Move array functions to KCL
Signed-off-by: Nick Cameron <nrc@ncameron.org >
* Move clone to KCL
Signed-off-by: Nick Cameron <nrc@ncameron.org >
* Add a function type
Signed-off-by: Nick Cameron <nrc@ncameron.org >
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org >
2025-05-13 08:29:38 +12:00
270436f404
Fix: clearSceneAndBustCache when rust panics because it can load a stale cache ( #6809 )
...
* fix: clear scene and bust cache if rust panics
* fix: pr clean up
* fix: huh? cargo fmt doesn't do this?
2025-05-12 10:08:54 -05:00
21b92f5f13
fix cache multi-file ( #6844 )
...
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* updates
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* bump kittycad.rs i need this for cli
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* bump the version so i can fix cli
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* fix
Signed-off-by: Jess Frazelle <github@jessfraz.com >
* clippy
Signed-off-by: Jess Frazelle <github@jessfraz.com >
---------
Signed-off-by: Jess Frazelle <github@jessfraz.com >
2025-05-12 09:07:18 -05:00
1a325d0b29
Fix to use correct units for array range expressions ( #6837 )
...
* Fix to use correct units for array range expressions
* Update output
2025-05-12 01:30:33 -04:00
1240b23080
Don't truncate extrude arg docs ( #6854 )
...
Signed-off-by: Nick Cameron <nrc@ncameron.org >
2025-05-12 16:48:30 +12:00
8445080d7a
Some improvements to math::sqrt ( #6853 )
...
* Treat number as any rather than default
Signed-off-by: Nick Cameron <nrc@ncameron.org >
* Don't square root negative numbers
Signed-off-by: Nick Cameron <nrc@ncameron.org >
---------
Signed-off-by: Nick Cameron <nrc@ncameron.org >
2025-05-12 16:47:01 +12:00
