WIP

Change sweep relativeTo flag defaults
Default to trajectoryCurve, as Ryan wants
2025-05-14 14:18:57 -05:00 · 2025-05-14 14:18:11 -05:00 · 2025-05-14 13:57:12 -05:00 · 2025-05-14 13:54:10 -05:00 · 2025-05-14 14:16:23 -04:00 · 2025-05-14 17:53:44 +00:00
18 changed files with 1813 additions and 57 deletions
--- a/docs/kcl-std/std.json
+++ b/docs/kcl-std/std.json
--- a/docs/kcl-std/sweep.md
+++ b/docs/kcl-std/sweep.md
@ -13,6 +13,7 @@ sweep(
  path: Sketch | Helix,
  sectional?: bool,
  tolerance?: number,
+  relativeTo?: string,
  tagStart?: TagDeclarator,
  tagEnd?: TagDeclarator,
 ): [Solid]
@ -30,6 +31,7 @@ You can provide more than one sketch to sweep, and they will all be swept along
 | `path` | [`Sketch`](/docs/kcl-std/types/std-types-Sketch) or [`Helix`](/docs/kcl-std/types/std-types-Helix) | The path to sweep the sketch along | Yes |
 | `sectional` | [`bool`](/docs/kcl-std/types/std-types-bool) | If true, the sweep will be broken up into sub-sweeps (extrusions, revolves, sweeps) based on the trajectory path components. | No |
 | `tolerance` | [`number`](/docs/kcl-std/types/std-types-number) | Tolerance for this operation | No |
+| `relativeTo` | [`string`](/docs/kcl-std/types/std-types-string) | What is the sweep relative to? Can be either 'sketchPlane' or 'trajectoryCurve'. Defaults to sketchPlane. | No |
 | `tagStart` | [`TagDeclarator`](/docs/kcl-lang/types#TagDeclarator) | A named tag for the face at the start of the sweep, i.e. the original sketch | No |
 | `tagEnd` | [`TagDeclarator`](/docs/kcl-lang/types#TagDeclarator) | A named tag for the face at the end of the sweep | No |

--- a/e2e/playwright/desktop-export.spec.ts
+++ b/e2e/playwright/desktop-export.spec.ts
@ -58,12 +58,6 @@ test(
      await expect(submitButton).toBeVisible()
      await page.keyboard.press('Enter')

-      // Look out for the toast message
-      const exportingToastMessage = page.getByText(`Exporting...`)
-      const alreadyExportingToastMessage = page.getByText(`Already exporting`)
-      await expect(exportingToastMessage).toBeVisible()
-      await expect(alreadyExportingToastMessage).not.toBeVisible()
-
      // Expect it to succeed
      const errorToastMessage = page.getByText(`Error while exporting`)
      const engineErrorToastMessage = page.getByText(`Nothing to export`)
@ -72,7 +66,6 @@ test(

      const successToastMessage = page.getByText(`Exported successfully`)
      await expect(successToastMessage).toBeVisible()
-      await expect(exportingToastMessage).not.toBeVisible()

      // Check for the exported file
      const firstFileFullPath = path.resolve(
--- a/e2e/playwright/regression-tests.spec.ts
+++ b/e2e/playwright/regression-tests.spec.ts
@ -545,7 +545,8 @@ extrude002 = extrude(profile002, length = 150)
        expect(alreadyExportingToastMessage).not.toBeVisible(),
      ])

-      await expect(successToastMessage).toHaveCount(2)
+      const count = await successToastMessage.count()
+      await expect(count).toBeGreaterThanOrEqual(2)
    })
  })

--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@ -535,7 +535,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "117725a109d387c937a1533ce01b450cbde6b88abceea8473c4d7a85853cda3c"
 dependencies = [
 "lazy_static",
- "windows-sys 0.59.0",
+ "windows-sys 0.52.0",
 ]

 [[package]]
@ -963,7 +963,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "33d852cb9b869c2a9b3df2f71a3074817f01e1844f839a144f5fcef059a4eb5d"
 dependencies = [
 "libc",
- "windows-sys 0.59.0",
+ "windows-sys 0.52.0",
 ]

 [[package]]
@ -1746,7 +1746,7 @@ checksum = "e04d7f318608d35d4b61ddd75cbdaee86b023ebe2bd5a66ee0915f0bf93095a9"
 dependencies = [
 "hermit-abi",
 "libc",
- "windows-sys 0.59.0",
+ "windows-sys 0.52.0",
 ]

 [[package]]
@ -2080,9 +2080,9 @@ dependencies = [

 [[package]]
 name = "kittycad-modeling-cmds"
-version = "0.2.120"
+version = "0.2.121"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "48b71e06ee5d711d0085864a756fb6a304531246689ea00c6ef5d740670c3701"
+checksum = "94ba95c22493d79ec8a1faab963d8903f6de0e373efedf2bc3bb76a0ddbab036"
 dependencies = [
 "anyhow",
 "chrono",
@ -2987,7 +2987,7 @@ dependencies = [
 "once_cell",
 "socket2",
 "tracing",
- "windows-sys 0.59.0",
+ "windows-sys 0.52.0",
 ]

 [[package]]
@ -3306,7 +3306,7 @@ dependencies = [
 "errno",
 "libc",
 "linux-raw-sys",
- "windows-sys 0.59.0",
+ "windows-sys 0.52.0",
 ]

 [[package]]
@ -3900,7 +3900,7 @@ dependencies = [
 "getrandom 0.3.1",
 "once_cell",
 "rustix",
- "windows-sys 0.59.0",
+ "windows-sys 0.52.0",
 ]

 [[package]]
@ -4753,7 +4753,7 @@ version = "0.1.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "cf221c93e13a30d793f7645a0e7762c55d169dbb0a49671918a2319d289b10bb"
 dependencies = [
- "windows-sys 0.59.0",
+ "windows-sys 0.52.0",
 ]

 [[package]]
--- a/rust/kcl-lib/src/std/sweep.rs
+++ b/rust/kcl-lib/src/std/sweep.rs
@ -3,7 +3,7 @@
 use anyhow::Result;
 use kcl_derive_docs::stdlib;
 use kcmc::{each_cmd as mcmd, length_unit::LengthUnit, ModelingCmd};
-use kittycad_modeling_cmds::{self as kcmc};
+use kittycad_modeling_cmds::{self as kcmc, shared::RelativeTo};
 use schemars::JsonSchema;
 use serde::Serialize;

@ -37,11 +37,20 @@ pub async fn sweep(exec_state: &mut ExecState, args: Args) -> Result<KclValue, K
    )?;
    let sectional = args.get_kw_arg_opt("sectional")?;
    let tolerance: Option<TyF64> = args.get_kw_arg_opt_typed("tolerance", &RuntimeType::length(), exec_state)?;
+    let relative_to: Option<String> = args.get_kw_arg_opt_typed("relativeTo", &RuntimeType::string(), exec_state)?;
    let tag_start = args.get_kw_arg_opt("tagStart")?;
    let tag_end = args.get_kw_arg_opt("tagEnd")?;

    let value = inner_sweep(
-        sketches, path, sectional, tolerance, tag_start, tag_end, exec_state, args,
+        sketches,
+        path,
+        sectional,
+        tolerance,
+        relative_to,
+        tag_start,
+        tag_end,
+        exec_state,
+        args,
    )
    .await?;
    Ok(value.into())
@ -158,6 +167,7 @@ pub async fn sweep(exec_state: &mut ExecState, args: Args) -> Result<KclValue, K
        path = { docs = "The path to sweep the sketch along" },
        sectional = { docs = "If true, the sweep will be broken up into sub-sweeps (extrusions, revolves, sweeps) based on the trajectory path components." },
        tolerance = { docs = "Tolerance for this operation" },
+        relative_to = { docs = "What is the sweep relative to? Can be either 'sketchPlane' or 'trajectoryCurve'. Defaults to trajectoryCurve."},
        tag_start = { docs = "A named tag for the face at the start of the sweep, i.e. the original sketch" },
        tag_end = { docs = "A named tag for the face at the end of the sweep" },
    },
@ -169,6 +179,7 @@ async fn inner_sweep(
    path: SweepPath,
    sectional: Option<bool>,
    tolerance: Option<TyF64>,
+    relative_to: Option<String>,
    tag_start: Option<TagNode>,
    tag_end: Option<TagNode>,
    exec_state: &mut ExecState,
@ -178,6 +189,16 @@ async fn inner_sweep(
        SweepPath::Sketch(sketch) => sketch.id.into(),
        SweepPath::Helix(helix) => helix.value.into(),
    };
+    let relative_to = match relative_to.as_deref() {
+        Some("sketchPlane") => RelativeTo::SketchPlane,
+        Some("trajectoryCurve") | None => RelativeTo::TrajectoryCurve,
+        Some(_) => {
+            return Err(KclError::Syntax(crate::errors::KclErrorDetails {
+                source_ranges: vec![args.source_range],
+                message: "If you provide relativeTo, it must either be 'sketchPlane' or 'trajectoryCurve'".to_owned(),
+            }))
+        }
+    };

    let mut solids = Vec::new();
    for sketch in &sketches {
@ -189,6 +210,7 @@ async fn inner_sweep(
                trajectory,
                sectional: sectional.unwrap_or(false),
                tolerance: LengthUnit(tolerance.as_ref().map(|t| t.to_mm()).unwrap_or(DEFAULT_TOLERANCE)),
+                relative_to,
            }),
        )
        .await?;
--- a/rust/kcl-lib/tests/kcl_samples/bench/artifact_commands.snap
+++ b/rust/kcl-lib/tests/kcl_samples/bench/artifact_commands.snap
@ -5121,7 +5121,8 @@ description: Artifact commands bench.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -5132,7 +5133,8 @@ description: Artifact commands bench.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  }
 ]
--- a/rust/kcl-lib/tests/kcl_samples/cold-plate/artifact_commands.snap
+++ b/rust/kcl-lib/tests/kcl_samples/cold-plate/artifact_commands.snap
@ -905,7 +905,8 @@ description: Artifact commands cold-plate.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
--- a/rust/kcl-lib/tests/kcl_samples/countersunk-plate/program_memory.snap
+++ b/rust/kcl-lib/tests/kcl_samples/countersunk-plate/program_memory.snap
@ -162,7 +162,7 @@ description: Variables in memory after executing countersunk-plate.kcl
            ],
            "tag": null,
            "to": [
-              2.7737,
+              2.7738,
              -0.6983
            ],
            "type": "TangentialArc",
@ -176,7 +176,7 @@ description: Variables in memory after executing countersunk-plate.kcl
              "sourceRange": []
            },
            "from": [
-              2.7737,
+              2.7738,
              -0.6983
            ],
            "tag": null,
@ -196,7 +196,7 @@ description: Variables in memory after executing countersunk-plate.kcl
            },
            "ccw": false,
            "center": [
-              -0.0,
+              0.0,
              -0.0
            ],
            "from": [
--- a/rust/kcl-lib/tests/kcl_samples/cpu-cooler/artifact_commands.snap
+++ b/rust/kcl-lib/tests/kcl_samples/cpu-cooler/artifact_commands.snap
@ -5575,7 +5575,8 @@ description: Artifact commands cpu-cooler.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -6109,7 +6110,8 @@ description: Artifact commands cpu-cooler.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -9466,7 +9468,8 @@ description: Artifact commands cpu-cooler.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -9597,7 +9600,8 @@ description: Artifact commands cpu-cooler.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -10115,7 +10119,8 @@ description: Artifact commands cpu-cooler.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -10246,7 +10251,8 @@ description: Artifact commands cpu-cooler.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
--- a/rust/kcl-lib/tests/kcl_samples/exhaust-manifold/artifact_commands.snap
+++ b/rust/kcl-lib/tests/kcl_samples/exhaust-manifold/artifact_commands.snap
@ -1597,7 +1597,8 @@ description: Artifact commands exhaust-manifold.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -1608,7 +1609,8 @@ description: Artifact commands exhaust-manifold.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -1619,7 +1621,8 @@ description: Artifact commands exhaust-manifold.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
@ -1630,7 +1633,8 @@ description: Artifact commands exhaust-manifold.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
--- a/rust/kcl-lib/tests/kcl_samples/utility-sink/artifact_commands.snap
+++ b/rust/kcl-lib/tests/kcl_samples/utility-sink/artifact_commands.snap
@ -4490,7 +4490,8 @@ description: Artifact commands utility-sink.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
--- a/rust/kcl-lib/tests/subtract_regression03/artifact_commands.snap
+++ b/rust/kcl-lib/tests/subtract_regression03/artifact_commands.snap
@ -417,7 +417,8 @@ description: Artifact commands subtract_regression03.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
--- a/rust/kcl-lib/tests/subtract_regression05/artifact_commands.snap
+++ b/rust/kcl-lib/tests/subtract_regression05/artifact_commands.snap
@ -394,7 +394,8 @@ description: Artifact commands subtract_regression05.kcl
      "target": "[uuid]",
      "trajectory": "[uuid]",
      "sectional": false,
-      "tolerance": 0.0000001
+      "tolerance": 0.0000001,
+      "relative_to": "trajectory_curve"
    }
  },
  {
--- a/src/lang/KclSingleton.ts
+++ b/src/lang/KclSingleton.ts
@ -151,6 +151,10 @@ export class KclManager {
    // These belonged to the previous file
    this.lastSuccessfulOperations = []
    this.lastSuccessfulVariables = {}
+
+    // Without this, when leaving a project which has errors and opening another project which doesn't,
+    // you'd see the errors from the previous project for a short time until the new code is executed.
+    this._errors = []
  }

  get variables() {
--- a/src/lib/exportSave.ts
+++ b/src/lib/exportSave.ts
@ -31,7 +31,7 @@ const save_ = async (file: ModelingAppFile, toastId: string) => {
        )
        toast.success(EXPORT_TOAST_MESSAGES.SUCCESS + ' [TEST]', {
          id: toastId,
-          duration: 5_000,
+          duration: 10_000,
        })
        return
      }
--- a/src/machines/settingsMachine.ts
+++ b/src/machines/settingsMachine.ts
@ -139,18 +139,20 @@ export const settingsMachine = setup({
      return () => darkModeMatcher?.removeEventListener('change', listener)
    }),
    registerCommands: fromCallback<
-      { type: 'update' },
+      { type: 'update'; settings: SettingsType },
      { settings: SettingsType; actor: AnyActorRef }
    >(({ input, receive, system }) => {
      // This assumes this actor is running in a system with a command palette
      const commandBarActor = system.get(ACTOR_IDS.COMMAND_BAR)
      // If the user wants to hide the settings commands
      //from the command bar don't add them.
-      if (settings.commandBar.includeSettings.current === false) return
+      if (settings.commandBar.includeSettings.current === false) {
+        return
+      }
      let commands: Command[] = []

-      const updateCommands = () =>
-        settingsWithCommandConfigs(input.settings)
+      const updateCommands = (newSettings: SettingsType) =>
+        settingsWithCommandConfigs(newSettings)
          .map((type) =>
            createSettingsCommand({
              type,
@ -175,14 +177,19 @@ export const settingsMachine = setup({
          data: { commands: commands },
        })

-      receive((event) => {
-        if (event.type !== 'update') return
+      receive(({ type, settings: newSettings }) => {
+        if (type !== 'update') {
+          return
+        }
        removeCommands()
-        commands = updateCommands()
+        commands =
+          newSettings.commandBar.includeSettings.current === false
+            ? []
+            : updateCommands(newSettings)
        addCommands()
      })

-      commands = updateCommands()
+      commands = updateCommands(settings)
      addCommands()

      return () => {
@ -205,7 +212,9 @@ export const settingsMachine = setup({
      const sceneInfra = rootContext.sceneInfra
      const sceneEntitiesManager = rootContext.sceneEntitiesManager

-      if (!sceneInfra || !sceneEntitiesManager) return
+      if (!sceneInfra || !sceneEntitiesManager) {
+        return
+      }
      const opposingTheme = getOppositeTheme(context.app.theme.current)
      sceneInfra.theme = opposingTheme
      sceneEntitiesManager.updateSegmentBaseColor(opposingTheme)
@ -213,13 +222,17 @@ export const settingsMachine = setup({
    setAllowOrbitInSketchMode: ({ context, self }) => {
      const rootContext = self.system.get('root').getSnapshot().context
      const sceneInfra = rootContext.sceneInfra
-      if (!sceneInfra.camControls) return
+      if (!sceneInfra.camControls) {
+        return
+      }
      sceneInfra.camControls._setting_allowOrbitInSketchMode =
        context.app.allowOrbitInSketchMode.current
      // ModelingMachineProvider will do a use effect to trigger the camera engine sync
    },
    toastSuccess: ({ event }) => {
-      if (!('data' in event)) return
+      if (!('data' in event)) {
+        return
+      }
      const eventParts = event.type.replace(/^set./, '').split('.') as [
        keyof typeof settings,
        string,
@ -435,6 +448,22 @@ export const settingsMachine = setup({
          actions: ['setSettingAtLevel', 'setThemeColor'],
        },

+        'set.commandBar.includeSettings': {
+          target: 'persisting settings',
+
+          actions: [
+            'setSettingAtLevel',
+            'toastSuccess',
+            sendTo(
+              'registerCommands',
+              ({ context: { currentProject: _, ...settings } }) => ({
+                type: 'update',
+                settings,
+              })
+            ),
+          ],
+        },
+
        'set.modeling.defaultUnit': {
          target: 'persisting settings',

@ -497,6 +526,13 @@ export const settingsMachine = setup({
            'setClientTheme',
            'setAllowOrbitInSketchMode',
            'sendThemeToWatcher',
+            sendTo(
+              'registerCommands',
+              ({ context: { currentProject: _, ...settings } }) => ({
+                type: 'update',
+                settings,
+              })
+            ),
          ],
        },

@ -510,6 +546,13 @@ export const settingsMachine = setup({
            'setClientTheme',
            'setAllowOrbitInSketchMode',
            'sendThemeToWatcher',
+            sendTo(
+              'registerCommands',
+              ({ context: { currentProject: _, ...settings } }) => ({
+                type: 'update',
+                settings,
+              })
+            ),
          ],
        },

@ -529,7 +572,13 @@ export const settingsMachine = setup({
            'clearProjectSettings',
            'clearCurrentProject',
            'setThemeColor',
-            sendTo('registerCommands', { type: 'update' }),
+            sendTo(
+              'registerCommands',
+              ({ context: { currentProject: _, ...settings } }) => ({
+                type: 'update',
+                settings,
+              })
+            ),
          ],
        },
      },
@ -582,6 +631,13 @@ export const settingsMachine = setup({
            'setClientTheme',
            'setAllowOrbitInSketchMode',
            'sendThemeToWatcher',
+            sendTo(
+              'registerCommands',
+              ({ context: { currentProject: _, ...settings } }) => ({
+                type: 'update',
+                settings,
+              })
+            ),
          ],
        },
        onError: {
@ -612,7 +668,13 @@ export const settingsMachine = setup({
            'setClientTheme',
            'setAllowOrbitInSketchMode',
            'sendThemeToWatcher',
-            sendTo('registerCommands', { type: 'update' }),
+            sendTo(
+              'registerCommands',
+              ({ context: { currentProject: _, ...settings } }) => ({
+                type: 'update',
+                settings,
+              })
+            ),
          ],
        },
        onError: 'idle',
--- a/src/routes/Settings.tsx
+++ b/src/routes/Settings.tsx
@ -1,6 +1,5 @@
 import { Dialog, Transition } from '@headlessui/react'
 import { Fragment, useEffect, useRef } from 'react'
-import { useHotkeys } from 'react-hotkeys-hook'
 import { useLocation, useNavigate, useSearchParams } from 'react-router-dom'

 import { CustomIcon } from '@src/components/CustomIcon'
@ -10,14 +9,19 @@ import { KeybindingsSectionsList } from '@src/components/Settings/KeybindingsSec
 import { SettingsSearchBar } from '@src/components/Settings/SettingsSearchBar'
 import { SettingsSectionsList } from '@src/components/Settings/SettingsSectionsList'
 import { SettingsTabs } from '@src/components/Settings/SettingsTabs'
-import { useDotDotSlash } from '@src/hooks/useDotDotSlash'
 import { PATHS } from '@src/lib/paths'
 import type { SettingsLevel } from '@src/lib/settings/settingsTypes'

 export const Settings = () => {
  const navigate = useNavigate()
  const [searchParams, setSearchParams] = useSearchParams()
-  const close = () => navigate(location.pathname.replace(PATHS.SETTINGS, ''))
+  const close = () => {
+    // This makes sure input texts are saved before closing the dialog (eg. default project name).
+    if (document.activeElement instanceof HTMLInputElement) {
+      document.activeElement.blur()
+    }
+    navigate(location.pathname.replace(PATHS.SETTINGS, ''))
+  }
  const location = useLocation()
  const isFileSettings = location.pathname.includes(PATHS.FILE)
  const searchParamTab =
@ -25,8 +29,6 @@ export const Settings = () => {
    (isFileSettings ? 'project' : 'user')

  const scrollRef = useRef<HTMLDivElement>(null)
-  const dotDotSlash = useDotDotSlash()
-  useHotkeys('esc', () => navigate(dotDotSlash()))

  // Scroll to the hash on load if it exists
  useEffect(() => {
Author	SHA1	Message	Date
Adam Chalmers	df167c0382	WIP	2025-05-14 14:18:57 -05:00
Adam Chalmers	15857e9191	Change sweep relativeTo flag defaults Default to trajectoryCurve, as Ryan wants	2025-05-14 14:18:11 -05:00
Adam Chalmers	1a32f664d0	Change sweep relativeTo flag defaults Default to trajectoryCurve, as Ryan wants	2025-05-14 13:57:12 -05:00
Adam Chalmers	5c2dfb8e40	Support new sweep flag (#6932 ) Closes https://github.com/KittyCAD/engine/issues/3115	2025-05-14 13:54:10 -05:00
Andrew Varga	0e341d7863	#6202 Save input value before closing settings dialogue (#6931 ) * call blur on current input before closing settings dialogue to save value * separate esc handling is not needed * lint	2025-05-14 14:16:23 -04:00
Jace Browning	6a03ff9596	Stop checking for intermediate export toasts (#6935 )	2025-05-14 17:53:44 +00:00
Jace Browning	d7bd0c937d	Keep test toast messages around for longer (#6930 ) * Keep test toast messages around for longer * Check for at least two locators I wasn't able to reproduce, but it's possible one stuck around from a previous test.	2025-05-14 12:24:38 -04:00
Andrew Varga	d3b2483f4f	Clear errors when leaving file to avoid seeing previous files errors (#6928 ) Clear errors when leaving file to avoid seeing previous files errors when opening new project Co-authored-by: Jace Browning <jacebrowning@gmail.com>	2025-05-14 17:20:04 +02:00
Frank Noirot	7838b7c9fd	Fix "include settings" setting to have an effect (#6917 ) * Fix "include settings" setting to have an effect I'm not sold on if we should have this setting, but this fixes it for now. The issue is was that the new callback actor approach was using a stale version of the settings every time it received an "update" event: JS closure problems. Now it receives the new settings as an event payload. * Update src/machines/settingsMachine.ts --------- Co-authored-by: Pierre Jacquier <pierrejacquier39@gmail.com>	2025-05-14 15:14:33 +00:00