Merge branch 'main' into jtran/fix-constraints

Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>

.github/ISSUE_TEMPLATE/cryptic_error.yml

@@ -1,37 +0,0 @@
-name: Cryptic KCL Error
-description: File a bug report for source code that produces a confusing error
-title: "[CRYPTIC]: "
-labels: ["cryptic-error"]
-assignees: []
-body:
-  - type: markdown
-    attributes:
-      value: "Thank you for taking the time to report a confusing error. Please provide as much information as possible to help us resolve it."
-
-  - type: textarea
-    id: kcl
-    attributes:
-      label: Paste minimal KCL source that produces a cryptic error
-      description: Minimal KCL reproducer that produces a cryptic error
-      placeholder: "const ..."
-      render: javascript
-    validations:
-      required: true
-
-  - type: textarea
-    id: expected-behavior
-    attributes:
-      label: Expected Behavior
-      description: Description of what you expected to happen (if you know).
-      placeholder: "I expected that..."
-    validations:
-      required: false
-
-  - type: textarea
-    id: additional-context
-    attributes:
-      label: Additional Context
-      description: Add any other context about the problem here.
-      placeholder: "Anything else you want to add..."
-    validations:
-      required: false

.github/workflows/ci.yml

@@ -13,7 +13,6 @@ on:
   # Will checkout the last commit from the default branch (main as of 2023-10-04)
 
 env:
-  CUT_RELEASE_PR: ${{ github.event_name == 'pull_request' && (contains(github.event.pull_request.title, 'Cut release v')) }}
   BUILD_RELEASE: ${{ github.event_name == 'release' || github.event_name == 'schedule' || github.event_name == 'pull_request' && (contains(github.event.pull_request.title, 'Cut release v')) }}
 
 concurrency:
@@ -111,14 +110,8 @@ jobs:
           echo "$(jq --arg name 'Zoo Modeling App (Nightly)' \
             '.productName=$name' src-tauri/tauri.release.conf.json --indent 2)" > src-tauri/tauri.release.conf.json
 
-      - name: Set updater test version
-        if: ${{ env.CUT_RELEASE_PR == 'true' }}
-        run: |
-          echo "$(jq --arg url 'https://dl.zoo.dev/releases/modeling-app/test/last_update.json' \
-            '.plugins.updater.endpoints[]=$url' src-tauri/tauri.release.conf.json --indent 2)" > src-tauri/tauri.release.conf.json
-
       - uses: actions/upload-artifact@v3
-        if: ${{ github.event_name == 'schedule' || env.CUT_RELEASE_PR == 'true' }}
+        if: github.event_name == 'schedule'
         with:
           path: |
             package.json
@@ -384,30 +377,6 @@ jobs:
           E2E_TAURI_ENABLED: true
           TS_NODE_COMPILER_OPTIONS: '{"module": "commonjs"}'
 
-      - uses: actions/download-artifact@v3
-        if: ${{ env.CUT_RELEASE_PR == 'true' }}
-
-      - name: Copy updated .json file for updater test
-        if: ${{ env.CUT_RELEASE_PR == 'true' }}
-        run: |
-          ls -l artifact
-          cp artifact/src-tauri/tauri.release.conf.json src-tauri/tauri.release.conf.json
-          cat src-tauri/tauri.release.conf.json
-
-      - name: Build the app (release, updater test)
-        if: ${{ env.CUT_RELEASE_PR == 'true' && matrix.os != 'ubuntu-latest' }}
-        env:
-          TAURI_CONF_ARGS: "-c ${{ matrix.os == 'windows-latest' && 'src-tauri\\tauri.release.conf.json' || 'src-tauri/tauri.release.conf.json' }}"
-          TAURI_BUNDLE_ARGS: "-b ${{ matrix.os == 'windows-latest' && 'msi' || 'dmg' }}"
-        run: "yarn tauri build ${{ env.TAURI_CONF_ARGS }} ${{ env.TAURI_BUNDLE_ARGS }} ${{ env.TAURI_ARGS_MACOS }}"
-
-      - uses: actions/upload-artifact@v3
-        if: ${{ env.CUT_RELEASE_PR == 'true' && matrix.os != 'ubuntu-latest' }}
-        with:
-          path: "${{ matrix.os == 'macos-14' && 'src-tauri/target/universal-apple-darwin/release/bundle/dmg/*.dmg' || 'src-tauri/target/release/bundle/msi/*.msi' }}"
-          name: updater-test
-
-
   publish-apps-release:
     permissions:
       contents: write

.github/workflows/playwright.yml

@@ -83,20 +83,6 @@ jobs:
       uses: Swatinem/rust-cache@v2
       with:
         workspaces: './src/wasm-lib'
-    - name: Install vector
-      run: |
-        curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev > /tmp/vector.sh
-        chmod +x /tmp/vector.sh
-        /tmp/vector.sh -y -no-modify-path
-        mkdir -p /tmp/vector
-        cp .github/workflows/vector.toml /tmp/vector.toml
-        sed -i "s#GITHUB_WORKFLOW#${GITHUB_WORKFLOW}#g" /tmp/vector.toml
-        sed -i "s#GITHUB_REPOSITORY#${GITHUB_REPOSITORY}#g" /tmp/vector.toml
-        sed -i "s#GITHUB_SHA#${GITHUB_SHA}#g" /tmp/vector.toml
-        sed -i "s#GITHUB_REF_NAME#${GITHUB_REF_NAME}#g" /tmp/vector.toml
-        sed -i "s#GH_ACTIONS_AXIOM_TOKEN#${{secrets.GH_ACTIONS_AXIOM_TOKEN}}#g" /tmp/vector.toml
-        cat /tmp/vector.toml
-        ${HOME}/.vector/bin/vector --config /tmp/vector.toml &
     - name: Build Wasm (because rust diff)
       if: needs.check-rust-changes.outputs.rust-changed == 'true'
       run: yarn build:wasm
@@ -153,60 +139,27 @@ jobs:
       with:
         name: test-results-ubuntu-${{ github.sha }}
         path: test-results/
-    - name: Run ubuntu/chrome flow (with retries)
+    - name: Run ubuntu/chrome flow retry failures
       id: retry
       if: always()
       run: |
-        if [[ ! -f "test-results/.last-run.json" ]]; then
+        if [[ -d "test-results" ]];
-            # if no last run artifact, than run plawright normally
+        then if [[ $(ls -1 "test-results" | wc -l) != "0" ]];
-            echo "run playwright normally"
+          then echo "retried=true" >> $GITHUB_OUTPUT;
-            yarn playwright test --project="Google Chrome" e2e/playwright/flow-tests.spec.ts || true
+          else echo "retried=false" >> $GITHUB_OUTPUT; exit 0;
-            # # send to axiom
+          fi;
-            node playwrightProcess.mjs | tee /tmp/github-actions.log > /dev/null 2>&1
+        else echo "retried=false" >> $GITHUB_OUTPUT; exit 0;
-        fi
+        fi;
-        
+        yarn playwright test --project="Google Chrome" --last-failed e2e/playwright/flow-tests.spec.ts
-        retry=1
+      env:
-        max_retrys=4
+        CI: true
-        
+        token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
-        # retry failed tests, doing our own retries because using inbuilt playwright retries causes connection issues
+    - name: Run ubuntu/chrome flow
-        while [[ $retry -le $max_retrys ]]; do
+      if: steps.retry.outputs.retried == 'false'
-            if [[ -f "test-results/.last-run.json" ]]; then
+      run: yarn playwright test --project="Google Chrome" e2e/playwright/flow-tests.spec.ts
-                failed_tests=$(jq '.failedTests | length' test-results/.last-run.json)
-                if [[ $failed_tests -gt 0 ]]; then
-                    echo "retried=true" >>$GITHUB_OUTPUT
-                    echo "run playwright with last failed tests and retry $retry"
-                    yarn playwright test --project="Google Chrome" --last-failed e2e/playwright/flow-tests.spec.ts || true
-                    # send to axiom
-                    node playwrightProcess.mjs | tee /tmp/github-actions.log > /dev/null 2>&1
-                    retry=$((retry + 1))
-                else
-                    echo "retried=false" >>$GITHUB_OUTPUT
-                    exit 0
-                fi
-            else
-                echo "retried=false" >>$GITHUB_OUTPUT
-                exit 0
-            fi
-        done
-        
-        echo "retried=false" >>$GITHUB_OUTPUT
-        
-        if [[ -f "test-results/.last-run.json" ]]; then
-            failed_tests=$(jq '.failedTests | length' test-results/.last-run.json)
-            if [[ $failed_tests -gt 0 ]]; then
-                # if it still fails after 3 retrys, then fail the job
-                exit 1
-            fi
-        fi
-        exit 0
       env:
         CI: true
         token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
-    - name: send to axiom
-      if: always()
-      shell: bash
-      run: |
-        node playwrightProcess.mjs | tee /tmp/github-actions.log
     - uses: actions/upload-artifact@v4
       if: always()
       with:
@@ -273,20 +226,6 @@ jobs:
       uses: Swatinem/rust-cache@v2
       with:
         workspaces: './src/wasm-lib'
-    - name: Install vector
-      run: |
-        curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev > /tmp/vector.sh
-        chmod +x /tmp/vector.sh
-        /tmp/vector.sh -y -no-modify-path
-        mkdir -p /tmp/vector
-        cp .github/workflows/vector.toml /tmp/vector.toml
-        sed -i "" "s#GITHUB_WORKFLOW#${GITHUB_WORKFLOW}#g" /tmp/vector.toml
-        sed -i "" "s#GITHUB_REPOSITORY#${GITHUB_REPOSITORY}#g" /tmp/vector.toml
-        sed -i "" "s#GITHUB_SHA#${GITHUB_SHA}#g" /tmp/vector.toml
-        sed -i "" "s#GITHUB_REF_NAME#${GITHUB_REF_NAME}#g" /tmp/vector.toml
-        sed -i "" "s#GH_ACTIONS_AXIOM_TOKEN#${{secrets.GH_ACTIONS_AXIOM_TOKEN}}#g" /tmp/vector.toml
-        cat /tmp/vector.toml
-        ${HOME}/.vector/bin/vector --config /tmp/vector.toml &
     - name: Build Wasm (because rust diff)
       if: needs.check-rust-changes.outputs.rust-changed == 'true'
       run: yarn build:wasm
@@ -302,52 +241,26 @@ jobs:
       with:
         name: test-results-macos-${{ github.sha }}
         path: test-results/
-    - name: Run macos/safari flow (with retries)
+    - name: Run macos/safari flow retry failures
       id: retry
       if: always()
       run: |
-        if [[ ! -f "test-results/.last-run.json" ]]; then
+        if [[ -d "test-results" ]];
-            # if no last run artifact, than run plawright normally
+        then if [[ $(ls -1 "test-results" | wc -l) != "0" ]];
-            echo "run playwright normally"
+          then echo "retried=true" >> $GITHUB_OUTPUT;
-            yarn playwright test --project="webkit" e2e/playwright/flow-tests.spec.ts || true
+          else echo "retried=false" >> $GITHUB_OUTPUT; exit 0;
-            # # send to axiom
+          fi;
-            node playwrightProcess.mjs | tee /tmp/github-actions.log > /dev/null 2>&1
+        else echo "retried=false" >> $GITHUB_OUTPUT; exit 0;
-        fi
+        fi;
-        
+        yarn playwright test --project="webkit" --last-failed e2e/playwright/flow-tests.spec.ts
-        retry=1
+      env:
-        max_retrys=4
+        CI: true
-        
+        token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
-        # retry failed tests, doing our own retries because using inbuilt playwright retries causes connection issues
+    - name: Run macos/safari flow
-        while [[ $retry -le $max_retrys ]]; do
+      if: steps.retry.outputs.retried == 'false'
-            if [[ -f "test-results/.last-run.json" ]]; then
+      # webkit doesn't work on Ubuntu because of the same reason tauri doesn't (webRTC issues)
-                failed_tests=$(jq '.failedTests | length' test-results/.last-run.json)
+      # TODO remove this and the matrix and run all tests on ubuntu when this is fixed
-                if [[ $failed_tests -gt 0 ]]; then
+      run: yarn playwright test --project="webkit" e2e/playwright/flow-tests.spec.ts
-                    echo "retried=true" >>$GITHUB_OUTPUT
-                    echo "run playwright with last failed tests and retry $retry"
-                    yarn playwright test --project="webkit" --last-failed e2e/playwright/flow-tests.spec.ts || true
-                    # send to axiom
-                    node playwrightProcess.mjs | tee /tmp/github-actions.log > /dev/null 2>&1
-                    retry=$((retry + 1))
-                else
-                    echo "retried=false" >>$GITHUB_OUTPUT
-                    exit 0
-                fi
-            else
-                echo "retried=false" >>$GITHUB_OUTPUT
-                exit 0
-            fi
-        done
-        
-        echo "retried=false" >>$GITHUB_OUTPUT
-        
-        if [[ -f "test-results/.last-run.json" ]]; then
-            failed_tests=$(jq '.failedTests | length' test-results/.last-run.json)
-            if [[ $failed_tests -gt 0 ]]; then
-                # if it still fails after 3 retrys, then fail the job
-                exit 1
-            fi
-        fi
-        exit 0
       env:
         CI: true
         token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}

README.md

@@ -124,40 +124,20 @@ Before you submit a contribution PR to this repo, please ensure that:
 
 ## Release a new version
 
-#### 1. Bump the versions by running `./make-release.sh` and create a Cut Release PR
+1. Bump the versions by running `./make-realease.sh` while on a fresh pull of main
 
-That will create the branch with the updated json files for you:
+That will create the branch with the updated json files for you.
-- run `./make-release.sh` or `./make-release.sh patch` for a patch update;
+run `./make-release.sh` for a patch update
-- run `./make-release.sh minor` for minor; or
+run `./make-release.sh "minor"` for minor
-- run `./make-release.sh major` for major.
+run `./make-release.sh "major"` for major
 
-After it runs you should just need the push the branch and open a PR.
+After it runs you should just need to push the push the branch and open a PR (it will suggest a changelog for you too, delete any that are not user facing)
 
-**Important:** It needs to be prefixed with `Cut release v` to build in release mode and a few other things to test in the best context possible, the intent would be for instance to have `Cut release v1.2.3` for the `v1.2.3` release candidate.
+The PR may serve as a place to discuss the human-readable changelog and extra QA. 
 
-The PR may then serve as a place to discuss the human-readable changelog and extra QA. The `make-release.sh` tool suggests a changelog for you too to be used as PR description, just make sure to delete lines that are not user facing.
+2. Merge the PR
-
-#### 2. Smoke test artifacts from the Cut Release PR
-
-The release builds can be find under the `artifact` zip, at the very bottom of the `ci` action page for each commit on this branch.
-
-We don't have a strict process, but click around and check for anything obvious, posting results as comments in the Cut Release PR.
-
-The other `ci` output in Cut Release PRs is `updater-test`, because we don't have a way to test this fully automated, we have a semi-automated process. Download updater-test zip file, install the app, run it, expect an updater prompt to a dummy v0.99.99, install it and check that the app comes back at that version (on both macOS and Windows).
-
-#### 3. Merge the Cut Release PR
-
-This will kick the `create-release` action, that creates a _Draft_ release out of this Cut Release PR merge after less than a minute, with the new version as title and Cut Release PR as description.
-
-
-#### 4. Publish the release
-
-Head over to https://github.com/KittyCAD/modeling-app/releases, the draft release corresponding to the merged Cut Release PR should show up at the top as _Draft_. Click on it, verify the content, and hit _Publish_.
-
-#### 5. Profit
-
-A new Action kicks in at https://github.com/KittyCAD/modeling-app/actions, which can be found under `release` event filter.
 
+3. Profit (A new Action kicks in at https://github.com/KittyCAD/modeling-app/actions if the PR was correctly named)
 
 ## Fuzzing the parser
 

docs/kcl/angledLineThatIntersects.md

@@ -22,7 +22,7 @@ const exampleSketch = startSketchOn('XZ')
   |> lineTo([0, 20], %)
   |> angledLineThatIntersects({
        angle: 80,
-       intersectTag: lineToIntersect,
+       intersectTag: 'lineToIntersect',
        offset: 10
      }, %)
   |> close(%)
@@ -41,92 +41,6 @@ const example = extrude(10, exampleSketch)
 	angle: number,
 	// The tag of the line to intersect with.
 	intersectTag: {
-	// Engine information for a tag.
-	info: {
-	// The id of the tagged object.
-	id: uuid,
-	// The path the tag is on.
-	path: {
-	// The from point.
-	from: [number, number],
-	// The tag of the path.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	// The to point.
-	to: [number, number],
-},
-	// The sketch group the tag is on.
-	sketchGroup: uuid,
-	// The surface information for the tag.
-	surface: {
-	// The face id for the extrude plane.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "extrudePlane",
-} |
-{
-	// The face id for the extrude plane.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
-},
-},
 	value: string,
 },
 	// The offset from the intersecting line.
@@ -136,7 +50,7 @@ const example = extrude(10, exampleSketch)
 * `sketch_group`: `SketchGroup` - A sketch group is a collection of paths. (REQUIRED)
 ```js
 {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -178,21 +92,15 @@ const example = extrude(10, exampleSketch)
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -210,7 +118,7 @@ const example = extrude(10, exampleSketch)
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: SketchSurface,
@@ -361,38 +269,6 @@ const example = extrude(10, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.
@@ -548,7 +424,7 @@ const example = extrude(10, exampleSketch)
 `SketchGroup` - A sketch group is a collection of paths.
 ```js
 {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -590,21 +466,15 @@ const example = extrude(10, exampleSketch)
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -622,7 +492,7 @@ const example = extrude(10, exampleSketch)
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: SketchSurface,
@@ -773,38 +643,6 @@ const example = extrude(10, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.

docs/kcl/angledLineToY.md

@@ -41,7 +41,7 @@ const example = extrude(10, exampleSketch)
 * `sketch_group`: `SketchGroup` - A sketch group is a collection of paths. (REQUIRED)
 ```js
 {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -83,21 +83,15 @@ const example = extrude(10, exampleSketch)
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -115,7 +109,7 @@ const example = extrude(10, exampleSketch)
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: SketchSurface,
@@ -266,38 +260,6 @@ const example = extrude(10, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.
@@ -453,7 +415,7 @@ const example = extrude(10, exampleSketch)
 `SketchGroup` - A sketch group is a collection of paths.
 ```js
 {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -495,21 +457,15 @@ const example = extrude(10, exampleSketch)
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -527,7 +483,7 @@ const example = extrude(10, exampleSketch)
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: SketchSurface,
@@ -678,38 +634,6 @@ const example = extrude(10, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.

docs/kcl/extrude.md

@@ -19,8 +19,8 @@ const example = startSketchOn('XZ')
   |> startProfileAt([0, 0], %)
   |> line([10, 0], %)
   |> arc({
-       angleStart: 120,
+       angle_end: 0,
-       angleEnd: 0,
+       angle_start: 120,
        radius: 5
      }, %)
   |> line([5, 0], %)
@@ -41,8 +41,8 @@ const example = startSketchOn('XZ')
 const exampleSketch = startSketchOn('XZ')
   |> startProfileAt([-10, 0], %)
   |> arc({
-       angleStart: 120,
+       angle_end: -60,
-       angleEnd: -60,
+       angle_start: 120,
        radius: 5
      }, %)
   |> line([10, 0], %)
@@ -67,7 +67,7 @@ const example = extrude(10, exampleSketch)
 * `sketch_group_set`: `SketchGroupSet` - A sketch group or a group of sketch groups. (REQUIRED)
 ```js
 {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -109,21 +109,15 @@ const example = extrude(10, exampleSketch)
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -141,7 +135,7 @@ const example = extrude(10, exampleSketch)
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: SketchSurface,
@@ -292,38 +286,6 @@ const example = extrude(10, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.
@@ -479,21 +441,15 @@ const example = extrude(10, exampleSketch)
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -511,7 +467,7 @@ const example = extrude(10, exampleSketch)
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -553,21 +509,15 @@ const example = extrude(10, exampleSketch)
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -619,38 +569,6 @@ const example = extrude(10, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.
@@ -825,38 +743,6 @@ const example = extrude(10, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 } |
 {

docs/kcl/index.md

@@ -20,11 +20,6 @@ layout: manual
 * [`angledLineToY`](kcl/angledLineToY)
 * [`arc`](kcl/arc)
 * [`asin`](kcl/asin)
-* [`assert`](kcl/assert)
-* [`assertGreaterThan`](kcl/assertGreaterThan)
-* [`assertGreaterThanOrEq`](kcl/assertGreaterThanOrEq)
-* [`assertLessThan`](kcl/assertLessThan)
-* [`assertLessThanOrEq`](kcl/assertLessThanOrEq)
 * [`atan`](kcl/atan)
 * [`bezierCurve`](kcl/bezierCurve)
 * [`ceil`](kcl/ceil)
@@ -36,13 +31,13 @@ layout: manual
 * [`extrude`](kcl/extrude)
 * [`fillet`](kcl/fillet)
 * [`floor`](kcl/floor)
+* [`getEdge`](kcl/getEdge)
 * [`getNextAdjacentEdge`](kcl/getNextAdjacentEdge)
 * [`getOppositeEdge`](kcl/getOppositeEdge)
 * [`getPreviousAdjacentEdge`](kcl/getPreviousAdjacentEdge)
 * [`helix`](kcl/helix)
 * [`hole`](kcl/hole)
 * [`import`](kcl/import)
-* [`int`](kcl/int)
 * [`lastSegX`](kcl/lastSegX)
 * [`lastSegY`](kcl/lastSegY)
 * [`legAngX`](kcl/legAngX)
@@ -62,7 +57,6 @@ layout: manual
 * [`patternLinear3d`](kcl/patternLinear3d)
 * [`patternTransform`](kcl/patternTransform)
 * [`pi`](kcl/pi)
-* [`polar`](kcl/polar)
 * [`pow`](kcl/pow)
 * [`profileStart`](kcl/profileStart)
 * [`profileStartX`](kcl/profileStartX)

docs/kcl/profileStartX.md

@@ -29,7 +29,7 @@ const sketch001 = startSketchOn('XY')
 * `sketch_group`: `SketchGroup` - A sketch group is a collection of paths. (REQUIRED)
 ```js
 {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -71,21 +71,15 @@ const sketch001 = startSketchOn('XY')
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -103,7 +97,7 @@ const sketch001 = startSketchOn('XY')
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: SketchSurface,
@@ -254,38 +248,6 @@ const sketch001 = startSketchOn('XY')
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.

docs/kcl/profileStartY.md

@@ -28,7 +28,7 @@ const sketch001 = startSketchOn('XY')
 * `sketch_group`: `SketchGroup` - A sketch group is a collection of paths. (REQUIRED)
 ```js
 {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: {
@@ -70,21 +70,15 @@ const sketch001 = startSketchOn('XY')
 	// Chamfers or fillets on this extrude group.
 	filletOrChamfers: [{
 	// The engine id of the edge to fillet.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this fillet.
 	id: uuid,
 	radius: number,
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
 	type: "fillet",
 } |
 {
 	// The engine id of the edge to chamfer.
-	edgeId: uuid,
+	edge_id: uuid,
 	// The id of the engine command that called this chamfer.
 	id: uuid,
 	length: number,
@@ -102,7 +96,7 @@ const sketch001 = startSketchOn('XY')
 	id: uuid,
 	// The sketch group.
 	sketchGroup: {
-	// The id of the sketch group (this will change when the engine's reference to it changes.
+	// The id of the sketch group.
 	id: uuid,
 	// What the sketch is on (can be a plane or a face).
 	on: SketchSurface,
@@ -253,38 +247,6 @@ const sketch001 = startSketchOn('XY')
 	value: string,
 },
 	type: "extrudeArc",
-} |
-{
-	// The id for the chamfer surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "chamfer",
-} |
-{
-	// The id for the fillet surface.
-	faceId: uuid,
-	// The id of the geometry.
-	id: uuid,
-	// The source range.
-	sourceRange: [number, number],
-	// The tag.
-	tag: {
-	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
-	end: number,
-	start: number,
-	value: string,
-},
-	type: "fillet",
 }],
 },
 	// The id of the face.

docs/kcl/segAng.md

@@ -9,7 +9,7 @@ Returns the angle of the segment.
 
 
 ```js
-segAng(tag: TagIdentifier) -> number
+segAng(segment_name: TagIdentifier, sketch_group: SketchGroup) -> number
 ```
 
 ### Examples
@@ -20,9 +20,9 @@ const exampleSketch = startSketchOn('XZ')
   |> line([10, 0], %)
   |> line([5, 10], %, $seg01)
   |> line([-10, 0], %)
-  |> angledLine([segAng(seg01), 10], %)
+  |> angledLine([segAng(seg01, %), 10], %)
   |> line([-10, 0], %)
-  |> angledLine([segAng(seg01), -15], %)
+  |> angledLine([segAng(seg01, %), -15], %)
   |> close(%)
 
 const example = extrude(4, exampleSketch)
@@ -32,15 +32,89 @@ const example = extrude(4, exampleSketch)
 
 ### Arguments
 
-* `tag`: `TagIdentifier` (REQUIRED)
+* `segment_name`: `TagIdentifier` (REQUIRED)
 ```js
 {
-	// Engine information for a tag.
+	value: string,
-	info: {
+}
-	// The id of the tagged object.
+```
+* `sketch_group`: `SketchGroup` - A sketch group is a collection of paths. (REQUIRED)
+```js
+{
+	// The id of the sketch group.
 	id: uuid,
-	// The path the tag is on.
+	// What the sketch is on (can be a plane or a face).
-	path: {
+	on: {
+	// The id of the plane.
+	id: uuid,
+	// Origin of the plane.
+	origin: {
+	x: number,
+	y: number,
+	z: number,
+},
+	type: "plane",
+	// Type for a plane.
+	value: "XY" | "XZ" | "YZ" | "Custom",
+	// What should the plane’s X axis be?
+	xAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// What should the plane’s Y axis be?
+	yAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// The z-axis (normal).
+	zAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+} |
+{
+	// The extrude group the face is on.
+	extrudeGroup: {
+	// The id of the extrusion end cap
+	endCapId: uuid,
+	// Chamfers or fillets on this extrude group.
+	filletOrChamfers: [{
+	// The engine id of the edge to fillet.
+	edge_id: uuid,
+	// The id of the engine command that called this fillet.
+	id: uuid,
+	radius: number,
+	type: "fillet",
+} |
+{
+	// The engine id of the edge to chamfer.
+	edge_id: uuid,
+	// The id of the engine command that called this chamfer.
+	id: uuid,
+	length: number,
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	type: "chamfer",
+}],
+	// The height of the extrude group.
+	height: number,
+	// The id of the extrude group.
+	id: uuid,
+	// The sketch group.
+	sketchGroup: {
+	// The id of the sketch group.
+	id: uuid,
+	// What the sketch is on (can be a plane or a face).
+	on: SketchSurface,
+	// The starting path.
+	start: {
 	// The from point.
 	from: [number, number],
 	// The tag of the path.
@@ -53,10 +127,109 @@ const example = extrude(4, exampleSketch)
 	// The to point.
 	to: [number, number],
 },
-	// The sketch group the tag is on.
+	// Tag identifiers that have been declared in this sketch group.
-	sketchGroup: uuid,
+	tags: {
-	// The surface information for the tag.
+},
-	surface: {
+	// The paths in the sketch group.
+	value: [{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "ToPoint",
+} |
+{
+	// arc's direction
+	ccw: string,
+	// the arc's center
+	center: [number, number],
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArcTo",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArc",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Horizontal",
+	// The x coordinate.
+	x: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "AngledLineTo",
+	// The x coordinate.
+	x: number,
+	// The y coordinate.
+	y: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Base",
+}],
+},
+	// The id of the extrusion start cap
+	startCapId: uuid,
+	// The extrude surfaces.
+	value: [{
 	// The face id for the extrude plane.
 	faceId: uuid,
 	// The id of the geometry.
@@ -87,41 +260,144 @@ const example = extrude(4, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
+}],
-{
+},
-	// The id for the chamfer surface.
+	// The id of the face.
-	faceId: uuid,
-	// The id of the geometry.
 	id: uuid,
-	// The source range.
+	type: "face",
-	sourceRange: [number, number],
+	// The tag of the face.
-	// The tag.
+	value: string,
+	// What should the face’s X axis be?
+	xAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// What should the face’s Y axis be?
+	yAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// The z-axis (normal).
+	zAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+},
+	// The starting path.
+	start: {
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
 	tag: {
 	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
 	end: number,
 	start: number,
 	value: string,
 },
-	type: "chamfer",
+	// The to point.
-} |
+	to: [number, number],
-{
+},
-	// The id for the fillet surface.
+	// Tag identifiers that have been declared in this sketch group.
-	faceId: uuid,
+	tags: {
-	// The id of the geometry.
+},
-	id: uuid,
+	// The paths in the sketch group.
-	// The source range.
+	value: [{
-	sourceRange: [number, number],
+	// The from point.
-	// The tag.
+	from: [number, number],
+	// The tag of the path.
 	tag: {
 	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
 	end: number,
 	start: number,
 	value: string,
 },
-	type: "fillet",
+	// The to point.
-},
+	to: [number, number],
-},
+	type: "ToPoint",
+} |
+{
+	// arc's direction
+	ccw: string,
+	// the arc's center
+	center: [number, number],
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
 	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArcTo",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArc",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Horizontal",
+	// The x coordinate.
+	x: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "AngledLineTo",
+	// The x coordinate.
+	x: number,
+	// The y coordinate.
+	y: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Base",
+}],
 }
 ```
 

docs/kcl/segEndY.md

@@ -9,7 +9,7 @@ Returns the segment end of y.
 
 
 ```js
-segEndY(tag: TagIdentifier) -> number
+segEndY(segment_name: TagIdentifier, sketch_group: SketchGroup) -> number
 ```
 
 ### Examples
@@ -20,7 +20,7 @@ const exampleSketch = startSketchOn('XZ')
   |> line([20, 0], %)
   |> line([0, 3], %, $thing)
   |> line([-10, 0], %)
-  |> line([0, segEndY(thing)], %)
+  |> line([0, segEndY(thing, %)], %)
   |> line([-10, 0], %)
   |> close(%)
 
@@ -31,15 +31,89 @@ const example = extrude(5, exampleSketch)
 
 ### Arguments
 
-* `tag`: `TagIdentifier` (REQUIRED)
+* `segment_name`: `TagIdentifier` (REQUIRED)
 ```js
 {
-	// Engine information for a tag.
+	value: string,
-	info: {
+}
-	// The id of the tagged object.
+```
+* `sketch_group`: `SketchGroup` - A sketch group is a collection of paths. (REQUIRED)
+```js
+{
+	// The id of the sketch group.
 	id: uuid,
-	// The path the tag is on.
+	// What the sketch is on (can be a plane or a face).
-	path: {
+	on: {
+	// The id of the plane.
+	id: uuid,
+	// Origin of the plane.
+	origin: {
+	x: number,
+	y: number,
+	z: number,
+},
+	type: "plane",
+	// Type for a plane.
+	value: "XY" | "XZ" | "YZ" | "Custom",
+	// What should the plane’s X axis be?
+	xAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// What should the plane’s Y axis be?
+	yAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// The z-axis (normal).
+	zAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+} |
+{
+	// The extrude group the face is on.
+	extrudeGroup: {
+	// The id of the extrusion end cap
+	endCapId: uuid,
+	// Chamfers or fillets on this extrude group.
+	filletOrChamfers: [{
+	// The engine id of the edge to fillet.
+	edge_id: uuid,
+	// The id of the engine command that called this fillet.
+	id: uuid,
+	radius: number,
+	type: "fillet",
+} |
+{
+	// The engine id of the edge to chamfer.
+	edge_id: uuid,
+	// The id of the engine command that called this chamfer.
+	id: uuid,
+	length: number,
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	type: "chamfer",
+}],
+	// The height of the extrude group.
+	height: number,
+	// The id of the extrude group.
+	id: uuid,
+	// The sketch group.
+	sketchGroup: {
+	// The id of the sketch group.
+	id: uuid,
+	// What the sketch is on (can be a plane or a face).
+	on: SketchSurface,
+	// The starting path.
+	start: {
 	// The from point.
 	from: [number, number],
 	// The tag of the path.
@@ -52,10 +126,109 @@ const example = extrude(5, exampleSketch)
 	// The to point.
 	to: [number, number],
 },
-	// The sketch group the tag is on.
+	// Tag identifiers that have been declared in this sketch group.
-	sketchGroup: uuid,
+	tags: {
-	// The surface information for the tag.
+},
-	surface: {
+	// The paths in the sketch group.
+	value: [{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "ToPoint",
+} |
+{
+	// arc's direction
+	ccw: string,
+	// the arc's center
+	center: [number, number],
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArcTo",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArc",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Horizontal",
+	// The x coordinate.
+	x: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "AngledLineTo",
+	// The x coordinate.
+	x: number,
+	// The y coordinate.
+	y: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Base",
+}],
+},
+	// The id of the extrusion start cap
+	startCapId: uuid,
+	// The extrude surfaces.
+	value: [{
 	// The face id for the extrude plane.
 	faceId: uuid,
 	// The id of the geometry.
@@ -86,41 +259,144 @@ const example = extrude(5, exampleSketch)
 	value: string,
 },
 	type: "extrudeArc",
-} |
+}],
-{
+},
-	// The id for the chamfer surface.
+	// The id of the face.
-	faceId: uuid,
-	// The id of the geometry.
 	id: uuid,
-	// The source range.
+	type: "face",
-	sourceRange: [number, number],
+	// The tag of the face.
-	// The tag.
+	value: string,
+	// What should the face’s X axis be?
+	xAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// What should the face’s Y axis be?
+	yAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+	// The z-axis (normal).
+	zAxis: {
+	x: number,
+	y: number,
+	z: number,
+},
+},
+	// The starting path.
+	start: {
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
 	tag: {
 	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
 	end: number,
 	start: number,
 	value: string,
 },
-	type: "chamfer",
+	// The to point.
-} |
+	to: [number, number],
-{
+},
-	// The id for the fillet surface.
+	// Tag identifiers that have been declared in this sketch group.
-	faceId: uuid,
+	tags: {
-	// The id of the geometry.
+},
-	id: uuid,
+	// The paths in the sketch group.
-	// The source range.
+	value: [{
-	sourceRange: [number, number],
+	// The from point.
-	// The tag.
+	from: [number, number],
+	// The tag of the path.
 	tag: {
 	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
 	end: number,
 	start: number,
 	value: string,
 },
-	type: "fillet",
+	// The to point.
-},
+	to: [number, number],
-},
+	type: "ToPoint",
+} |
+{
+	// arc's direction
+	ccw: string,
+	// the arc's center
+	center: [number, number],
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
 	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArcTo",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "TangentialArc",
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Horizontal",
+	// The x coordinate.
+	x: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "AngledLineTo",
+	// The x coordinate.
+	x: number,
+	// The y coordinate.
+	y: number,
+} |
+{
+	// The from point.
+	from: [number, number],
+	// The tag of the path.
+	tag: {
+	digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
+	end: number,
+	start: number,
+	value: string,
+},
+	// The to point.
+	to: [number, number],
+	type: "Base",
+}],
 }
 ```
 

e2e/playwright/snapshot-tests.spec.ts

@@ -64,27 +64,27 @@ const part001 = startSketchOn('-XZ')
   |> angledLineToY({
         angle: topAng,
         to: totalHeightHalf,
-      }, %, $seg04)
+      }, %, 'seg04')
-  |> xLineTo(totalLen, %, $seg03')
+  |> xLineTo(totalLen, %, 'seg03')
-  |> yLine(-armThick, %, $seg01)
+  |> yLine(-armThick, %, 'seg01')
   |> angledLineThatIntersects({
         angle: HALF_TURN,
         offset: -armThick,
-        intersectTag: seg04
+        intersectTag: 'seg04'
       }, %)
-  |> angledLineToY([segAng(seg04, %) + 180, ZERO], %)
+  |> angledLineToY([segAng('seg04', %) + 180, ZERO], %)
   |> angledLineToY({
         angle: -bottomAng,
         to: -totalHeightHalf - armThick,
-      }, %, $seg02)
+      }, %, 'seg02')
-  |> xLineTo(segEndX(seg03, %) + 0, %)
+  |> xLineTo(segEndX('seg03', %) + 0, %)
-  |> yLine(-segLen(seg01, %), %)
+  |> yLine(-segLen('seg01', %), %)
   |> angledLineThatIntersects({
         angle: HALF_TURN,
         offset: -armThick,
-        intersectTag: seg02
+        intersectTag: 'seg02'
       }, %)
-  |> angledLineToY([segAng(seg02, %) + 180, -baseHeight], %)
+  |> angledLineToY([segAng('seg02', %) + 180, -baseHeight], %)
   |> xLineTo(ZERO, %)
   |> close(%)
   |> extrude(4, %)`
@@ -431,9 +431,7 @@ test('Draft segments should look right', async ({ page, context }) => {
   |> line([7.25, 0], %)`
   await expect(page.locator('.cm-content')).toHaveText(code)
 
-  await page
+  await page.getByRole('button', { name: 'Tangential Arc' }).click()
-    .getByRole('button', { name: 'Tangential Arc', exact: true })
-    .click()
 
   await page.mouse.move(startXPx + PUR * 30, 500 - PUR * 20, { steps: 10 })
 
@@ -477,10 +475,8 @@ test('Draft rectangles should look right', async ({ page, context }) => {
   const startXPx = 600
 
   // Equip the rectangle tool
-  await page.getByRole('button', { name: 'Line', exact: true }).click()
+  await page.getByRole('button', { name: 'Line' }).click()
-  await page
+  await page.getByRole('button', { name: 'Rectangle' }).click()
-    .getByRole('button', { name: 'Corner rectangle', exact: true })
-    .click()
 
   // Draw the rectangle
   await page.mouse.click(startXPx + PUR * 20, 500 - PUR * 30)
@@ -539,9 +535,7 @@ test.describe('Client side scene scale should match engine scale', () => {
   |> line([7.25, 0], %)`
     await expect(u.codeLocator).toHaveText(code)
 
-    await page
+    await page.getByRole('button', { name: 'Tangential Arc' }).click()
-      .getByRole('button', { name: 'Tangential Arc', exact: true })
-      .click()
     await page.waitForTimeout(100)
 
     await page.mouse.click(startXPx + PUR * 30, 500 - PUR * 20)
@@ -551,9 +545,7 @@ test.describe('Client side scene scale should match engine scale', () => {
     await expect(u.codeLocator).toHaveText(code)
 
     // click tangential arc tool again to unequip it
-    await page
+    await page.getByRole('button', { name: 'Tangential Arc' }).click()
-      .getByRole('button', { name: 'Tangential Arc', exact: true })
-      .click()
     await page.waitForTimeout(100)
 
     // screen shot should show the sketch
@@ -642,9 +634,7 @@ test.describe('Client side scene scale should match engine scale', () => {
   |> line([184.3, 0], %)`
     await expect(u.codeLocator).toHaveText(code)
 
-    await page
+    await page.getByRole('button', { name: 'Tangential Arc' }).click()
-      .getByRole('button', { name: 'Tangential Arc', exact: true })
-      .click()
     await page.waitForTimeout(100)
 
     await page.mouse.click(startXPx + PUR * 30, 500 - PUR * 20)
@@ -653,9 +643,7 @@ test.describe('Client side scene scale should match engine scale', () => {
   |> tangentialArcTo([551.2, -62.01], %)`
     await expect(u.codeLocator).toHaveText(code)
 
-    await page
+    await page.getByRole('button', { name: 'Tangential Arc' }).click()
-      .getByRole('button', { name: 'Tangential Arc', exact: true })
-      .click()
     await page.waitForTimeout(100)
 
     // screen shot should show the sketch