ci: Add yarn test of packages/codemirror-lang-kcl (#5035 )

* ci: Add yarn test of packages/codemirror-lang-kcl * Fix CI error running tests * Fix postcss config error
turns on helix from edge (#5036 )
2025-01-14 09:30:08 -05:00 · 2025-01-13 23:34:43 +00:00 · 2025-01-13 17:40:51 -05:00 · 2025-01-13 13:24:23 -08:00 · 2025-01-13 15:38:24 -05:00 · 2025-01-13 15:02:55 -05:00
31 changed files with 417 additions and 137 deletions
--- a/.eslintrc
+++ b/.eslintrc
@ -6,16 +6,24 @@
    "plugins": [
      "css-modules",
      "jest",
      "jsx-a11y",
      "react",
      "react-hooks",
      "suggest-no-throw",
      "testing-library",
      "@typescript-eslint"
    ],
    "extends": [
-      "plugin:css-modules/recommended"
+      "plugin:css-modules/recommended",
      "plugin:jsx-a11y/recommended",
      "plugin:react-hooks/recommended"
    ],
    "rules": {
      "@typescript-eslint/no-floating-promises": "error",
      "@typescript-eslint/no-misused-promises": "error",
      "jsx-a11y/click-events-have-key-events": "off",
      "jsx-a11y/no-autofocus": "off",
      "jsx-a11y/no-noninteractive-element-interactions": "off",
      "no-restricted-globals": [
        "error",
        {
@ -33,6 +41,9 @@
    "overrides": [
      {
        "files": ["e2e/**/*.ts"], // Update the pattern based on your file structure
        "extends": [
          "plugin:testing-library/react"
        ],
        "rules": {
          "suggest-no-throw/suggest-no-throw": "off",
          "testing-library/prefer-screen-queries": "off",
@ -41,6 +52,9 @@
      },
      {
        "files": ["src/**/*.test.ts"],
        "extends": [
          "plugin:testing-library/react"
        ],
        "rules": {
          "suggest-no-throw/suggest-no-throw": "off",
        }
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@ -6,23 +6,29 @@
 version: 2
 updates:
  - package-ecosystem: 'npm' # See documentation for possible values
-    directory: '/' # Location of package manifests
+    directories:
      - '/'
      - '/packages/codemirror-lang-kcl/'
      - '/packages/codemirror-lsp-client/'
    schedule:
-      interval: 'weekly'
+      interval: weekly
      day: monday
    reviewers:
      - franknoirot
      - irev-dev
  - package-ecosystem: 'github-actions' # See documentation for possible values
    directory: '/' # Location of package manifests
    schedule:
-      interval: 'weekly'
+      interval: weekly
      day: monday
    reviewers:
      - adamchalmers
      - jessfraz
  - package-ecosystem: 'cargo' # See documentation for possible values
    directory: '/src/wasm-lib/' # Location of package manifests
    schedule:
-      interval: 'weekly'
+      interval: weekly
      day: monday
    reviewers:
      - adamchalmers
      - jessfraz
@ -30,3 +36,6 @@ updates:
      serde-dependencies:
        patterns:
          - "serde*"
      wasm-bindgen-deps:
        patterns:
          - "wasm-bindgen*"
--- a/.github/workflows/codemirror-lang-kcl.yml
+++ b/.github/workflows/codemirror-lang-kcl.yml
@ -0,0 +1,32 @@
 name: CodeMirror Lang KCL
 on:
  pull_request:
  push:
    branches:
      - main
 concurrency:
  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
  cancel-in-progress: true
 jobs:
  yarn-unit-test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
          node-version-file: '.nvmrc'
          cache: 'yarn'
      - run: yarn install
        working-directory: packages/codemirror-lang-kcl
      - run: yarn tsc
        working-directory: packages/codemirror-lang-kcl
      - name: run unit tests
        run: yarn test
        working-directory: packages/codemirror-lang-kcl
--- a/docs/kcl/helix.md
+++ b/docs/kcl/helix.md
--- a/docs/kcl/std.json
+++ b/docs/kcl/std.json
@ -75843,7 +75843,6 @@
          "required": [
            "angleStart",
            "axis",
            "length",
            "radius",
            "revolutions"
          ],
@ -75864,9 +75863,10 @@
              "type": "boolean"
            },
            "length": {
-              "description": "Length of the helix.",
+              "description": "Length of the helix. This is not necessary if the helix is created around an edge. If not given the length of the edge is used.",
              "type": "number",
-              "format": "double"
+              "format": "double",
              "nullable": true
            },
            "radius": {
              "description": "Radius of the helix.",
@ -76962,7 +76962,7 @@
    "deprecated": false,
    "examples": [
      "// Create a helix around the Z axis.\nhelixPath = helix({\n  angleStart = 0,\n  ccw = true,\n  revolutions = 16,\n  length = 10,\n  radius = 5,\n  axis = 'Z'\n})\n\n// Create a spring by sweeping around the helix path.\nspringSketch = startSketchOn('YZ')\n  |> circle({ center = [0, 0], radius = 1 }, %)\n// |> sweep({ path = helixPath }, %)",
-      ""
+      "// Create a helix around an edge.\nhelper001 = startSketchOn('XZ')\n  |> startProfileAt([0, 0], %)\n  |> line([0, 10], %, $edge001)\n\nhelixPath = helix({\n  angleStart = 0,\n  ccw = true,\n  revolutions = 16,\n  length = 10,\n  radius = 5,\n  axis = edge001\n})\n\n// Create a spring by sweeping around the helix path.\nspringSketch = startSketchOn('XY')\n  |> circle({ center = [0, 0], radius = 1 }, %)\n// |> sweep({ path = helixPath }, %)"
    ]
  },
  {
--- a/docs/kcl/types/HelixData.md
+++ b/docs/kcl/types/HelixData.md
@ -19,7 +19,7 @@ Data for a helix.
 | `revolutions` |`number`| Number of revolutions. | No |
 | `angleStart` |`number`| Start angle (in degrees). | No |
 | `ccw` |`boolean`| Is the helix rotation counter clockwise? The default is `false`. | No |
-| `length` |`number`| Length of the helix. | No |
+| `length` |`number`| Length of the helix. This is not necessary if the helix is created around an edge. If not given the length of the edge is used. | No |
 | `radius` |`number`| Radius of the helix. | No |
 | `axis` |[`Axis3dOrEdgeReference`](/docs/kcl/types/Axis3dOrEdgeReference)| Axis to use as mirror. | No |
--- a/e2e/playwright/fixtures/fixtureSetup.ts
+++ b/e2e/playwright/fixtures/fixtureSetup.ts
@ -121,18 +121,23 @@ export class AuthenticatedTronApp {
 export const fixtures = {
  cmdBar: async ({ page }: { page: Page }, use: any) => {
    // eslint-disable-next-line react-hooks/rules-of-hooks
    await use(new CmdBarFixture(page))
  },
  editor: async ({ page }: { page: Page }, use: any) => {
    // eslint-disable-next-line react-hooks/rules-of-hooks
    await use(new EditorFixture(page))
  },
  toolbar: async ({ page }: { page: Page }, use: any) => {
    // eslint-disable-next-line react-hooks/rules-of-hooks
    await use(new ToolbarFixture(page))
  },
  scene: async ({ page }: { page: Page }, use: any) => {
    // eslint-disable-next-line react-hooks/rules-of-hooks
    await use(new SceneFixture(page))
  },
  homePage: async ({ page }: { page: Page }, use: any) => {
    // eslint-disable-next-line react-hooks/rules-of-hooks
    await use(new HomePageFixture(page))
  },
 }
--- a/package.json
+++ b/package.json
@ -91,8 +91,8 @@
    "build:wasm": "yarn wasm-prep && cd src/wasm-lib && wasm-pack build --release --target web --out-dir pkg && cargo test -p kcl-lib export_bindings && cd ../.. && yarn isomorphic-copy-wasm && yarn fmt",
    "remove-importmeta": "sed -i 's/import.meta.url/window.location.origin/g' \"./src/wasm-lib/pkg/wasm_lib.js\"; sed -i '' 's/import.meta.url/window.location.origin/g' \"./src/wasm-lib/pkg/wasm_lib.js\" || echo \"sed for both mac and linux\"",
    "wasm-prep": "rimraf src/wasm-lib/pkg && mkdirp src/wasm-lib/pkg && rimraf src/wasm-lib/kcl/bindings",
-    "lint-fix": "eslint --fix src/**/*.ts src/**/*.tsx e2e/**/*.ts packages/codemirror-lsp-client/src/**/*.ts",
+    "lint-fix": "eslint --fix --ext .ts --ext .tsx src e2e packages/codemirror-lsp-client/src",
-    "lint": "eslint --max-warnings 0 src/**/*.ts src/**/*.tsx e2e/**/*.ts packages/codemirror-lsp-client/src/**/*.ts",
+    "lint": "eslint --max-warnings 0 --ext .ts --ext .tsx src e2e packages/codemirror-lsp-client/src",
    "files:set-version": "echo \"$(jq --arg v \"$VERSION\" '.version=$v' package.json --indent 2)\" > package.json",
    "files:set-notes": "./scripts/set-files-notes.sh",
    "files:flip-to-nightly": "./scripts/flip-files-to-nightly.sh",
@ -149,7 +149,7 @@
    "@electron-forge/plugin-vite": "7.4.0",
    "@electron/fuses": "1.8.0",
    "@iarna/toml": "^2.2.5",
-    "@lezer/generator": "^1.7.1",
+    "@lezer/generator": "^1.7.2",
    "@nabla/vite-plugin-eslint": "^2.0.5",
    "@playwright/test": "^1.49.0",
    "@testing-library/jest-dom": "^5.14.1",
@ -183,8 +183,11 @@
    "eslint-plugin-css-modules": "^2.12.0",
    "eslint-plugin-import": "^2.30.0",
    "eslint-plugin-jest": "^28.10.0",
    "eslint-plugin-jsx-a11y": "^6.10.2",
    "eslint-plugin-react": "^7.37.3",
    "eslint-plugin-react-hooks": "^5.1.0",
    "eslint-plugin-suggest-no-throw": "^1.0.0",
    "eslint-plugin-testing-library": "^7.1.1",
    "happy-dom": "^16.3.0",
    "http-server": "^14.1.1",
    "husky": "^9.1.5",
--- a/packages/codemirror-lang-kcl/.gitignore
+++ b/packages/codemirror-lang-kcl/.gitignore
@ -4,4 +4,5 @@ dist
 tsconfig.tsbuildinfo
 *.d.ts
 *.js
 !postcss.config.js
 !rollup.config.js
--- a/packages/codemirror-lang-kcl/package.json
+++ b/packages/codemirror-lang-kcl/package.json
@ -28,6 +28,7 @@
    "@rollup/plugin-typescript": "^12.1.2",
    "rollup": "^4.29.1",
    "rollup-plugin-dts": "^6.1.1",
    "vite-tsconfig-paths": "^4.3.2",
    "vitest": "^2.1.8"
  },
  "files": [
--- a/packages/codemirror-lang-kcl/postcss.config.js
+++ b/packages/codemirror-lang-kcl/postcss.config.js
@ -0,0 +1 @@
 // This is here to prevent using the one in the root of the project.
--- a/packages/codemirror-lang-kcl/yarn.lock
+++ b/packages/codemirror-lang-kcl/yarn.lock
@ -398,7 +398,7 @@ check-error@^2.1.1:
  resolved "https://registry.yarnpkg.com/check-error/-/check-error-2.1.1.tgz#87eb876ae71ee388fa0471fe423f494be1d96ccc"
  integrity sha512-OAlb+T7V4Op9OwdkjmguYRqncdlx5JiofwOAUkmTF+jNdHwzTaTs4sRAGpzLF3oOz5xAyDGrPgeIDFQmDOTiJw==
-debug@^4.3.7:
+debug@^4.1.1, debug@^4.3.7:
  version "4.4.0"
  resolved "https://registry.yarnpkg.com/debug/-/debug-4.4.0.tgz#2b3f2aea2ffeb776477460267377dc8710faba8a"
  integrity sha512-6WTZ/IxCY/T6BALoZHaE4ctp9xm+Z5kY/pzYaCHRFeyVhojxlrm+46y68HA6hr0TcwEssoxNiDEUJQjfPZ/RYA==
@ -471,6 +471,11 @@ function-bind@^1.1.2:
  resolved "https://registry.yarnpkg.com/function-bind/-/function-bind-1.1.2.tgz#2c02d864d97f3ea6c8830c464cbd11ab6eab7a1c"
  integrity sha512-7XHNxH7qX9xG5mIwxkhumTox/MIRNcOgDrxWsMt2pAr23WHp6MrRlN7FBSFpCpr+oVO0F744iUgR82nJMfG2SA==
 globrex@^0.1.2:
  version "0.1.2"
  resolved "https://registry.yarnpkg.com/globrex/-/globrex-0.1.2.tgz#dd5d9ec826232730cd6793a5e33a9302985e6098"
  integrity sha512-uHJgbwAMwNFf5mLst7IWLNg14x1CkeqglJb/K3doi4dw6q2IvAAmM/Y81kevy83wP+Sst+nutFTYOGg3d1lsxg==
 hasown@^2.0.2:
  version "2.0.2"
  resolved "https://registry.yarnpkg.com/hasown/-/hasown-2.0.2.tgz#003eaf91be7adc372e84ec59dc37252cedb80003"
@ -647,6 +652,11 @@ tinyspy@^3.0.2:
  resolved "https://registry.yarnpkg.com/tinyspy/-/tinyspy-3.0.2.tgz#86dd3cf3d737b15adcf17d7887c84a75201df20a"
  integrity sha512-n1cw8k1k0x4pgA2+9XrOkFydTerNcJ1zWCO5Nn9scWHTD+5tp8dghT2x1uduQePZTZgd3Tupf+x9BxJjeJi77Q==
 tsconfck@^3.0.3:
  version "3.1.4"
  resolved "https://registry.yarnpkg.com/tsconfck/-/tsconfck-3.1.4.tgz#de01a15334962e2feb526824339b51be26712229"
  integrity sha512-kdqWFGVJqe+KGYvlSO9NIaWn9jT1Ny4oKVzAJsKii5eoE9snzTJzL4+MMVOMn+fikWGFmKEylcXL710V/kIPJQ==
 typescript@^5.7.2:
  version "5.7.2"
  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.7.2.tgz#3169cf8c4c8a828cde53ba9ecb3d2b1d5dd67be6"
@ -663,6 +673,15 @@ vite-node@2.1.8:
    pathe "^1.1.2"
    vite "^5.0.0"
 vite-tsconfig-paths@^4.3.2:
  version "4.3.2"
  resolved "https://registry.yarnpkg.com/vite-tsconfig-paths/-/vite-tsconfig-paths-4.3.2.tgz#321f02e4b736a90ff62f9086467faf4e2da857a9"
  integrity sha512-0Vd/a6po6Q+86rPlntHye7F31zA2URZMbH8M3saAZ/xR9QoGN/L21bxEGfXdWmFdNkqPpRdxFT7nmNe12e9/uA==
  dependencies:
    debug "^4.1.1"
    globrex "^0.1.2"
    tsconfck "^3.0.3"
 vite@^5.0.0:
  version "5.4.11"
  resolved "https://registry.yarnpkg.com/vite/-/vite-5.4.11.tgz#3b415cd4aed781a356c1de5a9ebafb837715f6e5"
--- a/src/components/HelpMenu.tsx
+++ b/src/components/HelpMenu.tsx
@ -148,6 +148,7 @@ function HelpMenuItem({
  return (
    <li className="p-0 m-0">
      {as === 'a' ? (
        // eslint-disable-next-line jsx-a11y/no-static-element-interactions
        <a
          {...(props as React.ComponentProps<'a'>)}
          onClick={openExternalBrowserIfDesktop(
--- a/src/components/ModelingSidebar/ModelingPanes/KclEditorMenu.tsx
+++ b/src/components/ModelingSidebar/ModelingPanes/KclEditorMenu.tsx
@ -18,6 +18,7 @@ export const KclEditorMenu = ({ children }: PropsWithChildren) => {
  return (
    <Menu>
      {/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */}
      <div
        className="relative"
        onClick={(e) => {
--- a/src/components/Stream.tsx
+++ b/src/components/Stream.tsx
@ -313,6 +313,7 @@ export const Stream = () => {
  }
  return (
    // eslint-disable-next-line jsx-a11y/no-static-element-interactions
    <div
      ref={videoWrapperRef}
      className="absolute inset-0 z-0"
--- a/src/lang/std/artifactGraph.test.ts
+++ b/src/lang/std/artifactGraph.test.ts
@ -705,7 +705,7 @@ describe('testing getArtifactsToUpdate', () => {
        segIds: [],
        id: expect.any(String),
        planeId: 'UUID-1',
-        sweepId: '',
+        sweepId: undefined,
        codeRef: {
          pathToNode: [['body', '']],
          range: [37, 64, true],
@ -743,7 +743,7 @@ describe('testing getArtifactsToUpdate', () => {
        type: 'segment',
        id: expect.any(String),
        pathId: expect.any(String),
-        surfaceId: '',
+        surfaceId: undefined,
        edgeIds: [],
        codeRef: {
          range: [70, 86, true],
@ -770,7 +770,7 @@ describe('testing getArtifactsToUpdate', () => {
        id: expect.any(String),
        consumedEdgeId: expect.any(String),
        edgeIds: [],
-        surfaceId: '',
+        surfaceId: undefined,
        codeRef: {
          range: [260, 299, true],
          pathToNode: [['body', '']],
--- a/src/lang/std/artifactGraph.ts
+++ b/src/lang/std/artifactGraph.ts
@ -37,7 +37,7 @@ export interface PathArtifact extends BaseArtifact {
  type: 'path'
  planeId: ArtifactId
  segIds: Array<ArtifactId>
-  sweepId: ArtifactId
+  sweepId?: ArtifactId
  solid2dId?: ArtifactId
  codeRef: CodeRef
 }
@ -60,7 +60,7 @@ export interface PathArtifactRich extends BaseArtifact {
 export interface SegmentArtifact extends BaseArtifact {
  type: 'segment'
  pathId: ArtifactId
-  surfaceId: ArtifactId
+  surfaceId?: ArtifactId
  edgeIds: Array<ArtifactId>
  edgeCutId?: ArtifactId
  codeRef: CodeRef
@ -68,7 +68,7 @@ export interface SegmentArtifact extends BaseArtifact {
 interface SegmentArtifactRich extends BaseArtifact {
  type: 'segment'
  path: PathArtifact
-  surf: WallArtifact
+  surf?: WallArtifact
  edges: Array<SweepEdge>
  edgeCut?: EdgeCut
  codeRef: CodeRef
@ -120,7 +120,7 @@ interface EdgeCut extends BaseArtifact {
  subType: 'fillet' | 'chamfer'
  consumedEdgeId: ArtifactId
  edgeIds: Array<ArtifactId>
-  surfaceId: ArtifactId
+  surfaceId?: ArtifactId
  codeRef: CodeRef
 }
@ -308,7 +308,7 @@ export function getArtifactsToUpdate({
        id,
        segIds: [],
        planeId: currentPlaneId,
-        sweepId: '',
+        sweepId: undefined,
        codeRef: { range, pathToNode },
      },
    })
@ -343,7 +343,7 @@ export function getArtifactsToUpdate({
        type: 'segment',
        id,
        pathId,
-        surfaceId: '',
+        surfaceId: undefined,
        edgeIds: [],
        codeRef: { range, pathToNode },
      },
@ -450,7 +450,8 @@ export function getArtifactsToUpdate({
                id: face_id,
                segId: curve_id,
                edgeCutEdgeIds: [],
-                sweepId: path.sweepId,
+                // TODO: Add explicit check for sweepId.  Should never use ''
                sweepId: path.sweepId ?? '',
                pathIds: [],
              },
            })
@ -458,15 +459,17 @@ export function getArtifactsToUpdate({
              id: curve_id,
              artifact: { ...seg, surfaceId: face_id },
            })
-            const sweep = getArtifact(path.sweepId)
+            if (path.sweepId) {
-            if (sweep?.type === 'sweep') {
+              const sweep = getArtifact(path.sweepId)
-              returnArr.push({
+              if (sweep?.type === 'sweep') {
-                id: path.sweepId,
+                returnArr.push({
-                artifact: {
+                  id: path.sweepId,
-                  ...sweep,
+                  artifact: {
-                  surfaceIds: [face_id],
+                    ...sweep,
-                },
+                    surfaceIds: [face_id],
-              })
+                  },
                })
              }
            }
          }
        }
@ -483,19 +486,22 @@ export function getArtifactsToUpdate({
              id: face_id,
              subType: cap === 'bottom' ? 'start' : 'end',
              edgeCutEdgeIds: [],
-              sweepId: path.sweepId,
+              // TODO: Add explicit check for sweepId.  Should never use ''
              sweepId: path.sweepId ?? '',
              pathIds: [],
            },
          })
-          const sweep = getArtifact(path.sweepId)
+          if (path.sweepId) {
-          if (sweep?.type !== 'sweep') return
+            const sweep = getArtifact(path.sweepId)
-          returnArr.push({
+            if (sweep?.type !== 'sweep') return
-            id: path.sweepId,
+            returnArr.push({
-            artifact: {
+              id: path.sweepId,
-              ...sweep,
+              artifact: {
-              surfaceIds: [face_id],
+                ...sweep,
-            },
+                surfaceIds: [face_id],
-          })
+              },
            })
          }
        }
      }
    })
@ -533,7 +539,8 @@ export function getArtifactsToUpdate({
              ? 'adjacent'
              : 'opposite',
          segId: cmd.edge_id,
-          sweepId: path.sweepId,
+          // TODO: Add explicit check for sweepId.  Should never use ''
          sweepId: path.sweepId ?? '',
        },
      },
      {
@ -544,7 +551,7 @@ export function getArtifactsToUpdate({
        },
      },
      {
-        id: path.sweepId,
+        id: sweep.id,
        artifact: {
          ...sweep,
          edgeIds: [response.data.modeling_response.data.edge],
@ -560,7 +567,7 @@ export function getArtifactsToUpdate({
        subType: cmd.cut_type,
        consumedEdgeId: cmd.edge_id,
        edgeIds: [],
-        surfaceId: '',
+        surfaceId: undefined,
        codeRef: { range, pathToNode },
      },
    })
@ -722,10 +729,12 @@ export function expandSegment(
    { key: segment.pathId, types: ['path'] },
    artifactGraph
  )
-  const surf = getArtifactOfTypes(
+  const surf = segment.surfaceId
-    { key: segment.surfaceId, types: ['wall'] },
+    ? getArtifactOfTypes(
-    artifactGraph
+        { key: segment.surfaceId, types: ['wall'] },
-  )
+        artifactGraph
      )
    : undefined
  const edges = getArtifactsOfTypes(
    { keys: segment.edgeIds, types: ['sweepEdge'] },
    artifactGraph
@ -842,6 +851,7 @@ export function getSweepFromSuspectedSweepSurface(
      artifactGraph
    )
    if (err(path)) return path
    if (!path.sweepId) return new Error('Path does not have a sweepId')
    return getArtifactOfTypes(
      { key: path.sweepId, types: ['sweep'] },
      artifactGraph
@ -859,6 +869,7 @@ export function getSweepFromSuspectedPath(
 ): SweepArtifact | Error {
  const path = getArtifactOfTypes({ key: id, types: ['path'] }, artifactGraph)
  if (err(path)) return path
  if (!path.sweepId) return new Error('Path does not have a sweepId')
  return getArtifactOfTypes(
    { key: path.sweepId, types: ['sweep'] },
    artifactGraph
--- a/src/lib/promptToEdit.ts
+++ b/src/lib/promptToEdit.ts
@ -137,7 +137,7 @@ See later source ranges for more context. about the sweep`,
            { key: artifact.pathId, types: ['path'] },
            artifactGraph
          )
-          if (!err(path)) {
+          if (!err(path) && path.sweepId) {
            const sweep = getArtifactOfTypes(
              { key: path.sweepId, types: ['sweep'] },
              artifactGraph
--- a/src/lib/selections.ts
+++ b/src/lib/selections.ts
@ -670,6 +670,7 @@ export function codeToIdSelections(
          }
        }
        if (type === 'extrude-wall' && entry.artifact.type === 'segment') {
          if (!entry.artifact.surfaceId) return
          const wall = engineCommandManager.artifactGraph.get(
            entry.artifact.surfaceId
          )
@ -714,6 +715,7 @@ export function codeToIdSelections(
          (type === 'end-cap' || type === 'start-cap') &&
          entry.artifact.type === 'path'
        ) {
          if (!entry.artifact.sweepId) return
          const extrusion = getArtifactOfTypes(
            {
              key: entry.artifact.sweepId,
--- a/src/main.ts
+++ b/src/main.ts
@ -320,6 +320,11 @@ export function getAutoUpdater(): AppUpdater {
 }
 app.on('ready', () => {
  // Disable auto updater on non-versioned builds
  if (packageJSON.version === '0.0.0') {
    return
  }
  const autoUpdater = getAutoUpdater()
  // TODO: we're getting `Error: Response ends without calling any handlers` with our setup,
  // so at the moment this isn't worth enabling
--- a/src/wasm-lib/Cargo.lock
+++ b/src/wasm-lib/Cargo.lock
@ -176,7 +176,7 @@ checksum = "3b43422f69d8ff38f95f1b2bb76517c91589a924d1559a0e935d7c8ce0274c11"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -187,7 +187,7 @@ checksum = "3f934833b4b7233644e5848f235df3f57ed8c80f1528a26c3dfa13d2147fa056"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -204,7 +204,7 @@ checksum = "3c87f3f15e7794432337fc718554eaa4dc8f04c9677a950ffe366f20a162ae42"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -474,7 +474,7 @@ dependencies = [
 "heck 0.5.0",
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -665,7 +665,7 @@ dependencies = [
 "proc-macro2",
 "quote",
 "strsim",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -676,7 +676,7 @@ checksum = "d336a2a514f6ccccaa3e09b02d41d35330c07ddf03a62165fcec10bb561c7806"
 dependencies = [
 "darling_core",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -723,7 +723,7 @@ dependencies = [
 [[package]]
 name = "derive-docs"
-version = "0.1.33"
+version = "0.1.34"
 dependencies = [
 "Inflector",
 "anyhow",
@ -737,7 +737,7 @@ dependencies = [
 "rustfmt-wrapper",
 "serde",
 "serde_tokenstream",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -748,7 +748,38 @@ checksum = "67e77553c4162a157adbf834ebae5b415acbecbeafc7a74b0e886657506a7611"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
 name = "derive_builder"
 version = "0.20.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "507dfb09ea8b7fa618fcf76e953f4f5e192547945816d5358edffe39f6f94947"
 dependencies = [
 "derive_builder_macro",
 ]
 [[package]]
 name = "derive_builder_core"
 version = "0.20.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "2d5bcf7b024d6835cfb3d473887cd966994907effbe9227e8c8219824d06c4e8"
 dependencies = [
 "darling",
 "proc-macro2",
 "quote",
 "syn 2.0.96",
 ]
 [[package]]
 name = "derive_builder_macro"
 version = "0.20.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "ab63b0e2bf4d5928aff72e83a7dace85d7bba5fe12dcc3c5a572d78caffd3f3c"
 dependencies = [
 "derive_builder_core",
 "syn 2.0.96",
 ]
 [[package]]
@ -791,7 +822,7 @@ checksum = "97369cbbc041bc366949bc74d34658d6cda5621039731c6310521892a3a20ae0"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -829,7 +860,7 @@ checksum = "a1ab991c1362ac86c61ab6f556cff143daa22e5a15e4e189df818b2fd19fe65b"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -990,7 +1021,7 @@ checksum = "162ee34ebcb7c64a8abebc059ce0fee27c2262618d7b60ed8faf72fef13c3650"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -1086,7 +1117,7 @@ dependencies = [
 "inflections",
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -1132,17 +1163,18 @@ dependencies = [
 [[package]]
 name = "handlebars"
-version = "6.2.0"
+version = "6.3.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "fd4ccde012831f9a071a637b0d4e31df31c0f6c525784b35ae76a9ac6bc1e315"
+checksum = "3d6b224b95c1e668ac0270325ad563b2eef1469fbbb8959bc7c692c844b813d9"
 dependencies = [
 "derive_builder",
 "log",
 "num-order",
 "pest",
 "pest_derive",
 "serde",
 "serde_json",
- "thiserror 1.0.68",
+ "thiserror 2.0.0",
 ]
 [[package]]
@ -1494,7 +1526,7 @@ checksum = "1ec89e9337638ecdc08744df490b221a7399bf8d164eb52a665454e60e075ad6"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -1684,7 +1716,7 @@ dependencies = [
 [[package]]
 name = "kcl-lib"
-version = "0.2.29"
+version = "0.2.30"
 dependencies = [
 "anyhow",
 "approx 0.5.1",
@ -1752,7 +1784,7 @@ dependencies = [
 [[package]]
 name = "kcl-test-server"
-version = "0.1.19"
+version = "0.1.20"
 dependencies = [
 "anyhow",
 "hyper 0.14.30",
@ -1819,9 +1851,9 @@ dependencies = [
 [[package]]
 name = "kittycad-modeling-cmds"
-version = "0.2.86"
+version = "0.2.89"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "65e34a8eeb4fff5167666d1f2bc36c95d08ab3a0f736a02c8d33a8cde21cfd8d"
+checksum = "ce9e58b34645facea36bc9f4868877bbe6fcac01b92896825e8d4f2f7c71dbd6"
 dependencies = [
 "anyhow",
 "chrono",
@ -1852,7 +1884,7 @@ dependencies = [
 "kittycad-modeling-cmds-macros-impl",
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -1863,7 +1895,7 @@ checksum = "fdb4ee23cc996aa2dca7584d410e8826e08161e1ac4335bb646d5ede33f37cb3"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2013,7 +2045,7 @@ checksum = "dcf09caffaac8068c346b6df2a7fc27a177fd20b39421a39ce0a211bde679a6c"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2312,7 +2344,7 @@ dependencies = [
 "regex",
 "regex-syntax 0.8.5",
 "structmeta",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2326,7 +2358,7 @@ dependencies = [
 "regex",
 "regex-syntax 0.8.5",
 "structmeta",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2366,7 +2398,7 @@ dependencies = [
 "pest_meta",
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2424,7 +2456,7 @@ checksum = "2f38a4412a78282e09a2cf38d195ea5420d15ba0602cb375210efbc877243965"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2554,7 +2586,7 @@ dependencies = [
 "proc-macro-error-attr2",
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2613,7 +2645,7 @@ dependencies = [
 "proc-macro2",
 "pyo3-macros-backend",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -2626,7 +2658,7 @@ dependencies = [
 "proc-macro2",
 "pyo3-build-config",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3161,7 +3193,7 @@ dependencies = [
 "proc-macro2",
 "quote",
 "serde_derive_internals",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3225,7 +3257,7 @@ checksum = "5a9bf7cf98d04a2b28aead066b7496853d4779c9cc183c440dbac457641e19a0"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3236,7 +3268,7 @@ checksum = "18d26a20a969b9e3fdf2fc2d9f21eda6c40e2de84c9408bb5d3b05d499aae711"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3260,7 +3292,7 @@ checksum = "6c64451ba24fc7a6a2d60fc75dd9c83c90903b19028d4eff35e88fc1e86564e9"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3281,7 +3313,7 @@ dependencies = [
 "proc-macro2",
 "quote",
 "serde",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3430,7 +3462,7 @@ dependencies = [
 "proc-macro2",
 "quote",
 "structmeta-derive",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3441,7 +3473,7 @@ checksum = "152a0b65a590ff6c3da95cabe2353ee04e6167c896b28e3b14478c2636c922fc"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3463,7 +3495,7 @@ dependencies = [
 "proc-macro2",
 "quote",
 "rustversion",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3506,9 +3538,9 @@ dependencies = [
 [[package]]
 name = "syn"
-version = "2.0.95"
+version = "2.0.96"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "46f71c0377baf4ef1cc3e3402ded576dccc315800fbc62dfc7fe04b009773b4a"
+checksum = "d5d0adab1ae378d7f53bdebc67a39f1f151407ef230f0ce2883572f5d8985c80"
 dependencies = [
 "proc-macro2",
 "quote",
@ -3532,7 +3564,7 @@ checksum = "c8af7666ab7b6390ab78131fb5b0fce11d6b7a6951602017c35fa82800708971"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3640,7 +3672,7 @@ checksum = "a7c61ec9a6f64d2793d8a45faba21efbe3ced62a886d44c36a009b2b519b4c7e"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3651,7 +3683,7 @@ checksum = "22efd00f33f93fa62848a7cab956c3d38c8d43095efda1decfc2b3a5dc0b8972"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3763,7 +3795,7 @@ checksum = "693d596312e88961bc67d7f1f97af8a70227d9f90c31bba5806eec004978d752"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3905,7 +3937,7 @@ checksum = "84fd902d4e0b9a4b27f2f440108dc034e1758628a9b702f8ec61ad66355422fa"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -3933,7 +3965,7 @@ checksum = "34704c8d6ebcbc939824180af020566b01a7c01f80641264eba0999f6c2b6be7"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -4016,7 +4048,7 @@ checksum = "0e9d8656589772eeec2cf7a8264d9cda40fb28b9bc53118ceb9e8c07f8f38730"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 "termcolor",
 ]
@ -4159,9 +4191,9 @@ checksum = "06abde3611657adf66d383f00b093d7faecc7fa57071cce2578660c9f1010821"
 [[package]]
 name = "uuid"
-version = "1.11.0"
+version = "1.11.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f8c5f0a0af699448548ad1a2fbf920fb4bee257eae39953ba95cb84891a0446a"
+checksum = "b913a3b5fe84142e269d63cc62b64319ccaf89b748fc31fe025177f767a756c4"
 dependencies = [
 "getrandom",
 "serde",
@ -4195,7 +4227,7 @@ dependencies = [
 "proc-macro-error2",
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -4256,7 +4288,7 @@ dependencies = [
 "log",
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 "wasm-bindgen-shared",
 ]
@ -4292,7 +4324,7 @@ checksum = "30d7a95b763d3c45903ed6c81f156801839e5ee968bb07e534c44df0fcd330c2"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 "wasm-bindgen-backend",
 "wasm-bindgen-shared",
 ]
@ -4673,7 +4705,7 @@ checksum = "28cc31741b18cb6f1d5ff12f5b7523e3d6eb0852bbbad19d73905511d9849b95"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 "synstructure",
 ]
@ -4695,7 +4727,7 @@ checksum = "fa4f8080344d4671fb4e831a13ad1e68092748387dfc4f55e356242fae12ce3e"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
@ -4715,7 +4747,7 @@ checksum = "0ea7b4a3637ea8669cedf0f1fd5c286a17f3de97b8dd5a70a6c167a1730e63a5"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 "synstructure",
 ]
@ -4744,7 +4776,7 @@ checksum = "6eafa6dfb17584ea3e2bd6e76e0cc15ad7af12b09abdd1ca55961bed9b1063c6"
 dependencies = [
 "proc-macro2",
 "quote",
- "syn 2.0.95",
+ "syn 2.0.96",
 ]
 [[package]]
--- a/src/wasm-lib/Cargo.toml
+++ b/src/wasm-lib/Cargo.toml
@ -76,7 +76,7 @@ members = [
 [workspace.dependencies]
 http = "1"
 kittycad = { version = "0.3.28", default-features = false, features = ["js", "requests"] }
-kittycad-modeling-cmds = { version = "0.2.86", features = [
+kittycad-modeling-cmds = { version = "0.2.89", features = [
  "ts-rs",
  "websocket",
 ] }
--- a/src/wasm-lib/derive-docs/Cargo.toml
+++ b/src/wasm-lib/derive-docs/Cargo.toml
@ -1,7 +1,7 @@
 [package]
 name = "derive-docs"
 description = "A tool for generating documentation from Rust derive macros"
-version = "0.1.33"
+version = "0.1.34"
 edition = "2021"
 license = "MIT"
 repository = "https://github.com/KittyCAD/modeling-app"
@ -20,7 +20,7 @@ quote = "1"
 regex = "1.11"
 serde = { version = "1.0.217", features = ["derive"] }
 serde_tokenstream = "0.2"
-syn = { version = "2.0.95", features = ["full"] }
+syn = { version = "2.0.96", features = ["full"] }
 [dev-dependencies]
 anyhow = "1.0.95"
--- a/src/wasm-lib/kcl-test-server/Cargo.toml
+++ b/src/wasm-lib/kcl-test-server/Cargo.toml
@ -1,7 +1,7 @@
 [package]
 name = "kcl-test-server"
 description = "A test server for KCL"
-version = "0.1.19"
+version = "0.1.20"
 edition = "2021"
 license = "MIT"
--- a/src/wasm-lib/kcl/Cargo.toml
+++ b/src/wasm-lib/kcl/Cargo.toml
@ -1,7 +1,7 @@
 [package]
 name = "kcl-lib"
 description = "KittyCAD Language implementation and tools"
-version = "0.2.29"
+version = "0.2.30"
 edition = "2021"
 license = "MIT"
 repository = "https://github.com/KittyCAD/modeling-app"
@ -22,7 +22,7 @@ clap = { version = "4.5.23", default-features = false, optional = true, features
 ] }
 convert_case = "0.6.0"
 dashmap = "6.1.0"
-derive-docs = { version = "0.1.33", path = "../derive-docs" }
+derive-docs = { version = "0.1.34", path = "../derive-docs" }
 dhat = { version = "0.3", optional = true }
 fnv = "1.0.7"
 form_urlencoded = "1.2.1"
@ -112,7 +112,7 @@ tabled = ["dep:tabled"]
 base64 = "0.22.1"
 criterion = { version = "0.5.1", features = ["async_tokio"] }
 expectorate = "1.1.0"
-handlebars = "6.2.0"
+handlebars = "6.3.0"
 iai = "0.1"
 image = { version = "0.25.5", default-features = false, features = ["png"] }
 insta = { version = "1.41.1", features = ["json", "filters", "redactions"] }
--- a/src/wasm-lib/kcl/src/docs/mod.rs
+++ b/src/wasm-lib/kcl/src/docs/mod.rs
@ -1024,6 +1024,36 @@ mod tests {
        assert_eq!(snippet, r#"hole(${0:holeSketch}, ${1:%})${}"#);
    }
    #[test]
    fn get_autocomplete_snippet_helix() {
        let helix_fn: Box<dyn StdLibFn> = Box::new(crate::std::helix::Helix);
        let snippet = helix_fn.to_autocomplete_snippet().unwrap();
        assert_eq!(
            snippet,
            r#"helix({
 	revolutions = ${0:3.14},
 	angleStart = ${1:3.14},
 	ccw = ${2:false},
 	radius = ${3:3.14},
 	axis = ${4:"X"},
 })${}"#
        );
    }
    #[test]
    fn get_autocomplete_snippet_helix_revolutions() {
        let helix_fn: Box<dyn StdLibFn> = Box::new(crate::std::helix::HelixRevolutions);
        let snippet = helix_fn.to_autocomplete_snippet().unwrap();
        assert_eq!(
            snippet,
            r#"helixRevolutions({
 	revolutions = ${0:3.14},
 	angleStart = ${1:3.14},
 	ccw = ${2:false},
 }, ${3:%})${}"#
        );
    }
    // We want to test the snippets we compile at lsp start.
    #[test]
    fn get_all_stdlib_autocomplete_snippets() {
--- a/src/wasm-lib/kcl/src/std/args.rs
+++ b/src/wasm-lib/kcl/src/std/args.rs
@ -1108,7 +1108,7 @@ impl<'a> FromKclValue<'a> for super::helix::HelixData {
    fn from_kcl_val(arg: &'a KclValue) -> Option<Self> {
        let obj = arg.as_object()?;
        let_field_of!(obj, revolutions);
-        let_field_of!(obj, length);
+        let_field_of!(obj, length?);
        let_field_of!(obj, ccw?);
        let_field_of!(obj, radius);
        let_field_of!(obj, axis);
--- a/src/wasm-lib/kcl/src/std/helix.rs
+++ b/src/wasm-lib/kcl/src/std/helix.rs
@ -26,8 +26,9 @@ pub struct HelixData {
    /// The default is `false`.
    #[serde(default)]
    pub ccw: bool,
-    /// Length of the helix.
+    /// Length of the helix. This is not necessary if the helix is created around an edge. If not
-    pub length: f64,
+    /// given the length of the edge is used.
    pub length: Option<f64>,
    /// Radius of the helix.
    pub radius: f64,
    /// Axis to use as mirror.
@ -64,7 +65,7 @@ pub async fn helix(exec_state: &mut ExecState, args: Args) -> Result<KclValue, K
 ///
 /// ```no_run
 /// // Create a helix around an edge.
-/// /*helper001 = startSketchOn('XZ')
+/// helper001 = startSketchOn('XZ')
 ///  |> startProfileAt([0, 0], %)
 ///  |> line([0, 10], %, $edge001)
 ///
@ -80,7 +81,7 @@ pub async fn helix(exec_state: &mut ExecState, args: Args) -> Result<KclValue, K
 /// // Create a spring by sweeping around the helix path.
 /// springSketch = startSketchOn('XY')
 ///     |> circle({ center = [0, 0], radius = 1 }, %)
-///     |> sweep({ path = helixPath }, %)*/
+///     //|> sweep({ path = helixPath }, %)
 /// ```
 #[stdlib {
    name = "helix",
@ -105,12 +106,20 @@ async fn inner_helix(data: HelixData, exec_state: &mut ExecState, args: Args) ->
        Axis3dOrEdgeReference::Axis(axis) => {
            let (axis, origin) = axis.axis_and_origin()?;
            // Make sure they gave us a length.
            let Some(length) = data.length else {
                return Err(KclError::Semantic(crate::errors::KclErrorDetails {
                    message: "Length is required when creating a helix around an axis.".to_string(),
                    source_ranges: vec![args.source_range],
                }));
            };
            args.batch_modeling_cmd(
                exec_state.next_uuid(),
                ModelingCmd::from(mcmd::EntityMakeHelixFromParams {
                    radius: data.radius,
                    is_clockwise: !data.ccw,
-                    length: LengthUnit(data.length),
+                    length: LengthUnit(length),
                    revolutions: data.revolutions,
                    start_angle: Angle::from_degrees(data.angle_start),
                    axis,
@ -119,25 +128,21 @@ async fn inner_helix(data: HelixData, exec_state: &mut ExecState, args: Args) ->
            )
            .await?;
        }
-        Axis3dOrEdgeReference::Edge(_edge) => {
+        Axis3dOrEdgeReference::Edge(edge) => {
-            /*let edge_id = edge.get_engine_id(exec_state, &args)?;
+            let edge_id = edge.get_engine_id(exec_state, &args)?;
            args.batch_modeling_cmd(
                exec_state.next_uuid(),
                ModelingCmd::from(mcmd::EntityMakeHelixFromEdge {
                    radius: data.radius,
                    is_clockwise: !data.ccw,
-                    length: LengthUnit(data.length),
+                    length: data.length.map(LengthUnit),
                    revolutions: data.revolutions,
                    start_angle: Angle::from_degrees(data.angle_start),
                    edge_id,
                }),
            )
-            .await?;*/
+            .await?;
            return Err(KclError::Unimplemented(crate::errors::KclErrorDetails {
                message: "Helix around edge is not yet implemented".to_string(),
                source_ranges: vec![args.source_range],
            }));
        }
    };
--- a/src/wasm-lib/kcl/tests/outputs/serial_test_example_helix1.png
+++ b/src/wasm-lib/kcl/tests/outputs/serial_test_example_helix1.png
--- a/vitest.workspace.ts
+++ b/vitest.workspace.ts
@ -0,0 +1,10 @@
 import { defineWorkspace } from 'vitest/config'
 export default defineWorkspace([
  './vite.main.config.ts',
  './vite.base.config.ts',
  './vite.config.ts',
  './vite.preload.config.ts',
  './vite.renderer.config.ts',
  './packages/codemirror-lang-kcl/vitest.main.config.ts',
 ])
--- a/yarn.lock
+++ b/yarn.lock
@ -1867,10 +1867,10 @@
  resolved "https://registry.yarnpkg.com/@lezer/common/-/common-1.2.1.tgz#198b278b7869668e1bebbe687586e12a42731049"
  integrity sha512-yemX0ZD2xS/73llMZIK6KplkjIjf2EvAHcinDi/TfJ9hS25G0388+ClHt6/3but0oOxinTcQHJLDXh6w1crzFQ==
-"@lezer/generator@^1.7.1":
+"@lezer/generator@^1.7.2":
-  version "1.7.1"
+  version "1.7.2"
-  resolved "https://registry.yarnpkg.com/@lezer/generator/-/generator-1.7.1.tgz#90c1a9de2fb4d5a714216fa659058c7859accaab"
+  resolved "https://registry.yarnpkg.com/@lezer/generator/-/generator-1.7.2.tgz#a491c91eb9f117ea803e748fa97574514156a2a3"
-  integrity sha512-MgPJN9Si+ccxzXl3OAmCeZuUKw4XiPl4y664FX/hnnyG9CTqUPq65N3/VGPA2jD23D7QgMTtNqflta+cPN+5mQ==
+  integrity sha512-CwgULPOPPmH54tv4gki18bElLCdJ1+FBC+nGVSVD08vFWDsMjS7KEjNTph9JOypDnet90ujN3LzQiW3CyVODNQ==
  dependencies:
    "@lezer/common" "^1.1.0"
    "@lezer/lr" "^1.3.0"
@ -2552,7 +2552,7 @@
    "@typescript-eslint/visitor-keys" "8.19.1"
    debug "^4.3.4"
-"@typescript-eslint/scope-manager@8.19.1":
+"@typescript-eslint/scope-manager@8.19.1", "@typescript-eslint/scope-manager@^8.15.0":
  version "8.19.1"
  resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.19.1.tgz#794cfc8add4f373b9cd6fa32e367e7565a0e231b"
  integrity sha512-60L9KIuN/xgmsINzonOcMDSB8p82h95hoBfSBtXuO4jlR1R9L1xSkmVZKgCPVfavDlXihh4ARNjXhh1gGnLC7Q==
@ -2589,7 +2589,7 @@
    semver "^7.6.0"
    ts-api-utils "^2.0.0"
-"@typescript-eslint/utils@8.19.1", "@typescript-eslint/utils@^6.0.0 || ^7.0.0 || ^8.0.0":
+"@typescript-eslint/utils@8.19.1", "@typescript-eslint/utils@^6.0.0 || ^7.0.0 || ^8.0.0", "@typescript-eslint/utils@^8.15.0":
  version "8.19.1"
  resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.19.1.tgz#dd8eabd46b92bf61e573286e1c0ba6bd243a185b"
  integrity sha512-IxG5gLO0Ne+KaUc8iW1A+XuKLd63o4wlbI1Zp692n1xojCl/THvgIKXJXBZixTh5dd5+yTJ/VXH7GJaaw21qXA==
@ -2926,6 +2926,11 @@ aria-query@5.3.0, aria-query@^5.0.0:
  dependencies:
    dequal "^2.0.3"
 aria-query@^5.3.2:
  version "5.3.2"
  resolved "https://registry.yarnpkg.com/aria-query/-/aria-query-5.3.2.tgz#93f81a43480e33a338f19163a3d10a50c01dcd59"
  integrity sha512-COROpnaoap1E2F000S62r6A60uHZnmlvomhfyT2DlTcrY1OrBKn2UhH7qn5wTC9zMvD0AY7csdPSNwKP+7WiQw==
 array-buffer-byte-length@^1.0.1:
  version "1.0.1"
  resolved "https://registry.yarnpkg.com/array-buffer-byte-length/-/array-buffer-byte-length-1.0.1.tgz#1e5583ec16763540a27ae52eed99ff899223568f"
@ -3076,6 +3081,11 @@ assertion-error@^1.1.0:
  resolved "https://registry.yarnpkg.com/assertion-error/-/assertion-error-1.1.0.tgz#e60b6b0e8f301bd97e5375215bda406c85118c0b"
  integrity sha512-jgsaNduz+ndvGyFt3uSuWqvy4lCnIJiovtouQN5JZHOKCS2QuhEdbcQHFhVksz2N2U9hXJo8odG7ETyWlEeuDw==
 ast-types-flow@^0.0.8:
  version "0.0.8"
  resolved "https://registry.yarnpkg.com/ast-types-flow/-/ast-types-flow-0.0.8.tgz#0a85e1c92695769ac13a428bb653e7538bea27d6"
  integrity sha512-OH/2E5Fg20h2aPrbe+QL8JZQFko0YZaF+j4mnQ7BGhfavO7OpSLa8a0y9sBwomHdSbkhTS8TQNayBfnW5DwbvQ==
 ast-types@^0.16.1:
  version "0.16.1"
  resolved "https://registry.yarnpkg.com/ast-types/-/ast-types-0.16.1.tgz#7a9da1617c9081bc121faafe91711b4c8bb81da2"
@ -3139,6 +3149,11 @@ available-typed-arrays@^1.0.7:
  dependencies:
    possible-typed-array-names "^1.0.0"
 axe-core@^4.10.0:
  version "4.10.2"
  resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.10.2.tgz#85228e3e1d8b8532a27659b332e39b7fa0e022df"
  integrity sha512-RE3mdQ7P3FRSe7eqCWoeQ/Z9QXrtniSjp1wUjt5nRC3WIpz5rSCve6o3fsZ2aCpJtrZjSZgjwXAoTO5k4tEI0w==
 axios@^0.26.1:
  version "0.26.1"
  resolved "https://registry.yarnpkg.com/axios/-/axios-0.26.1.tgz#1ede41c51fcf51bbbd6fd43669caaa4f0495aaa9"
@ -3146,6 +3161,11 @@ axios@^0.26.1:
  dependencies:
    follow-redirects "^1.14.8"
 axobject-query@^4.1.0:
  version "4.1.0"
  resolved "https://registry.yarnpkg.com/axobject-query/-/axobject-query-4.1.0.tgz#28768c76d0e3cff21bc62a9e2d0b6ac30042a1ee"
  integrity sha512-qIj0G9wZbMGNLjLmg1PT6v2mE9AH2zlnADJD/2tC6E00hgmhUOfEB6greHPAfLRSufHqROIUTkw6E+M3lH0PTQ==
 babel-plugin-polyfill-corejs2@^0.4.10:
  version "0.4.11"
  resolved "https://registry.yarnpkg.com/babel-plugin-polyfill-corejs2/-/babel-plugin-polyfill-corejs2-0.4.11.tgz#30320dfe3ffe1a336c15afdcdafd6fd615b25e33"
@ -3884,6 +3904,11 @@ d3-force@^3.0.0:
  resolved "https://registry.yarnpkg.com/d3-timer/-/d3-timer-3.0.1.tgz#6284d2a2708285b1abb7e201eda4380af35e63b0"
  integrity sha512-ndfJ/JxxMd3nw31uyKoY2naivF+r29V+Lc0svZxe1JvvIRmi8hUsrMvdOwgS1o6uBHmiz91geQ0ylPP0aj1VUA==
 damerau-levenshtein@^1.0.8:
  version "1.0.8"
  resolved "https://registry.yarnpkg.com/damerau-levenshtein/-/damerau-levenshtein-1.0.8.tgz#b43d286ccbd36bc5b2f7ed41caf2d0aba1f8a6e7"
  integrity sha512-sdQSFB7+llfUcQHUQO3+B8ERRj0Oa4w9POWMI/puGtuf7gFywGmkaLCElnudfTiKZV+NvHqL0ifzdrI8Ro7ESA==
 data-uri-to-buffer@^4.0.0:
  version "4.0.1"
  resolved "https://registry.yarnpkg.com/data-uri-to-buffer/-/data-uri-to-buffer-4.0.1.tgz#d8feb2b2881e6a4f58c2e08acfd0e2834e26222e"
@ -4631,6 +4656,32 @@ eslint-plugin-jest@^28.10.0:
  dependencies:
    "@typescript-eslint/utils" "^6.0.0 || ^7.0.0 || ^8.0.0"
 eslint-plugin-jsx-a11y@^6.10.2:
  version "6.10.2"
  resolved "https://registry.yarnpkg.com/eslint-plugin-jsx-a11y/-/eslint-plugin-jsx-a11y-6.10.2.tgz#d2812bb23bf1ab4665f1718ea442e8372e638483"
  integrity sha512-scB3nz4WmG75pV8+3eRUQOHZlNSUhFNq37xnpgRkCCELU3XMvXAxLk1eqWWyE22Ki4Q01Fnsw9BA3cJHDPgn2Q==
  dependencies:
    aria-query "^5.3.2"
    array-includes "^3.1.8"
    array.prototype.flatmap "^1.3.2"
    ast-types-flow "^0.0.8"
    axe-core "^4.10.0"
    axobject-query "^4.1.0"
    damerau-levenshtein "^1.0.8"
    emoji-regex "^9.2.2"
    hasown "^2.0.2"
    jsx-ast-utils "^3.3.5"
    language-tags "^1.0.9"
    minimatch "^3.1.2"
    object.fromentries "^2.0.8"
    safe-regex-test "^1.0.3"
    string.prototype.includes "^2.0.1"
 eslint-plugin-react-hooks@^5.1.0:
  version "5.1.0"
  resolved "https://registry.yarnpkg.com/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-5.1.0.tgz#3d34e37d5770866c34b87d5b499f5f0b53bf0854"
  integrity sha512-mpJRtPgHN2tNAvZ35AMfqeB3Xqeo273QxrHJsbBEPWODRM4r0yB6jfoROqKEYrOn27UtRPpcpHc2UqyBSuUNTw==
 eslint-plugin-react@^7.37.3:
  version "7.37.3"
  resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.37.3.tgz#567549e9251533975c4ea9706f986c3a64832031"
@ -4660,6 +4711,14 @@ eslint-plugin-suggest-no-throw@^1.0.0:
  resolved "https://registry.yarnpkg.com/eslint-plugin-suggest-no-throw/-/eslint-plugin-suggest-no-throw-1.0.0.tgz#facc852aa9acd5e0f4d5e0aff71d6a186e3be8e8"
  integrity sha512-IoSDNVeH9WRC9T4Nm3HResFthgiPEW8e6YkKzichJ4fZwac0T8qBQ/8qjmv9NeRSEw8q2EbN/THLE/UU38J46g==
 eslint-plugin-testing-library@^7.1.1:
  version "7.1.1"
  resolved "https://registry.yarnpkg.com/eslint-plugin-testing-library/-/eslint-plugin-testing-library-7.1.1.tgz#df834e821e53fa81c1eb1fad5a0d9ba4c510f9ea"
  integrity sha512-nszC833aZPwB6tik1nMkbFqmtgIXTT0sfJEYs0zMBKMlkQ4to2079yUV96SvmLh00ovSBJI4pgcBC1TiIP8mXg==
  dependencies:
    "@typescript-eslint/scope-manager" "^8.15.0"
    "@typescript-eslint/utils" "^8.15.0"
 eslint-scope@^7.2.2:
  version "7.2.2"
  resolved "https://registry.yarnpkg.com/eslint-scope/-/eslint-scope-7.2.2.tgz#deb4f92563390f32006894af62a22dba1c46423f"
@ -6392,7 +6451,7 @@ jsonfile@^6.0.1:
  optionalDependencies:
    graceful-fs "^4.1.6"
-"jsx-ast-utils@^2.4.1 || ^3.0.0":
+"jsx-ast-utils@^2.4.1 || ^3.0.0", jsx-ast-utils@^3.3.5:
  version "3.3.5"
  resolved "https://registry.yarnpkg.com/jsx-ast-utils/-/jsx-ast-utils-3.3.5.tgz#4766bd05a8e2a11af222becd19e15575e52a853a"
  integrity sha512-ZZow9HBI5O6EPgSJLUb8n2NKgmVWTwCvHGwFuJlMjvLFqlGG6pjirPhtdsseaLZjSibD8eegzmYpUZwoIlj2cQ==
@ -6432,6 +6491,18 @@ kill-port@^2.0.1:
    get-them-args "1.3.2"
    shell-exec "1.0.2"
 language-subtag-registry@^0.3.20:
  version "0.3.23"
  resolved "https://registry.yarnpkg.com/language-subtag-registry/-/language-subtag-registry-0.3.23.tgz#23529e04d9e3b74679d70142df3fd2eb6ec572e7"
  integrity sha512-0K65Lea881pHotoGEa5gDlMxt3pctLi2RplBb7Ezh4rRdLEOtgi7n4EwK9lamnUCkKBqaeKRVebTq6BAxSkpXQ==
 language-tags@^1.0.9:
  version "1.0.9"
  resolved "https://registry.yarnpkg.com/language-tags/-/language-tags-1.0.9.tgz#1ffdcd0ec0fafb4b1be7f8b11f306ad0f9c08777"
  integrity sha512-MbjN408fEndfiQXbFQ1vnd+1NoLDsnQW41410oQBXiyXDMYH5z505juWa4KUE1LqxRC7DgOgZDbKLxHIwm27hA==
  dependencies:
    language-subtag-registry "^0.3.20"
 lazy-val@^1.0.4, lazy-val@^1.0.5:
  version "1.0.5"
  resolved "https://registry.yarnpkg.com/lazy-val/-/lazy-val-1.0.5.tgz#6cf3b9f5bc31cee7ee3e369c0832b7583dcd923d"
@ -8630,6 +8701,15 @@ string-width@^5.0.0, string-width@^5.0.1, string-width@^5.1.2:
    emoji-regex "^9.2.2"
    strip-ansi "^7.0.1"
 string.prototype.includes@^2.0.1:
  version "2.0.1"
  resolved "https://registry.yarnpkg.com/string.prototype.includes/-/string.prototype.includes-2.0.1.tgz#eceef21283640761a81dbe16d6c7171a4edf7d92"
  integrity sha512-o7+c9bW6zpAdJHTtujeePODAhkuicdAryFsfVKwA+wGw89wJ4GTY484WTucM9hLtDEOpOvI+aHnzqnC5lHp4Rg==
  dependencies:
    call-bind "^1.0.7"
    define-properties "^1.2.1"
    es-abstract "^1.23.3"
 string.prototype.matchall@^4.0.12:
  version "4.0.12"
  resolved "https://registry.yarnpkg.com/string.prototype.matchall/-/string.prototype.matchall-4.0.12.tgz#6c88740e49ad4956b1332a911e949583a275d4c0"
Author	SHA1	Message	Date
Jonathan Tran	702e322f90	ci: Add yarn test of packages/codemirror-lang-kcl (#5035 ) * ci: Add yarn test of packages/codemirror-lang-kcl * Fix CI error running tests * Fix postcss config error	2025-01-14 09:30:08 -05:00
Jess Frazelle	e82830754d	turns on helix from edge (#5036 ) * updates for new lib Signed-off-by: Jess Frazelle <github@jessfraz.com> * autocomplete Signed-off-by: Jess Frazelle <github@jessfraz.com> * bump version Signed-off-by: Jess Frazelle <github@jessfraz.com> * bump all the things Signed-off-by: Jess Frazelle <github@jessfraz.com> * new samples Signed-off-by: Jess Frazelle <github@jessfraz.com> * docs Signed-off-by: Jess Frazelle <github@jessfraz.com> --------- Signed-off-by: Jess Frazelle <github@jessfraz.com>	2025-01-13 23:34:43 +00:00
Pierre Jacquier	7806377a5a	Disable auto-updater on non-versioned builds (#5042 )	2025-01-13 17:40:51 -05:00
Jonathan Tran	859afa2fd8	Upgrade all wasm-bindgen dependencies together (#5037 )	2025-01-13 13:24:23 -08:00
Jonathan Tran	0a5f3093fc	Fix Cargo.lock to not have changes (#5034 )	2025-01-13 15:38:24 -05:00
Jonathan Tran	b65f7939f6	Fix artifact types to be more accurate (#5022 )	2025-01-13 15:02:55 -05:00
dependabot[bot]	c35dea5e07	Bump syn from 2.0.95 to 2.0.96 in /src/wasm-lib (#5015 ) Bumps [syn](https://github.com/dtolnay/syn) from 2.0.95 to 2.0.96. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](https://github.com/dtolnay/syn/compare/2.0.95...2.0.96) --- updated-dependencies: - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2025-01-13 10:04:30 -08:00
dependabot[bot]	fc66d4745f	Bump handlebars from 6.2.0 to 6.3.0 in /src/wasm-lib (#5012 ) Bumps [handlebars](https://github.com/sunng87/handlebars-rust) from 6.2.0 to 6.3.0. - [Release notes](https://github.com/sunng87/handlebars-rust/releases) - [Changelog](https://github.com/sunng87/handlebars-rust/blob/master/CHANGELOG.md) - [Commits](https://github.com/sunng87/handlebars-rust/compare/v6.2.0...v6.3.0) --- updated-dependencies: - dependency-name: handlebars dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2025-01-13 13:03:34 -05:00
dependabot[bot]	b313d26c2a	Bump @lezer/generator from 1.7.1 to 1.7.2 (#5018 ) Bumps [@lezer/generator](https://github.com/lezer-parser/generator) from 1.7.1 to 1.7.2. - [Changelog](https://github.com/lezer-parser/generator/blob/main/CHANGELOG.md) - [Commits](https://github.com/lezer-parser/generator/compare/1.7.1...1.7.2) --- updated-dependencies: - dependency-name: "@lezer/generator" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2025-01-13 11:48:13 -05:00
Jonathan Tran	00b94ead62	Add packages to Dependabot updates (#5024 )	2025-01-13 11:29:00 -05:00
Jonathan Tran	0531ea1ce9	Change Dependabot PRs to always be made on Mondays (#5025 )	2025-01-13 15:30:33 +00:00
Kevin Nadro	5f9a4887c1	Developer workflow: added auto generated workspace file from vitest extension in vscode (#4997 ) * chore: added auto generated workspace file from vitest extension in vscode * fix: auto fmt fixes	2025-01-13 09:57:12 -05:00
Jonathan Tran	da7dfa16d8	Fix lost lints and add new ones (#5011 ) * Add eslint-plugin-jsx-a11y dependency * Add jsx-a11y lint * Add eslint-plugin-react-hooks dependency * Add react hooks lints * Ignore new react hooks lint in tests * Add eslint-plugin-testing-library dependency * Add testing-library lint * Fix yarn lint to use all files recursively	2025-01-13 09:30:14 -05:00
		`@ -0,0 +1 @@`
							`// This is here to prevent using the one in the root of the project.`