Merge branch 'main' into updater-test

.codespellrc

@@ -1,3 +1,3 @@
 [codespell]
 ignore-words-list: crate,everytime,inout,co-ordinate,ot,nwo,atleast,ue,afterall,ser,fromM,FromM
-skip: **/target,node_modules,build,dist,./out,**/Cargo.lock,./docs/kcl/*.md,./e2e/playwright/lib/console-error-whitelist.ts,.package-lock.json,**/package-lock.json,./openapi/*.json,./packages/codemirror-lang-kcl/test/all.test.ts,./public/kcl-samples,./rust/kcl-lib/tests/kcl_samples,tsconfig.tsbuildinfo,./src/lib/machine-api.d.ts
+skip: **/target,node_modules,build,dist,./out,**/Cargo.lock,./docs/kcl/*.md,.package-lock.json,**/package-lock.json,./openapi/*.json,./packages/codemirror-lang-kcl/test/all.test.ts,./public/kcl-samples,./rust/kcl-lib/tests/kcl_samples,tsconfig.tsbuildinfo,./src/lib/machine-api.d.ts

.eslintrc.json

@@ -19,11 +19,6 @@
     "plugin:jsx-a11y/recommended",
     "plugin:react-hooks/recommended"
   ],
-  "settings": {
-    "react": {
-      "version": "detect"
-    }
-  },
   "rules": {
     "no-array-constructor": "off", // This is wrong; use the @typescript-eslint one instead.
     "@typescript-eslint/no-array-constructor": "error",
@@ -66,7 +61,6 @@
     "jsx-a11y/click-events-have-key-events": "off",
     "jsx-a11y/no-autofocus": "off",
     "jsx-a11y/no-noninteractive-element-interactions": "off",
-    "react/no-unknown-property": "error",
     "no-restricted-globals": [
       "error",
       {

.github/ci-cd-scripts/playwright-electron.sh

@@ -26,8 +26,8 @@ max_retries=1
 # Retry failed tests, doing our own retries because using inbuilt Playwright retries causes connection issues
 while [[ $retry -le $max_retries ]]; do
     if [[ -f "test-results/.last-run.json" ]]; then
-        status=$(jq -r '.status' test-results/.last-run.json)
-        if [[ "$status" == "failed" ]]; then
+        failed_tests=$(jq '.failedTests | length' test-results/.last-run.json)
+        if [[ $failed_tests -gt 0 ]]; then
             echo "retried=true" >>$GITHUB_OUTPUT
             echo "run playwright with last failed tests and retry $retry"
             if [[ "$3" == *ubuntu* ]]; then
@@ -56,11 +56,10 @@ done
 echo "retried=false" >>$GITHUB_OUTPUT
 
 if [[ -f "test-results/.last-run.json" ]]; then
-    status=$(jq -r '.status' test-results/.last-run.json)
-    if [[ "$status" == "failed" ]]; then
-        # If it still fails after retries, then fail the job
+    failed_tests=$(jq '.failedTests | length' test-results/.last-run.json)
+    if [[ $failed_tests -gt 0 ]]; then
+        # If it still fails after 3 retries, then fail the job
         exit 1
     fi
 fi
-
 exit 0

.github/workflows/build-apps.yml

@@ -5,12 +5,14 @@ on:
   push:
     branches:
       - main
+      - updater-test
     tags:
       - 'v[0-9]+.[0-9]+.[0-9]+'
       - 'nightly-v[0-9]+.[0-9]+.[0-9]+'
 
 env:
-  IS_RELEASE: ${{ github.ref_type == 'tag' && startsWith(github.ref_name, 'v') }}
+  # IS_RELEASE: ${{ github.ref_type == 'tag' && startsWith(github.ref_name, 'v') }}
+  IS_RELEASE: true
   IS_NIGHTLY: ${{ github.ref_type == 'tag' && startsWith(github.ref_name, 'nightly-v') }}
 
 concurrency:
@@ -99,11 +101,11 @@ jobs:
           npm run files:set-version
           npm run files:flip-to-nightly
 
-      - name: Set release version
-        if: ${{ env.IS_RELEASE == 'true' }}
-        run: |
-          export VERSION=${GITHUB_REF_NAME#v}
-          npm run files:set-version
+      # - name: Set release version
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   run: |
+      #     export VERSION=${GITHUB_REF_NAME#v}
+      #     npm run files:set-version
 
       - uses: actions/upload-artifact@v4
         with:
@@ -122,17 +124,17 @@ jobs:
       - id: export_notes
         run: echo "notes=`cat release-notes.md`" >> "$GITHUB_OUTPUT"
 
-      - name: Prepare electron-builder.yml file for updater test
-        if: ${{ env.IS_RELEASE == 'true' }}
-        run: |
-          yq -i '.publish[0].url = "https://dl.zoo.dev/releases/modeling-app/updater-test"' electron-builder.yml
+      # - name: Prepare electron-builder.yml file for updater test
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   run: |
+      #     yq -i '.publish[0].url = "https://dl.zoo.dev/releases/modeling-app/updater-test"' electron-builder.yml
 
-      - uses: actions/upload-artifact@v4
-        if: ${{ env.IS_RELEASE == 'true' }}
-        with:
-          name: prepared-files-updater-test
-          path: |
-            electron-builder.yml
+      # - uses: actions/upload-artifact@v4
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   with:
+      #     name: prepared-files-updater-test
+      #     path: |
+      #       electron-builder.yml
 
 
   build-apps:
@@ -260,53 +262,53 @@ jobs:
 
       # The steps below are for updater-test builds, only on release
 
-      - uses: actions/download-artifact@v4
-        if: ${{ env.IS_RELEASE == 'true' }}
-        name: prepared-files-updater-test
+      # - uses: actions/download-artifact@v4
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   name: prepared-files-updater-test
 
-      - name: Copy updated electron-builder.yml file for updater test
-        if: ${{ env.IS_RELEASE == 'true' }}
-        run: |
-          ls -R prepared-files-updater-test
-          cp prepared-files-updater-test/electron-builder.yml electron-builder.yml
+      # - name: Copy updated electron-builder.yml file for updater test
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   run: |
+      #     ls -R prepared-files-updater-test
+      #     cp prepared-files-updater-test/electron-builder.yml electron-builder.yml
 
-      - name: Build the app (updater-test)
-        if: ${{ env.IS_RELEASE == 'true' }}
-        env:
-          APPLE_ID: ${{ secrets.APPLE_ID }}
-          APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
-          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
-          APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
-          CSC_LINK: ${{ secrets.APPLE_CERTIFICATE }}
-          CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
-          CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }}
-          WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }}
-        run: npm run tronb:package:prod
+      # - name: Build the app (updater-test)
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   env:
+      #     APPLE_ID: ${{ secrets.APPLE_ID }}
+      #     APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
+      #     APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
+      #     APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
+      #     CSC_LINK: ${{ secrets.APPLE_CERTIFICATE }}
+      #     CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
+      #     CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }}
+      #     WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }}
+      #   run: npm run tronb:package:prod
 
-      - uses: actions/upload-artifact@v4
-        if: ${{ env.IS_RELEASE == 'true' }}
-        with:
-          name: updater-test-arm64-${{ matrix.platform }}
-          path: |
-            out/*-arm64-win.exe
-            out/*-arm64-mac.dmg
-            out/*-arm64-linux.AppImage
+      # - uses: actions/upload-artifact@v4
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   with:
+      #     name: updater-test-arm64-${{ matrix.platform }}
+      #     path: |
+      #       out/*-arm64-win.exe
+      #       out/*-arm64-mac.dmg
+      #       out/*-arm64-linux.AppImage
 
-      - uses: actions/upload-artifact@v4
-        if: ${{ env.IS_RELEASE == 'true' }}
-        with:
-          name: updater-test-x64-${{ matrix.platform }}
-          path: |
-            out/*-x64-win.exe
-            out/*-x64-mac.dmg
-            out/*-x86_64-linux.AppImage
+      # - uses: actions/upload-artifact@v4
+      #   if: ${{ env.IS_RELEASE == 'true' }}
+      #   with:
+      #     name: updater-test-x64-${{ matrix.platform }}
+      #     path: |
+      #       out/*-x64-win.exe
+      #       out/*-x64-mac.dmg
+      #       out/*-x86_64-linux.AppImage
 
 
   upload-apps-release:
     runs-on: ubuntu-22.04
     permissions:
       contents: write
-    if: ${{ github.ref_type == 'tag' }}
+    # if: ${{ github.ref_type == 'tag' }}
     env:
       VERSION_NO_V: ${{ needs.prepare-files.outputs.version }}
       VERSION: ${{ format('v{0}', needs.prepare-files.outputs.version) }}
@@ -424,13 +426,13 @@ jobs:
           npm run files:set-notes
 
       - name: Authenticate to Google Cloud
-        if: ${{ env.IS_NIGHTLY == 'true' }}
+        # if: ${{ env.IS_NIGHTLY == 'true' }}
         uses: 'google-github-actions/auth@v2.1.8'
         with:
           credentials_json: '${{ secrets.GOOGLE_CLOUD_DL_SA }}'
 
       - name: Set up Google Cloud SDK
-        if: ${{ env.IS_NIGHTLY == 'true' }}
+        # if: ${{ env.IS_NIGHTLY == 'true' }}
         uses: google-github-actions/setup-gcloud@v2.1.4
         with:
           project_id: ${{ env.GOOGLE_CLOUD_PROJECT_ID }}
@@ -444,6 +446,14 @@ jobs:
           parent: false
           destination: 'dl.kittycad.io/releases/modeling-app/nightly'
 
+      - name: Upload updater-test files to public bucket
+        uses: google-github-actions/upload-cloud-storage@v2.2.1
+        with:
+          path: out
+          glob: '*'
+          parent: false
+          destination: 'dl.kittycad.io/releases/modeling-app/updater-test'
+
       - name: Invalidate bucket cache on latest*.yml and last_download.json files
         if: ${{ env.IS_NIGHTLY == 'true' }}
         run: npm run files:invalidate-bucket:nightly

.github/workflows/cargo-bench.yml

@@ -50,12 +50,13 @@ jobs:
       - name: Build the benchmark target(s)
         run: |
           cd rust
-          cargo codspeed build
+          cargo codspeed build --measurement-mode walltime
       - name: Run the benchmarks
         uses: CodSpeedHQ/action@v3
         with:
           working-directory: rust
           run: cargo codspeed run
           token: ${{ secrets.CODSPEED_TOKEN }}
+          mode: walltime
         env:
           KITTYCAD_API_TOKEN: ${{ secrets.KITTYCAD_API_TOKEN }}

.github/workflows/e2e-tests.yml

@@ -226,8 +226,8 @@ jobs:
         with:
           shell: bash
           command: npm run test:snapshots
-          timeout_minutes: 5
-          max_attempts: 5
+          timeout_minutes: 30
+          max_attempts: 3
         env:
           token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }}
           snapshottoken: ${{ secrets.KITTYCAD_API_TOKEN }}

.helix/languages.toml

@@ -5,6 +5,6 @@ command = "vscode-eslint-language-server"
 [[language]]
 name = "typescript"
 auto-format = true
-formatter = { command = "./node_modules/@biomejs/biome/bin/biome", args = ["format", "--write", "--stdin-file-path=foo.ts"] }
-# language-servers = [ { name = "eslint", only-features = [ "diagnostics" ] }, "typescript-language-server" ]
+formatter = { command = "node_modules/.bin/prettier", args = ["--parser", "typescript"] }
+language-servers = [ { name = "eslint", only-features = [ "diagnostics" ] }, "typescript-language-server" ]
 

CONTRIBUTING.md

@@ -1,432 +0,0 @@
-# Contributor Guide
-
-## Running a development build
-
-Install a node version manager such as [fnm](https://github.com/Schniz/fnm?tab=readme-ov-#installation).
-
-On Windows, it's also recommended to [upgrade your PowerShell version](https://learn.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-windows?view=powershell-7.5#winget), we're using 7.
-
-Then in the repo run the following to install and use the node version specified in `.nvmrc`. You might need to specify your processor architecture with `--arch arm64` or `--arch x64` if it's not autodetected.
-
-```
-fnm install --corepack-enabled
-fnm use
-```
-
-Install the NPM dependencies with:
-
-```
-npm install
-```
-
-This project uses a lot of Rust compiled to [WASM](https://webassembly.org/) within it. We have package scripts to run rustup, see `package.json` for reference:
-
-```
-# macOS/Linux
-npm run install:rust
-npm run install:wasm-pack:sh
-
-# Windows
-npm run install:rust:windows
-npm run install:wasm-pack:cargo
-```
-
-Then to build the WASM layer, run:
-
-```
-# macOS/Linux
-npm run build:wasm
-
-# Windows
-npm run build:wasm:windows
-```
-
-Or if you have the `gh` cli installed and want to download the latest main wasm bundle. Note that on Windows, you need to associate .ps1 files with PowerShell, which can be done via the right click menu, selecting `C:\Program Files\PowerShell\7\pwsh.exe`, and you can install tools like `gh` via `npm run install:tools:windows`.
-
-```
-# macOS/Linux
-npm run fetch:wasm
-
-# Windows
-npm run fetch:wasm:windows
-```
-
-That will build the WASM binary and put in the `public` dir (though gitignored).
-
-Finally, to run the web app only, run:
-
-```
-npm start
-```
-
-If you're not a Zoo employee you won't be able to access the dev environment, you should copy everything from `.env.production` to `.env.development.local` to make it point to production instead, then when you navigate to `localhost:3000` the easiest way to sign in is to paste `localStorage.setItem('TOKEN_PERSIST_KEY', "your-token-from-https://zoo.dev/account/api-tokens")` replacing the with a real token from https://zoo.dev/account/api-tokens of course, then navigate to `localhost:3000` again. Note that navigating to `localhost:3000/signin` removes your token so you will need to set the token again.
-
-### Development environment variables
-
-The Copilot LSP plugin in the editor requires a Zoo API token to run. In production, we authenticate this with a token via cookie in the browser and device auth token in the desktop environment, but this token is inaccessible in the dev browser version because the cookie is considered "cross-site" (from `localhost` to `dev.zoo.dev`). There is an optional environment variable called `VITE_KC_DEV_TOKEN` that you can populate with a dev token in a `.env.development.local` file to not check it into Git, which will use that token instead of other methods for the LSP service.
-
-### Developing in Chrome
-
-Chrome is in the process of rolling out a new default which
-[blocks Third-Party Cookies](https://developer.chrome.com/en/docs/privacy-sandbox/third-party-cookie-phase-out/).
-If you're having trouble logging into the `modeling-app`, you may need to
-enable third-party cookies. You can enable third-party cookies by clicking on
-the eye with a slash through it in the URL bar, and clicking on "Enable
-Third-Party Cookies".
-
-## Desktop
-
-To spin up the desktop app, `npm install` and `npm run build:wasm` need to have been done before hand then:
-
-```
-npm run tron:start
-```
-
-This will start the application and hot-reload on changes.
-
-Devtools can be opened with the usual Command-Option-I (macOS) or Ctrl-Shift-I (Linux and Windows).
-
-To package the app for your platform with electron-builder, run `npm run tronb:package:dev` (or `npm run tronb:package:prod` to point to the .env.production variables).
-
-## Checking out commits / Bisecting
-
-Which commands from setup are one off vs. need to be run every time?
-
-The following will need to be run when checking out a new commit and guarantees the build is not stale:
-
-```bash
-npm install
-npm run build:wasm
-npm start # or npm run build:local && npm run serve for slower but more production-like build
-```
-
-## Before submitting a PR
-
-Before you submit a contribution PR to this repo, please ensure that:
-
-- There is a corresponding issue for the changes you want to make, so that discussion of approach can be had before work begins.
-- You have separated out refactoring commits from feature commits as much as possible
-- You have run all of the following commands locally:
-  - `npm run fmt`
-  - `npm run tsc`
-  - `npm run test`
-  - Here they are all together: `npm run fmt && npm run tsc && npm run test`
-
-## Release a new version
-
-#### 1. Create a 'Cut release $VERSION' issue
-
-It will be used to document changelog discussions and release testing.
-
-https://github.com/KittyCAD/modeling-app/issues/new
-
-#### 2. Push a new tag
-
-Create a new tag and push it to the repo. The `semantic-release.sh` script will automatically bump the minor part, which we use the most. For instance going from `v0.27.0` to `v0.28.0`.
-
-```
-VERSION=$(./scripts/semantic-release.sh)
-git tag $VERSION
-git push origin --tags
-```
-
-This will trigger the `build-apps` workflow, set the version, build & sign the apps, and generate release files as well as updater-test artifacts.
-
-The workflow should be listed right away [in this list](https://github.com/KittyCAD/modeling-app/actions/workflows/build-apps.yml?query=event%3Apush)).
-
-#### 3. Manually test artifacts
-
-##### Release builds
-
-The release builds can be found under the `out-{arch}-{platform}` zip files, at the very bottom of the `build-apps` summary page for the workflow (triggered by the tag in 2.).
-
-Manually test against this [list](https://github.com/KittyCAD/modeling-app/issues/3588) across Windows, MacOS, Linux and posting results as comments in the issue.
-
-##### Updater-test builds
-
-The other `build-apps` output in the release `build-apps` workflow (triggered by 2.) is `updater-test-{arch}-{platform}`. It's a semi-automated process: for macOS, Windows, and Linux, download the corresponding updater-test artifact file, install the app, run it, expect an updater prompt to a dummy v0.255.255, install it and check that the app comes back at that version.
-
-The only difference with these builds is that they point to a different update location on the release bucket, with this dummy v0.255.255 always available. This helps ensuring that the version we release will be able to update to the next one available.
-
-If the prompt doesn't show up, start the app in command line to grab the electron-updater logs. This is likely an issue with the current build that needs addressing (or the updater-test location in the storage bucket).
-
-```
-# Windows (PowerShell)
-& 'C:\Program Files\Zoo Design Studio\Zoo Design Studio.exe'
-
-# macOS
-/Applications/Zoo\ Modeling\ App.app/Contents/MacOS/Zoo\ Modeling\ App
-
-# Linux
-./Zoo Design Studio-{version}-{arch}-linux.AppImage
-```
-
-#### 4. Publish the release
-
-Head over to https://github.com/KittyCAD/modeling-app/releases/new, pick the newly created tag and type it in the _Release title_ field as well.
-
-Hit _Generate release notes_ as a starting point to discuss the changelog in the issue. Once done, make sure _Set as the latest release_ is checked, and hit _Publish release_.
-
-A new `publish-apps-release` will kick in and you should be able to find it [here](https://github.com/KittyCAD/modeling-app/actions?query=event%3Arelease). On success, the files will be uploaded to the public bucket as well as to the GitHub release, and the announcement on Discord will be sent.
-
-#### 5. Close the issue
-
-If everything is well and the release is out to the public, the issue tracking the release shall be closed.
-
-## Fuzzing the parser
-
-Make sure you install cargo fuzz:
-
-```bash
-$ cargo install cargo-fuzz
-```
-
-```bash
-$ cd rust/kcl-lib
-
-# list the fuzz targets
-$ cargo fuzz list
-
-# run the parser fuzzer
-$ cargo +nightly fuzz run parser
-```
-
-For more information on fuzzing you can check out
-[this guide](https://rust-fuzz.github.io/book/cargo-fuzz.html).
-
-## Tests
-
-### Playwright tests
-
-You will need a `./e2e/playwright/playwright-secrets.env` file:
-
-```bash
-$ touch ./e2e/playwright/playwright-secrets.env
-$ cat ./e2e/playwright/playwright-secrets.env
-token=<dev.zoo.dev/account/api-tokens>
-snapshottoken=<zoo.dev/account/api-tokens>
-```
-or use `export` to set the environment variables `token` and `snapshottoken`.
-
-#### Snapshot tests (Google Chrome on Ubuntu only)
-
-Only Ubunu and Google Chrome is supported for the set of tests evaluating screenshot snapshots.
-If you don't run Ubuntu locally or in a VM, you may use a GitHub Codespace.
-```
-npm run playwright -- install chrome
-npm run test:snapshots
-```
-You may use `-- --update-snapshots` as needed.
-
-#### Electron flow tests (Chromium on Ubuntu, macOS, Windows)
-
-```
-npm run playwright -- install chromium
-npm run test:playwright:electron:local
-```
-You may use `-- -g "my test"` to match specific test titles, or `-- path/to/file.spec.ts` for a test file.
-
-#### Debugger
-
-However, if you want a debugger I recommend using VSCode and the `playwright` extension, as the above command is a cruder debugger that steps into every function call which is annoying.
-With the extension you can set a breakpoint after `waitForDefaultPlanesVisibilityChange` in order to skip app loading, then the vscode debugger's "step over" is much better for being able to stay at the right level of abstraction as you debug the code.
-
-If you want to limit to a single browser use `--project="webkit"` or `firefox`, `Google Chrome`
-Or comment out browsers in `playwright.config.ts`.
-
-note chromium has encoder compat issues which is why were testing against the branded 'Google Chrome'
-
-You may consider using the VSCode extension, it's useful for running individual threads, but some some reason the "record a test" is locked to chromium with we can't use. A work around is to us the CI `npm run playwright codegen -b wk --load-storage ./store localhost:3000`
-
-<details>
-<summary>
-
-Where `./store` should look like this
-
-</summary>
-
-```JSON
-{
-  "cookies": [],
-  "origins": [
-    {
-      "origin": "http://localhost:3000",
-      "localStorage": [
-        {
-          "name": "store",
-          "value": "{\"state\":{\"openPanes\":[\"code\"]},\"version\":0}"
-        },
-        {
-          "name": "persistCode",
-          "value": ""
-        },
-        {
-          "name": "TOKEN_PERSIST_KEY",
-          "value": "your-token"
-        }
-      ]
-    }
-  ]
-}
-```
-
-</details>
-
-However because much of our tests involve clicking in the stream at specific locations, it's code-gen looks `await page.locator('video').click();` when really we need to use a pixel coord, so I think it's of limited use.
-
-### Unit and component tests
-
-If you already haven't, run the following:
-
-```
-npm
-npm run build:wasm
-npm start
-```
-
-and finally:
-
-```
-npm run test:unit
-```
-
-For individual testing:
-
-```
-npm run test abstractSyntaxTree -t "unexpected closed curly brace" --silent=false
-```
-
-Which will run our suite of [Vitest unit](https://vitest.dev/) and [React Testing Library E2E](https://testing-library.com/docs/react-testing-library/intro) tests, in interactive mode by default.
-
-### Rust tests
-
-**Dependencies**
-
-- `KITTYCAD_API_TOKEN`
-- `cargo-nextest`
-- `just`
-
-#### Setting KITTYCAD_API_TOKEN
-
-Use the production zoo.dev token, set this environment variable before running the tests
-
-#### Installing cargonextest
-
-```
-cd rust
-cargo search cargo-nextest
-cargo install cargo-nextest
-```
-
-#### just
-
-install [`just`](https://github.com/casey/just?tab=readme-ov-file#pre-built-binaries)
-
-#### Running the tests
-
-```bash
-# With just
-# Make sure KITTYCAD_API_TOKEN=<prod zoo.dev token> is set
-# Make sure you installed cargo-nextest
-# Make sure you installed just
-cd rust
-just test
-```
-
-```bash
-# Without just
-# Make sure KITTYCAD_API_TOKEN=<prod zoo.dev token> is set
-# Make sure you installed cargo-nextest
-cd rust
-export RUST_BRACKTRACE="full" && cargo nextest run --workspace --test-threads=1
-```
-
-Where `XXX` is an API token from the production engine (NOT the dev environment).
-
-We recommend using [nextest](https://nexte.st/) to run the Rust tests (its faster and is used in CI). Once installed, run the tests using
-
-```
-cd rust
-KITTYCAD_API_TOKEN=XXX cargo run nextest
-```
-
-### Mapping CI CD jobs to local commands
-
-When you see the CI CD fail on jobs you may wonder three things
-
-- Do I have a bug in my code?
-- Is the test flaky?
-- Is there a bug in `main`?
-
-To answer these questions the following commands will give you confidence to locate the issue.
-
-#### Static Analysis
-
-Part of the CI CD pipeline performs static analysis on the code. Use the following commands to mimic the CI CD jobs.
-
-The following set of commands should get us closer to one and done commands to instantly retest issues.
-
-```
-npm run test-setup
-```
-
-> Gotcha, are packages up to date and is the wasm built?
-
-```
-npm run tsc
-npm run fmt:check
-npm run lint
-npm run test:unit:local
-```
-
-> Gotcha: Our unit tests have integration tests in them. You need to run a localhost server to run the unit tests.
-
-#### E2E Tests
-
-**Playwright Electron**
-
-These E2E tests run in electron. There are tests that are skipped if they are ran in a windows, linux, or macos environment. We can use playwright tags to implement test skipping.
-
-```
-npm run test:playwright:electron:local
-npm run test:playwright:electron:windows:local
-npm run test:playwright:electron:macos:local
-npm run test:playwright:electron:ubuntu:local
-```
-
-> Why does it say local? The CI CD commands that run in the pipeline cannot be ran locally. A single command will not properly setup the testing environment locally.
-
-#### Some notes on CI
-
-The tests are broken into snapshot tests and non-snapshot tests, and they run in that order, they automatically commit new snap shots, so if you see an image commit check it was an intended change. If we have non-determinism in the snapshots such that they are always committing new images, hopefully this annoyance makes us fix them asap, if you notice this happening let Kurt know. But for the odd occasion `git reset --hard HEAD~ && git push -f` is your friend.
-
-How to interpret failing playwright tests?
-If your tests fail, click through to the action and see that the tests failed on a line that includes `await page.getByTestId('loading').waitFor({ state: 'detached' })`, this means the test fail because the stream never started. It's you choice if you want to re-run the test, or ignore the failure.
-
-We run on ubuntu and macos, because safari doesn't work on linux because of the dreaded "no RTCPeerConnection variable" error. But linux runs first and then macos for the same reason that we limit the number of parallel tests to 1 because we limit stream connections per user, so tests would start failing we if let them run together.
-
-If something fails on CI you can download the artifact, unzip it and then open `playwright-report/data/<UUID>.zip` with https://trace.playwright.dev/ to see what happened.
-
-#### Getting started writing a playwright test in our app
-
-Besides following the instructions above and using the playwright docs, our app is weird because of the whole stream thing, which means our testing is weird. Because we've just figured out this stuff and therefore docs might go stale quick here's a 15min vid/tutorial
-
-https://github.com/KittyCAD/modeling-app/assets/29681384/6f5e8e85-1003-4fd9-be7f-f36ce833942d
-
-<details>
-
-<summary>
-PS: for the debug panel, the following JSON is useful for snapping the camera
-</summary>
-
-```JSON
-{"type":"modeling_cmd_req","cmd_id":"054e5472-e5e9-4071-92d7-1ce3bac61956","cmd":{"type":"default_camera_look_at","center":{"x":15,"y":0,"z":0},"up":{"x":0,"y":0,"z":1},"vantage":{"x":30,"y":30,"z":30}}}
-```
-
-</details>
-
-### Logging
-
-To display logging (to the terminal or console) set `ZOO_LOG=1`. This will log some warnings and simple performance metrics. To view these in test runs, use `-- --nocapture`.
-
-To enable memory metrics, build with `--features dhat-heap`.

Makefile

@@ -15,8 +15,8 @@ ifdef WINDOWS
 CARGO ?= $(USERPROFILE)/.cargo/bin/cargo.exe
 WASM_PACK ?= $(USERPROFILE)/.cargo/bin/wasm-pack.exe
 else
-CARGO ?= $(shell which cargo || echo ~/.cargo/bin/cargo)
-WASM_PACK ?= $(shell which wasm-pack || echo ~/.cargo/bin/wasm-pack)
+CARGO ?= ~/.cargo/bin/cargo
+WASM_PACK ?= ~/.cargo/bin/wasm-pack
 endif
 
 .PHONY: install

README.md

@@ -1,8 +1,8 @@
 ![Zoo Design Studio](/public/zma-logomark-outlined.png)
 
-# Zoo Design Studio
+## Zoo Design Studio
 
-[zoo.dev/modeling-app](https://zoo.dev/modeling-app)
+download at [zoo.dev/modeling-app/download](https://zoo.dev/modeling-app/download)
 
 A CAD application from the future, brought to you by the [Zoo team](https://zoo.dev).
 
@@ -23,7 +23,7 @@ Design Studio is a _hybrid_ user interface for CAD modeling. You can point-and-c
 
 The 3D view in Design Studio is just a video stream from our hosted geometry engine. The app sends new modeling commands to the engine via WebSockets, which returns back video frames of the view within the engine.
 
-## Technology
+## Tools
 
 - UI
   - [React](https://react.dev/)
@@ -38,16 +38,445 @@ The 3D view in Design Studio is just a video stream from our hosted geometry eng
 - Modeling
   - [KittyCAD TypeScript client](https://github.com/KittyCAD/kittycad.ts)
 
-## Get Started
+[Original demo video](https://drive.google.com/file/d/183_wjqGdzZ8EEZXSqZ3eDcJocYPCyOdC/view?pli=1)
 
-We recommend downloading the latest application binary from our [releases](https://github.com/KittyCAD/modeling-app/releases) page. If you don't see your platform or architecture supported there, please file an issue.
+[Original demo slides](https://github.com/user-attachments/files/19010536/demo.pdf)
 
-If you'd like to try out upcoming changes sooner, you can also download those from our [nightly releases](https://zoo.dev/modeling-app/download/nightly) page.
+## Get started
 
-## Developing
+We recommend downloading the latest application binary from [our Releases page](https://github.com/KittyCAD/modeling-app/releases). If you don't see your platform or architecture supported there, please file an issue.
 
-Finally, if you'd like to run a development build or contribute to the project, please visit our [contributor guide](CONTRIBUTING.md) to get started.
+## Running a development build
+
+Install a node version manager such as [fnm](https://github.com/Schniz/fnm?tab=readme-ov-#installation).
+
+On Windows, it's also recommended to [upgrade your PowerShell version](https://learn.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-windows?view=powershell-7.5#winget), we're using 7.
+
+Then in the repo run the following to install and use the node version specified in `.nvmrc`. You might need to specify your processor architecture with `--arch arm64` or `--arch x64` if it's not autodetected.
+
+```
+fnm install --corepack-enabled
+fnm use
+```
+
+Install the NPM dependencies with:
+
+```
+npm install
+```
+
+This project uses a lot of Rust compiled to [WASM](https://webassembly.org/) within it. We have package scripts to run rustup, see `package.json` for reference:
+
+```
+# macOS/Linux
+npm run install:rust
+npm run install:wasm-pack:sh
+
+# Windows
+npm run install:rust:windows
+npm run install:wasm-pack:cargo
+```
+
+Then to build the WASM layer, run:
+
+```
+# macOS/Linux
+npm run build:wasm
+
+# Windows
+npm run build:wasm:windows
+```
+
+Or if you have the `gh` cli installed and want to download the latest main wasm bundle. Note that on Windows, you need to associate .ps1 files with PowerShell, which can be done via the right click menu, selecting `C:\Program Files\PowerShell\7\pwsh.exe`, and you can install tools like `gh` via `npm run install:tools:windows`.
+
+```
+# macOS/Linux
+npm run fetch:wasm
+
+# Windows
+npm run fetch:wasm:windows
+```
+
+That will build the WASM binary and put in the `public` dir (though gitignored).
+
+Finally, to run the web app only, run:
+
+```
+npm start
+```
+
+If you're not a Zoo employee you won't be able to access the dev environment, you should copy everything from `.env.production` to `.env.development.local` to make it point to production instead, then when you navigate to `localhost:3000` the easiest way to sign in is to paste `localStorage.setItem('TOKEN_PERSIST_KEY', "your-token-from-https://zoo.dev/account/api-tokens")` replacing the with a real token from https://zoo.dev/account/api-tokens of course, then navigate to `localhost:3000` again. Note that navigating to `localhost:3000/signin` removes your token so you will need to set the token again.
+
+### Development environment variables
+
+The Copilot LSP plugin in the editor requires a Zoo API token to run. In production, we authenticate this with a token via cookie in the browser and device auth token in the desktop environment, but this token is inaccessible in the dev browser version because the cookie is considered "cross-site" (from `localhost` to `dev.zoo.dev`). There is an optional environment variable called `VITE_KC_DEV_TOKEN` that you can populate with a dev token in a `.env.development.local` file to not check it into Git, which will use that token instead of other methods for the LSP service.
+
+### Developing in Chrome
+
+Chrome is in the process of rolling out a new default which
+[blocks Third-Party Cookies](https://developer.chrome.com/en/docs/privacy-sandbox/third-party-cookie-phase-out/).
+If you're having trouble logging into the `modeling-app`, you may need to
+enable third-party cookies. You can enable third-party cookies by clicking on
+the eye with a slash through it in the URL bar, and clicking on "Enable
+Third-Party Cookies".
+
+## Desktop
+
+To spin up the desktop app, `npm install` and `npm run build:wasm` need to have been done before hand then:
+
+```
+npm run tron:start
+```
+
+This will start the application and hot-reload on changes.
+
+Devtools can be opened with the usual Command-Option-I (macOS) or Ctrl-Shift-I (Linux and Windows).
+
+To package the app for your platform with electron-builder, run `npm run tronb:package:dev` (or `npm run tronb:package:prod` to point to the .env.production variables).
+
+## Checking out commits / Bisecting
+
+Which commands from setup are one off vs. need to be run every time?
+
+The following will need to be run when checking out a new commit and guarantees the build is not stale:
+
+```bash
+npm install
+npm run build:wasm
+npm start # or npm run build:local && npm run serve for slower but more production-like build
+```
+
+## Before submitting a PR
+
+Before you submit a contribution PR to this repo, please ensure that:
+
+- There is a corresponding issue for the changes you want to make, so that discussion of approach can be had before work begins.
+- You have separated out refactoring commits from feature commits as much as possible
+- You have run all of the following commands locally:
+  - `npm run fmt`
+  - `npm run tsc`
+  - `npm run test`
+  - Here they are all together: `npm run fmt && npm run tsc && npm run test`
+
+## Release a new version
+
+#### 1. Create a 'Cut release $VERSION' issue
+
+It will be used to document changelog discussions and release testing.
+
+https://github.com/KittyCAD/modeling-app/issues/new
+
+#### 2. Push a new tag
+
+Create a new tag and push it to the repo. The `semantic-release.sh` script will automatically bump the minor part, which we use the most. For instance going from `v0.27.0` to `v0.28.0`.
+
+```
+VERSION=$(./scripts/semantic-release.sh)
+git tag $VERSION
+git push origin --tags
+```
+
+This will trigger the `build-apps` workflow, set the version, build & sign the apps, and generate release files as well as updater-test artifacts.
+
+The workflow should be listed right away [in this list](https://github.com/KittyCAD/modeling-app/actions/workflows/build-apps.yml?query=event%3Apush)).
+
+#### 3. Manually test artifacts
+
+##### Release builds
+
+The release builds can be found under the `out-{arch}-{platform}` zip files, at the very bottom of the `build-apps` summary page for the workflow (triggered by the tag in 2.).
+
+Manually test against this [list](https://github.com/KittyCAD/modeling-app/issues/3588) across Windows, MacOS, Linux and posting results as comments in the issue.
+
+##### Updater-test builds
+
+The other `build-apps` output in the release `build-apps` workflow (triggered by 2.) is `updater-test-{arch}-{platform}`. It's a semi-automated process: for macOS, Windows, and Linux, download the corresponding updater-test artifact file, install the app, run it, expect an updater prompt to a dummy v0.255.255, install it and check that the app comes back at that version.
+
+The only difference with these builds is that they point to a different update location on the release bucket, with this dummy v0.255.255 always available. This helps ensuring that the version we release will be able to update to the next one available.
+
+If the prompt doesn't show up, start the app in command line to grab the electron-updater logs. This is likely an issue with the current build that needs addressing (or the updater-test location in the storage bucket).
+
+```
+# Windows (PowerShell)
+& 'C:\Program Files\Zoo Design Studio\Zoo Design Studio.exe'
+
+# macOS
+/Applications/Zoo\ Modeling\ App.app/Contents/MacOS/Zoo\ Modeling\ App
+
+# Linux
+./Zoo Design Studio-{version}-{arch}-linux.AppImage
+```
+
+#### 4. Publish the release
+
+Head over to https://github.com/KittyCAD/modeling-app/releases/new, pick the newly created tag and type it in the _Release title_ field as well.
+
+Hit _Generate release notes_ as a starting point to discuss the changelog in the issue. Once done, make sure _Set as the latest release_ is checked, and hit _Publish release_.
+
+A new `publish-apps-release` will kick in and you should be able to find it [here](https://github.com/KittyCAD/modeling-app/actions?query=event%3Arelease). On success, the files will be uploaded to the public bucket as well as to the GitHub release, and the announcement on Discord will be sent.
+
+#### 5. Close the issue
+
+If everything is well and the release is out to the public, the issue tracking the release shall be closed.
+
+## Fuzzing the parser
+
+Make sure you install cargo fuzz:
+
+```bash
+$ cargo install cargo-fuzz
+```
+
+```bash
+$ cd rust/kcl-lib
+
+# list the fuzz targets
+$ cargo fuzz list
+
+# run the parser fuzzer
+$ cargo +nightly fuzz run parser
+```
+
+For more information on fuzzing you can check out
+[this guide](https://rust-fuzz.github.io/book/cargo-fuzz.html).
+
+## Tests
+
+### Playwright tests
+
+You will need a `./e2e/playwright/playwright-secrets.env` file:
+
+```bash
+$ touch ./e2e/playwright/playwright-secrets.env
+$ cat ./e2e/playwright/playwright-secrets.env
+token=<dev.zoo.dev/account/api-tokens>
+snapshottoken=<zoo.dev/account/api-tokens>
+```
+or use `export` to set the environment variables `token` and `snapshottoken`.
+
+#### Snapshot tests (Google Chrome on Ubuntu only)
+
+Only Ubunu and Google Chrome is supported for the set of tests evaluating screenshot snapshots.
+If you don't run Ubuntu locally or in a VM, you may use a GitHub Codespace.
+```
+npm run playwright -- install chrome
+npm run test:snapshots
+```
+You may use `-- --update-snapshots` as needed.
+
+#### Electron flow tests (Chromium on Ubuntu, macOS, Windows)
+
+```
+npm run playwright -- install chromium
+npm run test:playwright:electron:local 
+```
+You may use `-- -g "my test"` to match specific test titles, or `-- path/to/file.spec.ts` for a test file.
+
+#### Debugger
+
+However, if you want a debugger I recommend using VSCode and the `playwright` extension, as the above command is a cruder debugger that steps into every function call which is annoying.
+With the extension you can set a breakpoint after `waitForDefaultPlanesVisibilityChange` in order to skip app loading, then the vscode debugger's "step over" is much better for being able to stay at the right level of abstraction as you debug the code.
+
+If you want to limit to a single browser use `--project="webkit"` or `firefox`, `Google Chrome`
+Or comment out browsers in `playwright.config.ts`.
+
+note chromium has encoder compat issues which is why were testing against the branded 'Google Chrome'
+
+You may consider using the VSCode extension, it's useful for running individual threads, but some some reason the "record a test" is locked to chromium with we can't use. A work around is to us the CI `npm run playwright codegen -b wk --load-storage ./store localhost:3000`
+
+<details>
+<summary>
+
+Where `./store` should look like this
+
+</summary>
+
+```JSON
+{
+  "cookies": [],
+  "origins": [
+    {
+      "origin": "http://localhost:3000",
+      "localStorage": [
+        {
+          "name": "store",
+          "value": "{\"state\":{\"openPanes\":[\"code\"]},\"version\":0}"
+        },
+        {
+          "name": "persistCode",
+          "value": ""
+        },
+        {
+          "name": "TOKEN_PERSIST_KEY",
+          "value": "your-token"
+        }
+      ]
+    }
+  ]
+}
+```
+
+</details>
+
+However because much of our tests involve clicking in the stream at specific locations, it's code-gen looks `await page.locator('video').click();` when really we need to use a pixel coord, so I think it's of limited use.
+
+### Unit and component tests
+
+If you already haven't, run the following:
+
+```
+npm
+npm run build:wasm
+npm start
+```
+
+and finally:
+
+```
+npm run test:unit
+```
+
+For individual testing:
+
+```
+npm run test abstractSyntaxTree -t "unexpected closed curly brace" --silent=false
+```
+
+Which will run our suite of [Vitest unit](https://vitest.dev/) and [React Testing Library E2E](https://testing-library.com/docs/react-testing-library/intro) tests, in interactive mode by default.
+
+### Rust tests
+
+**Dependencies**
+
+- `KITTYCAD_API_TOKEN`
+- `cargo-nextest`
+- `just`
+
+#### Setting KITTYCAD_API_TOKEN
+
+Use the production zoo.dev token, set this environment variable before running the tests
+
+#### Installing cargonextest
+
+```
+cd rust 
+cargo search cargo-nextest
+cargo install cargo-nextest
+```
+
+#### just
+
+install [`just`](https://github.com/casey/just?tab=readme-ov-file#pre-built-binaries)
+
+#### Running the tests
+
+```bash
+# With just
+# Make sure KITTYCAD_API_TOKEN=<prod zoo.dev token> is set
+# Make sure you installed cargo-nextest
+# Make sure you installed just
+cd rust 
+just test
+```
+
+```bash
+# Without just
+# Make sure KITTYCAD_API_TOKEN=<prod zoo.dev token> is set
+# Make sure you installed cargo-nextest
+cd rust 
+export RUST_BRACKTRACE="full" && cargo nextest run --workspace --test-threads=1
+```
+
+Where `XXX` is an API token from the production engine (NOT the dev environment).
+
+We recommend using [nextest](https://nexte.st/) to run the Rust tests (its faster and is used in CI). Once installed, run the tests using
+
+```
+cd rust 
+KITTYCAD_API_TOKEN=XXX cargo run nextest
+```
+
+### Mapping CI CD jobs to local commands
+
+When you see the CI CD fail on jobs you may wonder three things
+
+- Do I have a bug in my code?
+- Is the test flaky?
+- Is there a bug in `main`?
+
+To answer these questions the following commands will give you confidence to locate the issue.
+
+#### Static Analysis
+
+Part of the CI CD pipeline performs static analysis on the code. Use the following commands to mimic the CI CD jobs.
+
+The following set of commands should get us closer to one and done commands to instantly retest issues.
+
+```
+npm run test-setup
+```
+
+> Gotcha, are packages up to date and is the wasm built?
+
+```
+npm run tsc
+npm run fmt:check
+npm run lint
+npm run test:unit:local
+```
+
+> Gotcha: Our unit tests have integration tests in them. You need to run a localhost server to run the unit tests.
+
+#### E2E Tests
+
+**Playwright Electron**
+
+These E2E tests run in electron. There are tests that are skipped if they are ran in a windows, linux, or macos environment. We can use playwright tags to implement test skipping.
+
+```
+npm run test:playwright:electron:local
+npm run test:playwright:electron:windows:local
+npm run test:playwright:electron:macos:local
+npm run test:playwright:electron:ubuntu:local
+```
+
+> Why does it say local? The CI CD commands that run in the pipeline cannot be ran locally. A single command will not properly setup the testing environment locally.
+
+#### Some notes on CI
+
+The tests are broken into snapshot tests and non-snapshot tests, and they run in that order, they automatically commit new snap shots, so if you see an image commit check it was an intended change. If we have non-determinism in the snapshots such that they are always committing new images, hopefully this annoyance makes us fix them asap, if you notice this happening let Kurt know. But for the odd occasion `git reset --hard HEAD~ && git push -f` is your friend.
+
+How to interpret failing playwright tests?
+If your tests fail, click through to the action and see that the tests failed on a line that includes `await page.getByTestId('loading').waitFor({ state: 'detached' })`, this means the test fail because the stream never started. It's you choice if you want to re-run the test, or ignore the failure.
+
+We run on ubuntu and macos, because safari doesn't work on linux because of the dreaded "no RTCPeerConnection variable" error. But linux runs first and then macos for the same reason that we limit the number of parallel tests to 1 because we limit stream connections per user, so tests would start failing we if let them run together.
+
+If something fails on CI you can download the artifact, unzip it and then open `playwright-report/data/<UUID>.zip` with https://trace.playwright.dev/ to see what happened.
+
+#### Getting started writing a playwright test in our app
+
+Besides following the instructions above and using the playwright docs, our app is weird because of the whole stream thing, which means our testing is weird. Because we've just figured out this stuff and therefore docs might go stale quick here's a 15min vid/tutorial
+
+https://github.com/KittyCAD/modeling-app/assets/29681384/6f5e8e85-1003-4fd9-be7f-f36ce833942d
+
+<details>
+
+<summary>
+PS: for the debug panel, the following JSON is useful for snapping the camera
+</summary>
+
+```JSON
+{"type":"modeling_cmd_req","cmd_id":"054e5472-e5e9-4071-92d7-1ce3bac61956","cmd":{"type":"default_camera_look_at","center":{"x":15,"y":0,"z":0},"up":{"x":0,"y":0,"z":1},"vantage":{"x":30,"y":30,"z":30}}}
+```
+
+</details>
 
 ## KCL
 
-To contribute to the KittyCAD Language, see the [README](https://github.com/KittyCAD/modeling-app/tree/main/rust/kcl-lib) for KCL.
+For how to contribute to KCL, [see our KCL README](https://github.com/KittyCAD/modeling-app/tree/main/rust/kcl-lib).
+
+### Logging
+
+To display logging (to the terminal or console) set `ZOO_LOG=1`. This will log some warnings and simple performance metrics. To view these in test runs, use `-- --nocapture`.
+
+To enable memory metrics, build with `--features dhat-heap`.

docs/kcl/bezierCurve.md

@@ -10,10 +10,8 @@ Draw a smooth, continuous, curved line segment from the current origin to the de
 
 ```js
 bezierCurve(
+  data: BezierData,
   sketch: Sketch,
-  control1: [number],
-  control2: [number],
-  end: [number],
   tag?: TagDeclarator,
 ): Sketch
 ```
@@ -23,11 +21,9 @@ bezierCurve(
 
 | Name | Type | Description | Required |
 |----------|------|-------------|----------|
-| `sketch` | [`Sketch`](/docs/kcl/types/Sketch) | Which sketch should this path be added to? | Yes |
-| `control1` | [`[number]`](/docs/kcl/types/number) | First control point for the cubic | Yes |
-| `control2` | [`[number]`](/docs/kcl/types/number) | Second control point for the cubic | Yes |
-| `end` | [`[number]`](/docs/kcl/types/number) | How far away (along the X and Y axes) should this line go? | Yes |
-| [`tag`](/docs/kcl/types/tag) | [`TagDeclarator`](/docs/kcl/types#tag-declaration) | Create a new tag which refers to this line | No |
+| `data` | [`BezierData`](/docs/kcl/types/BezierData) | Data to draw a bezier curve. | Yes |
+| `sketch` | [`Sketch`](/docs/kcl/types/Sketch) |  | Yes |
+| [`tag`](/docs/kcl/types/tag) | [`TagDeclarator`](/docs/kcl/types#tag-declaration) |  | No |
 
 ### Returns
 
@@ -40,7 +36,11 @@ bezierCurve(
 exampleSketch = startSketchOn(XZ)
   |> startProfileAt([0, 0], %)
   |> line(end = [0, 10])
-  |> bezierCurve(control1 = [5, 0], control2 = [5, 10], end = [10, 10])
+  |> bezierCurve({
+       to = [10, 10],
+       control1 = [5, 0],
+       control2 = [5, 10]
+     }, %)
   |> line(endAbsolute = [10, 0])
   |> close()
 

docs/kcl/extrude.md

@@ -42,10 +42,18 @@ extrude(
 example = startSketchOn(XZ)
   |> startProfileAt([0, 0], %)
   |> line(end = [10, 0])
-  |> arc(angleStart = 120, angleEnd = 0, radius = 5)
+  |> arc({
+       angleStart = 120,
+       angleEnd = 0,
+       radius = 5
+     }, %)
   |> line(end = [5, 0])
   |> line(end = [0, 10])
-  |> bezierCurve(control1 = [-10, 0], control2 = [2, 10], end = [-5, 10])
+  |> bezierCurve({
+       control1 = [-10, 0],
+       control2 = [2, 10],
+       to = [-5, 10]
+     }, %)
   |> line(end = [-5, -2])
   |> close()
   |> extrude(length = 10)
@@ -56,10 +64,18 @@ example = startSketchOn(XZ)
 ```js
 exampleSketch = startSketchOn(XZ)
   |> startProfileAt([-10, 0], %)
-  |> arc(angleStart = 120, angleEnd = -60, radius = 5)
+  |> arc({
+       angleStart = 120,
+       angleEnd = -60,
+       radius = 5
+     }, %)
   |> line(end = [10, 0])
   |> line(end = [5, 0])
-  |> bezierCurve(control1 = [-3, 0], control2 = [2, 10], end = [-5, 10])
+  |> bezierCurve({
+       control1 = [-3, 0],
+       control2 = [2, 10],
+       to = [-5, 10]
+     }, %)
   |> line(end = [-4, 10])
   |> line(end = [-5, -2])
   |> close()
@@ -72,10 +88,18 @@ example = extrude(exampleSketch, length = 10)
 ```js
 exampleSketch = startSketchOn(XZ)
   |> startProfileAt([-10, 0], %)
-  |> arc(angleStart = 120, angleEnd = -60, radius = 5)
+  |> arc({
+       angleStart = 120,
+       angleEnd = -60,
+       radius = 5
+     }, %)
   |> line(end = [10, 0])
   |> line(end = [5, 0])
-  |> bezierCurve(control1 = [-3, 0], control2 = [2, 10], end = [-5, 10])
+  |> bezierCurve({
+       control1 = [-3, 0],
+       control2 = [2, 10],
+       to = [-5, 10]
+     }, %)
   |> line(end = [-4, 10])
   |> line(end = [-5, -2])
   |> close()
@@ -88,10 +112,18 @@ example = extrude(exampleSketch, length = 20, symmetric = true)
 ```js
 exampleSketch = startSketchOn(XZ)
   |> startProfileAt([-10, 0], %)
-  |> arc(angleStart = 120, angleEnd = -60, radius = 5)
+  |> arc({
+       angleStart = 120,
+       angleEnd = -60,
+       radius = 5
+     }, %)
   |> line(end = [10, 0])
   |> line(end = [5, 0])
-  |> bezierCurve(control1 = [-3, 0], control2 = [2, 10], end = [-5, 10])
+  |> bezierCurve({
+       control1 = [-3, 0],
+       control2 = [2, 10],
+       to = [-5, 10]
+     }, %)
   |> line(end = [-4, 10])
   |> line(end = [-5, -2])
   |> close()

docs/kcl/fromCm.md

@@ -4,12 +4,8 @@ excerpt: "Converts a number from centimeters to the current default unit."
 layout: manual
 ---
 
-**WARNING:** This function is deprecated.
-
 Converts a number from centimeters to the current default unit.
 
-*DEPRECATED* prefer using explicit numeric suffixes (e.g., `42cm`) or the `to...` conversion functions.
-
 No matter what units the current file uses, this function will always return a number equivalent to the input in centimeters.
 
 For example, if the current file uses inches, `fromCm(1)` will return `0.393701`. If the current file uses millimeters, `fromCm(1)` will return `10`. If the current file uses centimeters, `fromCm(1)` will return `1`.

docs/kcl/fromFt.md

@@ -4,12 +4,8 @@ excerpt: "Converts a number from feet to the current default unit."
 layout: manual
 ---
 
-**WARNING:** This function is deprecated.
-
 Converts a number from feet to the current default unit.
 
-*DEPRECATED* prefer using explicit numeric suffixes (e.g., `42ft`) or the `to...` conversion functions.
-
 No matter what units the current file uses, this function will always return a number equivalent to the input in feet.
 
 For example, if the current file uses inches, `fromFt(1)` will return `12`. If the current file uses millimeters, `fromFt(1)` will return `304.8`. If the current file uses feet, `fromFt(1)` will return `1`.

docs/kcl/fromInches.md

@@ -4,12 +4,8 @@ excerpt: "Converts a number from inches to the current default unit."
 layout: manual
 ---
 
-**WARNING:** This function is deprecated.
-
 Converts a number from inches to the current default unit.
 
-*DEPRECATED* prefer using explicit numeric suffixes (e.g., `42inch`) or the `to...` conversion functions.
-
 No matter what units the current file uses, this function will always return a number equivalent to the input in inches.
 
 For example, if the current file uses inches, `fromInches(1)` will return `1`. If the current file uses millimeters, `fromInches(1)` will return `25.4`.

docs/kcl/fromM.md

@@ -4,12 +4,8 @@ excerpt: "Converts a number from meters to the current default unit."
 layout: manual
 ---
 
-**WARNING:** This function is deprecated.
-
 Converts a number from meters to the current default unit.
 
-*DEPRECATED* prefer using explicit numeric suffixes (e.g., `42m`) or the `to...` conversion functions.
-
 No matter what units the current file uses, this function will always return a number equivalent to the input in meters.
 
 For example, if the current file uses inches, `fromM(1)` will return `39.3701`. If the current file uses millimeters, `fromM(1)` will return `1000`. If the current file uses meters, `fromM(1)` will return `1`.

docs/kcl/fromMm.md

@@ -4,12 +4,8 @@ excerpt: "Converts a number from mm to the current default unit."
 layout: manual
 ---
 
-**WARNING:** This function is deprecated.
-
 Converts a number from mm to the current default unit.
 
-*DEPRECATED* prefer using explicit numeric suffixes (e.g., `42mm`) or the `to...` conversion functions.
-
 No matter what units the current file uses, this function will always return a number equivalent to the input in millimeters.
 
 For example, if the current file uses inches, `fromMm(1)` will return `1/25.4`. If the current file uses millimeters, `fromMm(1)` will return `1`.

docs/kcl/fromYd.md

@@ -4,12 +4,8 @@ excerpt: "Converts a number from yards to the current default unit."
 layout: manual
 ---
 
-**WARNING:** This function is deprecated.
-
 Converts a number from yards to the current default unit.
 
-*DEPRECATED* prefer using explicit numeric suffixes (e.g., `42yd`) or the `to...` conversion functions.
-
 No matter what units the current file uses, this function will always return a number equivalent to the input in yards.
 
 For example, if the current file uses inches, `fromYd(1)` will return `36`. If the current file uses millimeters, `fromYd(1)` will return `914.4`. If the current file uses yards, `fromYd(1)` will return `1`.

docs/kcl/index.md

@@ -22,8 +22,18 @@ layout: manual
   * [`string`](kcl/types/string)
   * [`tag`](kcl/types/tag)
 * **std**
+  * [`Axis2d`](kcl/types/Axis2d)
+  * [`Axis3d`](kcl/types/Axis3d)
   * [`END`](kcl/consts/std-END)
+  * [`Edge`](kcl/types/Edge)
+  * [`Face`](kcl/types/Face)
+  * [`Helix`](kcl/types/Helix)
+  * [`Plane`](kcl/types/Plane)
+  * [`Point2d`](kcl/types/Point2d)
+  * [`Point3d`](kcl/types/Point3d)
   * [`START`](kcl/consts/std-START)
+  * [`Sketch`](kcl/types/Sketch)
+  * [`Solid`](kcl/types/Solid)
   * [`X`](kcl/consts/std-X)
   * [`XY`](kcl/consts/std-XY)
   * [`XZ`](kcl/consts/std-XZ)
@@ -38,9 +48,14 @@ layout: manual
   * [`angledLineThatIntersects`](kcl/angledLineThatIntersects)
   * [`appearance`](kcl/appearance)
   * [`arc`](kcl/arc)
+  * [`arcTo`](kcl/arcTo)
   * [`asin`](kcl/asin)
   * [`assert`](kcl/assert)
-  * [`assertIs`](kcl/assertIs)
+  * [`assertEqual`](kcl/assertEqual)
+  * [`assertGreaterThan`](kcl/assertGreaterThan)
+  * [`assertGreaterThanOrEq`](kcl/assertGreaterThanOrEq)
+  * [`assertLessThan`](kcl/assertLessThan)
+  * [`assertLessThanOrEq`](kcl/assertLessThanOrEq)
   * [`atan`](kcl/atan)
   * [`atan2`](kcl/atan2)
   * [`bezierCurve`](kcl/bezierCurve)
@@ -51,6 +66,12 @@ layout: manual
   * [`extrude`](kcl/extrude)
   * [`fillet`](kcl/fillet)
   * [`floor`](kcl/floor)
+  * [`fromCm`](kcl/fromCm)
+  * [`fromFt`](kcl/fromFt)
+  * [`fromInches`](kcl/fromInches)
+  * [`fromM`](kcl/fromM)
+  * [`fromMm`](kcl/fromMm)
+  * [`fromYd`](kcl/fromYd)
   * [`getCommonEdge`](kcl/getCommonEdge)
   * [`getNextAdjacentEdge`](kcl/getNextAdjacentEdge)
   * [`getOppositeEdge`](kcl/getOppositeEdge)
@@ -110,14 +131,8 @@ layout: manual
   * [`sweep`](kcl/sweep)
   * [`tangentToEnd`](kcl/tangentToEnd)
   * [`tangentialArc`](kcl/tangentialArc)
-  * [`toCentimeters`](kcl/std-toCentimeters)
-  * [`toDegrees`](kcl/std-toDegrees)
-  * [`toFeet`](kcl/std-toFeet)
-  * [`toInches`](kcl/std-toInches)
-  * [`toMeters`](kcl/std-toMeters)
-  * [`toMillimeters`](kcl/std-toMillimeters)
-  * [`toRadians`](kcl/std-toRadians)
-  * [`toYards`](kcl/std-toYards)
+  * [`toDegrees`](kcl/toDegrees)
+  * [`toRadians`](kcl/toRadians)
   * [`translate`](kcl/translate)
   * [`union`](kcl/union)
   * [`xLine`](kcl/xLine)
@@ -138,14 +153,3 @@ layout: manual
   * [`turns::QUARTER_TURN`](kcl/consts/std-turns-QUARTER_TURN)
   * [`turns::THREE_QUARTER_TURN`](kcl/consts/std-turns-THREE_QUARTER_TURN)
   * [`turns::ZERO`](kcl/consts/std-turns-ZERO)
-* **std::types**
-  * [`Axis2d`](kcl/types/Axis2d)
-  * [`Axis3d`](kcl/types/Axis3d)
-  * [`Edge`](kcl/types/Edge)
-  * [`Face`](kcl/types/Face)
-  * [`Helix`](kcl/types/Helix)
-  * [`Plane`](kcl/types/Plane)
-  * [`Point2d`](kcl/types/Point2d)
-  * [`Point3d`](kcl/types/Point3d)
-  * [`Sketch`](kcl/types/Sketch)
-  * [`Solid`](kcl/types/Solid)

docs/kcl/int.md

@@ -34,7 +34,7 @@ int(num: number): number
 
 ```js
 n = int(ceil(5 / 2))
-assert(n, isEqualTo = 3, error = "5/2 = 2.5, rounded up makes 3")
+assertEqual(n, 3, 0.0001, "5/2 = 2.5, rounded up makes 3")
 // Draw n cylinders.
 startSketchOn(XZ)
   |> circle(center = [0, 0], radius = 2)

docs/kcl/known-issues.md

@@ -21,7 +21,4 @@ once fixed in engine will just start working here with no language changes.
 - **Chamfers**: Chamfers cannot intersect, you will get an error. Only simple
     chamfer cases work currently.
 
-- **Appearance**: Changing the appearance on a loft does not work. 
-    Changing the appearance on an imported model does not work.
-
-- **CSG Booleans**: Coplanar (bodies that share a plane) unions, subtractions, and intersections are not currently supported.
+- **Appearance**: Changing the appearance on a loft does not work.

docs/kcl/modules.md

@@ -109,98 +109,3 @@ Coordinate systems:
 - `zoo` (the default), forward: -Y, up: +Z, handedness: right
 - `opengl`, forward: +Z, up: +Y, handedness: right
 - `vulkan`, forward: +Z, up: -Y, handedness: left
-
-### Performance
-
-Parallelized foreign-file imports now let you overlap file reads, initialization,
-and rendering. To maximize throughput, you need to understand the three distinct
-stages—reading, initializing (background render start), and invocation (blocking)
-—and structure your code to defer blocking operations until the end.
-
-#### Foreign Import Execution Stages
-
-1. **Import (Read) Stage**  
-   ```norun
-   import "tests/inputs/cube.step" as cube
-   ```  
-   - Reads the file from disk and makes its API available.  
-   - **Does _not_** start Engine rendering or block your script.
-
-2. **Initialization (Background Render) Stage**  
-   ```norun
-   import "tests/inputs/cube.step" as cube
-
-   myCube = cube    // <- This line starts background rendering
-   ```  
-   - Invoking the imported symbol (assignment or plain call) triggers Engine rendering _in the background_.  
-   - This kick‑starts the render pipeline but doesn’t block—you can continue other work while the Engine processes the model.
-
-3. **Invocation (Blocking) Stage**  
-   ```norun
-   import "tests/inputs/cube.step" as cube
-
-   myCube = cube
-
-   myCube
-    |> translate(z=10) // <- This line blocks
-   ```  
-   - Any method call (e.g., `translate`, `scale`, `rotate`) waits for the background render to finish before applying transformations.  
-   - This is the only point where your script will block.
-
-> **Nuance:**  Foreign imports differ from pure KCL modules—calling the same import symbol multiple times (e.g., `screw` twice) starts background rendering twice.
-
-#### Best Practices
-
-##### 1. Defer Blocking Calls
-Initialize early but delay all transformations until after your heavy computation:
-```norun
-import "tests/inputs/cube.step" as cube     // 1) Read
-
-myCube = cube                               // 2) Background render starts
-
-
-// --- perform other operations and calculations or setup here ---
-
-
-myCube
-  |> translate(z=10)                        // 3) Blocks only here
-```
-
-##### 2. Encapsulate Imports in Modules
-Keep `main.kcl` free of reads and initialization; wrap them:
-
-```norun
-// imports.kcl
-import "tests/inputs/cube.step" as cube    // Read only
-
-
-export myCube = cube                      // Kick off rendering
-```
-
-```norun
-// main.kcl
-import myCube from "imports.kcl"  // Import the initialized object 
-
-
-// ... computations ...
-
-
-myCube
-  |> translate(z=10)              // Blocking call at the end
-```
-
-##### 3. Avoid Immediate Method Calls
-
-```norun
-import "tests/inputs/cube.step" as cube
-
-cube
-  |> translate(z=10)              // Blocks immediately, negating parallelism
-```
-
-Both calling methods right on `cube` immediately or leaving an implicit import without assignment introduce blocking.
-
-#### Future Improvements
-
-Upcoming releases will auto‑analyze dependencies and only block when truly necessary. Until then, explicit deferral and modular wrapping give you the best performance.
-

docs/kcl/patternTransform.md

@@ -174,7 +174,7 @@ t = 0.005 // taper factor [0-1)
 // Defines how to modify each layer of the vase.
 // Each replica is shifted up the Z axis, and has a smoothly-varying radius
 fn transform(replicaId) {
-  scale = r * abs(1 - (t * replicaId)) * (5 + cos(replicaId / 8: number(rad)))
+  scale = r * abs(1 - (t * replicaId)) * (5 + cos(replicaId / 8))
   return {
     translate = [0, 0, replicaId * 10],
     scale = [scale, scale, 0]
@@ -205,12 +205,12 @@ fn transform(i) {
 }
 startSketchOn(XY)
   |> startProfileAt([0, 0], %)
-  |> polygon(
+  |> polygon({
        radius = 10,
        numSides = 4,
        center = [0, 0],
-       inscribed = false,
-     )
+       inscribed = false
+     }, %)
   |> extrude(length = 4)
   |> patternTransform(instances = 3, transform = transform)
 ```

docs/kcl/polygon.md

@@ -10,11 +10,9 @@ Create a regular polygon with the specified number of sides that is either inscr
 
 ```js
 polygon(
+  data: PolygonData,
   sketchSurfaceOrGroup: SketchOrSurface,
-  radius: number,
-  numSides: u64,
-  center: [number],
-  inscribed?: bool,
+  tag?: TagDeclarator,
 ): Sketch
 ```
 
@@ -23,11 +21,9 @@ polygon(
 
 | Name | Type | Description | Required |
 |----------|------|-------------|----------|
-| `sketchSurfaceOrGroup` | [`SketchOrSurface`](/docs/kcl/types/SketchOrSurface) | Plane or surface to sketch on | Yes |
-| `radius` | [`number`](/docs/kcl/types/number) | The radius of the polygon | Yes |
-| `numSides` | `u64` | The number of sides in the polygon | Yes |
-| `center` | [`[number]`](/docs/kcl/types/number) | The center point of the polygon | Yes |
-| `inscribed` | [`bool`](/docs/kcl/types/bool) | Whether the polygon is inscribed (true, the default) or circumscribed (false) about a circle with the specified radius | No |
+| `data` | [`PolygonData`](/docs/kcl/types/PolygonData) | Data for drawing a polygon | Yes |
+| `sketchSurfaceOrGroup` | [`SketchOrSurface`](/docs/kcl/types/SketchOrSurface) | A sketch surface or a sketch. | Yes |
+| [`tag`](/docs/kcl/types/tag) | [`TagDeclarator`](/docs/kcl/types#tag-declaration) |  | No |
 
 ### Returns
 
@@ -39,12 +35,12 @@ polygon(
 ```js
 // Create a regular hexagon inscribed in a circle of radius 10
 hex = startSketchOn(XY)
-  |> polygon(
+  |> polygon({
        radius = 10,
        numSides = 6,
        center = [0, 0],
-       inscribed = true,
-     )
+       inscribed = true
+     }, %)
 
 example = extrude(hex, length = 5)
 ```
@@ -54,12 +50,12 @@ example = extrude(hex, length = 5)
 ```js
 // Create a square circumscribed around a circle of radius 5
 square = startSketchOn(XY)
-  |> polygon(
+  |> polygon({
        radius = 5.0,
        numSides = 4,
        center = [10, 10],
-       inscribed = false,
-     )
+       inscribed = false
+     }, %)
 example = extrude(square, length = 5)
 ```
 

docs/kcl/profileStart.md

@@ -9,7 +9,7 @@ Extract the provided 2-dimensional sketch's profile's origin value.
 
 
 ```js
-profileStart(profile: Sketch): [number]
+profileStart(sketch: Sketch): [number]
 ```
 
 
@@ -17,7 +17,7 @@ profileStart(profile: Sketch): [number]
 
 | Name | Type | Description | Required |
 |----------|------|-------------|----------|
-| `profile` | [`Sketch`](/docs/kcl/types/Sketch) | Profile whose start is being used | Yes |
+| `sketch` | [`Sketch`](/docs/kcl/types/Sketch) |  | Yes |
 
 ### Returns
 

docs/kcl/profileStartX.md

@@ -9,7 +9,7 @@ Extract the provided 2-dimensional sketch's profile's origin's 'x' value.
 
 
 ```js
-profileStartX(profile: Sketch): number
+profileStartX(sketch: Sketch): number
 ```
 
 
@@ -17,7 +17,7 @@ profileStartX(profile: Sketch): number
 
 | Name | Type | Description | Required |
 |----------|------|-------------|----------|
-| `profile` | [`Sketch`](/docs/kcl/types/Sketch) | Profile whose start is being used | Yes |
+| `sketch` | [`Sketch`](/docs/kcl/types/Sketch) |  | Yes |
 
 ### Returns
 

docs/kcl/profileStartY.md

@@ -9,7 +9,7 @@ Extract the provided 2-dimensional sketch's profile's origin's 'y' value.
 
 
 ```js
-profileStartY(profile: Sketch): number
+profileStartY(sketch: Sketch): number
 ```
 
 
@@ -17,7 +17,7 @@ profileStartY(profile: Sketch): number
 
 | Name | Type | Description | Required |
 |----------|------|-------------|----------|
-| `profile` | [`Sketch`](/docs/kcl/types/Sketch) | Profile whose start is being used | Yes |
+| `sketch` | [`Sketch`](/docs/kcl/types/Sketch) |  | Yes |
 
 ### Returns
 

docs/kcl/rotate.md

@@ -53,7 +53,7 @@ rotate(
 
 ### Returns
 
-[`SolidOrSketchOrImportedGeometry`](/docs/kcl/types/SolidOrSketchOrImportedGeometry) - Data for a solid, sketch, or an imported geometry.
+[`SolidOrSketchOrImportedGeometry`](/docs/kcl/types/SolidOrSketchOrImportedGeometry) - Data for a solid or an imported geometry.
 
 
 ### Examples

docs/kcl/scale.md

@@ -37,7 +37,7 @@ scale(
 
 ### Returns
 
-[`SolidOrSketchOrImportedGeometry`](/docs/kcl/types/SolidOrSketchOrImportedGeometry) - Data for a solid, sketch, or an imported geometry.
+[`SolidOrSketchOrImportedGeometry`](/docs/kcl/types/SolidOrSketchOrImportedGeometry) - Data for a solid or an imported geometry.
 
 
 ### Examples

docs/kcl/std-math-cos.md

@@ -31,7 +31,7 @@ exampleSketch = startSketchOn(XZ)
   |> startProfileAt([0, 0], %)
   |> angledLine(
     angle = 30,
-    length = 3 / cos(30deg),
+    length = 3 / cos(toRadians(30)),
   )
   |> yLine(endAbsolute = 0)
   |> close()

docs/kcl/std-math-polar.md

@@ -11,7 +11,7 @@ cartesian (x/y/z grid) coordinates.
 
 ```js
 polar(
-  angle: number(rad),
+  angle: number(Angle),
   length: number(Length),
 ): Point2d
 ```
@@ -21,7 +21,7 @@ polar(
 
 | Name | Type | Description | Required |
 |----------|------|-------------|----------|
-| `angle` | `number(rad)` |  | Yes |
+| `angle` | `number(Angle)` |  | Yes |
 | `length` | `number(Length)` |  | Yes |
 
 ### Returns

docs/kcl/std-math-sin.md

@@ -31,7 +31,7 @@ exampleSketch = startSketchOn(XZ)
   |> startProfileAt([0, 0], %)
   |> angledLine(
     angle = 50,
-    length = 15 / sin(135deg),
+    length = 15 / sin(toRadians(135)),
   )
   |> yLine(endAbsolute = 0)
   |> close()

docs/kcl/std-math-tan.md

@@ -31,7 +31,7 @@ exampleSketch = startSketchOn(XZ)
   |> startProfileAt([0, 0], %)
   |> angledLine(
     angle = 50,
-    length = 50 * tan((1/2): number(rad)),
+    length = 50 * tan(1/2),
   )
   |> yLine(endAbsolute = 0)
   |> close()

docs/kcl/std-toCentimeters.md

@@ -1,27 +0,0 @@
----
-title: "std::toCentimeters"
-excerpt: "Convert a number to centimeters from its current units."
-layout: manual
----
-
-Convert a number to centimeters from its current units.
-
-
-
-```js
-toCentimeters(@num: number(cm)): number(cm)
-```
-
-
-### Arguments
-
-| Name | Type | Description | Required |
-|----------|------|-------------|----------|
-| `num` | `number(cm)` |  | Yes |
-
-### Returns
-
-`number(cm)`
-
-
-

docs/kcl/std-toFeet.md

@@ -1,27 +0,0 @@
----
-title: "std::toFeet"
-excerpt: "Convert a number to feet from its current units."
-layout: manual
----
-
-Convert a number to feet from its current units.
-
-
-
-```js
-toFeet(@num: number(ft)): number(ft)
-```
-
-
-### Arguments
-
-| Name | Type | Description | Required |
-|----------|------|-------------|----------|
-| `num` | `number(ft)` |  | Yes |
-
-### Returns
-
-`number(ft)`
-
-
-

docs/kcl/std-toInches.md

@@ -1,27 +0,0 @@
----
-title: "std::toInches"
-excerpt: "Convert a number to inches from its current units."
-layout: manual
----
-
-Convert a number to inches from its current units.
-
-
-
-```js
-toInches(@num: number(in)): number(in)
-```
-
-
-### Arguments
-
-| Name | Type | Description | Required |
-|----------|------|-------------|----------|
-| `num` | `number(in)` |  | Yes |
-
-### Returns
-
-`number(in)`
-
-
-

docs/kcl/std-toMeters.md

@@ -1,27 +0,0 @@
----
-title: "std::toMeters"
-excerpt: "Convert a number to meters from its current units."
-layout: manual
----
-
-Convert a number to meters from its current units.
-
-
-
-```js
-toMeters(@num: number(m)): number(m)
-```
-
-
-### Arguments
-
-| Name | Type | Description | Required |
-|----------|------|-------------|----------|
-| `num` | `number(m)` |  | Yes |
-
-### Returns
-
-`number(m)`
-
-
-

docs/kcl/std-toMillimeters.md

@@ -1,27 +0,0 @@
----
-title: "std::toMillimeters"
-excerpt: "Convert a number to millimeters from its current units."
-layout: manual
----
-
-Convert a number to millimeters from its current units.
-
-
-
-```js
-toMillimeters(@num: number(mm)): number(mm)
-```
-
-
-### Arguments
-
-| Name | Type | Description | Required |
-|----------|------|-------------|----------|
-| `num` | `number(mm)` |  | Yes |
-
-### Returns
-
-`number(mm)`
-
-
-

docs/kcl/std-toYards.md

@@ -1,27 +0,0 @@
----
-title: "std::toYards"
-excerpt: "Converts a number to yards from its current units."
-layout: manual
----
-
-Converts a number to yards from its current units.
-
-
-
-```js
-toYards(@num: number(yd)): number(yd)
-```
-
-
-### Arguments
-
-| Name | Type | Description | Required |
-|----------|------|-------------|----------|
-| `num` | `number(yd)` |  | Yes |
-
-### Returns
-
-`number(yd)`
-
-
-

docs/kcl/translate.md

@@ -33,7 +33,7 @@ translate(
 
 ### Returns
 
-[`SolidOrSketchOrImportedGeometry`](/docs/kcl/types/SolidOrSketchOrImportedGeometry) - Data for a solid, sketch, or an imported geometry.
+[`SolidOrSketchOrImportedGeometry`](/docs/kcl/types/SolidOrSketchOrImportedGeometry) - Data for a solid or an imported geometry.
 
 
 ### Examples

docs/kcl/types.md

@@ -145,7 +145,7 @@ This helps keep your code neat and avoid unnecessary declarations.
 Say you have a long pipeline of sketch functions, like this:
 
 ```norun
-startSketchOn(XZ)
+startSketchOn('XZ')
   |> line(%, end = [3, 4])
   |> line(%, end = [10, 10])
   |> line(%, end = [-13, -14])
@@ -160,7 +160,7 @@ means that `|> line(%, end = [3, 4])` and `|> line(end = [3, 4])` are equivalent
 could be rewritten as 
 
 ```norun
-startSketchOn(XZ)
+startSketchOn('XZ')
  |> line(end = [3, 4])
  |> line(end = [10, 10])
  |> line(end = [-13, -14])
@@ -182,7 +182,7 @@ The syntax for declaring a tag is `$myTag` you would use it in the following
 way:
 
 ```norun
-startSketchOn(XZ)
+startSketchOn('XZ')
   |> startProfileAt(origin, %)
   |> angledLine(angle = 0, length = 191.26, tag = $rectangleSegmentA001)
   |> angledLine(
@@ -217,7 +217,7 @@ However if the code was written like this:
 
 ```norun
 fn rect(origin) {
-  return startSketchOn(XZ)
+  return startSketchOn('XZ')
     |> startProfileAt(origin, %)
     |> angledLine(angle = 0, length = 191.26, tag = $rectangleSegmentA001)
     |> angledLine(
@@ -227,7 +227,7 @@ fn rect(origin) {
        )
     |> angledLine(
          angle = segAng(rectangleSegmentA001),
-         length = -segLen(rectangleSegmentA001),
+         length = -segLen(rectangleSegmentA001)
          tag = $rectangleSegmentC001,
        )
     |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
@@ -247,7 +247,7 @@ For example the following code works.
 
 ```norun
 fn rect(origin) {
-  return startSketchOn(XZ)
+  return startSketchOn('XZ')
     |> startProfileAt(origin, %)
     |> angledLine(angle = 0, length = 191.26, tag = $rectangleSegmentA001)
     |> angledLine(
@@ -257,7 +257,7 @@ fn rect(origin) {
        )
     |> angledLine(
          angle = segAng(rectangleSegmentA001),
-         length = -segLen(rectangleSegmentA001),
+         length = -segLen(rectangleSegmentA001)
          tag = $rectangleSegmentC001,
        )
     |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
@@ -268,8 +268,11 @@ rect([0, 0])
 myRect = rect([20, 0])
 
 myRect
-  |> extrude(length = 10)
-  |> fillet(radius = 0.5, tags = [myRect.tags.rectangleSegmentA001])
+  |> extrude(10, %)
+  |> fillet(
+       radius = 0.5,
+       tags = [myRect.tags.rectangleSegmentA001]
+     )
 ```
 
 See how we use the tag `rectangleSegmentA001` in the `fillet` function outside

docs/kcl/types/Axis2d.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Axis2d"
+title: "std::Axis2d"
 excerpt: "An infinite line in 2d space."
 layout: manual
 ---

docs/kcl/types/Axis3d.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Axis3d"
+title: "std::Axis3d"
 excerpt: "An infinite line in 3d space."
 layout: manual
 ---

docs/kcl/types/Edge.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Edge"
+title: "std::Edge"
 excerpt: "The edge of a solid."
 layout: manual
 ---

docs/kcl/types/Face.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Face"
+title: "std::Face"
 excerpt: "A face."
 layout: manual
 ---

docs/kcl/types/Helix.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Helix"
+title: "std::Helix"
 excerpt: "A helix."
 layout: manual
 ---

docs/kcl/types/Path.md

@@ -141,8 +141,8 @@ A base path.
 |----------|------|-------------|----------|
 | `type` |enum: `ArcThreePoint`|  | No |
 | `p1` |`[number, number]`| Point 1 of the arc (base on the end of previous segment) | No |
-| `p2` |`[number, number]`| Point 2 of the arc (interiorAbsolute kwarg) | No |
-| `p3` |`[number, number]`| Point 3 of the arc (endAbsolute kwarg) | No |
+| `p2` |`[number, number]`| Point 2 of the arc (interior kwarg) | No |
+| `p3` |`[number, number]`| Point 3 of the arc (end kwarg) | No |
 | `from` |`[number, number]`| The from point. | No |
 | `to` |`[number, number]`| The to point. | No |
 | `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A unit of length. | No |

docs/kcl/types/Plane.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Plane"
+title: "std::Plane"
 excerpt: "A plane."
 layout: manual
 ---

docs/kcl/types/Point2d.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Point2d"
+title: "std::Point2d"
 excerpt: "A point in two dimensional space."
 layout: manual
 ---

docs/kcl/types/Point3d.md

@@ -1,5 +1,5 @@
 ---
-title: "std::types::Point3d"
+title: "std::Point3d"
 excerpt: "A point in three dimensional space."
 layout: manual
 ---

docs/kcl/types/SketchSurface.md

@@ -31,6 +31,7 @@ A sketch type.
 | `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane's X axis be? | No |
 | `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane's Y axis be? | No |
 | `zAxis` |[`Point3d`](/docs/kcl/types/Point3d)| The z-axis (normal). | No |
+| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A unit of length. | No |
 
 
 ----

docs/kcl/types/SolidOrSketchOrImportedGeometry.md

@@ -1,10 +1,10 @@
 ---
 title: "SolidOrSketchOrImportedGeometry"
-excerpt: "Data for a solid, sketch, or an imported geometry."
+excerpt: "Data for a solid or an imported geometry."
 layout: manual
 ---
 
-Data for a solid, sketch, or an imported geometry.
+Data for a solid or an imported geometry.
 
 
 

docs/kcl/types/tag.md

@@ -12,7 +12,7 @@ The syntax for declaring a tag is `$myTag` you would use it in the following
 way:
 
 ```js
-startSketchOn(XZ)
+startSketchOn('XZ')
   |> startProfileAt(origin, %)
   |> angledLine(angle = 0, length = 191.26, tag = $rectangleSegmentA001)
   |> angledLine(
@@ -46,7 +46,7 @@ However if the code was written like this:
 
 ```js
 fn rect(origin) {
-  return startSketchOn(XZ)
+  return startSketchOn('XZ')
     |> startProfileAt(origin, %)
     |> angledLine(angle = 0, length = 191.26, tag = $rectangleSegmentA001)
     |> angledLine(
@@ -75,7 +75,7 @@ For example the following code works.
 
 ```js
 fn rect(origin) {
-  return startSketchOn(XZ)
+  return startSketchOn('XZ')
     |> startProfileAt(origin, %)
     |> angledLine(angle = 0, length = 191.26, tag = $rectangleSegmentA001)
     |> angledLine(
@@ -94,8 +94,11 @@ rect([0, 0])
 myRect = rect([20, 0])
 
 myRect
-  |> extrude(length = 10)
-  |> fillet(radius = 0.5, tags = [myRect.tags.rectangleSegmentA001])
+  |> extrude(10, %)
+  |> fillet(
+       radius = 0.5,
+       tags = [myRect.tags.rectangleSegmentA001]
+     )
 ```
 
 See how we use the tag `rectangleSegmentA001` in the `fillet` function outside

e2e/playwright/app-header-tests.spec.ts

@@ -29,11 +29,11 @@ test.describe('Electron app header tests', () => {
   test(
     'User settings has correct shortcut',
     { tag: '@electron' },
-    async ({ page, toolbar }, testInfo) => {
+    async ({ page }, testInfo) => {
       await page.setBodyDimensions({ width: 1200, height: 500 })
 
       // Open the user sidebar menu.
-      await toolbar.userSidebarButton.click()
+      await page.getByTestId('user-sidebar-toggle').click()
 
       // No space after "User settings" since it's textContent.
       const text =

e2e/playwright/auth.spec.ts

@@ -1,53 +0,0 @@
-import { expect, test } from '@e2e/playwright/zoo-test'
-
-// test file is for testing auth functionality
-test.describe('Authentication tests', () => {
-  test(
-    `The user can sign out and back in`,
-    { tag: ['@electron'] },
-    async ({ page, homePage, signInPage, toolbar, tronApp }) => {
-      if (!tronApp) {
-        fail()
-      }
-
-      await page.setBodyDimensions({ width: 1000, height: 500 })
-      await homePage.projectSection.waitFor()
-
-      await test.step('Click on sign out and expect sign in page', async () => {
-        await toolbar.userSidebarButton.click()
-        await toolbar.signOutButton.click()
-        await expect(signInPage.signInButton).toBeVisible()
-      })
-
-      await test.step('Click on sign in and cancel, click again and expect different code', async () => {
-        await signInPage.signInButton.click()
-        await expect(signInPage.userCode).toBeVisible()
-        const firstUserCode = await signInPage.userCode.textContent()
-        await signInPage.cancelSignInButton.click()
-        await expect(signInPage.signInButton).toBeVisible()
-
-        await signInPage.signInButton.click()
-        await expect(signInPage.userCode).toBeVisible()
-        const secondUserCode = await signInPage.userCode.textContent()
-        expect(secondUserCode).not.toEqual(firstUserCode)
-      })
-
-      await test.step('Press back button and remain on home page', async () => {
-        await page.goBack()
-        await expect(homePage.projectSection).not.toBeVisible()
-        await expect(signInPage.signInButton).toBeVisible()
-      })
-
-      await test.step('Sign in, activate, and expect home page', async () => {
-        await signInPage.signInButton.click()
-        await expect(signInPage.userCode).toBeVisible()
-        const userCode = await signInPage.userCode.textContent()
-        expect(userCode).not.toBeNull()
-        await signInPage.verifyAndConfirmAuth(userCode!)
-
-        // Longer timeout than usual here for the wait on home page
-        await expect(homePage.projectSection).toBeVisible({ timeout: 10000 })
-      })
-    }
-  )
-})

e2e/playwright/feature-tree-pane.spec.ts

@@ -430,17 +430,5 @@ profile003 = startProfileAt([0, -4.93], sketch001)
       await editor.expectEditor.not.toContain('sketch001 =')
       await editor.expectEditor.not.toContain('profile002 = ')
     })
-
-    await test.step(`Delete the remaining plane via feature tree`, async () => {
-      const operationButton = await toolbar.getFeatureTreeOperation(
-        'Offset Plane',
-        0
-      )
-      await operationButton.click({ button: 'left' })
-      await page.keyboard.press('Delete')
-
-      // Verify the plane code is gone, and https://github.com/KittyCAD/modeling-app/issues/5988 is fixed.
-      await editor.expectEditor.not.toContain('plane001 =')
-    })
   })
 })

e2e/playwright/fixtures/cmdBarFixture.ts

@@ -178,13 +178,6 @@ export class CmdBarFixture {
     return this.page.getByRole('option', options)
   }
 
-  /**
-   * Clicks the Create new variable button for kcl input
-   */
-  createNewVariable = async () => {
-    await this.page.getByRole('button', { name: 'Create new variable' }).click()
-  }
-
   /**
    * Captures a snapshot of the request sent to the text-to-cad API endpoint
    * and saves it to a file named after the current test.

e2e/playwright/fixtures/fixtureSetup.ts

@@ -18,7 +18,6 @@ import type { Settings } from '@rust/kcl-lib/bindings/Settings'
 import { CmdBarFixture } from '@e2e/playwright/fixtures/cmdBarFixture'
 import { EditorFixture } from '@e2e/playwright/fixtures/editorFixture'
 import { HomePageFixture } from '@e2e/playwright/fixtures/homePageFixture'
-import { SignInPageFixture } from '@e2e/playwright/fixtures/signInPageFixture'
 import { SceneFixture } from '@e2e/playwright/fixtures/sceneFixture'
 import { ToolbarFixture } from '@e2e/playwright/fixtures/toolbarFixture'
 
@@ -67,7 +66,6 @@ export interface Fixtures {
   toolbar: ToolbarFixture
   scene: SceneFixture
   homePage: HomePageFixture
-  signInPage: SignInPageFixture
 }
 
 export class ElectronZoo {
@@ -389,9 +387,6 @@ const fixturesBasedOnProcessEnvPlatform = {
   homePage: async ({ page }: { page: Page }, use: FnUse) => {
     await use(new HomePageFixture(page))
   },
-  signInPage: async ({ page }: { page: Page }, use: FnUse) => {
-    await use(new SignInPageFixture(page))
-  },
 }
 
 if (process.env.PLATFORM === 'web') {

e2e/playwright/fixtures/sceneFixture.ts

@@ -257,14 +257,6 @@ export class SceneFixture {
     await expectPixelColor(this.page, colour, coords, diff)
   }
 
-  expectPixelColorNotToBe = async (
-    colour: [number, number, number] | [number, number, number][],
-    coords: { x: number; y: number },
-    diff: number
-  ) => {
-    await expectPixelColorNotToBe(this.page, colour, coords, diff)
-  }
-
   get gizmo() {
     return this.page.locator('[aria-label*=gizmo]')
   }
@@ -286,69 +278,37 @@ function isColourArray(
   return isArray(colour[0])
 }
 
-type PixelColorMatchMode = 'matches' | 'differs'
-
-export async function checkPixelColor(
-  page: Page,
-  colour: [number, number, number] | [number, number, number][],
-  coords: { x: number; y: number },
-  diff: number,
-  mode: PixelColorMatchMode
-) {
-  let finalValue = colour
-  const isMatchMode = mode === 'matches'
-  const actionText = isMatchMode ? 'expecting' : 'not expecting'
-  const functionName = isMatchMode
-    ? 'ExpectPixelColor'
-    : 'ExpectPixelColourNotToBe'
-
-  await expect
-    .poll(
-      async () => {
-        const pixel = (await getPixelRGBs(page)(coords, 1))[0]
-        if (!pixel) return null
-        finalValue = pixel
-
-        let matches
-        if (!isColourArray(colour)) {
-          matches = pixel.every(
-            (channel, index) => Math.abs(channel - colour[index]) < diff
-          )
-        } else {
-          matches = colour.some((c) =>
-            c.every((channel, index) => Math.abs(pixel[index] - channel) < diff)
-          )
-        }
-
-        return isMatchMode ? matches : !matches
-      },
-      { timeout: 10_000 }
-    )
-    .toBeTruthy()
-    .catch((cause) => {
-      throw new Error(
-        `${functionName}: point ${JSON.stringify(
-          coords
-        )} was ${actionText} ${colour} but got ${finalValue}`,
-        { cause }
-      )
-    })
-}
-
 export async function expectPixelColor(
   page: Page,
   colour: [number, number, number] | [number, number, number][],
   coords: { x: number; y: number },
   diff: number
 ) {
-  await checkPixelColor(page, colour, coords, diff, 'matches')
-}
-
-export async function expectPixelColorNotToBe(
-  page: Page,
-  colour: [number, number, number] | [number, number, number][],
-  coords: { x: number; y: number },
-  diff: number
-) {
-  await checkPixelColor(page, colour, coords, diff, 'differs')
+  let finalValue = colour
+  await expect
+    .poll(
+      async () => {
+        const pixel = (await getPixelRGBs(page)(coords, 1))[0]
+        if (!pixel) return null
+        finalValue = pixel
+        if (!isColourArray(colour)) {
+          return pixel.every(
+            (channel, index) => Math.abs(channel - colour[index]) < diff
+          )
+        }
+        return colour.some((c) =>
+          c.every((channel, index) => Math.abs(pixel[index] - channel) < diff)
+        )
+      },
+      { timeout: 10_000 }
+    )
+    .toBeTruthy()
+    .catch((cause) => {
+      throw new Error(
+        `ExpectPixelColor: point ${JSON.stringify(
+          coords
+        )} was expecting ${colour} but got ${finalValue}`,
+        { cause }
+      )
+    })
 }

e2e/playwright/fixtures/signInPageFixture.ts

@@ -1,48 +0,0 @@
-import type { Locator, Page } from '@playwright/test'
-import { secrets } from '@e2e/playwright/secrets'
-
-export class SignInPageFixture {
-  public page: Page
-
-  signInButton!: Locator
-  cancelSignInButton!: Locator
-  userCode!: Locator
-
-  apiBaseUrl!: string
-
-  constructor(page: Page) {
-    this.page = page
-
-    this.signInButton = this.page.getByTestId('sign-in-button')
-    this.cancelSignInButton = this.page.getByTestId('cancel-sign-in-button')
-    this.userCode = this.page.getByTestId('sign-in-user-code')
-
-    // TODO: set this thru env var
-    this.apiBaseUrl = 'https://api.dev.zoo.dev'
-  }
-
-  async verifyAndConfirmAuth(userCode: string) {
-    // Device flow: stolen from the tauri days
-    // https://github.com/KittyCAD/modeling-app/blob/d916c7987452e480719004e6d11fd2e595c7d0eb/e2e/tauri/specs/app.spec.ts#L19
-    const headers = {
-      Authorization: `Bearer ${secrets.token}`,
-      Accept: 'application/json',
-      'Content-Type': 'application/json',
-    }
-    const verifyUrl = `${this.apiBaseUrl}/oauth2/device/verify?user_code=${userCode}`
-    console.log(`GET ${verifyUrl}`)
-    const vr = await fetch(verifyUrl, { headers })
-    console.log(vr.status)
-
-    // Device flow: confirm
-    const confirmUrl = `${this.apiBaseUrl}/oauth2/device/confirm`
-    const data = JSON.stringify({ user_code: userCode })
-    console.log(`POST ${confirmUrl} ${data}`)
-    const cr = await fetch(confirmUrl, {
-      headers,
-      method: 'POST',
-      body: data,
-    })
-    console.log(cr.status)
-  }
-}

e2e/playwright/fixtures/toolbarFixture.ts

@@ -46,9 +46,6 @@ export class ToolbarFixture {
   gizmo!: Locator
   gizmoDisabled!: Locator
   loadButton!: Locator
-  /** User button for the user sidebar menu */
-  userSidebarButton!: Locator
-  signOutButton!: Locator
 
   constructor(page: Page) {
     this.page = page
@@ -85,9 +82,6 @@ export class ToolbarFixture {
     // element or two different elements can represent these states.
     this.gizmo = page.getByTestId('gizmo')
     this.gizmoDisabled = page.getByTestId('gizmo-disabled')
-
-    this.userSidebarButton = page.getByTestId('user-sidebar-toggle')
-    this.signOutButton = page.getByTestId('user-sidebar-sign-out')
   }
 
   get logoLink() {

e2e/playwright/lib/api-reporter.ts

@@ -1,25 +1,6 @@
-import type {
-  Reporter,
-  TestCase,
-  TestResult,
-  FullResult,
-} from '@playwright/test/reporter'
+import type { Reporter, TestCase, TestResult } from '@playwright/test/reporter'
 
 class MyAPIReporter implements Reporter {
-  private pendingRequests: Promise<void>[] = []
-  private allResults: Record<string, any>[] = []
-  private blockingResults: Record<string, any>[] = []
-
-  async onEnd(result: FullResult): Promise<void> {
-    await Promise.all(this.pendingRequests)
-    if (this.allResults.length > 0 && this.blockingResults.length === 0) {
-      result.status = 'passed'
-      if (!process.env.CI) {
-        console.error('TAB API - Marked failures as non-blocking')
-      }
-    }
-  }
-
   onTestEnd(test: TestCase, result: TestResult): void {
     if (!process.env.TAB_API_URL || !process.env.TAB_API_KEY) {
       return
@@ -39,7 +20,6 @@ class MyAPIReporter implements Reporter {
       platform: process.env.RUNNER_OS || process.platform,
       // Extra test and result data
       annotations: test.annotations.map((a) => a.type), // e.g. 'fail' or 'fixme'
-      id: test.id, // computed file/test/project ID used for reruns
       retry: result.retry,
       tags: test.tags, // e.g. '@snapshot' or '@skipWin'
       // Extra environment variables
@@ -55,7 +35,7 @@ class MyAPIReporter implements Reporter {
       RUNNER_ARCH: process.env.RUNNER_ARCH || null,
     }
 
-    const request = (async () => {
+    void (async () => {
       try {
         const response = await fetch(`${process.env.TAB_API_URL}/api/results`, {
           method: 'POST',
@@ -66,27 +46,18 @@ class MyAPIReporter implements Reporter {
           body: JSON.stringify(payload),
         })
 
-        if (response.ok) {
-          const result = await response.json()
-          this.allResults.push(result)
-          if (result.block) {
-            this.blockingResults.push(result)
-          }
-        } else {
-          const error = await response.json()
-          if (!process.env.CI) {
-            console.error('TAB API - Failed to send test result:', error)
-          }
+        if (!response.ok && !process.env.CI) {
+          console.error(
+            'TAB API - Failed to send test result:',
+            await response.text()
+          )
         }
-      } catch (error) {
-        const message = error instanceof Error ? error.message : String(error)
+      } catch {
         if (!process.env.CI) {
-          console.error('TAB API - Unable to send test result:', message)
+          console.error('TAB API - Unable to send test result')
         }
       }
     })()
-
-    this.pendingRequests.push(request)
   }
 }
 

e2e/playwright/lib/console-error-whitelist.ts

@@ -63,18 +63,6 @@ export const isErrorWhitelisted = (exception: Error) => {
         'e2e/playwright/can-create-sketches-on-all-planes-and-their-back-sides.spec.ts XY',
       project: 'Google Chrome',
     },
-    {
-      name: 'fE',
-      message:
-        'engine: Failed to wait for promise from send modeling command: JsValue("no connection to send on")',
-      stack: `fE: engine: Failed to wait for promise from send modeling command: JsValue("no connection to send on")
-     at ET (file:///home/runner/_work/modeling-app/modeling-app/.vite/renderer/main_window/assets/index-BvtRFNLF.js:49875:12)
-     at WGe.clearSceneAndBustCache (file:///home/runner/_work/modeling-app/modeling-app/.vite/renderer/main_window/assets/index-BvtRFNLF.js:91886:19)
-     at async a.onEngineConnectionOpened (file:///home/runner/_work/modeling-app/modeling-app/.vite/renderer/main_window/assets/index-BvtRFNLF.js:91483:9)`,
-      foundInSpec:
-        'e2e/playwright/testing-constraints.spec.ts is frequent but could be any spec',
-      project: 'Google Chrome',
-    },
     {
       name: 'RangeError',
       message: 'Position 160 is out of range for changeset of length 0',

e2e/playwright/native-file-menu.spec.ts

@@ -21,9 +21,8 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
                 if (!app || !app.applicationMenu) {
                   return false
                 }
-                const newProject = app.applicationMenu.getMenuItemById(
-                  'File.Create project'
-                )
+                const newProject =
+                  app.applicationMenu.getMenuItemById('File.New project')
                 if (!newProject) return false
                 newProject.click()
                 return true
@@ -409,7 +408,11 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
           )
           .toBe(true)
       })
-      test('Home.Help.Report a bug', async ({ tronApp, cmdBar, page }) => {
+      test('Home.Help.Refresh and report a bug', async ({
+        tronApp,
+        cmdBar,
+        page,
+      }) => {
         if (!tronApp) fail()
         // Run electron snippet to find the Menu!
         await page.waitForTimeout(100) // wait for createModelingPageMenu() to run
@@ -420,8 +423,9 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
                 if (!app || !app.applicationMenu) {
                   return false
                 }
-                const menu =
-                  app.applicationMenu.getMenuItemById('Help.Report a bug')
+                const menu = app.applicationMenu.getMenuItemById(
+                  'Help.Refresh and report a bug'
+                )
                 if (!menu) return false
                 menu.click()
                 return true
@@ -480,9 +484,8 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
         await page.waitForTimeout(100) // wait for createModelingPageMenu() to run
         await tronApp.electron.evaluate(async ({ app }) => {
           if (!app || !app.applicationMenu) fail()
-          const newProject = app.applicationMenu.getMenuItemById(
-            'File.Create project'
-          )
+          const newProject =
+            app.applicationMenu.getMenuItemById('File.New project')
           if (!newProject) fail()
           newProject.click()
         })
@@ -605,7 +608,7 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
         const expected = 'Export'
         expect(actual).toBe(expected)
       })
-      test('Modeling.File.Share part via Zoo link', async ({
+      test('Modeling.File.Share current part (via Zoo link)', async ({
         tronApp,
         cmdBar,
         page,
@@ -626,10 +629,10 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
             throw new Error('app or app.applicationMenu is missing')
           }
           const openProject = app.applicationMenu.getMenuItemById(
-            'File.Share part via Zoo link'
+            'File.Share current part (via Zoo link)'
           )
           if (!openProject) {
-            throw new Error('File.Share part via Zoo link')
+            throw new Error('File.Share current part (via Zoo link)')
           }
           openProject.click()
         })
@@ -2286,7 +2289,7 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
           if (!menu) fail()
         })
       })
-      test('Modeling.Help.Report a bug', async ({
+      test('Modeling.Help.Refresh and report a bug', async ({
         tronApp,
         cmdBar,
         page,
@@ -2310,8 +2313,9 @@ test.describe('Native file menu', { tag: ['@electron'] }, () => {
             async () =>
               await tronApp.electron.evaluate(async ({ app }) => {
                 if (!app || !app.applicationMenu) return false
-                const menu =
-                  app.applicationMenu.getMenuItemById('Help.Report a bug')
+                const menu = app.applicationMenu.getMenuItemById(
+                  'Help.Refresh and report a bug'
+                )
                 if (!menu) return false
                 menu.click()
                 return true

e2e/playwright/onboarding-tests.spec.ts

@@ -63,7 +63,7 @@ test.describe('Onboarding tests', () => {
     {
       tag: '@electron',
     },
-    async ({ page, tronApp, scene }) => {
+    async ({ page, tronApp }) => {
       if (!tronApp) {
         fail()
       }
@@ -72,6 +72,7 @@ test.describe('Onboarding tests', () => {
           onboarding_status: '',
         },
       })
+      const u = await getUtils(page)
 
       const viewportSize = { width: 1200, height: 500 }
       await page.setBodyDimensions(viewportSize)
@@ -79,7 +80,7 @@ test.describe('Onboarding tests', () => {
       await test.step(`Create a project and open to the onboarding`, async () => {
         await createProject({ name: 'project-link', page })
         await test.step(`Ensure the engine connection works by testing the sketch button`, async () => {
-          await scene.connectionEstablished()
+          await u.waitForPageLoad()
         })
       })
 
@@ -106,10 +107,12 @@ test.describe('Onboarding tests', () => {
   )
 
   test('Code resets after confirmation', async ({
+    context,
     page,
     homePage,
     tronApp,
     scene,
+    cmdBar,
   }) => {
     if (!tronApp) {
       fail()
@@ -273,8 +276,6 @@ test.describe('Onboarding tests', () => {
     page,
     homePage,
     tronApp,
-    editor,
-    toolbar,
   }) => {
     if (!tronApp) {
       fail()
@@ -288,6 +289,7 @@ test.describe('Onboarding tests', () => {
       },
     })
 
+    const u = await getUtils(page)
     const badCode = `// This is bad code we shouldn't see`
 
     await page.setBodyDimensions({ width: 1200, height: 1080 })
@@ -297,19 +299,18 @@ test.describe('Onboarding tests', () => {
       .poll(() => page.url())
       .toContain(onboardingPaths.PARAMETRIC_MODELING)
 
+    const bracketNoNewLines = bracket.replace(/\n/g, '')
+
     // Check the code got reset on load
-    await toolbar.openPane('code')
-    await editor.expectEditor.toContain(bracket, {
-      shouldNormalise: true,
+    await expect(page.locator('#code-pane')).toBeVisible()
+    await expect(u.codeLocator).toHaveText(bracketNoNewLines, {
       timeout: 10_000,
     })
 
     // Mess with the code again
-    await editor.replaceCode('', badCode)
-    await editor.expectEditor.toContain(badCode, {
-      shouldNormalise: true,
-      timeout: 10_000,
-    })
+    await u.codeLocator.selectText()
+    await u.codeLocator.fill(badCode)
+    await expect(u.codeLocator).toHaveText(badCode)
 
     // Click to the next step
     await page.locator('[data-testid="onboarding-next"]').hover()
@@ -319,10 +320,7 @@ test.describe('Onboarding tests', () => {
     })
 
     // Check that the code has been reset
-    await editor.expectEditor.toContain(bracket, {
-      shouldNormalise: true,
-      timeout: 10_000,
-    })
+    await expect(u.codeLocator).toHaveText(bracketNoNewLines)
   })
 
   // (lee) The two avatar tests are weird because even on main, we don't have
@@ -331,7 +329,6 @@ test.describe('Onboarding tests', () => {
   test('Avatar text updates depending on image load success', async ({
     context,
     page,
-    toolbar,
     homePage,
     tronApp,
   }) => {
@@ -363,7 +360,7 @@ test.describe('Onboarding tests', () => {
     await homePage.goToModelingScene()
 
     // Test that the text in this step is correct
-    const avatarLocator = toolbar.userSidebarButton.locator('img')
+    const avatarLocator = page.getByTestId('user-sidebar-toggle').locator('img')
     const onboardingOverlayLocator = page
       .getByTestId('onboarding-content')
       .locator('div')
@@ -405,7 +402,6 @@ test.describe('Onboarding tests', () => {
   test("Avatar text doesn't mention avatar when no avatar", async ({
     context,
     page,
-    toolbar,
     homePage,
     tronApp,
   }) => {
@@ -437,7 +433,7 @@ test.describe('Onboarding tests', () => {
     await homePage.goToModelingScene()
 
     // Test that the text in this step is correct
-    const sidebar = toolbar.userSidebarButton
+    const sidebar = page.getByTestId('user-sidebar-toggle')
     const avatar = sidebar.locator('img')
     const onboardingOverlayLocator = page
       .getByTestId('onboarding-content')
@@ -466,7 +462,6 @@ test.describe('Onboarding tests', () => {
 test('Restarting onboarding on desktop takes one attempt', async ({
   context,
   page,
-  toolbar,
   tronApp,
 }) => {
   test.fixme(orRunWhenFullSuiteEnabled())
@@ -505,7 +500,7 @@ test('Restarting onboarding on desktop takes one attempt', async ({
     .filter({ hasText: 'Tutorial Project 00' })
   const tutorialModalText = page.getByText('Welcome to Design Studio!')
   const tutorialDismissButton = page.getByRole('button', { name: 'Dismiss' })
-  const userMenuButton = toolbar.userSidebarButton
+  const userMenuButton = page.getByTestId('user-sidebar-toggle')
   const userMenuSettingsButton = page.getByRole('button', {
     name: 'User settings',
   })

e2e/playwright/point-click-assemblies.spec.ts

@@ -143,95 +143,8 @@ test.describe('Point-and-click assemblies tests', () => {
         await scene.settled(cmdBar)
       })
 
-      await test.step('Insert a second time with the same name and expect error', async () => {
-        await toolbar.insertButton.click()
-        await cmdBar.selectOption({ name: 'bracket.kcl' }).click()
-        await cmdBar.expectState({
-          stage: 'arguments',
-          currentArgKey: 'localName',
-          currentArgValue: '',
-          headerArguments: { Path: 'bracket.kcl', LocalName: '' },
-          highlightedHeaderArg: 'localName',
-          commandName: 'Insert',
-        })
-        await page.keyboard.insertText('bracket')
-        await cmdBar.progressCmdBar()
-        await expect(
-          page.getByText('This variable name is already in use')
-        ).toBeVisible()
-      })
-
-      await test.step('Insert a second time with a different name and expect error', async () => {
-        await page.keyboard.insertText('2')
-        await cmdBar.progressCmdBar()
-        await cmdBar.expectState({
-          stage: 'review',
-          headerArguments: { Path: 'bracket.kcl', LocalName: 'bracket2' },
-          commandName: 'Insert',
-        })
-        await cmdBar.progressCmdBar()
-        await editor.expectEditor.toContain(
-          `
-        import "cylinder.kcl" as cylinder
-        import "bracket.kcl" as bracket
-        import "bracket.kcl" as bracket2
-        cylinder
-        bracket
-        bracket2
-      `,
-          { shouldNormalise: true }
-        )
-        // TODO: update once we have clone() with #6209
-      })
-    }
-  )
-
-  test(
-    `Insert the bracket part into an assembly and transform it`,
-    { tag: ['@electron'] },
-    async ({
-      context,
-      page,
-      homePage,
-      scene,
-      editor,
-      toolbar,
-      cmdBar,
-      tronApp,
-    }) => {
-      if (!tronApp) {
-        fail()
-      }
-
-      const midPoint = { x: 500, y: 250 }
-      const moreToTheRightPoint = { x: 900, y: 250 }
-      const bgColor: [number, number, number] = [30, 30, 30]
-      const partColor: [number, number, number] = [100, 100, 100]
-      const tolerance = 30
-      const u = await getUtils(page)
-      const gizmo = page.locator('[aria-label*=gizmo]')
-      const resetCameraButton = page.getByRole('button', { name: 'Reset view' })
-
-      await test.step('Setup parts and expect empty assembly scene', async () => {
-        const projectName = 'assembly'
-        await context.folderSetupFn(async (dir) => {
-          const bracketDir = path.join(dir, projectName)
-          await fsp.mkdir(bracketDir, { recursive: true })
-          await Promise.all([
-            fsp.copyFile(
-              path.join('public', 'kcl-samples', 'bracket', 'main.kcl'),
-              path.join(bracketDir, 'bracket.kcl')
-            ),
-            fsp.writeFile(path.join(bracketDir, 'main.kcl'), ''),
-          ])
-        })
-        await page.setBodyDimensions({ width: 1000, height: 500 })
-        await homePage.openProject(projectName)
-        await scene.settled(cmdBar)
-        await toolbar.closePane('code')
-      })
-
-      await test.step('Insert kcl as module', async () => {
+      await test.step('Insert a second time and expect error', async () => {
+        // TODO: revisit once we have clone with #6209
         await insertPartIntoAssembly(
           'bracket.kcl',
           'bracket',
@@ -239,123 +152,19 @@ test.describe('Point-and-click assemblies tests', () => {
           cmdBar,
           page
         )
-        await toolbar.openPane('code')
         await editor.expectEditor.toContain(
           `
+        import "cylinder.kcl" as cylinder
         import "bracket.kcl" as bracket
+        import "bracket.kcl" as bracket
+        cylinder
+        bracket
         bracket
       `,
           { shouldNormalise: true }
         )
         await scene.settled(cmdBar)
-
-        // Check scene for changes
-        await toolbar.closePane('code')
-        await u.doAndWaitForCmd(async () => {
-          await gizmo.click({ button: 'right' })
-          await resetCameraButton.click()
-        }, 'zoom_to_fit')
-        await toolbar.closePane('debug')
-        await scene.expectPixelColor(partColor, midPoint, tolerance)
-        await scene.expectPixelColor(bgColor, moreToTheRightPoint, tolerance)
-      })
-
-      await test.step('Set translate on module', async () => {
-        await toolbar.openPane('feature-tree')
-
-        const op = await toolbar.getFeatureTreeOperation('bracket', 0)
-        await op.click({ button: 'right' })
-        await page.getByTestId('context-menu-set-translate').click()
-        await cmdBar.expectState({
-          stage: 'arguments',
-          currentArgKey: 'x',
-          currentArgValue: '0',
-          headerArguments: {
-            X: '',
-            Y: '',
-            Z: '',
-          },
-          highlightedHeaderArg: 'x',
-          commandName: 'Translate',
-        })
-        await page.keyboard.insertText('100')
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('0.1')
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('0.2')
-        await cmdBar.progressCmdBar()
-        await cmdBar.expectState({
-          stage: 'review',
-          headerArguments: {
-            X: '100',
-            Y: '0.1',
-            Z: '0.2',
-          },
-          commandName: 'Translate',
-        })
-        await cmdBar.progressCmdBar()
-        await toolbar.closePane('feature-tree')
-        await toolbar.openPane('code')
-        await editor.expectEditor.toContain(
-          `
-        bracket
-          |> translate(x = 100, y = 0.1, z = 0.2)
-        `,
-          { shouldNormalise: true }
-        )
-        // Expect translated part in the scene
-        await scene.expectPixelColor(bgColor, midPoint, tolerance)
-        await scene.expectPixelColor(partColor, moreToTheRightPoint, tolerance)
-      })
-
-      await test.step('Set rotate on module', async () => {
-        await toolbar.closePane('code')
-        await toolbar.openPane('feature-tree')
-
-        const op = await toolbar.getFeatureTreeOperation('bracket', 0)
-        await op.click({ button: 'right' })
-        await page.getByTestId('context-menu-set-rotate').click()
-        await cmdBar.expectState({
-          stage: 'arguments',
-          currentArgKey: 'roll',
-          currentArgValue: '0',
-          headerArguments: {
-            Roll: '',
-            Pitch: '',
-            Yaw: '',
-          },
-          highlightedHeaderArg: 'roll',
-          commandName: 'Rotate',
-        })
-        await page.keyboard.insertText('0.1')
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('0.2')
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('0.3')
-        await cmdBar.progressCmdBar()
-        await cmdBar.expectState({
-          stage: 'review',
-          headerArguments: {
-            Roll: '0.1',
-            Pitch: '0.2',
-            Yaw: '0.3',
-          },
-          commandName: 'Rotate',
-        })
-        await cmdBar.progressCmdBar()
-        await toolbar.closePane('feature-tree')
-        await toolbar.openPane('code')
-        await editor.expectEditor.toContain(
-          `
-        bracket
-          |> translate(x = 100, y = 0.1, z = 0.2)
-          |> rotate(roll = 0.1, pitch = 0.2, yaw = 0.3)
-        `,
-          { shouldNormalise: true }
-        )
-        // Expect no change in the scene as the rotations are tiny
-        await scene.expectPixelColor(bgColor, midPoint, tolerance)
-        await scene.expectPixelColor(partColor, moreToTheRightPoint, tolerance)
+        await expect(page.locator('.cm-lint-marker-error')).toBeVisible()
       })
     }
   )
@@ -422,6 +231,10 @@ test.describe('Point-and-click assemblies tests', () => {
         )
         await scene.settled(cmdBar)
 
+        // TODO: remove this once #5780 is fixed
+        await page.reload()
+
+        await scene.settled(cmdBar)
         await expect(page.locator('.cm-lint-marker-error')).not.toBeVisible()
         await toolbar.closePane('code')
         await scene.expectPixelColor(partColor, partPoint, tolerance)
@@ -466,6 +279,10 @@ test.describe('Point-and-click assemblies tests', () => {
         )
         await scene.settled(cmdBar)
 
+        // TODO: remove this once #5780 is fixed
+        await page.reload()
+        await scene.settled(cmdBar)
+
         await expect(page.locator('.cm-lint-marker-error')).not.toBeVisible()
         await toolbar.closePane('code')
         await scene.expectPixelColor(partColor, partPoint, tolerance)

e2e/playwright/point-click.spec.ts

@@ -5,10 +5,7 @@ import type { Locator, Page } from '@playwright/test'
 import type { EditorFixture } from '@e2e/playwright/fixtures/editorFixture'
 import type { SceneFixture } from '@e2e/playwright/fixtures/sceneFixture'
 import type { ToolbarFixture } from '@e2e/playwright/fixtures/toolbarFixture'
-import {
-  orRunWhenFullSuiteEnabled,
-  runningOnWindows,
-} from '@e2e/playwright/test-utils'
+import { orRunWhenFullSuiteEnabled } from '@e2e/playwright/test-utils'
 import { expect, test } from '@e2e/playwright/zoo-test'
 
 // test file is for testing point an click code gen functionality that's not sketch mode related
@@ -1049,7 +1046,7 @@ openSketch = startSketchOn(XY)
   }) => {
     // One dumb hardcoded screen pixel value
     const testPoint = { x: 620, y: 257 }
-    const expectedOutput = `helix001 = helix(  axis = X,  radius = 5,  length = 5,  revolutions = 1,  angleStart = 270,  ccw = false,)`
+    const expectedOutput = `helix001 = helix(  axis = X,  radius = 5,  length = 5,  revolutions = 1,  angleStart = 360,  ccw = false,)`
     const expectedLine = `axis=X,`
 
     await homePage.goToModelingScene()
@@ -1075,23 +1072,6 @@ openSketch = startSketchOn(XY)
       await expect.poll(() => page.getByText('Axis').count()).toBe(6)
       await cmdBar.progressCmdBar()
       await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'angleStart',
-        highlightedHeaderArg: 'angleStart',
-        currentArgValue: '360',
-        headerArguments: {
-          Mode: 'Axis',
-          Axis: 'X',
-          Revolutions: '1',
-          AngleStart: '',
-          Length: '',
-          Radius: '',
-          CounterClockWise: '',
-        },
-        commandName: 'Helix',
-      })
-      await cmdBar.currentArgumentInput.locator('.cm-content').fill('270')
       await cmdBar.progressCmdBar()
       await cmdBar.progressCmdBar()
       await cmdBar.progressCmdBar()
@@ -1100,7 +1080,7 @@ openSketch = startSketchOn(XY)
         headerArguments: {
           Mode: 'Axis',
           Axis: 'X',
-          AngleStart: '270',
+          AngleStart: '360',
           Revolutions: '1',
           Length: '5',
           Radius: '5',
@@ -1135,7 +1115,7 @@ openSketch = startSketchOn(XY)
         currentArgValue: '',
         headerArguments: {
           Axis: 'X',
-          AngleStart: '270',
+          AngleStart: '360',
           Revolutions: '1',
           Radius: '5',
           Length: initialInput,
@@ -1151,7 +1131,7 @@ openSketch = startSketchOn(XY)
         stage: 'review',
         headerArguments: {
           Axis: 'X',
-          AngleStart: '270',
+          AngleStart: '360',
           Revolutions: '1',
           Radius: '5',
           Length: newInput,
@@ -3547,9 +3527,6 @@ tag=$rectangleSegmentC002,
       toolbar,
       cmdBar,
     }) => {
-      if (runningOnWindows()) {
-        test.fixme(orRunWhenFullSuiteEnabled())
-      }
       const initialCode = `sketch001 = startSketchOn(XZ)
   |> startProfileAt([-102.57, 101.72], %)
   |> angledLine(angle = 0, length = 202.6, tag = $rectangleSegmentA001)
@@ -3841,469 +3818,4 @@ extrude001 = extrude(profile001, length = 100)
       )
     })
   })
-
-  const translateExtrudeCases: { variables: boolean }[] = [
-    {
-      variables: false,
-    },
-    {
-      variables: true,
-    },
-  ]
-  translateExtrudeCases.map(({ variables }) => {
-    test(`Set translate on extrude through right-click menu (variables: ${variables})`, async ({
-      context,
-      page,
-      homePage,
-      scene,
-      editor,
-      toolbar,
-      cmdBar,
-    }) => {
-      const initialCode = `sketch001 = startSketchOn(XZ)
-    profile001 = circle(sketch001, center = [0, 0], radius = 1)
-    extrude001 = extrude(profile001, length = 1)
-    `
-      await context.addInitScript((initialCode) => {
-        localStorage.setItem('persistCode', initialCode)
-      }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
-      await homePage.goToModelingScene()
-      await scene.settled(cmdBar)
-
-      // One dumb hardcoded screen pixel value
-      const midPoint = { x: 500, y: 250 }
-      const moreToTheRightPoint = { x: 800, y: 250 }
-      const bgColor: [number, number, number] = [50, 50, 50]
-      const partColor: [number, number, number] = [150, 150, 150]
-      const tolerance = 50
-
-      await test.step('Confirm extrude exists with default appearance', async () => {
-        await toolbar.closePane('code')
-        await scene.expectPixelColor(partColor, midPoint, tolerance)
-        await scene.expectPixelColor(bgColor, moreToTheRightPoint, tolerance)
-      })
-
-      await test.step('Set translate through command bar flow', async () => {
-        await toolbar.openPane('feature-tree')
-        const op = await toolbar.getFeatureTreeOperation('Extrude', 0)
-        await op.click({ button: 'right' })
-        await page.getByTestId('context-menu-set-translate').click()
-        await cmdBar.expectState({
-          stage: 'arguments',
-          currentArgKey: 'x',
-          currentArgValue: '0',
-          headerArguments: {
-            X: '',
-            Y: '',
-            Z: '',
-          },
-          highlightedHeaderArg: 'x',
-          commandName: 'Translate',
-        })
-        await page.keyboard.insertText('3')
-        if (variables) {
-          await cmdBar.createNewVariable()
-        }
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('0.1')
-        if (variables) {
-          await cmdBar.createNewVariable()
-        }
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('0.2')
-        if (variables) {
-          await cmdBar.createNewVariable()
-        }
-        await cmdBar.progressCmdBar()
-        await cmdBar.expectState({
-          stage: 'review',
-          headerArguments: {
-            X: '3',
-            Y: '0.1',
-            Z: '0.2',
-          },
-          commandName: 'Translate',
-        })
-        await cmdBar.progressCmdBar()
-        await toolbar.closePane('feature-tree')
-      })
-
-      await test.step('Confirm code and scene have changed', async () => {
-        await toolbar.openPane('code')
-        if (variables) {
-          await editor.expectEditor.toContain(
-            `
-            z001 = 0.2
-            y001 = 0.1
-            x001 = 3
-            sketch001 = startSketchOn(XZ)
-            profile001 = circle(sketch001, center = [0, 0], radius = 1)
-            extrude001 = extrude(profile001, length = 1)
-              |> translate(x = x001, y = y001, z = z001)
-          `,
-            { shouldNormalise: true }
-          )
-        } else {
-          await editor.expectEditor.toContain(
-            `
-            sketch001 = startSketchOn(XZ)
-            profile001 = circle(sketch001, center = [0, 0], radius = 1)
-            extrude001 = extrude(profile001, length = 1)
-              |> translate(x = 3, y = 0.1, z = 0.2)
-          `,
-            { shouldNormalise: true }
-          )
-        }
-        await scene.expectPixelColor(bgColor, midPoint, tolerance)
-        await scene.expectPixelColor(partColor, moreToTheRightPoint, tolerance)
-      })
-
-      await test.step('Edit translate', async () => {
-        await toolbar.openPane('feature-tree')
-        const op = await toolbar.getFeatureTreeOperation('Extrude', 0)
-        await op.click({ button: 'right' })
-        await page.getByTestId('context-menu-set-translate').click()
-        await cmdBar.expectState({
-          stage: 'arguments',
-          currentArgKey: 'z',
-          currentArgValue: variables ? 'z001' : '0.2',
-          headerArguments: {
-            X: '3',
-            Y: '0.1',
-            Z: '0.2',
-          },
-          highlightedHeaderArg: 'z',
-          commandName: 'Translate',
-        })
-        await page.keyboard.insertText('0.3')
-        await cmdBar.progressCmdBar()
-        await cmdBar.expectState({
-          stage: 'review',
-          headerArguments: {
-            X: '3',
-            Y: '0.1',
-            Z: '0.3',
-          },
-          commandName: 'Translate',
-        })
-        await cmdBar.progressCmdBar()
-        await toolbar.closePane('feature-tree')
-        await toolbar.openPane('code')
-        await editor.expectEditor.toContain(`z = 0.3`)
-        // Expect almost no change in scene
-        await scene.expectPixelColor(bgColor, midPoint, tolerance)
-        await scene.expectPixelColor(partColor, moreToTheRightPoint, tolerance)
-      })
-    })
-  })
-
-  const rotateExtrudeCases: { variables: boolean }[] = [
-    {
-      variables: false,
-    },
-    {
-      variables: true,
-    },
-  ]
-  rotateExtrudeCases.map(({ variables }) => {
-    test(`Set rotate on extrude through right-click menu (variables: ${variables})`, async ({
-      context,
-      page,
-      homePage,
-      scene,
-      editor,
-      toolbar,
-      cmdBar,
-    }) => {
-      const initialCode = `sketch001 = startSketchOn(XZ)
-    profile001 = circle(sketch001, center = [0, 0], radius = 1)
-    extrude001 = extrude(profile001, length = 1)
-    `
-      await context.addInitScript((initialCode) => {
-        localStorage.setItem('persistCode', initialCode)
-      }, initialCode)
-      await page.setBodyDimensions({ width: 1000, height: 500 })
-      await homePage.goToModelingScene()
-      await scene.settled(cmdBar)
-
-      await test.step('Set rotate through command bar flow', async () => {
-        await toolbar.openPane('feature-tree')
-        const op = await toolbar.getFeatureTreeOperation('Extrude', 0)
-        await op.click({ button: 'right' })
-        await page.getByTestId('context-menu-set-rotate').click()
-        await cmdBar.expectState({
-          stage: 'arguments',
-          currentArgKey: 'roll',
-          currentArgValue: '0',
-          headerArguments: {
-            Roll: '',
-            Pitch: '',
-            Yaw: '',
-          },
-          highlightedHeaderArg: 'roll',
-          commandName: 'Rotate',
-        })
-        await page.keyboard.insertText('1.1')
-        if (variables) {
-          await cmdBar.createNewVariable()
-        }
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('1.2')
-        if (variables) {
-          await cmdBar.createNewVariable()
-        }
-        await cmdBar.progressCmdBar()
-        await page.keyboard.insertText('1.3')
-        if (variables) {
-          await cmdBar.createNewVariable()
-        }
-        await cmdBar.progressCmdBar()
-        await cmdBar.expectState({
-          stage: 'review',
-          headerArguments: {
-            Roll: '1.1',
-            Pitch: '1.2',
-            Yaw: '1.3',
-          },
-          commandName: 'Rotate',
-        })
-        await cmdBar.progressCmdBar()
-        await toolbar.closePane('feature-tree')
-      })
-
-      await test.step('Confirm code and scene have changed', async () => {
-        await toolbar.openPane('code')
-        if (variables) {
-          await editor.expectEditor.toContain(
-            `
-            yaw001 = 1.3
-            pitch001 = 1.2
-            roll001 = 1.1
-            sketch001 = startSketchOn(XZ)
-            profile001 = circle(sketch001, center = [0, 0], radius = 1)
-            extrude001 = extrude(profile001, length = 1)
-              |> rotate(roll = roll001, pitch = pitch001, yaw = yaw001)
-          `,
-            { shouldNormalise: true }
-          )
-        } else {
-          await editor.expectEditor.toContain(
-            `
-            sketch001 = startSketchOn(XZ)
-            profile001 = circle(sketch001, center = [0, 0], radius = 1)
-            extrude001 = extrude(profile001, length = 1)
-              |> rotate(roll = 1.1, pitch = 1.2, yaw = 1.3)
-          `,
-            { shouldNormalise: true }
-          )
-        }
-      })
-
-      await test.step('Edit rotate', async () => {
-        await toolbar.openPane('feature-tree')
-        const op = await toolbar.getFeatureTreeOperation('Extrude', 0)
-        await op.click({ button: 'right' })
-        await page.getByTestId('context-menu-set-rotate').click()
-        await cmdBar.expectState({
-          stage: 'arguments',
-          currentArgKey: 'yaw',
-          currentArgValue: variables ? 'yaw001' : '1.3',
-          headerArguments: {
-            Roll: '1.1',
-            Pitch: '1.2',
-            Yaw: '1.3',
-          },
-          highlightedHeaderArg: 'yaw',
-          commandName: 'Rotate',
-        })
-        await page.keyboard.insertText('13')
-        await cmdBar.progressCmdBar()
-        await cmdBar.expectState({
-          stage: 'review',
-          headerArguments: {
-            Roll: '1.1',
-            Pitch: '1.2',
-            Yaw: '13',
-          },
-          commandName: 'Rotate',
-        })
-        await cmdBar.progressCmdBar()
-        await toolbar.closePane('feature-tree')
-        await toolbar.openPane('code')
-        await editor.expectEditor.toContain(`yaw = 13`)
-      })
-    })
-  })
-
-  test(`Set translate and rotate on extrude through selection`, async ({
-    context,
-    page,
-    homePage,
-    scene,
-    editor,
-    toolbar,
-    cmdBar,
-  }) => {
-    const initialCode = `sketch001 = startSketchOn(XZ)
-profile001 = circle(sketch001, center = [0, 0], radius = 1)
-extrude001 = extrude(profile001, length = 1)
-  `
-    await context.addInitScript((initialCode) => {
-      localStorage.setItem('persistCode', initialCode)
-    }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
-    await homePage.goToModelingScene()
-    await scene.settled(cmdBar)
-
-    // One dumb hardcoded screen pixel value
-    const midPoint = { x: 500, y: 250 }
-    const moreToTheRightPoint = { x: 800, y: 250 }
-    const bgColor: [number, number, number] = [50, 50, 50]
-    const partColor: [number, number, number] = [150, 150, 150]
-    const tolerance = 50
-    const [clickMidPoint] = scene.makeMouseHelpers(midPoint.x, midPoint.y)
-    const [clickMoreToTheRightPoint] = scene.makeMouseHelpers(
-      moreToTheRightPoint.x,
-      moreToTheRightPoint.y
-    )
-
-    await test.step('Confirm extrude exists with default appearance', async () => {
-      await toolbar.closePane('code')
-      await scene.expectPixelColor(partColor, midPoint, tolerance)
-      await scene.expectPixelColor(bgColor, moreToTheRightPoint, tolerance)
-    })
-
-    await test.step('Set translate through command bar flow', async () => {
-      await cmdBar.openCmdBar()
-      await cmdBar.chooseCommand('Translate')
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'selection',
-        currentArgValue: '',
-        headerArguments: {
-          Selection: '',
-          X: '',
-          Y: '',
-          Z: '',
-        },
-        highlightedHeaderArg: 'selection',
-        commandName: 'Translate',
-      })
-      await clickMidPoint()
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'x',
-        currentArgValue: '0',
-        headerArguments: {
-          Selection: '1 path',
-          X: '',
-          Y: '',
-          Z: '',
-        },
-        highlightedHeaderArg: 'x',
-        commandName: 'Translate',
-      })
-      await page.keyboard.insertText('2')
-      await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Selection: '1 path',
-          X: '2',
-          Y: '0',
-          Z: '0',
-        },
-        commandName: 'Translate',
-      })
-      await cmdBar.progressCmdBar()
-    })
-
-    await test.step('Confirm code and scene have changed', async () => {
-      await toolbar.openPane('code')
-      await editor.expectEditor.toContain(
-        `
-        sketch001 = startSketchOn(XZ)
-        profile001 = circle(sketch001, center = [0, 0], radius = 1)
-        extrude001 = extrude(profile001, length = 1)
-          |> translate(x = 2, y = 0, z = 0)
-          `,
-        { shouldNormalise: true }
-      )
-      await scene.expectPixelColor(bgColor, midPoint, tolerance)
-      await scene.expectPixelColor(partColor, moreToTheRightPoint, tolerance)
-    })
-
-    await test.step('Set rotate through command bar flow', async () => {
-      // clear selection
-      await clickMidPoint()
-      await cmdBar.openCmdBar()
-      await cmdBar.chooseCommand('Rotate')
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'selection',
-        currentArgValue: '',
-        headerArguments: {
-          Selection: '',
-          Roll: '',
-          Pitch: '',
-          Yaw: '',
-        },
-        highlightedHeaderArg: 'selection',
-        commandName: 'Rotate',
-      })
-      await clickMoreToTheRightPoint()
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'roll',
-        currentArgValue: '0',
-        headerArguments: {
-          Selection: '1 path',
-          Roll: '',
-          Pitch: '',
-          Yaw: '',
-        },
-        highlightedHeaderArg: 'roll',
-        commandName: 'Rotate',
-      })
-      await page.keyboard.insertText('0.1')
-      await cmdBar.progressCmdBar()
-      await page.keyboard.insertText('0.2')
-      await cmdBar.progressCmdBar()
-      await page.keyboard.insertText('0.3')
-      await cmdBar.progressCmdBar()
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Selection: '1 path',
-          Roll: '0.1',
-          Pitch: '0.2',
-          Yaw: '0.3',
-        },
-        commandName: 'Rotate',
-      })
-      await cmdBar.progressCmdBar()
-    })
-
-    await test.step('Confirm code has changed', async () => {
-      await toolbar.openPane('code')
-      await editor.expectEditor.toContain(
-        `
-        sketch001 = startSketchOn(XZ)
-        profile001 = circle(sketch001, center = [0, 0], radius = 1)
-        extrude001 = extrude(profile001, length = 1)
-          |> translate(x = 2, y = 0, z = 0)
-          |> rotate(roll = 0.1, pitch = 0.2, yaw = 0.3)
-          `,
-        { shouldNormalise: true }
-      )
-      // No change here since the angles are super small
-      await scene.expectPixelColor(bgColor, midPoint, tolerance)
-      await scene.expectPixelColor(partColor, moreToTheRightPoint, tolerance)
-    })
-  })
 })

e2e/playwright/projects.spec.ts

@@ -400,6 +400,11 @@ test(
     await expect(page.getByText('broken-code')).toBeVisible()
     await page.getByText('broken-code').click()
 
+    // Gotcha: You can not use scene.settled() since the KCL code is going to fail
+    await expect(
+      page.getByTestId('model-state-indicator-playing')
+    ).toBeAttached()
+
     // Gotcha: Scroll to the text content in code mirror because CodeMirror lazy loads DOM content
     await editor.scrollToText(
       "|> line(end = [0, wallMountL], tag = 'outerEdge')"
@@ -774,9 +779,7 @@ test.describe(`Project management commands`, () => {
       // Constants and locators
       const projectHomeLink = page.getByTestId('project-link')
       const commandButton = page.getByRole('button', { name: 'Commands' })
-      const commandOption = page.getByRole('option', {
-        name: 'rename project',
-      })
+      const commandOption = page.getByRole('option', { name: 'rename project' })
       const projectNameOption = page.getByRole('option', { name: projectName })
       const projectRenamedName = `untitled`
       // const projectMenuButton = page.getByTestId('project-sidebar-toggle')
@@ -836,9 +839,7 @@ test.describe(`Project management commands`, () => {
       // Constants and locators
       const projectHomeLink = page.getByTestId('project-link')
       const commandButton = page.getByRole('button', { name: 'Commands' })
-      const commandOption = page.getByRole('option', {
-        name: 'delete project',
-      })
+      const commandOption = page.getByRole('option', { name: 'delete project' })
       const projectNameOption = page.getByRole('option', { name: projectName })
       const commandWarning = page.getByText('Are you sure you want to delete?')
       const commandSubmitButton = page.getByRole('button', {
@@ -890,9 +891,7 @@ test.describe(`Project management commands`, () => {
       // Constants and locators
       const projectHomeLink = page.getByTestId('project-link')
       const commandButton = page.getByRole('button', { name: 'Commands' })
-      const commandOption = page.getByRole('option', {
-        name: 'rename project',
-      })
+      const commandOption = page.getByRole('option', { name: 'rename project' })
       const projectNameOption = page.getByRole('option', { name: projectName })
       const projectRenamedName = `untitled`
       const commandContinueButton = page.getByRole('button', {
@@ -948,9 +947,7 @@ test.describe(`Project management commands`, () => {
       // Constants and locators
       const projectHomeLink = page.getByTestId('project-link')
       const commandButton = page.getByRole('button', { name: 'Commands' })
-      const commandOption = page.getByRole('option', {
-        name: 'delete project',
-      })
+      const commandOption = page.getByRole('option', { name: 'delete project' })
       const projectNameOption = page.getByRole('option', { name: projectName })
       const commandWarning = page.getByText('Are you sure you want to delete?')
       const commandSubmitButton = page.getByRole('button', {
@@ -1965,13 +1962,13 @@ test(
 test(
   'Settings persist across restarts',
   { tag: '@electron' },
-  async ({ page, toolbar }, testInfo) => {
+  async ({ page, scene, cmdBar }, testInfo) => {
     await test.step('We can change a user setting like theme', async () => {
       await page.setBodyDimensions({ width: 1200, height: 500 })
 
       page.on('console', console.log)
 
-      await toolbar.userSidebarButton.click()
+      await page.getByTestId('user-sidebar-toggle').click()
 
       await page.getByTestId('user-settings').click()
 
@@ -1998,7 +1995,7 @@ test(
 test(
   'Original project name persist after onboarding',
   { tag: '@electron' },
-  async ({ page, toolbar }, testInfo) => {
+  async ({ page }, testInfo) => {
     test.fixme(orRunWhenFullSuiteEnabled())
     await page.setBodyDimensions({ width: 1200, height: 500 })
 
@@ -2010,7 +2007,7 @@ test(
     })
 
     await test.step('Should go through onboarding', async () => {
-      await toolbar.userSidebarButton.click()
+      await page.getByTestId('user-sidebar-toggle').click()
       await page.getByTestId('user-settings').click()
       await page.getByRole('button', { name: 'Replay Onboarding' }).click()
 

e2e/playwright/prompt-to-edit-snapshot-tests.spec.ts

@@ -1,5 +1,4 @@
 import { expect, test } from '@e2e/playwright/zoo-test'
-import { orRunWhenFullSuiteEnabled } from '@e2e/playwright/test-utils'
 
 /* eslint-disable jest/no-conditional-expect */
 
@@ -58,7 +57,6 @@ test.describe('edit with AI example snapshots', () => {
     `change colour`,
     { tag: '@snapshot' },
     async ({ context, homePage, cmdBar, editor, page, scene }) => {
-      test.fixme(orRunWhenFullSuiteEnabled())
       await context.addInitScript((file) => {
         localStorage.setItem('persistCode', file)
       }, file)

e2e/playwright/prompt-to-edit.spec.ts

@@ -1,3 +1,4 @@
+import { orRunWhenFullSuiteEnabled } from '@e2e/playwright/test-utils'
 import { expect, test } from '@e2e/playwright/zoo-test'
 
 /* eslint-disable jest/no-conditional-expect */
@@ -50,6 +51,7 @@ test.describe('Prompt-to-edit tests', { tag: '@skipWin' }, () => {
         page,
         scene,
       }) => {
+        test.fixme(orRunWhenFullSuiteEnabled())
         await context.addInitScript((file) => {
           localStorage.setItem('persistCode', file)
         }, file)
@@ -198,6 +200,7 @@ test.describe('Prompt-to-edit tests', { tag: '@skipWin' }, () => {
     page,
     scene,
   }) => {
+    test.fixme(orRunWhenFullSuiteEnabled())
     const body1CapCoords = { x: 571, y: 311 }
 
     await context.addInitScript((file) => {
@@ -257,6 +260,7 @@ test.describe('Prompt-to-edit tests', { tag: '@skipWin' }, () => {
     page,
     scene,
   }) => {
+    test.fixme(orRunWhenFullSuiteEnabled())
     const body1CapCoords = { x: 571, y: 311 }
     const body2WallCoords = { x: 620, y: 152 }
     const [clickBody1Cap] = scene.makeMouseHelpers(

e2e/playwright/sketch-tests.spec.ts

@@ -45,7 +45,11 @@ test.describe('Sketch tests', { tag: ['@skipWin'] }, () => {
 
     screwHole = startSketchOn(XY)
   ${startProfileAt1}
-  |> arc(angleStart = 0, angleEnd = 360, radius = screwRadius)
+  |> arc({
+        radius = screwRadius,
+        angleStart = 0,
+        angleEnd = 360
+      }, %)
 
     part001 = startSketchOn(XY)
   ${startProfileAt2}
@@ -62,7 +66,11 @@ test.describe('Sketch tests', { tag: ['@skipWin'] }, () => {
   |> tangentialArc(endAbsolute = [width / 2, 0])
   |> xLine(length = -width / 4 + wireRadius)
   |> yLine(length = wireOffset)
-  |> arc(angleStart = 0, angleEnd = 180, radius = wireRadius)
+  |> arc({
+        radius = wireRadius,
+        angleStart = 0,
+        angleEnd = 180
+      }, %)
   |> yLine(length = -wireOffset)
   |> xLine(length = -width / 4)
   |> close()
@@ -206,8 +214,15 @@ sketch001 = startProfileAt([12.34, -12.34], sketch002)
       |> startProfileAt([4.61, -14.01], %)
       |> line(end = [12.73, -0.09])
       |> tangentialArc(endAbsolute = [24.95, -5.38])
-      |> arc(interiorAbsolute = [20.18, -1.7], endAbsolute = [11.82, -1.16])
-      |> arc(angleStart = -89.36, angleEnd = 135.81, radius = 5.92)
+      |> arcTo({
+          interior = [20.18, -1.7],
+          end = [11.82, -1.16]
+        }, %)
+      |> arc({
+          radius = 5.92,
+          angleStart = -89.36,
+          angleEnd = 135.81
+        }, %)
       |> close()`
         )
       })
@@ -249,8 +264,15 @@ sketch001 = startProfileAt([12.34, -12.34], sketch002)
       |> startProfileAt([4.61, -14.01], %)
       |> line(end = [12.73, -0.09])
       |> tangentialArc(endAbsolute = [24.95, -5.38])
-      |> arc(interiorAbsolute = [20.18, -1.7], endAbsolute = [11.82, -1.16])
-      |> arc(angleStart = -89.36, angleEnd = 135.81, radius = 5.92)
+      |> arcTo({
+          interior = [20.18, -1.7],
+          end = [11.82, -1.16]
+        }, %)
+      |> arc({
+          radius = 5.92,
+          angleStart = -89.36,
+          angleEnd = 135.81
+        }, %)
       |> close()
 `)
       } else {
@@ -316,7 +338,7 @@ sketch001 = startProfileAt([12.34, -12.34], sketch002)
         await expect(page.locator('.cm-content')).not.toHaveText(prevContent)
       }
 
-      // drag arcTo interiorAbsolute handle (three point arc)
+      // drag arcTo interior handle (three point arc)
       const arcToHandle = await u.getBoundingBox('[data-overlay-index="2"]')
       await page.mouse.move(arcToHandle.x, arcToHandle.y - 5)
       await page.mouse.down()
@@ -388,8 +410,15 @@ sketch001 = startProfileAt([12.34, -12.34], sketch002)
   |> startProfileAt([6.44, -12.07], %)
   |> line(end = [14.72, 1.97])
   |> tangentialArc(endAbsolute = [26.92, -3.32])
-  |> arc(interiorAbsolute = [18.11, -3.73], endAbsolute = [9.77, -3.19])
-  |> arc(angleStart = -58.29, angleEnd = 161.17, radius = 3.75)
+  |> arcTo({
+       interior = [18.11, -3.73],
+       end = [9.77, -3.19]
+     }, %)
+  |> arc({
+       radius = 3.75,
+       angleStart = -58.29,
+       angleEnd = 161.17
+     }, %)
   |> close()
 `)
     }
@@ -919,9 +948,7 @@ profile001 = startProfileAt([${roundOff(scale * 69.6)}, ${roundOff(
 
       await page.mouse.move(pointA[0] - 12, pointA[1] + 12, { steps: 10 })
       const pointNotQuiteA = [pointA[0] - 7, pointA[1] + 7]
-      await page.mouse.move(pointNotQuiteA[0], pointNotQuiteA[1], {
-        steps: 10,
-      })
+      await page.mouse.move(pointNotQuiteA[0], pointNotQuiteA[1], { steps: 10 })
 
       await page.mouse.click(pointNotQuiteA[0], pointNotQuiteA[1], {
         delay: 200,
@@ -1473,12 +1500,12 @@ profile002 = startProfileAt([117.2, 56.08], sketch001)
         await circle3Point1()
         await page.waitForTimeout(200)
         await circle3Point2()
-        await editor.expectEditor.toContain('arc(')
+        await editor.expectEditor.toContain('arcTo({')
       })
 
       await test.step('equip line tool and verify three-point-arc code is removed after second click', async () => {
         await toolbar.lineBtn.click()
-        await editor.expectEditor.not.toContain('arc(')
+        await editor.expectEditor.not.toContain('arcTo({')
       })
 
       const [cornerRectPoint1] = scene.makeMouseHelpers(600, 300)
@@ -1515,9 +1542,9 @@ profile002 = startProfileAt([117.2, 56.08], sketch001)
         await continueProfile2Clk()
         await page.waitForTimeout(200)
         await circle3Point1()
-        await editor.expectEditor.toContain('arc(')
+        await editor.expectEditor.toContain('arcTo({')
         await toolbar.lineBtn.click()
-        await editor.expectEditor.not.toContain('arc(')
+        await editor.expectEditor.not.toContain('arcTo({')
         await editor.expectEditor.toContain('profile002')
       })
     }
@@ -1814,9 +1841,7 @@ profile003 = startProfileAt([206.63, -56.73], sketch001)
       await page.waitForTimeout(300)
 
       // Verify the three-point arc was created correctly
-      await editor.expectEditor.toContain(`arc(`)
-      await editor.expectEditor.toContain(`interiorAbsolute`)
-      await editor.expectEditor.toContain(`endAbsolute`)
+      await editor.expectEditor.toContain(`|> arcTo(`)
 
       // Switch back to line tool to continue
       await toolbar.lineBtn.click()
@@ -2036,7 +2061,10 @@ profile003 = startProfileAt([206.63, -56.73], sketch001)
       // Verify the first three-point arc was created correctly
       await editor.expectEditor.toContain(
         `profile011 = startProfileAt([13.56, -9.97], sketch001)
-  |> arc(interiorAbsolute = [15.19, -6.51], endAbsolute = [19.33, -11.19])`,
+  |> arcTo({
+       interior = [15.19, -6.51],
+       end = [19.33, -11.19]
+     }, %)`,
         { shouldNormalise: true }
       )
 
@@ -2053,8 +2081,14 @@ profile003 = startProfileAt([206.63, -56.73], sketch001)
 
       // Verify the second three-point arc was created correctly
       await editor.expectEditor.toContain(
-        `  |> arc(interiorAbsolute = [19.8, 1.7], endAbsolute = [21.7, 2.92])
-  |> arc(interiorAbsolute = [27.47, 1.42], endAbsolute = [27.57, 1.52])`,
+        `  |> arcTo({
+       interior = [19.8, 1.7],
+       end = [21.7, 2.92]
+     }, %)
+  |> arcTo({
+       interior = [27.47, 1.42],
+       end = [27.57, 1.52]
+     }, %)`,
         { shouldNormalise: true }
       )
     })
@@ -2829,29 +2863,33 @@ test.describe(`Click based selection don't brick the app when clicked out of ran
         `sketch001 = startSketchOn(XZ)
   |> startProfileAt([0, 0], %)
   |> line(end = [3.14, 3.14])
-  |> arc(
-       interiorAbsolute = [1, 2],
-       endAbsolute = [4, 2]
-     )`
+  |> arcTo({
+  end = [4, 2],
+  interior = [1, 2]
+  }, %)
+`
       )
     })
 
     await homePage.goToModelingScene()
     await scene.settled(cmdBar)
 
-    const formattedArc = `arc(interiorAbsolute = [1, 2], endAbsolute = [4, 2])`
     await test.step(`format the code`, async () => {
       // doesn't contain condensed version
-      await editor.expectEditor.not.toContain(formattedArc)
+      await editor.expectEditor.not.toContain(
+        `arcTo({ end = [4, 2], interior = [1, 2] }, %)`
+      )
       // click the code to enter sketch mode
-      await page.getByText(`arc`).click()
+      await page.getByText(`arcTo`).click()
       // Format the code.
       await page.locator('#code-pane button:first-child').click()
       await page.locator('button:has-text("Format code")').click()
     })
 
     await test.step(`Ensure the code reformatted`, async () => {
-      await editor.expectEditor.toContain(formattedArc)
+      await editor.expectEditor.toContain(
+        `arcTo({ end = [4, 2], interior = [1, 2] }, %)`
+      )
     })
 
     const [arcClick, arcHover] = scene.makeMouseHelpers(699, 337)
@@ -2862,7 +2900,7 @@ test.describe(`Click based selection don't brick the app when clicked out of ran
       await editor.expectState({
         activeLines: ['sketch001=startSketchOn(XZ)'],
         diagnostics: [],
-        highlightedCode: 'arc(interiorAbsolute = [1, 2], endAbsolute = [4, 2])',
+        highlightedCode: 'arcTo({end = [4, 2], interior = [1, 2]}, %)',
       })
     })
 
@@ -2884,7 +2922,7 @@ test.describe(`Click based selection don't brick the app when clicked out of ran
       await editor.expectState({
         activeLines: [],
         diagnostics: [],
-        highlightedCode: 'arc(interiorAbsolute = [1, 2], endAbsolute = [4, 2])',
+        highlightedCode: 'arcTo({end = [4, 2], interior = [1, 2]}, %)',
       })
     })
   })
@@ -2998,7 +3036,10 @@ profile001 = startProfileAt([0, 0], sketch001)
   |> line(end = [191.39, 191.39])
   |> tangentialArc(endAbsolute = [287.08, 95.69], tag = $seg01)
   |> angledLine(angle = tangentToEnd(seg01), length = 135.34)
-  |> arc(interiorAbsolute = [191.39, -95.69], endAbsolute = [287.08, -95.69], tag = $seg02)
+  |> arcTo({
+       interior = [191.39, -95.69],
+       end = [287.08, -95.69]
+     }, %, $seg02)
   |> angledLine(angle = tangentToEnd(seg02) + turns::HALF_TURN, length = 270.67)
 `.replaceAll('\n', '')
     )
@@ -3017,7 +3058,7 @@ test.describe('manual edits during sketch mode', () => {
   }) => {
     const initialCode = `myVar1 = 5
     myVar2 = 6
-
+    
     sketch001 = startSketchOn(XZ)
     profile001 = startProfileAt([106.68, 89.77], sketch001)
       |> line(end = [132.34, 157.8])
@@ -3028,8 +3069,10 @@ test.describe('manual edits during sketch mode', () => {
     sketch002 = startSketchOn(extrude001, face = seg01)
     profile002 = startProfileAt([83.39, 329.15], sketch002)
       |> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
-      |> angledLine(length = 156.54, angle = -28)
+      |> angledLine(angle = segAng(rectangleSegmentA001) - 90, length = 156.54, angle = -28)
       |> angledLine(
+          angle = segAng(rectangleSegmentA001),
+          length = -segLen(rectangleSegmentA001),
           angle = -151,
           length = 116.27,
         )
@@ -3046,43 +3089,38 @@ test.describe('manual edits during sketch mode', () => {
     await homePage.goToModelingScene()
     await scene.connectionEstablished()
     await scene.settled(cmdBar)
+    const expectSketchOriginToBeDrawn = async () => {
+      await scene.expectPixelColor(TEST_COLORS.WHITE, { x: 672, y: 193 }, 15)
+    }
 
     await test.step('Open feature tree and edit second sketch', async () => {
       await toolbar.openFeatureTreePane()
       const sketchButton = await toolbar.getFeatureTreeOperation('Sketch', 1)
       await sketchButton.dblclick()
       await page.waitForTimeout(700) // Wait for engine animation
+      await expectSketchOriginToBeDrawn()
     })
 
     await test.step('Add new variable and wait for re-execution', async () => {
       await page.waitForTimeout(500) // wait for deferred execution
       await editor.replaceCode('myVar2 = 6', 'myVar2 = 6\nmyVar3 = 7')
       await page.waitForTimeout(2000) // wait for deferred execution
+      await expectSketchOriginToBeDrawn()
     })
 
     const handle1Location = { x: 843, y: 235 }
+
     await test.step('Edit sketch by dragging handle', async () => {
       await page.waitForTimeout(500)
-      await expect
-        .poll(
-          async () => {
-            await editor.expectEditor.toContain('length = 156.54, angle = -28')
-            await page.mouse.move(handle1Location.x, handle1Location.y)
-            await page.mouse.down()
-            await page.mouse.move(
-              handle1Location.x + 50,
-              handle1Location.y + 50,
-              {
-                steps: 5,
-              }
-            )
-            await page.mouse.up()
-            await editor.expectEditor.toContain('length = 231.59, angle = -34')
-            return true
-          },
-          { timeout: 10_000 }
-        )
-        .toBeTruthy()
+      await editor.expectEditor.toContain('length = 156.54, angle = -28')
+      await page.mouse.move(handle1Location.x, handle1Location.y)
+      await page.mouse.down()
+      await page.mouse.move(handle1Location.x + 50, handle1Location.y + 50, {
+        steps: 5,
+      })
+      await page.mouse.up()
+      await editor.expectEditor.toContain('length = 231.59, angle = -34')
+      // await page.waitForTimeout(1000) // Wait for update
     })
 
     await test.step('Delete variables and wait for re-execution', async () => {
@@ -3091,27 +3129,20 @@ test.describe('manual edits during sketch mode', () => {
       await page.waitForTimeout(50)
       await editor.replaceCode('myVar2 = 6', '')
       await page.waitForTimeout(2000) // Wait for deferred execution
+      await expectSketchOriginToBeDrawn()
     })
 
     const handle2Location = { x: 872, y: 273 }
     await test.step('Edit sketch again', async () => {
       await editor.expectEditor.toContain('length = 231.59, angle = -34')
       await page.waitForTimeout(500)
-      await expect
-        .poll(
-          async () => {
-            await page.mouse.move(handle2Location.x, handle2Location.y)
-            await page.mouse.down()
-            await page.mouse.move(handle2Location.x, handle2Location.y - 50, {
-              steps: 5,
-            })
-            await page.mouse.up()
-            await editor.expectEditor.toContain('length = 167.36, angle = -14')
-            return true
-          },
-          { timeout: 10_000 }
-        )
-        .toBeTruthy()
+      await page.mouse.move(handle2Location.x, handle2Location.y)
+      await page.mouse.down()
+      await page.mouse.move(handle2Location.x, handle2Location.y - 50, {
+        steps: 5,
+      })
+      await page.mouse.up()
+      await editor.expectEditor.toContain('length = 167.36, angle = -14')
     })
 
     await test.step('add whole other sketch before current sketch', async () => {
@@ -3123,27 +3154,19 @@ test.describe('manual edits during sketch mode', () => {
     profile004 = circle(sketch003, center = [143.91, 136.89], radius = 71.63)`
       )
       await page.waitForTimeout(2000) // Wait for deferred execution
+      await expectSketchOriginToBeDrawn()
     })
 
     const handle3Location = { x: 844, y: 212 }
     await test.step('edit sketch again', async () => {
-      await page.waitForTimeout(500) // Wait for deferred execution
-      await expect
-        .poll(
-          async () => {
-            await editor.expectEditor.toContain('length = 167.36, angle = -14')
-            await page.mouse.move(handle3Location.x, handle3Location.y)
-            await page.mouse.down()
-            await page.mouse.move(handle3Location.x, handle3Location.y + 110, {
-              steps: 5,
-            })
-            await page.mouse.up()
-            await editor.expectEditor.toContain('length = 219.2, angle = -56')
-            return true
-          },
-          { timeout: 10_000 }
-        )
-        .toBeTruthy()
+      await editor.expectEditor.toContain('length = 167.36, angle = -14')
+      await page.mouse.move(handle3Location.x, handle3Location.y)
+      await page.mouse.down()
+      await page.mouse.move(handle3Location.x, handle3Location.y + 110, {
+        steps: 5,
+      })
+      await page.mouse.up()
+      await editor.expectEditor.toContain('length = 219.2, angle = -56')
     })
 
     // exit sketch and assert whole code
@@ -3151,27 +3174,32 @@ test.describe('manual edits during sketch mode', () => {
       await toolbar.exitSketch()
       await editor.expectEditor.toContain(
         `myVar1 = 5
-sketch003 = startSketchOn(XY)
-profile004 = circle(sketch003, center = [143.91, 136.89], radius = 71.63)
-
-sketch001 = startSketchOn(XZ)
-profile001 = startProfileAt([106.68, 89.77], sketch001)
-  |> line(end = [132.34, 157.8])
-  |> line(end = [67.65, -460.55], tag = $seg01)
-  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
-  |> close()
-extrude001 = extrude(profile001, length = 500)
-sketch002 = startSketchOn(extrude001, face = seg01)
-profile002 = startProfileAt([83.39, 329.15], sketch002)
-  |> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
-  |> angledLine(length = 219.2, angle = -56)
-  |> angledLine(angle = -151, length = 116.27)
-  |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
-  |> close()
-profile003 = startProfileAt([-201.08, 254.17], sketch002)
-  |> line(end = [103.55, 33.32])
-  |> line(end = [48.8, -153.54])
-`,
+    sketch003 = startSketchOn(XY)
+    profile004 = circle(sketch003, center = [143.91, 136.89], radius = 71.63)
+    
+    sketch001 = startSketchOn(XZ)
+    profile001 = startProfileAt([106.68, 89.77], sketch001)
+      |> line(end = [132.34, 157.8])
+      |> line(end = [67.65, -460.55], tag = $seg01)
+      |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
+      |> close()
+    extrude001 = extrude(profile001, length = 500)
+    sketch002 = startSketchOn(extrude001, face = seg01)
+    profile002 = startProfileAt([83.39, 329.15], sketch002)
+      |> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
+      |> angledLine(angle = segAng(rectangleSegmentA001) - 90, length = 219.2, angle = -56)
+      |> angledLine(
+          angle = segAng(rectangleSegmentA001),
+          length = -segLen(rectangleSegmentA001),
+          angle = -151,
+          length = 116.27,
+        )
+      |> line(endAbsolute = [profileStartX(%), profileStartY(%)])
+      |> close()
+    profile003 = startProfileAt([-201.08, 254.17], sketch002)
+      |> line(end = [103.55, 33.32])
+      |> line(end = [48.8, -153.54])
+    `,
         { shouldNormalise: true }
       )
       await editor.expectState({
@@ -3192,7 +3220,7 @@ profile003 = startProfileAt([-201.08, 254.17], sketch002)
   }) => {
     const initialCode = `myVar1 = 5
     myVar2 = 6
-
+    
     sketch001 = startSketchOn(XZ)
     profile001 = startProfileAt([106.68, 89.77], sketch001)
       |> line(end = [132.34, 157.8])
@@ -3203,8 +3231,10 @@ profile003 = startProfileAt([-201.08, 254.17], sketch002)
     sketch002 = startSketchOn(extrude001, face = seg01)
     profile002 = startProfileAt([83.39, 329.15], sketch002)
       |> angledLine(angle = 0, length = 119.61, tag = $rectangleSegmentA001)
-      |> angledLine(length = 156.54, angle = -28)
+      |> angledLine(angle = segAng(rectangleSegmentA001) - 90, length = 156.54, angle = -28)
       |> angledLine(
+           angle = segAng(rectangleSegmentA001),
+           length = -segLen(rectangleSegmentA001),
            angle = -151,
            length = 116.27,
          )
@@ -3295,7 +3325,7 @@ profile003 = startProfileAt([-201.08, 254.17], sketch002)
         )
         await editor.expectState({
           activeLines: [],
-          diagnostics: ['`badBadBadFn`isnotdefined'],
+          diagnostics: ['memoryitemkey`badBadBadFn`isnotdefined'],
           highlightedCode: '',
         })
         await expect(
@@ -3320,21 +3350,7 @@ profile003 = startProfileAt([-201.08, 254.17], sketch002)
         // this checks sketch segments have been drawn
         await verifyArrowHeadColor(arrowHeadWhite)
       })
-
-      await test.step('make a change to the code and expect pixel color to change', async () => {
-        // defends against a regression where sketch would duplicate in the scene
-        // https://github.com/KittyCAD/modeling-app/issues/6345
-        await editor.replaceCode(
-          'startProfileAt([75.8, 317.2',
-          'startProfileAt([75.8, 217.2'
-        )
-        // expect not white anymore
-        await scene.expectPixelColorNotToBe(
-          TEST_COLORS.WHITE,
-          arrowHeadLocation,
-          15
-        )
-      })
+      await page.waitForTimeout(100)
     }
   )
 })

e2e/playwright/snapshot-tests.spec.ts

@@ -49,6 +49,7 @@ test(
   'exports of each format should work',
   { tag: ['@snapshot', '@skipWin', '@skipMacos'] },
   async ({ page, context, scene, cmdBar, tronApp }) => {
+    test.fixme(orRunWhenFullSuiteEnabled())
     if (!tronApp) {
       fail()
     }
@@ -376,6 +377,9 @@ test.describe(
   'extrude on default planes should be stable',
   { tag: '@snapshot' },
   () => {
+    // FIXME: Skip on macos its being weird.
+    test.skip(process.platform === 'darwin', 'Skip on macos')
+
     test('XY', async ({ page, context, cmdBar, scene }) => {
       await extrudeDefaultPlane(context, page, cmdBar, scene, 'XY')
     })
@@ -530,6 +534,9 @@ test(
   'Draft rectangles should look right',
   { tag: '@snapshot' },
   async ({ page, context, cmdBar, scene }) => {
+    // FIXME: Skip on macos its being weird.
+    test.skip(process.platform === 'darwin', 'Skip on macos')
+
     const u = await getUtils(page)
     await page.setViewportSize({ width: 1200, height: 500 })
     const PUR = 400 / 37.5 //pixeltoUnitRatio
@@ -575,6 +582,7 @@ test(
   'Draft circle should look right',
   { tag: '@snapshot' },
   async ({ page, context, cmdBar, scene }) => {
+    test.fixme(orRunWhenFullSuiteEnabled())
     const u = await getUtils(page)
     await page.setViewportSize({ width: 1200, height: 500 })
     const PUR = 400 / 37.5 //pixeltoUnitRatio
@@ -621,6 +629,9 @@ test.describe(
   'Client side scene scale should match engine scale',
   { tag: '@snapshot' },
   () => {
+    // FIXME: Skip on macos its being weird.
+    test.skip(process.platform === 'darwin', 'Skip on macos')
+
     test('Inch scale', async ({ page, cmdBar, scene }) => {
       const u = await getUtils(page)
       await page.setViewportSize({ width: 1200, height: 500 })
@@ -796,6 +807,9 @@ test(
   'Sketch on face with none z-up',
   { tag: '@snapshot' },
   async ({ page, context, cmdBar, scene }) => {
+    // FIXME: Skip on macos its being weird.
+    test.skip(process.platform === 'darwin', 'Skip on macos')
+
     const u = await getUtils(page)
     await context.addInitScript(async (KCL_DEFAULT_LENGTH) => {
       localStorage.setItem(
@@ -854,6 +868,9 @@ test(
   'Zoom to fit on load - solid 2d',
   { tag: '@snapshot' },
   async ({ page, context, cmdBar, scene }) => {
+    // FIXME: Skip on macos its being weird.
+    test.skip(process.platform === 'darwin', 'Skip on macos')
+
     const u = await getUtils(page)
     await context.addInitScript(async () => {
       localStorage.setItem(
@@ -890,6 +907,9 @@ test(
   'Zoom to fit on load - solid 3d',
   { tag: '@snapshot' },
   async ({ page, context, cmdBar, scene }) => {
+    // FIXME: Skip on macos its being weird.
+    test.skip(process.platform === 'darwin', 'Skip on macos')
+
     const u = await getUtils(page)
     await context.addInitScript(async () => {
       localStorage.setItem(
@@ -1135,7 +1155,11 @@ sweepPath = startSketchOn(XZ)
 
 sweepSketch = startSketchOn(XY)
   |> startProfileAt([2, 0], %)
-  |> arc(angleStart = 0, angleEnd = 360, radius = 2)
+  |> arc({
+       angleEnd = 360,
+       angleStart = 0,
+       radius = 2
+     }, %)
   |> sweep(path = sweepPath)
   |> appearance(
        color = "#bb00ff",
@@ -1180,7 +1204,11 @@ sweepPath = startSketchOn(XZ)
 
 sweepSketch = startSketchOn(XY)
   |> startProfileAt([2, 0], %)
-  |> arc(angleStart = 0, angleEnd = 360, radius = 2)
+  |> arc({
+       angleEnd = 360,
+       angleStart = 0,
+       radius = 2
+     }, %)
   |> sweep(path = sweepPath)
   |> appearance(
        color = "#bb00ff",