Change units KCL functions to read from new module local setting

.codespellrc

@@ -1,3 +1,3 @@
 [codespell]
-ignore-words-list: crate,everytime,inout,co-ordinate,ot,nwo,atleast,ue,afterall,ser
+ignore-words-list: crate,everytime,inout,co-ordinate,ot,nwo,absolutey,atleast,ue,afterall
-skip: **/target,node_modules,build,dist,./out,**/Cargo.lock,./docs/kcl/*.md,.yarn.lock,**/yarn.lock,./openapi/*.json,./packages/codemirror-lang-kcl/test/all.test.ts,tsconfig.tsbuildinfo
+skip: **/target,node_modules,build,**/Cargo.lock,./docs/kcl/*.md,.yarn.lock,**/yarn.lock,./openapi/*.json,./src/lib/machine-api.d.ts

.eslintrc

@@ -5,32 +5,16 @@
     },
     "plugins": [
       "css-modules",
-      "jest",
-      "jsx-a11y",
-      "react",
-      "react-hooks",
       "suggest-no-throw",
-      "testing-library",
-      "@typescript-eslint"
     ],
     "extends": [
-      "plugin:css-modules/recommended",
+      "react-app",
-      "plugin:jsx-a11y/recommended",
+      "react-app/jest",
-      "plugin:react-hooks/recommended"
+      "plugin:css-modules/recommended"
     ],
     "rules": {
       "@typescript-eslint/no-floating-promises": "error",
       "@typescript-eslint/no-misused-promises": "error",
-      "jsx-a11y/click-events-have-key-events": "off",
-      "jsx-a11y/no-autofocus": "off",
-      "jsx-a11y/no-noninteractive-element-interactions": "off",
-      "no-restricted-globals": [
-        "error",
-        {
-          "name": "isNaN",
-          "message": "Use Number.isNaN() instead."
-        }
-      ],
       "semi": [
         "error",
         "never"
@@ -41,9 +25,6 @@
     "overrides": [
       {
         "files": ["e2e/**/*.ts"], // Update the pattern based on your file structure
-        "extends": [
-          "plugin:testing-library/react"
-        ],
         "rules": {
           "suggest-no-throw/suggest-no-throw": "off",
           "testing-library/prefer-screen-queries": "off",
@@ -52,9 +33,6 @@
       },
       {
         "files": ["src/**/*.test.ts"],
-        "extends": [
-          "plugin:testing-library/react"
-        ],
         "rules": {
           "suggest-no-throw/suggest-no-throw": "off",
         }

.github/ci-cd-scripts/playwright-electron.sh

@@ -21,7 +21,7 @@ if [[ ! -f "test-results/.last-run.json" ]]; then
 fi
 
 retry=1
-max_retrys=5
+max_retrys=4
 
 # retry failed tests, doing our own retries because using inbuilt playwright retries causes connection issues
 while [[ $retry -le $max_retrys ]]; do

.github/dependabot.yml

@@ -5,37 +5,24 @@
 
 version: 2
 updates:
-  - package-ecosystem: 'npm' # See documentation for possible values
+    - package-ecosystem: 'npm' # See documentation for possible values
-    directories:
+      directory: '/' # Location of package manifests
-      - '/'
+      schedule:
-      - '/packages/codemirror-lang-kcl/'
+          interval: 'weekly'
-      - '/packages/codemirror-lsp-client/'
+      reviewers:
-    schedule:
+          - franknoirot
-      interval: weekly
+          - irev-dev
-      day: monday
+    - package-ecosystem: 'github-actions' # See documentation for possible values
-    reviewers:
+      directory: '/' # Location of package manifests
-      - franknoirot
+      schedule:
-      - irev-dev
+          interval: 'weekly'
-  - package-ecosystem: 'github-actions' # See documentation for possible values
+      reviewers:
-    directory: '/' # Location of package manifests
+          - adamchalmers
-    schedule:
+          - jessfraz
-      interval: weekly
+    - package-ecosystem: 'cargo' # See documentation for possible values
-      day: monday
+      directory: '/src/wasm-lib/' # Location of package manifests
-    reviewers:
+      schedule:
-      - adamchalmers
+          interval: 'weekly'
-      - jessfraz
+      reviewers:
-  - package-ecosystem: 'cargo' # See documentation for possible values
+          - adamchalmers
-    directory: '/src/wasm-lib/' # Location of package manifests
+          - jessfraz
-    schedule:
-      interval: weekly
-      day: monday
-    reviewers:
-      - adamchalmers
-      - jessfraz
-    groups:
-      serde-dependencies:
-        patterns:
-          - "serde*"
-      wasm-bindgen-deps:
-        patterns:
-          - "wasm-bindgen*"

.github/workflows/build-and-store-wasm.yml

@@ -27,7 +27,7 @@ jobs:
 
 
       # Upload the WASM bundle as an artifact
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v3
         with:
           name: wasm-bundle
           path: src/wasm-lib/pkg

.github/workflows/build-apps.yml

@@ -126,13 +126,7 @@ jobs:
           node-version-file: '.nvmrc'
           cache: 'yarn' # Set this to npm, yarn or pnpm.
 
-      - name: yarn install
+      - run: yarn install
-        # Windows is picky sometimes and fails on fetch. Step takes about ~30s
-        uses: nick-fields/retry@v3.0.0
-        with:
-          timeout_minutes: 2
-          max_attempts: 3
-          command: yarn install
 
       - run: yarn tronb:vite
 
@@ -179,13 +173,7 @@ jobs:
           CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
           CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }}
           WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }}
-          DEBUG: "electron-notarize*"
+        run: yarn electron-builder --config --publish always
-        # TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures
-        uses: nick-fields/retry@v3.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          command: yarn electron-builder --config --publish always
 
       - name: List artifacts in out/
         run: ls -R out
@@ -240,13 +228,7 @@ jobs:
           CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
           CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }}
           WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }}
-          DEBUG: "electron-notarize*"
+        run: yarn electron-builder --config --publish always
-        # TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures
-        uses: nick-fields/retry@v3.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          command: yarn electron-builder --config --publish always
 
       - uses: actions/upload-artifact@v4
         if: ${{ env.IS_RELEASE == 'true' }}

.github/workflows/cargo-bench.yml

@@ -0,0 +1,44 @@
+on:
+  push:
+    branches:
+      - main
+    paths:
+      - '**.rs'
+      - '**/Cargo.toml'
+      - '**/Cargo.lock'
+      - '**/rust-toolchain.toml'
+      - .github/workflows/cargo-bench.yml
+  pull_request:
+    paths:
+      - '**.rs'
+      - '**/Cargo.toml'
+      - '**/Cargo.lock'
+      - '**/rust-toolchain.toml'
+      - .github/workflows/cargo-bench.yml
+  workflow_dispatch:
+permissions: read-all
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+name: cargo bench
+jobs:
+  cargo-bench:
+    name: Benchmark with iai
+    runs-on: ubuntu-latest-8-cores
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - name: Install dependencies
+        run: |
+          cargo install cargo-criterion
+          sudo apt update
+          sudo apt install -y valgrind
+      - name: Rust Cache
+        uses: Swatinem/rust-cache@v2.6.1
+      - name: Benchmark kcl library
+        shell: bash
+        run: |-
+          cd src/wasm-lib/kcl; cargo bench --all-features -- iai
+        env:
+          KITTYCAD_API_TOKEN: ${{secrets.KITTYCAD_API_TOKEN}}
+

.github/workflows/codemirror-lang-kcl.yml

@@ -1,32 +0,0 @@
-name: CodeMirror Lang KCL
-
-on:
-  pull_request:
-  push:
-    branches:
-      - main
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
-  cancel-in-progress: true
-
-jobs:
-  yarn-unit-test:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-          cache: 'yarn'
-
-      - run: yarn install
-        working-directory: packages/codemirror-lang-kcl
-
-      - run: yarn tsc
-        working-directory: packages/codemirror-lang-kcl
-
-      - name: run unit tests
-        run: yarn test
-        working-directory: packages/codemirror-lang-kcl

.github/workflows/e2e-tests.yml

@@ -18,6 +18,7 @@ permissions:
 jobs:
 
   check-rust-changes:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     outputs:
       rust-changed: ${{ steps.filter.outputs.rust }}
@@ -34,6 +35,7 @@ jobs:
               - 'src/wasm-lib/**'
 
   electron:
+    if: github.event.pull_request.draft == false
     timeout-minutes: 60
     name: playwright:electron:${{ matrix.os }} ${{ matrix.shardIndex }} ${{ matrix.shardTotal }}
     strategy:
@@ -127,12 +129,9 @@ jobs:
       shell: bash
       run: yarn tron:package
     - name: Run ubuntu/chrome snapshots
-      if: ${{ matrix.os == 'namespace-profile-ubuntu-8-cores' && matrix.shardIndex == 1 }}
       shell: bash
-      # TODO: break this in its own job, for now it's not slowing down the overall execution as ubuntu is the quickest,
-      # but we could do better. This forces a large 1/1 shard of all 20 snapshot tests that runs in about 3 minutes.
       run: |
-        PLATFORM=web yarn playwright test --config=playwright.config.ts --retries="3" --update-snapshots --grep=@snapshot  --shard=1/1
+        PLATFORM=web yarn playwright test --config=playwright.config.ts --retries="3" --update-snapshots --grep=@snapshot  --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
       env:
         CI: true
         NODE_ENV: development
@@ -153,7 +152,6 @@ jobs:
       continue-on-error: true
       run: rm -r test-results
     - name: check for changes
-      if: ${{ matrix.os == 'namespace-profile-ubuntu-8-cores' && matrix.shardIndex == 1 }}
       shell: bash
       id: git-check
       run: |

README.md

@@ -337,47 +337,13 @@ For individual testing:
 yarn test abstractSyntaxTree -t "unexpected closed curly brace" --silent=false
 ```
 
-Which will run our suite of [Vitest unit](https://vitest.dev/) and [React Testing Library E2E](https://testing-library.com/docs/react-testing-library/intro) tests, in interactive mode by default.
+Which will run our suite of [Vitest unit](https://vitest.dev/) and [React Testing Library E2E](https://testing-library.com/docs/react-testing-library/intro/) tests, in interactive mode by default.
 
 ### Rust tests
 
-**Dependencies**
-
-- `KITTYCAD_API_TOKEN`
-- `cargo-nextest`
-- `just`
-
-#### Setting KITTYCAD_API_TOKEN
-Use the production zoo.dev token, set this environment variable before running the tests
-
-#### Installing cargonextest
-
-```
-cd src/wasm-lib
-cargo search cargo-nextest
-cargo install cargo-nextest
-```
-
-#### just
-install [`just`](https://github.com/casey/just?tab=readme-ov-file#pre-built-binaries)
-
-#### Running the tests
-
 ```bash
-# With just
-# Make sure KITTYCAD_API_TOKEN=<prod zoo.dev token> is set
-# Make sure you installed cargo-nextest
-# Make sure you installed just
 cd src/wasm-lib
-just test
+KITTYCAD_API_TOKEN=XXX cargo test -- --test-threads=1
-```
-
-```bash
-# Without just
-# Make sure KITTYCAD_API_TOKEN=<prod zoo.dev token> is set
-# Make sure you installed cargo-nextest
-cd src/wasm-lib
-export RUST_BRACKTRACE="full" && cargo nextest run --workspace --test-threads=1
 ```
 
 Where `XXX` is an API token from the production engine (NOT the dev environment).

docs/kcl/index.md

@@ -35,7 +35,6 @@ layout: manual
 * [`ceil`](kcl/ceil)
 * [`chamfer`](kcl/chamfer)
 * [`circle`](kcl/circle)
-* [`circleThreePoint`](kcl/circleThreePoint)
 * [`close`](kcl/close)
 * [`cm`](kcl/cm)
 * [`cos`](kcl/cos)
@@ -48,11 +47,11 @@ layout: manual
 * [`getOppositeEdge`](kcl/getOppositeEdge)
 * [`getPreviousAdjacentEdge`](kcl/getPreviousAdjacentEdge)
 * [`helix`](kcl/helix)
-* [`helixRevolutions`](kcl/helixRevolutions)
 * [`hole`](kcl/hole)
 * [`hollow`](kcl/hollow)
 * [`import`](kcl/import)
 * [`inch`](kcl/inch)
+* [`int`](kcl/int)
 * [`lastSegX`](kcl/lastSegX)
 * [`lastSegY`](kcl/lastSegY)
 * [`legAngX`](kcl/legAngX)
@@ -81,7 +80,6 @@ layout: manual
 * [`pi`](kcl/pi)
 * [`polar`](kcl/polar)
 * [`polygon`](kcl/polygon)
-* [`pop`](kcl/pop)
 * [`pow`](kcl/pow)
 * [`profileStart`](kcl/profileStart)
 * [`profileStartX`](kcl/profileStartX)

docs/kcl/int.md

@@ -4,8 +4,6 @@ excerpt: "Convert a number to an integer."
 layout: manual
 ---
 
-**WARNING:** This function is deprecated.
-
 Convert a number to an integer.
 
 DEPRECATED use floor(), ceil(), or round().

docs/kcl/types/Axis3dOrEdgeReference.md

@@ -1,42 +0,0 @@
----
-title: "Axis3dOrEdgeReference"
-excerpt: "A 3D axis or tagged edge."
-layout: manual
----
-
-A 3D axis or tagged edge.
-
-
-
-
-**This schema accepts any of the following:**
-
-3D axis and origin.
-
-[`AxisAndOrigin3d`](/docs/kcl/types/AxisAndOrigin3d)
-
-
-
-
-
-
-
-
-----
-Tagged edge.
-
-[`EdgeReference`](/docs/kcl/types/EdgeReference)
-
-
-
-
-
-
-
-
-----
-
-
-
-
-

docs/kcl/types/AxisAndOrigin.md

@@ -1,10 +1,10 @@
 ---
-title: "AxisAndOrigin2d"
+title: "AxisAndOrigin"
-excerpt: "A 2D axis and origin."
+excerpt: "Axis and origin."
 layout: manual
 ---
 
-A 2D axis and origin.
+Axis and origin.
 
 
 

docs/kcl/types/AxisAndOrigin3d.md

@@ -1,105 +0,0 @@
----
-title: "AxisAndOrigin3d"
-excerpt: "A 3D axis and origin."
-layout: manual
----
-
-A 3D axis and origin.
-
-
-
-
-
-**This schema accepts exactly one of the following:**
-
-X-axis.
-
-**enum:** `X`
-
-
-
-
-
-
-
-
-----
-Y-axis.
-
-**enum:** `Y`
-
-
-
-
-
-
-
-
-----
-Z-axis.
-
-**enum:** `Z`
-
-
-
-
-
-
-
-
-----
-Flip the X-axis.
-
-**enum:** `-X`
-
-
-
-
-
-
-
-
-----
-Flip the Y-axis.
-
-**enum:** `-Y`
-
-
-
-
-
-
-
-
-----
-Flip the Z-axis.
-
-**enum:** `-Z`
-
-
-
-
-
-
-
-
-----
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `custom` |`object`|  | No |
-
-
-----
-
-
-
-

docs/kcl/types/AxisOrEdgeReference.md

@@ -1,19 +1,19 @@
 ---
-title: "Axis2dOrEdgeReference"
+title: "AxisOrEdgeReference"
-excerpt: "A 2D axis or tagged edge."
+excerpt: "Axis or tagged edge."
 layout: manual
 ---
 
-A 2D axis or tagged edge.
+Axis or tagged edge.
 
 
 
 
 **This schema accepts any of the following:**
 
-2D axis and origin.
+Axis and origin.
 
-[`AxisAndOrigin2d`](/docs/kcl/types/AxisAndOrigin2d)
+[`AxisAndOrigin`](/docs/kcl/types/AxisAndOrigin)
 
 
 

docs/kcl/types/CircleThreePointData.md

@@ -1,23 +0,0 @@
----
-title: "CircleThreePointData"
-excerpt: "Data for drawing a 3-point circle"
-layout: manual
----
-
-Data for drawing a 3-point circle
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `p1` |`[number, number]`| Point one for circle derivation. | No |
-| `p2` |`[number, number]`| Point two for circle derivation. | No |
-| `p3` |`[number, number]`| Point three for circle derivation. | No |
-
-

docs/kcl/types/Face.md

@@ -1,28 +0,0 @@
----
-title: "Face"
-excerpt: "A face."
-layout: manual
----
-
-A face.
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `id` |`string`| The id of the face. | No |
-| `value` |`string`| The tag of the face. | No |
-| `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the face’s X axis be? | No |
-| `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the face’s Y axis be? | No |
-| `zAxis` |[`Point3d`](/docs/kcl/types/Point3d)| The z-axis (normal). | No |
-| `solid` |[`Solid`](/docs/kcl/types/Solid)| The solid the face is on. | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A face. | No |
-| `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
-
-

docs/kcl/types/Helix.md

@@ -1,26 +0,0 @@
----
-title: "Helix"
-excerpt: "A helix."
-layout: manual
----
-
-A helix.
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `value` |`string`| The id of the helix. | No |
-| `revolutions` |`number`| Number of revolutions. | No |
-| `angleStart` |`number`| Start angle (in degrees). | No |
-| `ccw` |`boolean`| Is the helix rotation counter clockwise? | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A helix. | No |
-| `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
-
-

docs/kcl/types/HelixData.md

@@ -1,10 +1,10 @@
 ---
 title: "HelixData"
-excerpt: "Data for a helix."
+excerpt: "Data for helices."
 layout: manual
 ---
 
-Data for a helix.
+Data for helices.
 
 **Type:** `object`
 
@@ -19,8 +19,6 @@ Data for a helix.
 | `revolutions` |`number`| Number of revolutions. | No |
 | `angleStart` |`number`| Start angle (in degrees). | No |
 | `ccw` |`boolean`| Is the helix rotation counter clockwise? The default is `false`. | No |
-| `length` |`number`| Length of the helix. This is not necessary if the helix is created around an edge. If not given the length of the edge is used. | No |
+| `length` |`number`| Length of the helix. If this argument is not provided, the height of the solid is used. | No |
-| `radius` |`number`| Radius of the helix. | No |
-| `axis` |[`Axis3dOrEdgeReference`](/docs/kcl/types/Axis3dOrEdgeReference)| Axis to use as mirror. | No |
 
 

docs/kcl/types/HelixRevolutionsData.md

@@ -1,24 +0,0 @@
----
-title: "HelixRevolutionsData"
-excerpt: "Data for helix revolutions."
-layout: manual
----
-
-Data for helix revolutions.
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `revolutions` |`number`| Number of revolutions. | No |
-| `angleStart` |`number`| Start angle (in degrees). | No |
-| `ccw` |`boolean`| Is the helix rotation counter clockwise? The default is `false`. | No |
-| `length` |`number`| Length of the helix. If this argument is not provided, the height of the solid is used. | No |
-
-

docs/kcl/types/HelixValue.md

@@ -1,26 +0,0 @@
----
-title: "HelixValue"
-excerpt: "A helix."
-layout: manual
----
-
-A helix.
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `value` |`string`| The id of the helix. | No |
-| `revolutions` |`number`| Number of revolutions. | No |
-| `angleStart` |`number`| Start angle (in degrees). | No |
-| `ccw` |`boolean`| Is the helix rotation counter clockwise? | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A helix. | No |
-| `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
-
-

docs/kcl/types/KclValue.md

@@ -168,6 +168,7 @@ Any KCL value.
 
 
 ----
+A plane.
 
 **Type:** `object`
 
@@ -180,10 +181,17 @@ Any KCL value.
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
 | `type` |enum: [`Plane`](/docs/kcl/types/Plane)|  | No |
-| `value` |[`Plane`](/docs/kcl/types/Plane)| Any KCL value. | No |
+| `id` |`string`| The id of the plane. | No |
+| `value` |[`PlaneType`](/docs/kcl/types/PlaneType)| Any KCL value. | No |
+| `origin` |[`Point3d`](/docs/kcl/types/Point3d)| Origin of the plane. | No |
+| `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane’s X axis be? | No |
+| `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane’s Y axis be? | No |
+| `zAxis` |[`Point3d`](/docs/kcl/types/Point3d)| The z-axis (normal). | No |
+| `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
 
 
 ----
+A face.
 
 **Type:** `object`
 
@@ -195,8 +203,14 @@ Any KCL value.
 
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
-| `type` |enum: [`Face`](/docs/kcl/types/Face)|  | No |
+| `type` |enum: `Face`|  | No |
-| `value` |[`Face`](/docs/kcl/types/Face)| Any KCL value. | No |
+| `id` |`string`| The id of the face. | No |
+| `value` |`string`| The tag of the face. | No |
+| `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the face’s X axis be? | No |
+| `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the face’s Y axis be? | No |
+| `zAxis` |[`Point3d`](/docs/kcl/types/Point3d)| The z-axis (normal). | No |
+| `solid` |[`Solid`](/docs/kcl/types/Solid)| The solid the face is on. | No |
+| `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
 
 
 ----
@@ -232,6 +246,7 @@ Any KCL value.
 
 
 ----
+An solid is a collection of extrude surfaces.
 
 **Type:** `object`
 
@@ -244,7 +259,14 @@ Any KCL value.
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
 | `type` |enum: [`Solid`](/docs/kcl/types/Solid)|  | No |
-| `value` |[`Solid`](/docs/kcl/types/Solid)| Any KCL value. | No |
+| `id` |`string`| The id of the solid. | No |
+| `value` |`[` [`ExtrudeSurface`](/docs/kcl/types/ExtrudeSurface) `]`| The extrude surfaces. | No |
+| `sketch` |[`Sketch`](/docs/kcl/types/Sketch)| The sketch. | No |
+| `height` |`number`| The height of the solid. | No |
+| `startCapId` |`string`| The id of the extrusion start cap | No |
+| `endCapId` |`string`| The id of the extrusion end cap | No |
+| `edgeCuts` |`[` [`EdgeCut`](/docs/kcl/types/EdgeCut) `]`| Chamfers or fillets on this solid. | No |
+| `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`| Metadata. | No |
 
 
 ----
@@ -263,22 +285,6 @@ Any KCL value.
 | `value` |`[` [`Solid`](/docs/kcl/types/Solid) `]`|  | No |
 
 
-----
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `type` |enum: [`Helix`](/docs/kcl/types/Helix)|  | No |
-| `value` |[`Helix`](/docs/kcl/types/Helix)| Any KCL value. | No |
-
-
 ----
 Data for an imported geometry.
 

docs/kcl/types/Mirror2dData.md

@@ -16,6 +16,6 @@ Data for a mirror.
 
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
-| `axis` |[`Axis2dOrEdgeReference`](/docs/kcl/types/Axis2dOrEdgeReference)| Axis to use as mirror. | No |
+| `axis` |[`AxisOrEdgeReference`](/docs/kcl/types/AxisOrEdgeReference)| Axis to use as mirror. | No |
 
 

docs/kcl/types/Plane.md

@@ -22,7 +22,6 @@ A plane.
 | `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane’s X axis be? | No |
 | `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane’s Y axis be? | No |
 | `zAxis` |[`Point3d`](/docs/kcl/types/Point3d)| The z-axis (normal). | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A plane. | No |
 | `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
 
 

docs/kcl/types/RevolveData.md

@@ -17,7 +17,7 @@ Data for revolution surfaces.
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
 | `angle` |`number` (**maximum:** 360.0) (**minimum:** -360.0)| Angle to revolve (in degrees). Default is 360. | No |
-| `axis` |[`Axis2dOrEdgeReference`](/docs/kcl/types/Axis2dOrEdgeReference)| Axis of revolution. | No |
+| `axis` |[`AxisOrEdgeReference`](/docs/kcl/types/AxisOrEdgeReference)| Axis of revolution. | No |
 | `tolerance` |`number`| Tolerance for the revolve operation. | No |
 
 

docs/kcl/types/Sketch.md

@@ -21,7 +21,6 @@ A sketch is a collection of paths.
 | `on` |[`SketchSurface`](/docs/kcl/types/SketchSurface)| What the sketch is on (can be a plane or a face). | No |
 | `start` |[`BasePath`](/docs/kcl/types/BasePath)| The starting path. | No |
 | `tags` |`object`| Tag identifiers that have been declared in this sketch. | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A sketch is a collection of paths. | No |
 | `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`| Metadata. | No |
 
 

docs/kcl/types/SketchSet.md

@@ -30,7 +30,6 @@ A sketch is a collection of paths.
 | `on` |[`SketchSurface`](/docs/kcl/types/SketchSurface)| What the sketch is on (can be a plane or a face). | No |
 | `start` |[`BasePath`](/docs/kcl/types/BasePath)| The starting path. | No |
 | `tags` |`object`| Tag identifiers that have been declared in this sketch. | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A sketch or a group of sketches. | No |
 | `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`| Metadata. | No |
 
 

docs/kcl/types/SketchSurface.md

@@ -31,7 +31,6 @@ A plane.
 | `xAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane’s X axis be? | No |
 | `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the plane’s Y axis be? | No |
 | `zAxis` |[`Point3d`](/docs/kcl/types/Point3d)| The z-axis (normal). | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A sketch type. | No |
 | `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
 
 
@@ -55,7 +54,6 @@ A face.
 | `yAxis` |[`Point3d`](/docs/kcl/types/Point3d)| What should the face’s Y axis be? | No |
 | `zAxis` |[`Point3d`](/docs/kcl/types/Point3d)| The z-axis (normal). | No |
 | `solid` |[`Solid`](/docs/kcl/types/Solid)| The solid the face is on. | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A sketch type. | No |
 | `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`|  | No |
 
 

docs/kcl/types/Solid.md

@@ -23,7 +23,6 @@ An solid is a collection of extrude surfaces.
 | `startCapId` |`string`| The id of the extrusion start cap | No |
 | `endCapId` |`string`| The id of the extrusion end cap | No |
 | `edgeCuts` |`[` [`EdgeCut`](/docs/kcl/types/EdgeCut) `]`| Chamfers or fillets on this solid. | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| An solid is a collection of extrude surfaces. | No |
 | `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`| Metadata. | No |
 
 

docs/kcl/types/SolidSet.md

@@ -32,7 +32,6 @@ An solid is a collection of extrude surfaces.
 | `startCapId` |`string`| The id of the extrusion start cap | No |
 | `endCapId` |`string`| The id of the extrusion end cap | No |
 | `edgeCuts` |`[` [`EdgeCut`](/docs/kcl/types/EdgeCut) `]`| Chamfers or fillets on this solid. | No |
-| `units` |[`UnitLen`](/docs/kcl/types/UnitLen)| A solid or a group of solids. | No |
 | `__meta` |`[` [`Metadata`](/docs/kcl/types/Metadata) `]`| Metadata. | No |
 
 

docs/kcl/types/SweepData.md

@@ -16,7 +16,7 @@ Data for a sweep.
 
 | Property | Type | Description | Required |
 |----------|------|-------------|----------|
-| `path` |[`SweepPath`](/docs/kcl/types/SweepPath)| The path to sweep along. | No |
+| `path` |[`Sketch`](/docs/kcl/types/Sketch)| The path to sweep along. | No |
 | `sectional` |`boolean`| If true, the sweep will be broken up into sub-sweeps (extrusions, revolves, sweeps) based on the trajectory path components. | No |
 | `tolerance` |`number`| Tolerance for the sweep operation. | No |
 

docs/kcl/types/SweepPath.md

@@ -1,42 +0,0 @@
----
-title: "SweepPath"
-excerpt: "A path to sweep along."
-layout: manual
----
-
-A path to sweep along.
-
-
-
-
-**This schema accepts any of the following:**
-
-A path to sweep along.
-
-[`Sketch`](/docs/kcl/types/Sketch)
-
-
-
-
-
-
-
-
-----
-A path to sweep along.
-
-[`Helix`](/docs/kcl/types/Helix)
-
-
-
-
-
-
-
-
-----
-
-
-
-
-

docs/kcl/types/UnitLen.md

@@ -1,107 +0,0 @@
----
-title: "UnitLen"
-excerpt: ""
-layout: manual
----
-
-
-
-
-
-
-**This schema accepts exactly one of the following:**
-
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `type` |enum: `Mm`|  | No |
-
-
-----
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `type` |enum: `Cm`|  | No |
-
-
-----
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `type` |enum: `M`|  | No |
-
-
-----
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `type` |enum: `Inches`|  | No |
-
-
-----
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `type` |enum: `Feet`|  | No |
-
-
-----
-
-**Type:** `object`
-
-
-
-
-
-## Properties
-
-| Property | Type | Description | Required |
-|----------|------|-------------|----------|
-| `type` |enum: `Yards`|  | No |
-
-
-----
-
-
-
-

e2e/playwright/code-pane-and-errors.spec.ts

@@ -280,7 +280,7 @@ test(
 
       await expect(page.getByRole('link', { name: 'bracket' })).toBeVisible()
       await expect(page.getByText('router-template-slate')).toBeVisible()
-      await expect(page.getByText('Create project')).toBeVisible()
+      await expect(page.getByText('New Project')).toBeVisible()
     })
 
     await test.step('Opening the router-template project should load', async () => {

e2e/playwright/command-bar-tests.spec.ts

@@ -45,6 +45,46 @@ test.describe('Command bar tests', () => {
     )
   })
 
+  // TODO: fix this test after the electron migration
+  test.fixme('Fillet from command bar', async ({ page, homePage }) => {
+    await page.addInitScript(async () => {
+      localStorage.setItem(
+        'persistCode',
+        `sketch001 = startSketchOn('XY')
+    |> startProfileAt([-5, -5], %)
+    |> line([0, 10], %)
+    |> line([10, 0], %)
+    |> line([0, -10], %)
+    |> lineTo([profileStartX(%), profileStartY(%)], %)
+    |> close(%)
+  extrude001 = extrude(-10, sketch001)`
+      )
+    })
+
+    const u = await getUtils(page)
+    await page.setBodyDimensions({ width: 1000, height: 500 })
+    await homePage.goToModelingScene()
+    await u.openDebugPanel()
+    await u.expectCmdLog('[data-message-type="execution-done"]')
+    await u.closeDebugPanel()
+
+    const selectSegment = () => page.getByText(`line([0, -10], %)`).click()
+
+    await selectSegment()
+    await page.waitForTimeout(100)
+    await page.getByRole('button', { name: 'Fillet' }).click()
+    await page.waitForTimeout(100)
+    await page.keyboard.press('Enter') // skip selection
+    await page.waitForTimeout(100)
+    await page.keyboard.press('Enter') // accept default radius
+    await page.waitForTimeout(100)
+    await page.keyboard.press('Enter') // submit
+    await page.waitForTimeout(100)
+    await expect(page.locator('.cm-activeLine')).toContainText(
+      `fillet({ radius = ${KCL_DEFAULT_LENGTH}, tags = [seg01] }, %)`
+    )
+  })
+
   test('Command bar can change a setting, and switch back and forth between arguments', async ({
     page,
     homePage,

e2e/playwright/debug-pane.spec.ts

@@ -38,14 +38,14 @@ test.describe('Debug pane', () => {
       // Set the code in the code editor.
       await u.codeLocator.click()
       await page.keyboard.type(code, { delay: 0 })
-      // Scroll to the artifact graph.
+      // Scroll to the feature tree.
       await tree.scrollIntoViewIfNeeded()
-      // Expand the artifact graph.
+      // Expand the feature tree.
-      await tree.getByText('Artifact Graph').click()
+      await tree.getByText('Feature Tree').click()
       // Just expanded the details, making the element taller, so scroll again.
       await tree.getByText('Plane').first().scrollIntoViewIfNeeded()
     })
-    // Extract the artifact IDs from the debug artifact graph.
+    // Extract the artifact IDs from the debug feature tree.
     const initialSegmentIds = await segment.innerText({ timeout: 5_000 })
     // The artifact ID should include a UUID.
     expect(initialSegmentIds).toMatch(

e2e/playwright/fixtures/cmdBarFixture.ts

@@ -135,20 +135,4 @@ export class CmdBarFixture {
       await promptEditCommand.first().click()
     }
   }
-
-  get cmdSearchInput() {
-    return this.page.getByTestId('cmd-bar-search')
-  }
-
-  get argumentInput() {
-    return this.page.getByTestId('cmd-bar-arg-value')
-  }
-
-  get cmdOptions() {
-    return this.page.getByTestId('cmd-bar-option')
-  }
-
-  chooseCommand = async (commandName: string) => {
-    await this.cmdOptions.getByText(commandName).click()
-  }
 }

e2e/playwright/fixtures/fixtureSetup.ts

@@ -121,23 +121,18 @@ export class AuthenticatedTronApp {
 
 export const fixtures = {
   cmdBar: async ({ page }: { page: Page }, use: any) => {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     await use(new CmdBarFixture(page))
   },
   editor: async ({ page }: { page: Page }, use: any) => {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     await use(new EditorFixture(page))
   },
   toolbar: async ({ page }: { page: Page }, use: any) => {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     await use(new ToolbarFixture(page))
   },
   scene: async ({ page }: { page: Page }, use: any) => {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     await use(new SceneFixture(page))
   },
   homePage: async ({ page }: { page: Page }, use: any) => {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     await use(new HomePageFixture(page))
   },
 }

e2e/playwright/fixtures/homePageFixture.ts

@@ -103,7 +103,7 @@ export class HomePageFixture {
       .toEqual(expectedState)
   }
 
-  createAndGoToProject = async (projectTitle = 'project-$nnn') => {
+  createAndGoToProject = async (projectTitle: string) => {
     await expect(this.projectSection).not.toHaveText('Loading your Projects...')
     await this.projectButtonNew.click()
     await this.projectTextName.click()

e2e/playwright/fixtures/sceneFixture.ts

@@ -36,8 +36,7 @@ type DragFromHandler = (
 
 export class SceneFixture {
   public page: Page
-  public streamWrapper!: Locator
+
-  public loadingIndicator!: Locator
   private exeIndicator!: Locator
 
   constructor(page: Page) {
@@ -65,8 +64,6 @@ export class SceneFixture {
     this.page = page
 
     this.exeIndicator = page.getByTestId('model-state-indicator-execution-done')
-    this.streamWrapper = page.getByTestId('stream')
-    this.loadingIndicator = this.streamWrapper.getByTestId('loading')
   }
 
   makeMouseHelpers = (

e2e/playwright/fixtures/toolbarFixture.ts

@@ -14,9 +14,6 @@ export class ToolbarFixture {
 
   extrudeButton!: Locator
   loftButton!: Locator
-  sweepButton!: Locator
-  filletButton!: Locator
-  chamferButton!: Locator
   shellButton!: Locator
   offsetPlaneButton!: Locator
   startSketchBtn!: Locator
@@ -43,9 +40,6 @@ export class ToolbarFixture {
     this.page = page
     this.extrudeButton = page.getByTestId('extrude')
     this.loftButton = page.getByTestId('loft')
-    this.sweepButton = page.getByTestId('sweep')
-    this.filletButton = page.getByTestId('fillet3d')
-    this.chamferButton = page.getByTestId('chamfer3d')
     this.shellButton = page.getByTestId('shell')
     this.offsetPlaneButton = page.getByTestId('plane-offset')
     this.startSketchBtn = page.getByTestId('sketch')
@@ -63,10 +57,6 @@ export class ToolbarFixture {
     this.exeIndicator = page.getByTestId('model-state-indicator-execution-done')
   }
 
-  get logoLink() {
-    return this.page.getByTestId('app-logo')
-  }
-
   startSketchPlaneSelection = async () =>
     doAndWaitForImageDiff(this.page, () => this.startSketchBtn.click(), 500)
 

e2e/playwright/point-click.spec.ts

@@ -756,17 +756,6 @@ test(`Offset plane point-and-click`, async ({
     })
     await scene.expectPixelColor([74, 74, 74], testPoint, 15)
   })
-
-  await test.step('Delete offset plane via feature tree selection', async () => {
-    await editor.closePane()
-    const operationButton = await toolbar.getFeatureTreeOperation(
-      'Offset Plane',
-      0
-    )
-    await operationButton.click({ button: 'left' })
-    await page.keyboard.press('Backspace')
-    await scene.expectPixelColor([50, 51, 96], testPoint, 15)
-  })
 })
 
 const loftPointAndClickCases = [
@@ -829,6 +818,12 @@ loftPointAndClickCases.forEach(({ shouldPreselect }) => {
         })
         await selectSketches()
         await cmdBar.progressCmdBar()
+        await cmdBar.expectState({
+          stage: 'review',
+          headerArguments: { Selection: '2 faces' },
+          commandName: 'Loft',
+        })
+        await cmdBar.progressCmdBar()
       })
     } else {
       await test.step(`Preselect the two sketches`, async () => {
@@ -838,6 +833,12 @@ loftPointAndClickCases.forEach(({ shouldPreselect }) => {
       await test.step(`Go through the command bar flow with preselected sketches`, async () => {
         await toolbar.loftButton.click()
         await cmdBar.progressCmdBar()
+        await cmdBar.expectState({
+          stage: 'review',
+          headerArguments: { Selection: '2 faces' },
+          commandName: 'Loft',
+        })
+        await cmdBar.progressCmdBar()
       })
     }
 
@@ -850,666 +851,6 @@ loftPointAndClickCases.forEach(({ shouldPreselect }) => {
       })
       await scene.expectPixelColor([89, 89, 89], testPoint, 15)
     })
-
-    await test.step('Delete loft via feature tree selection', async () => {
-      await editor.closePane()
-      const operationButton = await toolbar.getFeatureTreeOperation('Loft', 0)
-      await operationButton.click({ button: 'left' })
-      await page.keyboard.press('Backspace')
-      await scene.expectPixelColor([254, 254, 254], testPoint, 15)
-    })
-  })
-})
-
-// TODO: merge with above test. Right now we're not able to delete a loft
-// right after creation via selection for some reason, so we go with a new instance
-test('Loft and offset plane deletion via selection', async ({
-  context,
-  page,
-  homePage,
-  scene,
-}) => {
-  const initialCode = `sketch001 = startSketchOn('XZ')
-  |> circle({ center = [0, 0], radius = 30 }, %)
-  plane001 = offsetPlane('XZ', 50)
-  sketch002 = startSketchOn(plane001)
-  |> circle({ center = [0, 0], radius = 20 }, %)
-loft001 = loft([sketch001, sketch002])
-`
-  await context.addInitScript((initialCode) => {
-    localStorage.setItem('persistCode', initialCode)
-  }, initialCode)
-  await page.setBodyDimensions({ width: 1000, height: 500 })
-  await homePage.goToModelingScene()
-
-  // One dumb hardcoded screen pixel value
-  const testPoint = { x: 575, y: 200 }
-  const [clickOnSketch1] = scene.makeMouseHelpers(testPoint.x, testPoint.y)
-  const [clickOnSketch2] = scene.makeMouseHelpers(testPoint.x, testPoint.y + 80)
-
-  await test.step(`Delete loft`, async () => {
-    // Check for loft
-    await scene.expectPixelColor([89, 89, 89], testPoint, 15)
-    await clickOnSketch1()
-    await expect(page.locator('.cm-activeLine')).toHaveText(`
-      |> circle({ center = [0, 0], radius = 30 }, %)
-    `)
-    await page.keyboard.press('Backspace')
-    // Check for sketch 1
-    await scene.expectPixelColor([254, 254, 254], testPoint, 15)
-  })
-
-  await test.step('Delete sketch002', async () => {
-    await page.waitForTimeout(1000)
-    await clickOnSketch2()
-    await expect(page.locator('.cm-activeLine')).toHaveText(`
-      |> circle({ center = [0, 0], radius = 20 }, %)
-    `)
-    await page.keyboard.press('Backspace')
-    // Check for plane001
-    await scene.expectPixelColor([228, 228, 228], testPoint, 15)
-  })
-
-  await test.step('Delete plane001', async () => {
-    await page.waitForTimeout(1000)
-    await clickOnSketch2()
-    await expect(page.locator('.cm-activeLine')).toHaveText(`
-      plane001 = offsetPlane('XZ', 50)
-    `)
-    await page.keyboard.press('Backspace')
-    // Check for sketch 1
-    await scene.expectPixelColor([254, 254, 254], testPoint, 15)
-  })
-})
-
-test(`Sweep point-and-click`, async ({
-  context,
-  page,
-  homePage,
-  scene,
-  editor,
-  toolbar,
-  cmdBar,
-}) => {
-  const initialCode = `sketch001 = startSketchOn('YZ')
-  |> circle({
-       center = [0, 0],
-       radius = 500
-     }, %)
-sketch002 = startSketchOn('XZ')
-  |> startProfileAt([0, 0], %)
-  |> xLine(-500, %)
-  |> tangentialArcTo([-2000, 500], %)
-`
-  await context.addInitScript((initialCode) => {
-    localStorage.setItem('persistCode', initialCode)
-  }, initialCode)
-  await page.setBodyDimensions({ width: 1000, height: 500 })
-  await homePage.goToModelingScene()
-  await scene.waitForExecutionDone()
-
-  // One dumb hardcoded screen pixel value
-  const testPoint = { x: 700, y: 250 }
-  const [clickOnSketch1] = scene.makeMouseHelpers(testPoint.x, testPoint.y)
-  const [clickOnSketch2] = scene.makeMouseHelpers(testPoint.x - 50, testPoint.y)
-  const sweepDeclaration = 'sweep001 = sweep({ path = sketch002 }, sketch001)'
-
-  await test.step(`Look for sketch001`, async () => {
-    await toolbar.closePane('code')
-    await scene.expectPixelColor([53, 53, 53], testPoint, 15)
-  })
-
-  await test.step(`Go through the command bar flow`, async () => {
-    await toolbar.sweepButton.click()
-    await cmdBar.expectState({
-      commandName: 'Sweep',
-      currentArgKey: 'target',
-      currentArgValue: '',
-      headerArguments: {
-        Target: '',
-        Trajectory: '',
-      },
-      highlightedHeaderArg: 'target',
-      stage: 'arguments',
-    })
-    await clickOnSketch1()
-    await cmdBar.expectState({
-      commandName: 'Sweep',
-      currentArgKey: 'trajectory',
-      currentArgValue: '',
-      headerArguments: {
-        Target: '1 face',
-        Trajectory: '',
-      },
-      highlightedHeaderArg: 'trajectory',
-      stage: 'arguments',
-    })
-    await clickOnSketch2()
-    await page.waitForTimeout(500)
-    await cmdBar.progressCmdBar()
-    await page.waitForTimeout(500)
-  })
-
-  await test.step(`Confirm code is added to the editor, scene has changed`, async () => {
-    await scene.expectPixelColor([135, 64, 73], testPoint, 15)
-    await toolbar.openPane('code')
-    await editor.expectEditor.toContain(sweepDeclaration)
-    await editor.expectState({
-      diagnostics: [],
-      activeLines: [sweepDeclaration],
-      highlightedCode: '',
-    })
-    await toolbar.closePane('code')
-  })
-
-  await test.step('Delete sweep via feature tree selection', async () => {
-    await toolbar.openPane('feature-tree')
-    await page.waitForTimeout(500)
-    const operationButton = await toolbar.getFeatureTreeOperation('Sweep', 0)
-    await operationButton.click({ button: 'left' })
-    await page.keyboard.press('Backspace')
-    await page.waitForTimeout(500)
-    await toolbar.closePane('feature-tree')
-    await scene.expectPixelColor([53, 53, 53], testPoint, 15)
-  })
-})
-
-test(`Sweep point-and-click failing validation`, async ({
-  context,
-  page,
-  homePage,
-  scene,
-  toolbar,
-  cmdBar,
-}) => {
-  const initialCode = `sketch001 = startSketchOn('YZ')
-  |> circle({
-       center = [0, 0],
-       radius = 500
-     }, %)
-sketch002 = startSketchOn('XZ')
-  |> startProfileAt([0, 0], %)
-  |> xLine(-500, %)
-  |> lineTo([-2000, 500], %)
-`
-  await context.addInitScript((initialCode) => {
-    localStorage.setItem('persistCode', initialCode)
-  }, initialCode)
-  await page.setBodyDimensions({ width: 1000, height: 500 })
-  await homePage.goToModelingScene()
-  await scene.waitForExecutionDone()
-
-  // One dumb hardcoded screen pixel value
-  const testPoint = { x: 700, y: 250 }
-  const [clickOnSketch1] = scene.makeMouseHelpers(testPoint.x, testPoint.y)
-  const [clickOnSketch2] = scene.makeMouseHelpers(testPoint.x - 50, testPoint.y)
-
-  await test.step(`Look for sketch001`, async () => {
-    await toolbar.closePane('code')
-    await scene.expectPixelColor([53, 53, 53], testPoint, 15)
-  })
-
-  await test.step(`Go through the command bar flow and fail validation with a toast`, async () => {
-    await toolbar.sweepButton.click()
-    await cmdBar.expectState({
-      commandName: 'Sweep',
-      currentArgKey: 'target',
-      currentArgValue: '',
-      headerArguments: {
-        Target: '',
-        Trajectory: '',
-      },
-      highlightedHeaderArg: 'target',
-      stage: 'arguments',
-    })
-    await clickOnSketch1()
-    await cmdBar.expectState({
-      commandName: 'Sweep',
-      currentArgKey: 'trajectory',
-      currentArgValue: '',
-      headerArguments: {
-        Target: '1 face',
-        Trajectory: '',
-      },
-      highlightedHeaderArg: 'trajectory',
-      stage: 'arguments',
-    })
-    await clickOnSketch2()
-    await page.waitForTimeout(500)
-    await cmdBar.progressCmdBar()
-    await expect(
-      page.getByText('Unable to sweep with the provided selection')
-    ).toBeVisible()
-  })
-})
-
-test(`Fillet point-and-click`, async ({
-  context,
-  page,
-  homePage,
-  scene,
-  editor,
-  toolbar,
-  cmdBar,
-}) => {
-  // Code samples
-  const initialCode = `sketch001 = startSketchOn('XY')
-  |> startProfileAt([-12, -6], %)
-  |> line([0, 12], %)
-  |> line([24, 0], %)
-  |> line([0, -12], %)
-  |> lineTo([profileStartX(%), profileStartY(%)], %)
-  |> close(%)
-extrude001 = extrude(-12, sketch001)
-`
-  const firstFilletDeclaration = 'fillet({ radius = 5, tags = [seg01] }, %)'
-  const secondFilletDeclaration =
-    'fillet({       radius = 5,       tags = [getOppositeEdge(seg01)]     }, %)'
-
-  // Locators
-  const firstEdgeLocation = { x: 600, y: 193 }
-  const secondEdgeLocation = { x: 600, y: 383 }
-  const bodyLocation = { x: 630, y: 290 }
-  const [clickOnFirstEdge] = scene.makeMouseHelpers(
-    firstEdgeLocation.x,
-    firstEdgeLocation.y
-  )
-  const [clickOnSecondEdge] = scene.makeMouseHelpers(
-    secondEdgeLocation.x,
-    secondEdgeLocation.y
-  )
-
-  // Colors
-  const edgeColorWhite: [number, number, number] = [248, 248, 248]
-  const edgeColorYellow: [number, number, number] = [251, 251, 40] // Mac:B=67 Ubuntu:B=12
-  const bodyColor: [number, number, number] = [155, 155, 155]
-  const filletColor: [number, number, number] = [127, 127, 127]
-  const backgroundColor: [number, number, number] = [30, 30, 30]
-  const lowTolerance = 20
-  const highTolerance = 40
-
-  // Setup
-  await test.step(`Initial test setup`, async () => {
-    await context.addInitScript((initialCode) => {
-      localStorage.setItem('persistCode', initialCode)
-    }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
-    await homePage.goToModelingScene()
-
-    // verify modeling scene is loaded
-    await scene.expectPixelColor(
-      backgroundColor,
-      secondEdgeLocation,
-      lowTolerance
-    )
-
-    // wait for stream to load
-    await scene.expectPixelColor(bodyColor, bodyLocation, highTolerance)
-  })
-
-  // Test 1: Command bar flow with preselected edges
-  await test.step(`Select first edge`, async () => {
-    await scene.expectPixelColor(
-      edgeColorWhite,
-      firstEdgeLocation,
-      lowTolerance
-    )
-    await clickOnFirstEdge()
-    await scene.expectPixelColor(
-      edgeColorYellow,
-      firstEdgeLocation,
-      highTolerance // Ubuntu color mismatch can require high tolerance
-    )
-  })
-
-  await test.step(`Apply fillet to the preselected edge`, async () => {
-    await page.waitForTimeout(100)
-    await toolbar.filletButton.click()
-    await cmdBar.expectState({
-      commandName: 'Fillet',
-      highlightedHeaderArg: 'selection',
-      currentArgKey: 'selection',
-      currentArgValue: '',
-      headerArguments: {
-        Selection: '',
-        Radius: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Fillet',
-      highlightedHeaderArg: 'radius',
-      currentArgKey: 'radius',
-      currentArgValue: '5',
-      headerArguments: {
-        Selection: '1 face',
-        Radius: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Fillet',
-      headerArguments: {
-        Selection: '1 face',
-        Radius: '5',
-      },
-      stage: 'review',
-    })
-    await cmdBar.progressCmdBar()
-  })
-
-  await test.step(`Confirm code is added to the editor`, async () => {
-    await editor.expectEditor.toContain(firstFilletDeclaration)
-    await editor.expectState({
-      diagnostics: [],
-      activeLines: ['|>fillet({radius=5,tags=[seg01]},%)'],
-      highlightedCode: '',
-    })
-  })
-
-  await test.step(`Confirm scene has changed`, async () => {
-    await scene.expectPixelColor(filletColor, firstEdgeLocation, lowTolerance)
-  })
-
-  // Test 2: Command bar flow without preselected edges
-  await test.step(`Open fillet UI without selecting edges`, async () => {
-    await page.waitForTimeout(100)
-    await toolbar.filletButton.click()
-    await cmdBar.expectState({
-      stage: 'arguments',
-      currentArgKey: 'selection',
-      currentArgValue: '',
-      headerArguments: {
-        Selection: '',
-        Radius: '',
-      },
-      highlightedHeaderArg: 'selection',
-      commandName: 'Fillet',
-    })
-  })
-
-  await test.step(`Select second edge`, async () => {
-    await scene.expectPixelColor(
-      edgeColorWhite,
-      secondEdgeLocation,
-      lowTolerance
-    )
-    await clickOnSecondEdge()
-    await scene.expectPixelColor(
-      edgeColorYellow,
-      secondEdgeLocation,
-      highTolerance // Ubuntu color mismatch can require high tolerance
-    )
-  })
-
-  await test.step(`Apply fillet to the second edge`, async () => {
-    await cmdBar.expectState({
-      commandName: 'Fillet',
-      highlightedHeaderArg: 'selection',
-      currentArgKey: 'selection',
-      currentArgValue: '',
-      headerArguments: {
-        Selection: '',
-        Radius: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Fillet',
-      highlightedHeaderArg: 'radius',
-      currentArgKey: 'radius',
-      currentArgValue: '5',
-      headerArguments: {
-        Selection: '1 sweepEdge',
-        Radius: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Fillet',
-      headerArguments: {
-        Selection: '1 sweepEdge',
-        Radius: '5',
-      },
-      stage: 'review',
-    })
-    await cmdBar.progressCmdBar()
-  })
-
-  await test.step(`Confirm code is added to the editor`, async () => {
-    await editor.expectEditor.toContain(secondFilletDeclaration)
-    await editor.expectState({
-      diagnostics: [],
-      activeLines: ['radius=5,'],
-      highlightedCode: '',
-    })
-  })
-
-  await test.step(`Confirm scene has changed`, async () => {
-    await scene.expectPixelColor(
-      backgroundColor,
-      secondEdgeLocation,
-      lowTolerance
-    )
-  })
-})
-
-test(`Chamfer point-and-click`, async ({
-  context,
-  page,
-  homePage,
-  scene,
-  editor,
-  toolbar,
-  cmdBar,
-}) => {
-  // Code samples
-  const initialCode = `sketch001 = startSketchOn('XY')
-  |> startProfileAt([-12, -6], %)
-  |> line([0, 12], %)
-  |> line([24, 0], %)
-  |> line([0, -12], %)
-  |> lineTo([profileStartX(%), profileStartY(%)], %)
-  |> close(%)
-extrude001 = extrude(-12, sketch001)
-`
-  const firstChamferDeclaration = 'chamfer({ length = 5, tags = [seg01] }, %)'
-  const secondChamferDeclaration =
-    'chamfer({       length = 5,       tags = [getOppositeEdge(seg01)]     }, %)'
-
-  // Locators
-  const firstEdgeLocation = { x: 600, y: 193 }
-  const secondEdgeLocation = { x: 600, y: 383 }
-  const bodyLocation = { x: 630, y: 290 }
-  const [clickOnFirstEdge] = scene.makeMouseHelpers(
-    firstEdgeLocation.x,
-    firstEdgeLocation.y
-  )
-  const [clickOnSecondEdge] = scene.makeMouseHelpers(
-    secondEdgeLocation.x,
-    secondEdgeLocation.y
-  )
-
-  // Colors
-  const edgeColorWhite: [number, number, number] = [248, 248, 248]
-  const edgeColorYellow: [number, number, number] = [251, 251, 40] // Mac:B=67 Ubuntu:B=12
-  const bodyColor: [number, number, number] = [155, 155, 155]
-  const chamferColor: [number, number, number] = [168, 168, 168]
-  const backgroundColor: [number, number, number] = [30, 30, 30]
-  const lowTolerance = 20
-  const highTolerance = 40
-
-  // Setup
-  await test.step(`Initial test setup`, async () => {
-    await context.addInitScript((initialCode) => {
-      localStorage.setItem('persistCode', initialCode)
-    }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
-    await homePage.goToModelingScene()
-
-    // verify modeling scene is loaded
-    await scene.expectPixelColor(
-      backgroundColor,
-      secondEdgeLocation,
-      lowTolerance
-    )
-
-    // wait for stream to load
-    await scene.expectPixelColor(bodyColor, bodyLocation, highTolerance)
-  })
-
-  // Test 1: Command bar flow with preselected edges
-  await test.step(`Select first edge`, async () => {
-    await scene.expectPixelColor(
-      edgeColorWhite,
-      firstEdgeLocation,
-      lowTolerance
-    )
-    await clickOnFirstEdge()
-    await scene.expectPixelColor(
-      edgeColorYellow,
-      firstEdgeLocation,
-      highTolerance // Ubuntu color mismatch can require high tolerance
-    )
-  })
-
-  await test.step(`Apply chamfer to the preselected edge`, async () => {
-    await page.waitForTimeout(100)
-    await toolbar.chamferButton.click()
-    await cmdBar.expectState({
-      commandName: 'Chamfer',
-      highlightedHeaderArg: 'selection',
-      currentArgKey: 'selection',
-      currentArgValue: '',
-      headerArguments: {
-        Selection: '',
-        Length: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Chamfer',
-      highlightedHeaderArg: 'length',
-      currentArgKey: 'length',
-      currentArgValue: '5',
-      headerArguments: {
-        Selection: '1 face',
-        Length: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Chamfer',
-      headerArguments: {
-        Selection: '1 face',
-        Length: '5',
-      },
-      stage: 'review',
-    })
-    await cmdBar.progressCmdBar()
-  })
-
-  await test.step(`Confirm code is added to the editor`, async () => {
-    await editor.expectEditor.toContain(firstChamferDeclaration)
-    await editor.expectState({
-      diagnostics: [],
-      activeLines: ['|>chamfer({length=5,tags=[seg01]},%)'],
-      highlightedCode: '',
-    })
-  })
-
-  await test.step(`Confirm scene has changed`, async () => {
-    await scene.expectPixelColor(chamferColor, firstEdgeLocation, lowTolerance)
-  })
-
-  // Test 2: Command bar flow without preselected edges
-  await test.step(`Open chamfer UI without selecting edges`, async () => {
-    await page.waitForTimeout(100)
-    await toolbar.chamferButton.click()
-    await cmdBar.expectState({
-      stage: 'arguments',
-      currentArgKey: 'selection',
-      currentArgValue: '',
-      headerArguments: {
-        Selection: '',
-        Length: '',
-      },
-      highlightedHeaderArg: 'selection',
-      commandName: 'Chamfer',
-    })
-  })
-
-  await test.step(`Select second edge`, async () => {
-    await scene.expectPixelColor(
-      edgeColorWhite,
-      secondEdgeLocation,
-      lowTolerance
-    )
-    await clickOnSecondEdge()
-    await scene.expectPixelColor(
-      edgeColorYellow,
-      secondEdgeLocation,
-      highTolerance // Ubuntu color mismatch can require high tolerance
-    )
-  })
-
-  await test.step(`Apply chamfer to the second edge`, async () => {
-    await cmdBar.expectState({
-      commandName: 'Chamfer',
-      highlightedHeaderArg: 'selection',
-      currentArgKey: 'selection',
-      currentArgValue: '',
-      headerArguments: {
-        Selection: '',
-        Length: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Chamfer',
-      highlightedHeaderArg: 'length',
-      currentArgKey: 'length',
-      currentArgValue: '5',
-      headerArguments: {
-        Selection: '1 sweepEdge',
-        Length: '',
-      },
-      stage: 'arguments',
-    })
-    await cmdBar.progressCmdBar()
-    await cmdBar.expectState({
-      commandName: 'Chamfer',
-      headerArguments: {
-        Selection: '1 sweepEdge',
-        Length: '5',
-      },
-      stage: 'review',
-    })
-    await cmdBar.progressCmdBar()
-  })
-
-  await test.step(`Confirm code is added to the editor`, async () => {
-    await editor.expectEditor.toContain(secondChamferDeclaration)
-    await editor.expectState({
-      diagnostics: [],
-      activeLines: ['length=5,'],
-      highlightedCode: '',
-    })
-  })
-
-  await test.step(`Confirm scene has changed`, async () => {
-    await scene.expectPixelColor(
-      backgroundColor,
-      secondEdgeLocation,
-      lowTolerance
-    )
   })
 })
 
@@ -1566,7 +907,6 @@ shellPointAndClickCapCases.forEach(({ shouldPreselect }) => {
         await clickOnCap()
         await page.waitForTimeout(500)
         await cmdBar.progressCmdBar()
-        await page.waitForTimeout(500)
         await cmdBar.progressCmdBar()
         await cmdBar.expectState({
           stage: 'review',
@@ -1587,7 +927,6 @@ shellPointAndClickCapCases.forEach(({ shouldPreselect }) => {
       await test.step(`Go through the command bar flow with a preselected face (cap)`, async () => {
         await toolbar.shellButton.click()
         await cmdBar.progressCmdBar()
-        await page.waitForTimeout(500)
         await cmdBar.progressCmdBar()
         await cmdBar.expectState({
           stage: 'review',
@@ -1669,7 +1008,6 @@ extrude001 = extrude(40, sketch001)
     await page.waitForTimeout(500)
     await page.keyboard.up('Shift')
     await cmdBar.progressCmdBar()
-    await page.waitForTimeout(500)
     await cmdBar.progressCmdBar()
     await cmdBar.expectState({
       stage: 'review',
@@ -1692,162 +1030,4 @@ extrude001 = extrude(40, sketch001)
     })
     await scene.expectPixelColor([49, 49, 49], testPoint, 15)
   })
-
-  await test.step('Delete shell via feature tree selection', async () => {
-    await editor.closePane()
-    const operationButton = await toolbar.getFeatureTreeOperation('Shell', 0)
-    await operationButton.click({ button: 'left' })
-    await page.keyboard.press('Backspace')
-    await scene.expectPixelColor([99, 99, 99], testPoint, 15)
-  })
-})
-
-const shellSketchOnFacesCases = [
-  `sketch001 = startSketchOn('XZ')
-  |> circle({ center = [0, 0], radius = 100 }, %)
-  |> extrude(100, %)
-
-sketch002 = startSketchOn(sketch001, 'END')
-  |> circle({ center = [0, 0], radius = 50 }, %)
-  |> extrude(50, %)
-  `,
-  `sketch001 = startSketchOn('XZ')
-  |> circle({ center = [0, 0], radius = 100 }, %)
-extrude001 = extrude(100, sketch001)
-
-sketch002 = startSketchOn(extrude001, 'END')
-  |> circle({ center = [0, 0], radius = 50 }, %)
-extrude002 = extrude(50, sketch002)
-  `,
-]
-shellSketchOnFacesCases.forEach((initialCode, index) => {
-  const hasExtrudesInPipe = index === 0
-  test(`Shell point-and-click sketch on face (extrudes in pipes: ${hasExtrudesInPipe})`, async ({
-    context,
-    page,
-    homePage,
-    scene,
-    editor,
-    toolbar,
-    cmdBar,
-  }) => {
-    await context.addInitScript((initialCode) => {
-      localStorage.setItem('persistCode', initialCode)
-    }, initialCode)
-    await page.setBodyDimensions({ width: 1000, height: 500 })
-    await homePage.goToModelingScene()
-    await scene.waitForExecutionDone()
-
-    // One dumb hardcoded screen pixel value
-    const testPoint = { x: 550, y: 295 }
-    const [clickOnCap] = scene.makeMouseHelpers(testPoint.x, testPoint.y)
-    const shellDeclaration = `shell001 = shell({ faces = ['end'], thickness = 5 }, ${
-      hasExtrudesInPipe ? 'sketch002' : 'extrude002'
-    })`
-
-    await test.step(`Look for the grey of the shape`, async () => {
-      await toolbar.closePane('code')
-      await scene.expectPixelColor([128, 128, 128], testPoint, 15)
-    })
-
-    await test.step(`Go through the command bar flow, selecting a cap and keeping default thickness`, async () => {
-      await toolbar.shellButton.click()
-      await cmdBar.expectState({
-        stage: 'arguments',
-        currentArgKey: 'selection',
-        currentArgValue: '',
-        headerArguments: {
-          Selection: '',
-          Thickness: '',
-        },
-        highlightedHeaderArg: 'selection',
-        commandName: 'Shell',
-      })
-      await clickOnCap()
-      await page.waitForTimeout(500)
-      await cmdBar.progressCmdBar()
-      await page.waitForTimeout(500)
-      await cmdBar.progressCmdBar()
-      await page.waitForTimeout(500)
-      await cmdBar.expectState({
-        stage: 'review',
-        headerArguments: {
-          Selection: '1 cap',
-          Thickness: '5',
-        },
-        commandName: 'Shell',
-      })
-      await cmdBar.progressCmdBar()
-    })
-
-    await test.step(`Confirm code is added to the editor, scene has changed`, async () => {
-      await toolbar.openPane('code')
-      await editor.expectEditor.toContain(shellDeclaration)
-      await editor.expectState({
-        diagnostics: [],
-        activeLines: [shellDeclaration],
-        highlightedCode: '',
-      })
-      await toolbar.closePane('code')
-      await scene.expectPixelColor([73, 73, 73], testPoint, 15)
-    })
-  })
-})
-
-test(`Shell dry-run validation rejects sweeps`, async ({
-  context,
-  page,
-  homePage,
-  scene,
-  editor,
-  toolbar,
-  cmdBar,
-}) => {
-  const initialCode = `sketch001 = startSketchOn('YZ')
-  |> circle({
-       center = [0, 0],
-       radius = 500
-     }, %)
-sketch002 = startSketchOn('XZ')
-  |> startProfileAt([0, 0], %)
-  |> xLine(-2000, %)
-sweep001 = sweep({ path = sketch002 }, sketch001)
-`
-  await context.addInitScript((initialCode) => {
-    localStorage.setItem('persistCode', initialCode)
-  }, initialCode)
-  await page.setBodyDimensions({ width: 1000, height: 500 })
-  await homePage.goToModelingScene()
-  await scene.waitForExecutionDone()
-
-  // One dumb hardcoded screen pixel value
-  const testPoint = { x: 500, y: 250 }
-  const [clickOnSweep] = scene.makeMouseHelpers(testPoint.x, testPoint.y)
-
-  await test.step(`Confirm sweep exists`, async () => {
-    await toolbar.closePane('code')
-    await scene.expectPixelColor([231, 231, 231], testPoint, 15)
-  })
-
-  await test.step(`Go through the Shell flow and fail validation with a toast`, async () => {
-    await toolbar.shellButton.click()
-    await cmdBar.expectState({
-      stage: 'arguments',
-      currentArgKey: 'selection',
-      currentArgValue: '',
-      headerArguments: {
-        Selection: '',
-        Thickness: '',
-      },
-      highlightedHeaderArg: 'selection',
-      commandName: 'Shell',
-    })
-    await clickOnSweep()
-    await page.waitForTimeout(500)
-    await cmdBar.progressCmdBar()
-    await expect(
-      page.getByText('Unable to shell with the provided selection')
-    ).toBeVisible()
-    await page.waitForTimeout(1000)
-  })
 })

e2e/playwright/projects.spec.ts

@@ -115,7 +115,7 @@ test(
 )
 
 test(
-  'open a file in a project works and renders, open another file in different project with errors, it should clear the scene',
+  'yyyyyyyyy open a file in a project works and renders, open another file in different project with errors, it should clear the scene',
   { tag: '@electron' },
   async ({ context, page }, testInfo) => {
     await context.folderSetupFn(async (dir) => {
@@ -172,7 +172,7 @@ test(
       await expect(page.getByRole('link', { name: 'bracket' })).toBeVisible()
       await expect(page.getByText('broken-code')).toBeVisible()
       await expect(page.getByText('bracket')).toBeVisible()
-      await expect(page.getByText('Create project')).toBeVisible()
+      await expect(page.getByText('New Project')).toBeVisible()
     })
     await test.step('opening broken code project should clear the scene and show the error', async () => {
       // Go back home.
@@ -199,7 +199,7 @@ test(
 )
 
 test(
-  'open a file in a project works and renders, open another file in different project that is empty, it should clear the scene',
+  'aaayyyyyyyy open a file in a project works and renders, open another file in different project that is empty, it should clear the scene',
   { tag: '@electron' },
   async ({ context, page }, testInfo) => {
     await context.folderSetupFn(async (dir) => {
@@ -253,7 +253,7 @@ test(
       await expect(page.getByRole('link', { name: 'bracket' })).toBeVisible()
       await expect(page.getByText('empty')).toBeVisible()
       await expect(page.getByText('bracket')).toBeVisible()
-      await expect(page.getByText('Create project')).toBeVisible()
+      await expect(page.getByText('New Project')).toBeVisible()
     })
     await test.step('opening empty code project should clear the scene', async () => {
       // Go back home.
@@ -276,7 +276,7 @@ test(
 )
 
 test(
-  'open a file in a project works and renders, open empty file, it should clear the scene',
+  'nooooooooooooo open a file in a project works and renders, open empty file, it should clear the scene',
   { tag: '@electron' },
   async ({ context, page }, testInfo) => {
     await context.folderSetupFn(async (dir) => {
@@ -985,126 +985,6 @@ test.describe(`Project management commands`, () => {
       })
     }
   )
-  test(`Create a new project with a colliding name`, async ({
-    context,
-    homePage,
-    toolbar,
-    cmdBar,
-  }) => {
-    const projectName = 'test-project'
-    await test.step(`Setup`, async () => {
-      await context.folderSetupFn(async (dir) => {
-        const projectDir = path.join(dir, projectName)
-        await Promise.all([fsp.mkdir(projectDir, { recursive: true })])
-        await Promise.all([
-          fsp.copyFile(
-            executorInputPath('router-template-slate.kcl'),
-            path.join(projectDir, 'main.kcl')
-          ),
-        ])
-      })
-      await homePage.expectState({
-        projectCards: [
-          {
-            title: projectName,
-            fileCount: 1,
-          },
-        ],
-        sortBy: 'last-modified-desc',
-      })
-    })
-
-    await test.step('Create a new project with the same name', async () => {
-      await cmdBar.openCmdBar()
-      await cmdBar.chooseCommand('create project')
-      await cmdBar.expectState({
-        stage: 'arguments',
-        commandName: 'Create project',
-        currentArgKey: 'name',
-        currentArgValue: '',
-        headerArguments: {
-          Name: '',
-        },
-        highlightedHeaderArg: 'name',
-      })
-      await cmdBar.argumentInput.fill(projectName)
-      await cmdBar.progressCmdBar()
-    })
-
-    await test.step(`Check the project was created with a non-colliding name`, async () => {
-      await toolbar.logoLink.click()
-      await homePage.expectState({
-        projectCards: [
-          {
-            title: projectName + '-1',
-            fileCount: 1,
-          },
-          {
-            title: projectName,
-            fileCount: 1,
-          },
-        ],
-        sortBy: 'last-modified-desc',
-      })
-    })
-
-    await test.step('Create another project with the same name', async () => {
-      await cmdBar.openCmdBar()
-      await cmdBar.chooseCommand('create project')
-      await cmdBar.expectState({
-        stage: 'arguments',
-        commandName: 'Create project',
-        currentArgKey: 'name',
-        currentArgValue: '',
-        headerArguments: {
-          Name: '',
-        },
-        highlightedHeaderArg: 'name',
-      })
-      await cmdBar.argumentInput.fill(projectName)
-      await cmdBar.progressCmdBar()
-    })
-
-    await test.step(`Check the second project was created with a non-colliding name`, async () => {
-      await toolbar.logoLink.click()
-      await homePage.expectState({
-        projectCards: [
-          {
-            title: projectName + '-2',
-            fileCount: 1,
-          },
-          {
-            title: projectName + '-1',
-            fileCount: 1,
-          },
-          {
-            title: projectName,
-            fileCount: 1,
-          },
-        ],
-        sortBy: 'last-modified-desc',
-      })
-    })
-  })
-})
-
-test(`Create a few projects using the default project name`, async ({
-  homePage,
-  toolbar,
-}) => {
-  for (let i = 0; i < 12; i++) {
-    await test.step(`Create project ${i}`, async () => {
-      await homePage.expectState({
-        projectCards: Array.from({ length: i }, (_, i) => ({
-          title: `project-${i.toString().padStart(3, '0')}`,
-          fileCount: 1,
-        })).toReversed(),
-        sortBy: 'last-modified-desc',
-      })
-      await homePage.createAndGoToProject()
-      await toolbar.logoLink.click()
-    })
-  }
 })
 
 test(
@@ -1511,7 +1391,7 @@ extrude001 = extrude(200, sketch001)`)
     await page.getByTestId('app-logo').click()
 
     await expect(
-      page.getByRole('button', { name: 'Create project' })
+      page.getByRole('button', { name: 'New project' })
     ).toBeVisible()
 
     for (let i = 1; i <= 10; i++) {
@@ -1585,7 +1465,7 @@ test(
 
       await expect(page.getByRole('link', { name: 'bracket' })).toBeVisible()
       await expect(page.getByText('router-template-slate')).toBeVisible()
-      await expect(page.getByText('Create project')).toBeVisible()
+      await expect(page.getByText('New Project')).toBeVisible()
     })
 
     await test.step('Opening the router-template project should load the stream', async () => {
@@ -1614,7 +1494,7 @@ test(
 
       await expect(page.getByRole('link', { name: 'bracket' })).toBeVisible()
       await expect(page.getByText('router-template-slate')).toBeVisible()
-      await expect(page.getByText('Create project')).toBeVisible()
+      await expect(page.getByText('New Project')).toBeVisible()
     })
   }
 )
@@ -2005,48 +1885,3 @@ test.fixme(
     })
   }
 )
-
-test(
-  'project name with foreign characters should open',
-  { tag: '@electron' },
-  async ({ context, page }, testInfo) => {
-    await context.folderSetupFn(async (dir) => {
-      const bracketDir = path.join(dir, 'اَلْعَرَبِيَّةُ')
-      await fsp.mkdir(bracketDir, { recursive: true })
-      await fsp.copyFile(
-        executorInputPath('focusrite_scarlett_mounting_braket.kcl'),
-        path.join(bracketDir, 'main.kcl')
-      )
-
-      await fsp.writeFile(path.join(bracketDir, 'empty.kcl'), '')
-    })
-
-    await page.setBodyDimensions({ width: 1200, height: 500 })
-    const u = await getUtils(page)
-
-    page.on('console', console.log)
-
-    const pointOnModel = { x: 630, y: 280 }
-
-    await test.step('Opening the اَلْعَرَبِيَّةُ project should load the stream', async () => {
-      // expect to see the text bracket
-      await expect(page.getByText('اَلْعَرَبِيَّةُ')).toBeVisible()
-
-      await page.getByText('اَلْعَرَبِيَّةُ').click()
-
-      await expect(
-        page.getByRole('button', { name: 'Start Sketch' })
-      ).toBeEnabled({
-        timeout: 20_000,
-      })
-
-      // gray at this pixel means the stream has loaded in the most
-      // user way we can verify it (pixel color)
-      await expect
-        .poll(() => u.getGreatestPixDiff(pointOnModel, [85, 85, 85]), {
-          timeout: 10_000,
-        })
-        .toBeLessThan(15)
-    })
-  }
-)

e2e/playwright/regression-tests.spec.ts

@@ -614,38 +614,6 @@ extrude001 = extrude(50, sketch001)
       await expect(gizmo).toBeVisible()
     })
   })
-
-  test(`Refreshing the app doesn't cause the stream to pause on long-executing files`, async ({
-    context,
-    homePage,
-    scene,
-    toolbar,
-    viewport,
-  }) => {
-    await context.folderSetupFn(async (dir) => {
-      const legoDir = path.join(dir, 'lego')
-      await fsp.mkdir(legoDir, { recursive: true })
-      await fsp.copyFile(
-        executorInputPath('lego.kcl'),
-        path.join(legoDir, 'main.kcl')
-      )
-    })
-
-    await test.step(`Test setup`, async () => {
-      await homePage.openProject('lego')
-      await toolbar.closePane('code')
-    })
-    await test.step(`Waiting for the loading spinner to disappear`, async () => {
-      await scene.loadingIndicator.waitFor({ state: 'detached' })
-    })
-    await test.step(`The part should start loading quickly, not waiting until execution is complete`, async () => {
-      await scene.expectPixelColor(
-        [143, 143, 143],
-        { x: (viewport?.width ?? 1200) / 2, y: (viewport?.height ?? 500) / 2 },
-        15
-      )
-    })
-  })
 })
 
 async function clickExportButton(page: Page) {

e2e/playwright/sketch-tests.spec.ts

@@ -39,8 +39,8 @@ test.describe('Sketch tests', () => {
   ${startProfileAt1}
   |> arc({
         radius = screwRadius,
-        angleStart = 0,
+        angle_start = 0,
-        angleEnd = 360
+        angle_end = 360
       }, %)
   
     part001 = startSketchOn('XY')
@@ -60,8 +60,8 @@ test.describe('Sketch tests', () => {
   |> yLine(wireOffset, %)
   |> arc({
         radius = wireRadius,
-        angleStart = 0,
+        angle_start = 0,
-        angleEnd = 180
+        angle_end = 180
       }, %)
   |> yLine(-wireOffset, %)
   |> xLine(-width / 4, %)
@@ -1323,85 +1323,3 @@ test.describe(`Sketching with offset planes`, () => {
     })
   })
 })
-
-// Regression test for https://github.com/KittyCAD/modeling-app/issues/4891
-test.describe(`Click based selection don't brick the app when clicked out of range after format using cache`, () => {
-  test(`Can select a line that reformmed after entering sketch mode`, async ({
-    context,
-    page,
-    scene,
-    toolbar,
-    editor,
-    homePage,
-  }) => {
-    // We seed the scene with a single offset plane
-    await context.addInitScript(() => {
-      localStorage.setItem(
-        'persistCode',
-        `sketch001 = startSketchOn('XZ')
-  |> startProfileAt([0, 0], %)
-  |> line([3.14, 3.14], %)
-  |> arcTo({
-  end = [4, 2],
-  interior = [1, 2]
-  }, %)
-`
-      )
-    })
-
-    await homePage.goToModelingScene()
-    await scene.waitForExecutionDone()
-
-    await test.step(`format the code`, async () => {
-      // doesn't contain condensed version
-      await editor.expectEditor.not.toContain(
-        `arcTo({ end = [4, 2], interior = [1, 2] }, %)`
-      )
-      // click the code to enter sketch mode
-      await page.getByText(`arcTo`).click()
-      // Format the code.
-      await page.locator('#code-pane button:first-child').click()
-      await page.locator('button:has-text("Format code")').click()
-    })
-
-    await test.step(`Ensure the code reformatted`, async () => {
-      await editor.expectEditor.toContain(
-        `arcTo({ end = [4, 2], interior = [1, 2] }, %)`
-      )
-    })
-
-    const [arcClick, arcHover] = scene.makeMouseHelpers(699, 337)
-    await test.step('Ensure we can hover the arc', async () => {
-      await arcHover()
-
-      // Check that the code is highlighted
-      await editor.expectState({
-        activeLines: ["sketch001=startSketchOn('XZ')"],
-        diagnostics: [],
-        highlightedCode: 'arcTo({end = [4, 2], interior = [1, 2]}, %)',
-      })
-    })
-
-    await test.step('reset the selection', async () => {
-      // Move the mouse out of the way
-      await page.mouse.move(655, 337)
-
-      await editor.expectState({
-        activeLines: ["sketch001=startSketchOn('XZ')"],
-        diagnostics: [],
-        highlightedCode: '',
-      })
-    })
-
-    await test.step('Ensure we can click the arc', async () => {
-      await arcClick()
-
-      // Check that the code is highlighted
-      await editor.expectState({
-        activeLines: [],
-        diagnostics: [],
-        highlightedCode: 'arcTo({end = [4, 2], interior = [1, 2]}, %)',
-      })
-    })
-  })
-})

e2e/playwright/test-utils.ts

@@ -1078,7 +1078,7 @@ export async function createProject({
   returnHome?: boolean
 }) {
   await test.step(`Create project and navigate to it`, async () => {
-    await page.getByRole('button', { name: 'Create project' }).click()
+    await page.getByRole('button', { name: 'New project' }).click()
     await page.getByRole('textbox', { name: 'Name' }).fill(name)
     await page.getByRole('button', { name: 'Continue' }).click()