Cut release v0.21.1 (#2347 )

remove getExtrudeWallTransform (#2342 )
* remove getExtrudeWallTransform Signed-off-by: Jess Frazelle <github@jessfraz.com> * docs Signed-off-by: Jess Frazelle <github@jessfraz.com> --------- Signed-off-by: Jess Frazelle <github@jessfraz.com>
2024-05-13 10:05:29 -04:00 · 2024-05-10 17:28:14 -07:00 · 2024-05-10 23:51:54 +00:00 · 2024-05-10 19:02:11 -04:00 · 2024-05-10 22:30:40 +00:00
216 changed files with 790 additions and 1300 deletions
--- a/docs/kcl/angleToMatchLengthX.md
+++ b/docs/kcl/angleToMatchLengthX.md
--- a/docs/kcl/angleToMatchLengthY.md
+++ b/docs/kcl/angleToMatchLengthY.md
--- a/docs/kcl/angledLine.md
+++ b/docs/kcl/angledLine.md
--- a/docs/kcl/angledLineOfXLength.md
+++ b/docs/kcl/angledLineOfXLength.md
--- a/docs/kcl/angledLineOfYLength.md
+++ b/docs/kcl/angledLineOfYLength.md
--- a/docs/kcl/angledLineThatIntersects.md
+++ b/docs/kcl/angledLineThatIntersects.md
--- a/docs/kcl/angledLineToX.md
+++ b/docs/kcl/angledLineToX.md
--- a/docs/kcl/angledLineToY.md
+++ b/docs/kcl/angledLineToY.md
--- a/docs/kcl/arc.md
+++ b/docs/kcl/arc.md
--- a/docs/kcl/bezierCurve.md
+++ b/docs/kcl/bezierCurve.md
--- a/docs/kcl/close.md
+++ b/docs/kcl/close.md
--- a/docs/kcl/extrude.md
+++ b/docs/kcl/extrude.md
--- a/docs/kcl/fillet.md
+++ b/docs/kcl/fillet.md
--- a/docs/kcl/getEdge.md
+++ b/docs/kcl/getEdge.md
--- a/docs/kcl/getExtrudeWallTransform.md
+++ b/docs/kcl/getExtrudeWallTransform.md
--- a/docs/kcl/getNextAdjacentEdge.md
+++ b/docs/kcl/getNextAdjacentEdge.md
--- a/docs/kcl/getOppositeEdge.md
+++ b/docs/kcl/getOppositeEdge.md
--- a/docs/kcl/getPreviousAdjacentEdge.md
+++ b/docs/kcl/getPreviousAdjacentEdge.md
--- a/docs/kcl/helix.md
+++ b/docs/kcl/helix.md
--- a/docs/kcl/hole.md
+++ b/docs/kcl/hole.md
--- a/docs/kcl/index.md
+++ b/docs/kcl/index.md
@ -31,7 +31,6 @@ layout: manual
 * [`fillet`](kcl/fillet)
 * [`floor`](kcl/floor)
 * [`getEdge`](kcl/getEdge)
 * [`getExtrudeWallTransform`](kcl/getExtrudeWallTransform)
 * [`getNextAdjacentEdge`](kcl/getNextAdjacentEdge)
 * [`getOppositeEdge`](kcl/getOppositeEdge)
 * [`getPreviousAdjacentEdge`](kcl/getPreviousAdjacentEdge)
--- a/docs/kcl/lastSegX.md
+++ b/docs/kcl/lastSegX.md
--- a/docs/kcl/lastSegY.md
+++ b/docs/kcl/lastSegY.md
--- a/docs/kcl/line.md
+++ b/docs/kcl/line.md
--- a/docs/kcl/lineTo.md
+++ b/docs/kcl/lineTo.md
--- a/docs/kcl/patternCircular2d.md
+++ b/docs/kcl/patternCircular2d.md
--- a/docs/kcl/patternCircular3d.md
+++ b/docs/kcl/patternCircular3d.md
--- a/docs/kcl/patternLinear2d.md
+++ b/docs/kcl/patternLinear2d.md
--- a/docs/kcl/patternLinear3d.md
+++ b/docs/kcl/patternLinear3d.md
--- a/docs/kcl/revolve.md
+++ b/docs/kcl/revolve.md
--- a/docs/kcl/segAng.md
+++ b/docs/kcl/segAng.md
--- a/docs/kcl/segEndX.md
+++ b/docs/kcl/segEndX.md
--- a/docs/kcl/segEndY.md
+++ b/docs/kcl/segEndY.md
--- a/docs/kcl/segLen.md
+++ b/docs/kcl/segLen.md
--- a/docs/kcl/startProfileAt.md
+++ b/docs/kcl/startProfileAt.md
--- a/docs/kcl/startSketchAt.md
+++ b/docs/kcl/startSketchAt.md
--- a/docs/kcl/startSketchOn.md
+++ b/docs/kcl/startSketchOn.md
--- a/docs/kcl/std.json
+++ b/docs/kcl/std.json
@ -28338,839 +28338,6 @@
      "const box = startSketchOn('XY')\n  |> startProfileAt([0, 0], %)\n  |> line([0, 10], %)\n  |> line([10, 0], %)\n  |> line([0, -10], %, 'revolveAxis')\n  |> close(%)\n  |> extrude(10, %)\n\nconst sketch001 = startSketchOn('XY')\n  |> startProfileAt([0, -10], %)\n  |> line([0, -10], %)\n  |> line([2, 0], %)\n  |> line([0, 10], %)\n  |> close(%)\n  |> revolve({\n       axis: getEdge('revolveAxis', box),\n       angle: 90\n     }, %)"
    ]
  },
  {
    "name": "getExtrudeWallTransform",
    "summary": "Returns the extrude wall transform.",
    "description": "",
    "tags": [],
    "args": [
      {
        "name": "surface_name",
        "type": "string",
        "schema": {
          "type": "string"
        },
        "required": true
      },
      {
        "name": "extrude_group",
        "type": "ExtrudeGroup",
        "schema": {
          "description": "An extrude group is a collection of extrude surfaces.",
          "type": "object",
          "required": [
            "__meta",
            "height",
            "id",
            "position",
            "rotation",
            "sketchGroupValues",
            "value",
            "xAxis",
            "yAxis",
            "zAxis"
          ],
          "properties": {
            "__meta": {
              "description": "Metadata.",
              "type": "array",
              "items": {
                "description": "Metadata.",
                "type": "object",
                "required": [
                  "sourceRange"
                ],
                "properties": {
                  "sourceRange": {
                    "description": "The source range.",
                    "type": "array",
                    "items": {
                      "type": "integer",
                      "format": "uint",
                      "minimum": 0.0
                    },
                    "maxItems": 2,
                    "minItems": 2
                  }
                }
              }
            },
            "endCapId": {
              "description": "The id of the extrusion end cap",
              "type": "string",
              "format": "uuid",
              "nullable": true
            },
            "height": {
              "description": "The height of the extrude group.",
              "type": "number",
              "format": "double"
            },
            "id": {
              "description": "The id of the extrude group.",
              "type": "string",
              "format": "uuid"
            },
            "position": {
              "description": "The position of the extrude group.",
              "type": "array",
              "items": {
                "type": "number",
                "format": "double"
              },
              "maxItems": 3,
              "minItems": 3
            },
            "rotation": {
              "description": "The rotation of the extrude group.",
              "type": "array",
              "items": {
                "type": "number",
                "format": "double"
              },
              "maxItems": 4,
              "minItems": 4
            },
            "sketchGroupValues": {
              "description": "The sketch group paths.",
              "type": "array",
              "items": {
                "description": "A path.",
                "oneOf": [
                  {
                    "description": "A path that goes to a point.",
                    "type": "object",
                    "required": [
                      "__geoMeta",
                      "from",
                      "name",
                      "to",
                      "type"
                    ],
                    "properties": {
                      "__geoMeta": {
                        "description": "Metadata.",
                        "type": "object",
                        "required": [
                          "id",
                          "sourceRange"
                        ],
                        "properties": {
                          "id": {
                            "description": "The id of the geometry.",
                            "type": "string",
                            "format": "uuid"
                          },
                          "sourceRange": {
                            "description": "The source range.",
                            "type": "array",
                            "items": {
                              "type": "integer",
                              "format": "uint",
                              "minimum": 0.0
                            },
                            "maxItems": 2,
                            "minItems": 2
                          }
                        }
                      },
                      "from": {
                        "description": "The from point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "name": {
                        "description": "The name of the path.",
                        "type": "string"
                      },
                      "to": {
                        "description": "The to point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "ToPoint"
                        ]
                      }
                    }
                  },
                  {
                    "description": "A arc that is tangential to the last path segment that goes to a point",
                    "type": "object",
                    "required": [
                      "__geoMeta",
                      "ccw",
                      "center",
                      "from",
                      "name",
                      "to",
                      "type"
                    ],
                    "properties": {
                      "__geoMeta": {
                        "description": "Metadata.",
                        "type": "object",
                        "required": [
                          "id",
                          "sourceRange"
                        ],
                        "properties": {
                          "id": {
                            "description": "The id of the geometry.",
                            "type": "string",
                            "format": "uuid"
                          },
                          "sourceRange": {
                            "description": "The source range.",
                            "type": "array",
                            "items": {
                              "type": "integer",
                              "format": "uint",
                              "minimum": 0.0
                            },
                            "maxItems": 2,
                            "minItems": 2
                          }
                        }
                      },
                      "ccw": {
                        "description": "arc's direction",
                        "type": "boolean"
                      },
                      "center": {
                        "description": "the arc's center",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "from": {
                        "description": "The from point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "name": {
                        "description": "The name of the path.",
                        "type": "string"
                      },
                      "to": {
                        "description": "The to point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "TangentialArcTo"
                        ]
                      }
                    }
                  },
                  {
                    "description": "A arc that is tangential to the last path segment",
                    "type": "object",
                    "required": [
                      "__geoMeta",
                      "from",
                      "name",
                      "to",
                      "type"
                    ],
                    "properties": {
                      "__geoMeta": {
                        "description": "Metadata.",
                        "type": "object",
                        "required": [
                          "id",
                          "sourceRange"
                        ],
                        "properties": {
                          "id": {
                            "description": "The id of the geometry.",
                            "type": "string",
                            "format": "uuid"
                          },
                          "sourceRange": {
                            "description": "The source range.",
                            "type": "array",
                            "items": {
                              "type": "integer",
                              "format": "uint",
                              "minimum": 0.0
                            },
                            "maxItems": 2,
                            "minItems": 2
                          }
                        }
                      },
                      "from": {
                        "description": "The from point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "name": {
                        "description": "The name of the path.",
                        "type": "string"
                      },
                      "to": {
                        "description": "The to point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "TangentialArc"
                        ]
                      }
                    }
                  },
                  {
                    "description": "A path that is horizontal.",
                    "type": "object",
                    "required": [
                      "__geoMeta",
                      "from",
                      "name",
                      "to",
                      "type",
                      "x"
                    ],
                    "properties": {
                      "__geoMeta": {
                        "description": "Metadata.",
                        "type": "object",
                        "required": [
                          "id",
                          "sourceRange"
                        ],
                        "properties": {
                          "id": {
                            "description": "The id of the geometry.",
                            "type": "string",
                            "format": "uuid"
                          },
                          "sourceRange": {
                            "description": "The source range.",
                            "type": "array",
                            "items": {
                              "type": "integer",
                              "format": "uint",
                              "minimum": 0.0
                            },
                            "maxItems": 2,
                            "minItems": 2
                          }
                        }
                      },
                      "from": {
                        "description": "The from point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "name": {
                        "description": "The name of the path.",
                        "type": "string"
                      },
                      "to": {
                        "description": "The to point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "Horizontal"
                        ]
                      },
                      "x": {
                        "description": "The x coordinate.",
                        "type": "number",
                        "format": "double"
                      }
                    }
                  },
                  {
                    "description": "An angled line to.",
                    "type": "object",
                    "required": [
                      "__geoMeta",
                      "from",
                      "name",
                      "to",
                      "type"
                    ],
                    "properties": {
                      "__geoMeta": {
                        "description": "Metadata.",
                        "type": "object",
                        "required": [
                          "id",
                          "sourceRange"
                        ],
                        "properties": {
                          "id": {
                            "description": "The id of the geometry.",
                            "type": "string",
                            "format": "uuid"
                          },
                          "sourceRange": {
                            "description": "The source range.",
                            "type": "array",
                            "items": {
                              "type": "integer",
                              "format": "uint",
                              "minimum": 0.0
                            },
                            "maxItems": 2,
                            "minItems": 2
                          }
                        }
                      },
                      "from": {
                        "description": "The from point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "name": {
                        "description": "The name of the path.",
                        "type": "string"
                      },
                      "to": {
                        "description": "The to point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "AngledLineTo"
                        ]
                      },
                      "x": {
                        "description": "The x coordinate.",
                        "type": "number",
                        "format": "double",
                        "nullable": true
                      },
                      "y": {
                        "description": "The y coordinate.",
                        "type": "number",
                        "format": "double",
                        "nullable": true
                      }
                    }
                  },
                  {
                    "description": "A base path.",
                    "type": "object",
                    "required": [
                      "__geoMeta",
                      "from",
                      "name",
                      "to",
                      "type"
                    ],
                    "properties": {
                      "__geoMeta": {
                        "description": "Metadata.",
                        "type": "object",
                        "required": [
                          "id",
                          "sourceRange"
                        ],
                        "properties": {
                          "id": {
                            "description": "The id of the geometry.",
                            "type": "string",
                            "format": "uuid"
                          },
                          "sourceRange": {
                            "description": "The source range.",
                            "type": "array",
                            "items": {
                              "type": "integer",
                              "format": "uint",
                              "minimum": 0.0
                            },
                            "maxItems": 2,
                            "minItems": 2
                          }
                        }
                      },
                      "from": {
                        "description": "The from point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "name": {
                        "description": "The name of the path.",
                        "type": "string"
                      },
                      "to": {
                        "description": "The to point.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "Base"
                        ]
                      }
                    }
                  }
                ]
              }
            },
            "startCapId": {
              "description": "The id of the extrusion start cap",
              "type": "string",
              "format": "uuid",
              "nullable": true
            },
            "value": {
              "description": "The extrude surfaces.",
              "type": "array",
              "items": {
                "description": "An extrude surface.",
                "oneOf": [
                  {
                    "description": "An extrude plane.",
                    "type": "object",
                    "required": [
                      "faceId",
                      "id",
                      "name",
                      "position",
                      "rotation",
                      "sourceRange",
                      "type"
                    ],
                    "properties": {
                      "faceId": {
                        "description": "The face id for the extrude plane.",
                        "type": "string",
                        "format": "uuid"
                      },
                      "id": {
                        "description": "The id of the geometry.",
                        "type": "string",
                        "format": "uuid"
                      },
                      "name": {
                        "description": "The name.",
                        "type": "string"
                      },
                      "position": {
                        "description": "The position.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 3,
                        "minItems": 3
                      },
                      "rotation": {
                        "description": "The rotation.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 4,
                        "minItems": 4
                      },
                      "sourceRange": {
                        "description": "The source range.",
                        "type": "array",
                        "items": {
                          "type": "integer",
                          "format": "uint",
                          "minimum": 0.0
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "extrudePlane"
                        ]
                      }
                    }
                  },
                  {
                    "description": "An extruded arc.",
                    "type": "object",
                    "required": [
                      "faceId",
                      "id",
                      "name",
                      "position",
                      "rotation",
                      "sourceRange",
                      "type"
                    ],
                    "properties": {
                      "faceId": {
                        "description": "The face id for the extrude plane.",
                        "type": "string",
                        "format": "uuid"
                      },
                      "id": {
                        "description": "The id of the geometry.",
                        "type": "string",
                        "format": "uuid"
                      },
                      "name": {
                        "description": "The name.",
                        "type": "string"
                      },
                      "position": {
                        "description": "The position.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 3,
                        "minItems": 3
                      },
                      "rotation": {
                        "description": "The rotation.",
                        "type": "array",
                        "items": {
                          "type": "number",
                          "format": "double"
                        },
                        "maxItems": 4,
                        "minItems": 4
                      },
                      "sourceRange": {
                        "description": "The source range.",
                        "type": "array",
                        "items": {
                          "type": "integer",
                          "format": "uint",
                          "minimum": 0.0
                        },
                        "maxItems": 2,
                        "minItems": 2
                      },
                      "type": {
                        "type": "string",
                        "enum": [
                          "extrudeArc"
                        ]
                      }
                    }
                  }
                ]
              }
            },
            "xAxis": {
              "description": "The x-axis of the extrude group base plane in the 3D space",
              "type": "object",
              "required": [
                "x",
                "y",
                "z"
              ],
              "properties": {
                "x": {
                  "type": "number",
                  "format": "double"
                },
                "y": {
                  "type": "number",
                  "format": "double"
                },
                "z": {
                  "type": "number",
                  "format": "double"
                }
              }
            },
            "yAxis": {
              "description": "The y-axis of the extrude group base plane in the 3D space",
              "type": "object",
              "required": [
                "x",
                "y",
                "z"
              ],
              "properties": {
                "x": {
                  "type": "number",
                  "format": "double"
                },
                "y": {
                  "type": "number",
                  "format": "double"
                },
                "z": {
                  "type": "number",
                  "format": "double"
                }
              }
            },
            "zAxis": {
              "description": "The z-axis of the extrude group base plane in the 3D space",
              "type": "object",
              "required": [
                "x",
                "y",
                "z"
              ],
              "properties": {
                "x": {
                  "type": "number",
                  "format": "double"
                },
                "y": {
                  "type": "number",
                  "format": "double"
                },
                "z": {
                  "type": "number",
                  "format": "double"
                }
              }
            }
          }
        },
        "required": true
      }
    ],
    "returnValue": {
      "name": "",
      "type": "ExtrudeTransform",
      "schema": {
        "type": "object",
        "required": [
          "__meta",
          "position",
          "rotation"
        ],
        "properties": {
          "__meta": {
            "type": "array",
            "items": {
              "description": "Metadata.",
              "type": "object",
              "required": [
                "sourceRange"
              ],
              "properties": {
                "sourceRange": {
                  "description": "The source range.",
                  "type": "array",
                  "items": {
                    "type": "integer",
                    "format": "uint",
                    "minimum": 0.0
                  },
                  "maxItems": 2,
                  "minItems": 2
                }
              }
            }
          },
          "position": {
            "type": "array",
            "items": {
              "type": "number",
              "format": "double"
            },
            "maxItems": 3,
            "minItems": 3
          },
          "rotation": {
            "type": "array",
            "items": {
              "type": "number",
              "format": "double"
            },
            "maxItems": 4,
            "minItems": 4
          }
        }
      },
      "required": true
    },
    "unpublished": false,
    "deprecated": false,
    "examples": [
      "const box = startSketchOn('XY')\n  |> startProfileAt([0, 0], %)\n  |> line([0, 10], %)\n  |> line([10, 0], %)\n  |> line([0, -10], %, \"surface\")\n  |> close(%)\n  |> extrude(5, %)\n\nconst transform = getExtrudeWallTransform('surface', box)"
    ]
  },
  {
    "name": "getNextAdjacentEdge",
    "summary": "Get the next adjacent edge to the edge given.",
--- a/docs/kcl/tangentialArc.md
+++ b/docs/kcl/tangentialArc.md
--- a/docs/kcl/tangentialArcTo.md
+++ b/docs/kcl/tangentialArcTo.md
--- a/docs/kcl/xLine.md
+++ b/docs/kcl/xLine.md
--- a/docs/kcl/xLineTo.md
+++ b/docs/kcl/xLineTo.md
--- a/docs/kcl/yLine.md
+++ b/docs/kcl/yLine.md
--- a/docs/kcl/yLineTo.md
+++ b/docs/kcl/yLineTo.md
--- a/e2e/playwright/flow-tests.spec.ts
+++ b/e2e/playwright/flow-tests.spec.ts
@ -131,6 +131,7 @@ test('Basic sketch', async ({ page }) => {
  // selected two lines therefore there should be two cursors
  await expect(page.locator('.cm-cursor')).toHaveCount(2)
  await page.getByRole('button', { name: 'Constrain' }).click()
  await page.getByRole('button', { name: 'Equal Length' }).click()
  await expect(page.locator('.cm-content'))
@ -264,6 +265,88 @@ test('Can moving camera', async ({ page, context }) => {
  }, [1, -94, -94])
 })
 test('if you click the format button it formats your code', async ({
  page,
 }) => {
  const u = getUtils(page)
  await page.setViewportSize({ width: 1000, height: 500 })
  await page.goto('/')
  await u.waitForAuthSkipAppStart()
  // check no error to begin with
  await expect(page.locator('.cm-lint-marker-error')).not.toBeVisible()
  await page.click('.cm-content')
  await page.keyboard.type(`const part001 = startSketchOn('XY')
 |> startProfileAt([-10, -10], %)
 |> line([20, 0], %)
 |> line([0, 20], %)
 |> line([-20, 0], %)
 |> close(%)`)
  await page.click('#code-pane button:first-child')
  await page.click('button:has-text("Format code")')
  await expect(page.locator('.cm-content'))
    .toHaveText(`const part001 = startSketchOn('XY')
  |> startProfileAt([-10, -10], %)
  |> line([20, 0], %)
  |> line([0, 20], %)
  |> line([-20, 0], %)
  |> close(%)`)
 })
 test('if you use the format keyboard binding it formats your code', async ({
  page,
 }) => {
  const u = getUtils(page)
  await page.addInitScript(async () => {
    localStorage.setItem(
      'persistCode',
      `const part001 = startSketchOn('XY')
 |> startProfileAt([-10, -10], %)
 |> line([20, 0], %)
 |> line([0, 20], %)
 |> line([-20, 0], %)
 |> close(%)`
    )
  })
  await page.setViewportSize({ width: 1000, height: 500 })
  const lspStartPromise = page.waitForEvent('console', async (message) => {
    // it would be better to wait for a message that the kcl lsp has started by looking for the message  message.text().includes('[lsp] [window/logMessage]')
    // but that doesn't seem to make it to the console for macos/safari :(
    if (message.text().includes('start kcl lsp')) {
      await new Promise((resolve) => setTimeout(resolve, 200))
      return true
    }
    return false
  })
  await page.goto('/')
  await u.waitForAuthSkipAppStart()
  await lspStartPromise
  // check no error to begin with
  await expect(page.locator('.cm-lint-marker-error')).not.toBeVisible()
  await u.openDebugPanel()
  await u.expectCmdLog('[data-message-type="execution-done"]')
  await u.closeDebugPanel()
  // focus the editor
  await page.click('.cm-line')
  // Hit alt+shift+f to format the code
  await page.keyboard.press('Alt+Shift+KeyF')
  await expect(page.locator('.cm-content'))
    .toHaveText(`const part001 = startSketchOn('XY')
  |> startProfileAt([-10, -10], %)
  |> line([20, 0], %)
  |> line([0, 20], %)
  |> line([-20, 0], %)
  |> close(%)`)
 })
 test('if you write invalid kcl you get inlined errors', async ({ page }) => {
  const u = getUtils(page)
  await page.setViewportSize({ width: 1000, height: 500 })
@ -529,10 +612,6 @@ test.describe('Can create sketches on all planes and their back sides', () => {
 })
 test('Auto complete works', async ({ page }) => {
  test.skip(
    true,
    'CORS issue stopping the kcl lsp from working, enable again later'
  )
  const u = getUtils(page)
  // const PUR = 400 / 37.5 //pixeltoUnitRatio
  await page.setViewportSize({ width: 1200, height: 500 })
@ -862,11 +941,14 @@ test('Selections work on fresh and edited sketch', async ({ page }) => {
    // click a segment hold shift and click an axis, see that a relevant constraint is enabled
    await topHorzSegmentClick()
    await page.keyboard.down('Shift')
    const constrainButton = page.getByRole('button', { name: 'Constrain' })
    const absYButton = page.getByRole('button', { name: 'ABS Y' })
    await constrainButton.click()
    await expect(absYButton).toBeDisabled()
    await page.waitForTimeout(100)
    await xAxisClick()
    await page.keyboard.up('Shift')
    await constrainButton.click()
    await absYButton.and(page.locator(':not([disabled])')).waitFor()
    await expect(absYButton).not.toBeDisabled()
@ -876,12 +958,14 @@ test('Selections work on fresh and edited sketch', async ({ page }) => {
    await page.waitForTimeout(100)
    // same selection but click the axis first
    await xAxisClick()
    await constrainButton.click()
    await expect(absYButton).toBeDisabled()
    await page.keyboard.down('Shift')
    await page.waitForTimeout(100)
    await topHorzSegmentClick()
    await page.keyboard.up('Shift')
    await constrainButton.click()
    await expect(absYButton).not.toBeDisabled()
    // clear selection by clicking on nothing
@ -890,10 +974,12 @@ test('Selections work on fresh and edited sketch', async ({ page }) => {
    // check the same selection again by putting cursor in code first then selecting axis
    await page.getByText(`  |> line([-${commonPoints.num2}, 0], %)`).click()
    await page.keyboard.down('Shift')
    await constrainButton.click()
    await expect(absYButton).toBeDisabled()
    await page.waitForTimeout(100)
    await xAxisClick()
    await page.keyboard.up('Shift')
    await constrainButton.click()
    await expect(absYButton).not.toBeDisabled()
    // clear selection by clicking on nothing
@ -1827,6 +1913,7 @@ test('Can code mod a line length', async ({ page }) => {
  const startXPx = 500
  await page.mouse.move(startXPx + PUR * 15, 250 - PUR * 10)
  await page.mouse.click(615, 102)
  await page.getByRole('button', { name: 'Constrain', exact: true }).click()
  await page.getByRole('button', { name: 'length', exact: true }).click()
  await page.getByText('Add constraining value').click()
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Inch-scale-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Inch-scale-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Inch-scale-2-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Inch-scale-2-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Millimeter-scale-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Millimeter-scale-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Millimeter-scale-2-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Client-side-scene-scale-should-match-engine-scale-Millimeter-scale-2-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Draft-rectangles-should-look-right-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Draft-rectangles-should-look-right-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Draft-segments-should-look-right-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Draft-segments-should-look-right-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Draft-segments-should-look-right-2-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Draft-segments-should-look-right-2-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/Sketch-on-face-with-none-z-up-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/Sketch-on-face-with-none-z-up-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable--XY-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable--XY-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable--XZ-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable--XZ-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable--YZ-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable--YZ-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable-XY-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable-XY-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable-XZ-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable-XZ-1-Google-Chrome-linux.png
--- a/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable-YZ-1-Google-Chrome-linux.png
+++ b/e2e/playwright/snapshot-tests.spec.ts-snapshots/extrude-on-default-planes-should-be-stable-YZ-1-Google-Chrome-linux.png
--- a/package.json
+++ b/package.json
@ -1,6 +1,6 @@
 {
  "name": "untitled-app",
-  "version": "0.21.0",
+  "version": "0.21.1",
  "private": true,
  "dependencies": {
    "@codemirror/autocomplete": "^6.16.0",
--- a/src-tauri/tauri.conf.json
+++ b/src-tauri/tauri.conf.json
@ -74,5 +74,5 @@
    }
  },
  "productName": "Zoo Modeling App",
-  "version": "0.21.0"
+  "version": "0.21.1"
 }
--- a/src/Toolbar.tsx
+++ b/src/Toolbar.tsx
@ -11,17 +11,18 @@ import {
  useNetworkStatus,
 } from 'components/NetworkHealthIndicator'
 import { useStore } from 'useStore'
 import { ActionButtonDropdown } from 'components/ActionButtonDropdown'
 export const Toolbar = () => {
  const { commandBarSend } = useCommandsContext()
  const { state, send, context } = useModelingContext()
  const toolbarButtonsRef = useRef<HTMLUListElement>(null)
  const iconClassName =
-    'group-disabled:text-chalkboard-50 group-enabled:group-hover:!text-chalkboard-10 group-pressed:!text-chalkboard-10'
+    'group-disabled:text-chalkboard-50 group-enabled:group-hover:!text-primary dark:group-enabled:group-hover:!text-inherit group-pressed:!text-chalkboard-10 group-ui-open:!text-chalkboard-10 dark:group-ui-open:!text-chalkboard-10'
  const bgClassName =
-    'group-disabled:!bg-transparent group-enabled:group-hover:bg-primary group-pressed:bg-primary'
+    'group-disabled:!bg-transparent group-enabled:group-hover:bg-primary/10 dark:group-enabled:group-hover:bg-primary group-pressed:bg-primary group-ui-open:bg-primary'
  const buttonClassName =
-    'bg-chalkboard-10 dark:bg-chalkboard-100 hover:bg-chalkboard-10 dark:hover:bg-chalkboard-100'
+    'bg-chalkboard-10 dark:bg-chalkboard-100 enabled:hover:bg-chalkboard-10 dark:enabled:hover:bg-chalkboard-100 pressed:!border-primary ui-open:!border-primary'
  const pathId = useMemo(() => {
    if (!isSingleCursorInPipe(context.selectionRanges, kclManager.ast)) {
      return false
@ -57,10 +58,7 @@ export const Toolbar = () => {
        {...props}
        ref={toolbarButtonsRef}
        onWheel={handleToolbarButtonsWheelEvent}
-        className={
+        className={'m-0 py-1 rounded-l-sm flex gap-2 items-center ' + className}
          'm-0 py-1 rounded-l-sm flex gap-2 items-center overflow-x-auto ' +
          className
        }
        style={{ scrollbarWidth: 'thin' }}
      >
        {state.nextEvents.includes('Enter sketch') && (
@ -71,7 +69,7 @@ export const Toolbar = () => {
              onClick={() =>
                send({ type: 'Enter sketch', data: { forceNewSketch: true } })
              }
-              icon={{
+              iconStart={{
                icon: 'sketch',
                iconClassName,
                bgClassName,
@ -88,7 +86,7 @@ export const Toolbar = () => {
              className={buttonClassName}
              Element="button"
              onClick={() => send({ type: 'Enter sketch' })}
-              icon={{
+              iconStart={{
                icon: 'sketch',
                iconClassName,
                bgClassName,
@ -105,7 +103,7 @@ export const Toolbar = () => {
              className={buttonClassName}
              Element="button"
              onClick={() => send({ type: 'Cancel' })}
-              icon={{
+              iconStart={{
                icon: 'arrowLeft',
                iconClassName,
                bgClassName,
@ -128,7 +126,7 @@ export const Toolbar = () => {
                    : send('Equip Line tool')
                }
                aria-pressed={state?.matches('Sketch.Line tool')}
-                icon={{
+                iconStart={{
                  icon: 'line',
                  iconClassName,
                  bgClassName,
@ -148,7 +146,7 @@ export const Toolbar = () => {
                    : send('Equip tangential arc to')
                }
                aria-pressed={state.matches('Sketch.Tangential arc to')}
-                icon={{
+                iconStart={{
                  icon: 'arc',
                  iconClassName,
                  bgClassName,
@ -172,7 +170,7 @@ export const Toolbar = () => {
                    : send('Equip rectangle tool')
                }
                aria-pressed={state.matches('Sketch.Rectangle tool')}
-                icon={{
+                iconStart={{
                  icon: 'rectangle',
                  iconClassName,
                  bgClassName,
@ -194,52 +192,54 @@ export const Toolbar = () => {
          </>
        )}
        {state.matches('Sketch.SketchIdle') &&
-          state.nextEvents
+          state.nextEvents.filter(
-            .filter(
+            (eventName) =>
-              (eventName) =>
+              eventName.includes('Make segment') ||
-                eventName.includes('Make segment') ||
+              eventName.includes('Constrain')
-                eventName.includes('Constrain')
+          ).length > 0 && (
-            )
+            <ActionButtonDropdown
-            .sort((a, b) => {
+              splitMenuItems={state.nextEvents
-              const aisEnabled = state.nextEvents
+                .filter(
-                .filter((event) => state.can(event as any))
+                  (eventName) =>
-                .includes(a)
+                    eventName.includes('Make segment') ||
-              const bIsEnabled = state.nextEvents
+                    eventName.includes('Constrain')
-                .filter((event) => state.can(event as any))
+                )
-                .includes(b)
+                .sort((a, b) => {
-              if (aisEnabled && !bIsEnabled) {
+                  const aisEnabled = state.nextEvents
-                return -1
+                    .filter((event) => state.can(event as any))
-              }
+                    .includes(a)
-              if (!aisEnabled && bIsEnabled) {
+                  const bIsEnabled = state.nextEvents
-                return 1
+                    .filter((event) => state.can(event as any))
-              }
+                    .includes(b)
-              return 0
+                  if (aisEnabled && !bIsEnabled) {
-            })
+                    return -1
-            .map((eventName) => (
+                  }
-              <li className="contents" key={eventName}>
+                  if (!aisEnabled && bIsEnabled) {
-                <ActionButton
+                    return 1
-                  className={buttonClassName}
+                  }
-                  Element="button"
+                  return 0
-                  key={eventName}
+                })
-                  onClick={() => send(eventName)}
+                .map((eventName) => ({
-                  disabled={
+                  label: eventName
                    .replace('Make segment ', '')
                    .replace('Constrain ', ''),
                  onClick: () => send(eventName),
                  disabled:
                    !state.nextEvents
                      .filter((event) => state.can(event as any))
-                      .includes(eventName) || disableAllButtons
+                      .includes(eventName) || disableAllButtons,
-                  }
+                }))}
-                  title={eventName}
+              className={buttonClassName}
-                  icon={{
+              Element="button"
-                    icon: 'line',
+              iconStart={{
-                    iconClassName,
+                icon: 'dimension',
-                    bgClassName,
+                iconClassName,
-                  }}
+                bgClassName,
-                >
+              }}
-                  {eventName
+            >
-                    .replace('Make segment ', '')
+              Constrain
-                    .replace('Constrain ', '')}
+            </ActionButtonDropdown>
-                </ActionButton>
+          )}
              </li>
            ))}
        {state.matches('idle') && (
          <li className="contents">
            <ActionButton
@ -257,7 +257,7 @@ export const Toolbar = () => {
                  ? 'extrude'
                  : 'sketches need to be closed, or not already extruded'
              }
-              icon={{
+              iconStart={{
                icon: 'extrude',
                iconClassName,
                bgClassName,
@ -272,7 +272,7 @@ export const Toolbar = () => {
  }
  return (
-    <menu className="max-w-full overflow-hidden whitespace-nowrap rounded px-1.5 py-0.5 backdrop-blur-sm bg-chalkboard-10/80 dark:bg-chalkboard-110/70 relative">
+    <menu className="max-w-full whitespace-nowrap rounded px-1.5 py-0.5 backdrop-blur-sm bg-chalkboard-10/80 dark:bg-chalkboard-110/70 relative">
      <ToolbarButtons />
    </menu>
  )
--- a/src/components/ActionButton.tsx
+++ b/src/components/ActionButton.tsx
@ -1,11 +1,12 @@
 import { ActionIcon, ActionIconProps } from './ActionIcon'
-import React from 'react'
+import React, { ForwardedRef, forwardRef } from 'react'
 import { paths } from 'lib/paths'
 import { Link } from 'react-router-dom'
 import type { LinkProps } from 'react-router-dom'
 interface BaseActionButtonProps {
-  icon?: ActionIconProps
+  iconStart?: ActionIconProps
  iconEnd?: ActionIconProps
  className?: string
 }
@ -32,15 +33,15 @@ type ActionButtonAsElement = BaseActionButtonProps &
    Element: React.ComponentType<React.HTMLAttributes<HTMLButtonElement>>
  }
-type ActionButtonProps =
+export type ActionButtonProps =
  | ActionButtonAsButton
  | ActionButtonAsLink
  | ActionButtonAsExternal
  | ActionButtonAsElement
-export const ActionButton = (props: ActionButtonProps) => {
+export const ActionButton = forwardRef((props: ActionButtonProps, ref) => {
-  const classNames = `action-button m-0 group mono text-sm flex items-center gap-2 rounded-sm border-solid border border-chalkboard-30 hover:border-chalkboard-40 dark:border-chalkboard-70 dark:hover:border-chalkboard-60 dark:bg-chalkboard-90/50 p-[3px] text-chalkboard-100 dark:text-chalkboard-10 ${
+  const classNames = `action-button p-0 m-0 group mono text-xs leading-none flex items-center gap-2 rounded-sm border-solid border border-chalkboard-30 hover:border-chalkboard-40 enabled:dark:border-chalkboard-70 dark:hover:border-chalkboard-60 dark:bg-chalkboard-90/50 text-chalkboard-100 dark:text-chalkboard-10 ${
-    props.icon ? 'pr-2' : 'px-2'
+    props.iconStart ? (props.iconEnd ? 'px-0' : 'pr-2') : 'px-2'
  } ${props.className ? props.className : ''}`
  switch (props.Element) {
@ -48,11 +49,23 @@ export const ActionButton = (props: ActionButtonProps) => {
      // Note we have to destructure 'className' and 'Element' out of props
      // because we don't want to pass them to the button element;
      // the same is true for the other cases below.
-      const { Element, icon, children, className: _className, ...rest } = props
+      const {
        Element,
        iconStart,
        iconEnd,
        children,
        className: _className,
        ...rest
      } = props
      return (
-        <button className={classNames} {...rest}>
+        <button
-          {props.icon && <ActionIcon {...icon} />}
+          ref={ref as ForwardedRef<HTMLButtonElement>}
          className={classNames}
          {...rest}
        >
          {iconStart && <ActionIcon {...iconStart} />}
          {children}
          {iconEnd && <ActionIcon {...iconEnd} />}
        </button>
      )
    }
@ -60,15 +73,22 @@ export const ActionButton = (props: ActionButtonProps) => {
      const {
        Element,
        to,
-        icon,
+        iconStart,
        iconEnd,
        children,
        className: _className,
        ...rest
      } = props
      return (
-        <Link to={to || paths.INDEX} className={classNames} {...rest}>
+        <Link
-          {icon && <ActionIcon {...icon} />}
+          ref={ref as ForwardedRef<HTMLAnchorElement>}
          to={to || paths.INDEX}
          className={classNames}
          {...rest}
        >
          {iconStart && <ActionIcon {...iconStart} />}
          {children}
          {iconEnd && <ActionIcon {...iconEnd} />}
        </Link>
      )
    }
@ -76,33 +96,42 @@ export const ActionButton = (props: ActionButtonProps) => {
      const {
        Element,
        to,
-        icon,
+        iconStart,
        iconEnd,
        children,
        className: _className,
        ...rest
      } = props
      return (
        <Link
          ref={ref as ForwardedRef<HTMLAnchorElement>}
          to={to || paths.INDEX}
          className={classNames}
          {...rest}
          target="_blank"
        >
-          {icon && <ActionIcon {...icon} />}
+          {iconStart && <ActionIcon {...iconStart} />}
          {children}
          {iconEnd && <ActionIcon {...iconEnd} />}
        </Link>
      )
    }
    default: {
-      const { Element, icon, children, className: _className, ...rest } = props
+      const {
-      if (!Element) throw new Error('Element is required')
+        Element,
        iconStart,
        children,
        className: _className,
        ...rest
      } = props
      return (
        <Element className={classNames} {...rest}>
-          {props.icon && <ActionIcon {...props.icon} />}
+          {props.iconStart && <ActionIcon {...props.iconStart} />}
          {children}
          {props.iconEnd && <ActionIcon {...props.iconEnd} />}
        </Element>
      )
    }
  }
-}
+})
--- a/src/components/ActionButtonDropdown.tsx
+++ b/src/components/ActionButtonDropdown.tsx
@ -0,0 +1,55 @@
 import { Popover } from '@headlessui/react'
 import { ActionButton, ActionButtonProps } from './ActionButton'
 type ActionButtonSplitProps = Omit<ActionButtonProps, 'iconEnd'> & {
  splitMenuItems: {
    label: string
    shortcut?: string
    onClick: () => void
    disabled?: boolean
  }[]
 }
 export function ActionButtonDropdown({
  splitMenuItems,
  className,
  ...props
 }: ActionButtonSplitProps) {
  return (
    <Popover className="relative">
      <Popover.Button
        as={ActionButton}
        className={className}
        {...props}
        Element="button"
        iconEnd={{
          icon: 'caretDown',
          className: 'ui-open:rotate-180',
          bgClassName:
            'bg-chalkboard-20 dark:bg-chalkboard-80 ui-open:bg-primary ui-open:text-chalkboard-10',
        }}
      />
      <Popover.Panel
        as="ul"
        className="absolute z-20 left-1/2 -translate-x-1/2 top-full mt-1 w-fit max-h-[80vh] overflow-y-auto py-2 flex flex-col gap-1 align-stretch text-inherit dark:text-chalkboard-10 bg-chalkboard-10 dark:bg-chalkboard-100 rounded shadow-lg border border-solid border-chalkboard-30 dark:border-chalkboard-80 text-sm m-0 p-0"
      >
        {splitMenuItems.map((item) => (
          <li className="contents" key={item.label}>
            <button
              onClick={item.onClick}
              className="block px-3 py-1 hover:bg-primary/10 dark:hover:bg-chalkboard-80 border-0 m-0 text-sm w-full rounded-none text-left disabled:!bg-transparent dark:disabled:text-chalkboard-60"
              disabled={item.disabled}
            >
              <span className="capitalize">{item.label}</span>
              {item.shortcut && (
                <kbd className="bg-primary/10 dark:bg-chalkboard-80 dark:group-hover:bg-primary font-mono rounded-sm dark:text-inherit inline-block px-1 border-primary dark:border-chalkboard-90">
                  {item.shortcut}
                </kbd>
              )}
            </button>
          </li>
        ))}
      </Popover.Panel>
    </Popover>
  )
 }
--- a/src/components/ActionIcon.tsx
+++ b/src/components/ActionIcon.tsx
@ -29,10 +29,8 @@ export const ActionIcon = ({
  size = 'md',
  children,
 }: ActionIconProps) => {
-  // By default, we reverse the icon color and background color in dark mode
+  const computedIconClassName = `h-auto text-inherit dark:text-current !group-disabled:text-chalkboard-60 !group-disabled:text-chalkboard-60 ${iconClassName}`
-  const computedIconClassName = `h-auto text-primary dark:text-current !group-disabled:text-chalkboard-60 !group-disabled:text-chalkboard-60 ${iconClassName}`
+  const computedBgClassName = `bg-chalkboard-20 dark:bg-chalkboard-80 !group-disabled:bg-chalkboard-30 !dark:group-disabled:bg-chalkboard-80 ${bgClassName}`
  const computedBgClassName = `bg-primary/10 dark:bg-chalkboard-90 !group-disabled:bg-chalkboard-30 !dark:group-disabled:bg-chalkboard-80 ${bgClassName}`
  return (
    <div
--- a/src/components/CommandBar/CommandBarHeader.tsx
+++ b/src/components/CommandBar/CommandBarHeader.tsx
@ -175,7 +175,7 @@ function ReviewingButton() {
      type="submit"
      form="review-form"
      className="w-fit !p-0 rounded-sm border !border-primary hover:shadow"
-      icon={{
+      iconStart={{
        icon: 'checkmark',
        bgClassName: 'p-1 rounded-sm !bg-primary hover:brightness-110',
        iconClassName: '!text-chalkboard-10',
@ -193,7 +193,7 @@ function GatheringArgsButton() {
      type="submit"
      form="arg-form"
      className="w-fit !p-0 rounded-sm border !border-primary hover:shadow"
-      icon={{
+      iconStart={{
        icon: 'arrowRight',
        bgClassName: 'p-1 rounded-sm !bg-primary hover:brightness-110',
        iconClassName: '!text-chalkboard-10',
--- a/src/components/CustomIcon.tsx
+++ b/src/components/CustomIcon.tsx
@ -71,6 +71,16 @@ const CustomIconMap = {
      />
    </svg>
  ),
  caretDown: (
    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
      <path
        fillRule="evenodd"
        clipRule="evenodd"
        d="M10 11.2929L6.35346 7.64642L5.64636 8.35354L9.64648 12.3536L10.3536 12.3536L14.3535 8.35353L13.6464 7.64643L10 11.2929Z"
        fill="currentColor"
      />
    </svg>
  ),
  clipboardCheckmark: (
    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
      <path
@ -101,6 +111,16 @@ const CustomIconMap = {
      />
    </svg>
  ),
  dimension: (
    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
      <path
        fillRule="evenodd"
        clipRule="evenodd"
        d="M15.6455 3.6455L14 2V5.291L5.291 14H2L6 18V14.7052L14.7052 6H18L16.3526 4.35261L16.3546 4.35065L15.6475 3.64354L15.6455 3.6455Z"
        fill="currentColor"
      />
    </svg>
  ),
  equal: (
    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
      <path
--- a/src/components/DownloadAppBanner.tsx
+++ b/src/components/DownloadAppBanner.tsx
@ -25,7 +25,7 @@ const DownloadAppBanner = () => {
            <ActionButton
              Element="button"
              onClick={() => setIsBannerDismissed(true)}
-              icon={{
+              iconStart={{
                icon: 'close',
                className: 'p-1',
                bgClassName:
--- a/src/components/ErrorPage.tsx
+++ b/src/components/ErrorPage.tsx
@ -29,7 +29,7 @@ export const ErrorPage = () => {
            <ActionButton
              Element="link"
              to={'/'}
-              icon={{ icon: faHome }}
+              iconStart={{ icon: faHome }}
              data-testid="unexpected-error-home"
            >
              Go Home
@ -37,14 +37,14 @@ export const ErrorPage = () => {
          )}
          <ActionButton
            Element="button"
-            icon={{ icon: faRefresh }}
+            iconStart={{ icon: faRefresh }}
            onClick={() => window.location.reload()}
          >
            Reload
          </ActionButton>
          <ActionButton
            Element="button"
-            icon={{ icon: faTrash }}
+            iconStart={{ icon: faTrash }}
            onClick={() => {
              window.localStorage.clear()
            }}
@ -53,7 +53,7 @@ export const ErrorPage = () => {
          </ActionButton>
          <ActionButton
            Element="externalLink"
-            icon={{ icon: faBug }}
+            iconStart={{ icon: faBug }}
            to="https://github.com/KittyCAD/modeling-app/issues/new"
          >
            Report Bug
--- a/src/components/FileTree.tsx
+++ b/src/components/FileTree.tsx
@ -109,7 +109,7 @@ function DeleteConfirmationDialog({
                send({ type: 'Delete file', data: fileOrDir })
                setIsOpen(false)
              }}
-              icon={{
+              iconStart={{
                icon: faTrashAlt,
                bgClassName: 'bg-destroy-80',
                iconClassName:
@ -340,7 +340,7 @@ export const FileTreeMenu = () => {
    <>
      <ActionButton
        Element="button"
-        icon={{
+        iconStart={{
          icon: 'filePlus',
          iconClassName: '!text-current',
          bgClassName: 'bg-transparent',
@ -355,7 +355,7 @@ export const FileTreeMenu = () => {
      <ActionButton
        Element="button"
-        icon={{
+        iconStart={{
          icon: 'folderPlus',
          iconClassName: '!text-current',
          bgClassName: 'bg-transparent',
--- a/src/components/ProjectCard.tsx
+++ b/src/components/ProjectCard.tsx
@ -85,7 +85,7 @@ function ProjectCard({
            <ActionButton
              Element="button"
              type="submit"
-              icon={{
+              iconStart={{
                icon: faCheck,
                size: 'sm',
                className: 'p-1',
@ -99,7 +99,7 @@ function ProjectCard({
            </ActionButton>
            <ActionButton
              Element="button"
-              icon={{
+              iconStart={{
                icon: faX,
                size: 'sm',
                iconClassName: 'dark:!text-chalkboard-20',
@ -141,7 +141,7 @@ function ProjectCard({
            <div className="absolute z-10 bottom-2 right-2 flex gap-1 items-center opacity-0 group-hover:opacity-100 group-focus-within:opacity-100">
              <ActionButton
                Element="button"
-                icon={{
+                iconStart={{
                  icon: faPenAlt,
                  className: 'p-1',
                  iconClassName: 'dark:!text-chalkboard-20',
@ -161,7 +161,7 @@ function ProjectCard({
              </ActionButton>
              <ActionButton
                Element="button"
-                icon={{
+                iconStart={{
                  icon: faTrashAlt,
                  className: 'p-1',
                  size: 'xs',
@ -207,7 +207,7 @@ function ProjectCard({
                      await handleDeleteProject(project)
                      setIsConfirmingDelete(false)
                    }}
-                    icon={{
+                    iconStart={{
                      icon: faTrashAlt,
                      bgClassName: 'bg-destroy-80',
                      className: 'p-1',
--- a/src/components/ProjectSidebarMenu.tsx
+++ b/src/components/ProjectSidebarMenu.tsx
@ -165,7 +165,7 @@ function ProjectMenuPopover({
              <div className="flex flex-col gap-2 p-4 dark:bg-chalkboard-90">
                <ActionButton
                  Element="button"
-                  icon={{ icon: 'exportFile', className: 'p-1' }}
+                  iconStart={{ icon: 'exportFile', className: 'p-1' }}
                  className="border-transparent dark:border-transparent"
                  disabled={!findCommand(exportCommandInfo)}
                  onClick={() =>
@ -185,7 +185,7 @@ function ProjectMenuPopover({
                      // Clear the scene and end the session.
                      engineCommandManager.endSession()
                    }}
-                    icon={{
+                    iconStart={{
                      icon: 'arrowLeft',
                      className: 'p-1',
                    }}
--- a/src/components/SetVarNameModal.tsx
+++ b/src/components/SetVarNameModal.tsx
@ -78,7 +78,7 @@ export const SetVarNameModal = ({
                  Element="button"
                  type="submit"
                  disabled={!isNewVariableNameUnique}
-                  icon={{ icon: faPlus }}
+                  iconStart={{ icon: faPlus }}
                >
                  Add variable
                </ActionButton>
--- a/src/components/UpdaterModal.tsx
+++ b/src/components/UpdaterModal.tsx
@ -59,7 +59,7 @@ export const UpdaterModal = ({
        <ActionButton
          Element="button"
          onClick={() => onResolve({ wantUpdate: false })}
-          icon={{
+          iconStart={{
            icon: 'close',
            bgClassName: 'bg-destroy-80',
            iconClassName: 'text-destroy-20 group-hover:text-destroy-10',
@ -72,7 +72,10 @@ export const UpdaterModal = ({
        <ActionButton
          Element="button"
          onClick={() => onResolve({ wantUpdate: true })}
-          icon={{ icon: 'arrowRight', bgClassName: 'dark:bg-chalkboard-80' }}
+          iconStart={{
            icon: 'arrowRight',
            bgClassName: 'dark:bg-chalkboard-80',
          }}
          className="dark:hover:bg-chalkboard-80/50"
          data-testid="update-button-update"
        >
--- a/src/components/UpdaterRestartModal.tsx
+++ b/src/components/UpdaterRestartModal.tsx
@ -31,7 +31,7 @@ export const UpdaterRestartModal = ({
        <ActionButton
          Element="button"
          onClick={() => onResolve({ wantRestart: false })}
-          icon={{
+          iconStart={{
            icon: 'close',
            bgClassName: 'bg-destroy-80',
            iconClassName: 'text-destroy-20 group-hover:text-destroy-10',
@ -44,7 +44,10 @@ export const UpdaterRestartModal = ({
        <ActionButton
          Element="button"
          onClick={() => onResolve({ wantRestart: true })}
-          icon={{ icon: 'arrowRight', bgClassName: 'dark:bg-chalkboard-80' }}
+          iconStart={{
            icon: 'arrowRight',
            bgClassName: 'dark:bg-chalkboard-80',
          }}
          className="dark:hover:bg-chalkboard-80/50"
          data-testid="update-restrart-button-update"
        >
--- a/src/components/UserSidebarMenu.tsx
+++ b/src/components/UserSidebarMenu.tsx
@ -55,7 +55,7 @@ const UserSidebarMenu = ({ user }: { user?: User }) => {
      ) : (
        <ActionButton
          Element={Popover.Button}
-          icon={{ icon: 'menu' }}
+          iconStart={{ icon: 'menu' }}
          className="border-transparent !px-0"
          data-testid="user-sidebar-toggle"
        >
@ -120,7 +120,7 @@ const UserSidebarMenu = ({ user }: { user?: User }) => {
              <div className="p-4 flex flex-col gap-2">
                <ActionButton
                  Element="button"
-                  icon={{ icon: 'settings' }}
+                  iconStart={{ icon: 'settings' }}
                  className="border-transparent dark:border-transparent hover:bg-transparent"
                  onClick={() => {
                    // since /settings is a nested route the sidebar doesn't close
@ -138,7 +138,7 @@ const UserSidebarMenu = ({ user }: { user?: User }) => {
                <ActionButton
                  Element="externalLink"
                  to="https://github.com/KittyCAD/modeling-app/discussions"
-                  icon={{ icon: faGithub, className: 'p-1', size: 'sm' }}
+                  iconStart={{ icon: faGithub, className: 'p-1', size: 'sm' }}
                  className="border-transparent dark:border-transparent"
                >
                  Request a feature
@ -146,7 +146,7 @@ const UserSidebarMenu = ({ user }: { user?: User }) => {
                <ActionButton
                  Element="externalLink"
                  to="https://github.com/KittyCAD/modeling-app/issues/new/choose"
-                  icon={{ icon: faBug, className: 'p-1', size: 'sm' }}
+                  iconStart={{ icon: faBug, className: 'p-1', size: 'sm' }}
                  className="border-transparent dark:border-transparent"
                >
                  Report a bug
@ -154,7 +154,7 @@ const UserSidebarMenu = ({ user }: { user?: User }) => {
                <ActionButton
                  Element="button"
                  onClick={() => send('Log out')}
-                  icon={{
+                  iconStart={{
                    icon: faSignOutAlt,
                    className: 'p-1',
                    bgClassName: '!bg-transparent',
--- a/src/components/WasmErrBanner.tsx
+++ b/src/components/WasmErrBanner.tsx
@ -24,7 +24,7 @@ export function WasmErrBanner() {
          <ActionButton
            Element="button"
            onClick={() => setBannerDismissed(true)}
-            icon={{
+            iconStart={{
              icon: 'close',
              className: 'p-1',
              bgClassName:
--- a/src/editor/plugins/lsp/plugin.ts
+++ b/src/editor/plugins/lsp/plugin.ts
@ -264,8 +264,12 @@ export class LanguageServerPlugin implements PluginValue {
    )
      return null
-    this.sendChange({
+    this.client.textDocumentDidChange({
-      documentText: this.view.state.doc.toString(),
+      textDocument: {
        uri: this.documentUri,
        version: this.documentVersion++,
      },
      contentChanges: [{ text: this.view.state.doc.toString() }],
    })
    const result = await this.client.textDocumentFormatting({
--- a/src/lang/codeManager.ts
+++ b/src/lang/codeManager.ts
@ -79,6 +79,7 @@ export default class CodeManager {
    if (this._code !== code) {
      this.code = code
      this.#updateState(code)
      this.updateCodeEditor(code)
    }
  }
--- a/src/routes/Home.tsx
+++ b/src/routes/Home.tsx
@ -210,7 +210,7 @@ const Home = () => {
                  : '')
              }
              onClick={() => setSearchParams(getNextSearchParams(sort, 'name'))}
-              icon={{
+              iconStart={{
                icon: getSortIcon(sort, 'name'),
                className: 'p-1.5',
                iconClassName: !sort.includes('name')
@ -232,7 +232,7 @@ const Home = () => {
              onClick={() =>
                setSearchParams(getNextSearchParams(sort, 'modified'))
              }
-              icon={{
+              iconStart={{
                icon: sort ? getSortIcon(sort, 'modified') : faArrowDown,
                className: 'p-1.5',
                iconClassName: !isSortByModified ? '!text-chalkboard-40' : '',
@ -278,7 +278,7 @@ const Home = () => {
              <ActionButton
                Element="button"
                onClick={() => send('Create project')}
-                icon={{ icon: faPlus, iconClassName: 'p-1 w-4' }}
+                iconStart={{ icon: faPlus, iconClassName: 'p-1 w-4' }}
                data-testid="home-new-file"
              >
                New project
--- a/src/routes/Onboarding/Units.tsx
+++ b/src/routes/Onboarding/Units.tsx
@ -51,7 +51,7 @@ export default function Units() {
          <ActionButton
            Element="button"
            onClick={dismiss}
-            icon={{
+            iconStart={{
              icon: faXmark,
              bgClassName: 'bg-destroy-80',
              iconClassName:
@ -64,7 +64,7 @@ export default function Units() {
          <ActionButton
            Element="button"
            onClick={next}
-            icon={{ icon: faArrowRight }}
+            iconStart={{ icon: faArrowRight }}
          >
            Next: Camera
          </ActionButton>
--- a/src/routes/Onboarding/index.tsx
+++ b/src/routes/Onboarding/index.tsx
@ -144,7 +144,7 @@ export function OnboardingButtons({
      <ActionButton
        Element="button"
        onClick={dismiss}
-        icon={{
+        iconStart={{
          icon: 'close',
          bgClassName: 'bg-destroy-80',
          iconClassName: 'text-destroy-20 group-hover:text-destroy-10',
@ -161,7 +161,7 @@ export function OnboardingButtons({
      <ActionButton
        Element="button"
        onClick={next}
-        icon={{ icon: 'arrowRight', bgClassName: 'dark:bg-chalkboard-80' }}
+        iconStart={{ icon: 'arrowRight', bgClassName: 'dark:bg-chalkboard-80' }}
        className="dark:hover:bg-chalkboard-80/50"
        data-testid="onboarding-next"
      >
--- a/src/routes/Settings.tsx
+++ b/src/routes/Settings.tsx
@ -269,7 +269,7 @@ export const Settings = () => {
                    <ActionButton
                      Element="button"
                      onClick={restartOnboarding}
-                      icon={{
+                      iconStart={{
                        icon: 'refresh',
                        size: 'sm',
                        className: 'p-1',
@ -300,7 +300,7 @@ export const Settings = () => {
                            )
                            showInFolder(paths[searchParamTab])
                          }}
-                          icon={{
+                          iconStart={{
                            icon: 'folder',
                            size: 'sm',
                            className: 'p-1',
@ -319,7 +319,7 @@ export const Settings = () => {
                          })
                          toast.success('Settings restored to default')
                        }}
-                        icon={{
+                        iconStart={{
                          icon: 'refresh',
                          size: 'sm',
                          className: 'p-1 text-chalkboard-10',
--- a/src/routes/SignIn.tsx
+++ b/src/routes/SignIn.tsx
@ -65,7 +65,7 @@ const SignIn = () => {
          <ActionButton
            Element="button"
            onClick={signInTauri}
-            icon={{ icon: 'arrowRight' }}
+            iconStart={{ icon: 'arrowRight' }}
            className="w-fit mt-4"
            data-testid="sign-in-button"
          >
@ -80,7 +80,7 @@ const SignIn = () => {
              typeof window !== 'undefined' &&
                window.location.href.replace('signin', '')
            )}`}
-            icon={{ icon: 'arrowRight' }}
+            iconStart={{ icon: 'arrowRight' }}
            className="w-fit mt-4"
          >
            Sign in
--- a/src/wasm-lib/Cargo.lock
+++ b/src/wasm-lib/Cargo.lock
@ -1895,7 +1895,7 @@ dependencies = [
 [[package]]
 name = "kcl-lib"
-version = "0.1.54"
+version = "0.1.55"
 dependencies = [
 "anyhow",
 "approx 0.5.1",
--- a/src/wasm-lib/grackle/fixtures/cube_lineTo.png
+++ b/src/wasm-lib/grackle/fixtures/cube_lineTo.png
--- a/src/wasm-lib/grackle/fixtures/cube_tangentialArcTo.png
+++ b/src/wasm-lib/grackle/fixtures/cube_tangentialArcTo.png
--- a/src/wasm-lib/grackle/fixtures/cube_xyLine.png
+++ b/src/wasm-lib/grackle/fixtures/cube_xyLine.png
--- a/src/wasm-lib/kcl/Cargo.toml
+++ b/src/wasm-lib/kcl/Cargo.toml
@ -1,7 +1,7 @@
 [package]
 name = "kcl-lib"
 description = "KittyCAD Language implementation and tools"
-version = "0.1.54"
+version = "0.1.55"
 edition = "2021"
 license = "MIT"
 repository = "https://github.com/KittyCAD/modeling-app"
--- a/src/wasm-lib/kcl/src/ast/types.rs
+++ b/src/wasm-lib/kcl/src/ast/types.rs
@ -3297,6 +3297,144 @@ fn ghi = (x) => {
        assert_eq!(symbols.len(), 7);
    }
    #[test]
    fn test_recast_bug_extra_parens() {
        let some_program_string = r#"// Ball Bearing
 // A ball bearing is a type of rolling-element bearing that uses balls to maintain the separation between the bearing races. The primary purpose of a ball bearing is to reduce rotational friction and support radial and axial loads. 
 // Define constants like ball diameter, inside diameter, overhange length, and thickness
 const sphereDia = 0.5
 const insideDia = 1
 const thickness = 0.25
 const overHangLength = .4
 // Sketch and revolve the inside bearing piece
 const insideRevolve = startSketchOn('XZ')
  |> startProfileAt([insideDia / 2, 0], %)
  |> line([0, thickness + sphereDia / 2], %)
  |> line([overHangLength, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, -sphereDia], %)
  |> line([overHangLength - thickness, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)
 // Sketch and revolve one of the balls and duplicate it using a circular pattern. (This is currently a workaround, we have a bug with rotating on a sketch that touches the rotation axis)
 const sphere = startSketchOn('XZ')
  |> startProfileAt([
       0.05 + insideDia / 2 + thickness,
       0 - 0.05
     ], %)
  |> line([sphereDia - 0.1, 0], %)
  |> arc({
       angle_start: 0,
       angle_end: -180,
       radius: sphereDia / 2 - 0.05
     }, %)
  |> close(%)
  |> revolve({ axis: 'x' }, %)
  |> patternCircular3d({
       axis: [0, 0, 1],
       center: [0, 0, 0],
       repetitions: 10,
       arcDegrees: 360,
       rotateDuplicates: true
     }, %)
 // Sketch and revolve the outside bearing
 const outsideRevolve = startSketchOn('XZ')
  |> startProfileAt([
       insideDia / 2 + thickness + sphereDia,
       0
     ], %)
  |> line([0, sphereDia / 2], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength, 0], %)
  |> line([0, -2 * thickness - sphereDia], %)
  |> line([-overHangLength, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength - thickness, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)"#;
        let tokens = crate::token::lexer(some_program_string).unwrap();
        let parser = crate::parser::Parser::new(tokens);
        let program = parser.ast().unwrap();
        println!("{:#?}", program);
        let recasted = program.recast(&Default::default(), 0);
        assert_eq!(
            recasted,
            r#"// Ball Bearing
 // A ball bearing is a type of rolling-element bearing that uses balls to maintain the separation between the bearing races. The primary purpose of a ball bearing is to reduce rotational friction and support radial and axial loads.
 // Define constants like ball diameter, inside diameter, overhange length, and thickness
 const sphereDia = 0.5
 const insideDia = 1
 const thickness = 0.25
 const overHangLength = .4
 // Sketch and revolve the inside bearing piece
 const insideRevolve = startSketchOn('XZ')
  |> startProfileAt([insideDia / 2, 0], %)
  |> line([0, thickness + sphereDia / 2], %)
  |> line([overHangLength, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, -sphereDia], %)
  |> line([overHangLength - thickness, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)
 // Sketch and revolve one of the balls and duplicate it using a circular pattern. (This is currently a workaround, we have a bug with rotating on a sketch that touches the rotation axis)
 const sphere = startSketchOn('XZ')
  |> startProfileAt([
       0.05 + insideDia / 2 + thickness,
       0 - 0.05
     ], %)
  |> line([sphereDia - 0.1, 0], %)
  |> arc({
       angle_start: 0,
       angle_end: -180,
       radius: sphereDia / 2 - 0.05
     }, %)
  |> close(%)
  |> revolve({ axis: 'x' }, %)
  |> patternCircular3d({
       axis: [0, 0, 1],
       center: [0, 0, 0],
       repetitions: 10,
       arcDegrees: 360,
       rotateDuplicates: true
     }, %)
 // Sketch and revolve the outside bearing
 const outsideRevolve = startSketchOn('XZ')
  |> startProfileAt([
       insideDia / 2 + thickness + sphereDia,
       0
     ], %)
  |> line([0, sphereDia / 2], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength, 0], %)
  |> line([0, -2 * thickness - sphereDia], %)
  |> line([-overHangLength, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength - thickness, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)
 "#
        );
    }
    #[test]
    fn test_recast_empty_file() {
        let some_program_string = r#""#;
--- a/src/wasm-lib/kcl/src/executor.rs
+++ b/src/wasm-lib/kcl/src/executor.rs
@ -144,8 +144,6 @@ pub enum MemoryItem {
    },
    ImportedGeometry(ImportedGeometry),
    #[ts(skip)]
    ExtrudeTransform(Box<ExtrudeTransform>),
    #[ts(skip)]
    Function {
        #[serde(skip)]
        func: Option<MemoryFunction>,
@ -300,16 +298,6 @@ pub struct UserVal {
    pub meta: Vec<Metadata>,
 }
 #[derive(Debug, Clone, Deserialize, Serialize, PartialEq, ts_rs::TS, JsonSchema)]
 #[ts(export)]
 #[serde(tag = "type", rename_all = "camelCase")]
 pub struct ExtrudeTransform {
    pub position: Position,
    pub rotation: Rotation,
    #[serde(rename = "__meta")]
    pub meta: Vec<Metadata>,
 }
 pub type MemoryFunction =
    fn(
        s: Vec<MemoryItem>,
@ -348,7 +336,6 @@ impl From<MemoryItem> for Vec<SourceRange> {
                .flat_map(|eg| eg.meta.iter().map(|m| m.source_range))
                .collect(),
            MemoryItem::ImportedGeometry(i) => i.meta.iter().map(|m| m.source_range).collect(),
            MemoryItem::ExtrudeTransform(e) => e.meta.iter().map(|m| m.source_range).collect(),
            MemoryItem::Function { meta, .. } => meta.iter().map(|m| m.source_range).collect(),
            MemoryItem::Plane(p) => p.meta.iter().map(|m| m.source_range).collect(),
            MemoryItem::Face(f) => f.meta.iter().map(|m| m.source_range).collect(),
--- a/src/wasm-lib/kcl/src/lsp/kcl/mod.rs
+++ b/src/wasm-lib/kcl/src/lsp/kcl/mod.rs
@ -313,6 +313,28 @@ impl Backend {
            let source_range: SourceRange = token.clone().into();
            let position = source_range.start_to_lsp_position(&params.text);
            // We need to check if we are on the last token of the line.
            // If we are starting from the end of the last line just add 1 to the line.
            // Check if we are on the last token of the line.
            if let Some(line) = params.text.lines().nth(position.line as usize) {
                if line.len() == position.character as usize {
                    // We are on the last token of the line.
                    // We need to add a new line.
                    let semantic_token = SemanticToken {
                        delta_line: position.line - last_position.line + 1,
                        delta_start: 0,
                        length: token.value.len() as u32,
                        token_type: token_type_index as u32,
                        token_modifiers_bitset: 0,
                    };
                    semantic_tokens.push(semantic_token);
                    last_position = Position::new(position.line + 1, 0);
                    continue;
                }
            }
            let semantic_token = SemanticToken {
                delta_line: position.line - last_position.line,
                delta_start: if position.line != last_position.line {
@ -1011,7 +1033,7 @@ impl LanguageServer for Backend {
            },
            0,
        );
-        let source_range = SourceRange([0, current_code.len() - 1]);
+        let source_range = SourceRange([0, current_code.len()]);
        let range = source_range.to_lsp_range(current_code);
        Ok(Some(vec![TextEdit {
            new_text: recast,
--- a/src/wasm-lib/kcl/src/lsp/tests.rs
+++ b/src/wasm-lib/kcl/src/lsp/tests.rs
@ -1014,15 +1014,86 @@ async fn test_kcl_lsp_semantic_tokens() {
    if let tower_lsp::lsp_types::SemanticTokensResult::Tokens(semantic_tokens) = semantic_tokens {
        assert_eq!(semantic_tokens.data.len(), 2);
        assert_eq!(semantic_tokens.data[0].length, 13);
        assert_eq!(semantic_tokens.data[0].delta_start, 0);
        assert_eq!(semantic_tokens.data[0].delta_line, 0);
        assert_eq!(semantic_tokens.data[0].token_type, 8);
        assert_eq!(semantic_tokens.data[1].length, 4);
        assert_eq!(semantic_tokens.data[1].delta_start, 14);
        assert_eq!(semantic_tokens.data[1].delta_line, 0);
        assert_eq!(semantic_tokens.data[1].token_type, 3);
    } else {
        panic!("Expected semantic tokens");
    }
 }
 #[tokio::test(flavor = "multi_thread")]
 async fn test_kcl_lsp_semantic_tokens_multiple_comments() {
    let server = kcl_lsp_server(false).await.unwrap();
    // Send open file.
    server
        .did_open(tower_lsp::lsp_types::DidOpenTextDocumentParams {
            text_document: tower_lsp::lsp_types::TextDocumentItem {
                uri: "file:///test.kcl".try_into().unwrap(),
                language_id: "kcl".to_string(),
                version: 1,
                text: r#"// Ball Bearing
 // A ball bearing is a type of rolling-element bearing that uses balls to maintain the separation between the bearing races. The primary purpose of a ball bearing is to reduce rotational friction and support radial and axial loads. 
 // Define constants like ball diameter, inside diameter, overhange length, and thickness
 const sphereDia = 0.5"#.to_string(),
            },
        })
        .await;
    server.wait_on_handle().await;
    // Send semantic tokens request.
    let semantic_tokens = server
        .semantic_tokens_full(tower_lsp::lsp_types::SemanticTokensParams {
            text_document: tower_lsp::lsp_types::TextDocumentIdentifier {
                uri: "file:///test.kcl".try_into().unwrap(),
            },
            partial_result_params: Default::default(),
            work_done_progress_params: Default::default(),
        })
        .await
        .unwrap()
        .unwrap();
    // Check the semantic tokens.
    if let tower_lsp::lsp_types::SemanticTokensResult::Tokens(semantic_tokens) = semantic_tokens {
        assert_eq!(semantic_tokens.data.len(), 7);
        assert_eq!(semantic_tokens.data[0].length, 15);
        assert_eq!(semantic_tokens.data[0].delta_start, 0);
        assert_eq!(semantic_tokens.data[0].delta_line, 0);
        assert_eq!(semantic_tokens.data[0].token_type, 6);
        assert_eq!(semantic_tokens.data[1].length, 232);
        assert_eq!(semantic_tokens.data[1].delta_start, 0);
        assert_eq!(semantic_tokens.data[1].delta_line, 1);
        assert_eq!(semantic_tokens.data[1].token_type, 6);
        assert_eq!(semantic_tokens.data[2].length, 88);
        assert_eq!(semantic_tokens.data[2].delta_start, 0);
        assert_eq!(semantic_tokens.data[2].delta_line, 2);
        assert_eq!(semantic_tokens.data[2].token_type, 6);
        assert_eq!(semantic_tokens.data[3].length, 5);
        assert_eq!(semantic_tokens.data[3].delta_start, 0);
        assert_eq!(semantic_tokens.data[3].delta_line, 1);
        assert_eq!(semantic_tokens.data[3].token_type, 4);
        assert_eq!(semantic_tokens.data[4].length, 9);
        assert_eq!(semantic_tokens.data[4].delta_start, 6);
        assert_eq!(semantic_tokens.data[4].delta_line, 0);
        assert_eq!(semantic_tokens.data[4].token_type, 1);
        assert_eq!(semantic_tokens.data[5].length, 1);
        assert_eq!(semantic_tokens.data[5].delta_start, 10);
        assert_eq!(semantic_tokens.data[5].token_type, 2);
        assert_eq!(semantic_tokens.data[6].length, 3);
        assert_eq!(semantic_tokens.data[6].delta_start, 2);
        assert_eq!(semantic_tokens.data[6].token_type, 0);
    } else {
        panic!("Expected semantic tokens");
    }
 }
 #[tokio::test(flavor = "multi_thread")]
 async fn test_kcl_lsp_document_symbol() {
    let server = kcl_lsp_server(false).await.unwrap();
@ -1112,6 +1183,183 @@ async fn test_kcl_lsp_formatting() {
    );
 }
 #[tokio::test(flavor = "multi_thread")]
 async fn test_kcl_lsp_formatting_extra_parens() {
    let server = kcl_lsp_server(false).await.unwrap();
    // Send open file.
    server
        .did_open(tower_lsp::lsp_types::DidOpenTextDocumentParams {
            text_document: tower_lsp::lsp_types::TextDocumentItem {
                uri: "file:///test.kcl".try_into().unwrap(),
                language_id: "kcl".to_string(),
                version: 1,
                text: r#"// Ball Bearing
 // A ball bearing is a type of rolling-element bearing that uses balls to maintain the separation between the bearing races. The primary purpose of a ball bearing is to reduce rotational friction and support radial and axial loads. 
 // Define constants like ball diameter, inside diameter, overhange length, and thickness
 const sphereDia = 0.5
 const insideDia = 1
 const thickness = 0.25
 const overHangLength = .4
 // Sketch and revolve the inside bearing piece
 const insideRevolve = startSketchOn('XZ')
  |> startProfileAt([insideDia / 2, 0], %)
  |> line([0, thickness + sphereDia / 2], %)
  |> line([overHangLength, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, -sphereDia], %)
  |> line([overHangLength - thickness, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)
 // Sketch and revolve one of the balls and duplicate it using a circular pattern. (This is currently a workaround, we have a bug with rotating on a sketch that touches the rotation axis)
 const sphere = startSketchOn('XZ')
  |> startProfileAt([
       0.05 + insideDia / 2 + thickness,
       0 - 0.05
     ], %)
  |> line([sphereDia - 0.1, 0], %)
  |> arc({
       angle_start: 0,
       angle_end: -180,
       radius: sphereDia / 2 - 0.05
     }, %)
  |> close(%)
  |> revolve({ axis: 'x' }, %)
  |> patternCircular3d({
       axis: [0, 0, 1],
       center: [0, 0, 0],
       repetitions: 10,
       arcDegrees: 360,
       rotateDuplicates: true
     }, %)
 // Sketch and revolve the outside bearing
 const outsideRevolve = startSketchOn('XZ')
  |> startProfileAt([
       insideDia / 2 + thickness + sphereDia,
       0
     ], %)
  |> line([0, sphereDia / 2], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength, 0], %)
  |> line([0, -2 * thickness - sphereDia], %)
  |> line([-overHangLength, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength - thickness, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)"#
                    .to_string(),
            },
        })
        .await;
    server.wait_on_handle().await;
    // Send formatting request.
    let formatting = server
        .formatting(tower_lsp::lsp_types::DocumentFormattingParams {
            text_document: tower_lsp::lsp_types::TextDocumentIdentifier {
                uri: "file:///test.kcl".try_into().unwrap(),
            },
            options: tower_lsp::lsp_types::FormattingOptions {
                tab_size: 2,
                insert_spaces: true,
                properties: Default::default(),
                trim_trailing_whitespace: None,
                insert_final_newline: None,
                trim_final_newlines: None,
            },
            work_done_progress_params: Default::default(),
        })
        .await
        .unwrap()
        .unwrap();
    // Check the formatting.
    assert_eq!(formatting.len(), 1);
    assert_eq!(
        formatting[0].range,
        tower_lsp::lsp_types::Range {
            start: tower_lsp::lsp_types::Position { line: 0, character: 0 },
            end: tower_lsp::lsp_types::Position {
                line: 60,
                character: 30
            }
        }
    );
    assert_eq!(
        formatting[0].new_text,
        r#"// Ball Bearing
 // A ball bearing is a type of rolling-element bearing that uses balls to maintain the separation between the bearing races. The primary purpose of a ball bearing is to reduce rotational friction and support radial and axial loads.
 // Define constants like ball diameter, inside diameter, overhange length, and thickness
 const sphereDia = 0.5
 const insideDia = 1
 const thickness = 0.25
 const overHangLength = .4
 // Sketch and revolve the inside bearing piece
 const insideRevolve = startSketchOn('XZ')
  |> startProfileAt([insideDia / 2, 0], %)
  |> line([0, thickness + sphereDia / 2], %)
  |> line([overHangLength, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, -sphereDia], %)
  |> line([overHangLength - thickness, 0], %)
  |> line([0, -thickness], %)
  |> line([-overHangLength, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)
 // Sketch and revolve one of the balls and duplicate it using a circular pattern. (This is currently a workaround, we have a bug with rotating on a sketch that touches the rotation axis)
 const sphere = startSketchOn('XZ')
  |> startProfileAt([
       0.05 + insideDia / 2 + thickness,
       0 - 0.05
     ], %)
  |> line([sphereDia - 0.1, 0], %)
  |> arc({
       angle_start: 0,
       angle_end: -180,
       radius: sphereDia / 2 - 0.05
     }, %)
  |> close(%)
  |> revolve({ axis: 'x' }, %)
  |> patternCircular3d({
       axis: [0, 0, 1],
       center: [0, 0, 0],
       repetitions: 10,
       arcDegrees: 360,
       rotateDuplicates: true
     }, %)
 // Sketch and revolve the outside bearing
 const outsideRevolve = startSketchOn('XZ')
  |> startProfileAt([
       insideDia / 2 + thickness + sphereDia,
       0
     ], %)
  |> line([0, sphereDia / 2], %)
  |> line([-overHangLength + thickness, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength, 0], %)
  |> line([0, -2 * thickness - sphereDia], %)
  |> line([-overHangLength, 0], %)
  |> line([0, thickness], %)
  |> line([overHangLength - thickness, 0], %)
  |> close(%)
  |> revolve({ axis: 'y' }, %)"#
    );
 }
 #[tokio::test(flavor = "multi_thread")]
 async fn test_kcl_lsp_rename() {
    let server = kcl_lsp_server(false).await.unwrap();
--- a/src/wasm-lib/kcl/src/std/extrude.rs
+++ b/src/wasm-lib/kcl/src/std/extrude.rs
@ -8,8 +8,8 @@ use uuid::Uuid;
 use crate::{
    errors::{KclError, KclErrorDetails},
    executor::{
-        ExtrudeGroup, ExtrudeGroupSet, ExtrudeSurface, ExtrudeTransform, GeoMeta, MemoryItem, Path, SketchGroup,
+        ExtrudeGroup, ExtrudeGroupSet, ExtrudeSurface, GeoMeta, MemoryItem, Path, SketchGroup, SketchGroupSet,
-        SketchGroupSet, SketchSurface,
+        SketchSurface,
    },
    std::Args,
 };
@ -224,48 +224,3 @@ pub(crate) async fn do_post_extrude(
        meta: sketch_group.meta,
    }))
 }
 /// Returns the extrude wall transform.
 pub async fn get_extrude_wall_transform(args: Args) -> Result<MemoryItem, KclError> {
    let (surface_name, extrude_group) = args.get_path_name_extrude_group()?;
    let result = inner_get_extrude_wall_transform(&surface_name, *extrude_group, args)?;
    Ok(MemoryItem::ExtrudeTransform(result))
 }
 /// Returns the extrude wall transform.
 ///
 /// ```no_run
 /// const box = startSketchOn('XY')
 ///     |> startProfileAt([0, 0], %)
 ///     |> line([0, 10], %)
 ///     |> line([10, 0], %)
 ///     |> line([0, -10], %, "surface")
 ///     |> close(%)
 ///     |> extrude(5, %)
 ///
 /// const transform = getExtrudeWallTransform('surface', box)
 /// ```
 #[stdlib {
    name = "getExtrudeWallTransform"
 }]
 fn inner_get_extrude_wall_transform(
    surface_name: &str,
    extrude_group: ExtrudeGroup,
    args: Args,
 ) -> Result<Box<ExtrudeTransform>, KclError> {
    let surface = extrude_group.get_path_by_name(surface_name).ok_or_else(|| {
        KclError::Type(KclErrorDetails {
            message: format!(
                "Expected a surface name that exists in the given ExtrudeGroup, found `{}`",
                surface_name
            ),
            source_ranges: vec![args.source_range],
        })
    })?;
    Ok(Box::new(ExtrudeTransform {
        position: surface.get_position(),
        rotation: surface.get_rotation(),
        meta: extrude_group.meta,
    }))
 }
--- a/src/wasm-lib/kcl/src/std/mod.rs
+++ b/src/wasm-lib/kcl/src/std/mod.rs
@ -44,7 +44,6 @@ lazy_static! {
        Box::new(LegAngX),
        Box::new(LegAngY),
        Box::new(crate::std::extrude::Extrude),
        Box::new(crate::std::extrude::GetExtrudeWallTransform),
        Box::new(crate::std::segment::SegEndX),
        Box::new(crate::std::segment::SegEndY),
        Box::new(crate::std::segment::LastSegX),
@ -906,54 +905,6 @@ impl Args {
        Ok((number, sketch_set))
    }
    fn get_path_name_extrude_group(&self) -> Result<(String, Box<ExtrudeGroup>), KclError> {
        // Iterate over our args, the first argument should be a UserVal with a string value.
        // The second argument should be a ExtrudeGroup.
        let first_value = self
            .args
            .first()
            .ok_or_else(|| {
                KclError::Type(KclErrorDetails {
                    message: format!("Expected a string as the first argument, found `{:?}`", self.args),
                    source_ranges: vec![self.source_range],
                })
            })?
            .get_json_value()?;
        let path_name = if let serde_json::Value::String(s) = first_value {
            s.to_string()
        } else {
            return Err(KclError::Type(KclErrorDetails {
                message: format!("Expected a string as the first argument, found `{:?}`", self.args),
                source_ranges: vec![self.source_range],
            }));
        };
        let second_value = self.args.get(1).ok_or_else(|| {
            KclError::Type(KclErrorDetails {
                message: format!(
                    "Expected a ExtrudeGroup as the second argument, found `{:?}`",
                    self.args
                ),
                source_ranges: vec![self.source_range],
            })
        })?;
        let extrude_group = if let MemoryItem::ExtrudeGroup(sg) = second_value {
            sg.clone()
        } else {
            return Err(KclError::Type(KclErrorDetails {
                message: format!(
                    "Expected a ExtrudeGroup as the second argument, found `{:?}`",
                    self.args
                ),
                source_ranges: vec![self.source_range],
            }));
        };
        Ok((path_name, extrude_group))
    }
 }
 /// Returns the length of the given leg.
--- a/src/wasm-lib/kcl/tests/outputs/serial_test_example_angle_to_match_length_x0.png
+++ b/src/wasm-lib/kcl/tests/outputs/serial_test_example_angle_to_match_length_x0.png
--- a/src/wasm-lib/kcl/tests/outputs/serial_test_example_angle_to_match_length_y0.png
+++ b/src/wasm-lib/kcl/tests/outputs/serial_test_example_angle_to_match_length_y0.png
--- a/src/wasm-lib/kcl/tests/outputs/serial_test_example_angled_line0.png
+++ b/src/wasm-lib/kcl/tests/outputs/serial_test_example_angled_line0.png
--- a/src/wasm-lib/kcl/tests/outputs/serial_test_example_angled_line_of_x_length0.png
+++ b/src/wasm-lib/kcl/tests/outputs/serial_test_example_angled_line_of_x_length0.png
--- a/src/wasm-lib/kcl/tests/outputs/serial_test_example_angled_line_of_y_length0.png
+++ b/src/wasm-lib/kcl/tests/outputs/serial_test_example_angled_line_of_y_length0.png
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Pierre Jacquier	07eaf93e78	Cut release v0.21.1 (#2347 )	2024-05-13 10:05:29 -04:00
Jess Frazelle	6a5ca3088a	remove getExtrudeWallTransform (#2342 ) * remove getExtrudeWallTransform Signed-off-by: Jess Frazelle <github@jessfraz.com> * docs Signed-off-by: Jess Frazelle <github@jessfraz.com> --------- Signed-off-by: Jess Frazelle <github@jessfraz.com>	2024-05-10 17:28:14 -07:00
Jess Frazelle	6501072d80	turn on formatting test now working (#2341 ) turn on test now working Signed-off-by: Jess Frazelle <github@jessfraz.com>	2024-05-10 23:51:54 +00:00
Frank Noirot	726fd02bad	Add a component for toolbar buttons with a dropdown, consolidate Constrain actions under one (#2327 )	2024-05-10 19:02:11 -04:00
Jess Frazelle	d0f9ae475f	format button wasnt working, will add playwright test so we don't regress again (#2340 ) * add test Signed-off-by: Jess Frazelle <github@jessfraz.com> * add another test Signed-off-by: Jess Frazelle <github@jessfraz.com> * add another test Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * off by one error Signed-off-by: Jess Frazelle <github@jessfraz.com> * add two tests Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix typos Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix semantic tokens for commants Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix tests Signed-off-by: Jess Frazelle <github@jessfraz.com> --------- Signed-off-by: Jess Frazelle <github@jessfraz.com>	2024-05-10 22:30:40 +00:00