add more tests

added PipeExpression checker.

now query works with :

const xRel001 = -20
      const xRel002 = -50
      const part001 = startSketchOn('-XZ')
        |> startProfileAt([175.73, 109.38], %)
        |> line([xRel001, 178.25], %)
        |> line([-265.39, -87.86], %)
        |> tangentialArcTo([543.32, -355.04], %)

.github/workflows/ci.yml

@@ -147,14 +147,6 @@ jobs:
           cp artifact/src-tauri/tauri.conf.json src-tauri/tauri.conf.json
           cp artifact/src-tauri/tauri.release.conf.json src-tauri/tauri.release.conf.json
 
-      - name: Update WebView2 on Windows
-        if: matrix.os == 'windows-latest'
-        # Workaround needed to build the tauri windows app with matching edge version.
-        # From https://github.com/actions/runner-images/issues/9538
-        run: |
-          Invoke-WebRequest -Uri 'https://go.microsoft.com/fwlink/p/?LinkId=2124703' -OutFile 'setup.exe'
-          Start-Process -FilePath setup.exe -Verb RunAs -Wait
-
       - name: Install ubuntu system dependencies
         if: matrix.os == 'ubuntu-latest'
         run: |
@@ -372,17 +364,6 @@ jobs:
           E2E_APPLICATION: "./src-tauri/target/${{ env.BUILD_RELEASE == 'true' && 'release' || 'debug' }}/zoo-modeling-app"
           KITTYCAD_API_TOKEN: ${{ env.BUILD_RELEASE == 'true' && secrets.KITTYCAD_API_TOKEN || secrets.KITTYCAD_API_TOKEN_DEV }}
 
-      - name: Run e2e tests (windows only)
-        if: ${{ matrix.os == 'windows-latest' && github.event_name != 'release' && github.event_name != 'schedule' }}
-        run: |
-          cargo install tauri-driver --force
-          yarn wdio run wdio.conf.ts
-        env:
-          E2E_APPLICATION: ".\\src-tauri\\target\\${{ env.BUILD_RELEASE == 'true' && 'release' || 'debug' }}\\Zoo Modeling App.exe"
-          KITTYCAD_API_TOKEN: ${{ env.BUILD_RELEASE == 'true' && secrets.KITTYCAD_API_TOKEN || secrets.KITTYCAD_API_TOKEN_DEV }}
-          VITE_KC_API_BASE_URL: ${{ env.BUILD_RELEASE == 'true' && 'https://api.zoo.dev' || 'https://api.dev.zoo.dev' }}
-          E2E_TAURI_ENABLED: true
-          TS_NODE_COMPILER_OPTIONS: '{"module": "commonjs"}'
 
   publish-apps-release:
     runs-on: ubuntu-latest

README.md

@@ -309,25 +309,6 @@ PS: for the debug panel, the following JSON is useful for snapping the camera
 
 </details>
 
-### Tauri e2e tests
-
-#### Windows (local only until the CI edge version mismatch is fixed)
-
-```
-yarn install
-yarn build:wasm
-cp src/wasm-lib/pkg/wasm_lib_bg.wasm public
-yarn vite build --mode development
-yarn tauri build --debug -b
-$env:KITTYCAD_API_TOKEN="<YOUR_KITTYCAD_API_TOKEN>"
-$env:VITE_KC_API_BASE_URL="https://api.dev.zoo.dev"
-$env:E2E_TAURI_ENABLED="true"
-$env:TS_NODE_COMPILER_OPTIONS='{"module": "commonjs"}'
-$env:E2E_APPLICATION=".\src-tauri\target\debug\Zoo Modeling App.exe"
-Stop-Process -Name msedgedriver
-yarn wdio run wdio.conf.ts
-```
-
 ## KCL
 
 For how to contribute to KCL, [see our KCL README](https://github.com/KittyCAD/modeling-app/tree/main/src/wasm-lib/kcl).

docs/kcl/std.json

@@ -63731,8 +63731,7 @@
     "examples": [
       "const exampleSketch = startSketchOn(\"XY\")\n  |> startProfileAt([0, 0], %)\n  |> line([10, 0], %)\n  |> line([0, 10], %)\n  |> line([-10, 0], %)\n  |> close(%)\n\nconst example = extrude(5, exampleSketch)\n\nconst exampleSketch002 = startSketchOn(example, 'end')\n  |> startProfileAt([1, 1], %)\n  |> line([8, 0], %)\n  |> line([0, 8], %)\n  |> line([-8, 0], %)\n  |> close(%)\n\nconst example002 = extrude(5, exampleSketch002)\n\nconst exampleSketch003 = startSketchOn(example002, 'end')\n  |> startProfileAt([2, 2], %)\n  |> line([6, 0], %)\n  |> line([0, 6], %)\n  |> line([-6, 0], %)\n  |> close(%)\n\nconst example003 = extrude(5, exampleSketch003)",
       "const exampleSketch = startSketchOn(\"XY\")\n  |> startProfileAt([0, 0], %)\n  |> line([10, 0], %)\n  |> line([0, 10], %, 'sketchingFace')\n  |> line([-10, 0], %)\n  |> close(%)\n\nconst example = extrude(10, exampleSketch)\n\nconst exampleSketch002 = startSketchOn(example, 'sketchingFace')\n  |> startProfileAt([1, 1], %)\n  |> line([8, 0], %)\n  |> line([0, 8], %)\n  |> line([-8, 0], %)\n  |> close(%, 'sketchingFace002')\n\nconst example002 = extrude(10, exampleSketch002)\n\nconst exampleSketch003 = startSketchOn(example002, 'sketchingFace002')\n  |> startProfileAt([-8, 12], %)\n  |> line([0, 6], %)\n  |> line([6, 0], %)\n  |> line([0, -6], %)\n  |> close(%)\n\nconst example003 = extrude(5, exampleSketch003)",
-      "const exampleSketch = startSketchOn('XY')\n  |> startProfileAt([4, 12], %)\n  |> line([2, 0], %)\n  |> line([0, -6], %)\n  |> line([4, -6], %)\n  |> line([0, -6], %)\n  |> line([-3.75, -4.5], %)\n  |> line([0, -5.5], %)\n  |> line([-2, 0], %)\n  |> close(%)\n\nconst example = revolve({ axis: 'y', angle: 180 }, exampleSketch)\n\nconst exampleSketch002 = startSketchOn(example, 'end')\n  |> startProfileAt([4.5, -5], %)\n  |> line([0, 5], %)\n  |> line([5, 0], %)\n  |> line([0, -5], %)\n  |> close(%)\n\nconst example002 = extrude(5, exampleSketch002)",
+      "const exampleSketch = startSketchOn('XY')\n  |> startProfileAt([4, 12], %)\n  |> line([2, 0], %)\n  |> line([0, -6], %)\n  |> line([4, -6], %)\n  |> line([0, -6], %)\n  |> line([-3.75, -4.5], %)\n  |> line([0, -5.5], %)\n  |> line([-2, 0], %)\n  |> close(%)\n\nconst example = revolve({ axis: 'y', angle: 180 }, exampleSketch)\n\nconst exampleSketch002 = startSketchOn(example, 'end')\n  |> startProfileAt([4.5, -5], %)\n  |> line([0, 5], %)\n  |> line([5, 0], %)\n  |> line([0, -5], %)\n  |> close(%)\n\nconst example002 = extrude(5, exampleSketch002)"
-      "const a1 = startSketchOn({\n       plane: {\n         origin: { x: 0, y: 0, z: 0 },\n         x_axis: { x: 1, y: 0, z: 0 },\n         y_axis: { x: 0, y: 1, z: 0 },\n         z_axis: { x: 0, y: 0, z: 1 }\n       }\n     })\n  |> startProfileAt([0, 0], %)\n  |> line([100.0, 0], %)\n  |> yLine(-100.0, %)\n  |> xLine(-100.0, %)\n  |> yLine(100.0, %)\n  |> close(%)\n  |> extrude(3.14, %)"
     ]
   },
   {

e2e/playwright/snapshot-tests.spec.ts

@@ -1,10 +1,10 @@
-import { test, expect } from '@playwright/test'
+import { test, expect, Download } from '@playwright/test'
 import { secrets } from './secrets'
-import { Paths, doExport, getUtils } from './test-utils'
+import { getUtils } from './test-utils'
 import { Models } from '@kittycad/lib'
 import fsp from 'fs/promises'
 import { spawn } from 'child_process'
-import { KCL_DEFAULT_LENGTH } from 'lib/constants'
+import { APP_NAME, KCL_DEFAULT_LENGTH } from 'lib/constants'
 import JSZip from 'jszip'
 import path from 'path'
 import { TEST_SETTINGS, TEST_SETTINGS_KEY } from './storageStates'
@@ -20,7 +20,6 @@ test.beforeEach(async ({ page }) => {
       localStorage.setItem('TOKEN_PERSIST_KEY', token)
       localStorage.setItem('persistCode', ``)
       localStorage.setItem(settingsKey, settings)
-      localStorage.setItem('playwright', 'true')
     },
     {
       token: secrets.token,
@@ -45,7 +44,7 @@ test.setTimeout(60_000)
 test('exports of each format should work', async ({ page, context }) => {
   // FYI this test doesn't work with only engine running locally
   // And you will need to have the KittyCAD CLI installed
-  const u = await getUtils(page)
+  const u = getUtils(page)
   await context.addInitScript(async () => {
     ;(window as any).playwrightSkipFilePicker = true
     localStorage.setItem(
@@ -99,6 +98,78 @@ const part001 = startSketchOn('-XZ')
   await page.waitForTimeout(1000)
   await u.clearAndCloseDebugPanel()
 
+  interface Paths {
+    modelPath: string
+    imagePath: string
+    outputType: string
+  }
+  const doExport = async (
+    output: Models['OutputFormat_type']
+  ): Promise<Paths> => {
+    await page.getByRole('button', { name: APP_NAME }).click()
+    await expect(
+      page.getByRole('button', { name: 'Export Part' })
+    ).toBeVisible()
+    await page.getByRole('button', { name: 'Export Part' }).click()
+    await expect(page.getByTestId('command-bar')).toBeVisible()
+
+    // Go through export via command bar
+    await page.getByRole('option', { name: output.type, exact: false }).click()
+    await page.locator('#arg-form').waitFor({ state: 'detached' })
+    if ('storage' in output) {
+      await page.getByTestId('arg-name-storage').waitFor({ timeout: 1000 })
+      await page.getByRole('button', { name: 'storage', exact: false }).click()
+      await page
+        .getByRole('option', { name: output.storage, exact: false })
+        .click()
+      await page.locator('#arg-form').waitFor({ state: 'detached' })
+    }
+    await expect(page.getByText('Confirm Export')).toBeVisible()
+
+    const getPromiseAndResolve = () => {
+      let resolve: any = () => {}
+      const promise = new Promise<Download>((r) => {
+        resolve = r
+      })
+      return [promise, resolve]
+    }
+
+    const [downloadPromise1, downloadResolve1] = getPromiseAndResolve()
+    let downloadCnt = 0
+
+    page.on('download', async (download) => {
+      if (downloadCnt === 0) {
+        downloadResolve1(download)
+      }
+      downloadCnt++
+    })
+    await page.getByRole('button', { name: 'Submit command' }).click()
+
+    // Handle download
+    const download = await downloadPromise1
+    const downloadLocationer = (extra = '', isImage = false) =>
+      `./e2e/playwright/export-snapshots/${output.type}-${
+        'storage' in output ? output.storage : ''
+      }${extra}.${isImage ? 'png' : output.type}`
+    const downloadLocation = downloadLocationer()
+
+    await download.saveAs(downloadLocation)
+
+    if (output.type === 'step') {
+      // stable timestamps for step files
+      const fileContents = await fsp.readFile(downloadLocation, 'utf-8')
+      const newFileContents = fileContents.replace(
+        /[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}\.[0-9]+[0-9]+[0-9]\+[0-9]{2}:[0-9]{2}/g,
+        '1970-01-01T00:00:00.0+00:00'
+      )
+      await fsp.writeFile(downloadLocation, newFileContents)
+    }
+    return {
+      modelPath: downloadLocation,
+      imagePath: downloadLocationer('', true),
+      outputType: output.type,
+    }
+  }
   const axisDirectionPair: Models['AxisDirectionPair_type'] = {
     axis: 'z',
     direction: 'positive',
@@ -114,114 +185,84 @@ const part001 = startSketchOn('-XZ')
   // just note that only `type` and `storage` are used for selecting the drop downs is the app
   // the rest are only there to make typescript happy
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'step',
-        type: 'step',
+      coords: sysType,
-        coords: sysType,
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'ply',
-        type: 'ply',
+      coords: sysType,
-        coords: sysType,
+      selection: { type: 'default_scene' },
-        selection: { type: 'default_scene' },
+      storage: 'ascii',
-        storage: 'ascii',
+      units: 'in',
-        units: 'in',
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'ply',
-        type: 'ply',
+      storage: 'binary_little_endian',
-        storage: 'binary_little_endian',
+      coords: sysType,
-        coords: sysType,
+      selection: { type: 'default_scene' },
-        selection: { type: 'default_scene' },
+      units: 'in',
-        units: 'in',
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'ply',
-        type: 'ply',
+      storage: 'binary_big_endian',
-        storage: 'binary_big_endian',
+      coords: sysType,
-        coords: sysType,
+      selection: { type: 'default_scene' },
-        selection: { type: 'default_scene' },
+      units: 'in',
-        units: 'in',
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'stl',
-        type: 'stl',
+      storage: 'ascii',
-        storage: 'ascii',
+      coords: sysType,
-        coords: sysType,
+      units: 'in',
-        units: 'in',
+      selection: { type: 'default_scene' },
-        selection: { type: 'default_scene' },
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'stl',
-        type: 'stl',
+      storage: 'binary',
-        storage: 'binary',
+      coords: sysType,
-        coords: sysType,
+      units: 'in',
-        units: 'in',
+      selection: { type: 'default_scene' },
-        selection: { type: 'default_scene' },
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      // obj seems to be a little flaky, times out tests sometimes
-        // obj seems to be a little flaky, times out tests sometimes
+      type: 'obj',
-        type: 'obj',
+      coords: sysType,
-        coords: sysType,
+      units: 'in',
-        units: 'in',
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'gltf',
-        type: 'gltf',
+      storage: 'embedded',
-        storage: 'embedded',
+      presentation: 'pretty',
-        presentation: 'pretty',
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'gltf',
-        type: 'gltf',
+      storage: 'binary',
-        storage: 'binary',
+      presentation: 'pretty',
-        presentation: 'pretty',
+    })
-      },
-      page
-    )
   )
   exportLocations.push(
-    await doExport(
+    await doExport({
-      {
+      type: 'gltf',
-        type: 'gltf',
+      storage: 'standard',
-        storage: 'standard',
+      presentation: 'pretty',
-        presentation: 'pretty',
+    })
-      },
-      page
-    )
   )
 
   // close page to disconnect websocket since we can only have one open atm
@@ -328,7 +369,7 @@ const extrudeDefaultPlane = async (context: any, page: any, plane: string) => {
     localStorage.setItem('persistCode', code)
   })
 
-  const u = await getUtils(page)
+  const u = getUtils(page)
   await page.setViewportSize({ width: 1200, height: 500 })
   await page.goto('/')
   await u.waitForAuthSkipAppStart()
@@ -383,7 +424,7 @@ test.describe('extrude on default planes should be stable', () => {
 })
 
 test('Draft segments should look right', async ({ page, context }) => {
-  const u = await getUtils(page)
+  const u = getUtils(page)
   await page.setViewportSize({ width: 1200, height: 500 })
   const PUR = 400 / 37.5 //pixeltoUnitRatio
   await page.goto('/')
@@ -442,7 +483,7 @@ test('Draft segments should look right', async ({ page, context }) => {
 })
 
 test('Draft rectangles should look right', async ({ page, context }) => {
-  const u = await getUtils(page)
+  const u = getUtils(page)
   await page.setViewportSize({ width: 1200, height: 500 })
   const PUR = 400 / 37.5 //pixeltoUnitRatio
   await page.goto('/')
@@ -489,7 +530,7 @@ test('Draft rectangles should look right', async ({ page, context }) => {
 
 test.describe('Client side scene scale should match engine scale', () => {
   test('Inch scale', async ({ page }) => {
-    const u = await getUtils(page)
+    const u = getUtils(page)
     await page.setViewportSize({ width: 1200, height: 500 })
     const PUR = 400 / 37.5 //pixeltoUnitRatio
     await page.goto('/')
@@ -592,7 +633,7 @@ test.describe('Client side scene scale should match engine scale', () => {
         }),
       }
     )
-    const u = await getUtils(page)
+    const u = getUtils(page)
     await page.setViewportSize({ width: 1200, height: 500 })
     const PUR = 400 / 37.5 //pixeltoUnitRatio
     await page.goto('/')
@@ -678,7 +719,7 @@ test.describe('Client side scene scale should match engine scale', () => {
 })
 
 test('Sketch on face with none z-up', async ({ page, context }) => {
-  const u = await getUtils(page)
+  const u = getUtils(page)
   await context.addInitScript(async (KCL_DEFAULT_LENGTH) => {
     localStorage.setItem(
       'persistCode',
@@ -732,76 +773,3 @@ const part002 = startSketchOn(part001, 'seg01')
     maxDiffPixels: 100,
   })
 })
-
-test('Zoom to fit on load - solid 2d', async ({ page, context }) => {
-  const u = await getUtils(page)
-  await context.addInitScript(async () => {
-    localStorage.setItem(
-      'persistCode',
-      `const part001 = startSketchOn('XY')
-  |> startProfileAt([-10, -10], %)
-  |> line([20, 0], %)
-  |> line([0, 20], %)
-  |> line([-20, 0], %)
-  |> close(%)
-`
-    )
-  }, KCL_DEFAULT_LENGTH)
-
-  await page.setViewportSize({ width: 1200, height: 500 })
-  await page.goto('/')
-  await u.waitForAuthSkipAppStart()
-
-  await u.openDebugPanel()
-  // wait for execution done
-  await expect(
-    page.locator('[data-message-type="execution-done"]')
-  ).toHaveCount(2)
-  await u.closeDebugPanel()
-
-  // Wait for the second extrusion to appear
-  // TODO: Find a way to truly know that the objects have finished
-  // rendering, because an execution-done message is not sufficient.
-  await page.waitForTimeout(1000)
-
-  await expect(page).toHaveScreenshot({
-    maxDiffPixels: 100,
-  })
-})
-
-test('Zoom to fit on load - solid 3d', async ({ page, context }) => {
-  const u = await getUtils(page)
-  await context.addInitScript(async () => {
-    localStorage.setItem(
-      'persistCode',
-      `const part001 = startSketchOn('XY')
-  |> startProfileAt([-10, -10], %)
-  |> line([20, 0], %)
-  |> line([0, 20], %)
-  |> line([-20, 0], %)
-  |> close(%)
-  |> extrude(10, %)
-`
-    )
-  }, KCL_DEFAULT_LENGTH)
-
-  await page.setViewportSize({ width: 1200, height: 500 })
-  await page.goto('/')
-  await u.waitForAuthSkipAppStart()
-
-  await u.openDebugPanel()
-  // wait for execution done
-  await expect(
-    page.locator('[data-message-type="execution-done"]')
-  ).toHaveCount(2)
-  await u.closeDebugPanel()
-
-  // Wait for the second extrusion to appear
-  // TODO: Find a way to truly know that the objects have finished
-  // rendering, because an execution-done message is not sufficient.
-  await page.waitForTimeout(1000)
-
-  await expect(page).toHaveScreenshot({
-    maxDiffPixels: 100,
-  })
-})

e2e/playwright/test-utils.ts

@@ -1,11 +1,8 @@
-import { test, expect, Page, Download } from '@playwright/test'
+import { expect, Page } from '@playwright/test'
 import { EngineCommand } from '../../src/lang/std/engineConnection'
 import fsp from 'fs/promises'
 import pixelMatch from 'pixelmatch'
 import { PNG } from 'pngjs'
-import { Protocol } from 'playwright-core/types/protocol'
-import type { Models } from '@kittycad/lib'
-import { APP_NAME } from 'lib/constants'
 
 async function waitForPageLoad(page: Page) {
   // wait for 'Loading stream...' spinner
@@ -96,12 +93,7 @@ async function waitForCmdReceive(page: Page, commandType: string) {
     .waitFor()
 }
 
-export async function getUtils(page: Page) {
+export function getUtils(page: Page) {
-  // Chrome devtools protocol session only works in Chromium
-  const browserType = page.context().browser()?.browserType().name()
-  const cdpSession =
-    browserType !== 'chromium' ? null : await page.context().newCDPSession(page)
-
   return {
     waitForAuthSkipAppStart: () => waitForPageLoad(page),
     removeCurrentCode: () => removeCurrentCode(page),
@@ -132,24 +124,6 @@ export async function getUtils(page: Page) {
     },
     waitForCmdReceive: (commandType: string) =>
       waitForCmdReceive(page, commandType),
-    getSegmentBodyCoords: async (locator: string, px = 30) => {
-      const overlay = page.locator(locator)
-      const bbox = await overlay
-        .boundingBox()
-        .then((box) => ({ ...box, x: box?.x || 0, y: box?.y || 0 }))
-      const angle = Number(await overlay.getAttribute('data-overlay-angle'))
-      const angleXOffset = Math.cos(((angle - 180) * Math.PI) / 180) * px
-      const angleYOffset = Math.sin(((angle - 180) * Math.PI) / 180) * px
-      return {
-        x: bbox.x + angleXOffset,
-        y: bbox.y - angleYOffset,
-      }
-    },
-    getBoundingBox: async (locator: string) =>
-      page
-        .locator(locator)
-        .boundingBox()
-        .then((box) => ({ x: box?.x || 0, y: box?.y || 0 })),
     doAndWaitForCmd: async (
       fn: () => Promise<void>,
       commandType: string,
@@ -206,17 +180,6 @@ export async function getUtils(page: Page) {
           }
         }, 50)
       }),
-    emulateNetworkConditions: async (
-      networkOptions: Protocol.Network.emulateNetworkConditionsParameters
-    ) => {
-      // Skip on non-Chromium browsers, since we need to use the CDP.
-      test.skip(
-        cdpSession === null,
-        'Network emulation is only supported in Chromium'
-      )
-
-      cdpSession?.send('Network.emulateNetworkConditions', networkOptions)
-    },
   }
 }
 
@@ -292,77 +255,3 @@ export const makeTemplate: (
       ),
   }
 }
-
-export interface Paths {
-  modelPath: string
-  imagePath: string
-  outputType: string
-}
-
-export const doExport = async (
-  output: Models['OutputFormat_type'],
-  page: Page
-): Promise<Paths> => {
-  await page.getByRole('button', { name: APP_NAME }).click()
-  await expect(page.getByRole('button', { name: 'Export Part' })).toBeVisible()
-  await page.getByRole('button', { name: 'Export Part' }).click()
-  await expect(page.getByTestId('command-bar')).toBeVisible()
-
-  // Go through export via command bar
-  await page.getByRole('option', { name: output.type, exact: false }).click()
-  await page.locator('#arg-form').waitFor({ state: 'detached' })
-  if ('storage' in output) {
-    await page.getByTestId('arg-name-storage').waitFor({ timeout: 1000 })
-    await page.getByRole('button', { name: 'storage', exact: false }).click()
-    await page
-      .getByRole('option', { name: output.storage, exact: false })
-      .click()
-    await page.locator('#arg-form').waitFor({ state: 'detached' })
-  }
-  await expect(page.getByText('Confirm Export')).toBeVisible()
-
-  const getPromiseAndResolve = () => {
-    let resolve: any = () => {}
-    const promise = new Promise<Download>((r) => {
-      resolve = r
-    })
-    return [promise, resolve]
-  }
-
-  const [downloadPromise1, downloadResolve1] = getPromiseAndResolve()
-  let downloadCnt = 0
-
-  page.on('download', async (download) => {
-    if (downloadCnt === 0) {
-      downloadResolve1(download)
-    }
-    downloadCnt++
-  })
-  await page.getByRole('button', { name: 'Submit command' }).click()
-
-  // Handle download
-  const download = await downloadPromise1
-  const downloadLocationer = (extra = '', isImage = false) =>
-    `./e2e/playwright/export-snapshots/${output.type}-${
-      'storage' in output ? output.storage : ''
-    }${extra}.${isImage ? 'png' : output.type}`
-  const downloadLocation = downloadLocationer()
-
-  await download.saveAs(downloadLocation)
-
-  if (output.type === 'step') {
-    // stable timestamps for step files
-    const fileContents = await fsp.readFile(downloadLocation, 'utf-8')
-    const newFileContents = fileContents.replace(
-      /[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}\.[0-9]+[0-9]+[0-9]\+[0-9]{2}:[0-9]{2}/g,
-      '1970-01-01T00:00:00.0+00:00'
-    )
-    await fsp.writeFile(downloadLocation, newFileContents)
-  }
-
-  return {
-    modelPath: downloadLocation,
-    imagePath: downloadLocationer('', true),
-    outputType: output.type,
-  }
-}

e2e/tauri/specs/auth.e2e.ts

@@ -1,19 +1,11 @@
 import { browser, $, expect } from '@wdio/globals'
 import fs from 'fs/promises'
-import path from 'path'
-import os from 'os'
 
-const isWin32 = os.platform() === 'win32'
+const documentsDir = `${process.env.HOME}/Documents`
-const documentsDir = path.join(os.homedir(), 'Documents')
+const userSettingsDir = `${process.env.HOME}/.config/dev.zoo.modeling-app`
-const userSettingsDir = path.join(
+const defaultProjectDir = `${documentsDir}/zoo-modeling-app-projects`
-  os.homedir(),
+const newProjectDir = `${documentsDir}/a-different-directory`
-  '.config',
+const userCodeDir = '/tmp/kittycad_user_code'
-  'dev.zoo.modeling-app'
-)
-const defaultProjectDir = path.join(documentsDir, 'zoo-modeling-app-projects')
-const newProjectDir = path.join(documentsDir, 'a-different-directory')
-const tmp = process.env.TEMP || '/tmp'
-const userCodeDir = path.join(tmp, 'kittycad_user_code')
 
 async function click(element: WebdriverIO.Element): Promise<void> {
   // Workaround for .click(), see https://github.com/tauri-apps/tauri/issues/6541
@@ -32,7 +24,7 @@ async function setDatasetValue(
   await browser.execute(`arguments[0].dataset.${property} = "${value}"`, field)
 }
 
-describe('ZMA (Tauri)', () => {
+describe('ZMA (Tauri, Linux)', () => {
   it('opens the auth page and signs in', async () => {
     // Clean up filesystem from previous tests
     await new Promise((resolve) => setTimeout(resolve, 100))
@@ -50,7 +42,9 @@ describe('ZMA (Tauri)', () => {
     await new Promise((resolve) => setTimeout(resolve, 2000))
 
     // Get from main.rs
-    const userCode = await (await fs.readFile(userCodeDir)).toString()
+    const userCode = await (
+      await fs.readFile('/tmp/kittycad_user_code')
+    ).toString()
     console.log(`Found user code ${userCode}`)
 
     // Device flow: verify
@@ -98,12 +92,7 @@ describe('ZMA (Tauri)', () => {
      * to be able to skip the folder selection dialog if data-testValue
      * has a value, allowing us to test the input otherwise works.
      */
-    // TODO: understand why we need to force double \ on Windows
+    await setDatasetValue(projectDirInput, 'testValue', newProjectDir)
-    await setDatasetValue(
-      projectDirInput,
-      'testValue',
-      isWin32 ? newProjectDir.replaceAll('\\', '\\\\') : newProjectDir
-    )
     const projectDirButton = await $('[data-testid="project-directory-button"]')
     await click(projectDirButton)
     await new Promise((resolve) => setTimeout(resolve, 500))
@@ -113,15 +102,6 @@ describe('ZMA (Tauri)', () => {
     const nameInput = await $('[data-testid="projects-defaultProjectName"]')
     expect(await nameInput.getValue()).toEqual('project-$nnn')
 
-    // Setting it back (for back to back local tests)
-    await new Promise((resolve) => setTimeout(resolve, 5000))
-    await setDatasetValue(
-      projectDirInput,
-      'testValue',
-      isWin32 ? defaultProjectDir.replaceAll('\\', '\\\\') : newProjectDir
-    )
-    await click(projectDirButton)
-
     const closeButton = await $('[data-testid="settings-close-button"]')
     await click(closeButton)
   })
@@ -140,15 +120,9 @@ describe('ZMA (Tauri)', () => {
   it('opens the new file and expects a loading stream', async () => {
     const projectLink = await $('[data-testid="project-link"]')
     await click(projectLink)
-    if (isWin32) {
+    const errorText = await $('[data-testid="unexpected-error"]')
-      // TODO: actually do something to check that the stream is up
+    expect(await errorText.getText()).toContain('unexpected error')
-      await new Promise((resolve) => setTimeout(resolve, 5000))
+    await browser.execute('window.location.href = "tauri://localhost/home"')
-    } else {
-      const errorText = await $('[data-testid="unexpected-error"]')
-      expect(await errorText.getText()).toContain('unexpected error')
-    }
-    const base = isWin32 ? 'http://tauri.localhost' : 'tauri://localhost'
-    await browser.execute(`window.location.href = "${base}/home"`)
   })
 
   it('signs out', async () => {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "untitled-app",
-  "version": "0.22.0",
+  "version": "0.21.7",
   "private": true,
   "dependencies": {
     "@codemirror/autocomplete": "^6.16.0",
@@ -10,12 +10,12 @@
     "@fortawesome/react-fontawesome": "^0.2.0",
     "@headlessui/react": "^1.7.19",
     "@headlessui/tailwindcss": "^0.2.0",
-    "@kittycad/lib": "^0.0.63",
+    "@kittycad/lib": "^0.0.60",
     "@lezer/javascript": "^1.4.9",
     "@open-rpc/client-js": "^1.8.1",
-    "@react-hook/resize-observer": "^2.0.1",
+    "@react-hook/resize-observer": "^1.2.6",
     "@replit/codemirror-interact": "^6.3.1",
-    "@tauri-apps/api": "2.0.0-beta.12",
+    "@tauri-apps/api": "2.0.0-beta.8",
     "@tauri-apps/plugin-dialog": "^2.0.0-beta.2",
     "@tauri-apps/plugin-fs": "^2.0.0-beta.3",
     "@tauri-apps/plugin-http": "^2.0.0-beta.2",
@@ -37,7 +37,7 @@
     "crypto-js": "^4.2.0",
     "debounce-promise": "^3.1.2",
     "decamelize": "^6.0.0",
-    "formik": "^2.4.6",
+    "formik": "^2.4.5",
     "fuse.js": "^7.0.0",
     "html2canvas-pro": "^1.4.3",
     "http-server": "^14.1.1",
@@ -61,11 +61,11 @@
     "ua-parser-js": "^1.0.37",
     "uuid": "^9.0.1",
     "vitest": "^1.6.0",
-    "vscode-jsonrpc": "^8.2.1",
+    "vscode-jsonrpc": "^8.1.0",
     "vscode-languageserver-protocol": "^3.17.5",
     "wasm-pack": "^0.12.1",
     "web-vitals": "^3.5.2",
-    "ws": "^8.17.0",
+    "ws": "^8.16.0",
     "xstate": "^4.38.2",
     "zustand": "^4.5.2"
   },
@@ -133,7 +133,7 @@
     "@types/wait-on": "^5.3.4",
     "@types/wicg-file-system-access": "^2023.10.5",
     "@types/ws": "^8.5.10",
-    "@vitejs/plugin-react": "^4.3.0",
+    "@vitejs/plugin-react": "^4.2.1",
     "@vitest/web-worker": "^1.5.0",
     "@wdio/cli": "^8.24.3",
     "@wdio/globals": "^8.36.0",

src-tauri/Cargo.lock

@@ -195,7 +195,6 @@ dependencies = [
  "tauri-plugin-http",
  "tauri-plugin-log",
  "tauri-plugin-os",
- "tauri-plugin-persisted-scope",
  "tauri-plugin-process",
  "tauri-plugin-shell",
  "tauri-plugin-updater",
@@ -344,7 +343,7 @@ checksum = "3b43422f69d8ff38f95f1b2bb76517c91589a924d1559a0e935d7c8ce0274c11"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -379,7 +378,7 @@ checksum = "c6fa2087f2753a7da8cc1c0dbfcf89579dd57458e36769de5ac750b4671737ca"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -425,7 +424,7 @@ checksum = "3c87f3f15e7794432337fc718554eaa4dc8f04c9677a950ffe366f20a162ae42"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -574,7 +573,7 @@ dependencies = [
  "proc-macro-crate 3.1.0",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
  "syn_derive",
 ]
 
@@ -883,7 +882,7 @@ dependencies = [
  "heck 0.5.0",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1085,7 +1084,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "13b588ba4ac1a99f7f2964d24b3d896ddc6bf847ee3855dbd4366f058cfcd331"
 dependencies = [
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1095,7 +1094,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "edb49164822f3ee45b17acd4a208cfc1251410cf0cad9a833234c9890774dd9f"
 dependencies = [
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1119,7 +1118,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "strsim 0.10.0",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1130,7 +1129,7 @@ checksum = "a668eda54683121533a393014d8692171709ff57a7d61f187b6e782719f8933f"
 dependencies = [
  "darling_core",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1177,7 +1176,7 @@ checksum = "377af281d8f23663862a7c84623bc5dcf7f8c44b13c7496a590bdc157f941a43"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
  "synstructure",
 ]
 
@@ -1214,7 +1213,7 @@ dependencies = [
  "regex",
  "serde",
  "serde_tokenstream",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1225,7 +1224,7 @@ checksum = "67e77553c4162a157adbf834ebae5b415acbecbeafc7a74b0e886657506a7611"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1287,7 +1286,7 @@ checksum = "487585f4d0c6655fe74905e2504d8ad6908e4db67f744eb140876906c2f3175d"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1319,7 +1318,7 @@ checksum = "f2b99bf03862d7f545ebc28ddd33a665b50865f4dfd84031a393823879bd4c54"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1417,7 +1416,7 @@ checksum = "5c785274071b1b420972453b306eeca06acf4633829db4223b58a2a8c5953bc4"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1568,7 +1567,7 @@ checksum = "1a5c6c585bc94aaf2c7b51dd4c2ba22680844aba4c687be581871a6f518c5742"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1684,7 +1683,7 @@ checksum = "87750cf4b7a4c0625b1529e4c543c2182106e4dedc60a2a6455e00d212c489ac"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1960,7 +1959,7 @@ dependencies = [
  "proc-macro-error",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -1988,7 +1987,7 @@ dependencies = [
  "inflections",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -2063,7 +2062,7 @@ dependencies = [
  "proc-macro-error",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -2461,6 +2460,15 @@ dependencies = [
  "once_cell",
 ]
 
+[[package]]
+name = "itertools"
+version = "0.10.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "b0fd2260e829bddf4cb6ea802289de2f86d6a7a690192fbe91b3f46e0f2c8473"
+dependencies = [
+ "either",
+]
+
 [[package]]
 name = "itertools"
 version = "0.12.1"
@@ -2559,7 +2567,7 @@ dependencies = [
 
 [[package]]
 name = "kcl-lib"
-version = "0.1.58"
+version = "0.1.57"
 dependencies = [
  "anyhow",
  "approx",
@@ -2582,7 +2590,7 @@ dependencies = [
  "kittycad-execution-plan-traits",
  "lazy_static",
  "mime_guess",
- "parse-display",
+ "parse-display 0.9.0",
  "reqwest 0.11.27",
  "ropey",
  "schemars",
@@ -2602,7 +2610,7 @@ dependencies = [
  "wasm-bindgen-futures",
  "web-sys",
  "winnow 0.5.40",
- "zip 2.1.1",
+ "zip 1.3.0",
 ]
 
 [[package]]
@@ -2618,13 +2626,13 @@ dependencies = [
 
 [[package]]
 name = "kittycad"
-version = "0.3.3"
+version = "0.3.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b0cbef813153197e60c0e96f59eea0b75f8418380f414b20250ee81b60e522c3"
+checksum = "2c6e12eb45fd9a28c8e99dbdef54556246b39acee14e4aa6f0fc43636caa62d9"
 dependencies = [
  "anyhow",
  "async-trait",
- "base64 0.22.1",
+ "base64 0.21.7",
  "bigdecimal",
  "bytes",
  "chrono",
@@ -2633,10 +2641,10 @@ dependencies = [
  "format_serde_error",
  "futures",
  "http 0.2.12",
- "itertools",
+ "itertools 0.10.5",
  "log",
  "mime_guess",
- "parse-display",
+ "parse-display 0.8.2",
  "phonenumber",
  "rand 0.8.5",
  "reqwest 0.11.27",
@@ -2663,7 +2671,7 @@ checksum = "0611fc9b9786175da21d895ffa0f65039e19c9111e94a41b7af999e3b95f045f"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -3351,17 +3359,43 @@ dependencies = [
  "windows-targets 0.48.5",
 ]
 
+[[package]]
+name = "parse-display"
+version = "0.8.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c6509d08722b53e8dafe97f2027b22ccbe3a5db83cb352931e9716b0aa44bc5c"
+dependencies = [
+ "once_cell",
+ "parse-display-derive 0.8.2",
+ "regex",
+]
+
 [[package]]
 name = "parse-display"
 version = "0.9.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "06af5f9333eb47bd9ba8462d612e37a8328a5cb80b13f0af4de4c3b89f52dee5"
 dependencies = [
- "parse-display-derive",
+ "parse-display-derive 0.9.0",
  "regex",
  "regex-syntax 0.8.3",
 ]
 
+[[package]]
+name = "parse-display-derive"
+version = "0.8.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "68517892c8daf78da08c0db777fcc17e07f2f63ef70041718f8a7630ad84f341"
+dependencies = [
+ "once_cell",
+ "proc-macro2",
+ "quote",
+ "regex",
+ "regex-syntax 0.7.5",
+ "structmeta 0.2.0",
+ "syn 2.0.65",
+]
+
 [[package]]
 name = "parse-display-derive"
 version = "0.9.0"
@@ -3372,8 +3406,8 @@ dependencies = [
  "quote",
  "regex",
  "regex-syntax 0.8.3",
- "structmeta",
+ "structmeta 0.3.0",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -3515,7 +3549,7 @@ dependencies = [
  "phf_shared 0.11.2",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -3547,14 +3581,14 @@ dependencies = [
 
 [[package]]
 name = "phonenumber"
-version = "0.3.5+8.13.36"
+version = "0.3.4+8.13.34"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f174c8db59b620032bd52b655fc97000458850fec0db35fcd4e802b668517ec0"
+checksum = "8d888d375f2963bf06c5079665fbe53db69860879ff5a78524fe3c93c54fb7b8"
 dependencies = [
  "bincode",
  "either",
  "fnv",
- "itertools",
+ "itertools 0.12.1",
  "lazy_static",
  "nom",
  "quick-xml",
@@ -3583,7 +3617,7 @@ checksum = "2f38a4412a78282e09a2cf38d195ea5420d15ba0602cb375210efbc877243965"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -3735,9 +3769,9 @@ checksum = "dc375e1527247fe1a97d8b7156678dfe7c1af2fc075c9a4db3690ecd2a148068"
 
 [[package]]
 name = "proc-macro2"
-version = "1.0.83"
+version = "1.0.81"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0b33eb56c327dec362a9e55b3ad14f9d2f0904fb5a5b03b513ab5465399e9f43"
+checksum = "3d1597b0c024618f09a9c3b8655b7e430397a36d23fdafec26d6965e9eec3eba"
 dependencies = [
  "unicode-ident",
 ]
@@ -3967,6 +4001,12 @@ version = "0.6.29"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "f162c6dd7b008981e4d40210aca20b4bd0f9b60ca9271061b07f78537722f2e1"
 
+[[package]]
+name = "regex-syntax"
+version = "0.7.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "dbb5fb1acd8a1a18b3dd5be62d25485eb770e05afb408a9627d14d451bae12da"
+
 [[package]]
 name = "regex-syntax"
 version = "0.8.3"
@@ -4415,7 +4455,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "serde_derive_internals",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4500,9 +4540,9 @@ dependencies = [
 
 [[package]]
 name = "serde"
-version = "1.0.203"
+version = "1.0.202"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7253ab4de971e72fb7be983802300c30b5a7f0c2e56fab8abfc6a214307c0094"
+checksum = "226b61a0d411b2ba5ff6d7f73a476ac4f8bb900373459cd00fab8512828ba395"
 dependencies = [
  "serde_derive",
 ]
@@ -4518,13 +4558,13 @@ dependencies = [
 
 [[package]]
 name = "serde_derive"
-version = "1.0.203"
+version = "1.0.202"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "500cbc0ebeb6f46627f50f3f5811ccf6bf00643be300b4c3eabc0ef55dc5b5ba"
+checksum = "6048858004bcff69094cd972ed40a32500f153bd3be9f716b2eed2e8217c4838"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4535,7 +4575,7 @@ checksum = "330f01ce65a3a5fe59a60c82f3c9a024b573b8a6e875bd233fe5f934e71d54e3"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4568,7 +4608,7 @@ checksum = "6c64451ba24fc7a6a2d60fc75dd9c83c90903b19028d4eff35e88fc1e86564e9"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4589,7 +4629,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "serde",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4631,7 +4671,7 @@ dependencies = [
  "darling",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4890,6 +4930,18 @@ version = "0.11.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "7da8b5736845d9f2fcb837ea5d9e2628564b3b043a70948a3f0b778838c5fb4f"
 
+[[package]]
+name = "structmeta"
+version = "0.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "78ad9e09554f0456d67a69c1584c9798ba733a5b50349a6c0d0948710523922d"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "structmeta-derive 0.2.0",
+ "syn 2.0.65",
+]
+
 [[package]]
 name = "structmeta"
 version = "0.3.0"
@@ -4898,8 +4950,19 @@ checksum = "2e1575d8d40908d70f6fd05537266b90ae71b15dbbe7a8b7dffa2b759306d329"
 dependencies = [
  "proc-macro2",
  "quote",
- "structmeta-derive",
+ "structmeta-derive 0.3.0",
- "syn 2.0.66",
+ "syn 2.0.65",
+]
+
+[[package]]
+name = "structmeta-derive"
+version = "0.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "a60bcaff7397072dca0017d1db428e30d5002e00b6847703e2e42005c95fbe00"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4910,7 +4973,7 @@ checksum = "152a0b65a590ff6c3da95cabe2353ee04e6167c896b28e3b14478c2636c922fc"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4932,7 +4995,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "rustversion",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -4965,9 +5028,9 @@ dependencies = [
 
 [[package]]
 name = "syn"
-version = "2.0.66"
+version = "2.0.65"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c42f3f41a2de00b01c0aaad383c5a45241efc8b2d1eda5661812fda5f3cdcff5"
+checksum = "d2863d96a84c6439701d7a38f9de935ec562c8832cc55d1dde0f513b52fad106"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -4983,7 +5046,7 @@ dependencies = [
  "proc-macro-error",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -5000,7 +5063,7 @@ checksum = "c8af7666ab7b6390ab78131fb5b0fce11d6b7a6951602017c35fa82800708971"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -5217,7 +5280,7 @@ dependencies = [
  "serde",
  "serde_json",
  "sha2",
- "syn 2.0.66",
+ "syn 2.0.65",
  "tauri-utils",
  "thiserror",
  "time",
@@ -5235,7 +5298,7 @@ dependencies = [
  "heck 0.4.1",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
  "tauri-codegen",
  "tauri-utils",
 ]
@@ -5307,9 +5370,9 @@ dependencies = [
 
 [[package]]
 name = "tauri-plugin-fs"
-version = "2.0.0-beta.7"
+version = "2.0.0-beta.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "35377195c6923beda5f29482a16b492d431de964389fca9aaf81a0f7e908023f"
+checksum = "609f53d90f08808679ecdd81455d9a4d0053291b92780695569f7400fdba27d5"
 dependencies = [
  "anyhow",
  "glob",
@@ -5384,22 +5447,6 @@ dependencies = [
  "thiserror",
 ]
 
-[[package]]
-name = "tauri-plugin-persisted-scope"
-version = "2.0.0-beta.7"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b600c870217ec082b0f3482935a8edad347d18e8cd7d422a74bc92d035c0e394"
-dependencies = [
- "aho-corasick",
- "bincode",
- "log",
- "serde",
- "serde_json",
- "tauri",
- "tauri-plugin-fs",
- "thiserror",
-]
-
 [[package]]
 name = "tauri-plugin-process"
 version = "2.0.0-beta.3"
@@ -5601,7 +5648,7 @@ checksum = "46c3384250002a6d5af4d114f2845d37b57521033f30d5c3f46c4d70e1197533"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -5690,7 +5737,7 @@ checksum = "5b8a1e28f2deaa14e508979454cb3a223b10b938b45af148bc0986de36f1923b"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -5879,7 +5926,7 @@ checksum = "84fd902d4e0b9a4b27f2f440108dc034e1758628a9b702f8ec61ad66355422fa"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -5908,7 +5955,7 @@ checksum = "34704c8d6ebcbc939824180af020566b01a7c01f80641264eba0999f6c2b6be7"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -6029,7 +6076,7 @@ source = "git+https://github.com/Aleph-Alpha/ts-rs#f898578d80d3e2a54080c1c046c45
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
  "termcolor",
 ]
 
@@ -6242,7 +6289,7 @@ dependencies = [
  "proc-macro-error",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -6341,7 +6388,7 @@ dependencies = [
  "once_cell",
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
  "wasm-bindgen-shared",
 ]
 
@@ -6375,7 +6422,7 @@ checksum = "e94f17b526d0a461a191c78ea52bbce64071ed5c04c9ffe424dcb38f74171bb7"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
  "wasm-bindgen-backend",
  "wasm-bindgen-shared",
 ]
@@ -6516,7 +6563,7 @@ checksum = "ac1345798ecd8122468840bcdf1b95e5dc6d2206c5e4b0eafa078d061f59c9bc"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -6622,7 +6669,7 @@ checksum = "f6fc35f58ecd95a9b71c4f2329b911016e6bec66b3f2e6a4aad86bd2e99e2f9b"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -6633,7 +6680,7 @@ checksum = "08990546bf4edef8f431fa6326e032865f27138718c587dc21bc0265bbcb57cc"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -7075,7 +7122,7 @@ checksum = "9ce1b18ccd8e73a9321186f97e46f9f04b778851177567b1975109d26a08d2a6"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.66",
+ "syn 2.0.65",
 ]
 
 [[package]]
@@ -7106,16 +7153,15 @@ dependencies = [
 
 [[package]]
 name = "zip"
-version = "2.1.1"
+version = "1.3.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1dd56a4d5921bc2f99947ac5b3abe5f510b1be7376fdc5e9fce4a23c6a93e87c"
+checksum = "f1f4a27345eb6f7aa7bd015ba7eb4175fa4e1b462a29874b779e0bbcf96c6ac7"
 dependencies = [
  "arbitrary",
  "crc32fast",
  "crossbeam-utils",
  "displaydoc",
  "indexmap 2.2.6",
- "memchr",
  "thiserror",
 ]
 

src-tauri/Cargo.toml

@@ -28,7 +28,6 @@ tauri-plugin-fs = { version = "2.0.0-beta.6" }
 tauri-plugin-http = { version = "2.0.0-beta.6" }
 tauri-plugin-log = { version = "2.0.0-beta.4" }
 tauri-plugin-os = { version = "2.0.0-beta.2" }
-tauri-plugin-persisted-scope = { version = "2.0.0-beta.7" }
 tauri-plugin-process = { version = "2.0.0-beta.2" }
 tauri-plugin-shell = { version = "2.0.0-beta.2" }
 tauri-plugin-updater = { version = "2.0.0-beta.4" }

src-tauri/capabilities/desktop.json

@@ -32,15 +32,6 @@
     {
       "identifier": "fs:scope",
       "allow": [
-        {
-          "path": "$TEMP"
-        },
-        {
-          "path": "$TEMP/**/*"
-        },
-        {
-          "path": "$HOME"
-        },
         {
           "path": "$HOME/**/*"
         },

src-tauri/src/main.rs

@@ -267,15 +267,7 @@ async fn login(app: tauri::AppHandle, host: &str) -> Result<String, InvokeError>
     let e2e_tauri_enabled = env::var("E2E_TAURI_ENABLED").is_ok();
     if e2e_tauri_enabled {
         log::warn!("E2E_TAURI_ENABLED is set, won't open {} externally", auth_uri.secret());
-        let mut temp = String::from("/tmp");
+        tokio::fs::write("/tmp/kittycad_user_code", details.user_code().secret())
-        // Overwrite with Windows variable
-        match env::var("TEMP") {
-            Ok(val) => temp = val,
-            Err(_e) => println!("Fallback to default /tmp"),
-        }
-        let path = Path::new(&temp).join("kittycad_user_code");
-        println!("Writing to {}", path.to_string_lossy());
-        tokio::fs::write(path, details.user_code().secret())
             .await
             .map_err(|e| InvokeError::from_anyhow(e.into()))?;
     } else {
@@ -433,7 +425,6 @@ fn main() -> Result<()> {
                 .build(),
         )
         .plugin(tauri_plugin_os::init())
-        .plugin(tauri_plugin_persisted_scope::init())
         .plugin(tauri_plugin_process::init())
         .plugin(tauri_plugin_shell::init())
         .setup(|app| {

src-tauri/tauri.conf.json

@@ -74,5 +74,5 @@
     }
   },
   "productName": "Zoo Modeling App",
-  "version": "0.22.0"
+  "version": "0.21.7"
 }

src/App.tsx

@@ -24,7 +24,6 @@ import { ModelingSidebar } from 'components/ModelingSidebar/ModelingSidebar'
 import { LowerRightControls } from 'components/LowerRightControls'
 import ModalContainer from 'react-modal-promise'
 import useHotkeyWrapper from 'lib/hotkeyWrapper'
-import Gizmo from 'components/Gizmo'
 
 export function App() {
   useRefreshSettings(paths.FILE + 'SETTINGS')
@@ -129,9 +128,7 @@ export function App() {
       <ModelingSidebar paneOpacity={paneOpacity} />
       <Stream className="absolute inset-0 z-0" />
       {/* <CamToggle /> */}
-      <LowerRightControls>
+      <LowerRightControls />
-        <Gizmo />
-      </LowerRightControls>
     </div>
   )
 }

src/Toolbar.tsx

@@ -15,12 +15,10 @@ import { ActionButtonDropdown } from 'components/ActionButtonDropdown'
 import { useHotkeys } from 'react-hotkeys-hook'
 import Tooltip from 'components/Tooltip'
 
-export function Toolbar({
+export const Toolbar = () => {
-  className = '',
-  ...props
-}: React.HTMLAttributes<HTMLElement>) {
-  const { state, send, context } = useModelingContext()
   const { commandBarSend } = useCommandsContext()
+  const { state, send, context } = useModelingContext()
+  const toolbarButtonsRef = useRef<HTMLUListElement>(null)
   const iconClassName =
     'group-disabled:text-chalkboard-50 group-enabled:group-hover:!text-primary dark:group-enabled:group-hover:!text-inherit group-pressed:!text-chalkboard-10 group-ui-open:!text-chalkboard-10 dark:group-ui-open:!text-chalkboard-10'
   const bgClassName =
@@ -36,9 +34,6 @@ export function Toolbar({
       context.selectionRanges
     )
   }, [engineCommandManager.artifactMap, context.selectionRanges])
-
-  const toolbarButtonsRef = useRef<HTMLUListElement>(null)
-
   const { overallState } = useNetworkStatus()
   const { isExecuting } = useKclContext()
   const { isStreamReady } = useStore((s) => ({
@@ -105,45 +100,12 @@ export function Toolbar({
 
     span.scrollLeft = span.scrollLeft += ev.deltaY
   }
-  const nextEvents = useMemo(() => state.nextEvents, [state.nextEvents])
-  const splitMenuItems = useMemo(
-    () =>
-      nextEvents
-        .filter(
-          (eventName) =>
-            eventName.includes('Make segment') ||
-            eventName.includes('Constrain')
-        )
-        .sort((a, b) => {
-          const aisEnabled = nextEvents
-            .filter((event) => state.can(event as any))
-            .includes(a)
-          const bIsEnabled = nextEvents
-            .filter((event) => state.can(event as any))
-            .includes(b)
-          if (aisEnabled && !bIsEnabled) {
-            return -1
-          }
-          if (!aisEnabled && bIsEnabled) {
-            return 1
-          }
-          return 0
-        })
-        .map((eventName) => ({
-          label: eventName
-            .replace('Make segment ', '')
-            .replace('Constrain ', ''),
-          onClick: () => send(eventName),
-          disabled:
-            !nextEvents
-              .filter((event) => state.can(event as any))
-              .includes(eventName) || disableAllButtons,
-        })),
 
-    [JSON.stringify(nextEvents), state]
+  function ToolbarButtons({
-  )
+    className = '',
-  return (
+    ...props
-    <menu className="max-w-full whitespace-nowrap rounded px-1.5 py-0.5 backdrop-blur-sm bg-chalkboard-10/80 dark:bg-chalkboard-110/70 relative">
+  }: React.HTMLAttributes<HTMLElement>) {
+    return (
       <ul
         {...props}
         ref={toolbarButtonsRef}
@@ -151,7 +113,7 @@ export function Toolbar({
         className={'m-0 py-1 rounded-l-sm flex gap-2 items-center ' + className}
         style={{ scrollbarWidth: 'thin' }}
       >
-        {nextEvents.includes('Enter sketch') && (
+        {state.nextEvents.includes('Enter sketch') && (
           <li className="contents">
             <ActionButton
               className={buttonClassName}
@@ -177,7 +139,7 @@ export function Toolbar({
             </ActionButton>
           </li>
         )}
-        {nextEvents.includes('Enter sketch') && pathId && (
+        {state.nextEvents.includes('Enter sketch') && pathId && (
           <li className="contents">
             <ActionButton
               className={buttonClassName}
@@ -201,7 +163,7 @@ export function Toolbar({
             </ActionButton>
           </li>
         )}
-        {nextEvents.includes('Cancel') && !state.matches('idle') && (
+        {state.nextEvents.includes('Cancel') && !state.matches('idle') && (
           <li className="contents">
             <ActionButton
               className={buttonClassName}
@@ -324,13 +286,43 @@ export function Toolbar({
           </>
         )}
         {state.matches('Sketch.SketchIdle') &&
-          nextEvents.filter(
+          state.nextEvents.filter(
             (eventName) =>
               eventName.includes('Make segment') ||
               eventName.includes('Constrain')
           ).length > 0 && (
             <ActionButtonDropdown
-              splitMenuItems={splitMenuItems}
+              splitMenuItems={state.nextEvents
+                .filter(
+                  (eventName) =>
+                    eventName.includes('Make segment') ||
+                    eventName.includes('Constrain')
+                )
+                .sort((a, b) => {
+                  const aisEnabled = state.nextEvents
+                    .filter((event) => state.can(event as any))
+                    .includes(a)
+                  const bIsEnabled = state.nextEvents
+                    .filter((event) => state.can(event as any))
+                    .includes(b)
+                  if (aisEnabled && !bIsEnabled) {
+                    return -1
+                  }
+                  if (!aisEnabled && bIsEnabled) {
+                    return 1
+                  }
+                  return 0
+                })
+                .map((eventName) => ({
+                  label: eventName
+                    .replace('Make segment ', '')
+                    .replace('Constrain ', ''),
+                  onClick: () => send(eventName),
+                  disabled:
+                    !state.nextEvents
+                      .filter((event) => state.can(event as any))
+                      .includes(eventName) || disableAllButtons,
+                }))}
               className={buttonClassName}
               Element="button"
               iconStart={{
@@ -377,6 +369,12 @@ export function Toolbar({
           </li>
         )}
       </ul>
+    )
+  }
+
+  return (
+    <menu className="max-w-full whitespace-nowrap rounded px-1.5 py-0.5 backdrop-blur-sm bg-chalkboard-10/80 dark:bg-chalkboard-110/70 relative">
+      <ToolbarButtons />
     </menu>
   )
 }

src/clientSideScene/CameraControls.ts

@@ -20,7 +20,6 @@ import {
   EngineCommand,
   Subscription,
   EngineCommandManager,
-  UnreliableSubscription,
 } from 'lang/std/engineConnection'
 import { uuidv4 } from 'lib/utils'
 import { deg2Rad } from 'lib/utils2d'
@@ -233,19 +232,9 @@ export class CameraControls {
     this.update()
     this._usePerspectiveCamera()
 
-    type CallBackParam = Parameters<
+    const cb: Subscription<
-      (
+      'default_camera_zoom' | 'camera_drag_end' | 'default_camera_get_settings'
-        | Subscription<
+    >['callback'] = ({ data, type }) => {
-            | 'default_camera_zoom'
-            | 'camera_drag_end'
-            | 'default_camera_get_settings'
-            | 'zoom_to_fit'
-          >
-        | UnreliableSubscription<'camera_drag_move'>
-      )['callback']
-    >[0]
-
-    const cb = ({ data, type }: CallBackParam) => {
       const camSettings = data.settings
       this.camera.position.set(
         camSettings.pos.x,
@@ -257,13 +246,7 @@ export class CameraControls {
         camSettings.center.y,
         camSettings.center.z
       )
-      const quat = new Quaternion(
+      this.camera.up.set(camSettings.up.x, camSettings.up.y, camSettings.up.z)
-        camSettings.orientation.x,
-        camSettings.orientation.y,
-        camSettings.orientation.z,
-        camSettings.orientation.w
-      ).invert()
-      this.camera.up.copy(new Vector3(0, 1, 0).applyQuaternion(quat))
       if (this.camera instanceof PerspectiveCamera && camSettings.ortho) {
         this.useOrthographicCamera()
       }
@@ -304,14 +287,6 @@ export class CameraControls {
         event: 'default_camera_get_settings',
         callback: cb,
       })
-      this.engineCommandManager.subscribeTo({
-        event: 'zoom_to_fit',
-        callback: cb,
-      })
-      this.engineCommandManager.subscribeToUnreliable({
-        event: 'camera_drag_move',
-        callback: cb,
-      })
     })
   }
 

src/clientSideScene/ClientSideSceneComp.tsx

@@ -1,4 +1,4 @@
-import { useRef, useEffect, useState, useMemo, Fragment } from 'react'
+import { useRef, useEffect, useState } from 'react'
 import { useModelingContext } from 'hooks/useModelingContext'
 
 import { cameraMouseDragGuards } from 'lib/cameraControls'
@@ -6,44 +6,12 @@ import { useSettingsAuthContext } from 'hooks/useSettingsAuthContext'
 import { ARROWHEAD, DEBUG_SHOW_BOTH_SCENES } from './sceneInfra'
 import { ReactCameraProperties } from './CameraControls'
 import { throttle } from 'lib/utils'
-import {
+import { sceneInfra } from 'lib/singletons'
-  sceneInfra,
-  kclManager,
-  codeManager,
-  editorManager,
-  sceneEntitiesManager,
-  engineCommandManager,
-} from 'lib/singletons'
 import {
   EXTRA_SEGMENT_HANDLE,
   PROFILE_START,
   getParentGroup,
 } from './sceneEntities'
-import { SegmentOverlay, SketchDetails } from 'machines/modelingMachine'
-import { findUsesOfTagInPipe, getNodeFromPath } from 'lang/queryAst'
-import {
-  CallExpression,
-  PathToNode,
-  Program,
-  SourceRange,
-  Value,
-  parse,
-  recast,
-} from 'lang/wasm'
-import { CustomIcon, CustomIconName } from 'components/CustomIcon'
-import { ConstrainInfo } from 'lang/std/stdTypes'
-import { getConstraintInfo } from 'lang/std/sketch'
-import { Dialog, Popover, Transition } from '@headlessui/react'
-import { LineInputsType } from 'lang/std/sketchcombos'
-import toast from 'react-hot-toast'
-import { InstanceProps, create } from 'react-modal-promise'
-import { executeAst } from 'useStore'
-import {
-  deleteSegmentFromPipeExpression,
-  makeRemoveSingleConstraintInput,
-  removeSingleConstraintInfo,
-} from 'lang/modifyAst'
-import { ActionButton } from 'components/ActionButton'
 
 function useShouldHideScene(): { hideClient: boolean; hideServer: boolean } {
   const [isCamMoving, setIsCamMoving] = useState(false)
@@ -132,530 +100,17 @@ export const ClientSideScene = ({
   }
 
   return (
-    <>
+    <div
-      <div
+      ref={canvasRef}
-        ref={canvasRef}
+      style={{ cursor: cursor }}
-        style={{ cursor: cursor }}
+      className={`absolute inset-0 h-full w-full transition-all duration-300 ${
-        className={`absolute inset-0 h-full w-full transition-all duration-300 ${
+        hideClient ? 'opacity-0' : 'opacity-100'
-          hideClient ? 'opacity-0' : 'opacity-100'
+      } ${hideServer ? 'bg-chalkboard-10 dark:bg-chalkboard-100' : ''} ${
-        } ${hideServer ? 'bg-chalkboard-10 dark:bg-chalkboard-100' : ''} ${
+        !hideClient && !hideServer && state.matches('Sketch')
-          !hideClient && !hideServer && state.matches('Sketch')
+          ? 'bg-chalkboard-10/80 dark:bg-chalkboard-100/80'
-            ? 'bg-chalkboard-10/80 dark:bg-chalkboard-100/80'
+          : ''
-            : ''
+      }`}
-        }`}
+    ></div>
-      ></div>
-      <Overlays />
-    </>
-  )
-}
-
-const Overlays = () => {
-  const { context } = useModelingContext()
-  if (context.mouseState.type === 'isDragging') return null
-  return (
-    <div className="absolute inset-0 pointer-events-none">
-      {Object.entries(context.segmentOverlays)
-        .filter((a) => a[1].visible)
-        .map(([pathToNodeString, overlay], index) => {
-          return (
-            <Overlay
-              overlay={overlay}
-              key={pathToNodeString}
-              pathToNodeString={pathToNodeString}
-              overlayIndex={index}
-            />
-          )
-        })}
-    </div>
-  )
-}
-
-const Overlay = ({
-  overlay,
-  overlayIndex,
-  pathToNodeString,
-}: {
-  overlay: SegmentOverlay
-  overlayIndex: number
-  pathToNodeString: string
-}) => {
-  const { context, send, state } = useModelingContext()
-  let xAlignment = overlay.angle < 0 ? '0%' : '-100%'
-  let yAlignment = overlay.angle < -90 || overlay.angle >= 90 ? '0%' : '-100%'
-
-  const callExpression = getNodeFromPath<CallExpression>(
-    kclManager.ast,
-    overlay.pathToNode,
-    'CallExpression'
-  ).node
-  const constraints = getConstraintInfo(
-    callExpression,
-    codeManager.code,
-    overlay.pathToNode
-  )
-
-  const offset = 20 // px
-  // We could put a boolean in settings that
-  const offsetAngle = 90
-
-  const xOffset =
-    Math.cos(((overlay.angle + offsetAngle) * Math.PI) / 180) * offset
-  const yOffset =
-    Math.sin(((overlay.angle + offsetAngle) * Math.PI) / 180) * offset
-
-  const shouldShow =
-    overlay.visible &&
-    typeof context?.segmentHoverMap?.[pathToNodeString] === 'number' &&
-    !(
-      state.matches('Sketch.Line tool') ||
-      state.matches('Sketch.Tangential arc to') ||
-      state.matches('Sketch.Rectangle tool')
-    )
-
-  return (
-    <div className={`absolute w-0 h-0`}>
-      <div
-        data-testid="segment-overlay"
-        data-path-to-node={pathToNodeString}
-        data-overlay-index={overlayIndex}
-        data-overlay-angle={overlay.angle}
-        className="pointer-events-auto absolute w-0 h-0"
-        style={{
-          transform: `translate3d(${overlay.windowCoords[0]}px, ${overlay.windowCoords[1]}px, 0)`,
-        }}
-      ></div>
-      {shouldShow && (
-        <div
-          className={`px-0 pointer-events-auto absolute flex gap-1`}
-          style={{
-            transform: `translate3d(calc(${
-              overlay.windowCoords[0] + xOffset
-            }px + ${xAlignment}), calc(${
-              overlay.windowCoords[1] - yOffset
-            }px + ${yAlignment}), 0)`,
-          }}
-          onMouseEnter={() =>
-            send({
-              type: 'Set mouse state',
-              data: {
-                type: 'isHovering',
-                on: overlay.group,
-              },
-            })
-          }
-          onMouseLeave={() =>
-            send({
-              type: 'Set mouse state',
-              data: { type: 'idle' },
-            })
-          }
-        >
-          {constraints &&
-            constraints.map((constraintInfo, i) => (
-              <ConstraintSymbol
-                constrainInfo={constraintInfo}
-                key={i}
-                verticalPosition={
-                  overlay.windowCoords[1] > window.innerHeight / 2
-                    ? 'top'
-                    : 'bottom'
-                }
-              />
-            ))}
-          <SegmentMenu
-            verticalPosition={
-              overlay.windowCoords[1] > window.innerHeight / 2
-                ? 'top'
-                : 'bottom'
-            }
-            pathToNode={overlay.pathToNode}
-            stdLibFnName={constraints[0]?.stdLibFnName}
-          />
-        </div>
-      )}
-    </div>
-  )
-}
-
-type ConfirmModalProps = InstanceProps<boolean, boolean> & { text: string }
-
-export const ConfirmModal = ({
-  isOpen,
-  onResolve,
-  onReject,
-  text,
-}: ConfirmModalProps) => {
-  return (
-    <Transition appear show={isOpen} as={Fragment}>
-      <Dialog
-        as="div"
-        className="relative z-10"
-        onClose={() => onResolve(false)}
-      >
-        <Transition.Child
-          as={Fragment}
-          enter="ease-out duration-300"
-          enterFrom="opacity-0"
-          enterTo="opacity-100"
-          leave="ease-in duration-200"
-          leaveFrom="opacity-100"
-          leaveTo="opacity-0"
-        >
-          <div className="fixed inset-0 bg-black bg-opacity-25" />
-        </Transition.Child>
-
-        <div className="fixed inset-0 overflow-y-auto">
-          <div className="flex min-h-full items-center justify-center p-4 text-center">
-            <Transition.Child
-              as={Fragment}
-              enter="ease-out duration-300"
-              enterFrom="opacity-0 scale-95"
-              enterTo="opacity-100 scale-100"
-              leave="ease-in duration-200"
-              leaveFrom="opacity-100 scale-100"
-              leaveTo="opacity-0 scale-95"
-            >
-              <Dialog.Panel className="rounded relative mx-auto px-4 py-8 bg-chalkboard-10 dark:bg-chalkboard-100 border dark:border-chalkboard-70 max-w-xl w-full shadow-lg">
-                <div>{text}</div>
-                <div className="mt-8 flex justify-between">
-                  <ActionButton
-                    Element="button"
-                    onClick={() => onResolve(true)}
-                  >
-                    Continue and unconstrain
-                  </ActionButton>
-                  <ActionButton
-                    Element="button"
-                    onClick={() => onReject(false)}
-                  >
-                    Cancel
-                  </ActionButton>
-                </div>
-              </Dialog.Panel>
-            </Transition.Child>
-          </div>
-        </div>
-      </Dialog>
-    </Transition>
-  )
-}
-
-export const confirmModal = create<ConfirmModalProps, boolean, boolean>(
-  ConfirmModal
-)
-
-export async function deleteSegment({
-  pathToNode,
-  sketchDetails,
-}: {
-  pathToNode: PathToNode
-  sketchDetails: SketchDetails | null
-}) {
-  let modifiedAst: Program = kclManager.ast
-  const dependentRanges = findUsesOfTagInPipe(modifiedAst, pathToNode)
-
-  const shouldContinueSegDelete = dependentRanges.length
-    ? await confirmModal({
-        text: `At least ${dependentRanges.length} segment rely on the segment you're deleting.\nDo you want to continue and unconstrain these segments?`,
-        isOpen: true,
-      })
-    : true
-
-  if (!shouldContinueSegDelete) return
-  modifiedAst = deleteSegmentFromPipeExpression(
-    dependentRanges,
-    modifiedAst,
-    kclManager.programMemory,
-    codeManager.code,
-    pathToNode
-  )
-
-  const newCode = recast(modifiedAst)
-  modifiedAst = parse(newCode)
-  const testExecute = await executeAst({
-    ast: modifiedAst,
-    useFakeExecutor: true,
-    engineCommandManager: engineCommandManager,
-  })
-  if (testExecute.errors.length) {
-    toast.error('Segment tag used outside of current Sketch. Could not delete.')
-    return
-  }
-
-  if (!sketchDetails) return
-  sceneEntitiesManager.updateAstAndRejigSketch(
-    sketchDetails.sketchPathToNode,
-    modifiedAst,
-    sketchDetails.zAxis,
-    sketchDetails.yAxis,
-    sketchDetails.origin
-  )
-}
-
-const SegmentMenu = ({
-  verticalPosition,
-  pathToNode,
-  stdLibFnName,
-}: {
-  verticalPosition: 'top' | 'bottom'
-  pathToNode: PathToNode
-  stdLibFnName: string
-}) => {
-  const { send } = useModelingContext()
-  const dependentSourceRanges = findUsesOfTagInPipe(kclManager.ast, pathToNode)
-  return (
-    <Popover className="relative">
-      {({ open }) => (
-        <>
-          <Popover.Button
-            data-testid="overlay-menu"
-            data-stdlib-fn-name={stdLibFnName}
-            className="bg-chalkboard-10 dark:bg-chalkboard-100 border !border-transparent hover:!border-chalkboard-40 dark:hover:!border-chalkboard-70 ui-open:!border-chalkboard-40 dark:ui-open:!border-chalkboard-70 h-[26px] w-[26px] rounded-sm p-0 m-0"
-          >
-            <CustomIcon name={'three-dots'} />
-          </Popover.Button>
-          <Popover.Panel
-            as="menu"
-            className={`absolute ${
-              verticalPosition === 'top' ? 'bottom-full' : 'top-full'
-            } z-10 w-36 flex flex-col gap-1 divide-y divide-chalkboard-20 dark:divide-chalkboard-70 align-stretch px-0 py-1 bg-chalkboard-10 dark:bg-chalkboard-100 rounded-sm shadow-lg border border-solid border-chalkboard-20/50 dark:border-chalkboard-80/50`}
-          >
-            {/* <button className="hover:bg-white/80 bg-white/50 rounded p-1 text-nowrap">
-                Remove segment constraints
-              </button> */}
-            <button
-              className="!border-transparent rounded-sm text-left p-1 text-nowrap"
-              // disabled={dependentSourceRanges.length > 0}
-              title={
-                dependentSourceRanges.length > 0
-                  ? `At least ${dependentSourceRanges.length} segment rely on this segment's tag.`
-                  : ''
-              }
-              onClick={() => {
-                send({ type: 'Delete segment', data: pathToNode })
-              }}
-            >
-              Delete Segment
-            </button>
-          </Popover.Panel>
-        </>
-      )}
-    </Popover>
-  )
-}
-
-const ConstraintSymbol = ({
-  constrainInfo: { type: _type, isConstrained, value, pathToNode, argPosition },
-  verticalPosition,
-}: {
-  constrainInfo: ConstrainInfo
-  verticalPosition: 'top' | 'bottom'
-}) => {
-  const { context, send } = useModelingContext()
-  const varNameMap: {
-    [key in ConstrainInfo['type']]: {
-      varName: string
-      displayName: string
-      iconName: CustomIconName
-      implicitConstraintDesc?: string
-    }
-  } = {
-    xRelative: {
-      varName: 'xRel',
-      displayName: 'X Relative',
-      iconName: 'xRelative',
-    },
-    xAbsolute: {
-      varName: 'xAbs',
-      displayName: 'X Absolute',
-      iconName: 'xAbsolute',
-    },
-    yRelative: {
-      varName: 'yRel',
-      displayName: 'Y Relative',
-      iconName: 'yRelative',
-    },
-    yAbsolute: {
-      varName: 'yAbs',
-      displayName: 'Y Absolute',
-      iconName: 'yAbsolute',
-    },
-    angle: {
-      varName: 'angle',
-      displayName: 'Angle',
-      iconName: 'angle',
-    },
-    length: {
-      varName: 'len',
-      displayName: 'Length',
-      iconName: 'dimension',
-    },
-    intersectionOffset: {
-      varName: 'perpDist',
-      displayName: 'Intersection Offset',
-      iconName: 'intersection-offset',
-    },
-
-    // implicit constraints
-    vertical: {
-      varName: '',
-      displayName: '',
-      iconName: 'vertical',
-      implicitConstraintDesc: 'vertically',
-    },
-    horizontal: {
-      varName: '',
-      displayName: '',
-      iconName: 'horizontal',
-      implicitConstraintDesc: 'horizontally',
-    },
-    tangentialWithPrevious: {
-      varName: '',
-      displayName: '',
-      iconName: 'tangent',
-      implicitConstraintDesc: 'tangential to previous segment',
-    },
-
-    // we don't render this one
-    intersectionTag: {
-      varName: '',
-      displayName: '',
-      iconName: 'dimension',
-    },
-  }
-  const varName =
-    _type in varNameMap ? varNameMap[_type as LineInputsType].varName : 'var'
-  const name: CustomIconName = varNameMap[_type as LineInputsType].iconName
-  const displayName = varNameMap[_type as LineInputsType]?.displayName
-  const implicitDesc =
-    varNameMap[_type as LineInputsType]?.implicitConstraintDesc
-
-  const node = useMemo(
-    () => getNodeFromPath<Value>(kclManager.ast, pathToNode).node,
-    [kclManager.ast, pathToNode]
-  )
-  const range: SourceRange = node ? [node.start, node.end] : [0, 0]
-
-  if (_type === 'intersectionTag') return null
-
-  return (
-    <div className="relative group">
-      <button
-        data-testid="constraint-symbol"
-        data-is-implicit-constraint={implicitDesc ? 'true' : 'false'}
-        data-constraint-type={_type}
-        data-is-constrained={isConstrained ? 'true' : 'false'}
-        className={`${
-          implicitDesc
-            ? 'bg-chalkboard-10 dark:bg-chalkboard-100 border-transparent border-0 rounded'
-            : isConstrained
-            ? 'bg-chalkboard-10 dark:bg-chalkboard-90 dark:hover:bg-chalkboard-80 border-chalkboard-40 dark:border-chalkboard-70 rounded-sm'
-            : 'bg-primary/30 dark:bg-primary text-primary dark:text-chalkboard-10 dark:border-transparent group-hover:bg-primary/40 group-hover:border-primary/50 group-hover:brightness-125'
-        } h-[26px] w-[26px] rounded-sm relative m-0 p-0`}
-        onMouseEnter={() => {
-          editorManager.setHighlightRange(range)
-        }}
-        onMouseLeave={() => {
-          editorManager.setHighlightRange([0, 0])
-        }}
-        // disabled={isConstrained || !convertToVarEnabled}
-        // disabled={implicitDesc} TODO why does this change styles that are hard to override?
-        onClick={async () => {
-          if (!isConstrained) {
-            send({
-              type: 'Convert to variable',
-              data: {
-                pathToNode,
-                variableName: varName,
-              },
-            })
-          } else if (isConstrained) {
-            try {
-              const shallowPath = getNodeFromPath<CallExpression>(
-                parse(recast(kclManager.ast)),
-                pathToNode,
-                'CallExpression',
-                true
-              ).shallowPath
-              const input = makeRemoveSingleConstraintInput(
-                argPosition,
-                shallowPath
-              )
-              if (!input || !context.sketchDetails) return
-              const transform = removeSingleConstraintInfo(
-                input,
-                kclManager.ast,
-                kclManager.programMemory
-              )
-              if (!transform) return
-              const { modifiedAst } = transform
-              kclManager.updateAst(modifiedAst, true)
-            } catch (e) {
-              console.log('error', e)
-            }
-            toast.success('Constraint removed')
-          }
-        }}
-      >
-        <CustomIcon name={name} />
-      </button>
-
-      <div
-        className={`absolute ${
-          verticalPosition === 'top'
-            ? 'top-0 -translate-y-full'
-            : 'bottom-0 translate-y-full'
-        } group-hover:block hidden w-[2px] h-2 translate-x-[12px] bg-white/40`}
-      ></div>
-      <div
-        className={`absolute ${
-          verticalPosition === 'top' ? 'top-0' : 'bottom-0'
-        } group-hover:block hidden`}
-        style={{
-          transform: `translate3d(calc(-50% + 13px), ${
-            verticalPosition === 'top' ? '-100%' : '100%'
-          }, 0)`,
-        }}
-      >
-        <div
-          className="bg-chalkboard-10 dark:bg-chalkboard-90 p-2 px-3 rounded-sm border border-solid border-chalkboard-20 dark:border-chalkboard-80 shadow-sm"
-          data-testid="constraint-symbol-popover"
-        >
-          {implicitDesc ? (
-            <div className="min-w-48">
-              <pre className="inline-block">
-                <code className="text-primary">{value}</code>
-              </pre>{' '}
-              <span>is implicitly constrained {implicitDesc}</span>
-            </div>
-          ) : (
-            <>
-              <div className="flex mb-1">
-                <span className="text-nowrap">
-                  <span className="font-bold">
-                    {isConstrained ? 'Constrained' : 'Unconstrained'}
-                  </span>
-                  <span className="text-white/80 text-sm pl-2">
-                    {displayName}
-                  </span>
-                </span>
-              </div>
-              <div className="flex mb-1">
-                <span className="pr-2 whitespace-nowrap">Set to</span>
-                <pre>
-                  <code className="text-primary">{value}</code>
-                </pre>
-              </div>
-              <div className="text-sm text-chalkboard-70 dark:text-chalkboard-40 text-nowrap">
-                {isConstrained
-                  ? 'Click to unconstrain with raw number'
-                  : 'Click to constrain with variable'}
-              </div>
-            </>
-          )}
-        </div>
-      </div>
-    </div>
   )
 }
 

src/clientSideScene/sceneEntities.ts

@@ -69,13 +69,12 @@ import {
   tangentialArcToSegment,
 } from './segments'
 import {
-  addCallExpressionsToPipe,
   addCloseToPipe,
   addNewSketchLn,
   changeSketchArguments,
   updateStartProfileAtArgs,
 } from 'lang/std/sketch'
-import { normaliseAngle, roundOff, throttle } from 'lib/utils'
+import { roundOff, throttle } from 'lib/utils'
 import {
   createArrayExpression,
   createCallExpressionStdLib,
@@ -92,7 +91,7 @@ import { getTangentPointFromPreviousArc } from 'lib/utils2d'
 import { createGridHelper, orthoScale, perspScale } from './helpers'
 import { Models } from '@kittycad/lib'
 import { uuidv4 } from 'lib/utils'
-import { SegmentOverlayPayload, SketchDetails } from 'machines/modelingMachine'
+import { SketchDetails } from 'machines/modelingMachine'
 import { EngineCommandManager } from 'lang/std/engineConnection'
 import {
   getRectangleCallExpressions,
@@ -139,8 +138,8 @@ export class SceneEntities {
   }
   onCamChange = () => {
     const orthoFactor = orthoScale(sceneInfra.camControls.camera)
-    const callbacks: (() => SegmentOverlayPayload | null)[] = []
+
-    Object.values(this.activeSegments).forEach((segment, index) => {
+    Object.values(this.activeSegments).forEach((segment) => {
       const factor =
         (sceneInfra.camControls.camera instanceof OrthographicCamera
           ? orthoFactor
@@ -151,14 +150,12 @@ export class SceneEntities {
         segment.userData.to &&
         segment.userData.type === STRAIGHT_SEGMENT
       ) {
-        callbacks.push(
+        this.updateStraightSegment({
-          this.updateStraightSegment({
+          from: segment.userData.from,
-            from: segment.userData.from,
+          to: segment.userData.to,
-            to: segment.userData.to,
+          group: segment,
-            group: segment,
+          scale: factor,
-            scale: factor,
+        })
-          })
-        )
       }
 
       if (
@@ -167,15 +164,13 @@ export class SceneEntities {
         segment.userData.prevSegment &&
         segment.userData.type === TANGENTIAL_ARC_TO_SEGMENT
       ) {
-        callbacks.push(
+        this.updateTangentialArcToSegment({
-          this.updateTangentialArcToSegment({
+          prevSegment: segment.userData.prevSegment,
-            prevSegment: segment.userData.prevSegment,
+          from: segment.userData.from,
-            from: segment.userData.from,
+          to: segment.userData.to,
-            to: segment.userData.to,
+          group: segment,
-            group: segment,
+          scale: factor,
-            scale: factor,
+        })
-          })
-        )
       }
       if (segment.name === PROFILE_START) {
         segment.scale.set(factor, factor, factor)
@@ -191,7 +186,6 @@ export class SceneEntities {
       const y = this.axisGroup.getObjectByName(Y_AXIS)
       y?.scale.set(factor / sceneInfra._baseUnitMultiplier, 1, 1)
     }
-    sceneInfra.overlayCallbacks(callbacks)
   }
 
   createIntersectionPlane() {
@@ -371,7 +365,7 @@ export class SceneEntities {
     })
     group.add(_profileStart)
     this.activeSegments[JSON.stringify(segPathToNode)] = _profileStart
-    const callbacks: (() => SegmentOverlayPayload | null)[] = []
+
     sketchGroup.value.forEach((segment, index) => {
       let segPathToNode = getNodePathFromSourceRange(
         maybeModdedAst,
@@ -416,15 +410,6 @@ export class SceneEntities {
           texture: sceneInfra.extraSegmentTexture,
           theme: sceneInfra._theme,
         })
-        callbacks.push(
-          this.updateTangentialArcToSegment({
-            prevSegment: sketchGroup.value[index - 1],
-            from: segment.from,
-            to: segment.to,
-            group: seg,
-            scale: factor,
-          })
-        )
       } else {
         seg = straightSegment({
           from: segment.from,
@@ -437,14 +422,6 @@ export class SceneEntities {
           texture: sceneInfra.extraSegmentTexture,
           theme: sceneInfra._theme,
         })
-        callbacks.push(
-          this.updateStraightSegment({
-            from: segment.from,
-            to: segment.to,
-            group: seg,
-            scale: factor,
-          })
-        )
       }
       seg.layers.set(SKETCH_LAYER)
       seg.traverse((child) => {
@@ -469,7 +446,6 @@ export class SceneEntities {
       this.intersectionPlane.position.set(...position)
     this.scene.add(group)
     sceneInfra.camControls.enableRotate = false
-    sceneInfra.overlayCallbacks(callbacks)
 
     return {
       truncatedAst,
@@ -560,32 +536,8 @@ export class SceneEntities {
 
         let modifiedAst
         if (profileStart) {
-          const lastSegment = sketchGroup.value.slice(-1)[0]
-          modifiedAst = addCallExpressionsToPipe({
-            node: kclManager.ast,
-            programMemory: kclManager.programMemory,
-            pathToNode: sketchPathToNode,
-            expressions: [
-              createCallExpressionStdLib(
-                lastSegment.type === 'TangentialArcTo'
-                  ? 'tangentialArcTo'
-                  : 'lineTo',
-                [
-                  createArrayExpression([
-                    createCallExpressionStdLib('profileStartX', [
-                      createPipeSubstitution(),
-                    ]),
-                    createCallExpressionStdLib('profileStartY', [
-                      createPipeSubstitution(),
-                    ]),
-                  ]),
-                  createPipeSubstitution(),
-                ]
-              ),
-            ],
-          })
           modifiedAst = addCloseToPipe({
-            node: modifiedAst,
+            node: kclManager.ast,
             programMemory: kclManager.programMemory,
             pathToNode: sketchPathToNode,
           })
@@ -608,17 +560,13 @@ export class SceneEntities {
         }
 
         await kclManager.executeAstMock(modifiedAst)
-        if (profileStart) {
+        this.setUpDraftSegment(
-          sceneInfra.modelingSend({ type: 'CancelSketch' })
+          sketchPathToNode,
-        } else {
+          forward,
-          this.setUpDraftSegment(
+          up,
-            sketchPathToNode,
+          origin,
-            forward,
+          segmentName
-            up,
+        )
-            origin,
-            segmentName
-          )
-        }
       },
       onMove: (args) => {
         this.onDragSegment({
@@ -1042,8 +990,7 @@ export class SceneEntities {
         orthoFactor,
         sketchGroup
       )
-
+      sgPaths.forEach((group, index) =>
-      const callBacks = sgPaths.map((group, index) =>
         this.updateSegment(
           group,
           index,
@@ -1053,7 +1000,6 @@ export class SceneEntities {
           sketchGroup
         )
       )
-      sceneInfra.overlayCallbacks(callBacks)
     })()
   }
 
@@ -1074,7 +1020,7 @@ export class SceneEntities {
     modifiedAst: Program,
     orthoFactor: number,
     sketchGroup: SketchGroup
-  ): (() => SegmentOverlayPayload | null) => {
+  ) => {
     const segPathToNode = getNodePathFromSourceRange(
       modifiedAst,
       segment.__geoMeta.sourceRange
@@ -1095,7 +1041,7 @@ export class SceneEntities {
         : perspScale(sceneInfra.camControls.camera, group)) /
       sceneInfra._baseUnitMultiplier
     if (type === TANGENTIAL_ARC_TO_SEGMENT) {
-      return this.updateTangentialArcToSegment({
+      this.updateTangentialArcToSegment({
         prevSegment: sgPaths[index - 1],
         from: segment.from,
         to: segment.to,
@@ -1103,7 +1049,7 @@ export class SceneEntities {
         scale: factor,
       })
     } else if (type === STRAIGHT_SEGMENT) {
-      return this.updateStraightSegment({
+      this.updateStraightSegment({
         from: segment.from,
         to: segment.to,
         group,
@@ -1113,7 +1059,6 @@ export class SceneEntities {
       group.position.set(segment.from[0], segment.from[1], 0)
       group.scale.set(factor, factor, factor)
     }
-    return () => null
   }
 
   updateTangentialArcToSegment({
@@ -1128,7 +1073,7 @@ export class SceneEntities {
     to: [number, number]
     group: Group
     scale?: number
-  }): () => SegmentOverlayPayload | null {
+  }) {
     group.userData.from = from
     group.userData.to = to
     group.userData.prevSegment = prevSegment
@@ -1216,18 +1161,6 @@ export class SceneEntities {
         scale,
       })
     }
-    const angle = normaliseAngle(
-      (arcInfo.endAngle * 180) / Math.PI + (arcInfo.ccw ? 90 : -90)
-    )
-    return () =>
-      sceneInfra.updateOverlayDetails({
-        arrowGroup,
-        group,
-        isHandlesVisible,
-        from,
-        to,
-        angle,
-      })
   }
   throttledUpdateDashedArcGeo = throttle(
     (
@@ -1248,7 +1181,7 @@ export class SceneEntities {
     to: [number, number]
     group: Group
     scale?: number
-  }): () => SegmentOverlayPayload | null {
+  }) {
     group.userData.from = from
     group.userData.to = to
     const shape = new Shape()
@@ -1325,14 +1258,6 @@ export class SceneEntities {
         scale
       )
     }
-    return () =>
-      sceneInfra.updateOverlayDetails({
-        arrowGroup,
-        group,
-        isHandlesVisible,
-        from,
-        to,
-      })
   }
   async animateAfterSketch() {
     // if (isReducedMotion()) {
@@ -1604,14 +1529,6 @@ export class SceneEntities {
       },
     }
   }
-  resetOverlays() {
-    sceneInfra.modelingSend({
-      type: 'Set Segment Overlays',
-      data: {
-        type: 'clear',
-      },
-    })
-  }
 }
 
 export type DefaultPlaneStr = 'XY' | 'XZ' | 'YZ' | '-XY' | '-XZ' | '-YZ'

src/clientSideScene/sceneInfra.ts

@@ -21,15 +21,15 @@ import {
   TextureLoader,
   Texture,
 } from 'three'
-import { Coords2d, compareVec2Epsilon2 } from 'lang/std/sketch'
+import { compareVec2Epsilon2 } from 'lang/std/sketch'
 import { useModelingContext } from 'hooks/useModelingContext'
 import * as TWEEN from '@tweenjs/tween.js'
 import { Axis } from 'lib/selections'
 import { type BaseUnit } from 'lib/settings/settingsTypes'
 import { CameraControls } from './CameraControls'
 import { EngineCommandManager } from 'lang/std/engineConnection'
-import { MouseState, SegmentOverlayPayload } from 'machines/modelingMachine'
+import { settings } from 'lib/settings/initialSettings'
-import { getAngle, throttle } from 'lib/utils'
+import { MouseState } from 'machines/modelingMachine'
 import { Themes } from 'lib/theme'
 
 type SendType = ReturnType<typeof useModelingContext>['send']
@@ -155,88 +155,8 @@ export class SceneInfra {
   }
 
   modelingSend: SendType = (() => {}) as any
-  throttledModelingSend: any = (() => {}) as any
   setSend(send: SendType) {
     this.modelingSend = send
-    this.throttledModelingSend = throttle(send, 100)
-  }
-  overlayTimeout = 0
-  callbacks: (() => SegmentOverlayPayload | null)[] = []
-  _overlayCallbacks(callbacks: (() => SegmentOverlayPayload | null)[]) {
-    const segmentOverlayPayload: SegmentOverlayPayload = {
-      type: 'set-many',
-      overlays: {},
-    }
-    callbacks.forEach((cb) => {
-      const overlay = cb()
-      if (overlay?.type === 'set-one') {
-        segmentOverlayPayload.overlays[overlay.pathToNodeString] = overlay.seg
-      }
-    })
-    this.modelingSend({
-      type: 'Set Segment Overlays',
-      data: segmentOverlayPayload,
-    })
-  }
-  overlayCallbacks(
-    callbacks: (() => SegmentOverlayPayload | null)[],
-    instant = false
-  ) {
-    if (instant) {
-      this._overlayCallbacks(callbacks)
-      return
-    }
-    this.callbacks = callbacks
-    if (this.overlayTimeout) clearTimeout(this.overlayTimeout)
-    this.overlayTimeout = setTimeout(() => {
-      this._overlayCallbacks(this.callbacks)
-    }, 100) as unknown as number
-  }
-
-  overlayThrottleMap: { [pathToNodeString: string]: number } = {}
-  updateOverlayDetails({
-    arrowGroup,
-    group,
-    isHandlesVisible,
-    from,
-    to,
-    angle,
-  }: {
-    arrowGroup: Group
-    group: Group
-    isHandlesVisible: boolean
-    from: Coords2d
-    to: Coords2d
-    angle?: number
-  }): SegmentOverlayPayload | null {
-    if (group.userData.pathToNode && arrowGroup) {
-      const vector = new Vector3(0, 0, 0)
-
-      // Get the position of the object3D in world space
-      // console.log('arrowGroup', arrowGroup)
-      arrowGroup.getWorldPosition(vector)
-
-      // Project that position to screen space
-      vector.project(this.camControls.camera)
-
-      const _angle = typeof angle === 'number' ? angle : getAngle(from, to)
-
-      const x = (vector.x * 0.5 + 0.5) * window.innerWidth
-      const y = (-vector.y * 0.5 + 0.5) * window.innerHeight
-      const pathToNodeString = JSON.stringify(group.userData.pathToNode)
-      return {
-        type: 'set-one',
-        pathToNodeString,
-        seg: {
-          windowCoords: [x, y],
-          angle: _angle,
-          group,
-          pathToNode: group.userData.pathToNode,
-          visible: isHandlesVisible,
-        },
-      }
-    }
-    return null
   }
 
   hoveredObject: null | any = null
@@ -262,6 +182,15 @@ export class SceneInfra {
     this.renderer.setClearColor(0x000000, 0) // Set clear color to black with 0 alpha (fully transparent)
     window.addEventListener('resize', this.onWindowResize)
 
+    // CAMERA
+    const camHeightDistanceRatio = 0.5
+    const baseUnit: BaseUnit = settings.modeling.defaultUnit.current
+    const baseRadius = 5.6
+    const length = baseUnitTomm(baseUnit) * baseRadius
+    const ang = Math.atan(camHeightDistanceRatio)
+    const x = Math.cos(ang) * length
+    const y = Math.sin(ang) * length
+
     this.camControls = new CameraControls(
       false,
       this.renderer.domElement,
@@ -269,6 +198,7 @@ export class SceneInfra {
     )
     this.camControls.subscribeToCamChange(() => this.onCameraChange())
     this.camControls.camera.layers.enable(SKETCH_LAYER)
+    this.camControls.camera.position.set(0, -x, y)
     if (DEBUG_SHOW_INTERSECTION_PLANE)
       this.camControls.camera.layers.enable(INTERSECTION_PLANE_LAYER)
 

src/components/ActionButtonDropdown.tsx

@@ -39,7 +39,6 @@ export function ActionButtonDropdown({
               onClick={item.onClick}
               className="block px-3 py-1 hover:bg-primary/10 dark:hover:bg-chalkboard-80 border-0 m-0 text-sm w-full rounded-none text-left disabled:!bg-transparent dark:disabled:text-chalkboard-60"
               disabled={item.disabled}
-              data-testid={item.label}
             >
               <span className="capitalize">{item.label}</span>
               {item.shortcut && (

src/components/AvailableVarsHelpers.tsx

@@ -216,7 +216,7 @@ export const CreateNewVariable = ({
     <>
       <label
         htmlFor="create-new-variable"
-        className="block mt-3 font-mono text-chalkboard-90"
+        className="block mt-3 font-mono text-gray-900"
       >
         Create new variable
       </label>
@@ -224,12 +224,11 @@ export const CreateNewVariable = ({
         {showCheckbox && (
           <input
             type="checkbox"
-            data-testid="create-new-variable-checkbox"
             checked={shouldCreateVariable}
             onChange={(e) => {
               setShouldCreateVariable(e.target.checked)
             }}
-            className="bg-chalkboard-10 dark:bg-chalkboard-80"
+            className="bg-white text-gray-900"
           />
         )}
         <input
@@ -250,7 +249,7 @@ export const CreateNewVariable = ({
         />
       </div>
       {!isNewVariableNameUnique && (
-        <div className="bg-pink-200 dark:bg-chalkboard-80 dark:text-pink-200 rounded px-2 py-0.5 text-xs">
+        <div className="bg-pink-200 rounded px-2 py-0.5 text-xs">
           Sorry, that's not a unique variable name. Please try something else
         </div>
       )}

src/components/CustomIcon.tsx

@@ -11,16 +11,6 @@ const CustomIconMap = {
       />
     </svg>
   ),
-  angle: (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        fillRule="evenodd"
-        clipRule="evenodd"
-        d="M15 14L10 14H5.00001H4.0495L4.58799 13.2168L7.33799 9.21675L10.088 5.21674L10.912 5.78326L8.45436 9.35807C9.07972 9.78751 9.54479 10.2461 9.87084 10.8329C10.2065 11.437 10.3723 12.1375 10.4598 13H15V14ZM9.45406 13C9.37153 12.2592 9.23025 11.739 8.99671 11.3186C8.7674 10.9059 8.42873 10.5535 7.88782 10.1821L5.95053 13L9.45406 13Z"
-        fill="currentColor"
-      />
-    </svg>
-  ),
   arrowDown: (
     <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
       <path
@@ -237,16 +227,6 @@ const CustomIconMap = {
       />
     </svg>
   ),
-  'intersection-offset': (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        fillRule="evenodd"
-        clipRule="evenodd"
-        d="M13.8189 4.34932L4.21895 13.9493L3.51184 13.2422L13.1118 3.64221L13.8189 4.34932ZM7.17419 15.6636L6.48848 16.3493L5.78137 15.6422L6.46709 14.9564L7.17419 15.6636ZM9.57419 13.2636L8.20276 14.635L7.49566 13.9279L8.86709 12.5564L9.57419 13.2636ZM12.0932 13.0433C12.3807 12.8662 12.6223 12.6217 12.796 12.3319L15.8739 15.4098L15.1668 16.1169L12.0932 13.0433ZM14.3742 8.46355L13.0028 9.83498L12.2957 9.12787L13.6671 7.75644L14.3742 8.46355ZM16.0885 6.74927L15.4028 7.43498L14.6957 6.72787L15.3814 6.04216L16.0885 6.74927ZM10.9933 12.754C11.8217 12.754 12.4933 12.0825 12.4933 11.254C12.4933 10.4256 11.8217 9.75404 10.9933 9.75404C10.1649 9.75404 9.49329 10.4256 9.49329 11.254C9.49329 12.0825 10.1649 12.754 10.9933 12.754Z"
-        fill="currentColor"
-      />
-    </svg>
-  ),
   kcl: (
     <svg viewBox="0 0 40 40" fill="none" xmlns="http://www.w3.org/2000/svg">
       <path
@@ -405,16 +385,6 @@ const CustomIconMap = {
       />
     </svg>
   ),
-  tangent: (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        fillRule="evenodd"
-        clipRule="evenodd"
-        d="M12.73 2.73L9.23398 6.226C9.72614 6.46571 10.1178 6.87964 10.3288 7.38755C10.6321 7.31396 10.949 7.27497 11.275 7.27497C13.4841 7.27497 15.275 9.06583 15.275 11.275C15.275 13.4841 13.4841 15.275 11.275 15.275C9.06587 15.275 7.27501 13.4841 7.27501 11.275C7.27501 10.949 7.314 10.6321 7.38757 10.3288C6.87965 10.1178 6.46571 9.72614 6.226 9.23398L2.72998 12.73L3.43709 13.4371L6.32769 10.5465C6.29298 10.7843 6.27501 11.0275 6.27501 11.275C6.27501 14.0364 8.51358 16.275 11.275 16.275C14.0364 16.275 16.275 14.0364 16.275 11.275C16.275 8.51355 14.0364 6.27497 11.275 6.27497C11.0276 6.27497 10.7843 6.29294 10.5465 6.32765L13.4371 3.4371L12.73 2.73ZM8.26001 9.75C9.08844 9.75 9.76001 9.07843 9.76001 8.25C9.76001 7.42157 9.08844 6.75 8.26001 6.75C7.43158 6.75 6.76001 7.42157 6.76001 8.25C6.76001 9.07843 7.43158 9.75 8.26001 9.75Z"
-        fill="currentColor"
-      />
-    </svg>
-  ),
   'three-dots': (
     <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
       <path
@@ -425,14 +395,6 @@ const CustomIconMap = {
       />
     </svg>
   ),
-  trash: (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        d="M8.5 6H5V8H6M8.5 6V4H11.5V6M8.5 6H11.5M11.5 6H15V8H14M6 8V15.5H8M6 8H14M14 8V15.5H12M8 15.5V10M8 15.5H10M12 15.5V10M12 15.5H10M10 15.5V12"
-        stroke="currentColor"
-      />
-    </svg>
-  ),
   vertical: (
     <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
       <path
@@ -443,42 +405,6 @@ const CustomIconMap = {
       />
     </svg>
   ),
-  xAbsolute: (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        fillRule="evenodd"
-        clipRule="evenodd"
-        d="M4 16V4H5L5 16H4ZM8.75069 6.82599C8.97469 6.78866 9.20803 6.79799 9.45069 6.85399C9.91736 6.95666 10.2627 7.17132 10.4867 7.49799C10.524 7.55399 10.552 7.58199 10.5707 7.58199L10.6547 7.46999C10.8787 7.20866 11.1447 7.01732 11.4527 6.89599C11.8074 6.76532 12.162 6.77932 12.5167 6.93799C12.7874 7.07799 12.9787 7.26466 13.0907 7.49799C13.2774 7.87132 13.282 8.26332 13.1047 8.67399C13.03 8.83266 12.9367 8.95399 12.8247 9.03799C12.4887 9.28066 12.1714 9.32732 11.8727 9.17799C11.8167 9.14999 11.77 9.11732 11.7327 9.07999C11.5927 8.93999 11.5367 8.76266 11.5647 8.54799C11.6207 8.12799 11.8354 7.85266 12.2087 7.72199L12.3207 7.67999L12.2647 7.62399C12.0967 7.47466 11.8914 7.43266 11.6487 7.49799C11.63 7.49799 11.6114 7.50266 11.5927 7.51199C11.3127 7.61466 11.0887 7.88532 10.9207 8.32399C10.8274 8.55732 10.58 9.54199 10.1787 11.278C10.132 11.4367 10.1087 11.5347 10.1087 11.572C10.062 11.8613 10.0667 12.0573 10.1227 12.16C10.1974 12.3 10.314 12.398 10.4727 12.454C10.5194 12.4727 10.6174 12.482 10.7667 12.482C10.9067 12.482 11.0094 12.4727 11.0747 12.454C11.3174 12.3793 11.56 12.23 11.8027 12.006C12.092 11.7073 12.2834 11.3807 12.3767 11.026C12.4047 10.9327 12.442 10.8813 12.4887 10.872C12.526 10.8627 12.61 10.858 12.7407 10.858C12.918 10.858 13.0207 10.8673 13.0487 10.886C13.0674 10.9047 13.0767 10.9373 13.0767 10.984C13.0767 11.18 12.9554 11.474 12.7127 11.866C12.7034 11.894 12.6894 11.9173 12.6707 11.936C12.2507 12.58 11.6954 12.9767 11.0047 13.126C10.79 13.1633 10.5474 13.1633 10.2767 13.126C9.80069 13.0233 9.44603 12.8133 9.21269 12.496L9.12869 12.37L9.08669 12.412C8.72269 12.8787 8.31203 13.126 7.85469 13.154C7.32269 13.182 6.92603 12.986 6.66469 12.566C6.60869 12.4913 6.56669 12.4073 6.53869 12.314C6.47336 12.1087 6.45469 11.8893 6.48269 11.656C6.54803 11.2547 6.73469 10.9793 7.04269 10.83C7.34136 10.69 7.60736 10.6853 7.84069 10.816C8.05536 10.9187 8.15336 11.1053 8.13469 11.376C8.10669 11.7493 7.93403 12.02 7.61669 12.188C7.57003 12.216 7.50469 12.244 7.42069 12.272L7.36469 12.286L7.40669 12.328C7.53736 12.4307 7.68669 12.482 7.85469 12.482C7.97603 12.4913 8.10203 12.4587 8.23269 12.384C8.47536 12.216 8.65736 11.9593 8.77869 11.614L9.54869 8.53399C9.61403 8.19799 9.62336 7.96466 9.57669 7.83399C9.53003 7.68466 9.40869 7.57732 9.21269 7.51199C9.02603 7.45599 8.83469 7.45599 8.63869 7.51199C8.36803 7.58666 8.13003 7.72666 7.92469 7.93199C7.65403 8.21199 7.45803 8.52466 7.33669 8.86999C7.30869 8.98199 7.28069 9.05199 7.25269 9.07999C7.23403 9.09866 7.13603 9.10799 6.95869 9.10799H6.69269L6.65069 9.06599C6.62269 9.03799 6.60869 9.00066 6.60869 8.95399C6.63669 8.81399 6.69269 8.65532 6.77669 8.47799C6.86069 8.28199 6.96803 8.09532 7.09869 7.91799C7.24803 7.69399 7.45336 7.48399 7.71469 7.28799C7.72403 7.27866 7.73803 7.26932 7.75669 7.25999C8.06469 7.04532 8.39603 6.90066 8.75069 6.82599ZM15 4L15 16H16L16 4H15Z"
-        fill="currentColor"
-      />
-    </svg>
-  ),
-  xRelative: (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        d="M8.75069 6.82599C8.97469 6.78866 9.20803 6.79799 9.45069 6.85399C9.91736 6.95666 10.2627 7.17132 10.4867 7.49799C10.524 7.55399 10.552 7.58199 10.5707 7.58199L10.6547 7.46999C10.8787 7.20866 11.1447 7.01732 11.4527 6.89599C11.8074 6.76532 12.162 6.77932 12.5167 6.93799C12.7874 7.07799 12.9787 7.26466 13.0907 7.49799C13.2774 7.87132 13.282 8.26332 13.1047 8.67399C13.03 8.83266 12.9367 8.95399 12.8247 9.03799C12.4887 9.28066 12.1714 9.32732 11.8727 9.17799C11.8167 9.14999 11.77 9.11732 11.7327 9.07999C11.5927 8.93999 11.5367 8.76266 11.5647 8.54799C11.6207 8.12799 11.8354 7.85266 12.2087 7.72199L12.3207 7.67999L12.2647 7.62399C12.0967 7.47466 11.8914 7.43266 11.6487 7.49799C11.63 7.49799 11.6114 7.50266 11.5927 7.51199C11.3127 7.61466 11.0887 7.88532 10.9207 8.32399C10.8274 8.55732 10.58 9.54199 10.1787 11.278C10.132 11.4367 10.1087 11.5347 10.1087 11.572C10.062 11.8613 10.0667 12.0573 10.1227 12.16C10.1974 12.3 10.314 12.398 10.4727 12.454C10.5194 12.4727 10.6174 12.482 10.7667 12.482C10.9067 12.482 11.0094 12.4727 11.0747 12.454C11.3174 12.3793 11.56 12.23 11.8027 12.006C12.092 11.7073 12.2834 11.3807 12.3767 11.026C12.4047 10.9327 12.442 10.8813 12.4887 10.872C12.526 10.8627 12.61 10.858 12.7407 10.858C12.918 10.858 13.0207 10.8673 13.0487 10.886C13.0674 10.9047 13.0767 10.9373 13.0767 10.984C13.0767 11.18 12.9554 11.474 12.7127 11.866C12.7034 11.894 12.6894 11.9173 12.6707 11.936C12.2507 12.58 11.6954 12.9767 11.0047 13.126C10.79 13.1633 10.5474 13.1633 10.2767 13.126C9.80069 13.0233 9.44603 12.8133 9.21269 12.496L9.12869 12.37L9.08669 12.412C8.72269 12.8787 8.31203 13.126 7.85469 13.154C7.32269 13.182 6.92603 12.986 6.66469 12.566C6.60869 12.4913 6.56669 12.4073 6.53869 12.314C6.47336 12.1087 6.45469 11.8893 6.48269 11.656C6.54803 11.2547 6.73469 10.9793 7.04269 10.83C7.34136 10.69 7.60736 10.6853 7.84069 10.816C8.05536 10.9187 8.15336 11.1053 8.13469 11.376C8.10669 11.7493 7.93403 12.02 7.61669 12.188C7.57003 12.216 7.50469 12.244 7.42069 12.272L7.36469 12.286L7.40669 12.328C7.53736 12.4307 7.68669 12.482 7.85469 12.482C7.97603 12.4913 8.10203 12.4587 8.23269 12.384C8.47536 12.216 8.65736 11.9593 8.77869 11.614L9.54869 8.53399C9.61403 8.19799 9.62336 7.96466 9.57669 7.83399C9.53003 7.68466 9.40869 7.57732 9.21269 7.51199C9.02603 7.45599 8.83469 7.45599 8.63869 7.51199C8.36803 7.58666 8.13003 7.72666 7.92469 7.93199C7.65403 8.21199 7.45803 8.52466 7.33669 8.86999C7.30869 8.98199 7.28069 9.05199 7.25269 9.07999C7.23403 9.09866 7.13603 9.10799 6.95869 9.10799H6.69269L6.65069 9.06599C6.62269 9.03799 6.60869 9.00066 6.60869 8.95399C6.63669 8.81399 6.69269 8.65532 6.77669 8.47799C6.86069 8.28199 6.96803 8.09532 7.09869 7.91799C7.24803 7.69399 7.45336 7.48399 7.71469 7.28799C7.72403 7.27866 7.73803 7.26932 7.75669 7.25999C8.06469 7.04532 8.39603 6.90066 8.75069 6.82599Z"
-        fill="currentColor"
-      />
-    </svg>
-  ),
-  yAbsolute: (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        fillRule="evenodd"
-        clipRule="evenodd"
-        d="M4 16V4H5L5 16H4ZM7.92469 6.83999C8.11136 6.79332 8.33069 6.79799 8.58269 6.85399C9.05869 6.98466 9.36203 7.26932 9.49269 7.70799C9.53003 7.86666 9.53003 8.06732 9.49269 8.30999C9.47403 8.37532 9.40403 8.56666 9.28269 8.88399C8.94669 9.78932 8.72736 10.4847 8.62469 10.97C8.52203 11.5953 8.57803 12.0293 8.79269 12.272C8.95136 12.4587 9.17536 12.5287 9.46469 12.482C9.88469 12.426 10.2534 12.174 10.5707 11.726L10.6547 11.6L11.1587 9.54199C11.5134 8.15132 11.7047 7.43266 11.7327 7.38599C11.882 7.11532 12.106 6.97532 12.4047 6.96599C12.554 6.96599 12.68 7.00799 12.7827 7.09199C12.8294 7.11066 12.8714 7.16199 12.9087 7.24599C12.9554 7.33932 12.9647 7.45599 12.9367 7.59599C12.9087 7.73599 12.6847 8.65532 12.2647 10.354C11.742 12.3887 11.49 13.3733 11.5087 13.308C11.4154 13.6067 11.2754 13.882 11.0887 14.134C10.566 14.9273 9.87536 15.4593 9.01669 15.73C8.60603 15.87 8.20469 15.912 7.81269 15.856C7.11269 15.7533 6.67403 15.436 6.49669 14.904C6.45936 14.6987 6.46403 14.5073 6.51069 14.33C6.56669 14.0967 6.68336 13.91 6.86069 13.77C7.19669 13.5273 7.51403 13.4807 7.81269 13.63C7.92469 13.6953 8.00869 13.784 8.06469 13.896C8.16736 14.12 8.14869 14.3627 8.00869 14.624C7.91536 14.8013 7.78936 14.932 7.63069 15.016L7.54669 15.072L7.61669 15.1C7.98069 15.2587 8.36336 15.2587 8.76469 15.1C9.26869 14.8947 9.68869 14.442 10.0247 13.742C10.09 13.5927 10.1507 13.4433 10.2067 13.294C10.3187 12.9673 10.3654 12.7993 10.3467 12.79C10.3374 12.79 10.3047 12.8087 10.2487 12.846C10.1087 12.93 9.95936 13 9.80069 13.056C9.28736 13.2333 8.76003 13.2007 8.21869 12.958C8.08803 12.902 7.97136 12.832 7.86869 12.748C7.44869 12.412 7.26669 11.8987 7.32269 11.208C7.36003 10.7507 7.57936 9.98066 7.98069 8.89799C7.99003 8.86066 7.99936 8.82799 8.00869 8.79999C8.13936 8.47332 8.20936 8.27732 8.21869 8.21199C8.33069 7.89466 8.34469 7.67532 8.26069 7.55399C8.22336 7.49799 8.14869 7.46999 8.03669 7.46999C7.63536 7.50732 7.30403 7.84799 7.04269 8.49199C6.99603 8.60399 6.95403 8.72532 6.91669 8.85599C6.87003 9.00532 6.83269 9.08466 6.80469 9.09399C6.79536 9.10332 6.69736 9.10799 6.51069 9.10799H6.25869L6.21669 9.06599C6.17003 9.02866 6.17469 8.93066 6.23069 8.77199C6.40803 8.17466 6.67869 7.70332 7.04269 7.35799C7.30403 7.08732 7.59803 6.91466 7.92469 6.83999ZM15 4L15 16H16L16 4H15Z"
-        fill="currentColor"
-      />
-    </svg>
-  ),
-  yRelative: (
-    <svg viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
-      <path
-        d="M7.92463 6.83998C8.1113 6.79332 8.33063 6.79798 8.58263 6.85398C9.05863 6.98465 9.36197 7.26932 9.49263 7.70798C9.52997 7.86665 9.52997 8.06732 9.49263 8.30998C9.47397 8.37532 9.40397 8.56665 9.28263 8.88399C8.94663 9.78932 8.7273 10.4847 8.62463 10.97C8.52197 11.5953 8.57797 12.0293 8.79263 12.272C8.9513 12.4587 9.1753 12.5287 9.46463 12.482C9.88463 12.426 10.2533 12.174 10.5706 11.726L10.6546 11.6L11.1586 9.54198C11.5133 8.15132 11.7046 7.43265 11.7326 7.38598C11.882 7.11532 12.106 6.97532 12.4046 6.96598C12.554 6.96598 12.68 7.00798 12.7826 7.09198C12.8293 7.11065 12.8713 7.16198 12.9086 7.24598C12.9553 7.33932 12.9646 7.45598 12.9366 7.59598C12.9086 7.73598 12.6846 8.65532 12.2646 10.354C11.742 12.3887 11.49 13.3733 11.5086 13.308C11.4153 13.6067 11.2753 13.882 11.0886 14.134C10.566 14.9273 9.8753 15.4593 9.01663 15.73C8.60597 15.87 8.20463 15.912 7.81263 15.856C7.11263 15.7533 6.67397 15.436 6.49663 14.904C6.4593 14.6987 6.46397 14.5073 6.51063 14.33C6.56663 14.0967 6.6833 13.91 6.86063 13.77C7.19663 13.5273 7.51397 13.4807 7.81263 13.63C7.92463 13.6953 8.00863 13.784 8.06463 13.896C8.1673 14.12 8.14863 14.3627 8.00863 14.624C7.9153 14.8013 7.7893 14.932 7.63063 15.016L7.54663 15.072L7.61663 15.1C7.98063 15.2587 8.3633 15.2587 8.76463 15.1C9.26863 14.8947 9.68863 14.442 10.0246 13.742C10.09 13.5927 10.1506 13.4433 10.2066 13.294C10.3186 12.9673 10.3653 12.7993 10.3466 12.79C10.3373 12.79 10.3046 12.8087 10.2486 12.846C10.1086 12.93 9.9593 13 9.80063 13.056C9.2873 13.2333 8.75997 13.2007 8.21863 12.958C8.08797 12.902 7.9713 12.832 7.86863 12.748C7.44863 12.412 7.26663 11.8987 7.32263 11.208C7.35997 10.7507 7.5793 9.98065 7.98063 8.89798C7.98997 8.86065 7.9993 8.82798 8.00863 8.79998C8.1393 8.47332 8.2093 8.27732 8.21863 8.21198C8.33063 7.89465 8.34463 7.67532 8.26063 7.55398C8.2233 7.49798 8.14863 7.46998 8.03663 7.46998C7.6353 7.50732 7.30397 7.84798 7.04263 8.49198C6.99597 8.60398 6.95397 8.72532 6.91663 8.85598C6.86997 9.00532 6.83263 9.08465 6.80463 9.09398C6.7953 9.10332 6.6973 9.10798 6.51063 9.10798H6.25863L6.21663 9.06598C6.16997 9.02865 6.17463 8.93065 6.23063 8.77198C6.40797 8.17465 6.67863 7.70332 7.04263 7.35798C7.30397 7.08732 7.59797 6.91465 7.92463 6.83998Z"
-        fill="currentColor"
-      />
-    </svg>
-  ),
 } as const
 
 export type CustomIconName = keyof typeof CustomIconMap

src/components/FileMachineProvider.tsx

@@ -11,7 +11,6 @@ import {
   InterpreterFrom,
   Prop,
   StateFrom,
-  assign,
 } from 'xstate'
 import { useCommandsContext } from 'hooks/useCommandsContext'
 import { fileMachine } from 'machines/fileMachine'
@@ -38,7 +37,7 @@ export const FileMachineProvider = ({
 }) => {
   const navigate = useNavigate()
   const { commandBarSend } = useCommandsContext()
-  const { project, file } = useRouteLoaderData(paths.FILE) as IndexLoaderData
+  const { project } = useRouteLoaderData(paths.FILE) as IndexLoaderData
 
   const [state, send] = useMachine(fileMachine, {
     context: {
@@ -54,32 +53,8 @@ export const FileMachineProvider = ({
               context.selectedDirectory + sep() + event.data.name
             )}`
           )
-        } else if (
-          event.data &&
-          'path' in event.data &&
-          event.data.path.endsWith(FILE_EXT)
-        ) {
-          // Don't navigate to newly created directories
-          navigate(`${paths.FILE}/${encodeURIComponent(event.data.path)}`)
         }
       },
-      addFileToRenamingQueue: assign({
-        itemsBeingRenamed: (context, event) => [
-          ...context.itemsBeingRenamed,
-          event.data.path,
-        ],
-      }),
-      removeFileFromRenamingQueue: assign({
-        itemsBeingRenamed: (
-          context,
-          event: EventFrom<typeof fileMachine, 'done.invoke.rename-file'>
-        ) =>
-          context.itemsBeingRenamed.filter(
-            (path) => path !== event.data.oldPath
-          ),
-      }),
-      renameToastSuccess: (_, event) => toast.success(event.data.message),
-      createToastSuccess: (_, event) => toast.success(event.data.message),
       toastSuccess: (_, event) =>
         event.data && toast.success((event.data || '') + ''),
       toastError: (_, event) => toast.error((event.data || '') + ''),
@@ -95,56 +70,37 @@ export const FileMachineProvider = ({
         }
       },
       createFile: async (context, event) => {
-        let createdName = event.data.name.trim() || DEFAULT_FILE_NAME
+        let name = event.data.name.trim() || DEFAULT_FILE_NAME
-        let createdPath: string
 
         if (event.data.makeDir) {
-          createdPath = await join(context.selectedDirectory.path, createdName)
+          await mkdir(await join(context.selectedDirectory.path, name))
-          await mkdir(createdPath)
         } else {
-          createdPath =
+          await create(
             context.selectedDirectory.path +
-            sep() +
+              sep() +
-            createdName +
+              name +
-            (createdName.endsWith(FILE_EXT) ? '' : FILE_EXT)
+              (name.endsWith(FILE_EXT) ? '' : FILE_EXT)
-          await create(createdPath)
+          )
         }
 
-        return {
+        return `Successfully created "${name}"`
-          message: `Successfully created "${createdName}"`,
-          path: createdPath,
-        }
       },
       renameFile: async (
         context: ContextFrom<typeof fileMachine>,
         event: EventFrom<typeof fileMachine, 'Rename file'>
       ) => {
         const { oldName, newName, isDir } = event.data
-        const name = newName ? newName : DEFAULT_FILE_NAME
+        let name = newName ? newName : DEFAULT_FILE_NAME
-        const oldPath = await join(context.selectedDirectory.path, oldName)
-        const newDirPath = await join(context.selectedDirectory.path, name)
-        const newPath =
-          newDirPath + (name.endsWith(FILE_EXT) || isDir ? '' : FILE_EXT)
 
-        await rename(oldPath, newPath, {})
+        await rename(
-
+          await join(context.selectedDirectory.path, oldName),
-        if (oldPath === file?.path && project?.path) {
+          (await join(context.selectedDirectory.path, name)) +
-          // If we just renamed the current file, navigate to the new path
+            (name.endsWith(FILE_EXT) || isDir ? '' : FILE_EXT),
-          navigate(paths.FILE + '/' + encodeURIComponent(newPath))
+          {}
-        } else if (file?.path.includes(oldPath)) {
+        )
-          // If we just renamed a directory that the current file is in, navigate to the new path
+        return (
-          navigate(
+          oldName !== name && `Successfully renamed "${oldName}" to "${name}"`
-            paths.FILE +
+        )
-              '/' +
-              encodeURIComponent(file.path.replace(oldPath, newDirPath))
-          )
-        }
-
-        return {
-          message: `Successfully renamed "${oldName}" to "${name}"`,
-          newPath,
-          oldPath,
-        }
       },
       deleteFile: async (
         context: ContextFrom<typeof fileMachine>,
@@ -161,17 +117,6 @@ export const FileMachineProvider = ({
             console.error('Error deleting file', e)
           )
         }
-
-        // If we just deleted the current file or one of its parent directories,
-        // navigate to the project root
-        if (
-          (event.data.path === file?.path ||
-            file?.path.includes(event.data.path)) &&
-          project?.path
-        ) {
-          navigate(paths.FILE + '/' + encodeURIComponent(project.path))
-        }
-
         return `Successfully deleted ${isDir ? 'folder' : 'file'} "${
           event.data.name
         }"`

src/components/FileTree.tsx

@@ -2,11 +2,11 @@ import type { FileEntry, IndexLoaderData } from 'lib/types'
 import { paths } from 'lib/paths'
 import { ActionButton } from './ActionButton'
 import Tooltip from './Tooltip'
-import { Dispatch, useCallback, useEffect, useRef, useState } from 'react'
+import { Dispatch, useEffect, useRef, useState } from 'react'
 import { useNavigate, useRouteLoaderData } from 'react-router-dom'
-import { Disclosure } from '@headlessui/react'
+import { Dialog, Disclosure } from '@headlessui/react'
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
-import { faChevronRight } from '@fortawesome/free-solid-svg-icons'
+import { faChevronRight, faTrashAlt } from '@fortawesome/free-solid-svg-icons'
 import { useFileContext } from 'hooks/useFileContext'
 import styles from './FileTree.module.css'
 import { sortProject } from 'lib/tauriFS'
@@ -16,8 +16,6 @@ import { codeManager, kclManager } from 'lib/singletons'
 import { useDocumentHasFocus } from 'hooks/useDocumentHasFocus'
 import { useLspContext } from './LspProvider'
 import useHotkeyWrapper from 'lib/hotkeyWrapper'
-import { useModelingContext } from 'hooks/useModelingContext'
-import { DeleteConfirmationDialog } from './ProjectCard/DeleteProjectDialog'
 
 function getIndentationCSS(level: number) {
   return `calc(1rem * ${level + 1})`
@@ -25,11 +23,11 @@ function getIndentationCSS(level: number) {
 
 function RenameForm({
   fileOrDir,
-  onSubmit,
+  setIsRenaming,
   level = 0,
 }: {
   fileOrDir: FileEntry
-  onSubmit: () => void
+  setIsRenaming: Dispatch<React.SetStateAction<boolean>>
   level?: number
 }) {
   const { send } = useFileContext()
@@ -37,6 +35,7 @@ function RenameForm({
 
   function handleRenameSubmit(e: React.FormEvent<HTMLFormElement>) {
     e.preventDefault()
+    setIsRenaming(false)
     send({
       type: 'Rename file',
       data: {
@@ -50,7 +49,7 @@ function RenameForm({
   function handleKeyDown(e: React.KeyboardEvent<HTMLInputElement>) {
     if (e.key === 'Escape') {
       e.stopPropagation()
-      onSubmit()
+      setIsRenaming(false)
     }
   }
 
@@ -62,12 +61,10 @@ function RenameForm({
           ref={inputRef}
           type="text"
           autoFocus
-          autoCapitalize="off"
-          autoCorrect="off"
           placeholder={fileOrDir.name}
           className="w-full py-1 bg-transparent text-chalkboard-100 placeholder:text-chalkboard-70 dark:text-chalkboard-10 dark:placeholder:text-chalkboard-50 focus:outline-none focus:ring-0"
           onKeyDown={handleKeyDown}
-          onBlur={onSubmit}
+          onBlur={() => setIsRenaming(false)}
           style={{ paddingInlineStart: getIndentationCSS(level) }}
         />
       </label>
@@ -78,7 +75,7 @@ function RenameForm({
   )
 }
 
-function DeleteFileTreeItemDialog({
+function DeleteConfirmationDialog({
   fileOrDir,
   setIsOpen,
 }: {
@@ -87,23 +84,48 @@ function DeleteFileTreeItemDialog({
 }) {
   const { send } = useFileContext()
   return (
-    <DeleteConfirmationDialog
+    <Dialog
-      title={`Delete ${fileOrDir.children !== undefined ? 'folder' : 'file'}`}
+      open={true}
-      onDismiss={() => setIsOpen(false)}
+      onClose={() => setIsOpen(false)}
-      onConfirm={() => {
+      className="relative z-50"
-        send({ type: 'Delete file', data: fileOrDir })
-        setIsOpen(false)
-      }}
     >
-      <p className="my-4">
+      <div className="fixed inset-0 bg-chalkboard-110/80 grid place-content-center">
-        This will permanently delete "{fileOrDir.name || 'this file'}"
+        <Dialog.Panel className="rounded p-4 bg-chalkboard-10 dark:bg-chalkboard-100 border border-destroy-80 max-w-2xl">
-        {fileOrDir.children !== undefined ? ' and all of its contents. ' : '. '}
+          <Dialog.Title as="h2" className="text-2xl font-bold mb-4">
-      </p>
+            Delete {fileOrDir.children !== undefined ? 'Folder' : 'File'}
-      <p className="my-4">
+          </Dialog.Title>
-        Are you sure you want to delete "{fileOrDir.name || 'this file'}
+          <Dialog.Description className="my-6">
-        "? This action cannot be undone.
+            This will permanently delete "{fileOrDir.name || 'this file'}"
-      </p>
+            {fileOrDir.children !== undefined
-    </DeleteConfirmationDialog>
+              ? ' and all of its contents. '
+              : '. '}
+            This action cannot be undone.
+          </Dialog.Description>
+
+          <div className="flex justify-between">
+            <ActionButton
+              Element="button"
+              onClick={async () => {
+                send({ type: 'Delete file', data: fileOrDir })
+                setIsOpen(false)
+              }}
+              iconStart={{
+                icon: faTrashAlt,
+                bgClassName: 'bg-destroy-80',
+                iconClassName:
+                  'text-destroy-20 group-hover:text-destroy-10 hover:text-destroy-10 dark:text-destroy-20 dark:group-hover:text-destroy-10 dark:hover:text-destroy-10',
+              }}
+              className="hover:border-destroy-40 dark:hover:border-destroy-40"
+            >
+              Delete
+            </ActionButton>
+            <ActionButton Element="button" onClick={() => setIsOpen(false)}>
+              Cancel
+            </ActionButton>
+          </div>
+        </Dialog.Panel>
+      </div>
+    </Dialog>
   )
 }
 
@@ -111,57 +133,35 @@ const FileTreeItem = ({
   project,
   currentFile,
   fileOrDir,
-  onNavigateToFile,
+  onDoubleClick,
   level = 0,
 }: {
   project?: IndexLoaderData['project']
   currentFile?: IndexLoaderData['file']
   fileOrDir: FileEntry
-  onNavigateToFile?: () => void
+  onDoubleClick?: () => void
   level?: number
 }) => {
-  const { send: fileSend, context: fileContext } = useFileContext()
+  const { send, context } = useFileContext()
   const { onFileOpen, onFileClose } = useLspContext()
   const navigate = useNavigate()
+  const [isRenaming, setIsRenaming] = useState(false)
   const [isConfirmingDelete, setIsConfirmingDelete] = useState(false)
   const isCurrentFile = fileOrDir.path === currentFile?.path
 
-  const isRenaming = fileContext.itemsBeingRenamed.includes(fileOrDir.path)
-  const removeCurrentItemFromRenaming = useCallback(
-    () =>
-      fileSend({
-        type: 'assign',
-        data: {
-          itemsBeingRenamed: fileContext.itemsBeingRenamed.filter(
-            (path) => path !== fileOrDir.path
-          ),
-        },
-      }),
-    [fileContext.itemsBeingRenamed, fileOrDir.path, fileSend]
-  )
-
-  const addCurrentItemToRenaming = useCallback(() => {
-    fileSend({
-      type: 'assign',
-      data: {
-        itemsBeingRenamed: [...fileContext.itemsBeingRenamed, fileOrDir.path],
-      },
-    })
-  }, [fileContext.itemsBeingRenamed, fileOrDir.path, fileSend])
-
   function handleKeyUp(e: React.KeyboardEvent<HTMLButtonElement>) {
     if (e.metaKey && e.key === 'Backspace') {
       // Open confirmation dialog
       setIsConfirmingDelete(true)
     } else if (e.key === 'Enter') {
       // Show the renaming form
-      addCurrentItemToRenaming()
+      setIsRenaming(true)
     } else if (e.code === 'Space') {
-      handleClick()
+      handleDoubleClick()
     }
   }
 
-  function handleClick() {
+  function handleDoubleClick() {
     if (fileOrDir.children !== undefined) return // Don't open directories
 
     if (fileOrDir.name?.endsWith(FILE_EXT) === false && project?.path) {
@@ -172,7 +172,7 @@ const FileTreeItem = ({
           codeManager.code
       )
       codeManager.writeToFile()
-      kclManager.executeCode(true, true)
+      kclManager.executeCode(true)
     } else {
       // Let the lsp servers know we closed a file.
       onFileClose(currentFile?.path || null, project?.path || null)
@@ -181,7 +181,7 @@ const FileTreeItem = ({
       // Open kcl files
       navigate(`${paths.FILE}/${encodeURIComponent(fileOrDir.path)}`)
     }
-    onNavigateToFile?.()
+    onDoubleClick?.()
   }
 
   return (
@@ -199,10 +199,8 @@ const FileTreeItem = ({
             <button
               className="flex gap-1 items-center py-0.5 rounded-none border-none p-0 m-0 text-sm w-full hover:!bg-transparent text-left !text-inherit"
               style={{ paddingInlineStart: getIndentationCSS(level) }}
-              onClick={(e) => {
+              onDoubleClick={handleDoubleClick}
-                e.currentTarget.focus()
+              onClick={(e) => e.currentTarget.focus()}
-                handleClick()
-              }}
               onKeyUp={handleKeyUp}
             >
               <CustomIcon
@@ -214,7 +212,7 @@ const FileTreeItem = ({
           ) : (
             <RenameForm
               fileOrDir={fileOrDir}
-              onSubmit={removeCurrentItemFromRenaming}
+              setIsRenaming={setIsRenaming}
               level={level}
             />
           )}
@@ -227,23 +225,17 @@ const FileTreeItem = ({
                 <Disclosure.Button
                   className={
                     ' group border-none text-sm rounded-none p-0 m-0 flex items-center justify-start w-full py-0.5 hover:text-primary hover:bg-primary/5 dark:hover:text-inherit dark:hover:bg-primary/10' +
-                    (fileContext.selectedDirectory.path.includes(fileOrDir.path)
+                    (context.selectedDirectory.path.includes(fileOrDir.path)
                       ? ' ui-open:bg-primary/10'
                       : '')
                   }
                   style={{ paddingInlineStart: getIndentationCSS(level) }}
                   onClick={(e) => e.currentTarget.focus()}
                   onClickCapture={(e) =>
-                    fileSend({
+                    send({ type: 'Set selected directory', data: fileOrDir })
-                      type: 'Set selected directory',
-                      data: fileOrDir,
-                    })
                   }
                   onFocusCapture={(e) =>
-                    fileSend({
+                    send({ type: 'Set selected directory', data: fileOrDir })
-                      type: 'Set selected directory',
-                      data: fileOrDir,
-                    })
                   }
                   onKeyDown={(e) => e.key === 'Enter' && e.preventDefault()}
                   onKeyUp={handleKeyUp}
@@ -271,7 +263,7 @@ const FileTreeItem = ({
                   />
                   <RenameForm
                     fileOrDir={fileOrDir}
-                    onSubmit={removeCurrentItemFromRenaming}
+                    setIsRenaming={setIsRenaming}
                     level={-1}
                   />
                 </div>
@@ -287,16 +279,10 @@ const FileTreeItem = ({
                 <ul
                   className="m-0 p-0"
                   onClickCapture={(e) => {
-                    fileSend({
+                    send({ type: 'Set selected directory', data: fileOrDir })
-                      type: 'Set selected directory',
-                      data: fileOrDir,
-                    })
                   }}
                   onFocusCapture={(e) =>
-                    fileSend({
+                    send({ type: 'Set selected directory', data: fileOrDir })
-                      type: 'Set selected directory',
-                      data: fileOrDir,
-                    })
                   }
                 >
                   {fileOrDir.children?.map((child) => (
@@ -304,7 +290,7 @@ const FileTreeItem = ({
                       fileOrDir={child}
                       project={project}
                       currentFile={currentFile}
-                      onNavigateToFile={onNavigateToFile}
+                      onDoubleClick={onDoubleClick}
                       level={level + 1}
                       key={level + '-' + child.path}
                     />
@@ -316,7 +302,7 @@ const FileTreeItem = ({
         </Disclosure>
       )}
       {isConfirmingDelete && (
-        <DeleteFileTreeItemDialog
+        <DeleteConfirmationDialog
           fileOrDir={fileOrDir}
           setIsOpen={setIsConfirmingDelete}
         />
@@ -328,7 +314,7 @@ const FileTreeItem = ({
 interface FileTreeProps {
   className?: string
   file?: IndexLoaderData['file']
-  onNavigateToFile: (
+  closePanel: (
     focusableElement?:
       | HTMLElement
       | React.MutableRefObject<HTMLElement | null>
@@ -385,34 +371,30 @@ export const FileTreeMenu = () => {
   )
 }
 
-export const FileTree = ({
+export const FileTree = ({ className = '', closePanel }: FileTreeProps) => {
-  className = '',
-  onNavigateToFile: closePanel,
-}: FileTreeProps) => {
   return (
     <div className={className}>
       <div className="flex items-center gap-1 px-4 py-1 bg-chalkboard-20/40 dark:bg-chalkboard-80/50 border-b border-b-chalkboard-30 dark:border-b-chalkboard-80">
         <h2 className="flex-1 m-0 p-0 text-sm mono">Files</h2>
         <FileTreeMenu />
       </div>
-      <FileTreeInner onNavigateToFile={closePanel} />
+      <FileTreeInner onDoubleClick={closePanel} />
     </div>
   )
 }
 
 export const FileTreeInner = ({
-  onNavigateToFile,
+  onDoubleClick,
 }: {
-  onNavigateToFile?: () => void
+  onDoubleClick?: () => void
 }) => {
   const loaderData = useRouteLoaderData(paths.FILE) as IndexLoaderData
-  const { send: fileSend, context: fileContext } = useFileContext()
+  const { send, context } = useFileContext()
-  const { send: modelingSend } = useModelingContext()
   const documentHasFocus = useDocumentHasFocus()
 
   // Refresh the file tree when the document gets focus
   useEffect(() => {
-    fileSend({ type: 'Refresh' })
+    send({ type: 'Refresh' })
   }, [documentHasFocus])
 
   return (
@@ -420,22 +402,15 @@ export const FileTreeInner = ({
       <ul
         className="m-0 p-0 text-sm"
         onClickCapture={(e) => {
-          fileSend({
+          send({ type: 'Set selected directory', data: context.project })
-            type: 'Set selected directory',
-            data: fileContext.project,
-          })
         }}
       >
-        {sortProject(fileContext.project?.children || []).map((fileOrDir) => (
+        {sortProject(context.project.children || []).map((fileOrDir) => (
           <FileTreeItem
-            project={fileContext.project}
+            project={context.project}
             currentFile={loaderData?.file}
             fileOrDir={fileOrDir}
-            onNavigateToFile={() => {
+            onDoubleClick={onDoubleClick}
-              // Reset modeling state when navigating to a new file
-              modelingSend({ type: 'Cancel' })
-              onNavigateToFile?.()
-            }}
             key={fileOrDir.path}
           />
         ))}

src/components/Gizmo.tsx

@@ -1,146 +0,0 @@
-import { sceneInfra } from 'lib/singletons'
-import { useEffect, useRef } from 'react'
-import {
-  WebGLRenderer,
-  Scene,
-  OrthographicCamera,
-  BoxGeometry,
-  SphereGeometry,
-  MeshBasicMaterial,
-  Color,
-  Mesh,
-  Clock,
-  Quaternion,
-  ColorRepresentation,
-} from 'three'
-
-const CANVAS_SIZE = 80
-const FRUSTUM_SIZE = 0.5
-const AXIS_LENGTH = 0.35
-const AXIS_WIDTH = 0.02
-const AXIS_COLORS = {
-  x: '#fa6668',
-  y: '#11eb6b',
-  z: '#6689ef',
-  gray: '#c6c7c2',
-}
-
-export default function Gizmo() {
-  const canvasRef = useRef<HTMLCanvasElement | null>(null)
-
-  useEffect(() => {
-    if (!canvasRef.current) return
-
-    const canvas = canvasRef.current
-    const renderer = new WebGLRenderer({ canvas, antialias: true, alpha: true })
-    renderer.setSize(CANVAS_SIZE, CANVAS_SIZE)
-    renderer.setPixelRatio(Math.min(window.devicePixelRatio, 2))
-
-    const scene = new Scene()
-    const camera = createCamera()
-    const { gizmoAxes, gizmoAxisHeads } = createGizmo()
-    scene.add(...gizmoAxes, ...gizmoAxisHeads)
-
-    const clock = new Clock()
-    const clientCamera = sceneInfra.camControls.camera
-    let currentQuaternion = new Quaternion().copy(clientCamera.quaternion)
-
-    const animate = () => {
-      requestAnimationFrame(animate)
-      updateCameraOrientation(
-        camera,
-        currentQuaternion,
-        sceneInfra.camControls.camera.quaternion,
-        clock.getDelta()
-      )
-      renderer.render(scene, camera)
-    }
-    animate()
-
-    return () => {
-      renderer.dispose()
-    }
-  }, [])
-
-  return (
-    <div className="grid place-content-center rounded-full overflow-hidden border border-solid border-primary/50 pointer-events-none">
-      <canvas ref={canvasRef} />
-    </div>
-  )
-}
-
-const createCamera = () => {
-  return new OrthographicCamera(
-    -FRUSTUM_SIZE,
-    FRUSTUM_SIZE,
-    FRUSTUM_SIZE,
-    -FRUSTUM_SIZE,
-    0.5,
-    3
-  )
-}
-
-const createGizmo = () => {
-  const gizmoAxes = [
-    createAxis(AXIS_LENGTH, AXIS_WIDTH, AXIS_COLORS.x, 0, 'z'),
-    createAxis(AXIS_LENGTH, AXIS_WIDTH, AXIS_COLORS.y, Math.PI / 2, 'z'),
-    createAxis(AXIS_LENGTH, AXIS_WIDTH, AXIS_COLORS.z, -Math.PI / 2, 'y'),
-    createAxis(AXIS_LENGTH, AXIS_WIDTH, AXIS_COLORS.gray, Math.PI, 'z'),
-    createAxis(AXIS_LENGTH, AXIS_WIDTH, AXIS_COLORS.gray, -Math.PI / 2, 'z'),
-    createAxis(AXIS_LENGTH, AXIS_WIDTH, AXIS_COLORS.gray, Math.PI / 2, 'y'),
-  ]
-
-  const gizmoAxisHeads = [
-    createAxisHead(AXIS_LENGTH, AXIS_COLORS.x, 0, 'z'),
-    createAxisHead(AXIS_LENGTH, AXIS_COLORS.y, Math.PI / 2, 'z'),
-    createAxisHead(AXIS_LENGTH, AXIS_COLORS.z, -Math.PI / 2, 'y'),
-    createAxisHead(AXIS_LENGTH, AXIS_COLORS.gray, Math.PI, 'z'),
-    createAxisHead(AXIS_LENGTH, AXIS_COLORS.gray, -Math.PI / 2, 'z'),
-    createAxisHead(AXIS_LENGTH, AXIS_COLORS.gray, Math.PI / 2, 'y'),
-  ]
-
-  return { gizmoAxes, gizmoAxisHeads }
-}
-
-const createAxis = (
-  length: number,
-  width: number,
-  color: ColorRepresentation,
-  rotation = 0,
-  axis = 'x'
-) => {
-  const geometry = new BoxGeometry(length, width, width).translate(
-    length / 2,
-    0,
-    0
-  )
-  const material = new MeshBasicMaterial({ color: new Color(color) })
-  const mesh = new Mesh(geometry, material)
-  mesh.rotation[axis as 'x' | 'y' | 'z'] = rotation
-  return mesh
-}
-
-const createAxisHead = (
-  length: number,
-  color: ColorRepresentation,
-  rotation = 0,
-  axis = 'x'
-) => {
-  const geometry = new SphereGeometry(0.065, 16, 8).translate(length, 0, 0)
-  const material = new MeshBasicMaterial({ color: new Color(color) })
-  const mesh = new Mesh(geometry, material)
-  mesh.rotation[axis as 'x' | 'y' | 'z'] = rotation
-  return mesh
-}
-
-const updateCameraOrientation = (
-  camera: OrthographicCamera,
-  currentQuaternion: Quaternion,
-  targetQuaternion: Quaternion,
-  deltaTime: number
-) => {
-  const slerpFactor = 1 - Math.exp(-30 * deltaTime)
-  currentQuaternion.slerp(targetQuaternion, slerpFactor).normalize()
-  camera.position.set(0, 0, 1).applyQuaternion(currentQuaternion)
-  camera.quaternion.copy(currentQuaternion)
-}

src/components/LowerRightControls.tsx

@@ -13,19 +13,17 @@ export function LowerRightControls(props: React.PropsWithChildren) {
   const linkOverrideClassName =
     '!text-chalkboard-70 hover:!text-chalkboard-80 dark:!text-chalkboard-40 dark:hover:!text-chalkboard-30'
 
-  const isPlayWright = window?.localStorage.getItem('playwright') === 'true'
-
   return (
-    <section className="fixed bottom-2 right-2 flex flex-col items-end gap-3 pointer-events-none">
+    <section className="fixed bottom-2 right-2">
       {props.children}
-      <menu className="flex items-center justify-end gap-3 pointer-events-auto">
+      <menu className="flex items-center justify-end gap-3">
         <a
           href={`https://github.com/KittyCAD/modeling-app/releases/tag/v${APP_VERSION}`}
           target="_blank"
           rel="noopener noreferrer"
           className={'!no-underline font-mono text-xs ' + linkOverrideClassName}
         >
-          v{isPlayWright ? '11.22.33' : APP_VERSION}
+          v{APP_VERSION}
         </a>
         <a
           href="https://github.com/KittyCAD/modeling-app/issues/new/choose"

src/components/ModelingMachineProvider.tsx

@@ -11,17 +11,13 @@ import {
 import { SetSelections, modelingMachine } from 'machines/modelingMachine'
 import { useSetupEngineManager } from 'hooks/useSetupEngineManager'
 import { useSettingsAuthContext } from 'hooks/useSettingsAuthContext'
-import {
+import { isCursorInSketchCommandRange } from 'lang/util'
-  isCursorInSketchCommandRange,
-  updatePathToNodeFromMap,
-} from 'lang/util'
 import {
   kclManager,
   sceneInfra,
   engineCommandManager,
   codeManager,
   editorManager,
-  sceneEntitiesManager,
 } from 'lib/singletons'
 import { applyConstraintHorzVertDistance } from './Toolbar/SetHorzVertDistance'
 import {
@@ -43,24 +39,11 @@ import { applyConstraintAbsDistance } from './Toolbar/SetAbsDistance'
 import useStateMachineCommands from 'hooks/useStateMachineCommands'
 import { modelingMachineConfig } from 'lib/commandBarConfigs/modelingCommandConfig'
 import {
-  STRAIGHT_SEGMENT,
-  TANGENTIAL_ARC_TO_SEGMENT,
-  getParentGroup,
   getSketchOrientationDetails,
   getSketchQuaternion,
 } from 'clientSideScene/sceneEntities'
-import {
+import { sketchOnExtrudedFace, startSketchOnDefault } from 'lang/modifyAst'
-  moveValueIntoNewVariablePath,
+import { Program, VariableDeclaration, coreDump } from 'lang/wasm'
-  sketchOnExtrudedFace,
-  startSketchOnDefault,
-} from 'lang/modifyAst'
-import {
-  Program,
-  VariableDeclaration,
-  coreDump,
-  parse,
-  recast,
-} from 'lang/wasm'
 import {
   getNodeFromPath,
   getNodePathFromSourceRange,
@@ -74,7 +57,6 @@ import { EditorSelection } from '@uiw/react-codemirror'
 import { CoreDumpManager } from 'lib/coredump'
 import { useSearchParams } from 'react-router-dom'
 import { letEngineAnimateAndSyncCamAfter } from 'clientSideScene/CameraControls'
-import { getVarNameModal } from 'hooks/useToolbarGuards'
 import useHotkeyWrapper from 'lib/hotkeyWrapper'
 
 type MachineContext<T extends AnyStateMachine> = {
@@ -145,84 +127,10 @@ export const ModelingMachineProvider = ({
         },
         'Set mouse state': assign({
           mouseState: (_, event) => event.data,
-          segmentHoverMap: ({ mouseState, segmentHoverMap }, event) => {
-            if (event.data.type === 'isHovering') {
-              const parent = getParentGroup(event.data.on, [
-                STRAIGHT_SEGMENT,
-                TANGENTIAL_ARC_TO_SEGMENT,
-              ])
-              const pathToNode = parent?.userData?.pathToNode
-              const pathToNodeString = JSON.stringify(pathToNode)
-              if (!parent || !pathToNode) return segmentHoverMap
-              if (segmentHoverMap[pathToNodeString] !== undefined)
-                clearTimeout(segmentHoverMap[JSON.stringify(pathToNode)])
-              return {
-                ...segmentHoverMap,
-                [pathToNodeString]: 0,
-              }
-            } else if (
-              event.data.type === 'idle' &&
-              mouseState.type === 'isHovering'
-            ) {
-              const mouseOnParent = getParentGroup(mouseState.on, [
-                STRAIGHT_SEGMENT,
-                TANGENTIAL_ARC_TO_SEGMENT,
-              ])
-              if (!mouseOnParent || !mouseOnParent?.userData?.pathToNode)
-                return segmentHoverMap
-              const pathToNodeString = JSON.stringify(
-                mouseOnParent?.userData?.pathToNode
-              )
-              const timeoutId = setTimeout(() => {
-                sceneInfra.modelingSend({
-                  type: 'Set mouse state',
-                  data: {
-                    type: 'timeoutEnd',
-                    pathToNodeString,
-                  },
-                })
-              }, 800) as unknown as number
-              return {
-                ...segmentHoverMap,
-                [pathToNodeString]: timeoutId,
-              }
-            } else if (event.data.type === 'timeoutEnd') {
-              const copy = { ...segmentHoverMap }
-              delete copy[event.data.pathToNodeString]
-              return copy
-            }
-            return {}
-          },
         }),
-        'Set Segment Overlays': assign({
+        'Set selection': assign(({ selectionRanges }, event) => {
-          segmentOverlays: ({ segmentOverlays }, { data }) => {
+          if (event.type !== 'Set selection') return {} // this was needed for ts after adding 'Set selection' action to on done modal events
-            if (data.type === 'set-many') return data.overlays
+          const setSelections = event.data
-            if (data.type === 'set-one')
-              return {
-                ...segmentOverlays,
-                [data.pathToNodeString]: data.seg,
-              }
-            if (data.type === 'delete-one') {
-              const copy = { ...segmentOverlays }
-              delete copy[data.pathToNodeString]
-              return copy
-            }
-            // data.type === 'clear'
-            return {}
-          },
-        }),
-        'Set sketchDetails': assign(({ sketchDetails }, event) =>
-          sketchDetails
-            ? {
-                sketchDetails: {
-                  ...sketchDetails,
-                  sketchPathToNode: event.data,
-                },
-              }
-            : {}
-        ),
-        'Set selection': assign(({ selectionRanges, sketchDetails }, event) => {
-          const setSelections = event.data as SetSelections // this was needed for ts after adding 'Set selection' action to on done modal events
           if (!editorManager.editorView) return {}
           const dispatchSelection = (selection?: EditorSelection) => {
             if (!selection) return // TODO less of hack for the below please
@@ -309,29 +217,11 @@ export const ModelingMachineProvider = ({
               selectionRanges: selections,
             }
           }
-          if (setSelections.selectionType === 'completeSelection') {
-            editorManager.selectRange(setSelections.selection)
-            if (!sketchDetails)
-              return {
-                selectionRanges: setSelections.selection,
-              }
-            return {
-              selectionRanges: setSelections.selection,
-              sketchDetails: {
-                ...sketchDetails,
-                sketchPathToNode:
-                  setSelections.updatedPathToNode ||
-                  sketchDetails?.sketchPathToNode ||
-                  [],
-              },
-            }
-          }
 
           return {}
         }),
-        'Engine export': async (_, event) => {
+        'Engine export': (_, event) => {
           if (event.type !== 'Export' || TEST) return
-          console.log('exporting', event.data)
           const format = {
             ...event.data,
           } as Partial<Models['OutputFormat_type']>
@@ -375,16 +265,9 @@ export const ModelingMachineProvider = ({
             format.selection = { type: 'default_scene' }
           }
 
-          toast.promise(
+          exportFromEngine({
-            exportFromEngine({
+            format: format as Models['OutputFormat_type'],
-              format: format as Models['OutputFormat_type'],
+          }).catch((e) => toast.error('Error while exporting', e)) // TODO I think we need to throw the error from engineCommandManager
-            }),
-            {
-              loading: 'Exporting...',
-              success: 'Exported successfully',
-              error: 'Error while exporting',
-            }
-          )
         },
       },
       guards: {
@@ -417,23 +300,8 @@ export const ModelingMachineProvider = ({
             selectionRanges
           )
         },
-        'Has exportable geometry': () => {
+        'Has exportable geometry': () =>
-          if (
+          kclManager.kclErrors.length === 0 && kclManager.ast.body.length > 0,
-            kclManager.kclErrors.length === 0 &&
-            kclManager.ast.body.length > 0
-          )
-            return true
-          else {
-            let errorMessage = 'Unable to Export '
-            if (kclManager.kclErrors.length > 0)
-              errorMessage += 'due to KCL Errors'
-            else if (kclManager.ast.body.length === 0)
-              errorMessage += 'due to Empty Scene'
-            console.error(errorMessage)
-            toast.error(errorMessage)
-            return false
-          }
-        },
       },
       services: {
         'AST-undo-startSketchOn': async ({ sketchDetails }) => {
@@ -508,26 +376,13 @@ export const ModelingMachineProvider = ({
         },
         'Get horizontal info': async ({
           selectionRanges,
-          sketchDetails,
         }): Promise<SetSelections> => {
           const { modifiedAst, pathToNodeMap } =
             await applyConstraintHorzVertDistance({
               constraint: 'setHorzDistance',
               selectionRanges,
             })
-          const _modifiedAst = parse(recast(modifiedAst))
+          await kclManager.updateAst(modifiedAst, true)
-          if (!sketchDetails) throw new Error('No sketch details')
-          const updatedPathToNode = updatePathToNodeFromMap(
-            sketchDetails.sketchPathToNode,
-            pathToNodeMap
-          )
-          await sceneEntitiesManager.updateAstAndRejigSketch(
-            updatedPathToNode,
-            _modifiedAst,
-            sketchDetails.zAxis,
-            sketchDetails.yAxis,
-            sketchDetails.origin
-          )
           return {
             selectionType: 'completeSelection',
             selection: pathMapToSelections(
@@ -535,31 +390,17 @@ export const ModelingMachineProvider = ({
               selectionRanges,
               pathToNodeMap
             ),
-            updatedPathToNode,
           }
         },
         'Get vertical info': async ({
           selectionRanges,
-          sketchDetails,
         }): Promise<SetSelections> => {
           const { modifiedAst, pathToNodeMap } =
             await applyConstraintHorzVertDistance({
               constraint: 'setVertDistance',
               selectionRanges,
             })
-          const _modifiedAst = parse(recast(modifiedAst))
+          await kclManager.updateAst(modifiedAst, true)
-          if (!sketchDetails) throw new Error('No sketch details')
-          const updatedPathToNode = updatePathToNodeFromMap(
-            sketchDetails.sketchPathToNode,
-            pathToNodeMap
-          )
-          await sceneEntitiesManager.updateAstAndRejigSketch(
-            updatedPathToNode,
-            _modifiedAst,
-            sketchDetails.zAxis,
-            sketchDetails.yAxis,
-            sketchDetails.origin
-          )
           return {
             selectionType: 'completeSelection',
             selection: pathMapToSelections(
@@ -567,12 +408,10 @@ export const ModelingMachineProvider = ({
               selectionRanges,
               pathToNodeMap
             ),
-            updatedPathToNode,
           }
         },
         'Get angle info': async ({
           selectionRanges,
-          sketchDetails,
         }): Promise<SetSelections> => {
           const { modifiedAst, pathToNodeMap } = await (angleBetweenInfo({
             selectionRanges,
@@ -584,48 +423,22 @@ export const ModelingMachineProvider = ({
                 selectionRanges,
                 angleOrLength: 'setAngle',
               }))
-          const _modifiedAst = parse(recast(modifiedAst))
+          await kclManager.updateAst(modifiedAst, true)
-          if (!sketchDetails) throw new Error('No sketch details')
+          return {
-          const updatedPathToNode = updatePathToNodeFromMap(
+            selectionType: 'completeSelection',
-            sketchDetails.sketchPathToNode,
+            selection: pathMapToSelections(
-            pathToNodeMap
+              kclManager.ast,
-          )
+              selectionRanges,
-          await sceneEntitiesManager.updateAstAndRejigSketch(
+              pathToNodeMap
-            updatedPathToNode,
+            ),
-            _modifiedAst,
+          }
-            sketchDetails.zAxis,
+        },
-            sketchDetails.yAxis,
+        'Get length info': async ({
-            sketchDetails.origin
+          selectionRanges,
-          )
+        }): Promise<SetSelections> => {
-          return {
+          const { modifiedAst, pathToNodeMap } =
-            selectionType: 'completeSelection',
+            await applyConstraintAngleLength({ selectionRanges })
-            selection: pathMapToSelections(
+          await kclManager.updateAst(modifiedAst, true)
-              _modifiedAst,
-              selectionRanges,
-              pathToNodeMap
-            ),
-            updatedPathToNode,
-          }
-        },
-        'Get length info': async ({
-          selectionRanges,
-          sketchDetails,
-        }): Promise<SetSelections> => {
-          const { modifiedAst, pathToNodeMap } =
-            await applyConstraintAngleLength({ selectionRanges })
-          const _modifiedAst = parse(recast(modifiedAst))
-          if (!sketchDetails) throw new Error('No sketch details')
-          const updatedPathToNode = updatePathToNodeFromMap(
-            sketchDetails.sketchPathToNode,
-            pathToNodeMap
-          )
-          await sceneEntitiesManager.updateAstAndRejigSketch(
-            updatedPathToNode,
-            _modifiedAst,
-            sketchDetails.zAxis,
-            sketchDetails.yAxis,
-            sketchDetails.origin
-          )
           return {
             selectionType: 'completeSelection',
             selection: pathMapToSelections(
@@ -633,31 +446,17 @@ export const ModelingMachineProvider = ({
               selectionRanges,
               pathToNodeMap
             ),
-            updatedPathToNode,
           }
         },
         'Get perpendicular distance info': async ({
           selectionRanges,
-          sketchDetails,
         }): Promise<SetSelections> => {
           const { modifiedAst, pathToNodeMap } = await applyConstraintIntersect(
             {
               selectionRanges,
             }
           )
-          const _modifiedAst = parse(recast(modifiedAst))
+          await kclManager.updateAst(modifiedAst, true)
-          if (!sketchDetails) throw new Error('No sketch details')
-          const updatedPathToNode = updatePathToNodeFromMap(
-            sketchDetails.sketchPathToNode,
-            pathToNodeMap
-          )
-          await sceneEntitiesManager.updateAstAndRejigSketch(
-            updatedPathToNode,
-            _modifiedAst,
-            sketchDetails.zAxis,
-            sketchDetails.yAxis,
-            sketchDetails.origin
-          )
           return {
             selectionType: 'completeSelection',
             selection: pathMapToSelections(
@@ -665,31 +464,17 @@ export const ModelingMachineProvider = ({
               selectionRanges,
               pathToNodeMap
             ),
-            updatedPathToNode,
           }
         },
         'Get ABS X info': async ({
           selectionRanges,
-          sketchDetails,
         }): Promise<SetSelections> => {
           const { modifiedAst, pathToNodeMap } =
             await applyConstraintAbsDistance({
               constraint: 'xAbs',
               selectionRanges,
             })
-          const _modifiedAst = parse(recast(modifiedAst))
+          await kclManager.updateAst(modifiedAst, true)
-          if (!sketchDetails) throw new Error('No sketch details')
-          const updatedPathToNode = updatePathToNodeFromMap(
-            sketchDetails.sketchPathToNode,
-            pathToNodeMap
-          )
-          await sceneEntitiesManager.updateAstAndRejigSketch(
-            updatedPathToNode,
-            _modifiedAst,
-            sketchDetails.zAxis,
-            sketchDetails.yAxis,
-            sketchDetails.origin
-          )
           return {
             selectionType: 'completeSelection',
             selection: pathMapToSelections(
@@ -697,31 +482,17 @@ export const ModelingMachineProvider = ({
               selectionRanges,
               pathToNodeMap
             ),
-            updatedPathToNode,
           }
         },
         'Get ABS Y info': async ({
           selectionRanges,
-          sketchDetails,
         }): Promise<SetSelections> => {
           const { modifiedAst, pathToNodeMap } =
             await applyConstraintAbsDistance({
               constraint: 'yAbs',
               selectionRanges,
             })
-          const _modifiedAst = parse(recast(modifiedAst))
+          await kclManager.updateAst(modifiedAst, true)
-          if (!sketchDetails) throw new Error('No sketch details')
-          const updatedPathToNode = updatePathToNodeFromMap(
-            sketchDetails.sketchPathToNode,
-            pathToNodeMap
-          )
-          await sceneEntitiesManager.updateAstAndRejigSketch(
-            updatedPathToNode,
-            _modifiedAst,
-            sketchDetails.zAxis,
-            sketchDetails.yAxis,
-            sketchDetails.origin
-          )
           return {
             selectionType: 'completeSelection',
             selection: pathMapToSelections(
@@ -729,30 +500,8 @@ export const ModelingMachineProvider = ({
               selectionRanges,
               pathToNodeMap
             ),
-            updatedPathToNode,
           }
         },
-        'Get convert to variable info': async ({ sketchDetails }, { data }) => {
-          if (!sketchDetails) return []
-          const { variableName } = await getVarNameModal({
-            valueName: data.variableName || 'var',
-          })
-          const { modifiedAst: _modifiedAst, pathToReplacedNode } =
-            moveValueIntoNewVariablePath(
-              parse(recast(kclManager.ast)),
-              kclManager.programMemory,
-              data.pathToNode,
-              variableName
-            )
-          await sceneEntitiesManager.updateAstAndRejigSketch(
-            pathToReplacedNode || [],
-            parse(recast(_modifiedAst)),
-            sketchDetails.zAxis,
-            sketchDetails.yAxis,
-            sketchDetails.origin
-          )
-          return pathToReplacedNode || sketchDetails.sketchPathToNode
-        },
       },
       devTools: true,
     }
@@ -762,12 +511,6 @@ export const ModelingMachineProvider = ({
     kclManager.registerExecuteCallback(() => {
       modelingSend({ type: 'Re-execute' })
     })
-
-    // Before this component unmounts, call the 'Cancel'
-    // event to clean up any state in the modeling machine.
-    return () => {
-      modelingSend({ type: 'Cancel' })
-    }
   }, [modelingSend])
 
   // Give the state back to the editorManager.
@@ -783,19 +526,6 @@ export const ModelingMachineProvider = ({
     editorManager.selectionRanges = modelingState.context.selectionRanges
   }, [modelingState.context.selectionRanges])
 
-  useEffect(() => {
-    const offlineCallback = () => {
-      // If we are in sketch mode we need to exit it.
-      // TODO: how do i check if we are in a sketch mode, I only want to call
-      // this then.
-      modelingSend({ type: 'Cancel' })
-    }
-    window.addEventListener('offline', offlineCallback)
-    return () => {
-      window.removeEventListener('offline', offlineCallback)
-    }
-  }, [modelingSend])
-
   useStateMachineCommands({
     machineId: 'modeling',
     state: modelingState,
@@ -803,10 +533,6 @@ export const ModelingMachineProvider = ({
     actor: modelingActor,
     commandBarConfig: modelingMachineConfig,
     allCommandsRequireNetwork: true,
-    // TODO for when sketch tools are in the toolbar: This was added when we used one "Cancel" event,
-    // but we need to support "SketchCancel" and basically
-    // make this function take the actor or state so it
-    // can call the correct event.
     onCancel: () => modelingSend({ type: 'Cancel' }),
   })
 

src/components/ModelingSidebar/ModelingPanes/KclEditorMenu.tsx

@@ -48,7 +48,7 @@ export const KclEditorMenu = ({ children }: PropsWithChildren) => {
           {convertToVarEnabled && (
             <Menu.Item>
               <button
-                onClick={() => handleConvertToVarClick()}
+                onClick={handleConvertToVarClick}
                 className={styles.button}
               >
                 <span>Convert to Variable</span>

src/components/ModelingSidebar/ModelingPanes/KclEditorPane.tsx

@@ -66,7 +66,7 @@ export const KclEditorPane = () => {
 
   useEffect(() => {
     if (typeof window === 'undefined') return
-    const onlineCallback = () => kclManager.executeCode(true, true)
+    const onlineCallback = () => kclManager.executeCode(true)
     window.addEventListener('online', onlineCallback)
     return () => window.removeEventListener('online', onlineCallback)
   }, [])

src/components/ModelingSidebar/ModelingPanes/MemoryPane.tsx

@@ -6,7 +6,6 @@ import { useResolvedTheme } from 'hooks/useResolvedTheme'
 import { ActionButton } from 'components/ActionButton'
 import toast from 'react-hot-toast'
 import Tooltip from 'components/Tooltip'
-import { useModelingContext } from 'hooks/useModelingContext'
 
 export const MemoryPaneMenu = () => {
   const { programMemory } = useKclContext()
@@ -45,7 +44,6 @@ export const MemoryPaneMenu = () => {
 export const MemoryPane = () => {
   const theme = useResolvedTheme()
   const { programMemory } = useKclContext()
-  const { state } = useModelingContext()
   const ProcessedMemory = useMemo(
     () => processMemory(programMemory),
     [programMemory]
@@ -69,12 +67,6 @@ export const MemoryPane = () => {
           />
         </div>
       </div>
-      {state.matches('Sketch') && (
-        <div
-          className="absolute inset-0 dark:bg-chalkboard-90/80 bg-chalkboard-10/80 cursor-not-allowed"
-          title="Variables won't update in sketch mode"
-        ></div>
-      )}
     </div>
   )
 }

src/components/ModelingSidebar/ModelingSidebar.tsx

@@ -210,7 +210,6 @@ function ModelingPaneButton({
       key={paneConfig.id}
       className="pointer-events-auto flex items-center justify-center border-transparent dark:border-transparent p-0 m-0 rounded-sm !outline-none"
       onClick={togglePane}
-      data-testid={paneConfig.title}
     >
       <ActionIcon
         icon={paneConfig.icon}

src/components/NetworkHealthIndicator.tsx

@@ -231,10 +231,7 @@ export const NetworkHealthIndicator = () => {
           Network Health ({NETWORK_HEALTH_TEXT[overallState]})
         </Tooltip>
       </Popover.Button>
-      <Popover.Panel
+      <Popover.Panel className="absolute right-0 left-auto bottom-full mb-1 w-64 flex flex-col gap-1 align-stretch bg-chalkboard-10 dark:bg-chalkboard-90 rounded shadow-lg border border-solid border-chalkboard-20/50 dark:border-chalkboard-80/50 text-sm">
-        className="absolute right-0 left-auto bottom-full mb-1 w-64 flex flex-col gap-1 align-stretch bg-chalkboard-10 dark:bg-chalkboard-90 rounded shadow-lg border border-solid border-chalkboard-20/50 dark:border-chalkboard-80/50 text-sm"
-        data-testid="network-popover"
-      >
         <div
           className={`flex items-center justify-between p-2 rounded-t-sm ${overallConnectionStateColor[overallState].bg} ${overallConnectionStateColor[overallState].icon}`}
         >

src/components/ProjectCard.tsx

@@ -0,0 +1,235 @@
+import { FormEvent, useEffect, useRef, useState } from 'react'
+import { paths } from 'lib/paths'
+import { Link } from 'react-router-dom'
+import { ActionButton } from './ActionButton'
+import {
+  faCheck,
+  faPenAlt,
+  faTrashAlt,
+  faX,
+} from '@fortawesome/free-solid-svg-icons'
+import { FILE_EXT } from 'lib/constants'
+import { Dialog } from '@headlessui/react'
+import { useHotkeys } from 'react-hotkeys-hook'
+import Tooltip from './Tooltip'
+import { Project } from 'wasm-lib/kcl/bindings/Project'
+
+function ProjectCard({
+  project,
+  handleRenameProject,
+  handleDeleteProject,
+  ...props
+}: {
+  project: Project
+  handleRenameProject: (
+    e: FormEvent<HTMLFormElement>,
+    f: Project
+  ) => Promise<void>
+  handleDeleteProject: (f: Project) => Promise<void>
+}) {
+  useHotkeys('esc', () => setIsEditing(false))
+  const [isEditing, setIsEditing] = useState(false)
+  const [isConfirmingDelete, setIsConfirmingDelete] = useState(false)
+  const [numberOfFiles, setNumberOfFiles] = useState(1)
+  const [numberOfFolders, setNumberOfFolders] = useState(0)
+
+  let inputRef = useRef<HTMLInputElement>(null)
+
+  function handleSave(e: FormEvent<HTMLFormElement>) {
+    e.preventDefault()
+    void handleRenameProject(e, project).then(() => setIsEditing(false))
+  }
+
+  function getDisplayedTime(dateStr: string) {
+    const date = new Date(dateStr)
+    const startOfToday = new Date()
+    startOfToday.setHours(0, 0, 0, 0)
+    return date.getTime() < startOfToday.getTime()
+      ? date.toLocaleDateString()
+      : date.toLocaleTimeString()
+  }
+
+  useEffect(() => {
+    async function getNumberOfFiles() {
+      setNumberOfFiles(project.kcl_file_count)
+      setNumberOfFolders(project.directory_count)
+    }
+    void getNumberOfFiles()
+  }, [project.kcl_file_count, project.directory_count])
+
+  useEffect(() => {
+    if (inputRef.current) {
+      inputRef.current.focus()
+      inputRef.current.select()
+    }
+  }, [inputRef.current])
+
+  return (
+    <li
+      {...props}
+      className="group relative min-h-[5em] p-1 rounded-sm border border-chalkboard-20 dark:border-chalkboard-80 hover:!border-primary"
+    >
+      {isEditing ? (
+        <form onSubmit={handleSave} className="flex items-center gap-2">
+          <input
+            className="min-w-0 p-1 dark:bg-chalkboard-80 dark:border-chalkboard-40 focus:outline-none"
+            type="text"
+            id="newProjectName"
+            name="newProjectName"
+            autoCorrect="off"
+            autoCapitalize="off"
+            defaultValue={project.name}
+            ref={inputRef}
+          />
+          <div className="flex items-center gap-1">
+            <ActionButton
+              Element="button"
+              type="submit"
+              iconStart={{
+                icon: faCheck,
+                size: 'sm',
+                className: 'p-1',
+                bgClassName: '!bg-transparent',
+              }}
+              className="!p-0"
+            >
+              <Tooltip position="left" delay={1000}>
+                Rename project
+              </Tooltip>
+            </ActionButton>
+            <ActionButton
+              Element="button"
+              iconStart={{
+                icon: faX,
+                size: 'sm',
+                iconClassName: 'dark:!text-chalkboard-20',
+                bgClassName: '!bg-transparent',
+                className: 'p-1',
+              }}
+              className="!p-0"
+              onClick={() => setIsEditing(false)}
+            >
+              <Tooltip position="left" delay={1000}>
+                Cancel
+              </Tooltip>
+            </ActionButton>
+          </div>
+        </form>
+      ) : (
+        <>
+          <Link
+            className="relative z-0 flex flex-col h-full gap-2 p-1 !no-underline !text-chalkboard-110 dark:!text-chalkboard-10"
+            to={`${paths.FILE}/${encodeURIComponent(project.default_file)}`}
+            data-testid="project-link"
+          >
+            <div className="flex-1">{project.name?.replace(FILE_EXT, '')}</div>
+            <span className="text-xs text-chalkboard-60">
+              {numberOfFiles} file{numberOfFiles === 1 ? '' : 's'}{' '}
+              {numberOfFolders > 0 &&
+                `/ ${numberOfFolders} folder${
+                  numberOfFolders === 1 ? '' : 's'
+                }`}
+            </span>
+            <span className="text-xs text-chalkboard-60">
+              Edited{' '}
+              {project.metadata && project.metadata?.modified
+                ? getDisplayedTime(project.metadata.modified)
+                : 'never'}
+            </span>
+          </Link>
+          <div className="absolute z-10 flex items-center gap-1 opacity-0 bottom-2 right-2 group-hover:opacity-100 group-focus-within:opacity-100">
+            <ActionButton
+              Element="button"
+              iconStart={{
+                icon: faPenAlt,
+                className: 'p-1',
+                iconClassName: 'dark:!text-chalkboard-20',
+                bgClassName: '!bg-transparent',
+                size: 'xs',
+              }}
+              onClick={(e) => {
+                e.stopPropagation()
+                e.nativeEvent.stopPropagation()
+                setIsEditing(true)
+              }}
+              className="!p-0"
+            >
+              <Tooltip position="left" delay={1000}>
+                Rename project
+              </Tooltip>
+            </ActionButton>
+            <ActionButton
+              Element="button"
+              iconStart={{
+                icon: faTrashAlt,
+                className: 'p-1',
+                size: 'xs',
+                bgClassName: '!bg-transparent',
+                iconClassName: '!text-destroy-70',
+              }}
+              className="!p-0 hover:border-destroy-40 dark:hover:border-destroy-40"
+              onClick={(e) => {
+                e.stopPropagation()
+                e.nativeEvent.stopPropagation()
+                setIsConfirmingDelete(true)
+              }}
+            >
+              <Tooltip position="left" delay={1000}>
+                Delete project
+              </Tooltip>
+            </ActionButton>
+          </div>
+          <Dialog
+            open={isConfirmingDelete}
+            onClose={() => setIsConfirmingDelete(false)}
+            className="relative z-50"
+          >
+            <div className="fixed inset-0 grid bg-chalkboard-110/80 place-content-center">
+              <Dialog.Panel className="max-w-2xl p-4 border rounded bg-chalkboard-10 dark:bg-chalkboard-100 border-destroy-80">
+                <Dialog.Title as="h2" className="mb-4 text-2xl font-bold">
+                  Delete File
+                </Dialog.Title>
+                <Dialog.Description>
+                  This will permanently delete "{project.name || 'this file'}".
+                </Dialog.Description>
+
+                <p className="my-4">
+                  Are you sure you want to delete "{project.name || 'this file'}
+                  "? This action cannot be undone.
+                </p>
+
+                <div className="flex justify-between">
+                  <ActionButton
+                    Element="button"
+                    onClick={async () => {
+                      await handleDeleteProject(project)
+                      setIsConfirmingDelete(false)
+                    }}
+                    iconStart={{
+                      icon: faTrashAlt,
+                      bgClassName: 'bg-destroy-80',
+                      className: 'p-1',
+                      size: 'sm',
+                      iconClassName: '!text-destroy-70 dark:!text-destroy-40',
+                    }}
+                    className="hover:border-destroy-40 dark:hover:border-destroy-40"
+                  >
+                    Delete
+                  </ActionButton>
+                  <ActionButton
+                    Element="button"
+                    onClick={() => setIsConfirmingDelete(false)}
+                  >
+                    Cancel
+                  </ActionButton>
+                </div>
+              </Dialog.Panel>
+            </div>
+          </Dialog>
+        </>
+      )}
+    </li>
+  )
+}
+
+export default ProjectCard

src/components/ProjectCard/DeleteProjectDialog.tsx

@@ -1,46 +0,0 @@
-import { Dialog } from '@headlessui/react'
-import { ActionButton } from 'components/ActionButton'
-
-interface DeleteConfirmationDialogProps extends React.PropsWithChildren<{}> {
-  title: string
-  onConfirm: () => void
-  onDismiss: () => void
-}
-
-export function DeleteConfirmationDialog({
-  title,
-  onConfirm,
-  onDismiss,
-  children,
-}: DeleteConfirmationDialogProps) {
-  return (
-    <Dialog open={true} onClose={onDismiss} className="relative z-50">
-      <div className="fixed inset-0 grid bg-chalkboard-110/80 place-content-center">
-        <Dialog.Panel className="max-w-2xl p-4 border rounded bg-chalkboard-10 dark:bg-chalkboard-100 border-destroy-80">
-          <Dialog.Title as="h2" className="mb-4 text-2xl font-bold">
-            {title}
-          </Dialog.Title>
-          <Dialog.Description>{children}</Dialog.Description>
-
-          <div className="flex justify-between">
-            <ActionButton
-              Element="button"
-              onClick={onConfirm}
-              iconStart={{
-                icon: 'trash',
-                bgClassName: 'bg-destroy-10 dark:bg-destroy-80',
-                iconClassName: '!text-destroy-80 dark:!text-destroy-20',
-              }}
-              className="hover:border-destroy-40 dark:hover:border-destroy-40 hover:bg-destroy-10/20 dark:hover:bg-destroy-80/20"
-            >
-              Delete
-            </ActionButton>
-            <ActionButton Element="button" onClick={onDismiss}>
-              Cancel
-            </ActionButton>
-          </div>
-        </Dialog.Panel>
-      </div>
-    </Dialog>
-  )
-}

src/components/ProjectCard/ProjectCard.tsx

@@ -1,185 +0,0 @@
-import { FormEvent, useEffect, useRef, useState } from 'react'
-import { paths } from 'lib/paths'
-import { Link } from 'react-router-dom'
-import { ActionButton } from '../ActionButton'
-import { FILE_EXT } from 'lib/constants'
-import { useHotkeys } from 'react-hotkeys-hook'
-import Tooltip from '../Tooltip'
-import { DeleteConfirmationDialog } from './DeleteProjectDialog'
-import { ProjectCardRenameForm } from './ProjectCardRenameForm'
-import { Project } from 'wasm-lib/kcl/bindings/Project'
-
-function ProjectCard({
-  project,
-  handleRenameProject,
-  handleDeleteProject,
-  ...props
-}: {
-  project: Project
-  handleRenameProject: (
-    e: FormEvent<HTMLFormElement>,
-    f: Project
-  ) => Promise<void>
-  handleDeleteProject: (f: Project) => Promise<void>
-}) {
-  useHotkeys('esc', () => setIsEditing(false))
-  const [isEditing, setIsEditing] = useState(false)
-  const [isConfirmingDelete, setIsConfirmingDelete] = useState(false)
-  const [numberOfFiles, setNumberOfFiles] = useState(1)
-  const [numberOfFolders, setNumberOfFolders] = useState(0)
-  // const [imageUrl, setImageUrl] = useState('')
-
-  let inputRef = useRef<HTMLInputElement>(null)
-
-  function handleSave(e: FormEvent<HTMLFormElement>) {
-    e.preventDefault()
-    void handleRenameProject(e, project).then(() => setIsEditing(false))
-  }
-
-  function getDisplayedTime(dateStr: string) {
-    const date = new Date(dateStr)
-    const startOfToday = new Date()
-    startOfToday.setHours(0, 0, 0, 0)
-    return date.getTime() < startOfToday.getTime()
-      ? date.toLocaleDateString()
-      : date.toLocaleTimeString()
-  }
-
-  useEffect(() => {
-    async function getNumberOfFiles() {
-      setNumberOfFiles(project.kcl_file_count)
-      setNumberOfFolders(project.directory_count)
-    }
-
-    // async function setupImageUrl() {
-    //   const projectImagePath = await join(project.path, PROJECT_IMAGE_NAME)
-    //   if (await exists(projectImagePath)) {
-    //     const imageData = await readFile(projectImagePath)
-    //     const blob = new Blob([imageData], { type: 'image/jpg' })
-    //     const imageUrl = URL.createObjectURL(blob)
-    //     setImageUrl(imageUrl)
-    //   }
-    // }
-
-    void getNumberOfFiles()
-    // void setupImageUrl()
-  }, [project.kcl_file_count, project.directory_count])
-
-  useEffect(() => {
-    if (inputRef.current && isEditing) {
-      inputRef.current.focus()
-      inputRef.current.select()
-    }
-  }, [isEditing, inputRef.current])
-
-  return (
-    <li
-      {...props}
-      className="group relative flex flex-col rounded-sm border border-primary/40 dark:border-chalkboard-80 hover:!border-primary"
-    >
-      <Link
-        data-testid="project-link"
-        to={`${paths.FILE}/${encodeURIComponent(project.default_file)}`}
-        className="flex flex-col flex-1 !no-underline !text-chalkboard-110 dark:!text-chalkboard-10 group-hover:!hue-rotate-0 min-h-[5em] divide-y divide-primary/40 dark:divide-chalkboard-80 group-hover:!divide-primary"
-      >
-        {/* <div className="h-36 relative overflow-hidden bg-gradient-to-b from-transparent to-primary/10 rounded-t-sm">
-          {imageUrl && (
-            <img
-              src={imageUrl}
-              alt=""
-              className="h-full w-full transition-transform group-hover:scale-105 object-cover"
-            />
-          )}
-        </div> */}
-        <div className="pb-2 flex flex-col flex-grow flex-auto gap-2 rounded-b-sm">
-          {isEditing ? (
-            <ProjectCardRenameForm
-              onSubmit={handleSave}
-              className="flex items-center gap-2 p-2"
-              onClick={(e) => e.stopPropagation()}
-              project={project}
-              onDismiss={() => setIsEditing(false)}
-              ref={inputRef}
-            />
-          ) : (
-            <h3 className="font-sans relative z-0 p-2">
-              {project.name?.replace(FILE_EXT, '')}
-            </h3>
-          )}
-          <span className="px-2 text-chalkboard-60 text-xs">
-            {numberOfFiles} file{numberOfFiles === 1 ? '' : 's'}{' '}
-            {numberOfFolders > 0 &&
-              `/ ${numberOfFolders} folder${numberOfFolders === 1 ? '' : 's'}`}
-          </span>
-          <span className="px-2 text-chalkboard-60 text-xs">
-            Edited{' '}
-            {project.metadata && project.metadata?.modified
-              ? getDisplayedTime(project.metadata.modified)
-              : 'never'}
-          </span>
-        </div>
-      </Link>
-      {!isEditing && (
-        <div className="absolute z-10 flex items-center gap-1 opacity-0 bottom-2 right-2 group-hover:opacity-100 group-focus-within:opacity-100">
-          <ActionButton
-            Element="button"
-            iconStart={{
-              icon: 'sketch',
-              iconClassName: 'dark:!text-chalkboard-20',
-              bgClassName: '!bg-transparent',
-            }}
-            onClick={(e) => {
-              e.stopPropagation()
-              e.nativeEvent.stopPropagation()
-              setIsEditing(true)
-            }}
-            className="!p-0"
-          >
-            <Tooltip position="top-right" delay={1000}>
-              Rename project
-            </Tooltip>
-          </ActionButton>
-          <ActionButton
-            Element="button"
-            iconStart={{
-              icon: 'trash',
-              iconClassName: 'dark:!text-chalkboard-30',
-              bgClassName: '!bg-transparent',
-            }}
-            className="!p-0"
-            onClick={(e) => {
-              e.stopPropagation()
-              e.nativeEvent.stopPropagation()
-              setIsConfirmingDelete(true)
-            }}
-          >
-            <Tooltip position="top-right" delay={1000}>
-              Delete project
-            </Tooltip>
-          </ActionButton>
-        </div>
-      )}
-      {isConfirmingDelete && (
-        <DeleteConfirmationDialog
-          title="Delete Project"
-          onConfirm={async () => {
-            await handleDeleteProject(project)
-            setIsConfirmingDelete(false)
-          }}
-          onDismiss={() => setIsConfirmingDelete(false)}
-        >
-          <p className="my-4">
-            This will permanently delete "{project.name || 'this file'}
-            ".
-          </p>
-          <p className="my-4">
-            Are you sure you want to delete "{project.name || 'this file'}
-            "? This action cannot be undone.
-          </p>
-        </DeleteConfirmationDialog>
-      )}
-    </li>
-  )
-}
-
-export default ProjectCard

src/components/ProjectCard/ProjectCardRenameForm.tsx

@@ -1,67 +0,0 @@
-import { ActionButton } from 'components/ActionButton'
-import Tooltip from 'components/Tooltip'
-import { HTMLProps, forwardRef } from 'react'
-import { Project } from 'wasm-lib/kcl/bindings/Project'
-
-interface ProjectCardRenameFormProps extends HTMLProps<HTMLFormElement> {
-  project: Project
-  onDismiss: () => void
-}
-
-export const ProjectCardRenameForm = forwardRef(
-  (
-    { project, onDismiss, ...props }: ProjectCardRenameFormProps,
-    ref: React.Ref<HTMLInputElement>
-  ) => {
-    return (
-      <form {...props}>
-        <input
-          className="min-w-0 dark:bg-chalkboard-80 dark:border-chalkboard-40 focus:outline-none"
-          type="text"
-          id="newProjectName"
-          onClickCapture={(e) => e.preventDefault()}
-          name="newProjectName"
-          required
-          autoCorrect="off"
-          autoCapitalize="off"
-          defaultValue={project.name}
-          ref={ref}
-          onKeyDown={(e) => {
-            if (e.key === 'Escape') {
-              onDismiss()
-            }
-          }}
-        />
-        <div className="flex items-center gap-1">
-          <ActionButton
-            Element="button"
-            type="submit"
-            iconStart={{
-              icon: 'checkmark',
-              bgClassName: '!bg-transparent',
-            }}
-            className="!p-0"
-          >
-            <Tooltip position="left" delay={1000}>
-              Rename project
-            </Tooltip>
-          </ActionButton>
-          <ActionButton
-            Element="button"
-            iconStart={{
-              icon: 'close',
-              iconClassName: 'dark:!text-chalkboard-20',
-              bgClassName: '!bg-transparent',
-            }}
-            className="!p-0"
-            onClick={onDismiss}
-          >
-            <Tooltip position="left" delay={1000}>
-              Cancel
-            </Tooltip>
-          </ActionButton>
-        </div>
-      </form>
-    )
-  }
-)