Compare commits

...

1 Commits

Author SHA1 Message Date
45ac070ed9 planes bug
Signed-off-by: Jess Frazelle <github@jessfraz.com>
2024-12-06 11:16:42 -08:00
3 changed files with 14 additions and 3 deletions

View File

@ -944,11 +944,14 @@ sketch002 = startSketchOn(extrude001, 'END')
) )
}) })
/* TODO: once we fix bug turn on. test('empty-scene default-planes act as expected when spaces in file', async ({
test('empty-scene default-planes act as expected when spaces in file', async ({
page, page,
browserName, browserName,
}) => { }) => {
test.skip(
browserName === 'webkit',
'Skip on Safari until `window.tearDown` is working there'
)
const u = await getUtils(page) const u = await getUtils(page)
await page.setViewportSize({ width: 1200, height: 500 }) await page.setViewportSize({ width: 1200, height: 500 })
@ -1000,6 +1003,10 @@ sketch002 = startSketchOn(extrude001, 'END')
page, page,
browserName, browserName,
}) => { }) => {
test.skip(
browserName === 'webkit',
'Skip on Safari until `window.tearDown` is working there'
)
const u = await getUtils(page) const u = await getUtils(page)
await page.setViewportSize({ width: 1200, height: 500 }) await page.setViewportSize({ width: 1200, height: 500 })
@ -1045,7 +1052,7 @@ sketch002 = startSketchOn(extrude001, 'END')
expect( expect(
await u.getGreatestPixDiff(XYPlanePoint, unHoveredColor) await u.getGreatestPixDiff(XYPlanePoint, unHoveredColor)
).toBeLessThan(8) ).toBeLessThan(8)
})*/ })
test('empty-scene default-planes act as expected', async ({ test('empty-scene default-planes act as expected', async ({
page, page,

View File

@ -2110,6 +2110,7 @@ export class EngineCommandManager extends EventTarget {
} }
deferredArtifactPopulated = deferExecution((a?: null) => { deferredArtifactPopulated = deferExecution((a?: null) => {
console.log('populated')
this.modelingSend({ type: 'Artifact graph populated' }) this.modelingSend({ type: 'Artifact graph populated' })
}, 200) }, 200)
deferredArtifactEmptied = deferExecution((a?: null) => { deferredArtifactEmptied = deferExecution((a?: null) => {

View File

@ -984,6 +984,7 @@ export const modelingMachine = setup({
}) })
}, },
'show default planes': () => { 'show default planes': () => {
console.log('show default planes')
// eslint-disable-next-line @typescript-eslint/no-floating-promises // eslint-disable-next-line @typescript-eslint/no-floating-promises
kclManager.showPlanes() kclManager.showPlanes()
}, },
@ -1682,8 +1683,10 @@ export const modelingMachine = setup({
}, },
showPlanes: { showPlanes: {
reenter: true,
on: { on: {
'Artifact graph emptied': 'hidePlanes', 'Artifact graph emptied': 'hidePlanes',
'Artifact graph populated': 'showPlanes',
}, },
entry: [ entry: [