Merge branch 'main' into kurt-web-app-oauth

web app oauth
Add support for tag on close segment when the last sketch edge is missing (#7375 )
2025-06-06 14:28:39 +10:00 · 2025-06-06 13:35:11 +10:00 · 2025-06-06 11:30:24 +10:00 · 2025-06-05 21:29:20 -04:00 · 2025-06-05 20:28:21 -04:00 · 2025-06-06 09:16:11 +10:00
603 changed files with 89743 additions and 161680 deletions
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@ -1,6 +1,6 @@
 # Contributor Guide

-## Running a development build
+## Installing dependencies

 Install a node version manager such as [fnm](https://github.com/Schniz/fnm?tab=readme-ov-#installation).

@ -31,7 +31,9 @@ npm run install:rust:windows
 npm run install:wasm-pack:cargo
 ```

-Then to build the WASM layer, run:
+## Building the app
+
+To build the WASM layer, run:

 ```
 # macOS/Linux
@ -74,7 +76,7 @@ enable third-party cookies. You can enable third-party cookies by clicking on
 the eye with a slash through it in the URL bar, and clicking on "Enable
 Third-Party Cookies".

-## Desktop
+### Developing with Electron

 To spin up the desktop app, `npm install` and `npm run build:wasm` need to have been done before hand then:

@ -88,114 +90,7 @@ Devtools can be opened with the usual Command-Option-I (macOS) or Ctrl-Shift-I (

 To package the app for your platform with electron-builder, run `npm run tronb:package:dev` (or `npm run tronb:package:prod` to point to the .env.production variables).

-## Checking out commits / Bisecting
-
-Which commands from setup are one off vs. need to be run every time?
-
-The following will need to be run when checking out a new commit and guarantees the build is not stale:
-
-```bash
-npm install
-npm run build:wasm
-npm start
-```
-
-## Before submitting a PR
-
-Before you submit a contribution PR to this repo, please ensure that:
-
- There is a corresponding issue for the changes you want to make, so that discussion of approach can be had before work begins.
- You have separated out refactoring commits from feature commits as much as possible
- You have run all of the following commands locally:
-  - `npm run fmt`
-  - `npm run tsc`
-  - `npm run test`
-  - Here they are all together: `npm run fmt && npm run tsc && npm run test`
-
-## Release a new version
-
-#### 1. Create a 'Cut release $VERSION' issue
-
-It will be used to document changelog discussions and release testing.
-
-https://github.com/KittyCAD/modeling-app/issues/new
-
-#### 2. Push a new tag
-
-Decide on a `v`-prefixed semver `VERSION` (e.g. `v1.2.3`) with the team and tag the repo on the latest main:
-
-```
-git tag $VERSION --message=""
-git push origin $VERSION
-```
-
-This will trigger the `build-apps` workflow to set the version, build & sign the apps, and generate release files.
-
-The workflow should be listed right away [in this list](https://github.com/KittyCAD/modeling-app/actions/workflows/build-apps.yml?query=event%3Apush).
-
-#### 3. Manually test artifacts
-
-##### Release builds
-
-The release builds can be found under the `out-{arch}-{platform}` zip files, at the very bottom of the `build-apps` summary page for the workflow (triggered by the tag in step 2).
-
-Manually test against [this list](https://github.com/KittyCAD/modeling-app/issues/3588) across Windows, MacOS, Linux and posting results as comments in the issue.
-
-A prompt should show up asking for a downgrade to the last release version. Running through that at the end of testing
-and making sure the current release candidate has the ability to be updated to what electron-updater points to is critical,
-but what is actually being downloaded and installed isn't.
-If the prompt doesn't show up, start the app in command line to grab the electron-updater logs. This is likely an issue with the current build that needs addressing.
-
-```
-# Windows (PowerShell)
-& 'C:\Program Files\Zoo Design Studio\Zoo Design Studio.exe'
-
-# macOS
-/Applications/Zoo\ Modeling\ App.app/Contents/MacOS/Zoo\ Modeling\ App
-
-# Linux
-./Zoo Design Studio-{version}-{arch}-linux.AppImage
-```
-
-#### 4. Bump the KCL version
-
-Follow the instructions [here](./rust/README.md) to publish new crates.
-This ensures that the KCL accepted by the app is also accepted by the CLI.
-
-#### 5. Publish the release
-
-Head over to https://github.com/KittyCAD/modeling-app/releases/new, pick the newly created tag and type it in the **Release title** field as well.
-
-Click **Generate release notes** as a starting point to discuss the changelog in the issue. Once done, make sure **Set as the latest release** is checked, and click **Publish release**.
-
-A new `publish-apps-release` workflow will start and you should be able to find it [here](https://github.com/KittyCAD/modeling-app/actions?query=event%3Arelease). On success, the files will be uploaded to the public bucket as well as to the GitHub release, and the announcement on Discord will be sent.
-
-#### 6. Close the issue
-
-If everything is well and the release is out to the public, the issue tracking the release shall be closed.
-
-## Fuzzing the parser
-
-Make sure you install cargo fuzz:
-
-```bash
-$ cargo install cargo-fuzz
-```
-
-```bash
-$ cd rust/kcl-lib
-
-# list the fuzz targets
-$ cargo fuzz list
-
-# run the parser fuzzer
-$ cargo +nightly fuzz run parser
-```
-
-For more information on fuzzing you can check out
-[this guide](https://rust-fuzz.github.io/book/cargo-fuzz.html).
-
-## Tests
+## Running tests

 ### Playwright tests

@ -313,8 +208,103 @@ then run tests that target the KCL language:
 npm run test:rust
 ```

+### Fuzzing the parser
+
+Make sure you install cargo fuzz:
+
+```bash
+$ cargo install cargo-fuzz
+```
+
+```bash
+$ cd rust/kcl-lib
+
+# list the fuzz targets
+$ cargo fuzz list
+
+# run the parser fuzzer
+$ cargo +nightly fuzz run parser
+```
+
+For more information on fuzzing you can check out
+[this guide](https://rust-fuzz.github.io/book/cargo-fuzz.html).
+
 ### Logging

 To display logging (to the terminal or console) set `ZOO_LOG=1`. This will log some warnings and simple performance metrics. To view these in test runs, use `-- --nocapture`.

 To enable memory metrics, build with `--features dhat-heap`.
+
+## Proposing changes
+
+Before you submit a contribution PR to this repo, please ensure that:
+
+- There is a corresponding issue for the changes you want to make, so that discussion of approach can be had before work begins.
+- You have separated out refactoring commits from feature commits as much as possible
+- You have run all of the following commands locally:
+  - `npm run fmt`
+  - `npm run tsc`
+  - `npm run test`
+  - Here they are all together: `npm run fmt && npm run tsc && npm run test`
+
+## Shipping releases
+
+#### 1. Create a 'Cut release $VERSION' issue
+
+It will be used to document changelog discussions and release testing.
+
+https://github.com/KittyCAD/modeling-app/issues/new
+
+#### 2. Push a new tag
+
+Decide on a `v`-prefixed semver `VERSION` (e.g. `v1.2.3`) with the team and tag the repo on the latest main:
+
+```
+git tag $VERSION --message=""
+git push origin $VERSION
+```
+
+This will trigger the `build-apps` workflow to set the version, build & sign the apps, and generate release files.
+
+The workflow should be listed right away [in this list](https://github.com/KittyCAD/modeling-app/actions/workflows/build-apps.yml?query=event%3Apush).
+
+#### 3. Manually test artifacts
+
+##### Release builds
+
+The release builds can be found under the `out-{arch}-{platform}` zip files, at the very bottom of the `build-apps` summary page for the workflow (triggered by the tag in step 2).
+
+Manually test against [this list](https://github.com/KittyCAD/modeling-app/issues/3588) across Windows, MacOS, Linux and posting results as comments in the issue.
+
+A prompt should show up asking for a downgrade to the last release version. Running through that at the end of testing
+and making sure the current release candidate has the ability to be updated to what electron-updater points to is critical,
+but what is actually being downloaded and installed isn't.
+If the prompt doesn't show up, start the app in command line to grab the electron-updater logs. This is likely an issue with the current build that needs addressing.
+
+```
+# Windows (PowerShell)
+& 'C:\Program Files\Zoo Design Studio\Zoo Design Studio.exe'
+
+# macOS
+/Applications/Zoo\ Modeling\ App.app/Contents/MacOS/Zoo\ Modeling\ App
+
+# Linux
+./Zoo Design Studio-{version}-{arch}-linux.AppImage
+```
+
+#### 4. Bump the KCL version
+
+Follow the instructions [here](./rust/README.md) to publish new crates.
+This ensures that the KCL accepted by the app is also accepted by the CLI.
+
+#### 5. Publish the release
+
+Head over to https://github.com/KittyCAD/modeling-app/releases/new, pick the newly created tag and type it in the **Release title** field as well.
+
+Click **Generate release notes** as a starting point to discuss the changelog in the issue. Once done, make sure **Set as the latest release** is checked, and click **Publish release**.
+
+A new `publish-apps-release` workflow will start and you should be able to find it [here](https://github.com/KittyCAD/modeling-app/actions?query=event%3Arelease). On success, the files will be uploaded to the public bucket as well as to the GitHub release, and the announcement on Discord will be sent.
+
+#### 6. Close the issue
+
+If everything is well and the release is out to the public, the issue tracking the release shall be closed.
--- a/docs/kcl-std/consts/std-math-E.md
+++ b/docs/kcl-std/consts/std-math-E.md
--- a/docs/kcl-std/consts/std-math-PI.md
+++ b/docs/kcl-std/consts/std-math-PI.md
--- a/docs/kcl-std/consts/std-math-TAU.md
+++ b/docs/kcl-std/consts/std-math-TAU.md
--- a/docs/kcl-std/functions/std-appearance-hexString.md
+++ b/docs/kcl-std/functions/std-appearance-hexString.md
--- a/docs/kcl-std/functions/std-array-map.md
+++ b/docs/kcl-std/functions/std-array-map.md
--- a/docs/kcl-std/functions/std-array-pop.md
+++ b/docs/kcl-std/functions/std-array-pop.md
--- a/docs/kcl-std/functions/std-array-push.md
+++ b/docs/kcl-std/functions/std-array-push.md
--- a/docs/kcl-std/functions/std-array-reduce.md
+++ b/docs/kcl-std/functions/std-array-reduce.md
--- a/docs/kcl-std/functions/std-assert.md
+++ b/docs/kcl-std/functions/std-assert.md
@ -1,11 +1,11 @@
 ---
 title: "assert"
 subtitle: "Function in std"
-excerpt: ""
+excerpt: "Check a value meets some expected conditions at runtime. Program terminates with an error if conditions aren't met. If you provide multiple conditions, they will all be checked and all must be met."
 layout: manual
 ---

-
+Check a value meets some expected conditions at runtime. Program terminates with an error if conditions aren't met. If you provide multiple conditions, they will all be checked and all must be met.

 ```kcl
 assert(
@ -20,8 +20,7 @@ assert(
 )
 ```

-Check a value meets some expected conditions at runtime. Program terminates with an error if conditions aren't met.
-If you provide multiple conditions, they will all be checked and all must be met.
+

 ### Arguments

@ -42,8 +41,19 @@ If you provide multiple conditions, they will all be checked and all must be met
 ```kcl
 n = 10
 assert(n, isEqualTo = 10)
-assert(n, isGreaterThanOrEqual = 0, isLessThan = 100, error = "number should be between 0 and 100")
-assert(1.0000000000012, isEqualTo = 1, tolerance = 0.0001, error = "number should be almost exactly 1")
+assert(
+  n,
+  isGreaterThanOrEqual = 0,
+  isLessThan = 100,
+  error = "number should be between 0 and 100",
+)
+assert(
+  1.0000000000012,
+  isEqualTo = 1,
+  tolerance = 0.0001,
+  error = "number should be almost exactly 1",
+)
+
 ```


--- a/docs/kcl-std/functions/std-assertIs.md
+++ b/docs/kcl-std/functions/std-assertIs.md
@ -29,6 +29,7 @@ assertIs(
 ```kcl
 kclIsFun = true
 assertIs(kclIsFun)
+
 ```


--- a/docs/kcl-std/functions/std-clone.md
+++ b/docs/kcl-std/functions/std-clone.md
--- a/docs/kcl-std/functions/std-helix.md
+++ b/docs/kcl-std/functions/std-helix.md
--- a/docs/kcl-std/functions/std-math-abs.md
+++ b/docs/kcl-std/functions/std-math-abs.md
--- a/docs/kcl-std/functions/std-math-acos.md
+++ b/docs/kcl-std/functions/std-math-acos.md
--- a/docs/kcl-std/functions/std-math-asin.md
+++ b/docs/kcl-std/functions/std-math-asin.md
--- a/docs/kcl-std/functions/std-math-atan.md
+++ b/docs/kcl-std/functions/std-math-atan.md
@ -29,14 +29,12 @@ Consider using `atan2()` instead for the true inverse of tangent.
 ```kcl
 sketch001 = startSketchOn(XZ)
  |> startProfile(at = [0, 0])
-  |> angledLine(
-    angle = atan(1.25),
-    length = 20,
-  )
+  |> angledLine(angle = atan(1.25), length = 20)
  |> yLine(endAbsolute = 0)
  |> close()

 extrude001 = extrude(sketch001, length = 5)
+
 ```


--- a/docs/kcl-std/functions/std-math-atan2.md
+++ b/docs/kcl-std/functions/std-math-atan2.md
--- a/docs/kcl-std/functions/std-math-ceil.md
+++ b/docs/kcl-std/functions/std-math-ceil.md
--- a/docs/kcl-std/functions/std-math-cos.md
+++ b/docs/kcl-std/functions/std-math-cos.md
--- a/docs/kcl-std/functions/std-math-floor.md
+++ b/docs/kcl-std/functions/std-math-floor.md
--- a/docs/kcl-std/functions/std-math-legAngX.md
+++ b/docs/kcl-std/functions/std-math-legAngX.md
@ -32,6 +32,7 @@ legAngX(

 ```kcl
 legAngX(hypotenuse = 5, leg = 3)
+
 ```


--- a/docs/kcl-std/functions/std-math-legAngY.md
+++ b/docs/kcl-std/functions/std-math-legAngY.md
@ -32,6 +32,7 @@ legAngY(

 ```kcl
 legAngY(hypotenuse = 5, leg = 3)
+
 ```


--- a/docs/kcl-std/functions/std-math-legLen.md
+++ b/docs/kcl-std/functions/std-math-legLen.md
@ -32,6 +32,7 @@ legLen(

 ```kcl
 legLen(hypotenuse = 5, leg = 3)
+
 ```


--- a/docs/kcl-std/functions/std-math-ln.md
+++ b/docs/kcl-std/functions/std-math-ln.md
--- a/docs/kcl-std/functions/std-math-log.md
+++ b/docs/kcl-std/functions/std-math-log.md
--- a/docs/kcl-std/functions/std-math-log10.md
+++ b/docs/kcl-std/functions/std-math-log10.md
--- a/docs/kcl-std/functions/std-math-log2.md
+++ b/docs/kcl-std/functions/std-math-log2.md
--- a/docs/kcl-std/functions/std-math-max.md
+++ b/docs/kcl-std/functions/std-math-max.md
--- a/docs/kcl-std/functions/std-math-min.md
+++ b/docs/kcl-std/functions/std-math-min.md
--- a/docs/kcl-std/functions/std-math-polar.md
+++ b/docs/kcl-std/functions/std-math-polar.md
--- a/docs/kcl-std/functions/std-math-pow.md
+++ b/docs/kcl-std/functions/std-math-pow.md
--- a/docs/kcl-std/functions/std-math-rem.md
+++ b/docs/kcl-std/functions/std-math-rem.md
--- a/docs/kcl-std/functions/std-math-round.md
+++ b/docs/kcl-std/functions/std-math-round.md
--- a/docs/kcl-std/functions/std-math-sin.md
+++ b/docs/kcl-std/functions/std-math-sin.md
--- a/docs/kcl-std/functions/std-math-sqrt.md
+++ b/docs/kcl-std/functions/std-math-sqrt.md
--- a/docs/kcl-std/functions/std-math-tan.md
+++ b/docs/kcl-std/functions/std-math-tan.md
--- a/docs/kcl-std/functions/std-offsetPlane.md
+++ b/docs/kcl-std/functions/std-offsetPlane.md
--- a/docs/kcl-std/functions/std-sketch-angledLine.md
+++ b/docs/kcl-std/functions/std-sketch-angledLine.md
--- a/docs/kcl-std/functions/std-sketch-angledLineThatIntersects.md
+++ b/docs/kcl-std/functions/std-sketch-angledLineThatIntersects.md
--- a/docs/kcl-std/functions/std-sketch-arc.md
+++ b/docs/kcl-std/functions/std-sketch-arc.md
--- a/docs/kcl-std/functions/std-sketch-bezierCurve.md
+++ b/docs/kcl-std/functions/std-sketch-bezierCurve.md
--- a/docs/kcl-std/functions/std-sketch-circle.md
+++ b/docs/kcl-std/functions/std-sketch-circle.md
--- a/docs/kcl-std/functions/std-sketch-circleThreePoint.md
+++ b/docs/kcl-std/functions/std-sketch-circleThreePoint.md
--- a/docs/kcl-std/functions/std-sketch-close.md
+++ b/docs/kcl-std/functions/std-sketch-close.md
--- a/docs/kcl-std/functions/std-sketch-extrude.md
+++ b/docs/kcl-std/functions/std-sketch-extrude.md
--- a/docs/kcl-std/functions/std-sketch-getCommonEdge.md
+++ b/docs/kcl-std/functions/std-sketch-getCommonEdge.md
--- a/docs/kcl-std/functions/std-sketch-getNextAdjacentEdge.md
+++ b/docs/kcl-std/functions/std-sketch-getNextAdjacentEdge.md
--- a/docs/kcl-std/functions/std-sketch-getOppositeEdge.md
+++ b/docs/kcl-std/functions/std-sketch-getOppositeEdge.md
--- a/docs/kcl-std/functions/std-sketch-getPreviousAdjacentEdge.md
+++ b/docs/kcl-std/functions/std-sketch-getPreviousAdjacentEdge.md
--- a/docs/kcl-std/functions/std-sketch-involuteCircular.md
+++ b/docs/kcl-std/functions/std-sketch-involuteCircular.md
--- a/docs/kcl-std/functions/std-sketch-lastSegX.md
+++ b/docs/kcl-std/functions/std-sketch-lastSegX.md
--- a/docs/kcl-std/functions/std-sketch-lastSegY.md
+++ b/docs/kcl-std/functions/std-sketch-lastSegY.md
--- a/docs/kcl-std/functions/std-sketch-line.md
+++ b/docs/kcl-std/functions/std-sketch-line.md
--- a/docs/kcl-std/functions/std-sketch-loft.md
+++ b/docs/kcl-std/functions/std-sketch-loft.md
--- a/docs/kcl-std/functions/std-sketch-patternCircular2d.md
+++ b/docs/kcl-std/functions/std-sketch-patternCircular2d.md
--- a/docs/kcl-std/functions/std-sketch-patternLinear2d.md
+++ b/docs/kcl-std/functions/std-sketch-patternLinear2d.md
--- a/docs/kcl-std/functions/std-sketch-patternTransform2d.md
+++ b/docs/kcl-std/functions/std-sketch-patternTransform2d.md
--- a/docs/kcl-std/functions/std-sketch-polygon.md
+++ b/docs/kcl-std/functions/std-sketch-polygon.md
--- a/docs/kcl-std/functions/std-sketch-profileStart.md
+++ b/docs/kcl-std/functions/std-sketch-profileStart.md
--- a/docs/kcl-std/functions/std-sketch-profileStartX.md
+++ b/docs/kcl-std/functions/std-sketch-profileStartX.md
--- a/docs/kcl-std/functions/std-sketch-profileStartY.md
+++ b/docs/kcl-std/functions/std-sketch-profileStartY.md
--- a/docs/kcl-std/functions/std-sketch-revolve.md
+++ b/docs/kcl-std/functions/std-sketch-revolve.md
--- a/docs/kcl-std/functions/std-sketch-segAng.md
+++ b/docs/kcl-std/functions/std-sketch-segAng.md
--- a/docs/kcl-std/functions/std-sketch-segEnd.md
+++ b/docs/kcl-std/functions/std-sketch-segEnd.md
--- a/docs/kcl-std/functions/std-sketch-segEndX.md
+++ b/docs/kcl-std/functions/std-sketch-segEndX.md
--- a/docs/kcl-std/functions/std-sketch-segEndY.md
+++ b/docs/kcl-std/functions/std-sketch-segEndY.md
--- a/docs/kcl-std/functions/std-sketch-segLen.md
+++ b/docs/kcl-std/functions/std-sketch-segLen.md
--- a/docs/kcl-std/functions/std-sketch-segStart.md
+++ b/docs/kcl-std/functions/std-sketch-segStart.md
--- a/docs/kcl-std/functions/std-sketch-segStartX.md
+++ b/docs/kcl-std/functions/std-sketch-segStartX.md
--- a/docs/kcl-std/functions/std-sketch-segStartY.md
+++ b/docs/kcl-std/functions/std-sketch-segStartY.md
--- a/docs/kcl-std/functions/std-sketch-startProfile.md
+++ b/docs/kcl-std/functions/std-sketch-startProfile.md
--- a/docs/kcl-std/functions/std-sketch-startSketchOn.md
+++ b/docs/kcl-std/functions/std-sketch-startSketchOn.md
--- a/docs/kcl-std/functions/std-sketch-subtract2d.md
+++ b/docs/kcl-std/functions/std-sketch-subtract2d.md
--- a/docs/kcl-std/functions/std-sketch-sweep.md
+++ b/docs/kcl-std/functions/std-sketch-sweep.md
--- a/docs/kcl-std/functions/std-sketch-tangentToEnd.md
+++ b/docs/kcl-std/functions/std-sketch-tangentToEnd.md
--- a/docs/kcl-std/functions/std-sketch-tangentialArc.md
+++ b/docs/kcl-std/functions/std-sketch-tangentialArc.md
--- a/docs/kcl-std/functions/std-sketch-xLine.md
+++ b/docs/kcl-std/functions/std-sketch-xLine.md
--- a/docs/kcl-std/functions/std-sketch-yLine.md
+++ b/docs/kcl-std/functions/std-sketch-yLine.md
--- a/docs/kcl-std/functions/std-solid-appearance.md
+++ b/docs/kcl-std/functions/std-solid-appearance.md
--- a/docs/kcl-std/functions/std-solid-chamfer.md
+++ b/docs/kcl-std/functions/std-solid-chamfer.md
--- a/docs/kcl-std/functions/std-solid-fillet.md
+++ b/docs/kcl-std/functions/std-solid-fillet.md
--- a/docs/kcl-std/functions/std-solid-hollow.md
+++ b/docs/kcl-std/functions/std-solid-hollow.md
--- a/docs/kcl-std/functions/std-solid-intersect.md
+++ b/docs/kcl-std/functions/std-solid-intersect.md
--- a/docs/kcl-std/functions/std-solid-patternCircular3d.md
+++ b/docs/kcl-std/functions/std-solid-patternCircular3d.md
--- a/docs/kcl-std/functions/std-solid-patternLinear3d.md
+++ b/docs/kcl-std/functions/std-solid-patternLinear3d.md
--- a/docs/kcl-std/functions/std-solid-patternTransform.md
+++ b/docs/kcl-std/functions/std-solid-patternTransform.md
--- a/docs/kcl-std/functions/std-solid-shell.md
+++ b/docs/kcl-std/functions/std-solid-shell.md
--- a/docs/kcl-std/functions/std-solid-subtract.md
+++ b/docs/kcl-std/functions/std-solid-subtract.md
--- a/docs/kcl-std/functions/std-solid-union.md
+++ b/docs/kcl-std/functions/std-solid-union.md
--- a/docs/kcl-std/functions/std-transform-mirror2d.md
+++ b/docs/kcl-std/functions/std-transform-mirror2d.md
--- a/docs/kcl-std/functions/std-transform-rotate.md
+++ b/docs/kcl-std/functions/std-transform-rotate.md
--- a/docs/kcl-std/functions/std-transform-scale.md
+++ b/docs/kcl-std/functions/std-transform-scale.md
--- a/docs/kcl-std/functions/std-transform-translate.md
+++ b/docs/kcl-std/functions/std-transform-translate.md
--- a/docs/kcl-std/functions/std-units-toDegrees.md
+++ b/docs/kcl-std/functions/std-units-toDegrees.md
--- a/docs/kcl-std/functions/std-units-toRadians.md
+++ b/docs/kcl-std/functions/std-units-toRadians.md
--- a/docs/kcl-std/index.md
+++ b/docs/kcl-std/index.md
@ -47,47 +47,47 @@ layout: manual
  * [`sqrt`](/docs/kcl-std/functions/std-math-sqrt)
  * [`tan`](/docs/kcl-std/functions/std-math-tan)
 * [**std::sketch**](/docs/kcl-std/modules/std-sketch)
-  * [`angledLine`](/docs/kcl-std/angledLine)
-  * [`angledLineThatIntersects`](/docs/kcl-std/angledLineThatIntersects)
-  * [`arc`](/docs/kcl-std/arc)
-  * [`bezierCurve`](/docs/kcl-std/bezierCurve)
+  * [`angledLine`](/docs/kcl-std/functions/std-sketch-angledLine)
+  * [`angledLineThatIntersects`](/docs/kcl-std/functions/std-sketch-angledLineThatIntersects)
+  * [`arc`](/docs/kcl-std/functions/std-sketch-arc)
+  * [`bezierCurve`](/docs/kcl-std/functions/std-sketch-bezierCurve)
  * [`circle`](/docs/kcl-std/functions/std-sketch-circle)
  * [`circleThreePoint`](/docs/kcl-std/functions/std-sketch-circleThreePoint)
-  * [`close`](/docs/kcl-std/close)
+  * [`close`](/docs/kcl-std/functions/std-sketch-close)
  * [`extrude`](/docs/kcl-std/functions/std-sketch-extrude)
  * [`getCommonEdge`](/docs/kcl-std/functions/std-sketch-getCommonEdge)
  * [`getNextAdjacentEdge`](/docs/kcl-std/functions/std-sketch-getNextAdjacentEdge)
  * [`getOppositeEdge`](/docs/kcl-std/functions/std-sketch-getOppositeEdge)
  * [`getPreviousAdjacentEdge`](/docs/kcl-std/functions/std-sketch-getPreviousAdjacentEdge)
-  * [`involuteCircular`](/docs/kcl-std/involuteCircular)
-  * [`lastSegX`](/docs/kcl-std/lastSegX)
-  * [`lastSegY`](/docs/kcl-std/lastSegY)
-  * [`line`](/docs/kcl-std/line)
+  * [`involuteCircular`](/docs/kcl-std/functions/std-sketch-involuteCircular)
+  * [`lastSegX`](/docs/kcl-std/functions/std-sketch-lastSegX)
+  * [`lastSegY`](/docs/kcl-std/functions/std-sketch-lastSegY)
+  * [`line`](/docs/kcl-std/functions/std-sketch-line)
  * [`loft`](/docs/kcl-std/functions/std-sketch-loft)
  * [`patternCircular2d`](/docs/kcl-std/functions/std-sketch-patternCircular2d)
  * [`patternLinear2d`](/docs/kcl-std/functions/std-sketch-patternLinear2d)
  * [`patternTransform2d`](/docs/kcl-std/functions/std-sketch-patternTransform2d)
  * [`polygon`](/docs/kcl-std/functions/std-sketch-polygon)
-  * [`profileStart`](/docs/kcl-std/profileStart)
-  * [`profileStartX`](/docs/kcl-std/profileStartX)
-  * [`profileStartY`](/docs/kcl-std/profileStartY)
+  * [`profileStart`](/docs/kcl-std/functions/std-sketch-profileStart)
+  * [`profileStartX`](/docs/kcl-std/functions/std-sketch-profileStartX)
+  * [`profileStartY`](/docs/kcl-std/functions/std-sketch-profileStartY)
  * [`revolve`](/docs/kcl-std/functions/std-sketch-revolve)
-  * [`segAng`](/docs/kcl-std/segAng)
-  * [`segEnd`](/docs/kcl-std/segEnd)
-  * [`segEndX`](/docs/kcl-std/segEndX)
-  * [`segEndY`](/docs/kcl-std/segEndY)
-  * [`segLen`](/docs/kcl-std/segLen)
-  * [`segStart`](/docs/kcl-std/segStart)
-  * [`segStartX`](/docs/kcl-std/segStartX)
-  * [`segStartY`](/docs/kcl-std/segStartY)
-  * [`startProfile`](/docs/kcl-std/startProfile)
-  * [`startSketchOn`](/docs/kcl-std/startSketchOn)
-  * [`subtract2d`](/docs/kcl-std/subtract2d)
+  * [`segAng`](/docs/kcl-std/functions/std-sketch-segAng)
+  * [`segEnd`](/docs/kcl-std/functions/std-sketch-segEnd)
+  * [`segEndX`](/docs/kcl-std/functions/std-sketch-segEndX)
+  * [`segEndY`](/docs/kcl-std/functions/std-sketch-segEndY)
+  * [`segLen`](/docs/kcl-std/functions/std-sketch-segLen)
+  * [`segStart`](/docs/kcl-std/functions/std-sketch-segStart)
+  * [`segStartX`](/docs/kcl-std/functions/std-sketch-segStartX)
+  * [`segStartY`](/docs/kcl-std/functions/std-sketch-segStartY)
+  * [`startProfile`](/docs/kcl-std/functions/std-sketch-startProfile)
+  * [`startSketchOn`](/docs/kcl-std/functions/std-sketch-startSketchOn)
+  * [`subtract2d`](/docs/kcl-std/functions/std-sketch-subtract2d)
  * [`sweep`](/docs/kcl-std/functions/std-sketch-sweep)
-  * [`tangentToEnd`](/docs/kcl-std/tangentToEnd)
-  * [`tangentialArc`](/docs/kcl-std/tangentialArc)
-  * [`xLine`](/docs/kcl-std/xLine)
-  * [`yLine`](/docs/kcl-std/yLine)
+  * [`tangentToEnd`](/docs/kcl-std/functions/std-sketch-tangentToEnd)
+  * [`tangentialArc`](/docs/kcl-std/functions/std-sketch-tangentialArc)
+  * [`xLine`](/docs/kcl-std/functions/std-sketch-xLine)
+  * [`yLine`](/docs/kcl-std/functions/std-sketch-yLine)
 * [**std::solid**](/docs/kcl-std/modules/std-solid)
  * [`appearance`](/docs/kcl-std/functions/std-solid-appearance)
  * [`chamfer`](/docs/kcl-std/functions/std-solid-chamfer)
@ -144,11 +144,7 @@ layout: manual
 See also the [types overview](/docs/kcl-lang/types)

 * [**Primitive types**](/docs/kcl-lang/types)
-  * [`End`](/docs/kcl-lang/types#End)
  * [`ImportedGeometry`](/docs/kcl-std/types/std-types-ImportedGeometry)
-  * [`Start`](/docs/kcl-lang/types#Start)
-  * [`TagDeclarator`](/docs/kcl-lang/types#TagDeclarator)
-  * [`TagIdentifier`](/docs/kcl-lang/types#TagIdentifier)
  * [`any`](/docs/kcl-std/types/std-types-any)
  * [`bool`](/docs/kcl-std/types/std-types-bool)
  * [`fn`](/docs/kcl-std/types/std-types-fn)
--- a/docs/kcl-std/modules/std-sketch.md
+++ b/docs/kcl-std/modules/std-sketch.md
@ -12,45 +12,45 @@ This module contains functions for creating and manipulating sketches, and makin

 ## Functions and constants

-* [`angledLine`](/docs/kcl-std/angledLine)
-* [`angledLineThatIntersects`](/docs/kcl-std/angledLineThatIntersects)
-* [`arc`](/docs/kcl-std/arc)
-* [`bezierCurve`](/docs/kcl-std/bezierCurve)
+* [`angledLine`](/docs/kcl-std/functions/std-sketch-angledLine)
+* [`angledLineThatIntersects`](/docs/kcl-std/functions/std-sketch-angledLineThatIntersects)
+* [`arc`](/docs/kcl-std/functions/std-sketch-arc)
+* [`bezierCurve`](/docs/kcl-std/functions/std-sketch-bezierCurve)
 * [`circle`](/docs/kcl-std/functions/std-sketch-circle)
 * [`circleThreePoint`](/docs/kcl-std/functions/std-sketch-circleThreePoint)
-* [`close`](/docs/kcl-std/close)
+* [`close`](/docs/kcl-std/functions/std-sketch-close)
 * [`extrude`](/docs/kcl-std/functions/std-sketch-extrude)
 * [`getCommonEdge`](/docs/kcl-std/functions/std-sketch-getCommonEdge)
 * [`getNextAdjacentEdge`](/docs/kcl-std/functions/std-sketch-getNextAdjacentEdge)
 * [`getOppositeEdge`](/docs/kcl-std/functions/std-sketch-getOppositeEdge)
 * [`getPreviousAdjacentEdge`](/docs/kcl-std/functions/std-sketch-getPreviousAdjacentEdge)
-* [`involuteCircular`](/docs/kcl-std/involuteCircular)
-* [`lastSegX`](/docs/kcl-std/lastSegX)
-* [`lastSegY`](/docs/kcl-std/lastSegY)
-* [`line`](/docs/kcl-std/line)
+* [`involuteCircular`](/docs/kcl-std/functions/std-sketch-involuteCircular)
+* [`lastSegX`](/docs/kcl-std/functions/std-sketch-lastSegX)
+* [`lastSegY`](/docs/kcl-std/functions/std-sketch-lastSegY)
+* [`line`](/docs/kcl-std/functions/std-sketch-line)
 * [`loft`](/docs/kcl-std/functions/std-sketch-loft)
 * [`patternCircular2d`](/docs/kcl-std/functions/std-sketch-patternCircular2d)
 * [`patternLinear2d`](/docs/kcl-std/functions/std-sketch-patternLinear2d)
 * [`patternTransform2d`](/docs/kcl-std/functions/std-sketch-patternTransform2d)
 * [`polygon`](/docs/kcl-std/functions/std-sketch-polygon)
-* [`profileStart`](/docs/kcl-std/profileStart)
-* [`profileStartX`](/docs/kcl-std/profileStartX)
-* [`profileStartY`](/docs/kcl-std/profileStartY)
+* [`profileStart`](/docs/kcl-std/functions/std-sketch-profileStart)
+* [`profileStartX`](/docs/kcl-std/functions/std-sketch-profileStartX)
+* [`profileStartY`](/docs/kcl-std/functions/std-sketch-profileStartY)
 * [`revolve`](/docs/kcl-std/functions/std-sketch-revolve)
-* [`segAng`](/docs/kcl-std/segAng)
-* [`segEnd`](/docs/kcl-std/segEnd)
-* [`segEndX`](/docs/kcl-std/segEndX)
-* [`segEndY`](/docs/kcl-std/segEndY)
-* [`segLen`](/docs/kcl-std/segLen)
-* [`segStart`](/docs/kcl-std/segStart)
-* [`segStartX`](/docs/kcl-std/segStartX)
-* [`segStartY`](/docs/kcl-std/segStartY)
-* [`startProfile`](/docs/kcl-std/startProfile)
-* [`startSketchOn`](/docs/kcl-std/startSketchOn)
-* [`subtract2d`](/docs/kcl-std/subtract2d)
+* [`segAng`](/docs/kcl-std/functions/std-sketch-segAng)
+* [`segEnd`](/docs/kcl-std/functions/std-sketch-segEnd)
+* [`segEndX`](/docs/kcl-std/functions/std-sketch-segEndX)
+* [`segEndY`](/docs/kcl-std/functions/std-sketch-segEndY)
+* [`segLen`](/docs/kcl-std/functions/std-sketch-segLen)
+* [`segStart`](/docs/kcl-std/functions/std-sketch-segStart)
+* [`segStartX`](/docs/kcl-std/functions/std-sketch-segStartX)
+* [`segStartY`](/docs/kcl-std/functions/std-sketch-segStartY)
+* [`startProfile`](/docs/kcl-std/functions/std-sketch-startProfile)
+* [`startSketchOn`](/docs/kcl-std/functions/std-sketch-startSketchOn)
+* [`subtract2d`](/docs/kcl-std/functions/std-sketch-subtract2d)
 * [`sweep`](/docs/kcl-std/functions/std-sketch-sweep)
-* [`tangentToEnd`](/docs/kcl-std/tangentToEnd)
-* [`tangentialArc`](/docs/kcl-std/tangentialArc)
-* [`xLine`](/docs/kcl-std/xLine)
-* [`yLine`](/docs/kcl-std/yLine)
+* [`tangentToEnd`](/docs/kcl-std/functions/std-sketch-tangentToEnd)
+* [`tangentialArc`](/docs/kcl-std/functions/std-sketch-tangentialArc)
+* [`xLine`](/docs/kcl-std/functions/std-sketch-xLine)
+* [`yLine`](/docs/kcl-std/functions/std-sketch-yLine)

--- a/docs/kcl-std/std.json
+++ b/docs/kcl-std/std.json
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Kurt Hutten	c42903d2e8	Merge branch 'main' into kurt-web-app-oauth	2025-06-06 14:28:39 +10:00
Kurt Hutten Irev-Dev	d98669fb8a	web app oauth	2025-06-06 13:35:11 +10:00
max	de6184c622	Add support for tag on close segment when the last sketch edge is missing (#7375 ) * add test * fix * Update snapshots * Update snapshots --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-06-06 11:30:24 +10:00
Kurt Hutten	0bce7d3c1c	move TTC capture to unit test (#7268 ) * move TTC capture to unit test * progress with artifact * fmt * abstract cases * add another case * add another test * update snapshots with proper file names * force to JSON * fmt * make jest happy * add another example and other tweaks * fix * tweak * add logs * more logs * strip out kcl version * remove logs * add comment explainer * more comments * more comment * remove package-lock line	2025-06-05 21:29:20 -04:00
Jonathan Tran	c43ec280f2	Change to use artifact pathToNode (#7361 ) * Change to use artifact pathToNode * Fix to do bounds checking	2025-06-05 20:28:21 -04:00
Andrew Varga	8e6483a47b	WIP #7226 Fix remove constraints (#7304 ) * handle if graphSelections is empty * fix removeConstrainingValuesInfo by using pathToNodes if available instead of selectionRanges: current selection should not be required to remove constraints * selectionRanges not needed for removeConstrainingValuesInfo anymore * fix remove constraint unit test: pass line's pathToNode instead of argument to remove constraint	2025-06-06 09:16:11 +10:00
Nick Cameron	e116bbaae8	Remove the untyped getters from std::args (#7377 ) * Move last uses of untypeed arg getters Signed-off-by: Nick Cameron <nrc@ncameron.org> * Rename _typed functions Signed-off-by: Nick Cameron <nrc@ncameron.org> --------- Signed-off-by: Nick Cameron <nrc@ncameron.org>	2025-06-05 18:45:58 -04:00
Nick Cameron	18b458fbca	Fix some typos in previous PR (#7392 ) Signed-off-by: Nick Cameron <nrc@ncameron.org>	2025-06-06 10:05:38 +12:00
Nick Cameron	4d1524f03b	Format examples in docs (#7378 ) Signed-off-by: Nick Cameron <nrc@ncameron.org>	2025-06-05 18:01:45 -04:00
Pierre Jacquier	11d8179368	Check for updates button in moar menus & toasts (#7369 ) * Check for update button in more menus Fixes #7368 * Add menubar item * Another one * Add Checking for updates... and No new update toasts * Lint * Trigger CI * Update src/main.ts Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Update electron-builder.yml Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Update electron-builder.yml * Moar clean up --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>	2025-06-05 17:12:14 -04:00
Jonathan Tran	3c23cada8e	Release KCL 80 (#7391 )	2025-06-05 20:34:58 +00:00
Jace Browning	81782b04ec	Rename and reorder contributor guide sections (#7387 )	2025-06-05 15:06:15 -04:00
Jonathan Tran	9ade6676b7	Fix docs for loft (#7389 )	2025-06-05 19:05:46 +00:00
Jace Browning	86e5c37678	Make web end-to-end tests exclusive with desktop (#7388 ) * Make web end-to-end tests exclusive with desktop * Use double quotes to support Windows	2025-06-05 13:42:36 -04:00
Jonathan Tran	8c36d742e5	Add mirror2d operations to Feature Tree (#7308 ) * Add mirror2d operations * Update output	2025-06-05 12:52:53 -04:00
Jonathan Tran	f6a3a3d0cd	Change to use nodePath instead of sourceRange for Operations (#7320 ) * Add NodePath to operations * Change to use nodePath to get pathToNode instead of sourceRange * Add additional node path unit test * Update output * Fix import statement NodePaths * Update output * Factor into function	2025-06-05 12:24:34 -04:00
Adam Chalmers	b5f81cb84a	Run fmt (#7383 )	2025-06-05 11:46:48 -04:00
Andrew Varga	4bb17c192f	Stabilize multiprofile sketch test further (#7373 ) * increase timeout after rectangle tool is clicked from 200ms -> 400ms * Delay after each primitive mouse interaction * Update snapshots * Update snapshots --------- Co-authored-by: jacebrowning <jacebrowning@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-06-05 11:28:40 -04:00
Andrew Varga	51ce55e782	Remove nested <button> elements (#7291 ) * remove nested <button> elements to avoid dom warning about nested buttons * keep using Popover.Button to allow popover functionality * fmt * match ShareButton margin to main branch to make snapshot tests happy	2025-06-05 17:24:04 +02:00
Adam Chalmers	427d55d13e	KCL: Optimization, ty Jon (#7379 ) This avoids a clone	2025-06-05 08:34:16 -05:00
Adam Chalmers	4575b32dbc	KCL parser: Allow .prop or [index] to follow any expression (#7371 ) Previously in a member expression like `foo.x` or `foo[3]`, `foo` had to be an identifier. You could not do something like `f().x` (and if you tried, you got a cryptic error). Rather than make the error better, we should just accept any expression to be the LHS of a member expression (aka its 'object'). This does knock our "parse lots of function calls" from 58 to 55 calls before it stack overflows. But I think it's fine, we'll address this in https://github.com/KittyCAD/modeling-app/pull/6226 when I get back to it. Closes https://github.com/KittyCAD/modeling-app/issues/7273	2025-06-05 09:23:48 -04:00
Adam Chalmers	9136fb0d1b	KCL: Improve error messages for var referenced in own definition (#7374 ) Jon pointed out that my new error message wasn't showing up in some cases, and it should store/restore the previous var being defined.	2025-06-04 23:48:15 -05:00
Nick Cameron	33d5a9cdc1	Execution refactoring (#7376 ) * Move import graph to execution Signed-off-by: Nick Cameron <nrc@ncameron.org> * Refactor artifact handling Signed-off-by: Nick Cameron <nrc@ncameron.org> * Refactor caching to separate global state from per-module state Signed-off-by: Nick Cameron <nrc@ncameron.org> --------- Signed-off-by: Nick Cameron <nrc@ncameron.org>	2025-06-05 15:56:43 +12:00
Adam Chalmers	c25dfabc94	Stronger types and better error handling in executeMock (#7370 ) This brings the `execute_mock` function into line with the `execute` function, which I tweaked in https://github.com/KittyCAD/modeling-app/pull/7351. Now mock execution, like real execution, will always return a properly-formatted KCL error, instead of any possible JS value. Also, incidentally, I noticed that send_response always succeeds, so I changed it from Result<()> to void.	2025-06-04 18:24:24 -04:00
Adam Chalmers	4502ad62b2	Fix vite warning (#7360 ) Specifically this warning: ``` [vite] warning: This case clause will never be evaluated because it duplicates an earlier case clause \| case 'angledLine': \| case 'startProfile': \| case 'arcTo': \| ^ \| return fnName \| default: ```	2025-06-04 17:08:06 -04:00
Nick Cameron	5235a731ba	Move sketch functions to KCL; remove Rust decl dead code (#7335 ) Signed-off-by: Nick Cameron <nrc@ncameron.org>	2025-06-04 15:41:01 -04:00
Zookeeper Lee	5ceb92d117	Try to avoid the black screen again & improve error messages (#7327 ) * Fix the black screen of death * fmt * make check * Clean up * Fix up zoom to fit * Change how emulateNetworkConditions work * Do NOT use browser's offline/online mechanisms * Fix test * Improve network error messages * Signal offline when failed event comes in * Don't use logic on components that only want a loader * Remove unnecessary pause state transition --------- Co-authored-by: jacebrowning <jacebrowning@gmail.com>	2025-06-04 13:59:22 -04:00
Max Ammann	ff92c73ac4	Update dependabot config (#7362 )	2025-06-04 10:08:54 -04:00
Pierre Jacquier	bbb6fffbcc	Allow edit for Translate and Rotate in Feature Tree (#7345 ) * WIP: Wire up edit on transforms to the new feature tree standalone ops Fixes #7338 * Clean up diff * Oopsie	2025-06-04 09:35:01 -04:00
Andrew Varga	37fca0d1df	#7326 Fix "Zoom to fit to shared model on web" test (#7328 ) * fix test * fix e2e test in another way so it doesnt break unit tests * Cleanup * Update src/hooks/useQueryParamEffects.ts Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * hasAskToOpen should only be used if not in desktop --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>	2025-06-04 09:37:25 +02:00
Jonathan Tran	e3694e4781	Fix crash while editing code while in sketch mode (#7284 ) * Fix crash by checking bounds * Add unit test	2025-06-04 12:10:09 +10:00
Jonathan Tran	f97bdaf8b7	Release KCL 79 (#7347 )	2025-06-03 22:04:56 -04:00
Adam Chalmers	3f3693e12d	Type ascription produces two incompatible fields (#7355 ) # Symptoms This code produces a big ugly confusing error in the frontend, see #7340. # Root cause I added a new test case, with an unknown type. In `ast.snap` under `body[0].declaration.init.ty` there two different `type` fields in the AST node for the type's name, and they have conflicting values Primitive and Identifier. <img width="602" alt="Screenshot 2025-06-03 at 4 04 55 PM" src="https://github.com/user-attachments/assets/913a0fa0-3e8d-473f-bb64-003d44915be0" /> # Solution Change the `enum PrimitiveType` variant from `Named(Node<Identifier>)` to `Named { name: Node<Identifier> }` so that the fields nest differently. Now the error correctly points out to the user that the type `NotARealType` can't be found. Much better error message that shows the user the problem. # Alternative solutions Stop the duplicated JSON fields altogether. I tried this previously in https://github.com/KittyCAD/modeling-app/pull/4369 but it was very involved, and I didn't think it was worth it. Maybe I should reopen that PR and solve this properly. Closes #7340	2025-06-03 20:05:40 -04:00
Jonathan Tran	73660d1db8	Bump criterion from 0.5.1 to 0.6.0 (#7357 )	2025-06-04 09:34:34 +10:00
Adam Chalmers	c373f33507	KCL: Fix format	2025-06-04 09:04:35 +10:00
Andrew Varga	2dc76a71cc	Stabilize test: "Can edit a sketch with multiple profiles, dragging segments to edit them, and adding one new profile" (#7356 )	2025-06-03 18:20:06 -04:00
Adam Chalmers	ce42966f2b	Upgrade to Rust 1.87 (#7346 ) I ignored some new clippy lints about large differences between enum variants. We can always revisit these later (the compiler suggests boxing them so that the enum variants are similar size)	2025-06-03 17:32:24 -04:00
Adam Chalmers	b47b9c9613	KCL: Emit proper errors in unexpected edge cases (#7351 ) There's some bug in the frontend or KCL somewhere, which results in the TypeScript frontend sending an AST (serialized to JSON) to the KCL executor, but the JSON cannot be deserialized into an AST. If this happens, it's a bug in ZDS, not a user error. The problem is that this sort of error will cause the frontend to silently stop rendering KCL, and it won't show the user any errors. They need to open up the console and look at the error there, and even if they do, it's hard to understand. This PR changes how we report these unexpected errors due to bugs in ZDS. ZDS should not silently stop working, it should at least print a half-decent error like this: <img width="527" alt="nicer error" src="https://github.com/user-attachments/assets/1bb37a64-0915-4472-849c-d146f397356b" /> ## Fix Right now, the wasm library exports a function `execute`. It previous returned an error as a String if one occurred. The frontend assumed this error string would be JSON that matched the schema `KclErrorWithOutputs`. This was not always true! For example, if something couldn't be serialized to JSON, we'd take the raw Serde error and stringify that. It wouldn't match `KclErrorWithOutputs`. Now I've changed `execute` so that if it errors, it'll returns a JsValue not a string. So that's one check (can this string be deserialized into a JSON object) that can be removed -- it'll return a JSON object directly now. The next check is "does this JSON object conform to the KclErrorWithOutputs schema". To prove that's correct, I changed `execute` to be a thin wrapper around `fn execute_typed` which returns `Result<ExecOutcome, KclErrorWithOutputs>`. Now we know the error will be the right type.	2025-06-03 15:37:17 -05:00
Zookeeper Lee	2af2144f89	Add query parameter to skip the embedded "sign in" view (#7352 ) Add query parameter to skip sign-in view if not necessary	2025-06-03 16:23:23 -04:00
Frank Noirot	bd37c488ee	Fix trackball, finally add an E2E test for it (#7341 ) * Fix orbit style setting not updating in camControls * Break apart camera movement tests, add trackball to orbit one * I don't think zoom was actually testing changes, this fixes that * test refactor: pass in expected cam pos, not its inverse * Lints * Lint fix broke the test, fix fix * Gah biome whyyy did you format other test names like that?	2025-06-03 14:56:19 -04:00
Jonathan Tran	a3551e4b2f	Bump csscolorparser from 0.7.0 to 0.7.2 (#7344 )	2025-06-03 11:50:09 -05:00
Adam Chalmers	d3979edb41	KCL: Better error message when using var in its own definition (#7339 ) I thought I did this in https://github.com/KittyCAD/modeling-app/pull/7325, but I forgot to actually set the better message. Actually fixes, for real this time, https://github.com/KittyCAD/modeling-app/issues/6072 this time.	2025-06-03 16:46:28 +00:00
Jonathan Tran	095a7a575b	Bump tokio-tungstenite from 0.24.0 to 0.26.2 (#7329 )	2025-06-03 10:16:22 -05:00
Pierre Jacquier	b5c8ca05a5	Fix whitespace in updater toast (#7331 ) pierremtb/adhoc/whitespace-fix-updater-toast	2025-06-03 10:15:42 -04:00
Kurt Hutten	33f7badf41	point and click-ify mounting plate (#7287 ) * point and click-ify mounting plate * Update kcl-samples simulation test output * Update public/kcl-samples/mounting-plate/main.kcl * Update public/kcl-samples/mounting-plate/main.kcl * fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-06-03 08:10:37 -04:00
Nick Cameron	569935c21f	Move segment functions to KCL (#7333 ) Signed-off-by: Nick Cameron <nrc@ncameron.org>	2025-06-03 15:15:51 +12:00
Adam Chalmers	7680605085	KCL: Fix 'cryptic' error when referencing a variable in its own declaration (#7325 ) Previously, `x = cos(x)` would just say "`x` is undefined". Now it says that `x` cannot be referenced in its own definition, try using a different variable instead. To do this, I've added a new `Option<String>` field to the mod-local executor context, tracking the current variable declaration. This means cloning some strings, implying a small performance hit. I think it's fine, for the better diagnostics. In the future we could refactor this to use a &str or store variable labels in stack-allocated strings like docs.rs/compact_str or something. Closes https://github.com/KittyCAD/modeling-app/issues/6072	2025-06-02 18:25:55 -04:00
Jonathan Tran	2bb6c74f42	Update error message after engine change (#7330 )	2025-06-02 18:05:46 -04:00
Pierre Jacquier	faf4d42b6a	Update getSketchExprsFromSelection to use codeRef.pathToNode (#6737 )	2025-06-02 16:49:41 -04:00
Pierre Jacquier	8dd2a86191	Make sweep tests more point-and-click like and clean up pathToNode retrieval (#6963 ) WIP: udpate sweep point-and-click tests and mess with pathToNode Fixes #6952	2025-06-02 16:49:20 -04:00
Adam Chalmers	13c4de77c3	Fix broken WASM test (#7324 ) Previous PR (#7321) was set to automerge, but apparently the npm-unit-test CI target doesn't block merges if it fails. Fixed now.	2025-06-02 15:56:49 -04:00
Adam Chalmers	e29ee9d1ca	KCL: Use named fields for KclError (#7321 ) We've changed the unnamed field of `KclError` variants to a named called `details`. To clarify: previously KCL errors looked like this: ```rust pub enum KclError { Lexical(KclErrorDetails), Syntax(KclErrorDetails), ``` Now they look like this: ```rust pub enum KclError { Lexical { details: KclErrorDetails }, Syntax { details: KclErrorDetails }, } ``` This lets us more easily add fields to the errors. For example, in the UndefinedValue case, adding a field for what the undefined name was. This PR refactors the code to make my PR in https://github.com/KittyCAD/modeling-app/pull/7309 much easier. Pure refactor, should not change any behaviour.	2025-06-02 14:30:57 -04:00
Jonathan Tran	b7437e949a	Update generated output to try to fix flakiness (#7323 )	2025-06-02 13:36:41 -04:00
Jonathan Tran	08781ff010	Add transform operations to the Feature Tree (#7307 ) * Add transform operations * Update output * Add scale icon	2025-06-02 10:32:36 -04:00
Andrew Varga	eb79b1f746	#7227 Fix project not saving when dragging a segment (#7276 ) * fix bug of not saving project when dragging a segment, add a test * Update e2e/playwright/projects.spec.ts Co-authored-by: Jace Browning <jacebrowning@gmail.com> --------- Co-authored-by: Jace Browning <jacebrowning@gmail.com>	2025-06-02 09:28:23 +02:00
Josh Gomez	8df81b2753	Update URL in Discord Bot (#7306 )	2025-05-30 14:36:45 -07:00
Jace Browning	e75a604c64	Fix the link for plan upgrades (#7305 )	2025-05-30 16:54:07 -04:00
Adam Sunderland	0624e42822	Add more detail to close() docs (#7300 ) * Add more detail to close() docs * Run gen	2025-05-30 16:05:32 -04:00
Zookeeper Lee	1c07e8af5b	Add hysteresis and EMA to ping to avoid flickering network badge (#7197 ) * Don't use WEAK and yellow * fmt && lint && tsc * Fix up the rebase & dark mode colors * Update src/hooks/useNetworkStatus.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Change Weak to Ok * Change Connected to Strong * fmt * Sync selectors for start sketch * Remove unused test-util brought back in a rebase * Align the other OKs * Add an else statement to overallState --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>	2025-05-30 15:50:05 -04:00
Adam Chalmers	5fccaad0e7	KCL: Fix cryptic error on unexpected tokens in fn call (#7295 ) This program: ```kcl 1 \|> extrude( length=depth, }) ``` was giving this bad error: ``` unexpected token \|> ``` Now it gives ```kcl There was an unexpected }. Try removing it. ``` and it correctly puts the diagnostic on the extra }. Fixes https://github.com/KittyCAD/modeling-app/issues/6126	2025-05-30 14:57:05 -04:00
Adam Chalmers	a506f7f698	KCL: Fix cryptic error when missing commas between arguments (#7297 ) Previously, this KCL ``` arc( endAbsolute = [0, 50] interiorAbsolute = [-50, 0] ) ``` gave the error `This argument has a label, but no value. Put some value after the equals sign`. Now it gives this much better error `Missing comma between arguments, try adding a comma in`, and its source range (red underline) is on the whitespace which was missing a comma: <img width="666" src="https://github.com/user-attachments/assets/aa5035f5-f748-4dab-b918-b81b05733323" /> Thanks for reporting this @benjamaan476	2025-05-30 13:20:06 -05:00
Jonathan Tran	1bb96cd878	Release KCL 78 (#7298 )	2025-05-30 13:48:17 -04:00