* Get electron building something at all * Merge Frank test setup work (#3418) * Working window.electron.getPath * Loading project-specific settings in electron tests * Simplify test until we can get snapshots/traces working in electron tests * test tweaks --------- Co-authored-by: Frank Noirot <frank@kittycad.io> * add test #3375 and #3420 * put kcl files together * move files * can sort projects #3362 * File in the file pane should open with a single click #3385 * pressing delete on home screen should do nothing #3387 * add aria labels to icons * Rename and delete projects, also spam arrow keys when renaming #3364 #3365 #3259 * Fix up paths * Update flake.nix to support Electron * Remove a layer of indirection * Work without a web server * Fix settings#projectDir link on home * Fix login (requires new @kittycad/lib WHICH IS NOT INCLUDED HERE) * Lee: Tests are broken because auth skip needs to happen * get setting override envs passed through * tweak eletron CI * yml tweak * fmt * NUKE tauri shit post merge with main * another test auth tweak * Revert "another test auth tweak" This reverts commitb2254b10af
. * try CI again * CI tweaks * SKIP_AUTH true now on playwright * Skipping auth when NODE_ENV=development now * fmt Signed-off-by: Jess Frazelle <github@jessfraz.com> * Use BASE_URL() * fix exists Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix foldername for macos Signed-off-by: Jess Frazelle <github@jessfraz.com> * update for windows Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix version in lower right Signed-off-by: Jess Frazelle <github@jessfraz.com> * cleanup unused imports Signed-off-by: Jess Frazelle <github@jessfraz.com> * progress on is playwright Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix test folders Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix fmt Signed-off-by: Jess Frazelle <github@jessfraz.com> * remove tauri from actions bullshit Signed-off-by: Jess Frazelle <github@jessfraz.com> * remove tauri dir Signed-off-by: Jess Frazelle <github@jessfraz.com> * fixups the coredump async shit Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * node env dev Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix cancellable Signed-off-by: Jess Frazelle <github@jessfraz.com> * cleanup unnessary things Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix Signed-off-by: Jess Frazelle <github@jessfraz.com> * env vars Signed-off-by: Jess Frazelle <github@jessfraz.com> * Bring back fix for NOT using hardcoded main.kcl * env Signed-off-by: Jess Frazelle <github@jessfraz.com> * fmt Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * Revert "updates" This reverts commit da5d9f1043eb94404e8b3f8044088e990e34a4ef. * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * remove tauri clippuy Signed-off-by: Jess Frazelle <github@jessfraz.com> * less retries for now, no debug Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * tsconfig Signed-off-by: Jess Frazelle <github@jessfraz.com> * small tsc fix * update some tsc Signed-off-by: Jess Frazelle <github@jessfraz.com> * tsc env Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix other tsc Signed-off-by: Jess Frazelle <github@jessfraz.com> * small change for routeLoaders * rm old screenshot Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix auth Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix last onew Signed-off-by: Jess Frazelle <github@jessfraz.com> * auth clean up * fix package.json Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix Signed-off-by: Jess Frazelle <github@jessfraz.com> * dissmissed screen on tests * add waits between files being written * put back retried Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix weird programMemory Map issue * put private back * Revert "put private back" This reverts commitd311b978ca
. * Revert "fix weird programMemory Map issue" This reverts commit6c387bdf62
. * remove serde-wasm-bindgen Signed-off-by: Jess Frazelle <github@jessfraz.com> * add env Signed-off-by: Jess Frazelle <github@jessfraz.com> * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu) * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu) * fix tests * more test tweaks * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu) * another tweak * A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu) * more test tweaks * more tweaks * increase macos timeout * try fix macos * disable macos playwright tests --------- Signed-off-by: Jess Frazelle <github@jessfraz.com> Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch> Co-authored-by: Frank Noirot <frank@kittycad.io> Co-authored-by: Adam Sunderland <iterion@gmail.com> Co-authored-by: Jess Frazelle <github@jessfraz.com> Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
191 lines
6.5 KiB
TypeScript
191 lines
6.5 KiB
TypeScript
import { test, expect } from '@playwright/test'
|
|
|
|
import { getUtils, setup, tearDown } from './test-utils'
|
|
import { SaveSettingsPayload } from 'lib/settings/settingsTypes'
|
|
import { TEST_SETTINGS_KEY, TEST_SETTINGS_CORRUPTED } from './storageStates'
|
|
import * as TOML from '@iarna/toml'
|
|
|
|
test.beforeEach(async ({ context, page }) => {
|
|
await setup(context, page)
|
|
})
|
|
|
|
test.afterEach(async ({ page }, testInfo) => {
|
|
await tearDown(page, testInfo)
|
|
})
|
|
|
|
test.describe('Testing settings', () => {
|
|
test('Stored settings are validated and fall back to defaults', async ({
|
|
page,
|
|
}) => {
|
|
const u = await getUtils(page)
|
|
|
|
// Override beforeEach test setup
|
|
// with corrupted settings
|
|
await page.addInitScript(
|
|
async ({ settingsKey, settings }) => {
|
|
localStorage.setItem(settingsKey, settings)
|
|
},
|
|
{
|
|
settingsKey: TEST_SETTINGS_KEY,
|
|
settings: TOML.stringify({ settings: TEST_SETTINGS_CORRUPTED }),
|
|
}
|
|
)
|
|
|
|
await page.setViewportSize({ width: 1200, height: 500 })
|
|
|
|
await u.waitForAuthSkipAppStart()
|
|
|
|
// Check the settings were reset
|
|
const storedSettings = TOML.parse(
|
|
await page.evaluate(
|
|
({ settingsKey }) => localStorage.getItem(settingsKey) || '',
|
|
{ settingsKey: TEST_SETTINGS_KEY }
|
|
)
|
|
) as { settings: SaveSettingsPayload }
|
|
|
|
expect(storedSettings.settings?.app?.theme).toBe(undefined)
|
|
|
|
// Check that the invalid settings were removed
|
|
expect(storedSettings.settings?.modeling?.defaultUnit).toBe(undefined)
|
|
expect(storedSettings.settings?.modeling?.mouseControls).toBe(undefined)
|
|
expect(storedSettings.settings?.app?.projectDirectory).toBe(undefined)
|
|
expect(storedSettings.settings?.projects?.defaultProjectName).toBe(
|
|
undefined
|
|
)
|
|
})
|
|
|
|
test('Project settings can be set and override user settings', async ({
|
|
page,
|
|
}) => {
|
|
const u = await getUtils(page)
|
|
await page.setViewportSize({ width: 1200, height: 500 })
|
|
await u.waitForAuthSkipAppStart()
|
|
await page
|
|
.getByRole('button', { name: 'Start Sketch' })
|
|
.waitFor({ state: 'visible' })
|
|
|
|
const paneButtonLocator = page.getByTestId('debug-pane-button')
|
|
const headingLocator = page.getByRole('heading', {
|
|
name: 'Settings',
|
|
exact: true,
|
|
})
|
|
const inputLocator = page.locator('input[name="modeling-showDebugPanel"]')
|
|
|
|
// Open the settings modal with the browser keyboard shortcut
|
|
await page.keyboard.press('Meta+Shift+,')
|
|
|
|
await expect(headingLocator).toBeVisible()
|
|
await page.locator('#showDebugPanel').getByText('OffOn').click()
|
|
|
|
// Close it and open again with keyboard shortcut, while KCL editor is focused
|
|
// Put the cursor in the editor
|
|
await test.step('Open settings with keyboard shortcut', async () => {
|
|
await page.getByTestId('settings-close-button').click()
|
|
await page.locator('.cm-content').click()
|
|
await page.keyboard.press('Meta+Shift+,')
|
|
await expect(headingLocator).toBeVisible()
|
|
})
|
|
|
|
// Verify the toast appeared
|
|
await expect(
|
|
page.getByText(`Set show debug panel to "false" for this project`)
|
|
).toBeVisible()
|
|
// Check that the theme changed
|
|
await expect(paneButtonLocator).not.toBeVisible()
|
|
|
|
// Check that the user setting was not changed
|
|
await page.getByRole('radio', { name: 'User' }).click()
|
|
await expect(inputLocator).toBeChecked()
|
|
|
|
// Roll back to default of "off"
|
|
await await page
|
|
.getByText('show debug panelRoll back show debug panelRoll back to match')
|
|
.hover()
|
|
await page
|
|
.getByRole('button', {
|
|
name: 'Roll back show debug panel',
|
|
})
|
|
.click()
|
|
await expect(inputLocator).not.toBeChecked()
|
|
|
|
// Check that the project setting did not change
|
|
await page.getByRole('radio', { name: 'Project' }).click()
|
|
await expect(
|
|
page.locator('input[name="modeling-showDebugPanel"]')
|
|
).not.toBeChecked()
|
|
})
|
|
|
|
// TODO fixme reset doesn't seem to work for color setting
|
|
test.fixme('Project and user settings can be reset', async ({ page }) => {
|
|
const u = await getUtils(page)
|
|
await page.setViewportSize({ width: 1200, height: 500 })
|
|
await u.waitForAuthSkipAppStart()
|
|
await page
|
|
.getByRole('button', { name: 'Start Sketch' })
|
|
.waitFor({ state: 'visible' })
|
|
|
|
const projectSettingsTab = page.getByRole('radio', { name: 'Project' })
|
|
const userSettingsTab = page.getByRole('radio', { name: 'User' })
|
|
const resetButton = page.getByRole('button', {
|
|
name: 'Restore default settings',
|
|
})
|
|
const themeColorSetting = page.locator('#themeColor').getByRole('slider')
|
|
const settingValues = {
|
|
default: '259',
|
|
user: '120',
|
|
project: '50',
|
|
}
|
|
|
|
// Open the settings modal with lower-right button
|
|
await page.getByRole('link', { name: 'Settings' }).last().click()
|
|
await expect(
|
|
page.getByRole('heading', { name: 'Settings', exact: true })
|
|
).toBeVisible()
|
|
|
|
await test.step('Set up theme color', async () => {
|
|
// Verify we're looking at the project-level settings,
|
|
// and it's set to default value
|
|
await expect(projectSettingsTab).toBeChecked()
|
|
await expect(themeColorSetting).toHaveValue(settingValues.default)
|
|
|
|
// Set project-level value to 50
|
|
await themeColorSetting.fill(settingValues.project)
|
|
|
|
// Set user-level value to 120
|
|
await userSettingsTab.click()
|
|
await themeColorSetting.fill(settingValues.user)
|
|
await projectSettingsTab.click()
|
|
})
|
|
|
|
await test.step('Reset project settings', async () => {
|
|
// Click the reset settings button.
|
|
await resetButton.click()
|
|
|
|
// Verify it is now set to the inherited user value
|
|
await expect(themeColorSetting).toHaveValue(settingValues.default)
|
|
|
|
// Check that the user setting also rolled back
|
|
await userSettingsTab.click()
|
|
await expect(themeColorSetting).toHaveValue(settingValues.default)
|
|
await projectSettingsTab.click()
|
|
|
|
// Set project-level value to 50 again to test the user-level reset
|
|
await themeColorSetting.fill(settingValues.project)
|
|
await userSettingsTab.click()
|
|
})
|
|
|
|
await test.step('Reset user settings', async () => {
|
|
// Change the setting and click the reset settings button.
|
|
await themeColorSetting.fill(settingValues.user)
|
|
await resetButton.click()
|
|
|
|
// Verify it is now set to the default value
|
|
await expect(themeColorSetting).toHaveValue(settingValues.default)
|
|
|
|
// Check that the project setting also changed
|
|
await projectSettingsTab.click()
|
|
await expect(themeColorSetting).toHaveValue(settingValues.default)
|
|
})
|
|
})
|
|
})
|