modeling-app

Files

Adam Chalmers 3f3693e12d Type ascription produces two incompatible fields (#7355 )

# Symptoms

This code produces a big ugly confusing error in the frontend, see #7340.

# Root cause

I added a new test case, with an unknown type. In `ast.snap` under `body[0].declaration.init.ty` there two different `type` fields in the AST node for the type's name, and they have conflicting values Primitive and Identifier.

<img width="602" alt="Screenshot 2025-06-03 at 4 04 55 PM" src="https://github.com/user-attachments/assets/913a0fa0-3e8d-473f-bb64-003d44915be0" />

# Solution

Change the `enum PrimitiveType` variant from `Named(Node<Identifier>)` to `Named { name: Node<Identifier> }` so that the fields nest differently.

Now the error correctly points out to the user that the type `NotARealType` can't be found. Much better error message that shows the user the problem.

# Alternative solutions

Stop the duplicated JSON fields altogether. I tried this previously in https://github.com/KittyCAD/modeling-app/pull/4369 but it was very involved, and I didn't think it was worth it. Maybe I should reopen that PR and solve this properly.

Closes #7340

2025-06-03 20:05:40 -04:00

ast

Type ascription produces two incompatible fields (#7355 )

2025-06-03 20:05:40 -04:00

snapshots

KCL: End-exclusive ranges like [0..<10] (#7179 )

2025-05-22 22:13:27 -05:00

token

KCL: Use named fields for KclError (#7321 )

2025-06-02 14:30:57 -04:00

math.rs

Move the wasm lib, and cleanup rust directory and all references (#5585 )