Frank Noirot 49b78d726a Submit selection to command on unmount of selection arg input (#7047) ...

* Submit selection to command on unmount of selection arg input

This fixes #7024 by saving the user's selection to the command even if
they click another argument in the command palette's header. It does no
harm to save the selection to the argument, even if it's being torn down
because the user dismissed it has no negative effect.

* Refactor to not auto-submit before selection is cleared on mount

Thanks E2E test suite

* Update failing E2E tests with new behavior, which allows skip with preselection

---------

Co-authored-by: Pierre Jacquier <pierrejacquier39@gmail.com>

2025-05-19 13:21:43 -04:00

..

export-snapshots

Fix a couple issues with settings reset on web & electron (#3564)

2024-08-20 11:06:39 -07:00

fixtures

Remove Create with Text-to-CAD from toolbar, make commands in command palette more distinct (#7048)

2025-05-18 10:24:48 +00:00

lib

Skip TAB-disabled tests locally by default (#6601)

2025-04-30 15:32:37 -04:00

named-views.spec.ts-snapshots

Share file snapshots across platforms (#6282)

2025-04-14 13:26:52 +00:00

snapshot-tests.spec.ts-snapshots

Remove Create with Text-to-CAD from toolbar, make commands in command palette more distinct (#7048)

2025-05-18 10:24:48 +00:00

snapshots/prompt-to-edit

change to no longer parallel for edges (#6705)

2025-05-06 01:06:20 +00:00

testing-selections.spec.ts-snapshots

Kwargs: startProfileAt (#6424)

2025-04-25 21:01:35 +00:00

app-header-tests.spec.ts

#6457 Disable sharing for multi-file AST (#6583)

2025-05-01 14:01:08 -04:00

auth.spec.ts

Fix logout issue on desktop (#6450)

2025-04-24 15:29:17 -04:00

basic-sketch.spec.ts

Remove deprecated syntax (#6561)

2025-04-30 13:12:40 +12:00

boolean.spec.ts

Enable Boolean op deletion from the feature tree (#6637)

2025-05-02 15:34:21 -04:00

can-create-sketches-on-all-planes-and-their-back-sides.spec.ts

Kwargs: startProfileAt (#6424)

2025-04-25 21:01:35 +00:00

code-pane-and-errors.spec.ts

More consistent error handling in modelingMachine codemods (#6910)

2025-05-15 12:26:20 -04:00

command-bar-tests.spec.ts

Submit selection to command on unmount of selection arg input (#7047)

2025-05-19 13:21:43 -04:00

debug-pane.spec.ts

Kwargs: startProfileAt (#6424)

2025-04-25 21:01:35 +00:00

desktop-export.spec.ts

Accept multiple export toast messages to be visible (#6979)

2025-05-15 22:48:15 +00:00

editor-tests.spec.ts

Submit selection to command on unmount of selection arg input (#7047)

2025-05-19 13:21:43 -04:00

feature-tree-pane.spec.ts

Multi-profile sweeps and more robust edit flows in point-and-click (#6437)

2025-05-06 17:57:27 -04:00

file-tree.spec.ts

Remove skips to align with new way of opting-in tests (#6560)

2025-04-29 08:50:19 -04:00

import-ui.spec.ts

test the wasm side (#6726)

2025-05-07 03:04:34 +00:00

machines.spec.ts

~Maybe~ (Lee: ABSOLUTELY) use biome (#6327)

2025-04-15 10:11:25 -04:00

named-views.spec.ts

Remove skips to align with new way of opting-in tests (#6560)

2025-04-29 08:50:19 -04:00

native-file-menu.spec.ts

Remove Create with Text-to-CAD from toolbar, make commands in command palette more distinct (#7048)

2025-05-18 10:24:48 +00:00

null.spec.ts

Sort imports (#6101)

2025-04-02 06:54:26 +00:00

onboarding-tests.spec.ts

Deflake onboarding test (#6996)

2025-05-15 23:27:58 -04:00

playwright-deprecated.ts

Sort imports (#6101)

2025-04-02 06:54:26 +00:00

point-click-assemblies.spec.ts

Remove fixme on foreign import assembly test (#6735)

2025-05-07 09:56:03 -04:00

point-click.spec.ts

Submit selection to command on unmount of selection arg input (#7047)

2025-05-19 13:21:43 -04:00

projects.spec.ts

bump modeling-cmds, nuke slow world (#6753)

2025-05-14 04:07:24 +00:00

prompt-to-edit-snapshot-tests.spec.ts

Make Modify with Text-to-CAD selection arg optional by honoring skip: false on non-required args (#6992)

2025-05-16 05:15:52 -04:00

prompt-to-edit.spec.ts

Make Modify with Text-to-CAD selection arg optional by honoring skip: false on non-required args (#6992)

2025-05-16 05:15:52 -04:00

regression-tests.spec.ts

Accept multiple export toast messages to be visible (#6979)

2025-05-15 22:48:15 +00:00

share-link.spec.ts

Add @web tag to new web-only tests for later CI use (#6784)

2025-05-08 17:58:05 -04:00

sketch-tests.spec.ts

Submit selection to command on unmount of selection arg input (#7047)

2025-05-19 13:21:43 -04:00

snapshot-tests.spec.ts

Backoff Reconnect (#6358)

2025-05-15 11:58:00 -04:00

storageStates.ts

Update onboarding to V1 browser and desktop flows (#6714)

2025-05-09 00:37:21 +00:00

stress-test.spec.ts

Franknoirot/adhoc/improve e2e (#6265)

2025-04-11 00:08:39 +00:00

test-network-and-connection-issues.spec.ts

Backoff Reconnect (#6358)

2025-05-15 11:58:00 -04:00

test-utils.test.ts

Switch to dynamically disabling broken tests (#6492)

2025-04-25 10:49:22 -04:00

test-utils.ts

Remove check on the Start Sketch button (#7004)

2025-05-16 10:38:18 -05:00

testing-camera-movement.spec.ts

Better, faster typo checker (#6716)

2025-05-07 12:48:23 -05:00

testing-constraints.spec.ts

profile start constrain overlays (#6795)

2025-05-10 12:29:41 +10:00

testing-gizmo.spec.ts

Remove deprecated syntax (#6561)

2025-04-30 13:12:40 +12:00

testing-perspective-toggle.spec.ts

Switch to dynamically disabling broken tests (#6492)

2025-04-25 10:49:22 -04:00

testing-samples-loading.spec.ts

fix pw test i turned off (#6921)

2025-05-14 04:36:52 +00:00

testing-segment-overlays.spec.ts

profile start constrain overlays (#6795)

2025-05-10 12:29:41 +10:00

testing-selections.spec.ts

Remove CallExpression support (#6639)

2025-05-02 16:08:12 -05:00

testing-settings.spec.ts

profile start constrain overlays (#6795)

2025-05-10 12:29:41 +10:00

text-to-cad-tests.spec.ts

Remove Create with Text-to-CAD from toolbar, make commands in command palette more distinct (#7048)

2025-05-18 10:24:48 +00:00

various.spec.ts

Submit selection to command on unmount of selection arg input (#7047)

2025-05-19 13:21:43 -04:00

zoo-test.ts

Shorten tronapp setup fail (#6362)

2025-04-24 06:35:57 +00:00