modeling-app

Files

Adam Chalmers 6aa588f09f Bug: KCL formatter removes 'fn' from closures: (#4718 )

# Problem

Before this PR, our formatter reformats
```
squares_out = reduce(arr, 0, fn (i, squares)  {
  return 1
})
```
to 
```
squares_out = reduce(arr, 0, (i, squares) {
  return 1
})
```
i.e. it removes the `fn` keyword from the closure. This keyword is required, so, our formatter turned working code into invalid code.

# Cause

When this closure parameter is formatted, the ExprContext is ::Decl, so `Expr::recast` skips adding the `fn` keyword. The reason it's ::Decl is because the `squares_out = ` declaration sets it, and no subsequent call sets the context to something else.

# Solution

When recasting a call expression, set the context for every argument to `ExprContext::Other`.

2024-12-09 19:13:49 -06:00

types

KCL docs: Remove FunctionExpression (#4633 )

2024-12-02 14:36:49 -06:00

abs.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

acos.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

angledLine.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

angledLineOfXLength.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

angledLineOfYLength.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

angledLineThatIntersects.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

angledLineToX.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

angledLineToY.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

angleToMatchLengthX.md

Fix description of angleToMatchLengthX (#4467 )

2024-11-13 09:04:35 -05:00

angleToMatchLengthY.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

arc.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

arcTo.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

asin.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

assert.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

assertEqual.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

assertGreaterThan.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

assertGreaterThanOrEq.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

assertLessThan.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

assertLessThanOrEq.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

atan.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

bezierCurve.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

ceil.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

chamfer.md

Make = and => optional in function declarations (#4577 )

2024-11-27 15:46:58 +13:00

circle.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

close.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

cm.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

cos.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

e.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

extrude.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

fillet.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

floor.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

ft.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

getNextAdjacentEdge.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

getOppositeEdge.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

getPreviousAdjacentEdge.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

helix.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

hole.md

Make = and => optional in function declarations (#4577 )

2024-11-27 15:46:58 +13:00

hollow.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

import.md

Module/import upgrades (#4677 )

2024-12-06 13:16:04 -05:00

inch.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

index.md

Add tangentToEnd stdlib function (#4541 )

2024-11-25 18:07:03 +00:00

int.md

Make = and => optional in function declarations (#4577 )

2024-11-27 15:46:58 +13:00

KNOWN-ISSUES.md

Sketch on face of chamfer now works, added an example (#3876 )

2024-09-12 16:13:11 -07:00

lastSegX.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

lastSegY.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

legAngX.md

kcl std lib docs use handlebars now so making changes should be better (1st pass) (#4007 )

2024-09-27 10:37:46 -04:00

legAngY.md

kcl std lib docs use handlebars now so making changes should be better (1st pass) (#4007 )

2024-09-27 10:37:46 -04:00

legLen.md

kcl std lib docs use handlebars now so making changes should be better (1st pass) (#4007 )

2024-09-27 10:37:46 -04:00

line.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

lineTo.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

ln.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

loft.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

log2.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

log10.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

log.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

m.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

map.md

Bug: KCL formatter removes 'fn' from closures: (#4718 )

2024-12-09 19:13:49 -06:00

max.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

min.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

mirror2d.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

mm.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

modules.md

Update fn syntax in module docs (#4641 )

2024-12-03 19:47:21 +00:00

offsetPlane.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

patternCircular2d.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

patternCircular3d.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

patternLinear2d.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

patternLinear3d.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

patternTransform2d.md

Make = and => optional in function declarations (#4577 )

2024-11-27 15:46:58 +13:00

patternTransform.md

Make = and => optional in function declarations (#4577 )

2024-11-27 15:46:58 +13:00

pi.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

polar.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

polygon.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

pow.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

profileStart.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

profileStartX.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

profileStartY.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

push.md

Guptaarnav 2024 10 28 (#4341 )

2024-10-28 20:52:51 -04:00

reduce.md

Bug: KCL formatter removes 'fn' from closures: (#4718 )

2024-12-09 19:13:49 -06:00

rem.md

KCL: Keyword function calls for stdlib (#4647 )

2024-12-05 14:27:51 -06:00

revolve.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

round.md

Implicit conversion of round numbers to integers (#4542 )

2024-11-25 10:50:43 +13:00

segAng.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

segEnd.md

Make = and => optional in function declarations (#4577 )

2024-11-27 15:46:58 +13:00

segEndX.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

segEndY.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

segLen.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

segStart.md

Make = and => optional in function declarations (#4577 )

2024-11-27 15:46:58 +13:00

segStartX.md

KCL: More ways to reference paths (#4387 )

2024-11-05 14:10:35 -06:00

segStartY.md

KCL: More ways to reference paths (#4387 )

2024-11-05 14:10:35 -06:00

shell.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

sin.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

sqrt.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

startProfileAt.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

startSketchAt.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

startSketchOn.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

std.json

Bug: KCL formatter removes 'fn' from closures: (#4718 )

2024-12-09 19:13:49 -06:00

tan.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

tangentialArc.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

tangentialArcTo.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

tangentialArcToRelative.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

tangentToEnd.md

Add tangentToEnd stdlib function (#4541 )

2024-11-25 18:07:03 +00:00

tau.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

toDegrees.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

toRadians.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

types.md

Update fn syntax in KCL Types doc (#4640 )

2024-12-03 18:17:02 +00:00

xLine.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

xLineTo.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

yd.md

return errors back to user (#4075 )

2024-10-02 22:05:12 -07:00

yLine.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00

yLineTo.md

Support = in record initialisation (#4519 )

2024-11-24 20:21:55 +00:00